[jira] (MDEP-446) make available on command line for dependency:copy
[ https://jira.codehaus.org/browse/MDEP-446?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=352634#comment-352634 ] Thomas Wabner commented on MDEP-446: ah, ok. Whats about using the -Dartifact variable an add this as a optional additional parameter like: -Dartifact=groupid:artifactId:version:war:destFileName If the destFilename is not given as an parameter value for the 'artifact' parameter, the standard behaviour can be used. >From my understanding, the 'artifact' cmd parameter is more or less a >representation for . I do not know, if I can give more than one >'artifact' parameter. > make available on command line for dependency:copy > - > > Key: MDEP-446 > URL: https://jira.codehaus.org/browse/MDEP-446 > Project: Maven Dependency Plugin > Issue Type: Improvement > Components: copy >Affects Versions: 2.8 >Reporter: Thomas Wabner > Fix For: more-investigation > > > It would be nice to be able to specify the destFileName as parameter on > commandline, to copy a dependency. > This is currently only supported in the pom.xml configuration section for the > dependency plugin like: > > > ${project.groupId} > ${project.artifactId} > ${project.version} > ${project.packaging} > > ${project.build.finalName}.${project.packaging} > true > > > We want to have a option on command line, to specify the destFileName with a > parameter. > For example: > mvn dependency:copy -Dartifact=groupid:artifactId:version:war > -Dmdep.stripVersion=true -DoutputDirectory=/temp/ > -Dartifact.destFileName=result.war -- This message was sent by Atlassian JIRA (v6.1.6#6162)
[jira] (MDEP-459) Update maven-dependency-analyzer to 1.5
[ https://jira.codehaus.org/browse/MDEP-459?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karl-Heinz Marbaise reassigned MDEP-459: Assignee: Karl-Heinz Marbaise > Update maven-dependency-analyzer to 1.5 > --- > > Key: MDEP-459 > URL: https://jira.codehaus.org/browse/MDEP-459 > Project: Maven Dependency Plugin > Issue Type: Improvement >Affects Versions: 2.9 >Reporter: Karl-Heinz Marbaise >Assignee: Karl-Heinz Marbaise >Priority: Minor > Fix For: 2.9 > > > Update maven-dependency-analyzer to 1.5 > Release Notes maven-dependency-analyzer 1.5: > * Bugs: > ** [MSHARED-285] - Port tests to JUnit 4.11 > ** [MSHARED-307] - Performance: The implementation of DefaultClassAnalyzer > unnecessarily scans jar files bodies > ** [MSHARED-323] - DefaultProjectDependencyAnalyzer does not correctly > transform Files with Spaces to URLs > ** [MSHARED-327] - maven-dependency-analyzer not compatible with Java 8 -- This message was sent by Atlassian JIRA (v6.1.6#6162)
[jira] (MRELEASE-875) release:prepare does not commit pom.xml if not in the git root
[ https://jira.codehaus.org/browse/MRELEASE-875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=352638#comment-352638 ] Benson Margulies commented on MRELEASE-875: --- See https://gist.github.com/bimargulies/c82594b0b57f6ab19c51. These are logs and such from https://github.com/bimargulies/pom-file-name-tc.git. To use this, make a clone where you can write tags, cd to the 'second' directory, and run 'mvn release:prepare'. You will get no commits, no errors, and a useless tag. Note that it has repository declarations for a Unix/MacOSX repo to deliver to; this probably does not matter for release:prepare. Note that this has a .gitignore that covers release.properties and pom.xml.releaseBackup, so clearly the problem is _not_ git status yelping about those. > release:prepare does not commit pom.xml if not in the git root > -- > > Key: MRELEASE-875 > URL: https://jira.codehaus.org/browse/MRELEASE-875 > Project: Maven Release Plugin > Issue Type: Bug > Components: prepare, scm >Affects Versions: 2.5 > Environment: git 1.9.0 >Reporter: john ten Den >Assignee: Dominik Bartholdi > > When the project pom.xml is not in the Git project root (f.e. in the "src" > directory) the pom.xml not committed and pushed (before tagging) > Commit of the pom.xml during release:prepare works fine if it is in the / > (root) of the git repository > Using the pom.xml in a subdirectory worked well with version 2.4.2 using git > 1.7. -- This message was sent by Atlassian JIRA (v6.1.6#6162)
[jira] (MRELEASE-875) release:prepare does not commit pom.xml if not in the git root
[ https://jira.codehaus.org/browse/MRELEASE-875?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dominik Bartholdi updated MRELEASE-875: --- Assignee: (was: Dominik Bartholdi) > release:prepare does not commit pom.xml if not in the git root > -- > > Key: MRELEASE-875 > URL: https://jira.codehaus.org/browse/MRELEASE-875 > Project: Maven Release Plugin > Issue Type: Bug > Components: prepare, scm >Affects Versions: 2.5 > Environment: git 1.9.0 >Reporter: john ten Den > > When the project pom.xml is not in the Git project root (f.e. in the "src" > directory) the pom.xml not committed and pushed (before tagging) > Commit of the pom.xml during release:prepare works fine if it is in the / > (root) of the git repository > Using the pom.xml in a subdirectory worked well with version 2.4.2 using git > 1.7. -- This message was sent by Atlassian JIRA (v6.1.6#6162)
[jira] (SCM-772) GitStatusConsumer does not properly handle quoted paths output from GitStatusCommand
[ https://jira.codehaus.org/browse/SCM-772?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gary Peskin updated SCM-772: Attachment: maven-scm.patch I've attached a proposed patch file. In getting further into this issue, I decided against using the "{{-z}}" option because it does not have each file on a separate line and switching to using it would cause too big of a change in the flow that drives the {{GitStatusConsumer.consumeLine}} method which is oriented towards a _line_ of output. Instead, I detect when the "{{--porcelain}}" output is surrounded by quotation marks and I dequote it in a manner consistent with the way that Git quoted it. The other main change was to get away from treating the file name as a URI since it is not a URI. A filename can contain characters that are not allowed in a URI and trying to treat a filename as a relative URI is not a good fit. Please review this and let me know what you think and if additional revisions are required. Thanks. > GitStatusConsumer does not properly handle quoted paths output from > GitStatusCommand > > > Key: SCM-772 > URL: https://jira.codehaus.org/browse/SCM-772 > Project: Maven SCM > Issue Type: Bug > Components: maven-scm-provider-git >Affects Versions: 1.9, 1.9.1 > Environment: All >Reporter: Gary Peskin > Attachments: maven-scm.patch > > > We have several files in our repository with spaces in the file name. Even > with --porcelain specified, the filename appears with quotes around it. Here > is an example: > {noformat} > M src/main/webapp/admin-index.html > M src/main/webapp/adminhelp/en_US/css/AboutThisBook.css > M "src/main/webapp/adminhelp/en_US/css/Appendix A Role Manager Defs.css" > {noformat} > This messes up the regular expression parsing in GitStatusConsumer. > A better approach would be to modify GitStatusCommand to specify the > {{"\-z"}} option instead of the {{"--porcelain"}} option. This option is > specifically designed to generate machine parseable output from the git > status command. This would necessitate changes to GitStatusConsumer but > would allow the elimination of all of the regex parsing in GitStatusConsumer > making for a more reliable solution. > If you'd like, please let me know and I can work up a patch for the changes > to these two classes and send it on. -- This message was sent by Atlassian JIRA (v6.1.6#6162)
[jira] (MRELEASE-767) releasing flat multi-module projects using git
[ https://jira.codehaus.org/browse/MRELEASE-767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=352657#comment-352657 ] Grégory Joseph commented on MRELEASE-767: - Same here, although I am trying to do {{mvn release:prepare -am -pl }} so presumably that's part of the problem (i have the same scm info in both the reactor and the top-most module of the list gathered with -am-pl) > releasing flat multi-module projects using git > -- > > Key: MRELEASE-767 > URL: https://jira.codehaus.org/browse/MRELEASE-767 > Project: Maven Release Plugin > Issue Type: Bug > Components: prepare >Affects Versions: 2.3.1 > Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 09:31:09-0800) > Maven home: /usr/share/maven > Java version: 1.6.0_31, vendor: Apple Inc. > Java home: /System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home > Default locale: en_US, platform encoding: MacRoman > OS name: "mac os x", version: "10.7.4", arch: "x86_64", family: "mac" >Reporter: Jeremy Norris >Assignee: Mark Struberg > Fix For: 2.5 > > > When releasing a project as follows: > ./parent/pom.xml > ./module-a/pom.xml > ./module-b/pom.xml > From the parent directory, with an scm config in the parent pom.xml (only) as > follows: > > scm:git:ssh://github.com/repox.git > > scm:git:ssh://github.com/repox.git > master > https://github.com/view/repox.git > > In org/apache/maven/shared/release/util/ReleaseUtils.java:182 it does this > indiscriminately: > url = realignScmUrl( parentLevels, url ); > This will trim the repo url from 'ssh://github.com/repox.git' -> > 'ssh://github.com', which will cause a failure when pushing the tag. > This type of realignment is not appropriate when using a git scm type. -- This message was sent by Atlassian JIRA (v6.1.6#6162)
[jira] (MRELEASE-767) releasing flat multi-module projects using git
[ https://jira.codehaus.org/browse/MRELEASE-767?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=352657#comment-352657 ] Grégory Joseph edited comment on MRELEASE-767 at 9/11/14 11:09 AM: --- Same here, although I am trying to do {{mvn release:prepare -am -pl }} so presumably that's part of the problem (i have the same scm info in both the reactor and the top-most module of the list gathered with -am-pl, and maven removes the last path item from it when trying to push) was (Author: gjoseph): Same here, although I am trying to do {{mvn release:prepare -am -pl }} so presumably that's part of the problem (i have the same scm info in both the reactor and the top-most module of the list gathered with -am-pl) > releasing flat multi-module projects using git > -- > > Key: MRELEASE-767 > URL: https://jira.codehaus.org/browse/MRELEASE-767 > Project: Maven Release Plugin > Issue Type: Bug > Components: prepare >Affects Versions: 2.3.1 > Environment: Apache Maven 3.0.3 (r1075438; 2011-02-28 09:31:09-0800) > Maven home: /usr/share/maven > Java version: 1.6.0_31, vendor: Apple Inc. > Java home: /System/Library/Java/JavaVirtualMachines/1.6.0.jdk/Contents/Home > Default locale: en_US, platform encoding: MacRoman > OS name: "mac os x", version: "10.7.4", arch: "x86_64", family: "mac" >Reporter: Jeremy Norris >Assignee: Mark Struberg > Fix For: 2.5 > > > When releasing a project as follows: > ./parent/pom.xml > ./module-a/pom.xml > ./module-b/pom.xml > From the parent directory, with an scm config in the parent pom.xml (only) as > follows: > > scm:git:ssh://github.com/repox.git > > scm:git:ssh://github.com/repox.git > master > https://github.com/view/repox.git > > In org/apache/maven/shared/release/util/ReleaseUtils.java:182 it does this > indiscriminately: > url = realignScmUrl( parentLevels, url ); > This will trim the repo url from 'ssh://github.com/repox.git' -> > 'ssh://github.com', which will cause a failure when pushing the tag. > This type of realignment is not appropriate when using a git scm type. -- This message was sent by Atlassian JIRA (v6.1.6#6162)
[jira] (MASSEMBLY-711) Add support for generating XZ compressed tarballs (.tar.xz)
Mat Booth created MASSEMBLY-711: --- Summary: Add support for generating XZ compressed tarballs (.tar.xz) Key: MASSEMBLY-711 URL: https://jira.codehaus.org/browse/MASSEMBLY-711 Project: Maven Assembly Plugin Issue Type: Improvement Affects Versions: 2.4.1 Reporter: Mat Booth I wish to add support for generating XZ compressed tarballs (.tar.xz) from an assembly descriptor. I will submit a patch for maven-assembly-plugin when PLXCOMP-239 is resolved and plexus-archiver has support for XZ. Please see PLXCOMP-239 for the plexus-archiver ticket for supporting XZ compression. -- This message was sent by Atlassian JIRA (v6.1.6#6162)
[jira] (SCM-776) Changelog single file with follow
Thibaud Lepretre created SCM-776: Summary: Changelog single file with follow Key: SCM-776 URL: https://jira.codehaus.org/browse/SCM-776 Project: Maven SCM Issue Type: Improvement Components: maven-scm-api, maven-scm-provider-git, maven-scm-provider-mercurial (hg) Affects Versions: 1.9.1 Environment: git 2.1.0 Reporter: Thibaud Lepretre Git (and hg) works with contents and not files so by default git log/whatchanged does not log any modification before rename/move. In order to print all log git (and hg) provides an option --follow. But its option must be only set with file and not directory. So is it possible to enhance changelog api in order to support: - Changelog single file - Ability to enable or disable --follow option -- This message was sent by Atlassian JIRA (v6.1.6#6162)
[jira] (SCM-776) Changelog single file with follow
[ https://jira.codehaus.org/browse/SCM-776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Thibaud Lepretre updated SCM-776: - Description: Git (and hg) works with contents and not files so by default git log/whatchanged does not log any modification before rename/move. In order to print all log git (and hg) provides an option --follow. But its option must be only set with file and not directory. So is it possible to enhance changelog api in order to support: - [API] Changelog single file - [GIT/HG providers] Ability to enable or disable --follow option was: Git (and hg) works with contents and not files so by default git log/whatchanged does not log any modification before rename/move. In order to print all log git (and hg) provides an option --follow. But its option must be only set with file and not directory. So is it possible to enhance changelog api in order to support: - Changelog single file - Ability to enable or disable --follow option > Changelog single file with follow > - > > Key: SCM-776 > URL: https://jira.codehaus.org/browse/SCM-776 > Project: Maven SCM > Issue Type: Improvement > Components: maven-scm-api, maven-scm-provider-git, > maven-scm-provider-mercurial (hg) >Affects Versions: 1.9.1 > Environment: git 2.1.0 >Reporter: Thibaud Lepretre > > Git (and hg) works with contents and not files so by default git > log/whatchanged does not log any modification before rename/move. > In order to print all log git (and hg) provides an option --follow. But its > option must be only set with file and not directory. > So is it possible to enhance changelog api in order to support: > - [API] Changelog single file > - [GIT/HG providers] Ability to enable or disable --follow option -- This message was sent by Atlassian JIRA (v6.1.6#6162)
[jira] (MPIR-252) Dependency Management report doesn't exclude system scoped dependencies
[ https://jira.codehaus.org/browse/MPIR-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=308366#comment-308366 ] Martijn Verburg edited comment on MPIR-252 at 9/11/14 12:21 PM: In the dependency management section: com.sun tools localVersion system ${toolsjar} Where ${toolsJar} is set by a property to be ${java.home}/../lib/tools.jar" was (Author: karianna): In the dependency management section: com.sun tools localVersion system ${toolsjar} Where ${toolsJar} is set by a property to be ${java.home}/..lib/tools.jar" > Dependency Management report doesn't exclude system scoped dependencies > --- > > Key: MPIR-252 > URL: https://jira.codehaus.org/browse/MPIR-252 > Project: Maven Project Info Reports Plugin > Issue Type: Bug > Components: dependency-management >Affects Versions: 2.5.1 > Environment: Mac OS X 10.7.2, Maven 3.0.4, JDK 1.7.0_06 / JDK 1.6.0_34 >Reporter: Martijn Verburg > > {noformat} > [WARNING] Unable to create Maven project for com.sun:tools:pom:localVersion > from repository. > org.apache.maven.project.ProjectBuildingException: Error resolving project > artifact: Failure to find com.sun:tools:pom:localVersion in > http://ci.jclarity.com:8081/nexus/content/groups/public/ was cached in the > local repository, resolution will not be reattempted until the update > interval of jclarity-central has elapsed or updates are forced for project > com.sun:tools:pom:localVersion > at > org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:296) > at > org.apache.maven.project.DefaultMavenProjectBuilder.buildFromRepository(DefaultMavenProjectBuilder.java:236) > at > org.apache.maven.project.DefaultMavenProjectBuilder.buildFromRepository(DefaultMavenProjectBuilder.java:251) > at > org.apache.maven.report.projectinfo.dependencies.RepositoryUtils.getMavenProjectFromRepository(RepositoryUtils.java:298) > at > org.apache.maven.report.projectinfo.dependencies.renderer.DependencyManagementRenderer.getDependencyRow(DependencyManagementRenderer.java:237) > at > org.apache.maven.report.projectinfo.dependencies.renderer.DependencyManagementRenderer.renderDependenciesForScope(DependencyManagementRenderer.java:204) > at > org.apache.maven.report.projectinfo.dependencies.renderer.DependencyManagementRenderer.renderDependenciesForAllScopes(DependencyManagementRenderer.java:157) > at > org.apache.maven.report.projectinfo.dependencies.renderer.DependencyManagementRenderer.renderSectionProjectDependencies(DependencyManagementRenderer.java:146) > at > org.apache.maven.report.projectinfo.dependencies.renderer.DependencyManagementRenderer.renderBody(DependencyManagementRenderer.java:132) > at > org.apache.maven.reporting.AbstractMavenReportRenderer.render(AbstractMavenReportRenderer.java:79) > at > org.apache.maven.report.projectinfo.DependencyManagementReport.executeReport(DependencyManagementReport.java:112) > at > org.apache.maven.reporting.AbstractMavenReport.generate(AbstractMavenReport.java:190) > at > org.apache.maven.plugins.site.ReportDocumentRenderer.renderDocument(ReportDocumentRenderer.java:219) > at > org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.renderModule(DefaultSiteRenderer.java:319) > at > org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.render(DefaultSiteRenderer.java:135) > at > org.apache.maven.plugins.site.SiteMojo.renderLocale(SiteMojo.java:175) > at org.apache.maven.plugins.site.SiteMojo.execute(SiteMojo.java:138) > at > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:101) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145) > at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84) > at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59) > at > org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183) > at > org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161) > at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:320) > at org.apache.maven.DefaultMaven.exec
[jira] (MPIR-252) Dependency Management report doesn't exclude system scoped dependencies
[ https://jira.codehaus.org/browse/MPIR-252?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=308366#comment-308366 ] Martijn Verburg edited comment on MPIR-252 at 9/11/14 12:21 PM: In the dependency management section: ``` com.sun tools localVersion system ${toolsjar} ``` Where `${toolsJar}` is set by a property to be `${java.home}/../lib/tools.jar` was (Author: karianna): In the dependency management section: com.sun tools localVersion system ${toolsjar} Where ${toolsJar} is set by a property to be ${java.home}/../lib/tools.jar" > Dependency Management report doesn't exclude system scoped dependencies > --- > > Key: MPIR-252 > URL: https://jira.codehaus.org/browse/MPIR-252 > Project: Maven Project Info Reports Plugin > Issue Type: Bug > Components: dependency-management >Affects Versions: 2.5.1 > Environment: Mac OS X 10.7.2, Maven 3.0.4, JDK 1.7.0_06 / JDK 1.6.0_34 >Reporter: Martijn Verburg > > {noformat} > [WARNING] Unable to create Maven project for com.sun:tools:pom:localVersion > from repository. > org.apache.maven.project.ProjectBuildingException: Error resolving project > artifact: Failure to find com.sun:tools:pom:localVersion in > http://ci.jclarity.com:8081/nexus/content/groups/public/ was cached in the > local repository, resolution will not be reattempted until the update > interval of jclarity-central has elapsed or updates are forced for project > com.sun:tools:pom:localVersion > at > org.apache.maven.project.DefaultProjectBuilder.build(DefaultProjectBuilder.java:296) > at > org.apache.maven.project.DefaultMavenProjectBuilder.buildFromRepository(DefaultMavenProjectBuilder.java:236) > at > org.apache.maven.project.DefaultMavenProjectBuilder.buildFromRepository(DefaultMavenProjectBuilder.java:251) > at > org.apache.maven.report.projectinfo.dependencies.RepositoryUtils.getMavenProjectFromRepository(RepositoryUtils.java:298) > at > org.apache.maven.report.projectinfo.dependencies.renderer.DependencyManagementRenderer.getDependencyRow(DependencyManagementRenderer.java:237) > at > org.apache.maven.report.projectinfo.dependencies.renderer.DependencyManagementRenderer.renderDependenciesForScope(DependencyManagementRenderer.java:204) > at > org.apache.maven.report.projectinfo.dependencies.renderer.DependencyManagementRenderer.renderDependenciesForAllScopes(DependencyManagementRenderer.java:157) > at > org.apache.maven.report.projectinfo.dependencies.renderer.DependencyManagementRenderer.renderSectionProjectDependencies(DependencyManagementRenderer.java:146) > at > org.apache.maven.report.projectinfo.dependencies.renderer.DependencyManagementRenderer.renderBody(DependencyManagementRenderer.java:132) > at > org.apache.maven.reporting.AbstractMavenReportRenderer.render(AbstractMavenReportRenderer.java:79) > at > org.apache.maven.report.projectinfo.DependencyManagementReport.executeReport(DependencyManagementReport.java:112) > at > org.apache.maven.reporting.AbstractMavenReport.generate(AbstractMavenReport.java:190) > at > org.apache.maven.plugins.site.ReportDocumentRenderer.renderDocument(ReportDocumentRenderer.java:219) > at > org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.renderModule(DefaultSiteRenderer.java:319) > at > org.apache.maven.doxia.siterenderer.DefaultSiteRenderer.render(DefaultSiteRenderer.java:135) > at > org.apache.maven.plugins.site.SiteMojo.renderLocale(SiteMojo.java:175) > at org.apache.maven.plugins.site.SiteMojo.execute(SiteMojo.java:138) > at > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:101) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153) > at > org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145) > at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84) > at > org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59) > at > org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183) > at > org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161) > at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:320) > at org.apache.maven.Default
[jira] (SCM-772) GitStatusConsumer does not properly handle quoted paths output from GitStatusCommand
[ https://jira.codehaus.org/browse/SCM-772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=352666#comment-352666 ] Robert Scholte commented on SCM-772: If I recall correctly, URI gave us an easy way to calculate the relative path without having OS issues. Be aware that when using File on Windows the pathseparator is \. It's a pretty big patch, so it'll take some time to verify it. > GitStatusConsumer does not properly handle quoted paths output from > GitStatusCommand > > > Key: SCM-772 > URL: https://jira.codehaus.org/browse/SCM-772 > Project: Maven SCM > Issue Type: Bug > Components: maven-scm-provider-git >Affects Versions: 1.9, 1.9.1 > Environment: All >Reporter: Gary Peskin > Attachments: maven-scm.patch > > > We have several files in our repository with spaces in the file name. Even > with --porcelain specified, the filename appears with quotes around it. Here > is an example: > {noformat} > M src/main/webapp/admin-index.html > M src/main/webapp/adminhelp/en_US/css/AboutThisBook.css > M "src/main/webapp/adminhelp/en_US/css/Appendix A Role Manager Defs.css" > {noformat} > This messes up the regular expression parsing in GitStatusConsumer. > A better approach would be to modify GitStatusCommand to specify the > {{"\-z"}} option instead of the {{"--porcelain"}} option. This option is > specifically designed to generate machine parseable output from the git > status command. This would necessitate changes to GitStatusConsumer but > would allow the elimination of all of the regex parsing in GitStatusConsumer > making for a more reliable solution. > If you'd like, please let me know and I can work up a patch for the changes > to these two classes and send it on. -- This message was sent by Atlassian JIRA (v6.1.6#6162)
[jira] (SCM-772) GitStatusConsumer does not properly handle quoted paths output from GitStatusCommand
[ https://jira.codehaus.org/browse/SCM-772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=352667#comment-352667 ] Gary Peskin commented on SCM-772: - I think you'll find that most of the patch is just enhancing the testing components. I agree that the URI does give an easy way to calculate the relative path. However, using the URI approach failed in my use case due to the special characters. I made sure that the code still passed all of the tests on both Windows 7 and Amazon Linux. It would be great if you could find places where the new code fails and then I can add those to the test and enhance the code to take that into account. There is now a Path.relativize() method that calculates the relative path but the Path class didn't come in until Java SE 1.7 so I didn't use it. > GitStatusConsumer does not properly handle quoted paths output from > GitStatusCommand > > > Key: SCM-772 > URL: https://jira.codehaus.org/browse/SCM-772 > Project: Maven SCM > Issue Type: Bug > Components: maven-scm-provider-git >Affects Versions: 1.9, 1.9.1 > Environment: All >Reporter: Gary Peskin > Attachments: maven-scm.patch > > > We have several files in our repository with spaces in the file name. Even > with --porcelain specified, the filename appears with quotes around it. Here > is an example: > {noformat} > M src/main/webapp/admin-index.html > M src/main/webapp/adminhelp/en_US/css/AboutThisBook.css > M "src/main/webapp/adminhelp/en_US/css/Appendix A Role Manager Defs.css" > {noformat} > This messes up the regular expression parsing in GitStatusConsumer. > A better approach would be to modify GitStatusCommand to specify the > {{"\-z"}} option instead of the {{"--porcelain"}} option. This option is > specifically designed to generate machine parseable output from the git > status command. This would necessitate changes to GitStatusConsumer but > would allow the elimination of all of the regex parsing in GitStatusConsumer > making for a more reliable solution. > If you'd like, please let me know and I can work up a patch for the changes > to these two classes and send it on. -- This message was sent by Atlassian JIRA (v6.1.6#6162)