[
https://jira.codehaus.org/browse/SCM-772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=352667#comment-352667
]
Gary Peskin commented on SCM-772:
---------------------------------
I think you'll find that most of the patch is just enhancing the testing
components. I agree that the URI does give an easy way to calculate the
relative path. However, using the URI approach failed in my use case due to
the special characters. I made sure that the code still passed all of the
tests on both Windows 7 and Amazon Linux. It would be great if you could find
places where the new code fails and then I can add those to the test and
enhance the code to take that into account. There is now a Path.relativize()
method that calculates the relative path but the Path class didn't come in
until Java SE 1.7 so I didn't use it.
> GitStatusConsumer does not properly handle quoted paths output from
> GitStatusCommand
> ------------------------------------------------------------------------------------
>
> Key: SCM-772
> URL: https://jira.codehaus.org/browse/SCM-772
> Project: Maven SCM
> Issue Type: Bug
> Components: maven-scm-provider-git
> Affects Versions: 1.9, 1.9.1
> Environment: All
> Reporter: Gary Peskin
> Attachments: maven-scm.patch
>
>
> We have several files in our repository with spaces in the file name. Even
> with --porcelain specified, the filename appears with quotes around it. Here
> is an example:
> {noformat}
> M src/main/webapp/admin-index.html
> M src/main/webapp/adminhelp/en_US/css/AboutThisBook.css
> M "src/main/webapp/adminhelp/en_US/css/Appendix A Role Manager Defs.css"
> {noformat}
> This messes up the regular expression parsing in GitStatusConsumer.
> A better approach would be to modify GitStatusCommand to specify the
> {{"\-z"}} option instead of the {{"--porcelain"}} option. This option is
> specifically designed to generate machine parseable output from the git
> status command. This would necessitate changes to GitStatusConsumer but
> would allow the elimination of all of the regex parsing in GitStatusConsumer
> making for a more reliable solution.
> If you'd like, please let me know and I can work up a patch for the changes
> to these two classes and send it on.
--
This message was sent by Atlassian JIRA
(v6.1.6#6162)
