Re: [PR] Fix for add char and token filters in Luke Analysis tab [lucene]
dweiss merged PR #14682: URL: https://github.com/apache/lucene/pull/14682 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Fix for add char and token filters in Luke Analysis tab [lucene]
pseudo-nymous commented on PR #14682: URL: https://github.com/apache/lucene/pull/14682#issuecomment-2888961089 Happy to contribute! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [I] Filters cannot be set in Analysis [lucene]
dweiss closed issue #14649: Filters cannot be set in Analysis URL: https://github.com/apache/lucene/issues/14649 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Fix for add char and token filters in Luke Analysis tab [lucene]
dweiss commented on PR #14682: URL: https://github.com/apache/lucene/pull/14682#issuecomment-2888960145 Thank you! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] tests: decrease maximum number of threads in seq number test to avoid OOM [lucene]
rmuir merged PR #14670: URL: https://github.com/apache/lucene/pull/14670 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] build: configure 3 retries for all gradle Download tasks [lucene]
rmuir merged PR #14653: URL: https://github.com/apache/lucene/pull/14653 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] upgrade from rat 0.14 to rat 0.15 [lucene]
rmuir merged PR #14648: URL: https://github.com/apache/lucene/pull/14648 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] deps(java): bump org.apache.rat:apache-rat from 0.14 to 0.16.1 [lucene]
github-actions[bot] commented on PR #14582: URL: https://github.com/apache/lucene/pull/14582#issuecomment-2888991972 This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog-check label to it and you will stop receiving this reminder on future updates to the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [I] gradle-wrapper.jar http 429 (too many requests) from github [lucene]
dweiss closed issue #14683: gradle-wrapper.jar http 429 (too many requests) from github URL: https://github.com/apache/lucene/issues/14683 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Use shasum on macosx and avoid checking the checksum if the wrapper file doesn't exist [lucene]
rmuir commented on code in PR #14684:
URL: https://github.com/apache/lucene/pull/14684#discussion_r2094599378
##
gradlew:
##
@@ -222,7 +222,12 @@ if [ "$cygwin" = "true" -o "$msys" = "true" ] ; then
fi
GRADLE_WRAPPER_JAR="$APP_HOME/gradle/wrapper/gradle-wrapper.jar"
-if ! ( cd "$APP_HOME/gradle/wrapper" && sha256sum --status -c
"${GRADLE_WRAPPER_JAR}.sha256" ); then
+if [ "$darwin" ]; then
Review Comment:
and it will also probably still "happen" to work with the bug on linux
systems... but only if they happen to have perl installed (thats where the
`shasum` will come from)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Use shasum on macosx and avoid checking the checksum if the wrapper file doesn't exist [lucene]
dweiss commented on code in PR #14684:
URL: https://github.com/apache/lucene/pull/14684#discussion_r2094599576
##
gradlew:
##
@@ -222,7 +222,12 @@ if [ "$cygwin" = "true" -o "$msys" = "true" ] ; then
fi
GRADLE_WRAPPER_JAR="$APP_HOME/gradle/wrapper/gradle-wrapper.jar"
-if ! ( cd "$APP_HOME/gradle/wrapper" && sha256sum --status -c
"${GRADLE_WRAPPER_JAR}.sha256" ); then
+if [ "$darwin" ]; then
Review Comment:
Darn, sure. Fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Use shasum on macosx and avoid checking the checksum if the wrapper file doesn't exist [lucene]
github-actions[bot] commented on PR #14684: URL: https://github.com/apache/lucene/pull/14684#issuecomment-2889150241 This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog-check label to it and you will stop receiving this reminder on future updates to the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Use shasum on macosx and avoid checking the checksum if the wrapper file doesn't exist [lucene]
dweiss commented on PR #14684: URL: https://github.com/apache/lucene/pull/14684#issuecomment-2889150872 Ok, both linux and mac seem to work fine after your tweak (and with cached gradle-wrapper.jar, so I assume the checksum command has been triggered) -  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Use shasum on macosx and avoid checking the checksum if the wrapper file doesn't exist [lucene]
rmuir commented on PR #14684: URL: https://github.com/apache/lucene/pull/14684#issuecomment-2889155275 on the mac it has this `shasum` just due to perl, so I think that's all that is happening. Not sure if it requires `xcode` installation to be present? But I guess here it is more common, than having an updated OS? On my mac i have BSD-based `sha256sum` installed with the OS, no coreutils installation needed. But they must have added this only recently to the macos? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [I] gradle-wrapper.jar http 429 (too many requests) from github [lucene]
dweiss commented on issue #14683: URL: https://github.com/apache/lucene/issues/14683#issuecomment-2889003536 For github workflows, we could configure regular gh caching just on this file (and keyed by gradle-wrapper.jar.sha256). Alternatively, we could put gradle-wrapper.jar on Lucene's own data service (aws). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[I] gradle-wrapper.jar http 429 (too many requests) from github [lucene]
dweiss opened a new issue, #14683: URL: https://github.com/apache/lucene/issues/14683 ### Description We see more of these. I'll add http 429 to WrapperDownloader but we may think of another way to do it, eventually. ### Version and environment details _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [I] gradle-wrapper.jar http 429 (too many requests) from github [lucene]
rmuir commented on issue #14683: URL: https://github.com/apache/lucene/issues/14683#issuecomment-2889003464 it is caused by the rate limit changes on GH side. https://github.blog/changelog/2025-05-08-updated-rate-limits-for-unauthenticated-requests/ Can we cache this binary somehow to avoid them? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [I] gradle-wrapper.jar http 429 (too many requests) from github [lucene]
dweiss commented on issue #14683: URL: https://github.com/apache/lucene/issues/14683#issuecomment-2889005053 I need to leave now but will try the caching trick later. I would place this jar on Lucene's data storage but am afraid of abuse by other projects. ;) There is a long story of requests for this and gradle inc. doesn't seem to be interested. https://github.com/gradle/gradle/issues/18718 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[PR] Use shasum on macosx and avoid checking the checksum if the wrapper file doesn't exist [lucene]
dweiss opened a new pull request, #14684: URL: https://github.com/apache/lucene/pull/14684 I just noticed that sha256sum is not present on github's mac vms. https://github.com/actions/runner-images/issues/90 This patch switches to using shasum on darwin and adds a pre-check to see if the file exists at all (otherwise shasum emits a warning, regardless of the ```--status``` flag). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [I] gradle-wrapper.jar http 429 (too many requests) from github [lucene]
dweiss commented on issue #14683: URL: https://github.com/apache/lucene/issues/14683#issuecomment-2889147432 It is a good idea indeed. If the problem persists, I'll do it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Use shasum on macosx and avoid checking the checksum if the wrapper file doesn't exist [lucene]
github-actions[bot] commented on PR #14684: URL: https://github.com/apache/lucene/pull/14684#issuecomment-2889147213 This PR does not have an entry in lucene/CHANGES.txt. Consider adding one. If the PR doesn't need a changelog entry, then add the skip-changelog-check label to it and you will stop receiving this reminder on future updates to the PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [I] gradle-wrapper.jar http 429 (too many requests) from github [lucene]
dweiss commented on issue #14683: URL: https://github.com/apache/lucene/issues/14683#issuecomment-2889148906 Seems like it's working -  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Use shasum on macosx and avoid checking the checksum if the wrapper file doesn't exist [lucene]
rmuir commented on code in PR #14684:
URL: https://github.com/apache/lucene/pull/14684#discussion_r2094599073
##
gradlew:
##
@@ -222,7 +222,12 @@ if [ "$cygwin" = "true" -o "$msys" = "true" ] ; then
fi
GRADLE_WRAPPER_JAR="$APP_HOME/gradle/wrapper/gradle-wrapper.jar"
-if ! ( cd "$APP_HOME/gradle/wrapper" && sha256sum --status -c
"${GRADLE_WRAPPER_JAR}.sha256" ); then
+if [ "$darwin" ]; then
Review Comment:
I'm pretty sure this will execute always as written, even when
`darwin=false`.
I would instead use it the same way as the variable is used elsewhere in the
script, without putting it inside of `test`:
```suggestion
if "$darwin"; then
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Use shasum on macosx and avoid checking the checksum if the wrapper file doesn't exist [lucene]
dweiss merged PR #14684: URL: https://github.com/apache/lucene/pull/14684 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Use shasum on macosx and avoid checking the checksum if the wrapper file doesn't exist [lucene]
dweiss commented on PR #14684: URL: https://github.com/apache/lucene/pull/14684#issuecomment-2889161433 I've no idea, to be honest. I also have sha256sum on my mac but it's relatively new... hard to tell where it comes from. I went with the suggestion on that gh issue I referenced. I don't think it'll hurt anyone. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [I] Nightly benchmark regression on 2025.05.01 [lucene]
mikemccand commented on issue #14630: URL: https://github.com/apache/lucene/issues/14630#issuecomment-2889212582 OK thank you @jpountz and @rmuir! Downgrading the kernel to 6.12.4 indeed recovered our lost performance, so it looks like that change in HZ (how many time slices the Linux scheduler divides each second into) from 300 (Arch Linux) -> 1000 was the cause of our slowdown. It's surprising it has such a big impact ... seems maybe we all might look into tuning this HZ in our production clusters! I added annotations (see `IG`, `IH`, and `II`, e.g. on the [`NumericRangeQuery (int)` task](https://benchmarks.mikemccandless.com/IntNRQ.html). I will put everything back (upgraded kernel, Lucene back on `main`, Java back on 24), so we accept and just annotate this performance impact. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Fix for add char and token filters in Luke Analysis tab [lucene]
dweiss commented on PR #14682: URL: https://github.com/apache/lucene/pull/14682#issuecomment-277887 This is a bug - thank you. Could you also add a CHANGES.txt entry under 10.3.0? I'll merge and backport. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Support adaptive refresh in Searcher Managers. [lucene]
vigyasharma merged PR #14443: URL: https://github.com/apache/lucene/pull/14443 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
Re: [PR] Add Query for reranking KnnFloatVectorQuery with full-precision vectors [lucene]
vigyasharma commented on PR #14009: URL: https://github.com/apache/lucene/pull/14009#issuecomment-2889130972 > The graph is a bit confusing, but the dots are the oversample (from 1 to 5). This is the piece I was missing! Can we edit the [benchmark comment](https://github.com/apache/lucene/pull/14009#issuecomment-2502665806) and add a line saying each dot represent oversample factor (from 1 to 6, i count 6 dots). So 4x oversample with 1_bit outperforms 2x oversample with 7_bit, in both latency and recall. And 3x oversample with 4_bit has better recall and latency than 7_bit with no oversample. Sorry I'm late to the party. Will look at the PR and benchmark more closely and try to think of latency laggers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
