[GitHub] [lucene] uschindler commented on issue #12396: Make ForUtil Vectorized
uschindler commented on issue #12396: URL: https://github.com/apache/lucene/issues/12396#issuecomment-1606834703 In my opinion, the best would be to proceed here without integrating in Lucene and I can have a look at the code. The provider interfaces in Lucene are still package private, so theres poissibility to do some changes. As said before, for all vector operations there should only be one provider class with basically two implementations in Lucene (VectorUtilDefaultProvider and VectorUtilPanamaProvider, one for each java version). Actually if the code is nicely isolated from the rest of Lucene's code it should not be too complicated to include it. I will take care of that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] javanna merged pull request #12385: Revert "Parallelize knn query rewrite across slices rather than segments
javanna merged PR #12385: URL: https://github.com/apache/lucene/pull/12385 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] romseygeek merged pull request #12388: Enable boosts on JoinUtil queries
romseygeek merged PR #12388: URL: https://github.com/apache/lucene/pull/12388 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] stefanvodita commented on pull request #12397: Remove redundant `throws` declarations
stefanvodita commented on PR #12397: URL: https://github.com/apache/lucene/pull/12397#issuecomment-1607296538 It looks like the automatic checker caught some more unused declared exceptions. Not sure why I didn’t catch these when running `./gradlew check`. I’ll investigate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] sohami commented on pull request #12374: Add CachingLeafSlicesSupplier to compute the LeafSlices for concurrent segment search
sohami commented on PR #12374: URL: https://github.com/apache/lucene/pull/12374#issuecomment-1607787911 @jpountz Gentle reminder for the review -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] mkhludnev commented on pull request #12397: Remove redundant `throws` declarations
mkhludnev commented on PR #12397: URL: https://github.com/apache/lucene/pull/12397#issuecomment-1607798359 Won't it change signature in an incompatible way? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] stefanvodita commented on pull request #12397: Remove redundant `throws` declarations
stefanvodita commented on PR #12397: URL: https://github.com/apache/lucene/pull/12397#issuecomment-1607837430 It would. I think there’s three categories of methods as far as this change is concerned: 1. Methods the user can't override. We can safely change all of these. 2. Methods the user can override. 1. Those where the user should not override and throw the exception. We can change these in the next major version. 2. Those where the user is expected to override and throw the exception. We have to keep them. I don't know if cases 2.i. and 2.ii. actually exist. For now, I can try to take care of case 1. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] benwtrent commented on a diff in pull request #12397: Remove redundant `throws` declarations
benwtrent commented on code in PR #12397:
URL: https://github.com/apache/lucene/pull/12397#discussion_r1242472556
##
lucene/analysis/common/src/java/org/apache/lucene/analysis/synonym/word2vec/Word2VecModel.java:
##
@@ -88,7 +87,7 @@ public int size() {
}
@Override
- public RandomAccessVectorValues copy() throws IOException {
+ public RandomAccessVectorValues copy() {
Review Comment:
This is an example of one you cannot remove. The class is `public` and not
final. So somebody could override the class and thus override this method.
` exports org.apache.lucene.analysis.synonym.word2vec;` also indicates its
exported in the public API for this Apache Lucene.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] mayya-sharipova commented on issue #11507: Increase the number of dims for KNN vectors to 2048 [LUCENE-10471]
mayya-sharipova commented on issue #11507: URL: https://github.com/apache/lucene/issues/11507#issuecomment-1607892454 I would like to renew the issue in light of the recent [integration of incubating Panama Vector API](https://github.com/apache/lucene/pull/12311), as indexing of vectors with it much faster. We run a benchmarking test, and indexing a dataset of vectors of 1536 dims was slightly faster than indexing of 1024 dims. This gives us enough confidence to extend max dims to 2048. ### Test environment - Dataset: - [nq](https://huggingface.co/datasets/BeIR/nq) dataset with `text` field embedded with OpenAI `text-embedding-ada-002` model, 1536 dims - [KnnGraphTester](https://github.com/apache/lucene/blob/branch_9_7/lucene/core/src/test/org/apache/lucene/util/hnsw/KnnGraphTester.java) - maxConn: 16, beamWidthIndex: 100 - Apple M1 laptop ### Test1: - Lucene 9.7 branch - Panama Vector API not enabled - vector dims=1024 (OpenAi vectors that were cut off to first 1024 dims) - Results: Indexed 2680961 documents in **3287s** Details ``` java -cp "lib/*:classes" -Xmx16g -Xms16g org.apache.lucene.util.hnsw.KnnGraphTester -dim 1024 -ndoc 2680961 -reindex -docs vectors_dims1024.bin -maxConn 16 -beamWidthIndex 100 creating index in vectors_dims1024.bin-16-100.index MS 0 [2023-06-26T11:10:24.765857Z; main]: initDynamicDefaults maxThreadCount=4 maxMergeCount=9 IFD 0 [2023-06-26T11:10:24.782017Z; main]: init: current segments file is "segments"; deletionPolicy=org.apache.lucene.index.KeepOnlyLastCommitDeletionPolicy@646d64ab IFD 0 [2023-06-26T11:10:24.783554Z; main]: now delete 0 files: [] IFD 0 [2023-06-26T11:10:24.784291Z; main]: now checkpoint "" [0 segments ; isCommit = false] IFD 0 [2023-06-26T11:10:24.784338Z; main]: now delete 0 files: [] IFD 0 [2023-06-26T11:10:24.785377Z; main]: 0 ms to checkpoint IW 0 [2023-06-26T11:10:24.785523Z; main]: init: create=true reader=null IW 0 [2023-06-26T11:10:24.790087Z; main]: dir=MMapDirectory@/Users/mayya/Elastic/knn/open_ai_vectors/vectors_dims1024.bin-16-100.index lockFactory=org.apache.lucene.store.NativeFSLockFactory@2c039ac6 index= version=9.7.0 analyzer=org.apache.lucene.analysis.standard.StandardAnalyzer ramBufferSizeMB=1994.0 maxBufferedDocs=-1 mergedSegmentWarmer=null delPolicy=org.apache.lucene.index.KeepOnlyLastCommitDeletionPolicy commit=null openMode=CREATE similarity=org.apache.lucene.search.similarities.BM25Similarity mergeScheduler=ConcurrentMergeScheduler: maxThreadCount=4, maxMergeCount=9, ioThrottle=true codec=Lucene95 infoStream=org.apache.lucene.util.PrintStreamInfoStream mergePolicy=[TieredMergePolicy: maxMergeAtOnce=10, maxMergedSegmentMB=5120.0, floorSegmentMB=2.0, forceMergeDeletesPctAllowed=10.0, segmentsPerTier=10.0, maxCFSSegmentSizeMB=8.796093022208E12, noCFSRatio=0.1, deletesPctAllowed=20.0 readerPooling=true perThreadHardLimitMB=1945 useCompoundFile=false commitOnClose=true indexSort=null checkPendingFlushOnUpdate=true softDeletesField=null maxFullFlushMergeWaitMillis=500 leafSorter=null eventListener=org.apache.lucene.index.IndexWriterEventListener$1@2173f6d9 writer=org.apache.lucene.index.IndexWriter@307f6b8c IW 0 [2023-06-26T11:10:24.790232Z; main]: MMapDirectory.UNMAP_SUPPORTED=true DWPT 0 [2023-06-26T11:19:47.652040Z; main]: flush postings as segment _0 numDocs=460521 IW 0 [2023-06-26T11:19:47.653761Z; main]: 1 ms to write norms IW 0 [2023-06-26T11:19:47.653954Z; main]: 0 ms to write docValues IW 0 [2023-06-26T11:19:47.654032Z; main]: 0 ms to write points IW 0 [2023-06-26T11:19:49.152263Z; main]: 1498 ms to write vectors IW 0 [2023-06-26T11:19:49.166472Z; main]: 14 ms to finish stored fields IW 0 [2023-06-26T11:19:49.166642Z; main]: 0 ms to write postings and finish vectors IW 0 [2023-06-26T11:19:49.167167Z; main]: 0 ms to write fieldInfos DWPT 0 [2023-06-26T11:19:49.167954Z; main]: new segment has 0 deleted docs DWPT 0 [2023-06-26T11:19:49.168030Z; main]: new segment has 0 soft-deleted docs DWPT 0 [2023-06-26T11:19:49.169572Z; main]: new segment has no vectors; no norms; no docValues; no prox; freqs DWPT 0 [2023-06-26T11:19:49.169670Z; main]: flushedFiles=[_0_Lucene95HnswVectorsFormat_0.vem, _0.fdm, _0_Lucene95HnswVectorsFormat_0.vec, _0.fdx, _0_Lucene95HnswVectorsFormat_0.vex, _0.fdt, _0.fnm] Indexed 2680961 documents in 3287s ``` ### Test2 - Lucene 9.7 branch with FloatVectorValues.MAX_DIMENSIONS set to 2048 - Panama Vector API enabled - dims=1536 - Results: Indexed 2680961 documents in **3141s** Details ``` java --add-modules jdk.incubator.vector -cp "lib/*:classes" -Xmx16g -Xms16g org.apache.lucene.util.hnsw.KnnGraphTester -dim 1536 -ndoc 2680961 -reindex -docs vectors.bin -maxConn 16 -beamWidthIndex 100 W
[GitHub] [lucene] javanna opened a new pull request, #12398: Share concurrent execution code into TaskExecutor
javanna opened a new pull request, #12398: URL: https://github.com/apache/lucene/pull/12398 Lucene has a non-public SliceExecutor abstraction that handles the execution of tasks when search is executed concurrently across leaf slices. Knn query vector rewrite has similar code that runs tasks concurrently, waits for them to be completed and handles eventual exceptions. This commit shares code among these two scenarios, to reduce code duplication as well as to ensure that further improvements are shared among them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] javanna commented on a diff in pull request #12183: Make some heavy query rewrites concurrent
javanna commented on code in PR #12183:
URL: https://github.com/apache/lucene/pull/12183#discussion_r1242565055
##
lucene/core/src/java/org/apache/lucene/index/TermStates.java:
##
@@ -86,19 +92,58 @@ public TermStates(
* @param needsStats if {@code true} then all leaf contexts will be visited
up-front to collect
* term statistics. Otherwise, the {@link TermState} objects will be
built only when requested
*/
- public static TermStates build(IndexReaderContext context, Term term,
boolean needsStats)
+ public static TermStates build(
+ IndexSearcher indexSearcher, IndexReaderContext context, Term term,
boolean needsStats)
throws IOException {
assert context != null && context.isTopLevel;
final TermStates perReaderTermState = new TermStates(needsStats ? null :
term, context);
if (needsStats) {
- for (final LeafReaderContext ctx : context.leaves()) {
-// if (DEBUG) System.out.println(" r=" + leaves[i].reader);
-TermsEnum termsEnum = loadTermsEnum(ctx, term);
-if (termsEnum != null) {
- final TermState termState = termsEnum.termState();
- // if (DEBUG) System.out.println("found");
- perReaderTermState.register(
- termState, ctx.ord, termsEnum.docFreq(),
termsEnum.totalTermFreq());
+ Executor executor = indexSearcher.getExecutor();
+ boolean isShutdown = false;
+ if (executor instanceof ExecutorService) {
+isShutdown = ((ExecutorService) executor).isShutdown();
+ }
+ if (executor != null && isShutdown == false) {
+// build term states concurrently
+List> tasks =
+context.leaves().stream()
+.map(
+ctx ->
+new FutureTask<>(
+() -> {
+ TermsEnum termsEnum = loadTermsEnum(ctx, term);
+ if (termsEnum != null) {
+final TermState termState =
termsEnum.termState();
+perReaderTermState.register(
+termState,
+ctx.ord,
+termsEnum.docFreq(),
+termsEnum.totalTermFreq());
+ }
+ return 0;
+}))
+.toList();
+for (FutureTask task : tasks) {
+ executor.execute(task);
+}
+for (FutureTask task : tasks) {
+ try {
+task.get();
+ } catch (InterruptedException | ExecutionException e) {
+throw new RuntimeException(e.getMessage());
+ }
+}
Review Comment:
I opened #12398 to share the execution code (executor.execute, future.get
and exception handling) and make it available for additional usecases to reuse.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] javanna commented on a diff in pull request #12183: Make some heavy query rewrites concurrent
javanna commented on code in PR #12183:
URL: https://github.com/apache/lucene/pull/12183#discussion_r1242567436
##
lucene/core/src/java/org/apache/lucene/index/TermStates.java:
##
@@ -86,19 +92,58 @@ public TermStates(
* @param needsStats if {@code true} then all leaf contexts will be visited
up-front to collect
* term statistics. Otherwise, the {@link TermState} objects will be
built only when requested
*/
- public static TermStates build(IndexReaderContext context, Term term,
boolean needsStats)
+ public static TermStates build(
+ IndexSearcher indexSearcher, IndexReaderContext context, Term term,
boolean needsStats)
throws IOException {
assert context != null && context.isTopLevel;
final TermStates perReaderTermState = new TermStates(needsStats ? null :
term, context);
if (needsStats) {
- for (final LeafReaderContext ctx : context.leaves()) {
-// if (DEBUG) System.out.println(" r=" + leaves[i].reader);
-TermsEnum termsEnum = loadTermsEnum(ctx, term);
-if (termsEnum != null) {
- final TermState termState = termsEnum.termState();
- // if (DEBUG) System.out.println("found");
- perReaderTermState.register(
- termState, ctx.ord, termsEnum.docFreq(),
termsEnum.totalTermFreq());
+ Executor executor = indexSearcher.getExecutor();
+ boolean isShutdown = false;
+ if (executor instanceof ExecutorService) {
+isShutdown = ((ExecutorService) executor).isShutdown();
+ }
+ if (executor != null && isShutdown == false) {
+// build term states concurrently
+List> tasks =
+context.leaves().stream()
+.map(
+ctx ->
+new FutureTask<>(
+() -> {
+ TermsEnum termsEnum = loadTermsEnum(ctx, term);
+ if (termsEnum != null) {
+final TermState termState =
termsEnum.termState();
+perReaderTermState.register(
+termState,
+ctx.ord,
+termsEnum.docFreq(),
+termsEnum.totalTermFreq());
+ }
+ return 0;
+}))
+.toList();
+for (FutureTask task : tasks) {
+ executor.execute(task);
Review Comment:
Thanks for the explanation, this makes sense to me. I reverted #12325 on
main and 9x (see #12385).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] stefanvodita commented on pull request #12397: Remove redundant `throws` declarations
stefanvodita commented on PR #12397: URL: https://github.com/apache/lucene/pull/12397#issuecomment-1608195952 Those are good points. What if we took a more targeted approach? Maybe we can remove unused `throws` from the tests as a step in the right direction. I’ve pushed a commit doing that. It’s a large diff, so beware, but I think it’s doing the right thing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] uschindler commented on pull request #12397: Remove redundant `throws` declarations
uschindler commented on PR #12397: URL: https://github.com/apache/lucene/pull/12397#issuecomment-1608414484 In general I would like to keep all tests with "throws Expection". This makes creating/modifying tests faster. I use a template whenever I create a new test. So please keep the tests as is. Thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] tflobbe merged pull request #12360: Update comment about IndexOptions ordinals
tflobbe merged PR #12360: URL: https://github.com/apache/lucene/pull/12360 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] zacharymorn commented on pull request #12194: [GITHUB-11915] Make Lucene smarter about long runs of matches via new API on DISI
zacharymorn commented on PR #12194:
URL: https://github.com/apache/lucene/pull/12194#issuecomment-1608695525
Thanks @jpountz for the feedback! On the second approach, I was actually
thinking something simpler, such as this
https://github.com/apache/lucene/pull/12194/commits/219beab1b1baea4950a3e47bc9bd46df32fef055.
I ran the benchmark tests after the change, and got the following results:
Index with sorting
Result 1:
```
TaskQPS baseline StdDevQPS
my_modified_version StdDevPct diff p-value
AndMedFilterMonth 2142.90 (7.1%) 1996.67
(5.0%) -6.8% ( -17% -5%) 0.000
AndHighHighDayTaxoFacets 13.99 (2.3%) 13.08
(2.3%) -6.5% ( -10% - -1%) 0.000
HighTermTitleSort 131.92 (2.5%) 124.03
(2.8%) -6.0% ( -10% -0%) 0.000
AndHighMedDayTaxoFacets 91.57 (2.0%) 86.87
(3.2%) -5.1% ( -10% -0%) 0.000
HighTermDayOfYearSort 235.50 (4.8%) 227.18
(4.1%) -3.5% ( -11% -5%) 0.012
MedTermDayTaxoFacets 72.51 (2.3%) 70.17
(2.5%) -3.2% ( -7% -1%) 0.000
HighTermMonthSort 3126.27 (3.2%) 3032.93
(3.8%) -3.0% ( -9% -4%) 0.007
Wildcard 280.45 (5.7%) 272.30
(5.7%) -2.9% ( -13% -8%) 0.107
OrHighMedDayTaxoFacets 22.17 (2.5%) 21.55
(2.4%) -2.8% ( -7% -2%) 0.000
HighTermTitleBDVSort 23.23 (2.9%) 22.59
(2.9%) -2.7% ( -8% -3%) 0.003
TermDTSort 198.40 (9.4%) 194.24
(9.1%) -2.1% ( -18% - 18%) 0.474
MedIntervalsOrdered 53.97 (13.6%) 52.88
(12.8%) -2.0% ( -24% - 28%) 0.629
MedSpanNear 172.23 (2.7%) 168.92
(2.4%) -1.9% ( -6% -3%) 0.018
BrowseMonthSSDVFacets 20.44 (5.9%) 20.09
(6.0%) -1.7% ( -12% - 10%) 0.360
Prefix3 879.87 (4.4%) 866.61
(4.5%) -1.5% ( -9% -7%) 0.284
HighSpanNear 50.36 (2.3%) 49.60
(1.9%) -1.5% ( -5% -2%) 0.022
LowSpanNear 372.08 (2.3%) 366.84
(1.7%) -1.4% ( -5% -2%) 0.030
AndHighLow 1852.63 (3.8%) 1829.62
(4.0%) -1.2% ( -8% -6%) 0.318
LowIntervalsOrdered9.32 (15.4%)9.21
(15.4%) -1.2% ( -27% - 35%) 0.811
HighIntervalsOrdered1.55 (20.5%)1.53
(20.6%) -1.1% ( -35% - 50%) 0.872
BrowseDayOfYearSSDVFacets 14.47 (4.8%) 14.33
(5.4%) -1.0% ( -10% -9%) 0.524
OrNotHighLow 1128.41 (4.1%) 1117.38
(3.9%) -1.0% ( -8% -7%) 0.438
OrHighNotHigh 492.96 (3.9%) 488.47
(4.3%) -0.9% ( -8% -7%) 0.486
MedPhrase 372.00 (2.7%) 368.75
(3.0%) -0.9% ( -6% -4%) 0.325
OrNotHighMed 628.90 (2.8%) 623.55
(2.5%) -0.9% ( -5% -4%) 0.310
OrHighNotLow 791.85 (3.8%) 785.12
(4.5%) -0.9% ( -8% -7%) 0.520
OrNotHighHigh 447.73 (2.9%) 444.15
(3.1%) -0.8% ( -6% -5%) 0.399
OrHighHigh 45.13 (4.0%) 44.78
(4.5%) -0.8% ( -8% -8%) 0.575
OrHighNotMed 543.72 (3.6%) 539.69
(4.2%) -0.7% ( -8% -7%) 0.545
HighTerm 946.86 (4.2%) 942.67
(3.8%) -0.4% ( -8% -7%) 0.727
LowTerm 1446.44 (5.6%) 1442.00
(5.9%) -0.3% ( -11% - 11%) 0.866
MedTerm 1064.71 (3.8%) 1061.77
(3.7%) -0.3% ( -7% -7%) 0.815
Fuzzy1 78.98 (6.5%) 78.77
(6.2%) -0.3% ( -12% - 13%) 0.896
BrowseDayOfYearTaxoFacets 14.60 (3.5%) 14.56
(3.0%) -0.2% ( -6% -6%) 0.808
OrHighLow 383.35 (3.5%) 382.47
(4.1%) -0.2% ( -7% -7%) 0.848
AndHighMed 419.38 (3.9%) 418.65
(3.4%) -0.2% ( -7% -7%) 0.879
LowSloppyPhrase 45.89 (1.9%) 45.85
(1.8%) -0.1% ( -3% -3%) 0.895
BrowseDateTaxoFacets 19.56 (2.2%) 19.55
(2.0%) -0.1% ( -4% -4%) 0.925
OrHighMed 53.51
[GitHub] [lucene] stefanvodita commented on pull request #12397: Remove redundant `throws` declarations
stefanvodita commented on PR #12397: URL: https://github.com/apache/lucene/pull/12397#issuecomment-1608879221 Thanks for the feedback Uwe. I thought changing the tests would be uncontroversial, but it sounds like you have a use-case for those exceptions. I’ll close this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] stefanvodita closed pull request #12397: Remove redundant `throws` declarations
stefanvodita closed pull request #12397: Remove redundant `throws` declarations URL: https://github.com/apache/lucene/pull/12397 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
