[GitHub] [lucene-solr] janhoy commented on pull request #2676: SOLR-16626: Upgrade to Netty 4.1.87.Final
janhoy commented on PR #2676: URL: https://github.com/apache/lucene-solr/pull/2676#issuecomment-1404725896 Ran the entire test suite. Looks good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] janhoy merged pull request #2676: SOLR-16626: Upgrade to Netty 4.1.87.Final
janhoy merged PR #2676: URL: https://github.com/apache/lucene-solr/pull/2676 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] jpountz opened a new pull request, #12113: Remove LogMergePolicy's boundary at the floor level.
jpountz opened a new pull request, #12113: URL: https://github.com/apache/lucene/pull/12113 `LogMergePolicy` has this boundary at the floor level that prevents merging segments above the minimum segment size with segments below this size. I cannot see a benefit from doing this, and no tests fail if I remove it, while this boundary has the downside of not running merges that seem legit to me. Should we remove this boundary check? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] jpountz commented on issue #12082: LeafFieldComparator setBottom not being called before compareBottom
jpountz commented on issue #12082: URL: https://github.com/apache/lucene/issues/12082#issuecomment-1404967722 It's been a long time, but I would guess that `setBottom` was put on `LeafFieldComparator` instead of `FieldComparator` because it is always called from a `LeafCollector` rather than a `Collector` (in contrast to e.g. `setTop`). It could make sense to move it to `Comparator`, but this would force `LeafCollectors` produced by top-field comparators to keep track of both the `FieldComparator` and the `LeafFieldComparator`. In the end I don't have a strong opinion on this question, there seem to be pros/cons with both having `setBottom` on `Comparator` and `LeafFieldComparator`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] jpountz commented on issue #11829: Reproducible TestShapeDocValues failure
jpountz commented on issue #11829: URL: https://github.com/apache/lucene/issues/11829#issuecomment-1405241519 @nknize I'm still seeing this failure once in a while, which seems to be related to a change of yours that I don't fully understand. Would you be able to look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] dantuzi closed pull request #12048: Move HNSW parameters to the HnswGraphBuilder class
dantuzi closed pull request #12048: Move HNSW parameters to the HnswGraphBuilder class URL: https://github.com/apache/lucene/pull/12048 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
