jpountz commented on issue #12082: URL: https://github.com/apache/lucene/issues/12082#issuecomment-1404967722
It's been a long time, but I would guess that `setBottom` was put on `LeafFieldComparator` instead of `FieldComparator` because it is always called from a `LeafCollector` rather than a `Collector` (in contrast to e.g. `setTop`). It could make sense to move it to `Comparator`, but this would force `LeafCollectors` produced by top-field comparators to keep track of both the `FieldComparator` and the `LeafFieldComparator`. In the end I don't have a strong opinion on this question, there seem to be pros/cons with both having `setBottom` on `Comparator` and `LeafFieldComparator`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
