[GitHub] [lucene] wjp719 opened a new pull request, #11995: enable fully directly copy merge/flush fdt files when index sorting
wjp719 opened a new pull request, #11995: URL: https://github.com/apache/lucene/pull/11995 when index sorting, fdt files needs to be decompressed and compressed according to new doc id order. This pr wants to add a docId offset index, so that we only copy origin fdt files to a new fdt file, and we only need to main the doc offset index according to the new doc id order. This can work in flush and merge process. This pr has two benefits: 1. now if index sorting, before flush, we need to write all origin uncompressed data to temp file, then read data back when flush. This pr can write final fdt file before flush, then write doc offset index when flush. This can reduce 30% IO throughput in our log scenario 2. improve 30% doc indexing performance in our log scenario the additional overhead is the new doc offset index files storage, 1% in our log scenario -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] wjp719 commented on pull request #11995: enable fully directly copy merge/flush fdt files when index sorting
wjp719 commented on PR #11995: URL: https://github.com/apache/lucene/pull/11995#issuecomment-1336157571 @jpountz Hi, can you help to review this pr, thanks a lot -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] kwrightapache commented on issue #11883: Spatial3d: Wrong intersection detected between small polygons
kwrightapache commented on issue #11883: URL: https://github.com/apache/lucene/issues/11883#issuecomment-1336165599 Ok, GeoConcavePolygon has been updated on main, and all changes have been pulled to branch_9x as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] xtonik opened a new issue, #11996: Replace custom String constructor from codepoints with constructor within java.lang.String class.
xtonik opened a new issue, #11996: URL: https://github.com/apache/lucene/issues/11996 ### Description Custom implementation is neither correct (see below) nor efficient (due to char array reallocation at least). True reason of creation custom implementation is according to related [git commit](https://github.com/apache/lucene/commit/972da5872fabbc0cd12fa2e12171be8e24f665fa) bugs presence in original implementation, but it seems, that they were already [fixed](https://bugs.openjdk.org/browse/JDK-6588260). Exact related commit message part is _fix sneaky bugs (workaround java's bug in new String(int[], int, int);_ without more specific information about bugs, so this must be verified whether all present bugs have been really fixed. Examples of incorrectness: - method argument `offset` is not checked to be positive - catching exception in normal program flow - throwing inappropriate exceptions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
