xtonik opened a new issue, #11996: URL: https://github.com/apache/lucene/issues/11996
### Description Custom implementation is neither correct (see below) nor efficient (due to char array reallocation at least). True reason of creation custom implementation is according to related [git commit](https://github.com/apache/lucene/commit/972da5872fabbc0cd12fa2e12171be8e24f665fa) bugs presence in original implementation, but it seems, that they were already [fixed](https://bugs.openjdk.org/browse/JDK-6588260). Exact related commit message part is _fix sneaky bugs (workaround java's bug in new String(int[], int, int);_ without more specific information about bugs, so this must be verified whether all present bugs have been really fixed. Examples of incorrectness: - method argument `offset` is not checked to be positive - catching exception in normal program flow - throwing inappropriate exceptions -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
