[GitHub] [lucene] jpountz opened a new pull request, #11972: Generalize range query optimization on sorted indexes to descending sorts.
jpountz opened a new pull request, #11972: URL: https://github.com/apache/lucene/pull/11972 This generalizes #687 to indexes that are sorted in descending order. The main challenge with descending sorts is that they require being able to compute the last doc ID that matches a value, which would ideally require walking the BKD tree in reverse order, but the API only support moving forward. This is worked around by maintaining a stack of `PointTree` clones to perform the search. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] jpountz commented on pull request #11942: Ensure collections are properly sized on creation
jpountz commented on PR #11942: URL: https://github.com/apache/lucene/pull/11942#issuecomment-1326206507 `gradlew precommit` fails for me due to imports, can you run `gradlew tidy`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] thecoop commented on pull request #11942: Ensure collections are properly sized on creation
thecoop commented on PR #11942: URL: https://github.com/apache/lucene/pull/11942#issuecomment-1326208762 Ah yes, oops, sorry about that -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] jpountz commented on pull request #11942: Ensure collections are properly sized on creation
jpountz commented on PR #11942: URL: https://github.com/apache/lucene/pull/11942#issuecomment-1326243950 Thanks @thecoop ! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] jpountz merged pull request #11942: Ensure collections are properly sized on creation
jpountz merged PR #11942: URL: https://github.com/apache/lucene/pull/11942 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] rmuir commented on pull request #11971: Disable useless error-prone checks (libraries/frameworks we do not use)
rmuir commented on PR #11971: URL: https://github.com/apache/lucene/pull/11971#issuecomment-1326477135 I think its enough for this issue. Majority of the error-prone checks we had enabled were just slowing down the build and providing no benefit :( And the majority of the ones that could provide benefit were disabled. But those require some work, for other issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] rmuir commented on pull request #11971: Disable useless error-prone checks (libraries/frameworks we do not use)
rmuir commented on PR #11971: URL: https://github.com/apache/lucene/pull/11971#issuecomment-1326503365 i'm happy if we disable more of the currently-enabled checks in followup issues. It starts to become subjective, but honestly most of the checks we have enabled are useless. If we haven't done explicit work to fix the associated problems across our (large) codebase, then such static analysis checks probably aren't doing anything. As a next step I'd rather work on enabling some of the checks marked `TODO: there are problems` here. Those are ones that I tried out, and the failures look like possibly real bugs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] shubhamvishu commented on pull request #11954: Remove QueryTimeout#isTimeoutEnabled method and move check to caller
shubhamvishu commented on PR #11954: URL: https://github.com/apache/lucene/pull/11954#issuecomment-1326530333 > Add entry in CHANGES.txt Thanks for reviewing @jpountz 😀 .. I have added the entry under 9.5.0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] rmuir opened a new issue, #11973: ShapeDocValues wrong serialization
rmuir opened a new issue, #11973:
URL: https://github.com/apache/lucene/issues/11973
### Description
Found by error-prone, looks rather serious to me since it impacts how the
shape is serialized to disk. How come no tests fail?
```
/home/rmuir/workspace/lucene/lucene/core/src/java/org/apache/lucene/document/ShapeDocValues.java:553:
warning: [LogicalAssignment] Assignment where a boolean expression was
expected; use == if this assignment wasn't expected or add parentheses for
clarity.
if (node.triangle.ca = true) {
```
With more context:
```
// write edge member of original shape
if (node.triangle.ab == true) {
header |= 0x10;
}
if (node.triangle.bc == true) {
header |= 0x20;
}
if (node.triangle.ca = true) {// <-- bug
header |= 0x40;
}
output.writeVInt(header);
```
After fixing this issue, we may enable error-prone `LogicalAssignment`
check, since it is the only such issue across the entire codebase:
https://errorprone.info/bugpattern/LogicalAssignment
### Version and environment details
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] rmuir opened a new pull request, #11974: fix wrong serialization by ShapeDocValues
rmuir opened a new pull request, #11974: URL: https://github.com/apache/lucene/pull/11974 Here's a fix, and also enabling the error-prone check. But I feel like some sort of testcase should have been failing here all along? Closes #11973 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] jpountz closed issue #11914: Remove QueryTimeout#isTimeoutEnabled?
jpountz closed issue #11914: Remove QueryTimeout#isTimeoutEnabled? URL: https://github.com/apache/lucene/issues/11914 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] jpountz merged pull request #11954: Remove QueryTimeout#isTimeoutEnabled method and move check to caller
jpountz merged PR #11954: URL: https://github.com/apache/lucene/pull/11954 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] jpountz commented on pull request #11880: Use ByteArrayComparator to replace Arrays#compareUnsigned in some other places
jpountz commented on PR #11880: URL: https://github.com/apache/lucene/pull/11880#issuecomment-1326605382 @gf2121 Let's merge this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] dweiss commented on pull request #11974: fix wrong serialization by ShapeDocValues
dweiss commented on PR #11974: URL: https://github.com/apache/lucene/pull/11974#issuecomment-1326621733 Wow. Nice catch. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] javanna opened a new pull request, #11975: Fix GeoDegeneratePath compile error
javanna opened a new pull request, #11975: URL: https://github.com/apache/lucene/pull/11975 9x is not compiling due to a bad cherry pick I believe. This should fix it. I tried to push the fix directly but something is missing because I don't have permissions, or have I dreamed that I became a committer? :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] rmuir merged pull request #11975: Fix GeoDegeneratePath compile error
rmuir merged PR #11975: URL: https://github.com/apache/lucene/pull/11975 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] rmuir commented on pull request #11975: Fix GeoDegeneratePath compile error
rmuir commented on PR #11975: URL: https://github.com/apache/lucene/pull/11975#issuecomment-1326849454 I thought you were a committer too... something isn't right, thank you for the fix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] rmuir commented on pull request #11975: Fix GeoDegeneratePath compile error
rmuir commented on PR #11975: URL: https://github.com/apache/lucene/pull/11975#issuecomment-1326850910 @javanna did you try to push to https://gitbox.apache.org/repos/asf/lucene.git ? This should work, it is what i set as `upstream` in my git. As far as github goes, in order to be able to use merge button etc, I think go to https://id.apache.org. login and make sure your github username is filled out there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] javanna commented on pull request #11975: Fix GeoDegeneratePath compile error
javanna commented on PR #11975: URL: https://github.com/apache/lucene/pull/11975#issuecomment-1326853480 Thanks Robert! id.apache.org is correctly set up but that still does not help. I tried to push to the github repo and not gitbox, I will change that then. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] rmuir commented on pull request #11975: Fix GeoDegeneratePath compile error
rmuir commented on PR #11975: URL: https://github.com/apache/lucene/pull/11975#issuecomment-1326861409 @javanna try to push to the gitbox first. if you want to do a test commit you can add yourself to whoweare page on the website repository: https://github.com/apache/lucene-site. It is a similar situation where you want to set your upstream ref to https://gitbox.apache.org/repos/asf/lucene-site.git. The github/id.apache.org is a separate thing, basically that just gives you the merge button, since github is really only a readonly mirror. If you just setup the github username, it may take a while to synchronize (?) If it isn't working by tomorrow, send an email to private@ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] maomao905 opened a new issue, #11976: End offset for combining characters is not incremented with ICUNormalizer2CharFilter
maomao905 opened a new issue, #11976:
URL: https://github.com/apache/lucene/issues/11976
### Description
This issue comes from https://github.com/elastic/elasticsearch/issues/50008.
When tokenizing combining characters (ex. `ã‹€`) after applying the char
filter `icu_normalizer`, end offset of combining character is not incremented
correctly.
The test which I added in [TestICUNormalizer2CharFilter](
https://github.com/apache/lucene/blob/main/lucene/analysis/icu/src/test/org/apache/lucene/analysis/icu/TestICUNormalizer2CharFilter.java)
failed.
```java
public void testTokenStreamCombiningCharacter() throws IOException {
String input = "日日㋀日"; // ㋀ is the combining character
CharFilter reader =
new ICUNormalizer2CharFilter(
new StringReader(input),
Normalizer2.getInstance(null, "nfkc_cf",
Normalizer2.Mode.COMPOSE));
Tokenizer tokenStream =
new ICUTokenizer(newAttributeFactory(), new
DefaultICUTokenizerConfig(false, true));
tokenStream.setReader(reader);
assertTokenStreamContents(
tokenStream,
new String[] {"日", "日", "1", "月", "日"},
new int[] {0, 1, 2, 3, 4}, // test pass if changed to {0, 1, 2, 2, 3}
new int[] {1, 2, 3, 4, 5}, // test pass if changed to {1, 2, 2, 3, 4}
(end offset for the word `1` is not incremented)
input.length());
}
```
```
$ ./gradlew test --tests
org.apache.lucene.analysis.icu.TestICUNormalizer2CharFilter.testTokenStreamCombiningCharacter
org.apache.lucene.analysis.icu.TestICUNormalizer2CharFilter >
testTokenStreamCombiningCharacter FAILED
java.lang.AssertionError: endOffset 2 term=1 expected:<3> but was:<2>
```
### Version and environment details
- macOS 12.3.1
- openjdk 17.0.5
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] maomao905 commented on issue #11976: End offset for combining characters is not incremented with ICUNormalizer2CharFilter
maomao905 commented on issue #11976: URL: https://github.com/apache/lucene/issues/11976#issuecomment-1326943642 https://github.com/apache/lucene/issues/9820 issue could be related. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
