[GitHub] [lucene] gf2121 merged pull request #602: LUCENE-10376: Roll up the loop in vint/vlong in DataInput
gf2121 merged PR #602: URL: https://github.com/apache/lucene/pull/602 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] javanna commented on pull request #11793: Prevent PointValues from returning null for ghost fields
javanna commented on PR #11793: URL: https://github.com/apache/lucene/pull/11793#issuecomment-1289134578 @jpountz I addressed the check index issue, and pushed an update around the packed values that are null in the empty point values instance. That scenario is a bit tricky and ghost fields are not extensively tested, I wonder if more testing is a thing we'd like to do. I am not entirely sure if things may go wrong when the packed values are retrieved with `PointTree`. That should be the `intersect` path and I could not yet determine if there may be NPEs there too with ghost fields. I am though under impression that we assumed before that `PointValues` is not null, hence in the worst case we would still have an NPE but in a different place. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] gf2121 merged pull request #11871: LUCENE-10376: Move CHANGES entry to 10.0.0
gf2121 merged PR #11871: URL: https://github.com/apache/lucene/pull/11871 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] uschindler commented on pull request #11871: LUCENE-10376: Move CHANGES entry to 10.0.0
uschindler commented on PR #11871: URL: https://github.com/apache/lucene/pull/11871#issuecomment-1289308243 Sorry, I forgot about this PR. Thanks for merging the "original". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] uschindler commented on pull request #602: LUCENE-10376: Roll up the loop in vint/vlong in DataInput
uschindler commented on PR #602: URL: https://github.com/apache/lucene/pull/602#issuecomment-1289308655 Sorry, I forgot about this PR. Thanks for merging! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] jmazanec15 commented on issue #11354: Reuse HNSW graphs when merging segments? [LUCENE-10318]
jmazanec15 commented on issue #11354: URL: https://github.com/apache/lucene/issues/11354#issuecomment-1289462064 Update: Sorry for delay, I am still working on this but got a little side tracked with other work. Hi @harishankar-gopalan, yes what currently happens is the graph gets reconstructed from scratch. In https://github.com/apache/lucene/pull/11719, I am working on selecting the largest graph from a segment and using that to initialize the newly created segment's graph. Posted above are my initial benchmark results. However, I am running into some issues where the recall is slightly lower with the test setup and the merge time is higher. I have been debugging a little bit why this is happening, but have not yet make progress. I am going to take another try at it this week or next week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] gf2121 closed issue #11412: Roll up the loop in vint/vlong in DataInput [LUCENE-10376]
gf2121 closed issue #11412: Roll up the loop in vint/vlong in DataInput [LUCENE-10376] URL: https://github.com/apache/lucene/issues/11412 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
