[GitHub] [lucene] uschindler commented on pull request #11834: Upgrade forbiddenapis to 3.4
uschindler commented on PR #11834: URL: https://github.com/apache/lucene/pull/11834#issuecomment-1264657879 I added a issue link as TODO: https://github.com/policeman-tools/forbidden-apis/issues/207 (the problem is that parsing the Java 19 classes leads to warnings about the same missing classes over and over) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] uschindler merged pull request #11834: Upgrade forbiddenapis to 3.4
uschindler merged PR #11834: URL: https://github.com/apache/lucene/pull/11834 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] uschindler opened a new pull request, #11835: Clean up MR-JAR build, so we do not have hardcoded "19" everywhere in validation tasks
uschindler opened a new pull request, #11835: URL: https://github.com/apache/lucene/pull/11835 This is mostly a cleanup after we added a MR-JAR. The problem was some hacks in the validation tasks, As long as soureSets are named "mainXX", with XX a feature version, we check everything automatically: - ECJ is disabled (we can't do a check without forking ECJ as a separate process using toolkit, we may support this later) - forbiddenapis (we disable checks for missing classes) - errorprone is disabled (errorprone does not work correctly at moment with forked compiler) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] uschindler merged pull request #11835: Clean up MR-JAR build, so we do not have hardcoded "19" everywhere in validation tasks
uschindler merged PR #11835: URL: https://github.com/apache/lucene/pull/11835 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] dsmiley commented on pull request #11807: No need to rewrite queries in unified highlighter
dsmiley commented on PR #11807: URL: https://github.com/apache/lucene/pull/11807#issuecomment-1264749687 +1 works for me; this change is the right thing to do, even if it surfaces issues that can be separately fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] uschindler commented on issue #11819: Fix Java 19 MR-JAR compilation in IDEs
uschindler commented on issue #11819: URL: https://github.com/apache/lucene/issues/11819#issuecomment-1264782928 I have a solution for Intellij Idea: #11836 This variant disables compilation of the MR-JAR sourceSets (like in Eclipse). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] uschindler opened a new pull request, #11836: GH-11819: Exclude MR-JAR sourceSet and folders from Idea Sync
uschindler opened a new pull request, #11836: URL: https://github.com/apache/lucene/pull/11836 This closes #11819. This is a bit of hack, but after trying a few times with Intellij Idea: When Gradle is running in ideaSync mode, we do some late evaluation: - remove all source folders from the `/main\d+/` sourceSets - exclude those directories explicit from Idea Config For me this works with Idea 2022.2.2 (Community Edition). To test delete your .idea folder from checkout. Restart Idea and tell it to reapply it as "Gradle project". The alternative is to go to View -> Tool Windows -> Gradle and then right-click on root project and select "Reload Gradle Project". Maybe there's a shorter way to do this, but as newcomer this IDE drains my head completely. When you build the project using gradle inside IDEA it will of course also generate the MR-JAR and compile the Java 19 classes (using Gradle's toolkit API). You can also edit the Java source files, but because of missing JDK you can't get autocomplete and syntax checks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] romseygeek merged pull request #11807: No need to rewrite queries in unified highlighter
romseygeek merged PR #11807: URL: https://github.com/apache/lucene/pull/11807 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] romseygeek closed issue #11490: UnifiedHighlighter can miss terms because of query rewrites [LUCENE-10454]
romseygeek closed issue #11490: UnifiedHighlighter can miss terms because of query rewrites [LUCENE-10454] URL: https://github.com/apache/lucene/issues/11490 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] risdenk merged pull request #2671: Add sts support
risdenk merged PR #2671: URL: https://github.com/apache/lucene-solr/pull/2671 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] uschindler commented on a diff in pull request #11836: GH-11819: Exclude MR-JAR sourceSet and folders from Idea Sync
uschindler commented on code in PR #11836:
URL: https://github.com/apache/lucene/pull/11836#discussion_r986079639
##
gradle/ide/intellij-idea.gradle:
##
@@ -37,6 +37,22 @@ if (isIdea) {
}
}
+if (isIdeaSync) {
+ allprojects {
+// disable all MR-JAR folders by hiding them from IDE after evaluation:
+plugins.withType(JavaPlugin) {
+ project.afterEvaluate {
+sourceSets.matching{ it.name ==~ /main\d+/ }.all{ sourceSet ->
+ logger.lifecycle("Skipping MR-JAR sourceSet on IntelliJ Idea: " +
sourceSet.name)
+ project.idea.module.excludeDirs += sourceSet.java.srcDirs
+ sourceSet.java.srcDirs = []
Review Comment:
Let me figure out if I can do this without actually removing the folder from
the SourceSet. I have to read the source code first.
If this is possible, the remaining stuff could be moved up. But anyways this
works as it should, it is just not nice.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] mdmarshmallow commented on issue #11761: Expand TieredMergePolicy deletePctAllowed limits
mdmarshmallow commented on issue #11761: URL: https://github.com/apache/lucene/issues/11761#issuecomment-1269018833 I updated the PR to change the default as well. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] zhaih opened a new issue, #11838: Adding concurrency to query rewrite?
zhaih opened a new issue, #11838: URL: https://github.com/apache/lucene/issues/11838 ### Description There're several queries relying on rewrite to do the most heavy work, such as KnnVectorQuery and AutomatonQuery, should we make rewrite step being able to run under multi-threading? Or we could also just move those costly steps into scorer creation and don't rewrite, that could also be an option because I can't really come up with other queries that are costly when doing rewrite. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] zhaih merged pull request #11831: GITHUB-11761: Move minimum TieredMergePolicy delete percentage from 2…
zhaih merged PR #11831: URL: https://github.com/apache/lucene/pull/11831 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] zhaih commented on pull request #11831: GITHUB-11761: Move minimum TieredMergePolicy delete percentage from 2…
zhaih commented on PR #11831: URL: https://github.com/apache/lucene/pull/11831#issuecomment-1269059590 Thanks @mdmarshmallow! I merged and backported it! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] stefanvodita commented on pull request #11780: GH#11601: Add ability to compute reader states after refresh
stefanvodita commented on PR #11780: URL: https://github.com/apache/lucene/pull/11780#issuecomment-1269159465 Thinking some more about this change in light of the comments, I see 3 ways it could go: 1. Do nothing. The user can already instantiate new reader states after a refresh if they want. No new API is required. 2. What this PR tried - offer an API to refresh and compute new reader states as one operation. @mikemccand points out this is likely not useful. 3. Allow the user to update the ordinal maps in the reader states they already have without requiring them to completely recreate the reader states. I’m not sure how much this accomplishes. The Javadoc suggests that the bulk of the work in instantiating a SortedSetDocValuesReaderState is building the ordinal map. In that case, updating the ordinal maps instead of recreating the reader states doesn’t have much benefit. Do any of these seem like reasonable approaches to address the original issue? If not, how else could we approach this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] rmuir merged pull request #11837: make 'gradle coverage' print test coverage summaries.
rmuir merged PR #11837: URL: https://github.com/apache/lucene/pull/11837 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] rmuir opened a new issue, #11839: gradle aggregate coverage report
rmuir opened a new issue, #11839: URL: https://github.com/apache/lucene/issues/11839 ### Description Currently, when running the build (e.g. `gradlew coverage`) you get a per-module report. Ideally we'd produce an aggregate report (similar to what black magic jenkins is doing: https://ci-builds.apache.org/job/Lucene/job/Lucene-Coverage-main/lastSuccessfulBuild/jacoco/ It would be great to also print the summary to the console (same as #11837). This would be nice, a single artifact of the code coverage for a build. For example, It could eventually be archived as a github action to help us better inspect PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] zhaih commented on issue #11750: Why we don't drop changes in pendingDVUpdates here?
zhaih commented on issue #11750: URL: https://github.com/apache/lucene/issues/11750#issuecomment-1269218912 I **think** this looks like a bug (but probably not hurting a lot? Because the segment is dropping anyway?) but I'm not 100% sure. @mikemccand do you have any ideas? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] zhaih commented on issue #11839: gradle aggregate coverage report
zhaih commented on issue #11839: URL: https://github.com/apache/lucene/issues/11839#issuecomment-1269234855 @rmuir I can work on it if you don't want to do it right now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
