[jira] [Commented] (LUCENE-10197) UnifiedHighlighter should use builders for thread-safety
[ https://issues.apache.org/jira/browse/LUCENE-10197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17433310#comment-17433310 ] Animesh Pandey commented on LUCENE-10197: - Oh wow. That is fine. I'll try to get something out if possible. So what happens after Nov 1? Is the development completely stopped or do we start focusing on Minor releases for v9? > UnifiedHighlighter should use builders for thread-safety > > > Key: LUCENE-10197 > URL: https://issues.apache.org/jira/browse/LUCENE-10197 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/highlighter >Reporter: Animesh Pandey >Priority: Minor > Labels: newdev > > UnifiedHighlighter is not thread-safe due to the presence of setters. We can > move the fields to builder so that the class becomes thread-safe. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Comment Edited] (LUCENE-10197) UnifiedHighlighter should use builders for thread-safety
[ https://issues.apache.org/jira/browse/LUCENE-10197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17433310#comment-17433310 ] Animesh Pandey edited comment on LUCENE-10197 at 10/23/21, 4:26 PM: Oh wow. That is fine. I'll try to get this out if possible. So what happens after Nov 1? Is the development completely stopped or do we start focusing on Minor releases for v9? I attempted the solution and have added a patch file to it. I don't think it is complete but wanted some feedback on whether it is on the right track. was (Author: apanimesh061): Oh wow. That is fine. I'll try to get something out if possible. So what happens after Nov 1? Is the development completely stopped or do we start focusing on Minor releases for v9? > UnifiedHighlighter should use builders for thread-safety > > > Key: LUCENE-10197 > URL: https://issues.apache.org/jira/browse/LUCENE-10197 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/highlighter >Reporter: Animesh Pandey >Priority: Minor > Labels: newdev > > UnifiedHighlighter is not thread-safe due to the presence of setters. We can > move the fields to builder so that the class becomes thread-safe. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Updated] (LUCENE-10197) UnifiedHighlighter should use builders for thread-safety
[ https://issues.apache.org/jira/browse/LUCENE-10197?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Animesh Pandey updated LUCENE-10197: Attachment: LUCENE-10197.patch > UnifiedHighlighter should use builders for thread-safety > > > Key: LUCENE-10197 > URL: https://issues.apache.org/jira/browse/LUCENE-10197 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/highlighter >Reporter: Animesh Pandey >Priority: Minor > Labels: newdev > Attachments: LUCENE-10197.patch > > > UnifiedHighlighter is not thread-safe due to the presence of setters. We can > move the fields to builder so that the class becomes thread-safe. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Created] (LUCENE-10198) Allow JAVA_OPTS in gradle download scripts and use system proxies by default
Dawid Weiss created LUCENE-10198: Summary: Allow JAVA_OPTS in gradle download scripts and use system proxies by default Key: LUCENE-10198 URL: https://issues.apache.org/jira/browse/LUCENE-10198 Project: Lucene - Core Issue Type: Task Reporter: Dawid Weiss -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] dweiss opened a new pull request #405: LUCENE-10198: Allow external JAVA_OPTS in gradlew scripts; use sane defaults (heap, stack and system proxies)
dweiss opened a new pull request #405: URL: https://github.com/apache/lucene/pull/405 # Description Please provide a short description of the changes you're making with this pull request. # Solution Please provide a short description of the approach taken to implement your solution. # Tests Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem. # Checklist Please review the following and check all that apply: - [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/lucene/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [ ] I have created a Jira issue and added the issue ID to my pull request title. - [ ] I have given Lucene maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [ ] I have developed this patch against the `main` branch. - [ ] I have run `./gradlew check`. - [ ] I have added tests for my changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Updated] (LUCENE-10198) Allow external JAVA_OPTS in gradlew scripts; use sane defaults (heap, stack and system proxies)
[ https://issues.apache.org/jira/browse/LUCENE-10198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-10198: - Summary: Allow external JAVA_OPTS in gradlew scripts; use sane defaults (heap, stack and system proxies) (was: Allow JAVA_OPTS in gradle download scripts and use system proxies by default) > Allow external JAVA_OPTS in gradlew scripts; use sane defaults (heap, stack > and system proxies) > --- > > Key: LUCENE-10198 > URL: https://issues.apache.org/jira/browse/LUCENE-10198 > Project: Lucene - Core > Issue Type: Task >Reporter: Dawid Weiss >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] dweiss commented on pull request #405: LUCENE-10198: Allow external JAVA_OPTS in gradlew scripts; use sane defaults (heap, stack and system proxies)
dweiss commented on pull request #405: URL: https://github.com/apache/lucene/pull/405#issuecomment-950192006 This changes PR-358 slightly and adds issue reference. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] dweiss edited a comment on pull request #405: LUCENE-10198: Allow external JAVA_OPTS in gradlew scripts; use sane defaults (heap, stack and system proxies)
dweiss edited a comment on pull request #405: URL: https://github.com/apache/lucene/pull/405#issuecomment-950192006 This changes #358 slightly and adds issue reference. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] dweiss commented on pull request #358: Add JAVA_OPTS to download the gradle-wrapper jar behind proxy.
dweiss commented on pull request #358: URL: https://github.com/apache/lucene/pull/358#issuecomment-950192204 I added LUCENE-10198 and modified your patch slightly: JAVA_OPTS can be defined externally (to allow any JVM options you desire). The defaults are saner - use system proxies. I verified on Windows and Linux and it seems to work fine. See #405 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] dweiss closed pull request #358: Add JAVA_OPTS to download the gradle-wrapper jar behind proxy.
dweiss closed pull request #358: URL: https://github.com/apache/lucene/pull/358 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Created] (LUCENE-10199) Drop ZIP binary distribution from release artifacts
Dawid Weiss created LUCENE-10199: Summary: Drop ZIP binary distribution from release artifacts Key: LUCENE-10199 URL: https://issues.apache.org/jira/browse/LUCENE-10199 Project: Lucene - Core Issue Type: Task Reporter: Dawid Weiss Assignee: Dawid Weiss -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Resolved] (LUCENE-9660) gradle task cache should not cache --tests
[
https://issues.apache.org/jira/browse/LUCENE-9660?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss resolved LUCENE-9660.
-
Resolution: Won't Fix
Gradle ways of re-executing the task:
--rerun-tasks
clean(taskName)
You can also multiply the test on a single run (see reiteration ("beasting") in
tests.txt).
> gradle task cache should not cache --tests
> --
>
> Key: LUCENE-9660
> URL: https://issues.apache.org/jira/browse/LUCENE-9660
> Project: Lucene - Core
> Issue Type: Improvement
> Components: general/build
>Reporter: David Smiley
>Assignee: Dawid Weiss
>Priority: Minor
>
> I recently ran a specific test at the CLI via gradle to see if a particular
> build failure repeats. It includes the {{--tests}} command line option to
> specify the test. The test passed. Later I wanted to run it again; I
> suspected it might be flakey. Gradle completed in 10 seconds, and I'm
> certain it didn't actually run the test. There was no printout and the
> build/test-results/test/outputs/... from the test run still had not changed
> from previously.
> Mike Drob informed me of "gradlew cleanTest" but I'd prefer to not have to
> know about that, at least not for the specific case of wanting to execute a
> specific test.
> CC [~dweiss]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Created] (LUCENE-10200) Restructure and modernize the release artifacts
Dawid Weiss created LUCENE-10200:
Summary: Restructure and modernize the release artifacts
Key: LUCENE-10200
URL: https://issues.apache.org/jira/browse/LUCENE-10200
Project: Lucene - Core
Issue Type: Task
Reporter: Dawid Weiss
This is an umbrella issue for various sub-tasks as per my e-mail [1].
[1] https://markmail.org/thread/f7yrggnynq2ijgmy
{code}
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Assigned] (LUCENE-10198) Allow external JAVA_OPTS in gradlew scripts; use sane defaults (heap, stack and system proxies)
[ https://issues.apache.org/jira/browse/LUCENE-10198?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss reassigned LUCENE-10198: Assignee: Dawid Weiss > Allow external JAVA_OPTS in gradlew scripts; use sane defaults (heap, stack > and system proxies) > --- > > Key: LUCENE-10198 > URL: https://issues.apache.org/jira/browse/LUCENE-10198 > Project: Lucene - Core > Issue Type: Task >Reporter: Dawid Weiss >Assignee: Dawid Weiss >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-10198) Allow external JAVA_OPTS in gradlew scripts; use sane defaults (heap, stack and system proxies)
[ https://issues.apache.org/jira/browse/LUCENE-10198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17433358#comment-17433358 ] Dawid Weiss commented on LUCENE-10198: -- I will merge this shortly. I don't think this requires an intense debate. Can reopen or revert if there are objections later. > Allow external JAVA_OPTS in gradlew scripts; use sane defaults (heap, stack > and system proxies) > --- > > Key: LUCENE-10198 > URL: https://issues.apache.org/jira/browse/LUCENE-10198 > Project: Lucene - Core > Issue Type: Task >Reporter: Dawid Weiss >Assignee: Dawid Weiss >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Updated] (LUCENE-10200) Restructure and modernize the release artifacts
[
https://issues.apache.org/jira/browse/LUCENE-10200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated LUCENE-10200:
-
Description:
This is an umbrella issue for various sub-tasks as per my e-mail [1].
[1] https://markmail.org/thread/f7yrggnynq2ijgmy
In this order, perhaps:
* Apply small text file changes (LUCENE-10163)
* Simplify artifacts (LUCENE-10199 drop ZIP binary), (LUCENE-10192 drop third
party JARs).
* Create an additional binary artifact for Luke (standalone).
* Test everything with the smoke tester.
was:
This is an umbrella issue for various sub-tasks as per my e-mail [1].
[1] https://markmail.org/thread/f7yrggnynq2ijgmy
{code}
{code}
> Restructure and modernize the release artifacts
> ---
>
> Key: LUCENE-10200
> URL: https://issues.apache.org/jira/browse/LUCENE-10200
> Project: Lucene - Core
> Issue Type: Task
>Reporter: Dawid Weiss
>Priority: Major
>
> This is an umbrella issue for various sub-tasks as per my e-mail [1].
> [1] https://markmail.org/thread/f7yrggnynq2ijgmy
> In this order, perhaps:
> * Apply small text file changes (LUCENE-10163)
> * Simplify artifacts (LUCENE-10199 drop ZIP binary), (LUCENE-10192 drop third
> party JARs).
> * Create an additional binary artifact for Luke (standalone).
> * Test everything with the smoke tester.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Assigned] (LUCENE-10200) Restructure and modernize the release artifacts
[ https://issues.apache.org/jira/browse/LUCENE-10200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss reassigned LUCENE-10200: Assignee: Dawid Weiss > Restructure and modernize the release artifacts > --- > > Key: LUCENE-10200 > URL: https://issues.apache.org/jira/browse/LUCENE-10200 > Project: Lucene - Core > Issue Type: Task >Reporter: Dawid Weiss >Assignee: Dawid Weiss >Priority: Major > > This is an umbrella issue for various sub-tasks as per my e-mail [1]. > [1] https://markmail.org/thread/f7yrggnynq2ijgmy > In this order, perhaps: > * Apply small text file changes (LUCENE-10163) > * Simplify artifacts (LUCENE-10199 drop ZIP binary), (LUCENE-10192 drop third > party JARs). > * Create an additional binary artifact for Luke (LUCENE-9978). > * Test everything with the smoke tester. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Updated] (LUCENE-10200) Restructure and modernize the release artifacts
[ https://issues.apache.org/jira/browse/LUCENE-10200?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss updated LUCENE-10200: - Description: This is an umbrella issue for various sub-tasks as per my e-mail [1]. [1] https://markmail.org/thread/f7yrggnynq2ijgmy In this order, perhaps: * Apply small text file changes (LUCENE-10163) * Simplify artifacts (LUCENE-10199 drop ZIP binary), (LUCENE-10192 drop third party JARs). * Create an additional binary artifact for Luke (LUCENE-9978). * Test everything with the smoke tester. was: This is an umbrella issue for various sub-tasks as per my e-mail [1]. [1] https://markmail.org/thread/f7yrggnynq2ijgmy In this order, perhaps: * Apply small text file changes (LUCENE-10163) * Simplify artifacts (LUCENE-10199 drop ZIP binary), (LUCENE-10192 drop third party JARs). * Create an additional binary artifact for Luke (standalone). * Test everything with the smoke tester. > Restructure and modernize the release artifacts > --- > > Key: LUCENE-10200 > URL: https://issues.apache.org/jira/browse/LUCENE-10200 > Project: Lucene - Core > Issue Type: Task >Reporter: Dawid Weiss >Priority: Major > > This is an umbrella issue for various sub-tasks as per my e-mail [1]. > [1] https://markmail.org/thread/f7yrggnynq2ijgmy > In this order, perhaps: > * Apply small text file changes (LUCENE-10163) > * Simplify artifacts (LUCENE-10199 drop ZIP binary), (LUCENE-10192 drop third > party JARs). > * Create an additional binary artifact for Luke (LUCENE-9978). > * Test everything with the smoke tester. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-10192) Drop third-party JARs from the binary distribution
[
https://issues.apache.org/jira/browse/LUCENE-10192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17433361#comment-17433361
]
Dawid Weiss commented on LUCENE-10192:
--
I'll drop third-party jars and flatten the structure of artifacts into a single
folder. This allows using much simpler classpath resolution using modules:
{code}
java --module-path jars --module lucene.demo/org.apache.lucene.demo.IndexFiles
{code}
This almost works - the test framework is currently causing module resolution
issues because of package exports to the core.
> Drop third-party JARs from the binary distribution
> --
>
> Key: LUCENE-10192
> URL: https://issues.apache.org/jira/browse/LUCENE-10192
> Project: Lucene - Core
> Issue Type: Task
>Reporter: Dawid Weiss
>Assignee: Dawid Weiss
>Priority: Trivial
>
> [~janhoy] Are we ready (with respect to scripts) for this change? I'd like to
> do it but I'm not sure whether the release wizard doesn't depend on it
> somehow (I will handle buildAndPushRelease.py and smokeTestRelease.py if they
> need fixes but I'm not sure about the releaseWizard.*).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] dweiss commented on pull request #408: LUCENE-10192: Drop third-party JARs from the binary distribution and use the module system for demos.
dweiss commented on pull request #408: URL: https://github.com/apache/lucene/pull/408#issuecomment-950211763 This is not ready yet but shows a PoC that works. ``` gradlew assembleRelease then unpack the release: CHANGES.txt docs jars JRE_VERSION_MIGRATION.md LICENSE.txt licenses MIGRATE.md NOTICE.txt README.md SYSTEM_REQUIREMENTS.md and try running the demo with, for example: java --module-path jars --module lucene.demo/org.apache.lucene.demo.IndexFiles -index index -docs licenses ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-10197) UnifiedHighlighter should use builders for thread-safety
[ https://issues.apache.org/jira/browse/LUCENE-10197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17433366#comment-17433366 ] David Smiley commented on LUCENE-10197: --- Development wouldn't be halted but it wouldn't be "released" until Lucene 10, likely in 2023. Are you opposed to the GitHub PR process? I find it superior for collaborative development than old patch files. I took a brief look at your patch. The builder itself looks nice but I think overall it misses the point because build() calls a bunch of setters on UnifiedHighlighter. A key outcome here is for UH to be immutable. The constructor for the UH could take this builder and populate itself accordingly. Remember we need to support UH subclassing too. > UnifiedHighlighter should use builders for thread-safety > > > Key: LUCENE-10197 > URL: https://issues.apache.org/jira/browse/LUCENE-10197 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/highlighter >Reporter: Animesh Pandey >Priority: Minor > Labels: newdev > Attachments: LUCENE-10197.patch > > > UnifiedHighlighter is not thread-safe due to the presence of setters. We can > move the fields to builder so that the class becomes thread-safe. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Resolved] (LUCENE-9351) Port releaseWizard to 7_7 branch
[ https://issues.apache.org/jira/browse/LUCENE-9351?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved LUCENE-9351. - Resolution: Not A Problem > Port releaseWizard to 7_7 branch > > > Key: LUCENE-9351 > URL: https://issues.apache.org/jira/browse/LUCENE-9351 > Project: Lucene - Core > Issue Type: Task > Components: general/tools >Reporter: Jan Høydahl >Priority: Major > > The releaseWizard tool can be used for 7.7.x releases. Must be back-ported > from master/branch8x. > Note that also changes in buildAndPushRelease.py, poll-mirrors.py and other > tools may be necessary too. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Reopened] (LUCENE-9809) Adapt Release Wizard to only release Lucene
[ https://issues.apache.org/jira/browse/LUCENE-9809?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl reopened LUCENE-9809: - Re-open for futher ant -> gradle fixes > Adapt Release Wizard to only release Lucene > --- > > Key: LUCENE-9809 > URL: https://issues.apache.org/jira/browse/LUCENE-9809 > Project: Lucene - Core > Issue Type: Sub-task >Reporter: Jan Høydahl >Assignee: Jan Høydahl >Priority: Major > Fix For: main (9.0) > > Time Spent: 1h 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Created] (LUCENE-10201) Upgrade Spatial4j to 0.8
David Smiley created LUCENE-10201: - Summary: Upgrade Spatial4j to 0.8 Key: LUCENE-10201 URL: https://issues.apache.org/jira/browse/LUCENE-10201 Project: Lucene - Core Issue Type: Improvement Components: modules/spatial-extras Reporter: David Smiley Assignee: David Smiley Spatial4j has been at 0.8 for some time. We should upgrade. [https://github.com/locationtech/spatial4j/releases/tag/spatial4j-0.8] -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-10201) Upgrade Spatial4j to 0.8
[ https://issues.apache.org/jira/browse/LUCENE-10201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17433371#comment-17433371 ] David Smiley commented on LUCENE-10201: --- I'll copy-paste the release notes: _from CHANGES.md_ [#197|https://github.com/locationtech/spatial4j/pull/197]: Require Java 8, AKA v1.8. (David Smiley) [#194|https://github.com/locationtech/spatial4j/pull/194]: Circles that cross a dateline can now be converted to a JTS Geometry. Previous attempts would throw an exception. (Stijn Caerts) [#194|https://github.com/locationtech/spatial4j/pull/194]: JtsGeometry now supports input an Geometry that crosses the dateline multiple times (wraps the globe multiple times). Previous attempts would yield erroneous behavior. (Stijn Caerts) [#188|https://github.com/locationtech/spatial4j/pull/188]: Upgraded to JTS 1.17.0. This JTS release has a small API change. (Jim Hughes) [#177|https://github.com/locationtech/spatial4j/issues/177]: Improve conversion of a Circle to Shape. JtsShapeFactory allows converting from a Shape object to a JTS Geometry object. Geodetic circles now translate to a polygon that has points equidistant from the center. Before the change, there was potentially a large inaccuracy. (Hrishi Bakshi) [#163|https://github.com/locationtech/spatial4j/issues/163]: "Empty" points in JTS are now convertible to a Spatial4j Shape instead of throwing an exception. (David Smiley) [#162|https://github.com/locationtech/spatial4j/issues/162]: Fixed WKT & GeoJSON [de]serialization of "empty" points and geometrycollections. (Jeen Broekstra, David Smiley) [#165|https://github.com/locationtech/spatial4j/pull/165]: Added ShapeFactory.pointLatLon convenience method. (MoeweX) [#167|https://github.com/locationtech/spatial4j/pull/167]: WKTWriter now has a means to customize the NumberFromat. (MoeweX) [#175|https://github.com/locationtech/spatial4j/issues/175]: ShapesAsWKTModule, a Jackson databind module, didn't deserialize WKT inside JSON to a Spatial4j Shape at all. Now it does. It continues to serialize correctly. (David Smiley) > Upgrade Spatial4j to 0.8 > > > Key: LUCENE-10201 > URL: https://issues.apache.org/jira/browse/LUCENE-10201 > Project: Lucene - Core > Issue Type: Improvement > Components: modules/spatial-extras >Reporter: David Smiley >Assignee: David Smiley >Priority: Major > > Spatial4j has been at 0.8 for some time. We should upgrade. > [https://github.com/locationtech/spatial4j/releases/tag/spatial4j-0.8] > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene] dsmiley opened a new pull request #409: LUCENE-10201: Upgrade Spatial4j to 0.8
dsmiley opened a new pull request #409: URL: https://github.com/apache/lucene/pull/409 https://issues.apache.org/jira/browse/LUCENE-10201 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-9809) Adapt Release Wizard to only release Lucene
[
https://issues.apache.org/jira/browse/LUCENE-9809?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17433373#comment-17433373
]
Jan Høydahl commented on LUCENE-9809:
-
ReleaseWizard step 6.4 uses Ant command
{code:java}
In the source checkout do the following (note that this step will prompt you
for your Apache LDAP credentials) cd ~/.lucene-releases/9.0.0/lucene
ant clean stage-maven-artifacts \
-Dmaven.dist.dir=~/.lucene-releases/9.0.0/RC1/dist/lucene-9.0.0-RC1-rev2719cf6630eb2bd7cb37d0e8462dc912d8fafd83/lucene/maven
\
-Dm2.repository.id=apache.releases.https \
-Dm2.repository.url=https://repository.apache.org/service/local/staging/deploy/maven2
{code}
The gradle equivalent is
{code:java}
./gradlew mavenToApacheReleases -Dversion.release=
-PasfNexusUsername= -PasfNexusPassword={code}
While the ant task prompted for ASF user/pass, the gradle equivalent expects
these as cli args, or as env.vars {{ASF_NEXUS_USERNAME}} and
{{ASF_NEXUS_PASSWORD}}. There does not seem to be any configuration for
specifying the folder where the signed and voted upon artifacts reside.
[~dweiss] will the command instead use the last build's build folder? We likely
need the wizard to prompt for user/pass, and somehow issue the command with the
env vars set, without revealing the password in logs in plaintext. Going to
check...
> Adapt Release Wizard to only release Lucene
> ---
>
> Key: LUCENE-9809
> URL: https://issues.apache.org/jira/browse/LUCENE-9809
> Project: Lucene - Core
> Issue Type: Sub-task
>Reporter: Jan Høydahl
>Assignee: Jan Høydahl
>Priority: Major
> Fix For: main (9.0)
>
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
