[jira] [Created] (LUCENE-9649) GenerateJflexTLDMacros regeneration missing
Dawid Weiss created LUCENE-9649: --- Summary: GenerateJflexTLDMacros regeneration missing Key: LUCENE-9649 URL: https://issues.apache.org/jira/browse/LUCENE-9649 Project: Lucene - Core Issue Type: Task Reporter: Dawid Weiss Assignee: Dawid Weiss Missing in gradle from ant build. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Created] (LUCENE-9650) Errorprone on master/gradle no longer works with JDK-16
Uwe Schindler created LUCENE-9650:
-
Summary: Errorprone on master/gradle no longer works with JDK-16
Key: LUCENE-9650
URL: https://issues.apache.org/jira/browse/LUCENE-9650
Project: Lucene - Core
Issue Type: Bug
Components: general/build
Affects Versions: master (9.0)
Reporter: Uwe Schindler
JDK-16 no longer allows access to internal classes of any module by default. It
looks like errorprone tries to access some internals from the Java compiler.
This now fails with Exception. You have to fully open the module or pass
`--illegal-access=allow`.
We have 3 options:
- install an update of errorprone
- disable error-prone if we detect a runtimeJdk with version >=16
- run javac as a separate forked task (i think we do already) and pass
`--illegal-access=allow` or open the internal compile module.
Error message:
{noformat}
> Task :solr:solr-ref-guide:compileJava FAILED
Exception in thread "main" java.lang.IllegalAccessError: class
com.google.errorprone.ErrorProneJavacPlugin (in unnamed module @0x887af79)
cannot access class com.sun.tools.javac.api.BasicJavacTask (in module
jdk.compiler) because module jdk.compiler does not export
com.sun.tools.javac.api to unnamed module @0x887af79
at
com.google.errorprone.ErrorProneJavacPlugin.init(ErrorProneJavacPlugin.java:38)
at
jdk.compiler/com.sun.tools.javac.api.BasicJavacTask.initPlugin(BasicJavacTask.java:254)
at
jdk.compiler/com.sun.tools.javac.api.BasicJavacTask.initPlugins(BasicJavacTask.java:228)
at jdk.compiler/com.sun.tools.javac.main.Main.compile(Main.java:292)
at jdk.compiler/com.sun.tools.javac.main.Main.compile(Main.java:176)
at jdk.compiler/com.sun.tools.javac.Main.compile(Main.java:64)
at jdk.compiler/com.sun.tools.javac.Main.main(Main.java:50)
{noformat}
Last failed build:
https://jenkins.thetaphi.de/job/Lucene-Solr-master-Linux/29129/
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-9570) Review code diffs after automatic formatting and correct problems before it is applied
[
https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255531#comment-17255531
]
ASF subversion and git services commented on LUCENE-9570:
-
Commit 8ef6a0da56878177ff8d6880c92e8f7d0321d076 in lucene-solr's branch
refs/heads/master from Dawid Weiss
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=8ef6a0d ]
LUCENE-9570: code reformatting [partial].
> Review code diffs after automatic formatting and correct problems before it
> is applied
> --
>
> Key: LUCENE-9570
> URL: https://issues.apache.org/jira/browse/LUCENE-9570
> Project: Lucene - Core
> Issue Type: Sub-task
>Reporter: Dawid Weiss
>Assignee: Dawid Weiss
>Priority: Blocker
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Review and correct all the javadocs before they're messed up by automatic
> formatting. Apply project-by-project, review diff, correct. Lots of diffs but
> it should be relatively quick.
> *Reviewing diffs manually*
> * switch to branch jira/LUCENE-9570 which the PR is based on:
> {code:java}
> git remote add dweiss g...@github.com:dweiss/lucene-solr.git
> git fetch dweiss
> git checkout jira/LUCENE-9570
> {code}
> * Open gradle/validation/spotless.gradle and locate the project/ package you
> wish to review. Enable it in spotless.gradle by creating a corresponding
> switch case block (refer to existing examples), for example:
> {code:java}
> case ":lucene:highlighter":
> target "src/**"
> targetExclude "**/resources/**", "**/overview.html"
> break
> {code}
> * Reformat the code:
> {code:java}
> gradlew tidy && git diff -w > /tmp/diff.patch && git status
> {code}
> * Look at what has changed (git status) and review the differences manually
> (/tmp/diff.patch). If everything looks ok, commit it directly to
> jira/LUCENE-9570 or make a PR against that branch.
> {code:java}
> git commit -am ":lucene:core - src/**/org/apache/lucene/document/**"
> {code}
> *Packages remaining* (put your name next to a module you're working on to
> avoid duplication).
> * case ":lucene:analysis:common": (partially done, dweiss)
> * case ":lucene:analysis:icu":
> * case ":lucene:analysis:kuromoji":
> * case ":lucene:analysis:morfologik":
> * case ":lucene:analysis:nori":
> * case ":lucene:analysis:opennlp":
> * case ":lucene:analysis:phonetic":
> * case ":lucene:analysis:smartcn":
> * case ":lucene:analysis:stempel":
> * case ":lucene:backward-codecs":
> * case ":lucene:benchmark":
> * case ":lucene:classification":
> * case ":lucene:codecs":
> * case ":lucene:demo":
> * case ":lucene:expressions":
> * case ":lucene:facet": (Erick Erickson)
> * case ":lucene:grouping":
> * case ":lucene:join":
> * case ":lucene:luke":
> * case ":lucene:memory":
> * case ":lucene:misc":
> * case ":lucene:monitor":
> * case ":lucene:queries": (Erick Erickson - done)
> * case ":lucene:queryparser":
> * case ":lucene:replicator":
> * case ":lucene:sandbox":
> * case ":lucene:spatial3d":
> * case ":lucene:spatial-extras":
> * case ":lucene:suggest":
> * case ":lucene:test-framework":
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Updated] (LUCENE-9570) Review code diffs after automatic formatting and correct problems before it is applied
[
https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated LUCENE-9570:
Description:
Review and correct all the javadocs before they're messed up by automatic
formatting. Apply project-by-project, review diff, correct. Lots of diffs but
it should be relatively quick.
*Reviewing diffs manually*
* switch to branch jira/LUCENE-9570 which the PR is based on:
{code:java}
git remote add dweiss g...@github.com:dweiss/lucene-solr.git
git fetch dweiss
git checkout jira/LUCENE-9570
{code}
* Open gradle/validation/spotless.gradle and locate the project/ package you
wish to review. Enable it in spotless.gradle by creating a corresponding switch
case block (refer to existing examples), for example:
{code:java}
case ":lucene:highlighter":
target "src/**"
targetExclude "**/resources/**", "**/overview.html"
break
{code}
* Reformat the code:
{code:java}
gradlew tidy && git diff -w > /tmp/diff.patch && git status
{code}
* Look at what has changed (git status) and review the differences manually
(/tmp/diff.patch). If everything looks ok, commit it directly to
jira/LUCENE-9570 or make a PR against that branch.
{code:java}
git commit -am ":lucene:core - src/**/org/apache/lucene/document/**"
{code}
*Packages remaining* (put your name next to a module you're working on to avoid
duplication).
* case ":lucene:analysis:icu":
* case ":lucene:analysis:kuromoji":
* case ":lucene:analysis:morfologik":
* case ":lucene:analysis:nori":
* case ":lucene:analysis:opennlp":
* case ":lucene:analysis:phonetic":
* case ":lucene:analysis:smartcn":
* case ":lucene:analysis:stempel":
* case ":lucene:backward-codecs":
* case ":lucene:benchmark":
* case ":lucene:classification":
* case ":lucene:codecs":
* case ":lucene:demo":
* case ":lucene:expressions":
* case ":lucene:facet": (Erick Erickson)
* case ":lucene:grouping":
* case ":lucene:join":
* case ":lucene:luke":
* case ":lucene:memory":
* case ":lucene:misc":
* case ":lucene:monitor":
* case ":lucene:queryparser":
* case ":lucene:replicator":
* case ":lucene:sandbox":
* case ":lucene:spatial3d":
* case ":lucene:spatial-extras":
* case ":lucene:suggest":
* case ":lucene:test-framework":
was:
Review and correct all the javadocs before they're messed up by automatic
formatting. Apply project-by-project, review diff, correct. Lots of diffs but
it should be relatively quick.
*Reviewing diffs manually*
* switch to branch jira/LUCENE-9570 which the PR is based on:
{code:java}
git remote add dweiss g...@github.com:dweiss/lucene-solr.git
git fetch dweiss
git checkout jira/LUCENE-9570
{code}
* Open gradle/validation/spotless.gradle and locate the project/ package you
wish to review. Enable it in spotless.gradle by creating a corresponding switch
case block (refer to existing examples), for example:
{code:java}
case ":lucene:highlighter":
target "src/**"
targetExclude "**/resources/**", "**/overview.html"
break
{code}
* Reformat the code:
{code:java}
gradlew tidy && git diff -w > /tmp/diff.patch && git status
{code}
* Look at what has changed (git status) and review the differences manually
(/tmp/diff.patch). If everything looks ok, commit it directly to
jira/LUCENE-9570 or make a PR against that branch.
{code:java}
git commit -am ":lucene:core - src/**/org/apache/lucene/document/**"
{code}
*Packages remaining* (put your name next to a module you're working on to avoid
duplication).
* case ":lucene:analysis:common": (partially done, dweiss)
* case ":lucene:analysis:icu":
* case ":lucene:analysis:kuromoji":
* case ":lucene:analysis:morfologik":
* case ":lucene:analysis:nori":
* case ":lucene:analysis:opennlp":
* case ":lucene:analysis:phonetic":
* case ":lucene:analysis:smartcn":
* case ":lucene:analysis:stempel":
* case ":lucene:backward-codecs":
* case ":lucene:benchmark":
* case ":lucene:classification":
* case ":lucene:codecs":
* case ":lucene:demo":
* case ":lucene:expressions":
* case ":lucene:facet": (Erick Erickson)
* case ":lucene:grouping":
* case ":lucene:join":
* case ":lucene:luke":
* case ":lucene:memory":
* case ":lucene:misc":
* case ":lucene:monitor":
* case ":lucene:queries": (Erick Erickson - done)
* case ":lucene:queryparser":
* case ":lucene:replicator":
* case ":lucene:sandbox":
* case ":lucene:spatial3d":
* case ":lucene:spatial-extras":
* case ":lucene:suggest":
* case ":lucene:test-framework":
> Review code diffs after automatic formatting and correct problems before it
> is applied
> --
>
> Key: LUCENE-9570
> URL: https://issues.apache.org/jira/browse/LUCENE-9570
> Project: Lucene - Core
> Issue Type: Sub-task
>Reporter: Daw
[jira] [Updated] (LUCENE-9570) Review code diffs after automatic formatting and correct problems before it is applied
[
https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated LUCENE-9570:
Description:
Review and correct all the javadocs before they're messed up by automatic
formatting. Apply project-by-project, review diff, correct. Lots of diffs but
it should be relatively quick.
*Reviewing diffs manually*
* switch to branch jira/LUCENE-9570 which the PR is based on:
{code:java}
git remote add dweiss g...@github.com:dweiss/lucene-solr.git
git fetch dweiss
git checkout jira/LUCENE-9570
{code}
* Open gradle/validation/spotless.gradle and locate the project/ package you
wish to review. Enable it in spotless.gradle by creating a corresponding switch
case block (refer to existing examples), for example:
{code:java}
case ":lucene:highlighter":
target "src/**"
targetExclude "**/resources/**", "**/overview.html"
break
{code}
* Reformat the code:
{code:java}
gradlew tidy && git diff -w > /tmp/diff.patch && git status
{code}
* Look at what has changed (git status) and review the differences manually
(/tmp/diff.patch). If everything looks ok, commit it directly to
jira/LUCENE-9570 or make a PR against that branch.
{code:java}
git commit -am ":lucene:core - src/**/org/apache/lucene/document/**"
{code}
*Packages remaining* (put your name next to a module you're working on to avoid
duplication).
* case ":lucene:analysis:icu":
* case ":lucene:analysis:kuromoji":
* case ":lucene:analysis:nori":
* case ":lucene:analysis:opennlp":
* case ":lucene:analysis:phonetic":
* case ":lucene:analysis:smartcn":
* case ":lucene:analysis:stempel":
* case ":lucene:backward-codecs":
* case ":lucene:benchmark":
* case ":lucene:classification":
* case ":lucene:codecs":
* case ":lucene:demo":
* case ":lucene:expressions":
* case ":lucene:facet": (Erick Erickson)
* case ":lucene:grouping":
* case ":lucene:join":
* case ":lucene:luke":
* case ":lucene:memory":
* case ":lucene:misc":
* case ":lucene:monitor":
* case ":lucene:queryparser":
* case ":lucene:replicator":
* case ":lucene:sandbox":
* case ":lucene:spatial3d":
* case ":lucene:spatial-extras":
* case ":lucene:suggest":
* case ":lucene:test-framework":
was:
Review and correct all the javadocs before they're messed up by automatic
formatting. Apply project-by-project, review diff, correct. Lots of diffs but
it should be relatively quick.
*Reviewing diffs manually*
* switch to branch jira/LUCENE-9570 which the PR is based on:
{code:java}
git remote add dweiss g...@github.com:dweiss/lucene-solr.git
git fetch dweiss
git checkout jira/LUCENE-9570
{code}
* Open gradle/validation/spotless.gradle and locate the project/ package you
wish to review. Enable it in spotless.gradle by creating a corresponding switch
case block (refer to existing examples), for example:
{code:java}
case ":lucene:highlighter":
target "src/**"
targetExclude "**/resources/**", "**/overview.html"
break
{code}
* Reformat the code:
{code:java}
gradlew tidy && git diff -w > /tmp/diff.patch && git status
{code}
* Look at what has changed (git status) and review the differences manually
(/tmp/diff.patch). If everything looks ok, commit it directly to
jira/LUCENE-9570 or make a PR against that branch.
{code:java}
git commit -am ":lucene:core - src/**/org/apache/lucene/document/**"
{code}
*Packages remaining* (put your name next to a module you're working on to avoid
duplication).
* case ":lucene:analysis:icu":
* case ":lucene:analysis:kuromoji":
* case ":lucene:analysis:morfologik":
* case ":lucene:analysis:nori":
* case ":lucene:analysis:opennlp":
* case ":lucene:analysis:phonetic":
* case ":lucene:analysis:smartcn":
* case ":lucene:analysis:stempel":
* case ":lucene:backward-codecs":
* case ":lucene:benchmark":
* case ":lucene:classification":
* case ":lucene:codecs":
* case ":lucene:demo":
* case ":lucene:expressions":
* case ":lucene:facet": (Erick Erickson)
* case ":lucene:grouping":
* case ":lucene:join":
* case ":lucene:luke":
* case ":lucene:memory":
* case ":lucene:misc":
* case ":lucene:monitor":
* case ":lucene:queryparser":
* case ":lucene:replicator":
* case ":lucene:sandbox":
* case ":lucene:spatial3d":
* case ":lucene:spatial-extras":
* case ":lucene:suggest":
* case ":lucene:test-framework":
> Review code diffs after automatic formatting and correct problems before it
> is applied
> --
>
> Key: LUCENE-9570
> URL: https://issues.apache.org/jira/browse/LUCENE-9570
> Project: Lucene - Core
> Issue Type: Sub-task
>Reporter: Dawid Weiss
>Assignee: Dawid Weiss
>Priority: Blocker
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Review and correct
[jira] [Commented] (LUCENE-9570) Review code diffs after automatic formatting and correct problems before it is applied
[
https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255532#comment-17255532
]
ASF subversion and git services commented on LUCENE-9570:
-
Commit 4160ceda2eea54d15ff7764f66546aaac4859e76 in lucene-solr's branch
refs/heads/master from Dawid Weiss
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=4160ced ]
LUCENE-9570: code reformatting [record rev].
> Review code diffs after automatic formatting and correct problems before it
> is applied
> --
>
> Key: LUCENE-9570
> URL: https://issues.apache.org/jira/browse/LUCENE-9570
> Project: Lucene - Core
> Issue Type: Sub-task
>Reporter: Dawid Weiss
>Assignee: Dawid Weiss
>Priority: Blocker
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Review and correct all the javadocs before they're messed up by automatic
> formatting. Apply project-by-project, review diff, correct. Lots of diffs but
> it should be relatively quick.
> *Reviewing diffs manually*
> * switch to branch jira/LUCENE-9570 which the PR is based on:
> {code:java}
> git remote add dweiss g...@github.com:dweiss/lucene-solr.git
> git fetch dweiss
> git checkout jira/LUCENE-9570
> {code}
> * Open gradle/validation/spotless.gradle and locate the project/ package you
> wish to review. Enable it in spotless.gradle by creating a corresponding
> switch case block (refer to existing examples), for example:
> {code:java}
> case ":lucene:highlighter":
> target "src/**"
> targetExclude "**/resources/**", "**/overview.html"
> break
> {code}
> * Reformat the code:
> {code:java}
> gradlew tidy && git diff -w > /tmp/diff.patch && git status
> {code}
> * Look at what has changed (git status) and review the differences manually
> (/tmp/diff.patch). If everything looks ok, commit it directly to
> jira/LUCENE-9570 or make a PR against that branch.
> {code:java}
> git commit -am ":lucene:core - src/**/org/apache/lucene/document/**"
> {code}
> *Packages remaining* (put your name next to a module you're working on to
> avoid duplication).
> * case ":lucene:analysis:common": (partially done, dweiss)
> * case ":lucene:analysis:icu":
> * case ":lucene:analysis:kuromoji":
> * case ":lucene:analysis:morfologik":
> * case ":lucene:analysis:nori":
> * case ":lucene:analysis:opennlp":
> * case ":lucene:analysis:phonetic":
> * case ":lucene:analysis:smartcn":
> * case ":lucene:analysis:stempel":
> * case ":lucene:backward-codecs":
> * case ":lucene:benchmark":
> * case ":lucene:classification":
> * case ":lucene:codecs":
> * case ":lucene:demo":
> * case ":lucene:expressions":
> * case ":lucene:facet": (Erick Erickson)
> * case ":lucene:grouping":
> * case ":lucene:join":
> * case ":lucene:luke":
> * case ":lucene:memory":
> * case ":lucene:misc":
> * case ":lucene:monitor":
> * case ":lucene:queries": (Erick Erickson - done)
> * case ":lucene:queryparser":
> * case ":lucene:replicator":
> * case ":lucene:sandbox":
> * case ":lucene:spatial3d":
> * case ":lucene:spatial-extras":
> * case ":lucene:suggest":
> * case ":lucene:test-framework":
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-9650) Errorprone on master/gradle no longer works with JDK-16
[
https://issues.apache.org/jira/browse/LUCENE-9650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255535#comment-17255535
]
Dawid Weiss commented on LUCENE-9650:
-
An update of errorprone would be the simplest solution? I don't if (or how) it
avoids to touch internal classes though.
> Errorprone on master/gradle no longer works with JDK-16
> ---
>
> Key: LUCENE-9650
> URL: https://issues.apache.org/jira/browse/LUCENE-9650
> Project: Lucene - Core
> Issue Type: Bug
> Components: general/build
>Affects Versions: master (9.0)
>Reporter: Uwe Schindler
>Priority: Major
>
> JDK-16 no longer allows access to internal classes of any module by default.
> It looks like errorprone tries to access some internals from the Java
> compiler. This now fails with Exception. You have to fully open the module or
> pass `--illegal-access=allow`.
> We have 3 options:
> - install an update of errorprone
> - disable error-prone if we detect a runtimeJdk with version >=16
> - run javac as a separate forked task (i think we do already) and pass
> `--illegal-access=allow` or open the internal compile module.
> Error message:
> {noformat}
> > Task :solr:solr-ref-guide:compileJava FAILED
> Exception in thread "main" java.lang.IllegalAccessError: class
> com.google.errorprone.ErrorProneJavacPlugin (in unnamed module @0x887af79)
> cannot access class com.sun.tools.javac.api.BasicJavacTask (in module
> jdk.compiler) because module jdk.compiler does not export
> com.sun.tools.javac.api to unnamed module @0x887af79
> at
> com.google.errorprone.ErrorProneJavacPlugin.init(ErrorProneJavacPlugin.java:38)
> at
> jdk.compiler/com.sun.tools.javac.api.BasicJavacTask.initPlugin(BasicJavacTask.java:254)
> at
> jdk.compiler/com.sun.tools.javac.api.BasicJavacTask.initPlugins(BasicJavacTask.java:228)
> at jdk.compiler/com.sun.tools.javac.main.Main.compile(Main.java:292)
> at jdk.compiler/com.sun.tools.javac.main.Main.compile(Main.java:176)
> at jdk.compiler/com.sun.tools.javac.Main.compile(Main.java:64)
> at jdk.compiler/com.sun.tools.javac.Main.main(Main.java:50)
> {noformat}
> Last failed build:
> https://jenkins.thetaphi.de/job/Lucene-Solr-master-Linux/29129/
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-9650) Errorprone on master/gradle no longer works with JDK-16
[
https://issues.apache.org/jira/browse/LUCENE-9650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255542#comment-17255542
]
Uwe Schindler commented on LUCENE-9650:
---
As said, if an update helps, it would be easiest.
If not, the simplest IMHO is to just disable it for now if
runtime.JDK.version>=16. That should be an easy if-statement.
Uwe
> Errorprone on master/gradle no longer works with JDK-16
> ---
>
> Key: LUCENE-9650
> URL: https://issues.apache.org/jira/browse/LUCENE-9650
> Project: Lucene - Core
> Issue Type: Bug
> Components: general/build
>Affects Versions: master (9.0)
>Reporter: Uwe Schindler
>Priority: Major
>
> JDK-16 no longer allows access to internal classes of any module by default.
> It looks like errorprone tries to access some internals from the Java
> compiler. This now fails with Exception. You have to fully open the module or
> pass `--illegal-access=allow`.
> We have 3 options:
> - install an update of errorprone
> - disable error-prone if we detect a runtimeJdk with version >=16
> - run javac as a separate forked task (i think we do already) and pass
> `--illegal-access=allow` or open the internal compile module.
> Error message:
> {noformat}
> > Task :solr:solr-ref-guide:compileJava FAILED
> Exception in thread "main" java.lang.IllegalAccessError: class
> com.google.errorprone.ErrorProneJavacPlugin (in unnamed module @0x887af79)
> cannot access class com.sun.tools.javac.api.BasicJavacTask (in module
> jdk.compiler) because module jdk.compiler does not export
> com.sun.tools.javac.api to unnamed module @0x887af79
> at
> com.google.errorprone.ErrorProneJavacPlugin.init(ErrorProneJavacPlugin.java:38)
> at
> jdk.compiler/com.sun.tools.javac.api.BasicJavacTask.initPlugin(BasicJavacTask.java:254)
> at
> jdk.compiler/com.sun.tools.javac.api.BasicJavacTask.initPlugins(BasicJavacTask.java:228)
> at jdk.compiler/com.sun.tools.javac.main.Main.compile(Main.java:292)
> at jdk.compiler/com.sun.tools.javac.main.Main.compile(Main.java:176)
> at jdk.compiler/com.sun.tools.javac.Main.compile(Main.java:64)
> at jdk.compiler/com.sun.tools.javac.Main.main(Main.java:50)
> {noformat}
> Last failed build:
> https://jenkins.thetaphi.de/job/Lucene-Solr-master-Linux/29129/
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] noblepaul commented on a change in pull request #2148: SOLR-15052: Per-replica states for reducing overseer bottlenecks
noblepaul commented on a change in pull request #2148:
URL: https://github.com/apache/lucene-solr/pull/2148#discussion_r549329497
##
File path: solr/core/src/test/org/apache/solr/handler/TestContainerPlugin.java
##
@@ -73,6 +79,29 @@ public void teardown() {
System.clearProperty("enable.packages");
}
+ public void testZkBehavior() throws Exception {
Review comment:
true
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] noblepaul commented on a change in pull request #2148: SOLR-15052: Per-replica states for reducing overseer bottlenecks
noblepaul commented on a change in pull request #2148:
URL: https://github.com/apache/lucene-solr/pull/2148#discussion_r549331687
##
File path:
solr/solrj/src/java/org/apache/solr/common/cloud/PerReplicaStates.java
##
@@ -0,0 +1,587 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.solr.common.cloud;
+
+import java.io.IOException;
+import java.lang.invoke.MethodHandles;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.HashSet;
+import java.util.LinkedHashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Objects;
+import java.util.Set;
+import java.util.function.BiConsumer;
+
+import org.apache.solr.cluster.api.SimpleMap;
+import org.apache.solr.common.MapWriter;
+import org.apache.solr.common.SolrException;
+import org.apache.solr.common.annotation.JsonProperty;
+import org.apache.solr.common.util.ReflectMapWriter;
+import org.apache.solr.common.util.StrUtils;
+import org.apache.solr.common.util.WrappedSimpleMap;
+import org.apache.zookeeper.CreateMode;
+import org.apache.zookeeper.KeeperException;
+import org.apache.zookeeper.data.ACL;
+import org.apache.zookeeper.data.Stat;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
+import static java.util.Collections.singletonList;
+import static org.apache.solr.common.params.CommonParams.NAME;
+import static org.apache.solr.common.params.CommonParams.VERSION;
+
+/**
+ * This represents the individual replica states in a collection
+ * This is an immutable object. When states are modified, a new instance is
constructed
+ */
+public class PerReplicaStates implements ReflectMapWriter {
+ private static final Logger log =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
+ public static final char SEPARATOR = ':';
+
+
+ @JsonProperty
+ public final String path;
+
+ @JsonProperty
+ public final int cversion;
+
+ @JsonProperty
+ public final SimpleMap states;
+
+ public PerReplicaStates(String path, int cversion, List states) {
+this.path = path;
+this.cversion = cversion;
+Map tmp = new LinkedHashMap<>();
+
+for (String state : states) {
+ State rs = State.parse(state);
+ if (rs == null) continue;
+ State existing = tmp.get(rs.replica);
+ if (existing == null) {
+tmp.put(rs.replica, rs);
+ } else {
+tmp.put(rs.replica, rs.insert(existing));
+ }
+}
+this.states = new WrappedSimpleMap<>(tmp);
+
+ }
+
+ /**Get the changed replicas
+ */
+ public static Set findModifiedReplicas(PerReplicaStates old,
PerReplicaStates fresh) {
+Set result = new HashSet<>();
+if (fresh == null) {
+ old.states.forEachKey(result::add);
+ return result;
+}
+old.states.forEachEntry((s, state) -> {
+ // the state is modified or missing
+ if (!Objects.equals(fresh.get(s) , state)) result.add(s);
+});
+fresh.states.forEachEntry((s, state) -> { if (old.get(s) == null )
result.add(s);
+});
+return result;
+ }
+
+ /**
+ * This is a persist operation with retry if a write fails due to stale state
+ */
+ public static void persist(WriteOps ops, String znode, SolrZkClient
zkClient) throws KeeperException, InterruptedException {
Review comment:
the persist op really has nothing much to do with the instance of PRS
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14608) Faster sorting for the /export handler
[ https://issues.apache.org/jira/browse/SOLR-14608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255710#comment-17255710 ] ASF subversion and git services commented on SOLR-14608: Commit 4e2cd9aaead835af6b638faeefab231d7b9a in lucene-solr's branch refs/heads/jira/SOLR-14608-export from Joel Bernstein [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=4e2cd9a ] SOLR-14608: Code clean up > Faster sorting for the /export handler > -- > > Key: SOLR-14608 > URL: https://issues.apache.org/jira/browse/SOLR-14608 > Project: Solr > Issue Type: New Feature >Reporter: Joel Bernstein >Assignee: Joel Bernstein >Priority: Major > > The largest cost of the export handler is the sorting. This ticket will > implement an improved algorithm for sorting that should greatly increase > overall throughput for the export handler. > *The current algorithm is as follows:* > Collect a bitset of matching docs. Iterate over that bitset and materialize > the top level oridinals for the sort fields in the document and add them to > priority queue of size 3. Then export the top 3 docs, turn off the > bits in the bit set and iterate again until all docs are sorted and sent. > There are two performance bottlenecks with this approach: > 1) Materializing the top level ordinals adds a huge amount of overhead to the > sorting process. > 2) The size of priority queue, 30,000, adds significant overhead to sorting > operations. > *The new algorithm:* > Has a top level *merge sort iterator* that wraps segment level iterators that > perform segment level priority queue sorts. > *Segment level:* > The segment level docset will be iterated and the segment level ordinals for > the sort fields will be materialized and added to a segment level priority > queue. As the segment level iterator pops docs from the priority queue the > top level ordinals for the sort fields are materialized. Because the top > level ordinals are materialized AFTER the sort, they only need to be looked > up when the segment level ordinal changes. This takes advantage of the sort > to limit the lookups into the top level ordinal structures. This also > eliminates redundant lookups of top level ordinals that occur during the > multiple passes over the matching docset. > The segment level priority queues can be kept smaller than 30,000 to improve > performance of the sorting operations because the overall batch size will > still be 30,000 or greater when all the segment priority queue sizes are > added up. This allows for batch sizes much larger then 30,000 without using a > single large priority queue. The increased batch size means fewer iterations > over the matching docset and the decreased priority queue size means faster > sorting operations. > *Top level:* > A top level iterator does a merge sort over the segment level iterators by > comparing the top level ordinals materialized when the segment level docs are > popped from the segment level priority queues. This requires no extra memory > and will be very performant. > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Updated] (LUCENE-9570) Review code diffs after automatic formatting and correct problems before it is applied
[
https://issues.apache.org/jira/browse/LUCENE-9570?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dawid Weiss updated LUCENE-9570:
Description:
Review and correct all the javadocs before they're messed up by automatic
formatting. Apply project-by-project, review diff, correct. Lots of diffs but
it should be relatively quick.
*Reviewing diffs manually*
* switch to branch jira/LUCENE-9570 which the PR is based on:
{code:java}
git remote add dweiss g...@github.com:dweiss/lucene-solr.git
git fetch dweiss
git checkout jira/LUCENE-9570
{code}
* Open gradle/validation/spotless.gradle and locate the project/ package you
wish to review. Enable it in spotless.gradle by creating a corresponding switch
case block (refer to existing examples), for example:
{code:java}
case ":lucene:highlighter":
target "src/**"
targetExclude "**/resources/**", "**/overview.html"
break
{code}
* Reformat the code:
{code:java}
gradlew tidy && git diff -w > /tmp/diff.patch && git status
{code}
* Look at what has changed (git status) and review the differences manually
(/tmp/diff.patch). If everything looks ok, commit it directly to
jira/LUCENE-9570 or make a PR against that branch.
{code:java}
git commit -am ":lucene:core - src/**/org/apache/lucene/document/**"
{code}
*Packages remaining* (put your name next to a module you're working on to avoid
duplication).
* case ":lucene:analysis:icu":
* case ":lucene:analysis:kuromoji":
* case ":lucene:analysis:nori":
* case ":lucene:analysis:opennlp":
* case ":lucene:analysis:phonetic":
* case ":lucene:analysis:smartcn":
* case ":lucene:analysis:stempel":
* case ":lucene:backward-codecs":
* case ":lucene:benchmark":
* case ":lucene:classification":
* case ":lucene:codecs":
* case ":lucene:expressions":
* case ":lucene:facet": (Erick Erickson)
* case ":lucene:grouping":
* case ":lucene:join":
* case ":lucene:luke":
* case ":lucene:memory":
* case ":lucene:misc":
* case ":lucene:monitor":
* case ":lucene:queryparser":
* case ":lucene:replicator":
* case ":lucene:sandbox":
* case ":lucene:spatial3d":
* case ":lucene:spatial-extras":
* case ":lucene:suggest":
* case ":lucene:test-framework":
was:
Review and correct all the javadocs before they're messed up by automatic
formatting. Apply project-by-project, review diff, correct. Lots of diffs but
it should be relatively quick.
*Reviewing diffs manually*
* switch to branch jira/LUCENE-9570 which the PR is based on:
{code:java}
git remote add dweiss g...@github.com:dweiss/lucene-solr.git
git fetch dweiss
git checkout jira/LUCENE-9570
{code}
* Open gradle/validation/spotless.gradle and locate the project/ package you
wish to review. Enable it in spotless.gradle by creating a corresponding switch
case block (refer to existing examples), for example:
{code:java}
case ":lucene:highlighter":
target "src/**"
targetExclude "**/resources/**", "**/overview.html"
break
{code}
* Reformat the code:
{code:java}
gradlew tidy && git diff -w > /tmp/diff.patch && git status
{code}
* Look at what has changed (git status) and review the differences manually
(/tmp/diff.patch). If everything looks ok, commit it directly to
jira/LUCENE-9570 or make a PR against that branch.
{code:java}
git commit -am ":lucene:core - src/**/org/apache/lucene/document/**"
{code}
*Packages remaining* (put your name next to a module you're working on to avoid
duplication).
* case ":lucene:analysis:icu":
* case ":lucene:analysis:kuromoji":
* case ":lucene:analysis:nori":
* case ":lucene:analysis:opennlp":
* case ":lucene:analysis:phonetic":
* case ":lucene:analysis:smartcn":
* case ":lucene:analysis:stempel":
* case ":lucene:backward-codecs":
* case ":lucene:benchmark":
* case ":lucene:classification":
* case ":lucene:codecs":
* case ":lucene:demo":
* case ":lucene:expressions":
* case ":lucene:facet": (Erick Erickson)
* case ":lucene:grouping":
* case ":lucene:join":
* case ":lucene:luke":
* case ":lucene:memory":
* case ":lucene:misc":
* case ":lucene:monitor":
* case ":lucene:queryparser":
* case ":lucene:replicator":
* case ":lucene:sandbox":
* case ":lucene:spatial3d":
* case ":lucene:spatial-extras":
* case ":lucene:suggest":
* case ":lucene:test-framework":
> Review code diffs after automatic formatting and correct problems before it
> is applied
> --
>
> Key: LUCENE-9570
> URL: https://issues.apache.org/jira/browse/LUCENE-9570
> Project: Lucene - Core
> Issue Type: Sub-task
>Reporter: Dawid Weiss
>Assignee: Dawid Weiss
>Priority: Blocker
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Review and correct all the javadocs before they're messed up by automatic
> form
[GitHub] [lucene-solr] dweiss opened a new pull request #2171: LUCENE-9650: disable errorprone on jdk16+
dweiss opened a new pull request #2171: URL: https://github.com/apache/lucene-solr/pull/2171 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-9650) Errorprone on master/gradle no longer works with JDK-16
[
https://issues.apache.org/jira/browse/LUCENE-9650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255722#comment-17255722
]
Dawid Weiss commented on LUCENE-9650:
-
Maybe you're right. I filed a PR. Please merge if you think it's ok.
> Errorprone on master/gradle no longer works with JDK-16
> ---
>
> Key: LUCENE-9650
> URL: https://issues.apache.org/jira/browse/LUCENE-9650
> Project: Lucene - Core
> Issue Type: Bug
> Components: general/build
>Affects Versions: master (9.0)
>Reporter: Uwe Schindler
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> JDK-16 no longer allows access to internal classes of any module by default.
> It looks like errorprone tries to access some internals from the Java
> compiler. This now fails with Exception. You have to fully open the module or
> pass `--illegal-access=allow`.
> We have 3 options:
> - install an update of errorprone
> - disable error-prone if we detect a runtimeJdk with version >=16
> - run javac as a separate forked task (i think we do already) and pass
> `--illegal-access=allow` or open the internal compile module.
> Error message:
> {noformat}
> > Task :solr:solr-ref-guide:compileJava FAILED
> Exception in thread "main" java.lang.IllegalAccessError: class
> com.google.errorprone.ErrorProneJavacPlugin (in unnamed module @0x887af79)
> cannot access class com.sun.tools.javac.api.BasicJavacTask (in module
> jdk.compiler) because module jdk.compiler does not export
> com.sun.tools.javac.api to unnamed module @0x887af79
> at
> com.google.errorprone.ErrorProneJavacPlugin.init(ErrorProneJavacPlugin.java:38)
> at
> jdk.compiler/com.sun.tools.javac.api.BasicJavacTask.initPlugin(BasicJavacTask.java:254)
> at
> jdk.compiler/com.sun.tools.javac.api.BasicJavacTask.initPlugins(BasicJavacTask.java:228)
> at jdk.compiler/com.sun.tools.javac.main.Main.compile(Main.java:292)
> at jdk.compiler/com.sun.tools.javac.main.Main.compile(Main.java:176)
> at jdk.compiler/com.sun.tools.javac.Main.compile(Main.java:64)
> at jdk.compiler/com.sun.tools.javac.Main.main(Main.java:50)
> {noformat}
> Last failed build:
> https://jenkins.thetaphi.de/job/Lucene-Solr-master-Linux/29129/
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] megancarey commented on a change in pull request #2148: SOLR-15052: Per-replica states for reducing overseer bottlenecks
megancarey commented on a change in pull request #2148:
URL: https://github.com/apache/lucene-solr/pull/2148#discussion_r549502516
##
File path:
solr/core/src/java/org/apache/solr/cloud/ShardLeaderElectionContextBase.java
##
@@ -179,17 +181,19 @@ void runLeaderProcess(boolean weAreReplacement, int
pauseBeforeStartMs)
ZkStateReader.STATE_PROP, Replica.State.ACTIVE.toString());
assert zkController != null;
assert zkController.getOverseer() != null;
- zkController.getOverseer().offerStateUpdate(Utils.toJSON(m));
+ DocCollection coll = zkStateReader.getCollection(this.collection);
+ if (coll == null || coll.getStateFormat() < 2 ||
ZkController.sendToOverseer(coll, id)) {
Review comment:
Nit: first two checks are run in sendToOverseer, are you checking here
to avoid opening a new stackframe?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] megancarey commented on a change in pull request #2148: SOLR-15052: Per-replica states for reducing overseer bottlenecks
megancarey commented on a change in pull request #2148:
URL: https://github.com/apache/lucene-solr/pull/2148#discussion_r549503500
##
File path: solr/core/src/java/org/apache/solr/cloud/ZkController.java
##
@@ -1609,12 +1611,41 @@ public void publish(final CoreDescriptor cd, final
Replica.State state, boolean
if (updateLastState) {
cd.getCloudDescriptor().setLastPublished(state);
}
- overseerJobQueue.offer(Utils.toJSON(m));
+ DocCollection coll = zkStateReader.getCollection(collection);
+ if (forcePublish || sendToOverseer(coll, coreNodeName)) {
+overseerJobQueue.offer(Utils.toJSON(m));
+ } else {
+//if (log.isInfoEnabled()) {
+ //nocommit make this debug
+ log.info("bypassed overseer for message : {}",
Utils.toJSONString(m));
+//}
+PerReplicaStates perReplicaStates =
PerReplicaStates.fetch(coll.getZNode(), zkClient, coll.getPerReplicaStates());
+PerReplicaStates.WriteOps ops =
PerReplicaStates.WriteOps.flipState(coreNodeName, state, perReplicaStates);
+PerReplicaStates.persist(ops, coll.getZNode(), zkClient);
+ }
} finally {
MDCLoggingContext.clear();
}
}
+ /**
+ * Whether a message needs to be sent to overseer or not
+ */
+ static boolean sendToOverseer(DocCollection coll, String replicaName) {
+if (coll == null) return true;
+if (coll.getStateFormat() < 2 || !coll.isPerReplicaState()) return true;
+Replica r = coll.getReplica(replicaName);
+if (r == null) return true;
+Slice shard = coll.getSlice(r.slice);
+if (shard == null) return true;//very unlikely
+if (shard.getState() == Slice.State.RECOVERY) return true;
+if (shard.getParent() != null) return true;
+for (Slice slice : coll.getSlices()) {
+ if (Objects.equals(shard.getName(), slice.getParent())) return true;
Review comment:
Won't this always be true since `shard` was picked from coll:slices list?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] uschindler commented on pull request #2171: LUCENE-9650: disable errorprone on jdk16+
uschindler commented on pull request #2171: URL: https://github.com/apache/lucene-solr/pull/2171#issuecomment-751881688 Hi, this works fine for me locally: ``` > gradlew compileJava -Druntime.java.home=/path/to/jdk-16 To honour the JVM settings for this build a new JVM will be forked. Please consider using the daemon: https://docs.gradle.org/6.6.1/userguide/gradle_daemon.html. Daemon will be stopped at the end of the build stopping after processing > Configure project : WARNING: errorprone disabled (won't work with JDK 16) > Task :altJvmWarning NOTE: Alternative java toolchain will be used for compilation and tests: Project will use Java 16 from: C:\Program Files\java\jdk-16 Gradle runs with Java 11 from: C:\Program Files\Java\jdk-11.0.8 > Task :solr:solrj:compileJava Note: Some input files use or override a deprecated API. Note: Recompile with -Xlint:deprecation for details. ``` Without this patch it fails as on Jenkins. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] uschindler merged pull request #2171: LUCENE-9650: disable errorprone on jdk16+
uschindler merged pull request #2171: URL: https://github.com/apache/lucene-solr/pull/2171 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-9650) Errorprone on master/gradle no longer works with JDK-16
[
https://issues.apache.org/jira/browse/LUCENE-9650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255735#comment-17255735
]
ASF subversion and git services commented on LUCENE-9650:
-
Commit 38c9d2ab76f53a9c5b40fd71e5e9c8095b06587c in lucene-solr's branch
refs/heads/master from Dawid Weiss
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=38c9d2a ]
LUCENE-9650: disable errorprone on jdk16+ (#2171)
> Errorprone on master/gradle no longer works with JDK-16
> ---
>
> Key: LUCENE-9650
> URL: https://issues.apache.org/jira/browse/LUCENE-9650
> Project: Lucene - Core
> Issue Type: Bug
> Components: general/build
>Affects Versions: master (9.0)
>Reporter: Uwe Schindler
>Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> JDK-16 no longer allows access to internal classes of any module by default.
> It looks like errorprone tries to access some internals from the Java
> compiler. This now fails with Exception. You have to fully open the module or
> pass `--illegal-access=allow`.
> We have 3 options:
> - install an update of errorprone
> - disable error-prone if we detect a runtimeJdk with version >=16
> - run javac as a separate forked task (i think we do already) and pass
> `--illegal-access=allow` or open the internal compile module.
> Error message:
> {noformat}
> > Task :solr:solr-ref-guide:compileJava FAILED
> Exception in thread "main" java.lang.IllegalAccessError: class
> com.google.errorprone.ErrorProneJavacPlugin (in unnamed module @0x887af79)
> cannot access class com.sun.tools.javac.api.BasicJavacTask (in module
> jdk.compiler) because module jdk.compiler does not export
> com.sun.tools.javac.api to unnamed module @0x887af79
> at
> com.google.errorprone.ErrorProneJavacPlugin.init(ErrorProneJavacPlugin.java:38)
> at
> jdk.compiler/com.sun.tools.javac.api.BasicJavacTask.initPlugin(BasicJavacTask.java:254)
> at
> jdk.compiler/com.sun.tools.javac.api.BasicJavacTask.initPlugins(BasicJavacTask.java:228)
> at jdk.compiler/com.sun.tools.javac.main.Main.compile(Main.java:292)
> at jdk.compiler/com.sun.tools.javac.main.Main.compile(Main.java:176)
> at jdk.compiler/com.sun.tools.javac.Main.compile(Main.java:64)
> at jdk.compiler/com.sun.tools.javac.Main.main(Main.java:50)
> {noformat}
> Last failed build:
> https://jenkins.thetaphi.de/job/Lucene-Solr-master-Linux/29129/
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-9650) Errorprone on master/gradle no longer works with JDK-16
[
https://issues.apache.org/jira/browse/LUCENE-9650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255736#comment-17255736
]
Uwe Schindler commented on LUCENE-9650:
---
Hi,
I tried it locally and it worked fine.
Nevertheless we should maybe wait for updates of Gradle and revisit this again.
Gradle itsself no longer works with recent JDK16 at all (for same reasons). But
this was fully expected to me (because it prohibits any access to internal APIs
by default). That's the best change finally in JDK 16: Encapsulate all private
stuff (except Unsafe and a few others).
> Errorprone on master/gradle no longer works with JDK-16
> ---
>
> Key: LUCENE-9650
> URL: https://issues.apache.org/jira/browse/LUCENE-9650
> Project: Lucene - Core
> Issue Type: Bug
> Components: general/build
>Affects Versions: master (9.0)
>Reporter: Uwe Schindler
>Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> JDK-16 no longer allows access to internal classes of any module by default.
> It looks like errorprone tries to access some internals from the Java
> compiler. This now fails with Exception. You have to fully open the module or
> pass `--illegal-access=allow`.
> We have 3 options:
> - install an update of errorprone
> - disable error-prone if we detect a runtimeJdk with version >=16
> - run javac as a separate forked task (i think we do already) and pass
> `--illegal-access=allow` or open the internal compile module.
> Error message:
> {noformat}
> > Task :solr:solr-ref-guide:compileJava FAILED
> Exception in thread "main" java.lang.IllegalAccessError: class
> com.google.errorprone.ErrorProneJavacPlugin (in unnamed module @0x887af79)
> cannot access class com.sun.tools.javac.api.BasicJavacTask (in module
> jdk.compiler) because module jdk.compiler does not export
> com.sun.tools.javac.api to unnamed module @0x887af79
> at
> com.google.errorprone.ErrorProneJavacPlugin.init(ErrorProneJavacPlugin.java:38)
> at
> jdk.compiler/com.sun.tools.javac.api.BasicJavacTask.initPlugin(BasicJavacTask.java:254)
> at
> jdk.compiler/com.sun.tools.javac.api.BasicJavacTask.initPlugins(BasicJavacTask.java:228)
> at jdk.compiler/com.sun.tools.javac.main.Main.compile(Main.java:292)
> at jdk.compiler/com.sun.tools.javac.main.Main.compile(Main.java:176)
> at jdk.compiler/com.sun.tools.javac.Main.compile(Main.java:64)
> at jdk.compiler/com.sun.tools.javac.Main.main(Main.java:50)
> {noformat}
> Last failed build:
> https://jenkins.thetaphi.de/job/Lucene-Solr-master-Linux/29129/
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Resolved] (LUCENE-9650) Errorprone on master/gradle no longer works with JDK-16
[
https://issues.apache.org/jira/browse/LUCENE-9650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler resolved LUCENE-9650.
---
Fix Version/s: master (9.0)
Assignee: Dawid Weiss
Resolution: Fixed
Thanks for help.
> Errorprone on master/gradle no longer works with JDK-16
> ---
>
> Key: LUCENE-9650
> URL: https://issues.apache.org/jira/browse/LUCENE-9650
> Project: Lucene - Core
> Issue Type: Bug
> Components: general/build
>Affects Versions: master (9.0)
>Reporter: Uwe Schindler
>Assignee: Dawid Weiss
>Priority: Major
> Fix For: master (9.0)
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> JDK-16 no longer allows access to internal classes of any module by default.
> It looks like errorprone tries to access some internals from the Java
> compiler. This now fails with Exception. You have to fully open the module or
> pass `--illegal-access=allow`.
> We have 3 options:
> - install an update of errorprone
> - disable error-prone if we detect a runtimeJdk with version >=16
> - run javac as a separate forked task (i think we do already) and pass
> `--illegal-access=allow` or open the internal compile module.
> Error message:
> {noformat}
> > Task :solr:solr-ref-guide:compileJava FAILED
> Exception in thread "main" java.lang.IllegalAccessError: class
> com.google.errorprone.ErrorProneJavacPlugin (in unnamed module @0x887af79)
> cannot access class com.sun.tools.javac.api.BasicJavacTask (in module
> jdk.compiler) because module jdk.compiler does not export
> com.sun.tools.javac.api to unnamed module @0x887af79
> at
> com.google.errorprone.ErrorProneJavacPlugin.init(ErrorProneJavacPlugin.java:38)
> at
> jdk.compiler/com.sun.tools.javac.api.BasicJavacTask.initPlugin(BasicJavacTask.java:254)
> at
> jdk.compiler/com.sun.tools.javac.api.BasicJavacTask.initPlugins(BasicJavacTask.java:228)
> at jdk.compiler/com.sun.tools.javac.main.Main.compile(Main.java:292)
> at jdk.compiler/com.sun.tools.javac.main.Main.compile(Main.java:176)
> at jdk.compiler/com.sun.tools.javac.Main.compile(Main.java:64)
> at jdk.compiler/com.sun.tools.javac.Main.main(Main.java:50)
> {noformat}
> Last failed build:
> https://jenkins.thetaphi.de/job/Lucene-Solr-master-Linux/29129/
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] megancarey commented on a change in pull request #2148: SOLR-15052: Per-replica states for reducing overseer bottlenecks
megancarey commented on a change in pull request #2148:
URL: https://github.com/apache/lucene-solr/pull/2148#discussion_r549506465
##
File path:
solr/core/src/java/org/apache/solr/cloud/overseer/CollectionMutator.java
##
@@ -107,7 +111,21 @@ public ZkWriteCommand modifyCollection(final ClusterState
clusterState, ZkNodePr
DocCollection coll =
clusterState.getCollection(message.getStr(COLLECTION_PROP));
Map m = coll.shallowCopy();
boolean hasAnyOps = false;
+PerReplicaStates.WriteOps replicaOps = null;
for (String prop :
CollectionAdminRequest.MODIFIABLE_COLLECTION_PROPERTIES) {
+ if (prop.equals(DocCollection.PER_REPLICA_STATE)) {
Review comment:
Nit: move special prop case below line 136, where other such props are
handled
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] megancarey commented on a change in pull request #2148: SOLR-15052: Per-replica states for reducing overseer bottlenecks
megancarey commented on a change in pull request #2148:
URL: https://github.com/apache/lucene-solr/pull/2148#discussion_r549506465
##
File path:
solr/core/src/java/org/apache/solr/cloud/overseer/CollectionMutator.java
##
@@ -107,7 +111,21 @@ public ZkWriteCommand modifyCollection(final ClusterState
clusterState, ZkNodePr
DocCollection coll =
clusterState.getCollection(message.getStr(COLLECTION_PROP));
Map m = coll.shallowCopy();
boolean hasAnyOps = false;
+PerReplicaStates.WriteOps replicaOps = null;
for (String prop :
CollectionAdminRequest.MODIFIABLE_COLLECTION_PROPERTIES) {
+ if (prop.equals(DocCollection.PER_REPLICA_STATE)) {
Review comment:
Nit: move special prop case below line 136 (previously L118), where
other such props are handled
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] megancarey commented on a change in pull request #2148: SOLR-15052: Per-replica states for reducing overseer bottlenecks
megancarey commented on a change in pull request #2148:
URL: https://github.com/apache/lucene-solr/pull/2148#discussion_r549516577
##
File path: solr/core/src/java/org/apache/solr/cloud/overseer/SliceMutator.java
##
@@ -132,7 +160,7 @@ public ZkWriteCommand setShardLeader(ClusterState
clusterState, ZkNodeProps mess
if (replica == oldLeader && !coreURL.equals(leaderUrl)) {
replica = new ReplicaMutator(cloudManager).unsetLeader(replica);
} else if (coreURL.equals(leaderUrl)) {
-replica = new ReplicaMutator(cloudManager).setLeader(replica);
+newLeader= replica = new
ReplicaMutator(cloudManager).setLeader(replica);
Review comment:
Supernit: `newLeader =`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] megancarey commented on a change in pull request #2148: SOLR-15052: Per-replica states for reducing overseer bottlenecks
megancarey commented on a change in pull request #2148:
URL: https://github.com/apache/lucene-solr/pull/2148#discussion_r549519765
##
File path: solr/solrj/src/java/org/apache/solr/common/cloud/ClusterState.java
##
@@ -256,6 +263,12 @@ private static DocCollection collectionFromObjects(String
name, Map props;
Map slices;
+if
("true".equals(String.valueOf(objs.get(DocCollection.PER_REPLICA_STATE {
Review comment:
Nit: I'd prefer
`Boolean.parseBoolean(String.valueOf(objs.get(DocCollection.PER_REPLICA_STATE)))`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] megancarey commented on a change in pull request #2148: SOLR-15052: Per-replica states for reducing overseer bottlenecks
megancarey commented on a change in pull request #2148:
URL: https://github.com/apache/lucene-solr/pull/2148#discussion_r549522964
##
File path: solr/solrj/src/java/org/apache/solr/common/cloud/Replica.java
##
@@ -70,16 +75,24 @@
* cluster and it's state should be discarded.
*
*/
-RECOVERY_FAILED;
-
+RECOVERY_FAILED("F");
+
+/**short name for a state. Used to encode this in the state node see
{@link PerReplicaStates.State}
+ */
+public final String shortName;
+
+State(String c) {
+ this.shortName = c;
+}
+
@Override
public String toString() {
return super.toString().toLowerCase(Locale.ROOT);
Review comment:
What is the value of having upper case here if we translate to lower
case elsewhere?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] noblepaul commented on a change in pull request #2148: SOLR-15052: Per-replica states for reducing overseer bottlenecks
noblepaul commented on a change in pull request #2148:
URL: https://github.com/apache/lucene-solr/pull/2148#discussion_r549539576
##
File path: solr/solrj/src/java/org/apache/solr/common/cloud/Replica.java
##
@@ -70,16 +75,24 @@
* cluster and it's state should be discarded.
*
*/
-RECOVERY_FAILED;
-
+RECOVERY_FAILED("F");
+
+/**short name for a state. Used to encode this in the state node see
{@link PerReplicaStates.State}
+ */
+public final String shortName;
+
+State(String c) {
+ this.shortName = c;
+}
+
@Override
public String toString() {
return super.toString().toLowerCase(Locale.ROOT);
Review comment:
The shortname is not the same as name.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] noblepaul commented on a change in pull request #2148: SOLR-15052: Per-replica states for reducing overseer bottlenecks
noblepaul commented on a change in pull request #2148:
URL: https://github.com/apache/lucene-solr/pull/2148#discussion_r549541668
##
File path:
solr/core/src/java/org/apache/solr/cloud/ShardLeaderElectionContextBase.java
##
@@ -179,17 +181,19 @@ void runLeaderProcess(boolean weAreReplacement, int
pauseBeforeStartMs)
ZkStateReader.STATE_PROP, Replica.State.ACTIVE.toString());
assert zkController != null;
assert zkController.getOverseer() != null;
- zkController.getOverseer().offerStateUpdate(Utils.toJSON(m));
+ DocCollection coll = zkStateReader.getCollection(this.collection);
+ if (coll == null || coll.getStateFormat() < 2 ||
ZkController.sendToOverseer(coll, id)) {
Review comment:
yeah, early termination
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] zacharymorn commented on a change in pull request #2141: LUCENE-9346: Support minimumNumberShouldMatch in WANDScorer
zacharymorn commented on a change in pull request #2141:
URL: https://github.com/apache/lucene-solr/pull/2141#discussion_r549545541
##
File path:
lucene/core/src/java/org/apache/lucene/search/Boolean2ScorerSupplier.java
##
@@ -195,10 +201,13 @@ private Scorer opt(Collection optional,
int minShouldMatch,
for (ScorerSupplier scorer : optional) {
optionalScorers.add(scorer.get(leadCost));
}
- if (minShouldMatch > 1) {
+
+ if (scoreMode == ScoreMode.TOP_SCORES) {
+return new WANDScorer(weight, optionalScorers, minShouldMatch);
+ } else if (minShouldMatch > 1) {
+// nocommit minShouldMath > 1 && scoreMode != ScoreMode.TOP_SCORES
still requires MinShouldMatchSumScorer.
+// Do we want to depcate this entirely now ?
Review comment:
Fixed. Thanks!
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] zacharymorn commented on a change in pull request #2141: LUCENE-9346: Support minimumNumberShouldMatch in WANDScorer
zacharymorn commented on a change in pull request #2141:
URL: https://github.com/apache/lucene-solr/pull/2141#discussion_r549545575
##
File path: lucene/core/src/java/org/apache/lucene/search/WANDScorer.java
##
@@ -130,10 +130,19 @@ private static long scaleMinScore(float minScore, int
scalingFactor) {
int upTo; // upper bound for which max scores are valid
- WANDScorer(Weight weight, Collection scorers) throws IOException {
+ int minShouldMatch;
+ int freq;
+
+ WANDScorer(Weight weight, Collection scorers, int minShouldMatch)
throws IOException {
super(weight);
+if (minShouldMatch > scorers.size()) {
Review comment:
Makes sense. I've updated the condition and the exception message.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] zacharymorn commented on a change in pull request #2141: LUCENE-9346: Support minimumNumberShouldMatch in WANDScorer
zacharymorn commented on a change in pull request #2141:
URL: https://github.com/apache/lucene-solr/pull/2141#discussion_r549545837
##
File path: lucene/core/src/java/org/apache/lucene/search/WANDScorer.java
##
@@ -130,10 +130,19 @@ private static long scaleMinScore(float minScore, int
scalingFactor) {
int upTo; // upper bound for which max scores are valid
- WANDScorer(Weight weight, Collection scorers) throws IOException {
+ int minShouldMatch;
+ int freq;
+
+ WANDScorer(Weight weight, Collection scorers, int minShouldMatch)
throws IOException {
super(weight);
+if (minShouldMatch > scorers.size()) {
+ throw new IllegalArgumentException("minShouldMatch should be <= the
number of scorers");
+}
+
this.minCompetitiveScore = 0;
+this.minShouldMatch = minShouldMatch > 0 ? minShouldMatch : 0;
Review comment:
I put it there originally to guard against any accidental invalid
negative minShouldMatch being passed in, but yeah it should probably be handled
as assertion. I've updated it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] zacharymorn commented on a change in pull request #2141: LUCENE-9346: Support minimumNumberShouldMatch in WANDScorer
zacharymorn commented on a change in pull request #2141:
URL: https://github.com/apache/lucene-solr/pull/2141#discussion_r549545859
##
File path: lucene/core/src/java/org/apache/lucene/search/WANDScorer.java
##
@@ -271,6 +280,19 @@ public boolean matches() throws IOException {
return false;
}
}
+
+// minCompetitiveScore satisfied, now checks if the doc has enough
required number of matches
+// Combining this loop with the above makes for complicated
conditional checks, so keeping them separate for readability
Review comment:
Makes sense. I gave this a second try and actually able to arrive at a
clean looking solution. Please let me know if this version looks good.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] zacharymorn commented on pull request #2052: LUCENE-8982: Make NativeUnixDirectory pure java with FileChannel direct IO flag, and rename to DirectIODirectory
zacharymorn commented on pull request #2052: URL: https://github.com/apache/lucene-solr/pull/2052#issuecomment-751925231 Hi @uschindler, I will have some time in the next few days. Do you mind me taking a look at what's left here and potentially pushing some changes? Don't want to get in the way though if you have the changes almost ready. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Created] (SOLR-15062) /api/cluster/zk/ls should give the stat of the current node
Noble Paul created SOLR-15062: - Summary: /api/cluster/zk/ls should give the stat of the current node Key: SOLR-15062 URL: https://issues.apache.org/jira/browse/SOLR-15062 Project: Solr Issue Type: Task Security Level: Public (Default Security Level. Issues are Public) Reporter: Noble Paul Assignee: Noble Paul -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Updated] (SOLR-15062) /api/cluster/zk/ls should give the stat of the current node
[
https://issues.apache.org/jira/browse/SOLR-15062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Noble Paul updated SOLR-15062:
--
Description:
{{GET
http://localhost:8983/api/cluster/zk/ls/collections/gettingstarted/state.json}}
{code:json}
{
"stat":{
"version":26,
"aversion":0,
"children":0,
"ctime":1609217140190,
"cversion":0,
"czxid":405,
"ephemeralOwner":0,
"mtime":1609220395103,
"mzxid":643,
"pzxid":405,
"dataLength":1382},
"/collections/gettingstarted/state.json":{},
"WARNING":"This response format is experimental. It is likely to change in
the future."}
{code}
> /api/cluster/zk/ls should give the stat of the current node
> ---
>
> Key: SOLR-15062
> URL: https://issues.apache.org/jira/browse/SOLR-15062
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Noble Paul
>Assignee: Noble Paul
>Priority: Minor
>
> {{GET
> http://localhost:8983/api/cluster/zk/ls/collections/gettingstarted/state.json}}
> {code:json}
> {
> "stat":{
> "version":26,
> "aversion":0,
> "children":0,
> "ctime":1609217140190,
> "cversion":0,
> "czxid":405,
> "ephemeralOwner":0,
> "mtime":1609220395103,
> "mzxid":643,
> "pzxid":405,
> "dataLength":1382},
> "/collections/gettingstarted/state.json":{},
> "WARNING":"This response format is experimental. It is likely to change in
> the future."}
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] tflobbe commented on a change in pull request #2169: SOLR-14723: Remove the class attribute for the caches in the _default/example configsets
tflobbe commented on a change in pull request #2169: URL: https://github.com/apache/lucene-solr/pull/2169#discussion_r549576007 ## File path: solr/core/src/test-files/solr/collection1/conf/solrconfig-caching.xml ## @@ -21,19 +21,16 @@ Review comment: Could you fix this docs to state that the default cache class is `CaffeineCache`? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] noblepaul opened a new pull request #2172: SOLR-15062: /api/cluster/zk/ls should give the stat of the current node
noblepaul opened a new pull request #2172: URL: https://github.com/apache/lucene-solr/pull/2172 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] tflobbe commented on pull request #2169: SOLR-14723: Remove the class attribute for the caches in the _default/example configsets
tflobbe commented on pull request #2169: URL: https://github.com/apache/lucene-solr/pull/2169#issuecomment-751963271 For `TestSolr4Spatial2`, I think you just need to add [this line](https://github.com/apache/lucene-solr/blob/master/solr/core/src/test/org/apache/solr/search/TestSolr4Spatial2.java#L323) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-9650) Errorprone on master/gradle no longer works with JDK-16
[
https://issues.apache.org/jira/browse/LUCENE-9650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17255838#comment-17255838
]
Dawid Weiss commented on LUCENE-9650:
-
Sure. Remember you can still compile/test with jdk16 running gradle on a less
recent JDK - this has been supported for some time now. See help/jvms.txt
> Errorprone on master/gradle no longer works with JDK-16
> ---
>
> Key: LUCENE-9650
> URL: https://issues.apache.org/jira/browse/LUCENE-9650
> Project: Lucene - Core
> Issue Type: Bug
> Components: general/build
>Affects Versions: master (9.0)
>Reporter: Uwe Schindler
>Assignee: Dawid Weiss
>Priority: Major
> Fix For: master (9.0)
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> JDK-16 no longer allows access to internal classes of any module by default.
> It looks like errorprone tries to access some internals from the Java
> compiler. This now fails with Exception. You have to fully open the module or
> pass `--illegal-access=allow`.
> We have 3 options:
> - install an update of errorprone
> - disable error-prone if we detect a runtimeJdk with version >=16
> - run javac as a separate forked task (i think we do already) and pass
> `--illegal-access=allow` or open the internal compile module.
> Error message:
> {noformat}
> > Task :solr:solr-ref-guide:compileJava FAILED
> Exception in thread "main" java.lang.IllegalAccessError: class
> com.google.errorprone.ErrorProneJavacPlugin (in unnamed module @0x887af79)
> cannot access class com.sun.tools.javac.api.BasicJavacTask (in module
> jdk.compiler) because module jdk.compiler does not export
> com.sun.tools.javac.api to unnamed module @0x887af79
> at
> com.google.errorprone.ErrorProneJavacPlugin.init(ErrorProneJavacPlugin.java:38)
> at
> jdk.compiler/com.sun.tools.javac.api.BasicJavacTask.initPlugin(BasicJavacTask.java:254)
> at
> jdk.compiler/com.sun.tools.javac.api.BasicJavacTask.initPlugins(BasicJavacTask.java:228)
> at jdk.compiler/com.sun.tools.javac.main.Main.compile(Main.java:292)
> at jdk.compiler/com.sun.tools.javac.main.Main.compile(Main.java:176)
> at jdk.compiler/com.sun.tools.javac.Main.compile(Main.java:64)
> at jdk.compiler/com.sun.tools.javac.Main.main(Main.java:50)
> {noformat}
> Last failed build:
> https://jenkins.thetaphi.de/job/Lucene-Solr-master-Linux/29129/
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
