[jira] [Created] (SOLR-14532) Add iml file to gitignore
Andras Salamon created SOLR-14532:
-
Summary: Add iml file to gitignore
Key: SOLR-14532
URL: https://issues.apache.org/jira/browse/SOLR-14532
Project: Solr
Issue Type: Bug
Security Level: Public (Default Security Level. Issues are Public)
Reporter: Andras Salamon
If I execute {{gradlew idea}} in my {{lucene-solr-upstream}} directory, it will
create three files in the root directory:
{noformat}
lucene-solr-upstream.iml
lucene-solr-upstream.ipr
lucene-solr-upstream.iws
{noformat}
Git will ignore the {{ipr}} and the {{iws}} file, but it lists the iml file as
a new file. We should also ignore that one.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Updated] (SOLR-14532) Add iml file to gitignore
[
https://issues.apache.org/jira/browse/SOLR-14532?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andras Salamon updated SOLR-14532:
--
Attachment: SOLR-14532.patch
> Add iml file to gitignore
> -
>
> Key: SOLR-14532
> URL: https://issues.apache.org/jira/browse/SOLR-14532
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Andras Salamon
>Priority: Trivial
> Attachments: SOLR-14532.patch
>
>
> If I execute {{gradlew idea}} in my {{lucene-solr-upstream}} directory, it
> will create three files in the root directory:
> {noformat}
> lucene-solr-upstream.iml
> lucene-solr-upstream.ipr
> lucene-solr-upstream.iws
> {noformat}
> Git will ignore the {{ipr}} and the {{iws}} file, but it lists the iml file
> as a new file. We should also ignore that one.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14532) Add iml file to gitignore
[
https://issues.apache.org/jira/browse/SOLR-14532?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123469#comment-17123469
]
Andras Salamon commented on SOLR-14532:
---
Gitignore only ignored {{parent.iml}} probably ant was using this filename. We
should ignore all iml files, but only in the root directory, because
{{dev-tools}} directory contains other iml files as well.
> Add iml file to gitignore
> -
>
> Key: SOLR-14532
> URL: https://issues.apache.org/jira/browse/SOLR-14532
> Project: Solr
> Issue Type: Bug
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Andras Salamon
>Priority: Trivial
> Attachments: SOLR-14532.patch
>
>
> If I execute {{gradlew idea}} in my {{lucene-solr-upstream}} directory, it
> will create three files in the root directory:
> {noformat}
> lucene-solr-upstream.iml
> lucene-solr-upstream.ipr
> lucene-solr-upstream.iws
> {noformat}
> Git will ignore the {{ipr}} and the {{iws}} file, but it lists the iml file
> as a new file. We should also ignore that one.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-9382) Lucene's gradle version can't cope with Java 14
[
https://issues.apache.org/jira/browse/LUCENE-9382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123653#comment-17123653
]
Dawid Weiss commented on LUCENE-9382:
-
{quote}bq. Am I correct that this change makes the script work and there's
nothing for me to do except say thanks?
{quote}
Yes - I just reorganized the structure a bit and it passes. Seems like a groovy
problem rather than gradle's. I'll limit this to solr-modules only and commit.
> Lucene's gradle version can't cope with Java 14
> ---
>
> Key: LUCENE-9382
> URL: https://issues.apache.org/jira/browse/LUCENE-9382
> Project: Lucene - Core
> Issue Type: Sub-task
>Reporter: Alan Woodward
>Assignee: Dawid Weiss
>Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> If you have JDK 14 installed as your default java, then attempting to use
> gradle within the lucene-solr project can result in errors, particularly if
> you have other projects that use more recent gradle versions on the same
> machine.
> ```
> java.lang.NoClassDefFoundError: Could not initialize class
> org.codehaus.groovy.vmplugin.v7.Java7
> at
> org.codehaus.groovy.vmplugin.VMPluginFactory.(VMPluginFactory.java:43)
> at
> org.codehaus.groovy.reflection.GroovyClassValueFactory.(GroovyClassValueFactory.java:35)
> ```
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14527) The 8.5.1 release can't be verified using PGP
[ https://issues.apache.org/jira/browse/SOLR-14527?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123671#comment-17123671 ] Ignacio Vera commented on SOLR-14527: - Thanks [~janhoy] > The 8.5.1 release can't be verified using PGP > - > > Key: SOLR-14527 > URL: https://issues.apache.org/jira/browse/SOLR-14527 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: website >Affects Versions: 8.5.1 >Reporter: Per Cederqvist >Priority: Major > > The [https://archive.apache.org/dist/lucene/solr/8.5.1/solr-8.5.1.tgz.asc] > signature of the > [https://archive.apache.org/dist/lucene/solr/8.5.1/solr-8.5.1.tgz] file is > made by the following key: > pub rsa4096 2019-07-10 [SC] > E58A6F4D5B2B48AC66D5E53BD4F181881A42F9E6 > uid [ unknown] Ignacio Vera (CODE SIGNING KEY) > sub rsa4096 2019-07-10 [E] > > However, that key is not included in > [https://archive.apache.org/dist/lucene/solr/KEYS,] so there is no way for me > to verify that the file is authentic. I could download the key from a > keyserver, but there are no signatures on the key, so I'm left with no way to > verify that the 8.5.1 distribution is legitimate. > I'm assuming this is just an omission, and that [~ivera] simply forgot to add > the key to the KEYS file. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-9382) Lucene's gradle version can't cope with Java 14
[ https://issues.apache.org/jira/browse/LUCENE-9382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123681#comment-17123681 ] ASF subversion and git services commented on LUCENE-9382: - Commit 3e8e5d8cf6477a60cd8019a41c657bcf313a174c in lucene-solr's branch refs/heads/master from Dawid Weiss [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=3e8e5d8 ] LUCENE-9382: update gradle to 6.4.1. (#1549) * LUCENE-9382: update gradle to 6.4.1. Requires minor changes around log call validation by restructuring the code around switches to a series of ifs. Piggybacking: apply log validation to :solr modules. Add inputs declaration so that task is not re-run on unmodified files. > Lucene's gradle version can't cope with Java 14 > --- > > Key: LUCENE-9382 > URL: https://issues.apache.org/jira/browse/LUCENE-9382 > Project: Lucene - Core > Issue Type: Sub-task >Reporter: Alan Woodward >Assignee: Dawid Weiss >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > If you have JDK 14 installed as your default java, then attempting to use > gradle within the lucene-solr project can result in errors, particularly if > you have other projects that use more recent gradle versions on the same > machine. > ``` > java.lang.NoClassDefFoundError: Could not initialize class > org.codehaus.groovy.vmplugin.v7.Java7 > at > org.codehaus.groovy.vmplugin.VMPluginFactory.(VMPluginFactory.java:43) > at > org.codehaus.groovy.reflection.GroovyClassValueFactory.(GroovyClassValueFactory.java:35) > ``` -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] dweiss merged pull request #1549: LUCENE-9382: update gradle to 6.4.1.
dweiss merged pull request #1549: URL: https://github.com/apache/lucene-solr/pull/1549 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (LUCENE-9382) Lucene's gradle version can't cope with Java 14
[ https://issues.apache.org/jira/browse/LUCENE-9382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123680#comment-17123680 ] ASF subversion and git services commented on LUCENE-9382: - Commit 3e8e5d8cf6477a60cd8019a41c657bcf313a174c in lucene-solr's branch refs/heads/master from Dawid Weiss [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=3e8e5d8 ] LUCENE-9382: update gradle to 6.4.1. (#1549) * LUCENE-9382: update gradle to 6.4.1. Requires minor changes around log call validation by restructuring the code around switches to a series of ifs. Piggybacking: apply log validation to :solr modules. Add inputs declaration so that task is not re-run on unmodified files. > Lucene's gradle version can't cope with Java 14 > --- > > Key: LUCENE-9382 > URL: https://issues.apache.org/jira/browse/LUCENE-9382 > Project: Lucene - Core > Issue Type: Sub-task >Reporter: Alan Woodward >Assignee: Dawid Weiss >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > > If you have JDK 14 installed as your default java, then attempting to use > gradle within the lucene-solr project can result in errors, particularly if > you have other projects that use more recent gradle versions on the same > machine. > ``` > java.lang.NoClassDefFoundError: Could not initialize class > org.codehaus.groovy.vmplugin.v7.Java7 > at > org.codehaus.groovy.vmplugin.VMPluginFactory.(VMPluginFactory.java:43) > at > org.codehaus.groovy.reflection.GroovyClassValueFactory.(GroovyClassValueFactory.java:35) > ``` -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Resolved] (LUCENE-9382) Lucene's gradle version can't cope with Java 14
[ https://issues.apache.org/jira/browse/LUCENE-9382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dawid Weiss resolved LUCENE-9382. - Fix Version/s: master (9.0) Resolution: Fixed > Lucene's gradle version can't cope with Java 14 > --- > > Key: LUCENE-9382 > URL: https://issues.apache.org/jira/browse/LUCENE-9382 > Project: Lucene - Core > Issue Type: Sub-task >Reporter: Alan Woodward >Assignee: Dawid Weiss >Priority: Major > Fix For: master (9.0) > > Time Spent: 20m > Remaining Estimate: 0h > > If you have JDK 14 installed as your default java, then attempting to use > gradle within the lucene-solr project can result in errors, particularly if > you have other projects that use more recent gradle versions on the same > machine. > ``` > java.lang.NoClassDefFoundError: Could not initialize class > org.codehaus.groovy.vmplugin.v7.Java7 > at > org.codehaus.groovy.vmplugin.VMPluginFactory.(VMPluginFactory.java:43) > at > org.codehaus.groovy.reflection.GroovyClassValueFactory.(GroovyClassValueFactory.java:35) > ``` -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14531) Refactor out internode requests from HttpShardHandler
[ https://issues.apache.org/jira/browse/SOLR-14531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123690#comment-17123690 ] Jan Høydahl commented on SOLR-14531: ?? > Refactor out internode requests from HttpShardHandler > - > > Key: SOLR-14531 > URL: https://issues.apache.org/jira/browse/SOLR-14531 > Project: Solr > Issue Type: Improvement > Security Level: Public(Default Security Level. Issues are Public) >Reporter: Noble Paul >Assignee: Noble Paul >Priority: Trivial > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] dweiss commented on pull request #1550: LUCENE-9383: benchmark module: Gradle conversion (complete)
dweiss commented on pull request #1550: URL: https://github.com/apache/lucene-solr/pull/1550#issuecomment-637493362 > I switched from "java-library" type of Gradle plugin/module to more plainly "java" because this module isn't a library (isn't something depended on by anything), it's closer to an app. Fine. > I tried type "application" but I didn't have the same control that the "JavaExec" task gives you. One consequence of not using "java-library" is that the names of the categories of dependencies are different, and so this appears odd/unusual relative to the other modules. This isn't accurate. The names of dependency configurations are different (and their setup is different). Gradle plugins (such as java, java-library, etc.) set up defaultsa for essentially the same underlying infrastructure. So you could just stay with 'java-library' and it'd still be fine. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Updated] (SOLR-14531) Refactor out internode requests from HttpShardHandler
[
https://issues.apache.org/jira/browse/SOLR-14531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Noble Paul updated SOLR-14531:
--
Description: We need to improve the readability of {{HttpShardHandler}} by
cutting it into smaller pieces
> Refactor out internode requests from HttpShardHandler
> -
>
> Key: SOLR-14531
> URL: https://issues.apache.org/jira/browse/SOLR-14531
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Noble Paul
>Assignee: Noble Paul
>Priority: Trivial
>
> We need to improve the readability of {{HttpShardHandler}} by cutting it into
> smaller pieces
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] dweiss commented on a change in pull request #1550: LUCENE-9383: benchmark module: Gradle conversion (complete)
dweiss commented on a change in pull request #1550:
URL: https://github.com/apache/lucene-solr/pull/1550#discussion_r433824063
##
File path: lucene/benchmark/build.gradle
##
@@ -15,27 +15,138 @@
* limitations under the License.
*/
-
-apply plugin: 'java-library'
+apply plugin: 'java'
+// NOT a 'java-library'. Maybe 'application' but seems too limiting.
description = 'System for benchmarking Lucene'
dependencies {
- api project(':lucene:core')
-
- implementation project(':lucene:analysis:common')
- implementation project(':lucene:facet')
- implementation project(':lucene:highlighter')
- implementation project(':lucene:queries')
- implementation project(':lucene:spatial-extras')
- implementation project(':lucene:queryparser')
-
- implementation "org.apache.commons:commons-compress"
- implementation "com.ibm.icu:icu4j"
- implementation "org.locationtech.spatial4j:spatial4j"
- implementation("net.sourceforge.nekohtml:nekohtml", {
+ compile project(':lucene:core')
+
+ compile project(':lucene:analysis:common')
+ compile project(':lucene:facet')
+ compile project(':lucene:highlighter')
+ compile project(':lucene:queries')
+ compile project(':lucene:spatial-extras')
+ compile project(':lucene:queryparser')
+
+ compile "org.apache.commons:commons-compress"
+ compile "com.ibm.icu:icu4j"
+ compile "org.locationtech.spatial4j:spatial4j"
+ compile("net.sourceforge.nekohtml:nekohtml", {
exclude module: "xml-apis"
})
- testImplementation project(':lucene:test-framework')
+ runtime project(':lucene:analysis:icu')
+
+ testCompile project(':lucene:test-framework')
+}
+
+ext {
+ tempDir = file("temp")
+ workDir = file("work")
+}
+
+task run(type: JavaExec) {
+ description "Run a perf test (optional: -PtaskAlg=conf/your-algorithm-file
-PmaxHeapSize=1G)"
+ main 'org.apache.lucene.benchmark.byTask.Benchmark'
+ classpath sourceSets.main.runtimeClasspath
+ // allow these to be specified on the CLI via -PtaskAlg= for example
+ def taskAlg = project.properties['taskAlg'] ?: 'conf/micro-standard.alg'
+ args = [taskAlg]
+
+ maxHeapSize = project.properties['maxHeapSize'] ?: '1G'
+
+ String stdOutStr = project.properties['standardOutput']
+ if (stdOutStr != null) {
+standardOutput = new File(stdOutStr).newOutputStream()
+ }
+
+ debugOptions {
+enabled = false
+port = 5005
+suspend = true
+ }
+}
+
+/* Old "collation" Ant target:
+gradle getTop100kWikiWordFiles run -PtaskAlg=conf/collation.alg
-PstandardOutput=work/collation.benchmark.output.txt
+perl -CSD scripts/collation.bm2jira.pl work/collation.benchmark.output.txt
+ */
+
+/* Old "shingle" Ant target:
+gradle reuters run -PtaskAlg=conf/shingle.alg
-PstandardOutput=work/shingle.benchmark.output.txt
+perl -CSD scripts/shingle.bm2jira.pl work/shingle.benchmark.output.txt
+ */
+
+// The remaining tasks just get / extract / prepare data
+
+task getEnWiki(type: Download) {
+ src
"https://home.apache.org/~dsmiley/data/enwiki-20070527-pages-articles.xml.bz2";
+ dest file("$tempDir/${src.file.split('/').last()}")
+ overwrite false
+ compress false
+
+ doLast {
+ant.bunzip2(src: dest, dest: tempDir) // will chop off .bz2
+ }
+}
+
+task getGeoNames(type: Download) {
+ // note: latest data is at:
https://download.geonames.org/export/dump/allCountries.zip
+ // and then randomize with: gsort -R -S 1500M file.txt >
file_random.txt
+ // and then compress with: bzip2 -9 -k file_random.txt
+ src
"https://home.apache.org/~dsmiley/data/geonames_20130921_randomOrder_allCountries.txt.bz2";
+ dest file("$tempDir/${src.file.split('/').last()}")
+ overwrite false
+ compress false
+
+ doLast {
+ant.bunzip2(src: dest, dest: tempDir) // will chop off .bz2
+ }
+}
+
+task getReuters(type: Download) {
+ // note: there is no HTTPS url and we don't care because this is merely
test/perf data
+ src
"http://www.daviddlewis.com/resources/testcollections/reuters21578/reuters21578.tar.gz";
+ dest file("$tempDir/${src.file.split('/').last()}")
+ overwrite false
+ compress false
+}
+task extractReuters(type: Copy) {
Review comment:
Add newline between tasks for clarity?
##
File path: lucene/benchmark/build.gradle
##
@@ -15,27 +15,138 @@
* limitations under the License.
*/
-
-apply plugin: 'java-library'
+apply plugin: 'java'
+// NOT a 'java-library'. Maybe 'application' but seems too limiting.
description = 'System for benchmarking Lucene'
dependencies {
- api project(':lucene:core')
-
- implementation project(':lucene:analysis:common')
- implementation project(':lucene:facet')
- implementation project(':lucene:highlighter')
- implementation project(':lucene:queries')
- implementation project(':lucene:spatial-extras')
- implementation project(':lucene:queryparser')
-
- implementation "org.apache.commons:commons-compress"
- implementation "com.ibm.icu:icu4j"
- implementation "org.locationtech.spatial4j:spatial4j"
- implemen
[jira] [Commented] (LUCENE-9383) Port benchmark module Ant build to Gradle
[ https://issues.apache.org/jira/browse/LUCENE-9383?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123703#comment-17123703 ] Dawid Weiss commented on LUCENE-9383: - I've added a few quick comments, David. Hope they'll help! > Port benchmark module Ant build to Gradle > - > > Key: LUCENE-9383 > URL: https://issues.apache.org/jira/browse/LUCENE-9383 > Project: Lucene - Core > Issue Type: Sub-task > Components: modules/benchmark >Reporter: David Smiley >Assignee: David Smiley >Priority: Minor > Time Spent: 40m > Remaining Estimate: 0h > > The benchmark's build is more than a conventional build, it also has scripts > to fetch sample data for perf testing, and a task to run a perf test. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14531) Refactor out internode requests from HttpShardHandler
[
https://issues.apache.org/jira/browse/SOLR-14531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123702#comment-17123702
]
Noble Paul commented on SOLR-14531:
---
I just moved an anonymous inner class used in {{HttpShardHandler}} to a new
class
> Refactor out internode requests from HttpShardHandler
> -
>
> Key: SOLR-14531
> URL: https://issues.apache.org/jira/browse/SOLR-14531
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Noble Paul
>Assignee: Noble Paul
>Priority: Trivial
>
> We need to improve the readability of {{HttpShardHandler}} by cutting it into
> smaller pieces
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] jpountz commented on pull request #1541: RegExp - add case insensitive matching option
jpountz commented on pull request #1541: URL: https://github.com/apache/lucene-solr/pull/1541#issuecomment-637503848 @markharwood Java's case-insensitivity flag is indeed a bit mask flag passed to the constructor, but my comment was more about the fact that the current flags on RegExp are about what operators are supported, while the bit you are adding controls how matching works. So in my opinion, it should be a different constructor argument (boolean or other bit set depending on whether we're seeing other desirable ways to control how matching works). We could merge both bitsets internally if that makes things easier, my concern is only about the API. I don't have an opinion about the RegExp split, but I don't feel bad about propagating information recursively like in your PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14531) Refactor out internode requests from HttpShardHandler
[
https://issues.apache.org/jira/browse/SOLR-14531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123712#comment-17123712
]
Jan Høydahl commented on SOLR-14531:
Thanks for adding the description. I assume this JIRA will have more commits
since it is not yet resolved?
> Refactor out internode requests from HttpShardHandler
> -
>
> Key: SOLR-14531
> URL: https://issues.apache.org/jira/browse/SOLR-14531
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Noble Paul
>Assignee: Noble Paul
>Priority: Trivial
>
> We need to improve the readability of {{HttpShardHandler}} by cutting it into
> smaller pieces
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14531) Refactor out internode requests from HttpShardHandler
[
https://issues.apache.org/jira/browse/SOLR-14531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123713#comment-17123713
]
Ishan Chattopadhyaya commented on SOLR-14531:
-
bq. ??
Why this cryptic comment? If you're worried why a PR wasn't raised for this,
then please explicitly say so.
IMO, such trivial changes shouldn't need a PR. This is literally moving a class
from a file to another one. However, if there are more such changes needed for
this large class, we should club them together and commit in one go (with a PR).
[~noble.paul], next time please run {{ant precommit}} before every push.
> Refactor out internode requests from HttpShardHandler
> -
>
> Key: SOLR-14531
> URL: https://issues.apache.org/jira/browse/SOLR-14531
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Noble Paul
>Assignee: Noble Paul
>Priority: Trivial
>
> We need to improve the readability of {{HttpShardHandler}} by cutting it into
> smaller pieces
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14531) Refactor out internode requests from HttpShardHandler
[
https://issues.apache.org/jira/browse/SOLR-14531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123721#comment-17123721
]
Erick Erickson commented on SOLR-14531:
---
"gw check -x test" is faster on master
Sheer poetry.
It'd be especially useful to know if gradle succeeds or fails and ant doesn't
behave the same way
> Refactor out internode requests from HttpShardHandler
> -
>
> Key: SOLR-14531
> URL: https://issues.apache.org/jira/browse/SOLR-14531
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Noble Paul
>Assignee: Noble Paul
>Priority: Trivial
>
> We need to improve the readability of {{HttpShardHandler}} by cutting it into
> smaller pieces
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Resolved] (SOLR-14531) Refactor out internode requests from HttpShardHandler
[
https://issues.apache.org/jira/browse/SOLR-14531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Noble Paul resolved SOLR-14531.
---
Fix Version/s: 8.6
Resolution: Fixed
> Refactor out internode requests from HttpShardHandler
> -
>
> Key: SOLR-14531
> URL: https://issues.apache.org/jira/browse/SOLR-14531
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Noble Paul
>Assignee: Noble Paul
>Priority: Trivial
> Fix For: 8.6
>
>
> We need to improve the readability of {{HttpShardHandler}} by cutting it into
> smaller pieces
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14531) Refactor out internode requests from HttpShardHandler
[
https://issues.apache.org/jira/browse/SOLR-14531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123729#comment-17123729
]
Noble Paul commented on SOLR-14531:
---
indeed Erick
the gradle build is really poetry. Looks very modern
--
-
Noble Paul
> Refactor out internode requests from HttpShardHandler
> -
>
> Key: SOLR-14531
> URL: https://issues.apache.org/jira/browse/SOLR-14531
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Noble Paul
>Assignee: Noble Paul
>Priority: Trivial
> Fix For: 8.6
>
>
> We need to improve the readability of {{HttpShardHandler}} by cutting it into
> smaller pieces
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] jpountz commented on pull request #1543: LUCENE-9378: Disable compression on binary values whose length is less than 32.
jpountz commented on pull request #1543: URL: https://github.com/apache/lucene-solr/pull/1543#issuecomment-637517914 Here are updated results where the baseline is master with Mark's commit that enabled compression of binary doc values is reverted, and the patch is this pull request. The bottleneck is now reading the lengths of all values in a given block. ``` TaskQPS baseline StdDev QPS patch StdDev Pct diff HighTermTitleBDVSort 28.91 (2.7%) 15.31 (7.4%) -47.0% ( -55% - -37%) HighSloppyPhrase6.45 (7.6%)6.35 (9.1%) -1.6% ( -16% - 16%) OrHighNotLow 1260.60 (3.7%) 1243.30 (3.5%) -1.4% ( -8% -6%) MedSloppyPhrase 34.45 (4.5%) 34.07 (5.4%) -1.1% ( -10% -9%) HighTermDayOfYearSort 28.14 (8.4%) 27.84 (9.6%) -1.1% ( -17% - 18%) BrowseMonthSSDVFacets 16.96 (11.7%) 16.81 (11.9%) -0.9% ( -21% - 25%) HighIntervalsOrdered 28.80 (2.7%) 28.55 (2.6%) -0.8% ( -6% -4%) Prefix3 100.23 (10.4%) 99.45 (9.4%) -0.8% ( -18% - 21%) BrowseDayOfYearSSDVFacets 15.44 (8.3%) 15.34 (9.6%) -0.6% ( -17% - 18%) OrHighNotHigh 1306.26 (2.5%) 1299.19 (1.9%) -0.5% ( -4% -4%) OrNotHighHigh 1389.86 (2.4%) 1382.43 (2.5%) -0.5% ( -5% -4%) AndHighLow 843.27 (3.3%) 839.05 (3.3%) -0.5% ( -6% -6%) LowSloppyPhrase 151.10 (3.7%) 150.35 (4.0%) -0.5% ( -7% -7%) OrHighNotMed 1336.61 (4.0%) 1331.42 (2.4%) -0.4% ( -6% -6%) MedPhrase 244.05 (2.4%) 243.17 (2.0%) -0.4% ( -4% -4%) MedTerm 3342.61 (4.1%) 3332.82 (3.9%) -0.3% ( -7% -8%) LowTerm 2724.03 (4.5%) 2719.60 (4.6%) -0.2% ( -8% -9%) HighSpanNear 20.82 (4.0%) 20.79 (3.7%) -0.2% ( -7% -7%) OrNotHighMed 1638.22 (3.8%) 1637.84 (2.8%) -0.0% ( -6% -6%) IntNRQ 193.31 (1.4%) 193.40 (1.4%) 0.0% ( -2% -2%) Respell 224.18 (2.2%) 224.43 (2.7%) 0.1% ( -4% -5%) AndHighMed 334.41 (3.7%) 334.91 (3.0%) 0.2% ( -6% -7%) LowSpanNear 184.23 (3.8%) 184.53 (3.3%) 0.2% ( -6% -7%) HighTermMonthSort 76.33 (7.7%) 76.48 (8.5%) 0.2% ( -14% - 17%) OrHighLow 765.34 (3.5%) 767.25 (2.9%) 0.2% ( -5% -6%) HighTerm 2321.04 (4.8%) 2327.02 (3.9%) 0.3% ( -8% -9%) HighPhrase 198.93 (3.2%) 199.50 (2.1%) 0.3% ( -4% -5%) OrHighHigh 42.13 (5.8%) 42.26 (5.3%) 0.3% ( -10% - 12%) AndHighHigh 95.83 (3.2%) 96.18 (3.2%) 0.4% ( -5% -6%) MedSpanNear 44.19 (4.1%) 44.37 (4.0%) 0.4% ( -7% -8%) Fuzzy1 222.24 (7.0%) 223.30 (7.1%) 0.5% ( -12% - 15%) OrHighMed 93.32 (4.4%) 93.80 (4.3%) 0.5% ( -7% -9%) LowPhrase 27.51 (3.5%) 27.68 (2.4%) 0.6% ( -5% -6%) OrNotHighLow 1277.07 (3.6%) 1285.51 (3.4%) 0.7% ( -6% -7%) PKLookup 244.71 (4.6%) 246.90 (4.6%) 0.9% ( -7% - 10%) Fuzzy2 120.37 (6.5%) 122.37 (6.3%) 1.7% ( -10% - 15%) Wildcard 486.28 (21.6%) 505.80 (23.1%) 4.0% ( -33% - 62%) BrowseDayOfYearTaxoFacets3.62 (2.6%)6.52 (19.4%) 80.4% ( 56% - 105%) BrowseDateTaxoFacets3.62 (2.8%)6.56 (19.6%) 81.3% ( 57% - 106%) BrowseMonthTaxoFacets3.89 (3.1%)7.74 (16.8%) 99.2% ( 76% - 122%) ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional c
[jira] [Resolved] (SOLR-14527) The 8.5.1 release can't be verified using PGP
[ https://issues.apache.org/jira/browse/SOLR-14527?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jan Høydahl resolved SOLR-14527. Resolution: Implemented I checked in a new version of README.html to the release mirror * Links to Solr download page instead of explaining how to validate - that is safer since the downloads page now has this info and links to the official KEYS and SHA files. * Removed broken image on top of README * No longer mentions ref-guide as download, instead just links to website > The 8.5.1 release can't be verified using PGP > - > > Key: SOLR-14527 > URL: https://issues.apache.org/jira/browse/SOLR-14527 > Project: Solr > Issue Type: Bug > Security Level: Public(Default Security Level. Issues are Public) > Components: website >Affects Versions: 8.5.1 >Reporter: Per Cederqvist >Priority: Major > > The [https://archive.apache.org/dist/lucene/solr/8.5.1/solr-8.5.1.tgz.asc] > signature of the > [https://archive.apache.org/dist/lucene/solr/8.5.1/solr-8.5.1.tgz] file is > made by the following key: > pub rsa4096 2019-07-10 [SC] > E58A6F4D5B2B48AC66D5E53BD4F181881A42F9E6 > uid [ unknown] Ignacio Vera (CODE SIGNING KEY) > sub rsa4096 2019-07-10 [E] > > However, that key is not included in > [https://archive.apache.org/dist/lucene/solr/KEYS,] so there is no way for me > to verify that the file is authentic. I could download the key from a > keyserver, but there are no signatures on the key, so I'm left with no way to > verify that the 8.5.1 distribution is legitimate. > I'm assuming this is just an omission, and that [~ivera] simply forgot to add > the key to the KEYS file. -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14531) Refactor out internode requests from HttpShardHandler
[
https://issues.apache.org/jira/browse/SOLR-14531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123776#comment-17123776
]
Jan Høydahl commented on SOLR-14531:
{quote}Why this cryptic comment? If you're worried why a PR wasn't raised for
this, then please explicitly say so.
{quote}
?? means that I don't even know what to ask :) I'm always puzzled when I see a
JIRA without description with push to stable branch, and still Open. All I wish
for is a clearer workflow.
> Refactor out internode requests from HttpShardHandler
> -
>
> Key: SOLR-14531
> URL: https://issues.apache.org/jira/browse/SOLR-14531
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Noble Paul
>Assignee: Noble Paul
>Priority: Trivial
> Fix For: 8.6
>
>
> We need to improve the readability of {{HttpShardHandler}} by cutting it into
> smaller pieces
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14526) fix or suppress warnings in apache/solr/core
[ https://issues.apache.org/jira/browse/SOLR-14526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123777#comment-17123777 ] ASF subversion and git services commented on SOLR-14526: Commit db9cd0cebb8c73d51bdd68a30c9c229c4745cb52 in lucene-solr's branch refs/heads/master from Erick Erickson [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=db9cd0c ] SOLR-14526: fix or suppress warnings in apache/solr/core > fix or suppress warnings in apache/solr/core > > > Key: SOLR-14526 > URL: https://issues.apache.org/jira/browse/SOLR-14526 > Project: Solr > Issue Type: Sub-task >Reporter: Erick Erickson >Assignee: Erick Erickson >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14526) fix or suppress warnings in apache/solr/core
[ https://issues.apache.org/jira/browse/SOLR-14526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123779#comment-17123779 ] ASF subversion and git services commented on SOLR-14526: Commit 10ca1e78707f009f41a15e74bc185cf60ae0090e in lucene-solr's branch refs/heads/branch_8x from Erick Erickson [ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=10ca1e7 ] SOLR-14526: fix or suppress warnings in apache/solr/core > fix or suppress warnings in apache/solr/core > > > Key: SOLR-14526 > URL: https://issues.apache.org/jira/browse/SOLR-14526 > Project: Solr > Issue Type: Sub-task >Reporter: Erick Erickson >Assignee: Erick Erickson >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Resolved] (SOLR-14526) fix or suppress warnings in apache/solr/core
[ https://issues.apache.org/jira/browse/SOLR-14526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Erick Erickson resolved SOLR-14526. --- Fix Version/s: 8.6 Resolution: Fixed > fix or suppress warnings in apache/solr/core > > > Key: SOLR-14526 > URL: https://issues.apache.org/jira/browse/SOLR-14526 > Project: Solr > Issue Type: Sub-task >Reporter: Erick Erickson >Assignee: Erick Erickson >Priority: Major > Fix For: 8.6 > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] joel-bernstein opened a new pull request #1551: LUCENESOLR-1912: CompositeIdRouter tries implicit logic first
joel-bernstein opened a new pull request #1551: URL: https://github.com/apache/lucene-solr/pull/1551 # Description Please provide a short description of the changes you're making with this pull request. # Solution Please provide a short description of the approach taken to implement your solution. # Tests Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem. # Checklist Please review the following and check all that apply: - [ ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability. - [ ] I have created a Jira issue and added the issue ID to my pull request title. - [ ] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended) - [ ] I have developed this patch against the `master` branch. - [ ] I have run `ant precommit` and the appropriate test suite. - [ ] I have added tests for my changes. - [ ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-9679) Exception when removing zk node /security.json
[
https://issues.apache.org/jira/browse/SOLR-9679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123828#comment-17123828
]
Jan Høydahl commented on SOLR-9679:
---
Will commit this soon
> Exception when removing zk node /security.json
> --
>
> Key: SOLR-9679
> URL: https://issues.apache.org/jira/browse/SOLR-9679
> Project: Solr
> Issue Type: Bug
> Components: Authentication
>Reporter: Jan Høydahl
>Assignee: Jan Høydahl
>Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> To reproduce:
> # Upload {{security.json}} to zk
> # {{bin/solr zk rm zk:/security.json -z localhost:9983}}
> {noformat}
> 2016-10-22 22:17:32.264 DEBUG (main-EventThread) [ ] o.a.s.c.c.SolrZkClient
> Submitting job to respond to event WatchedEvent state:SyncConnected
> type:NodeDeleted path:/security.json
> 2016-10-22 22:17:32.265 DEBUG
> (zkCallback-3-thread-1-processing-n:192.168.0.11:8983_solr) [ ]
> o.a.s.c.c.ZkStateReader Updating [/security.json] ...
> 2016-10-22 22:17:32.266 ERROR
> (zkCallback-3-thread-1-processing-n:192.168.0.11:8983_solr) [ ]
> o.a.s.c.c.ZkStateReader A ZK error has occurred
> org.apache.zookeeper.KeeperException$NoNodeException: KeeperErrorCode =
> NoNode for /security.json
> at org.apache.zookeeper.KeeperException.create(KeeperException.java:111)
> at org.apache.zookeeper.KeeperException.create(KeeperException.java:51)
> at org.apache.zookeeper.ZooKeeper.getData(ZooKeeper.java:1155)
> at
> org.apache.solr.common.cloud.SolrZkClient$7.execute(SolrZkClient.java:356)
> at
> org.apache.solr.common.cloud.SolrZkClient$7.execute(SolrZkClient.java:353)
> at
> org.apache.solr.common.cloud.ZkCmdExecutor.retryOperation(ZkCmdExecutor.java:60)
> at
> org.apache.solr.common.cloud.SolrZkClient.getData(SolrZkClient.java:353)
> at
> org.apache.solr.common.cloud.ZkStateReader$3.process(ZkStateReader.java:455)
> at
> org.apache.solr.common.cloud.SolrZkClient$3.lambda$process$0(SolrZkClient.java:268)
> at
> java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
> at java.util.concurrent.FutureTask.run(FutureTask.java:266)
> at
> org.apache.solr.common.util.ExecutorUtil$MDCAwareThreadPoolExecutor.lambda$execute$0(ExecutorUtil.java:229)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> at java.lang.Thread.run(Thread.java:745)
> {noformat}
> I'm not sure what should happen, but it would be sweet to be able to disable
> security by simply removing the znode... [~noble.paul] ?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Created] (SOLR-14533) Fix or suppress warnings in solr/handler/admin
Erick Erickson created SOLR-14533: - Summary: Fix or suppress warnings in solr/handler/admin Key: SOLR-14533 URL: https://issues.apache.org/jira/browse/SOLR-14533 Project: Solr Issue Type: Sub-task Reporter: Erick Erickson Assignee: Erick Erickson -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14533) Fix or suppress warnings in solr/handler/admin
[
https://issues.apache.org/jira/browse/SOLR-14533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123834#comment-17123834
]
Andras Salamon commented on SOLR-14533:
---
Have you started the work on this [~erickerickson]? I have a patch which fixes
{{solr/handler}} (not only admin subpackage) warnings.
> Fix or suppress warnings in solr/handler/admin
> --
>
> Key: SOLR-14533
> URL: https://issues.apache.org/jira/browse/SOLR-14533
> Project: Solr
> Issue Type: Sub-task
>Reporter: Erick Erickson
>Assignee: Erick Erickson
>Priority: Major
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14531) Refactor out internode requests from HttpShardHandler
[
https://issues.apache.org/jira/browse/SOLR-14531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123849#comment-17123849
]
Ishan Chattopadhyaya commented on SOLR-14531:
-
bq. ?? means that I don't even know what to ask I'm always puzzled when I see
a JIRA without description with push to stable branch, and still Open. All I
wish for is a clearer workflow.
Haha, I hear you, Jan. I hadn't realized that the description wasn't there
before your comment :-) I'm sure Noble didn't do that to deliberately puzzle
you, and it was unintentional. :-) :-) :-)
> Refactor out internode requests from HttpShardHandler
> -
>
> Key: SOLR-14531
> URL: https://issues.apache.org/jira/browse/SOLR-14531
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Noble Paul
>Assignee: Noble Paul
>Priority: Trivial
> Fix For: 8.6
>
>
> We need to improve the readability of {{HttpShardHandler}} by cutting it into
> smaller pieces
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] joel-bernstein closed pull request #1551: LUCENESOLR-1912: CompositeIdRouter tries implicit logic first
joel-bernstein closed pull request #1551: URL: https://github.com/apache/lucene-solr/pull/1551 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] joel-bernstein commented on pull request #1551: LUCENESOLR-1912: CompositeIdRouter tries implicit logic first
joel-bernstein commented on pull request #1551: URL: https://github.com/apache/lucene-solr/pull/1551#issuecomment-637570708 This was for an internal hackathon. Closing, sorry for the noise. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14533) Fix or suppress warnings in solr/handler/admin
[ https://issues.apache.org/jira/browse/SOLR-14533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123854#comment-17123854 ] Erick Erickson commented on SOLR-14533: --- Just barely, thanks for catching this so quickly and saving me work! Did I miss a JIRA or is it a local patch? If it's a JIRA, point me to the right one and I'll use that. Otherwise, please attach a patch or PR to this one. > Fix or suppress warnings in solr/handler/admin > -- > > Key: SOLR-14533 > URL: https://issues.apache.org/jira/browse/SOLR-14533 > Project: Solr > Issue Type: Sub-task >Reporter: Erick Erickson >Assignee: Erick Erickson >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Updated] (SOLR-14533) Fix or suppress warnings in solr/handler/admin
[ https://issues.apache.org/jira/browse/SOLR-14533?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andras Salamon updated SOLR-14533: -- Attachment: SOLR-14533.patch > Fix or suppress warnings in solr/handler/admin > -- > > Key: SOLR-14533 > URL: https://issues.apache.org/jira/browse/SOLR-14533 > Project: Solr > Issue Type: Sub-task >Reporter: Erick Erickson >Assignee: Erick Erickson >Priority: Major > Attachments: SOLR-14533.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14531) Refactor out internode requests from HttpShardHandler
[
https://issues.apache.org/jira/browse/SOLR-14531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123863#comment-17123863
]
Jan Høydahl commented on SOLR-14531:
I bet Noble is laying out traps for me :)
> Refactor out internode requests from HttpShardHandler
> -
>
> Key: SOLR-14531
> URL: https://issues.apache.org/jira/browse/SOLR-14531
> Project: Solr
> Issue Type: Improvement
> Security Level: Public(Default Security Level. Issues are Public)
>Reporter: Noble Paul
>Assignee: Noble Paul
>Priority: Trivial
> Fix For: 8.6
>
>
> We need to improve the readability of {{HttpShardHandler}} by cutting it into
> smaller pieces
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14533) Fix or suppress warnings in solr/handler/admin
[
https://issues.apache.org/jira/browse/SOLR-14533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17123865#comment-17123865
]
Andras Salamon commented on SOLR-14533:
---
It was a local patch, I was just about to open a new jira.
I mostly fixed resource warnings but there were a few other warnings as well:
{{Unlikely argument type Class for get(Object) on a
Map}}
I also eliminated an unchecked warning.
> Fix or suppress warnings in solr/handler/admin
> --
>
> Key: SOLR-14533
> URL: https://issues.apache.org/jira/browse/SOLR-14533
> Project: Solr
> Issue Type: Sub-task
>Reporter: Erick Erickson
>Assignee: Erick Erickson
>Priority: Major
> Attachments: SOLR-14533.patch
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14467) inconsistent server errors combining relatedness() with allBuckets:true
[
https://issues.apache.org/jira/browse/SOLR-14467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124035#comment-17124035
]
Chris M. Hostetter commented on SOLR-14467:
---
_(I thought i posted this comment last night, but found it sitting in an open
tab this AM)_
{quote}The attached patch ([^SOLR-14467_allBuckets_refine.patch]) I think fixes
the problem ...
{quote}
Sweet! ... i moved/combined your patch with the test patch already over in
SOLR-14520 ... i need to review it more in depth but i'm currently beasting the
combination of your patch to fix that issue with the new tests & fixes in this
issue to see if anything else shakes out.
> inconsistent server errors combining relatedness() with allBuckets:true
> ---
>
> Key: SOLR-14467
> URL: https://issues.apache.org/jira/browse/SOLR-14467
> Project: Solr
> Issue Type: Bug
> Components: Facet Module
>Reporter: Chris M. Hostetter
>Priority: Major
> Attachments: SOLR-14467.patch, SOLR-14467.patch, SOLR-14467.patch,
> SOLR-14467_allBuckets_refine.patch, SOLR-14467_test.patch,
> SOLR-14467_test.patch, beast.log.txt, beast2.log.txt
>
>
> While working on randomized testing for SOLR-13132 i discovered a variety of
> different ways that JSON Faceting's "allBuckets" option can fail when
> combined with the "relatedness()" function.
> I haven't found a trivial way to manual reproduce this, but i have been able
> to trigger the failures with a trivial patch to {{TestCloudJSONFacetSKG}}
> which i will attach.
> Based on the nature of the failures it looks like it may have something to do
> with multiple segments of different sizes, and or resizing the SlotAccs ?
> The relatedness() function doesn't have much (any?) existing tests in place
> that leverage "allBuckets" so this is probably a bug that has always existed
> -- it's possible it may be excessively cumbersome to fix and we might
> nee/wnat to just document that incompatibility and add some code to try and
> detect if the user combines these options and if so fail with a 400 error?
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14533) Fix or suppress warnings in solr/handler/admin
[ https://issues.apache.org/jira/browse/SOLR-14533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124123#comment-17124123 ] Erick Erickson commented on SOLR-14533: --- Cool, I'll take a look this evening. No big deal, but to keep from duplicating work, I'm trying to add a sub-task to SOLR-10778 when I start working on some section of the code. If you'd like to follow that convention I'll be sure to work on some other directory, there are plenty to go around ;)... Thanks! > Fix or suppress warnings in solr/handler/admin > -- > > Key: SOLR-14533 > URL: https://issues.apache.org/jira/browse/SOLR-14533 > Project: Solr > Issue Type: Sub-task >Reporter: Erick Erickson >Assignee: Erick Erickson >Priority: Major > Attachments: SOLR-14533.patch > > -- This message was sent by Atlassian Jira (v8.3.4#803005) - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1527: SOLR-14384 Stack SolrRequestInfo
dsmiley commented on a change in pull request #1527:
URL: https://github.com/apache/lucene-solr/pull/1527#discussion_r434081511
##
File path: solr/core/src/java/org/apache/solr/request/SolrRequestInfo.java
##
@@ -52,35 +56,53 @@
private static final Logger log =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
public static SolrRequestInfo getRequestInfo() {
-return threadLocal.get();
+if (threadLocal.get().isEmpty()) return null;
Review comment:
Instead of calling threadLocal.get() twice, can you please just call it
once? This goes for all the other methods in this class too.
##
File path: solr/core/src/java/org/apache/solr/request/SolrRequestInfo.java
##
@@ -52,35 +56,53 @@
private static final Logger log =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
public static SolrRequestInfo getRequestInfo() {
-return threadLocal.get();
+if (threadLocal.get().isEmpty()) return null;
+return threadLocal.get().peek();
}
+ /** Adds the SolrRequestInfo onto the stack provided that the stack is not
reached MAX_STACK_SIZE */
public static void setRequestInfo(SolrRequestInfo info) {
-// TODO: temporary sanity check... this can be changed to just an assert
in the future
-SolrRequestInfo prev = threadLocal.get();
-if (prev != null) {
- log.error("Previous SolrRequestInfo was not closed! req={}",
prev.req.getOriginalParams());
- log.error("prev == info : {}", prev.req == info.req, new
RuntimeException());
+if (info == null) {
+ throw new IllegalArgumentException("SolrRequestInfo is null");
+} else {
+ if (threadLocal.get().size() <= MAX_STACK_SIZE) {
+threadLocal.get().push(info);
+ } else {
+log.error("SolrRequestInfo Stack is full");
Review comment:
add assertion
##
File path: solr/core/src/java/org/apache/solr/request/SolrRequestInfo.java
##
@@ -52,35 +56,53 @@
private static final Logger log =
LoggerFactory.getLogger(MethodHandles.lookup().lookupClass());
public static SolrRequestInfo getRequestInfo() {
-return threadLocal.get();
+if (threadLocal.get().isEmpty()) return null;
+return threadLocal.get().peek();
}
+ /** Adds the SolrRequestInfo onto the stack provided that the stack is not
reached MAX_STACK_SIZE */
public static void setRequestInfo(SolrRequestInfo info) {
-// TODO: temporary sanity check... this can be changed to just an assert
in the future
-SolrRequestInfo prev = threadLocal.get();
-if (prev != null) {
- log.error("Previous SolrRequestInfo was not closed! req={}",
prev.req.getOriginalParams());
- log.error("prev == info : {}", prev.req == info.req, new
RuntimeException());
+if (info == null) {
+ throw new IllegalArgumentException("SolrRequestInfo is null");
+} else {
+ if (threadLocal.get().size() <= MAX_STACK_SIZE) {
+threadLocal.get().push(info);
+ } else {
+log.error("SolrRequestInfo Stack is full");
+ }
}
-assert prev == null;
-
-threadLocal.set(info);
}
+ /** Removes the most recent SolrRequestInfo from the stack */
public static void clearRequestInfo() {
-try {
- SolrRequestInfo info = threadLocal.get();
- if (info != null && info.closeHooks != null) {
-for (Closeable hook : info.closeHooks) {
- try {
-hook.close();
- } catch (Exception e) {
-SolrException.log(log, "Exception during close hook", e);
- }
+if (threadLocal.get().isEmpty()) {
+ log.error("clearRequestInfo called too many times");
+} else {
+ SolrRequestInfo info = threadLocal.get().pop();
+ closeHooks(info);
+}
+ }
+
+ /** Removes all the SolrRequestInfos from the stack */
Review comment:
comment that we expect it to be empty by now because all "set" calls
need to be balanced with a "clear". Thus this reset method is more of a
protection mechanism.
##
File path: solr/core/src/java/org/apache/solr/servlet/HttpSolrCall.java
##
@@ -145,6 +145,8 @@
public static final String INTERNAL_REQUEST_COUNT = "_forwardedCount";
public static final Random random;
+
+ private boolean pushedSolrRequestInfo = false;
Review comment:
I know I suggested this name but lets call this
"mustClearSolrRequestInfo"
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] dsmiley commented on a change in pull request #1550: LUCENE-9383: benchmark module: Gradle conversion (complete)
dsmiley commented on a change in pull request #1550:
URL: https://github.com/apache/lucene-solr/pull/1550#discussion_r434119837
##
File path: lucene/benchmark/build.gradle
##
@@ -15,27 +15,138 @@
* limitations under the License.
*/
-
-apply plugin: 'java-library'
+apply plugin: 'java'
+// NOT a 'java-library'. Maybe 'application' but seems too limiting.
description = 'System for benchmarking Lucene'
dependencies {
- api project(':lucene:core')
-
- implementation project(':lucene:analysis:common')
- implementation project(':lucene:facet')
- implementation project(':lucene:highlighter')
- implementation project(':lucene:queries')
- implementation project(':lucene:spatial-extras')
- implementation project(':lucene:queryparser')
-
- implementation "org.apache.commons:commons-compress"
- implementation "com.ibm.icu:icu4j"
- implementation "org.locationtech.spatial4j:spatial4j"
- implementation("net.sourceforge.nekohtml:nekohtml", {
+ compile project(':lucene:core')
Review comment:
Right; I was confused in my failed experiment with "application"
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14524) Harden MultiThreadedOCPTest
[
https://issues.apache.org/jira/browse/SOLR-14524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124330#comment-17124330
]
Erick Erickson commented on SOLR-14524:
---
[~mdrob] Do you want to commit this or shall I? FWIW, I could not get this test
to fail in 1,000 iterations on my machine (without the patch), so we'll have to
check it in and see if it stops failing on the various Jenkins machines.
> Harden MultiThreadedOCPTest
> ---
>
> Key: SOLR-14524
> URL: https://issues.apache.org/jira/browse/SOLR-14524
> Project: Solr
> Issue Type: Test
> Security Level: Public(Default Security Level. Issues are Public)
> Components: SolrCloud
>Affects Versions: master (9.0)
>Reporter: Ilan Ginzburg
>Priority: Minor
> Labels: test
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> {{MultiThreadedOCPTest.test()}} fails occasionally in Jenkins because of
> timing of tasks enqueue to the Collection API queue.
> This test in {{testFillWorkQueue()}} enqueues a large number of tasks (115,
> more than the 100 Collection API parallel executors) to the Collection API
> queue for a collection COLL_A, then observes a short delay and enqueues a
> task for another collection COLL_B.
> It verifies that the COLL_B task (that does not require the same lock as the
> COLL_A tasks) completes before the third COLL_A task.
> Test failures happen because when enqueues are slowed down enough, the first
> 3 tasks on COLL_A complete even before the COLL_B task gets enqueued!
> In one sample failed Jenkins test execution, the COLL_B task enqueue happened
> 1275ms after the enqueue of the first COLL_A, leaving plenty of time for a
> few (and possibly all) COLL_A tasks to complete.
> Fix will be along the lines of:
> * Make the “blocking” COLL_A task longer to execute (currently 1 second) to
> compensate for slow enqueues.
> * Verify the COLL_B task (a 1ms task) finishes before the long running
> COLL_A task does. This would be a good indication that even though the
> collection queue was filled with tasks waiting for a busy lock, a non
> competing task was picked and executed right away.
> * Delay the enqueue of the COLL_B task to the end of processing of the first
> COLL_A task. This would guarantee that COLL_B is enqueued once at least some
> COLL_A tasks started processing at the Overseer. Possibly also verify that
> the long running task of COLL_A didn't finish execution yet when the COLL_B
> task is enqueued...
> * It might be possible to set a (very) long duration for the slow task of
> COLL_A (to be less vulnerable to execution delays) without requiring the test
> to wait for that task to complete, but only wait for the COLL_B task to
> complete (so the test doesn't run for too long).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Updated] (SOLR-14520) json.facets: allBucket:true can cause server errors when combined with refine:true
[
https://issues.apache.org/jira/browse/SOLR-14520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris M. Hostetter updated SOLR-14520:
--
Attachment: SOLR-14520.patch
Status: Open (was: Open)
bq. Perhaps the key to reproducing might be to figure out how/when
partialBuckets for subs are initially populated...
The tests i added in the last patch were already triggering the partialBuckets
refinement -- the important bits i was overlooking was that in order to trigger
the ArrayIndexOutOfBoundsException we needed *BOTH* of the following to be true
when refining a facet of a partial bucket...
# the facet uses default sort by count (so that we collect against the
countAcc, collecting against the acc from some other stat leads to the other
NPE alreayd accounted for in the test)
# we trigger refinement of a bucket that has a slot number > 0
I had considered #1, but didn't really grasp that the existing test data was so
small all noe of the requests were tickling #2.
The attached patch just adds a 'cat5' example facet that would trigger the
AIOOBE -- but doesn't because the fix works.
bq. I still need to review & think about michael's solution a bit more before
commiting ...
I'm feeling more confident, but still beasting for a bit in conjunction with
the other test improvements in SOLR-14467
Unless i run into any problems, or there are any objections, I'll probably move
forward & commit tomorow.
> json.facets: allBucket:true can cause server errors when combined with
> refine:true
> --
>
> Key: SOLR-14520
> URL: https://issues.apache.org/jira/browse/SOLR-14520
> Project: Solr
> Issue Type: Bug
> Components: Facet Module
>Reporter: Chris M. Hostetter
>Priority: Major
> Attachments: SOLR-14520.patch, SOLR-14520.patch, SOLR-14520.patch
>
>
> Another bug that was discovered while testing SOLR-14467...
> In some situations, using {{allBuckets:true}} in conjunction with
> {{refine:true}} can cause server errors during the "refinement" requests to
> the individual shards -- either NullPointerExceptions from some (nested)
> SlotAccs when SpecialSlotAcc tries to collect them, or
> ArrayIndexOutOfBoundsException from CountSlotArrAcc.incrementCount because
> it's asked to collect to "large" slot# values even though it's been
> initialized with a size of '1'
> NOTE: these problems may be specific to FacetFieldProcessorByArrayDV - i have
> not yet seen similar failures from FacetFieldProcessorByArrayUIF (those are
> the only 2 used when doing refinement) but that may just be a fluke of
> testing.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Updated] (SOLR-14520) json.facets: allBucket:true can cause server errors when combined with refine:true
[
https://issues.apache.org/jira/browse/SOLR-14520?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris M. Hostetter updated SOLR-14520:
--
Status: Patch Available (was: Open)
> json.facets: allBucket:true can cause server errors when combined with
> refine:true
> --
>
> Key: SOLR-14520
> URL: https://issues.apache.org/jira/browse/SOLR-14520
> Project: Solr
> Issue Type: Bug
> Components: Facet Module
>Reporter: Chris M. Hostetter
>Priority: Major
> Attachments: SOLR-14520.patch, SOLR-14520.patch, SOLR-14520.patch
>
>
> Another bug that was discovered while testing SOLR-14467...
> In some situations, using {{allBuckets:true}} in conjunction with
> {{refine:true}} can cause server errors during the "refinement" requests to
> the individual shards -- either NullPointerExceptions from some (nested)
> SlotAccs when SpecialSlotAcc tries to collect them, or
> ArrayIndexOutOfBoundsException from CountSlotArrAcc.incrementCount because
> it's asked to collect to "large" slot# values even though it's been
> initialized with a size of '1'
> NOTE: these problems may be specific to FacetFieldProcessorByArrayDV - i have
> not yet seen similar failures from FacetFieldProcessorByArrayUIF (those are
> the only 2 used when doing refinement) but that may just be a fluke of
> testing.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] dsmiley merged pull request #1546: SOLR: Use absolute paths for server paths.
dsmiley merged pull request #1546: URL: https://github.com/apache/lucene-solr/pull/1546 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-11334) UnifiedSolrHighlighter returns an error when hl.fl delimited by ", "
[
https://issues.apache.org/jira/browse/SOLR-11334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124549#comment-17124549
]
ASF subversion and git services commented on SOLR-11334:
Commit 2af82c83d9cf134eb8741d1da1eeb606946f5baa in lucene-solr's branch
refs/heads/master from David Smiley
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=2af82c8 ]
SOLR-11334: Split some field lists better
Used by HighlightComponent and TermVectorComponent
Used to produce an empty string on comma-space, leading to an exception.
> UnifiedSolrHighlighter returns an error when hl.fl delimited by ", "
>
>
> Key: SOLR-11334
> URL: https://issues.apache.org/jira/browse/SOLR-11334
> Project: Solr
> Issue Type: Improvement
> Components: highlighter
>Affects Versions: 6.6
> Environment: Ubuntu 17.04 (GNU/Linux 4.10.0-33-generic x86_64)
> Java HotSpot 64-Bit Server VM(build 25.114-b01, mixed mode)
>Reporter: Yasufumi Mizoguchi
>Priority: Minor
> Attachments: SOLR-11334.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> UnifiedSolrHighlighter(hl.method=unified) misjudge the zero-length string as
> a field name and returns an error when hl.fl delimited by ", "
> request:
> {code}
> $ curl -XGET
> "http://localhost:8983/solr/techproducts/select?fl=name,%20manu&hl.fl=name,%20manu&hl.method=unified&hl=on&indent=on&q=corsair&wt=json";
> {code}
> response:
> {code}
> {
> "responseHeader":{
> "status":400,
> "QTime":8,
> "params":{
> "q":"corsair",
> "hl":"on",
> "indent":"on",
> "fl":"name, manu",
> "hl.fl":"name, manu",
> "hl.method":"unified",
> "wt":"json"}},
> "response":{"numFound":2,"start":0,"docs":[
> {
> "name":"CORSAIR ValueSelect 1GB 184-Pin DDR SDRAM Unbuffered DDR 400
> (PC 3200) System Memory - Retail",
> "manu":"Corsair Microsystems Inc."},
> {
> "name":"CORSAIR XMS 2GB (2 x 1GB) 184-Pin DDR SDRAM Unbuffered DDR
> 400 (PC 3200) Dual Channel Kit System Memory - Retail",
> "manu":"Corsair Microsystems Inc."}]
> },
> "error":{
> "metadata":[
> "error-class","org.apache.solr.common.SolrException",
> "root-error-class","org.apache.solr.common.SolrException"],
> "msg":"undefined field ",
> "code":400}}
> {code}
> DefaultHighlighter's response:
> {code}
> {
> "responseHeader":{
> "status":0,
> "QTime":5,
> "params":{
> "q":"corsair",
> "hl":"on",
> "indent":"on",
> "fl":"name, manu",
> "hl.fl":"name, manu",
> "hl.method":"original",
> "wt":"json"}},
> "response":{"numFound":2,"start":0,"docs":[
> {
> "name":"CORSAIR ValueSelect 1GB 184-Pin DDR SDRAM Unbuffered DDR 400
> (PC 3200) System Memory - Retail",
> "manu":"Corsair Microsystems Inc."},
> {
> "name":"CORSAIR XMS 2GB (2 x 1GB) 184-Pin DDR SDRAM Unbuffered DDR
> 400 (PC 3200) Dual Channel Kit System Memory - Retail",
> "manu":"Corsair Microsystems Inc."}]
> },
> "highlighting":{
> "VS1GB400C3":{
> "name":["CORSAIR ValueSelect 1GB 184-Pin DDR SDRAM Unbuffered
> DDR 400 (PC 3200) System Memory - Retail"],
> "manu":["Corsair Microsystems Inc."]},
> "TWINX2048-3200PRO":{
> "name":["CORSAIR XMS 2GB (2 x 1GB) 184-Pin DDR SDRAM
> Unbuffered DDR 400 (PC 3200) Dual Channel Kit System"],
> "manu":["Corsair Microsystems Inc."]}}}
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-11334) UnifiedSolrHighlighter returns an error when hl.fl delimited by ", "
[
https://issues.apache.org/jira/browse/SOLR-11334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124551#comment-17124551
]
ASF subversion and git services commented on SOLR-11334:
Commit ca0d5d9368eac7dbf7e080b5d16ce2936e7ab2c3 in lucene-solr's branch
refs/heads/branch_8x from David Smiley
[ https://gitbox.apache.org/repos/asf?p=lucene-solr.git;h=ca0d5d9 ]
SOLR-11334: Split some field lists better
Used by HighlightComponent and TermVectorComponent
Used to produce an empty string on comma-space, leading to an exception.
(cherry picked from commit 2af82c83d9cf134eb8741d1da1eeb606946f5baa)
> UnifiedSolrHighlighter returns an error when hl.fl delimited by ", "
>
>
> Key: SOLR-11334
> URL: https://issues.apache.org/jira/browse/SOLR-11334
> Project: Solr
> Issue Type: Improvement
> Components: highlighter
>Affects Versions: 6.6
> Environment: Ubuntu 17.04 (GNU/Linux 4.10.0-33-generic x86_64)
> Java HotSpot 64-Bit Server VM(build 25.114-b01, mixed mode)
>Reporter: Yasufumi Mizoguchi
>Priority: Minor
> Attachments: SOLR-11334.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> UnifiedSolrHighlighter(hl.method=unified) misjudge the zero-length string as
> a field name and returns an error when hl.fl delimited by ", "
> request:
> {code}
> $ curl -XGET
> "http://localhost:8983/solr/techproducts/select?fl=name,%20manu&hl.fl=name,%20manu&hl.method=unified&hl=on&indent=on&q=corsair&wt=json";
> {code}
> response:
> {code}
> {
> "responseHeader":{
> "status":400,
> "QTime":8,
> "params":{
> "q":"corsair",
> "hl":"on",
> "indent":"on",
> "fl":"name, manu",
> "hl.fl":"name, manu",
> "hl.method":"unified",
> "wt":"json"}},
> "response":{"numFound":2,"start":0,"docs":[
> {
> "name":"CORSAIR ValueSelect 1GB 184-Pin DDR SDRAM Unbuffered DDR 400
> (PC 3200) System Memory - Retail",
> "manu":"Corsair Microsystems Inc."},
> {
> "name":"CORSAIR XMS 2GB (2 x 1GB) 184-Pin DDR SDRAM Unbuffered DDR
> 400 (PC 3200) Dual Channel Kit System Memory - Retail",
> "manu":"Corsair Microsystems Inc."}]
> },
> "error":{
> "metadata":[
> "error-class","org.apache.solr.common.SolrException",
> "root-error-class","org.apache.solr.common.SolrException"],
> "msg":"undefined field ",
> "code":400}}
> {code}
> DefaultHighlighter's response:
> {code}
> {
> "responseHeader":{
> "status":0,
> "QTime":5,
> "params":{
> "q":"corsair",
> "hl":"on",
> "indent":"on",
> "fl":"name, manu",
> "hl.fl":"name, manu",
> "hl.method":"original",
> "wt":"json"}},
> "response":{"numFound":2,"start":0,"docs":[
> {
> "name":"CORSAIR ValueSelect 1GB 184-Pin DDR SDRAM Unbuffered DDR 400
> (PC 3200) System Memory - Retail",
> "manu":"Corsair Microsystems Inc."},
> {
> "name":"CORSAIR XMS 2GB (2 x 1GB) 184-Pin DDR SDRAM Unbuffered DDR
> 400 (PC 3200) Dual Channel Kit System Memory - Retail",
> "manu":"Corsair Microsystems Inc."}]
> },
> "highlighting":{
> "VS1GB400C3":{
> "name":["CORSAIR ValueSelect 1GB 184-Pin DDR SDRAM Unbuffered
> DDR 400 (PC 3200) System Memory - Retail"],
> "manu":["Corsair Microsystems Inc."]},
> "TWINX2048-3200PRO":{
> "name":["CORSAIR XMS 2GB (2 x 1GB) 184-Pin DDR SDRAM
> Unbuffered DDR 400 (PC 3200) Dual Channel Kit System"],
> "manu":["Corsair Microsystems Inc."]}}}
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[GitHub] [lucene-solr] dsmiley closed pull request #1531: SOLR-11334: Split some field lists better
dsmiley closed pull request #1531: URL: https://github.com/apache/lucene-solr/pull/1531 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org - To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Updated] (SOLR-11334) UnifiedSolrHighlighter returns an error when hl.fl delimited by ", "
[
https://issues.apache.org/jira/browse/SOLR-11334?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley updated SOLR-11334:
Fix Version/s: 8.6
Assignee: David Smiley
Resolution: Fixed
Status: Resolved (was: Patch Available)
> UnifiedSolrHighlighter returns an error when hl.fl delimited by ", "
>
>
> Key: SOLR-11334
> URL: https://issues.apache.org/jira/browse/SOLR-11334
> Project: Solr
> Issue Type: Improvement
> Components: highlighter
>Affects Versions: 6.6
> Environment: Ubuntu 17.04 (GNU/Linux 4.10.0-33-generic x86_64)
> Java HotSpot 64-Bit Server VM(build 25.114-b01, mixed mode)
>Reporter: Yasufumi Mizoguchi
>Assignee: David Smiley
>Priority: Minor
> Fix For: 8.6
>
> Attachments: SOLR-11334.patch
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> UnifiedSolrHighlighter(hl.method=unified) misjudge the zero-length string as
> a field name and returns an error when hl.fl delimited by ", "
> request:
> {code}
> $ curl -XGET
> "http://localhost:8983/solr/techproducts/select?fl=name,%20manu&hl.fl=name,%20manu&hl.method=unified&hl=on&indent=on&q=corsair&wt=json";
> {code}
> response:
> {code}
> {
> "responseHeader":{
> "status":400,
> "QTime":8,
> "params":{
> "q":"corsair",
> "hl":"on",
> "indent":"on",
> "fl":"name, manu",
> "hl.fl":"name, manu",
> "hl.method":"unified",
> "wt":"json"}},
> "response":{"numFound":2,"start":0,"docs":[
> {
> "name":"CORSAIR ValueSelect 1GB 184-Pin DDR SDRAM Unbuffered DDR 400
> (PC 3200) System Memory - Retail",
> "manu":"Corsair Microsystems Inc."},
> {
> "name":"CORSAIR XMS 2GB (2 x 1GB) 184-Pin DDR SDRAM Unbuffered DDR
> 400 (PC 3200) Dual Channel Kit System Memory - Retail",
> "manu":"Corsair Microsystems Inc."}]
> },
> "error":{
> "metadata":[
> "error-class","org.apache.solr.common.SolrException",
> "root-error-class","org.apache.solr.common.SolrException"],
> "msg":"undefined field ",
> "code":400}}
> {code}
> DefaultHighlighter's response:
> {code}
> {
> "responseHeader":{
> "status":0,
> "QTime":5,
> "params":{
> "q":"corsair",
> "hl":"on",
> "indent":"on",
> "fl":"name, manu",
> "hl.fl":"name, manu",
> "hl.method":"original",
> "wt":"json"}},
> "response":{"numFound":2,"start":0,"docs":[
> {
> "name":"CORSAIR ValueSelect 1GB 184-Pin DDR SDRAM Unbuffered DDR 400
> (PC 3200) System Memory - Retail",
> "manu":"Corsair Microsystems Inc."},
> {
> "name":"CORSAIR XMS 2GB (2 x 1GB) 184-Pin DDR SDRAM Unbuffered DDR
> 400 (PC 3200) Dual Channel Kit System Memory - Retail",
> "manu":"Corsair Microsystems Inc."}]
> },
> "highlighting":{
> "VS1GB400C3":{
> "name":["CORSAIR ValueSelect 1GB 184-Pin DDR SDRAM Unbuffered
> DDR 400 (PC 3200) System Memory - Retail"],
> "manu":["Corsair Microsystems Inc."]},
> "TWINX2048-3200PRO":{
> "name":["CORSAIR XMS 2GB (2 x 1GB) 184-Pin DDR SDRAM
> Unbuffered DDR 400 (PC 3200) Dual Channel Kit System"],
> "manu":["Corsair Microsystems Inc."]}}}
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
[jira] [Commented] (SOLR-14520) json.facets: allBucket:true can cause server errors when combined with refine:true
[
https://issues.apache.org/jira/browse/SOLR-14520?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17124573#comment-17124573
]
Lucene/Solr QA commented on SOLR-14520:
---
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} test4tests {color} | {color:green} 0m
0s{color} | {color:green} The patch appears to include 1 new or modified test
files. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
3s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m
4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Release audit (RAT) {color} |
{color:green} 1m 4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Check forbidden APIs {color} |
{color:green} 1m 4s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} Validate source patterns {color} |
{color:green} 1m 4s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} unit {color} | {color:green} 46m
49s{color} | {color:green} core in the patch passed. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 50m 48s{color} |
{color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| JIRA Issue | SOLR-14520 |
| JIRA Patch URL |
https://issues.apache.org/jira/secure/attachment/13004656/SOLR-14520.patch |
| Optional Tests | compile javac unit ratsources checkforbiddenapis
validatesourcepatterns |
| uname | Linux lucene1-us-west 4.15.0-54-generic #58-Ubuntu SMP Mon Jun 24
10:55:24 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | ant |
| Personality |
/home/jenkins/jenkins-slave/workspace/PreCommit-SOLR-Build/sourcedir/dev-tools/test-patch/lucene-solr-yetus-personality.sh
|
| git revision | master / a06f57c7e16 |
| ant | version: Apache Ant(TM) version 1.10.5 compiled on March 28 2019 |
| Default Java | LTS |
| Test Results |
https://builds.apache.org/job/PreCommit-SOLR-Build/759/testReport/ |
| modules | C: solr/core U: solr/core |
| Console output |
https://builds.apache.org/job/PreCommit-SOLR-Build/759/console |
| Powered by | Apache Yetus 0.7.0 http://yetus.apache.org |
This message was automatically generated.
> json.facets: allBucket:true can cause server errors when combined with
> refine:true
> --
>
> Key: SOLR-14520
> URL: https://issues.apache.org/jira/browse/SOLR-14520
> Project: Solr
> Issue Type: Bug
> Components: Facet Module
>Reporter: Chris M. Hostetter
>Priority: Major
> Attachments: SOLR-14520.patch, SOLR-14520.patch, SOLR-14520.patch
>
>
> Another bug that was discovered while testing SOLR-14467...
> In some situations, using {{allBuckets:true}} in conjunction with
> {{refine:true}} can cause server errors during the "refinement" requests to
> the individual shards -- either NullPointerExceptions from some (nested)
> SlotAccs when SpecialSlotAcc tries to collect them, or
> ArrayIndexOutOfBoundsException from CountSlotArrAcc.incrementCount because
> it's asked to collect to "large" slot# values even though it's been
> initialized with a size of '1'
> NOTE: these problems may be specific to FacetFieldProcessorByArrayDV - i have
> not yet seen similar failures from FacetFieldProcessorByArrayUIF (those are
> the only 2 used when doing refinement) but that may just be a fluke of
> testing.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
-
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
