Re: [PR] Check for empty responses [iceberg-python]

2023-10-14 Thread via GitHub


Fokko merged PR #69:
URL: https://github.com/apache/iceberg-python/pull/69


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org



Re: [PR] Fix Arrow fixed type [iceberg-python]

2023-10-14 Thread via GitHub


Fokko merged PR #70:
URL: https://github.com/apache/iceberg-python/pull/70


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org



Re: [PR] Bump version to 0.5.1 [iceberg-python]

2023-10-14 Thread via GitHub


Fokko merged PR #68:
URL: https://github.com/apache/iceberg-python/pull/68


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org



Re: [PR] Spark 3.4: Fix issue when partitioning by UUID [iceberg]

2023-10-14 Thread via GitHub


singhpk234 commented on code in PR #8250:
URL: https://github.com/apache/iceberg/pull/8250#discussion_r1359495723


##
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/InternalRowWrapper.java:
##
@@ -71,8 +77,12 @@ public  void set(int pos, T value) {
 row.update(pos, value);
   }
 
-  private static BiFunction getter(DataType type) {
+  private static BiFunction getter(Type icebergType, 
DataType type) {
 if (type instanceof StringType) {
+  if (Type.TypeID.UUID == icebergType.typeId()) {

Review Comment:
   can we add a comment here explaining that a StringType may be a UUID-type 
hence return UUID also should we explicity check the else case saying if it's 
not StringType either throw UnReachable or Unsupported ops or null accordingly 
? 



##
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/InternalRowWrapper.java:
##
@@ -40,9 +43,12 @@ class InternalRowWrapper implements StructLike {
   private InternalRow row = null;
 
   @SuppressWarnings("unchecked")
-  InternalRowWrapper(StructType rowType) {
+  InternalRowWrapper(StructType rowType, Types.StructType icebergStruct) {

Review Comment:
   should we have a Pre-condition check that icebergStruct.fields().length is 
equal to types.lenght ? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org



[PR] JDBC: JDBC Catalog should do exact namespace search for get namespace queries [iceberg]

2023-10-14 Thread via GitHub


amogh-jahagirdar opened a new pull request, #8833:
URL: https://github.com/apache/iceberg/pull/8833

   Fixes #8832
   
   Currently the SQL query to get namespace does a regex based search + limit 1 
, which is used during namespace existence checks. I believe this behavior is 
not correct, it should do an exact lookup


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org



Re: [I] [JdbcCatalog] Issue with Namespace Exists [iceberg]

2023-10-14 Thread via GitHub


amogh-jahagirdar commented on issue #8832:
URL: https://github.com/apache/iceberg/issues/8832#issuecomment-1763151183

   Thanks for reporting @haizhou-zhao , this is a surprising behavior. I put up 
a fix for this in #8833 to do exact search, let me know what you think.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org



Re: [PR] JDBC: JDBC Catalog should do exact namespace search for get namespace queries [iceberg]

2023-10-14 Thread via GitHub


amogh-jahagirdar commented on code in PR #8833:
URL: https://github.com/apache/iceberg/pull/8833#discussion_r1359617907


##
core/src/main/java/org/apache/iceberg/jdbc/JdbcUtil.java:
##
@@ -135,7 +135,7 @@ final class JdbcUtil {
   + CATALOG_NAME
   + " = ? AND "
   + TABLE_NAMESPACE
-  + " LIKE ? LIMIT 1";
+  + " = ?";

Review Comment:
   Oh, actually we would still want the limit 1 to shortcut for the existence 
checks since this queries the "all tables" table.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org



[PR] Core: fix reading of split offsets in manifests [iceberg]

2023-10-14 Thread via GitHub


bryanck opened a new pull request, #8834:
URL: https://github.com/apache/iceberg/pull/8834

   This PR fixes a critical bug in reading split offsets from manifests. A 
change in https://github.com/apache/iceberg/pull/8336 added caching of the 
offsets collection in `BaseFile` to avoid reallocation. However, the Avro 
reader will reuse the same BaseFile object when reading, thus only the offsets 
from the first entry are allocated, and then those are reused for all  other 
entries.
   
   cc @aokolnychyi @RussellSpitzer @rdblue @danielcweeks This can result in 
corrupted metadata, as rewrite manifests will read in the invalid offsets then 
write those back.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org



Re: [PR] Core: fix reading of split offsets in manifests [iceberg]

2023-10-14 Thread via GitHub


bryanck commented on code in PR #8834:
URL: https://github.com/apache/iceberg/pull/8834#discussion_r1359632733


##
core/src/main/java/org/apache/iceberg/BaseFile.java:
##
@@ -463,11 +463,7 @@ public ByteBuffer keyMetadata() {
 
   @Override
   public List splitOffsets() {
-if (splitOffsetList == null && splitOffsets != null) {
-  this.splitOffsetList = ArrayUtil.toUnmodifiableLongList(splitOffsets);
-}
-
-return splitOffsetList;
+return splitOffsets == null ? ImmutableList.of() : 
Longs.asList(splitOffsets);

Review Comment:
   The intent of the original PR was to avoid the inefficient allocation of 
long primitives into a collection. The Guava wrapper should be much more 
efficient than the original allocation code.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org



Re: [PR] Core: fix reading of split offsets in manifests [iceberg]

2023-10-14 Thread via GitHub


bryanck commented on code in PR #8834:
URL: https://github.com/apache/iceberg/pull/8834#discussion_r1359632733


##
core/src/main/java/org/apache/iceberg/BaseFile.java:
##
@@ -463,11 +463,7 @@ public ByteBuffer keyMetadata() {
 
   @Override
   public List splitOffsets() {
-if (splitOffsetList == null && splitOffsets != null) {
-  this.splitOffsetList = ArrayUtil.toUnmodifiableLongList(splitOffsets);
-}
-
-return splitOffsetList;
+return splitOffsets == null ? ImmutableList.of() : 
Longs.asList(splitOffsets);

Review Comment:
   The intent of the original PR was to avoid the inefficient copy of long 
primitives into a collection. The Guava wrapper should be much more efficient 
than the original allocation code.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org



Re: [PR] Core: fix reading of split offsets in manifests [iceberg]

2023-10-14 Thread via GitHub


bryanck commented on code in PR #8834:
URL: https://github.com/apache/iceberg/pull/8834#discussion_r1359632733


##
core/src/main/java/org/apache/iceberg/BaseFile.java:
##
@@ -463,11 +463,7 @@ public ByteBuffer keyMetadata() {
 
   @Override
   public List splitOffsets() {
-if (splitOffsetList == null && splitOffsets != null) {
-  this.splitOffsetList = ArrayUtil.toUnmodifiableLongList(splitOffsets);
-}
-
-return splitOffsetList;
+return splitOffsets == null ? ImmutableList.of() : 
Longs.asList(splitOffsets);

Review Comment:
   The intent of the original PR was to avoid the inefficient copy of long 
primitives into a collection. The Guava wrapper should be much more efficient 
than the allocation being done previously.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org



Re: [PR] Core: fix reading of split offsets in manifests [iceberg]

2023-10-14 Thread via GitHub


bryanck commented on code in PR #8834:
URL: https://github.com/apache/iceberg/pull/8834#discussion_r1359633367


##
core/src/main/java/org/apache/iceberg/BaseFile.java:
##
@@ -476,7 +472,7 @@ long[] splitOffsetArray() {
 
   @Override
   public List equalityFieldIds() {
-return ArrayUtil.toIntList(equalityIds);
+return equalityIds == null ? ImmutableList.of() : Ints.asList(equalityIds);

Review Comment:
   Using the same Guava wrapper here as well.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org



Re: [PR] Core: fix reading of split offsets in manifests [iceberg]

2023-10-14 Thread via GitHub


bryanck commented on PR #8834:
URL: https://github.com/apache/iceberg/pull/8834#issuecomment-1763167751

   I'm working on adding a test, but wanted to post this ASAP.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org



Re: [PR] Core: Simplify/improve View APIs [iceberg]

2023-10-14 Thread via GitHub


wmoustafa commented on PR #7992:
URL: https://github.com/apache/iceberg/pull/7992#issuecomment-1763172619

   > Also, I'm not convinced that you can/should have `field-aliases` and 
`field-comments` at the top-level. Some engines may support field aliases, but 
others do not so they don't apply equally to the representations and is 
inconsistent with the spec, which has them at the representation level.
   
   +1. Also worth considering whether "Representation" really refers to an 
engine or a dialect. Right now it looks like dialect, but even if we go with 
the above we will be making an implicit correlation between dialect and engine.
   
   > I think it's fine to omit the default catalog and default namespaces, 
especially if we can appropriately qualify them in the engine when constructing 
the sql representation.
   
   +1. How are we thinking about the fact that catalog names are not the same 
across engines, even when the underlying tables end up being looked up from the 
same metastore/catalog? E.g., `hive.db.t` in Trino might refer to the same 
table as `spark_catalog.db.t` in Spark?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org



Re: [PR] Core: fix reading of split offsets in manifests [iceberg]

2023-10-14 Thread via GitHub


danielcweeks commented on code in PR #8834:
URL: https://github.com/apache/iceberg/pull/8834#discussion_r1359638251


##
core/src/main/java/org/apache/iceberg/BaseFile.java:
##
@@ -463,11 +463,7 @@ public ByteBuffer keyMetadata() {
 
   @Override
   public List splitOffsets() {
-if (splitOffsetList == null && splitOffsets != null) {
-  this.splitOffsetList = ArrayUtil.toUnmodifiableLongList(splitOffsets);
-}
-
-return splitOffsetList;
+return splitOffsets == null ? ImmutableList.of() : 
Longs.asList(splitOffsets);

Review Comment:
   I think we might want to return null in the event there are no split 
offsets. That looks like the original behavior, and I think most of the checks 
are looking for Noel to decide between offset planning and basic split planning.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org



Re: [PR] Core: fix reading of split offsets in manifests [iceberg]

2023-10-14 Thread via GitHub


danielcweeks commented on code in PR #8834:
URL: https://github.com/apache/iceberg/pull/8834#discussion_r1359638251


##
core/src/main/java/org/apache/iceberg/BaseFile.java:
##
@@ -463,11 +463,7 @@ public ByteBuffer keyMetadata() {
 
   @Override
   public List splitOffsets() {
-if (splitOffsetList == null && splitOffsets != null) {
-  this.splitOffsetList = ArrayUtil.toUnmodifiableLongList(splitOffsets);
-}
-
-return splitOffsetList;
+return splitOffsets == null ? ImmutableList.of() : 
Longs.asList(splitOffsets);

Review Comment:
   I think we might want to return null in the event there are no split 
offsets. That looks like the original behavior, and I think most of the checks 
are looking for null to decide between offset planning and basic split planning.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org



Re: [PR] Core: fix reading of split offsets in manifests [iceberg]

2023-10-14 Thread via GitHub


bryanck commented on code in PR #8834:
URL: https://github.com/apache/iceberg/pull/8834#discussion_r1359639050


##
core/src/main/java/org/apache/iceberg/BaseFile.java:
##
@@ -463,11 +463,7 @@ public ByteBuffer keyMetadata() {
 
   @Override
   public List splitOffsets() {
-if (splitOffsetList == null && splitOffsets != null) {
-  this.splitOffsetList = ArrayUtil.toUnmodifiableLongList(splitOffsets);
-}
-
-return splitOffsetList;
+return splitOffsets == null ? ImmutableList.of() : 
Longs.asList(splitOffsets);

Review Comment:
   Right, I missed, that, I made this change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org



Re: [PR] docs: Clarify some view issues [iceberg]

2023-10-14 Thread via GitHub


wmoustafa commented on code in PR #7504:
URL: https://github.com/apache/iceberg/pull/7504#discussion_r1359640842


##
format/view-spec.md:
##
@@ -328,3 +330,17 @@ 
s3://bucket/warehouse/default.db/event_agg/metadata/2-(uuid).metadata.json
   } ]
 }
 ```
+
+## Appendix B: Well Known (canonical) dialects
+
+The following dialects names are reserved and indicate dialects for specific 
systems:
+
+| Dialect Name | Description   
| Versioning  |
+|--|---|-|
+|athena|  [Amazon Athena 
Dialect](https://docs.aws.amazon.com/athena/latest/ug/ddl-sql-reference.html)   
  | TBD |

Review Comment:
   Bumping up this thread @jackye1995.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org



Re: [PR] Core: fix reading of split offsets in manifests [iceberg]

2023-10-14 Thread via GitHub


bryanck commented on PR #8834:
URL: https://github.com/apache/iceberg/pull/8834#issuecomment-1763214878

   > I'm working on adding a test, but wanted to post this ASAP.
   
   I updated a test to cover this case.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org



Re: [I] Pushdown min/max/count to partitions metadata table [iceberg]

2023-10-14 Thread via GitHub


github-actions[bot] commented on issue #7365:
URL: https://github.com/apache/iceberg/issues/7365#issuecomment-1763216091

   This issue has been automatically marked as stale because it has been open 
for 180 days with no activity. It will be closed in next 14 days if no further 
activity occurs. To permanently prevent this issue from being considered stale, 
add the label 'not-stale', but commenting on the issue is preferred when 
possible.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org



Re: [I] Broken Unit tests on Windows OS [iceberg]

2023-10-14 Thread via GitHub


github-actions[bot] commented on issue #7287:
URL: https://github.com/apache/iceberg/issues/7287#issuecomment-1763216102

   This issue has been automatically marked as stale because it has been open 
for 180 days with no activity. It will be closed in next 14 days if no further 
activity occurs. To permanently prevent this issue from being considered stale, 
add the label 'not-stale', but commenting on the issue is preferred when 
possible.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org



Re: [PR] Core: fix reading of split offsets in manifests [iceberg]

2023-10-14 Thread via GitHub


bryanck commented on code in PR #8834:
URL: https://github.com/apache/iceberg/pull/8834#discussion_r1359633367


##
core/src/main/java/org/apache/iceberg/BaseFile.java:
##
@@ -476,7 +472,7 @@ long[] splitOffsetArray() {
 
   @Override
   public List equalityFieldIds() {
-return ArrayUtil.toIntList(equalityIds);
+return equalityIds == null ? ImmutableList.of() : Ints.asList(equalityIds);

Review Comment:
   Using the same Guava wrapper here as well. This is a slight change in 
behavor as you can't add elements to the resulting list, but I didn't find 
instances where the list needed to be mutable.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org



Re: [PR] Core: fix reading of split offsets in manifests [iceberg]

2023-10-14 Thread via GitHub


bryanck commented on code in PR #8834:
URL: https://github.com/apache/iceberg/pull/8834#discussion_r1359632733


##
core/src/main/java/org/apache/iceberg/BaseFile.java:
##
@@ -463,11 +463,7 @@ public ByteBuffer keyMetadata() {
 
   @Override
   public List splitOffsets() {
-if (splitOffsetList == null && splitOffsets != null) {
-  this.splitOffsetList = ArrayUtil.toUnmodifiableLongList(splitOffsets);
-}
-
-return splitOffsetList;
+return splitOffsets == null ? ImmutableList.of() : 
Longs.asList(splitOffsets);

Review Comment:
   The intent of the original PR was to avoid the inefficient copy of long 
primitives into a collection. The Guava wrapper should be much more efficient 
than the allocation being done previously. This does prevent the resulting list 
from being added to, but I didn't find instances where the list needed to be 
mutable 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org



Re: [PR] Core: fix reading of split offsets in manifests [iceberg]

2023-10-14 Thread via GitHub


bryanck commented on code in PR #8834:
URL: https://github.com/apache/iceberg/pull/8834#discussion_r1359633367


##
core/src/main/java/org/apache/iceberg/BaseFile.java:
##
@@ -476,7 +472,7 @@ long[] splitOffsetArray() {
 
   @Override
   public List equalityFieldIds() {
-return ArrayUtil.toIntList(equalityIds);
+return equalityIds == null ? ImmutableList.of() : Ints.asList(equalityIds);

Review Comment:
   Using the same Guava wrapper here as well (also with a slight change in 
behavior with a list that can't be added to).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org



Re: [PR] Core: fix reading of split offsets in manifests [iceberg]

2023-10-14 Thread via GitHub


bryanck commented on code in PR #8834:
URL: https://github.com/apache/iceberg/pull/8834#discussion_r1359632733


##
core/src/main/java/org/apache/iceberg/BaseFile.java:
##
@@ -463,11 +463,7 @@ public ByteBuffer keyMetadata() {
 
   @Override
   public List splitOffsets() {
-if (splitOffsetList == null && splitOffsets != null) {
-  this.splitOffsetList = ArrayUtil.toUnmodifiableLongList(splitOffsets);
-}
-
-return splitOffsetList;
+return splitOffsets == null ? ImmutableList.of() : 
Longs.asList(splitOffsets);

Review Comment:
   The intent of the original PR was to avoid the inefficient copy of long 
primitives into a collection. The Guava wrapper should be much more efficient 
than the allocation being done previously, so still an improvement.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org



Re: [PR] Core: fix reading of split offsets in manifests [iceberg]

2023-10-14 Thread via GitHub


bryanck commented on code in PR #8834:
URL: https://github.com/apache/iceberg/pull/8834#discussion_r1359633367


##
core/src/main/java/org/apache/iceberg/BaseFile.java:
##
@@ -476,7 +472,7 @@ long[] splitOffsetArray() {
 
   @Override
   public List equalityFieldIds() {
-return ArrayUtil.toIntList(equalityIds);
+return equalityIds == null ? ImmutableList.of() : Ints.asList(equalityIds);

Review Comment:
   Using the same Guava wrapper here as well (also with a slight change in 
behavior with a list that can't be added to).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org



Re: [I] rewrite_position_delete_files leads to error [iceberg]

2023-10-14 Thread via GitHub


atifiu commented on issue #8045:
URL: https://github.com/apache/iceberg/issues/8045#issuecomment-1763254744

   And we are still using spark 3.3.1 so is there any way to get around this 
issue without upgrading to spark 3.4 and iceberg 1.3.1.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org



[PR] Build: Bump nessie from 0.71.1 to 0.72.0 [iceberg]

2023-10-14 Thread via GitHub


dependabot[bot] opened a new pull request, #8835:
URL: https://github.com/apache/iceberg/pull/8835

   Bumps `nessie` from 0.71.1 to 0.72.0.
   Updates `org.projectnessie.nessie:nessie-client` from 0.71.1 to 0.72.0
   
   Updates `org.projectnessie.nessie:nessie-jaxrs-testextension` from 0.71.1 to 
0.72.0
   
   Updates `org.projectnessie.nessie:nessie-versioned-storage-inmemory` from 
0.71.1 to 0.72.0
   
   Updates `org.projectnessie.nessie:nessie-versioned-storage-testextension` 
from 0.71.1 to 0.72.0
   
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot show  ignore conditions` will show all of 
the ignore conditions of the specified dependency
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org



[PR] Build: Bump com.fasterxml.jackson.core:jackson-annotations from 2.15.2 to 2.15.3 [iceberg]

2023-10-14 Thread via GitHub


dependabot[bot] opened a new pull request, #8836:
URL: https://github.com/apache/iceberg/pull/8836

   Bumps 
[com.fasterxml.jackson.core:jackson-annotations](https://github.com/FasterXML/jackson)
 from 2.15.2 to 2.15.3.
   
   Commits
   
   See full diff in https://github.com/FasterXML/jackson/commits";>compare view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.fasterxml.jackson.core:jackson-annotations&package-manager=gradle&previous-version=2.15.2&new-version=2.15.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot show  ignore conditions` will show all of 
the ignore conditions of the specified dependency
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org



[PR] Build: Bump org.xerial:sqlite-jdbc from 3.43.0.0 to 3.43.2.0 [iceberg]

2023-10-14 Thread via GitHub


dependabot[bot] opened a new pull request, #8837:
URL: https://github.com/apache/iceberg/pull/8837

   Bumps [org.xerial:sqlite-jdbc](https://github.com/xerial/sqlite-jdbc) from 
3.43.0.0 to 3.43.2.0.
   
   Release notes
   Sourced from https://github.com/xerial/sqlite-jdbc/releases";>org.xerial:sqlite-jdbc's 
releases.
   
   Release 3.43.2.0
   Changelog
   πŸš€ Features
   
   upgrade to sqlite 3.43.2 (https://github.com/xerial/sqlite-jdbc/commits/a434c78";>a434c78)
   add slf44-api to replace use of standard streams (https://github.com/xerial/sqlite-jdbc/commits/21c77a4";>21c77a4), 
closes https://redirect.github.com/xerial/sqlite-jdbc/issues/802";>#802
   upgrade to sqlite 3.43.1 (https://github.com/xerial/sqlite-jdbc/commits/7b40a6a";>7b40a6a)
   
   πŸ› Fixes
   native-image
   
   do not initialize logging framework at build-time (https://github.com/xerial/sqlite-jdbc/commits/d8f762c";>d8f762c)
   
   unscoped
   
   add missing module requirement for slf4j (https://github.com/xerial/sqlite-jdbc/commits/32082c0";>32082c0)
   add SONAME to Android binaries (https://github.com/xerial/sqlite-jdbc/commits/f6a3aef";>f6a3aef), 
closes https://redirect.github.com/xerial/sqlite-jdbc/issues/960";>#960
   
   🏎 Perf
   
   remove use of DriverManager.println (https://github.com/xerial/sqlite-jdbc/commits/75ce563";>75ce563), 
closes https://redirect.github.com/xerial/sqlite-jdbc/issues/984";>#984
   
   πŸ”„οΈ Changes
   
   spotless apply (https://github.com/xerial/sqlite-jdbc/commits/77339ed";>77339ed)
   replace generic exceptions (https://github.com/xerial/sqlite-jdbc/commits/6d563d4";>6d563d4)
   
   πŸ›   Build
   deps
   
   bump org.codehaus.mojo:versions-maven-plugin (https://github.com/xerial/sqlite-jdbc/commits/ebdda17";>ebdda17)
   bump org.apache.maven.plugins:maven-javadoc-plugin (https://github.com/xerial/sqlite-jdbc/commits/5e37532";>5e37532)
   bump org.apache.maven.plugins:maven-enforcer-plugin (https://github.com/xerial/sqlite-jdbc/commits/b3188dc";>b3188dc)
   bump actions/checkout from 3 to 4 (https://github.com/xerial/sqlite-jdbc/commits/3eaabec";>3eaabec)
   bump org.jreleaser:jreleaser-maven-plugin (https://github.com/xerial/sqlite-jdbc/commits/07d420d";>07d420d)
   
   deps-dev
   
   bump org.mockito:mockito-core from 5.5.0 to 5.6.0 (https://github.com/xerial/sqlite-jdbc/commits/54aa6ab";>54aa6ab)
   bump org.junit-pioneer:junit-pioneer (https://github.com/xerial/sqlite-jdbc/commits/b363636";>b363636)
   
   makefile
   
   add slf4j dependency (https://github.com/xerial/sqlite-jdbc/commits/1663cfe";>1663cfe)
   
   unscoped
   
   update native-image testing to GraalVM 21 (https://github.com/xerial/sqlite-jdbc/commits/1229f00";>1229f00)
   fix native configuration for slf4j (https://github.com/xerial/sqlite-jdbc/commits/89dbda1";>89dbda1)
   MultipleClassLoaderTest fails on Windows (https://github.com/xerial/sqlite-jdbc/commits/d4f4dc2";>d4f4dc2)
   
   Contributors
   We'd like to thank the following people for their contributions:
   Gauthier, Gauthier Roebroeck, Kristof
   
   
   
   Commits
   
   https://github.com/xerial/sqlite-jdbc/commit/120b82bcdbed8a2a59c50e10f28071dc443e7d02";>120b82b
 chore(release): 3.43.2.0 [skip ci]
   https://github.com/xerial/sqlite-jdbc/commit/989bf35b3dadbbbc5bb68e9fce816268e993e63b";>989bf35
 chore: update native libraries
   https://github.com/xerial/sqlite-jdbc/commit/c049cbd89f8b4516a3a5b84688bc1c1fc147088b";>c049cbd
 chore: upgrade to sqlite 3.43.2
   https://github.com/xerial/sqlite-jdbc/commit/870917795b33e8b16998e39554d000fa19e7e1fd";>8709177
 chore: update native libraries
   https://github.com/xerial/sqlite-jdbc/commit/a434c78363e19bcc560e2dc3a0e31c48c1b56b13";>a434c78
 feat: upgrade to sqlite 3.43.2
   https://github.com/xerial/sqlite-jdbc/commit/54aa6abbf829452c81511ef8400bfbdac1c10e38";>54aa6ab
 build(deps-dev): bump org.mockito:mockito-core from 5.5.0 to 5.6.0
   https://github.com/xerial/sqlite-jdbc/commit/d8f762c9974d514d1894dd91f638781faf35a5a5";>d8f762c
 fix(native-image): do not initialize logging framework at build-time
   https://github.com/xerial/sqlite-jdbc/commit/1229f0006a9c868662c004f78d819c9cd8f502ad";>1229f00
 ci: update native-image testing to GraalVM 21
   https://github.com/xerial/sqlite-jdbc/commit/89dbda1bb21bc7df004419edb32e26f17bbb0e19";>89dbda1
 build: fix native configuration for slf4j
   https://github.com/xerial/sqlite-jdbc/commit/32082c0504d02ee4b0b379b6cc4f26fc9fcf95ab";>32082c0
 fix: add missing module requirement for slf4j
   Additional commits viewable in https://github.com/xerial/sqlite-jdbc/compare/3.43.0.0...3.43.2.0";>compare
 view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=org.xerial:sqlite-jdbc&package-manager=gradle&previous-version=3.43.0.0&new-version=3.43.2.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabo

[PR] Build: Bump software.amazon.awssdk:bom from 2.20.162 to 2.21.0 [iceberg]

2023-10-14 Thread via GitHub


dependabot[bot] opened a new pull request, #8838:
URL: https://github.com/apache/iceberg/pull/8838

   Bumps software.amazon.awssdk:bom from 2.20.162 to 2.21.0.
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=software.amazon.awssdk:bom&package-manager=gradle&previous-version=2.20.162&new-version=2.21.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot show  ignore conditions` will show all of 
the ignore conditions of the specified dependency
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org



[PR] Build: Bump com.fasterxml.jackson.dataformat:jackson-dataformat-xml from 2.9.9 to 2.15.3 [iceberg]

2023-10-14 Thread via GitHub


dependabot[bot] opened a new pull request, #8839:
URL: https://github.com/apache/iceberg/pull/8839

   Bumps 
[com.fasterxml.jackson.dataformat:jackson-dataformat-xml](https://github.com/FasterXML/jackson-dataformat-xml)
 from 2.9.9 to 2.15.3.
   
   Commits
   
   https://github.com/FasterXML/jackson-dataformat-xml/commit/746bda99b1a3e196f5879c8818681052de1eddc1";>746bda9
 [maven-release-plugin] prepare release jackson-dataformat-xml-2.15.3
   https://github.com/FasterXML/jackson-dataformat-xml/commit/fd589a502a3c9ec4a41f461c089851aa2873bee9";>fd589a5
 Prepare for 2.15.3 release
   https://github.com/FasterXML/jackson-dataformat-xml/commit/1a06d23a8e7ee1781cb26365098aaca4f004e9e2";>1a06d23
 2.15.3-SNAPSHOT
   https://github.com/FasterXML/jackson-dataformat-xml/commit/c96cf3e160b96973535d0341eaf06158820f";>c96cf3e
 [maven-release-plugin] prepare for next development iteration
   https://github.com/FasterXML/jackson-dataformat-xml/commit/129404fa3be53b76503d6831a825605b5a2c365a";>129404f
 [maven-release-plugin] prepare release jackson-dataformat-xml-2.15.2
   https://github.com/FasterXML/jackson-dataformat-xml/commit/37352b3a097765732a33ea9ebf71954e4316d778";>37352b3
 2.15.2 release
   https://github.com/FasterXML/jackson-dataformat-xml/commit/536a3237d26b3092edbbf2a9c9e948ff3f71c632";>536a323
 Fix a test
   https://github.com/FasterXML/jackson-dataformat-xml/commit/0dde658e3b01d07abf45ce84c26978d928310475";>0dde658
 Add a test wrt https://redirect.github.com/FasterXML/jackson-dataformat-xml/issues/579";>#579
   https://github.com/FasterXML/jackson-dataformat-xml/commit/679c7937932680fcb7de57f906bebe25a317b337";>679c793
 Minor test addition
   https://github.com/FasterXML/jackson-dataformat-xml/commit/25c2cac3d8ebe36a287daa5bfe8e6acde73745a5";>25c2cac
 Back to snapshot dep
   Additional commits viewable in https://github.com/FasterXML/jackson-dataformat-xml/compare/jackson-dataformat-xml-2.9.9...jackson-dataformat-xml-2.15.3";>compare
 view
   
   
   
   
   
   [![Dependabot compatibility 
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=com.fasterxml.jackson.dataformat:jackson-dataformat-xml&package-manager=gradle&previous-version=2.9.9&new-version=2.15.3)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
   
   Dependabot will resolve any conflicts with this PR as long as you don't 
alter it yourself. You can also trigger a rebase manually by commenting 
`@dependabot rebase`.
   
   [//]: # (dependabot-automerge-start)
   [//]: # (dependabot-automerge-end)
   
   ---
   
   
   Dependabot commands and options
   
   
   You can trigger Dependabot actions by commenting on this PR:
   - `@dependabot rebase` will rebase this PR
   - `@dependabot recreate` will recreate this PR, overwriting any edits that 
have been made to it
   - `@dependabot merge` will merge this PR after your CI passes on it
   - `@dependabot squash and merge` will squash and merge this PR after your CI 
passes on it
   - `@dependabot cancel merge` will cancel a previously requested merge and 
block automerging
   - `@dependabot reopen` will reopen this PR if it is closed
   - `@dependabot close` will close this PR and stop Dependabot recreating it. 
You can achieve the same result by closing it manually
   - `@dependabot show  ignore conditions` will show all of 
the ignore conditions of the specified dependency
   - `@dependabot ignore this major version` will close this PR and stop 
Dependabot creating any more for this major version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this minor version` will close this PR and stop 
Dependabot creating any more for this minor version (unless you reopen the PR 
or upgrade to it yourself)
   - `@dependabot ignore this dependency` will close this PR and stop 
Dependabot creating any more for this dependency (unless you reopen the PR or 
upgrade to it yourself)
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org



Re: [PR] Build: Bump com.fasterxml.jackson.dataformat:jackson-dataformat-xml from 2.9.9 to 2.15.2 [iceberg]

2023-10-14 Thread via GitHub


dependabot[bot] commented on PR #8789:
URL: https://github.com/apache/iceberg/pull/8789#issuecomment-1763268099

   Superseded by #8839.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org



[PR] Build: Bump com.palantir.baseline:gradle-baseline-java from 4.42.0 to 5.25.0 [iceberg]

2023-10-14 Thread via GitHub


dependabot[bot] opened a new pull request, #8840:
URL: https://github.com/apache/iceberg/pull/8840

   Bumps 
[com.palantir.baseline:gradle-baseline-java](https://github.com/palantir/gradle-baseline)
 from 4.42.0 to 5.25.0.
   
   Release notes
   Sourced from https://github.com/palantir/gradle-baseline/releases";>com.palantir.baseline:gradle-baseline-java's
 releases.
   
   5.25.0
   
   
   
   Type
   Description
   Link
   
   
   
   
   Fix
   Revert "Lazy exact dependencies"
   https://redirect.github.com/palantir/gradle-baseline/pull/2642";>palantir/gradle-baseline#2642
   
   
   
   5.24.0
   
   
   
   Type
   Description
   Link
   
   
   
   
   Fix
   baseline-exact-dependencies is now far more lazy around 
Configuration creation in order to support Gradle 8.
   https://redirect.github.com/palantir/gradle-baseline/pull/2639";>palantir/gradle-baseline#2639
   
   
   
   5.23.0
   
   
   
   Type
   Description
   Link
   
   
   
   
   Fix
   Use a Proxy for JavaInstallationMetadata so we 
can work across Gradle 7 and 8.
   https://redirect.github.com/palantir/gradle-baseline/pull/2605";>palantir/gradle-baseline#2605
   
   
   
   5.22.0
   Automated release, no documented user facing changes
   5.21.0
   
   
   
   Type
   Description
   Link
   
   
   
   
   Improvement
   Upgrade error-prone to 2.21.1 (from 2.19.1)
   https://redirect.github.com/palantir/gradle-baseline/pull/2628";>palantir/gradle-baseline#2628
   
   
   
   5.20.0
   
   
   
   Type
   Description
   Link
   
   
   
   
   Improvement
   Improve SafeLoggingPropagation on Immutables, taking into account fields 
from superinterfaces
   https://redirect.github.com/palantir/gradle-baseline/pull/2629";>palantir/gradle-baseline#2629
   
   
   
   5.19.0
   
   
   
   Type
   Description
   Link
   
   
   
   
   Improvement
   Prefer InputStream.transferTo(OutputStream)Add error-prone check to automate migration 
to prefer InputStream.transferTo(OutputStream) instead of utility 
methods such as Guava's 
com.google.common.io.ByteStreams.copy(InputStream, 
OutputStream).Allow 
for optimization when underlying input stream (such as 
ByteArrayInputStream, ChannelInputStream) overrides 
transferTo(OutputStream) to avoid extra array allocations and copy 
larger chunks at a time (e.g. allowing 16KiB chunks via 
ApacheHttpClientBlockingChannel.ModulatingOutputStream from https://redirect.github.com/palantir/gradle-baseline/issues/1790";>#1790).When running on JDK 21+, this 
also enables 16KiB byte chunk copies via 
InputStream.transferTo(OutputStream) perhttps://bugs.openjdk.org/browse/JDK-8299336";>JDK-8299336, where as on 
JDK Closes https://redirect.github.com/palantir/gradle-baseline/issues/2615";>palantir/gradle-baseline#2615
   https://redirect.github.com/palantir/gradle-baseline/pull/2615";>palantir/gradle-baseline#2615,
 https://redirect.github.com/palantir/gradle-baseline/pull/2616";>palantir/gradle-baseline#2616
   
   
   
   5.18.0
   Automated release, no documented user facing changes
   5.17.0
   
   
   
   Type
   Description
   Link
   
   
   
   
   Feature
   Add error-prone check to prefer ZoneId constants
   https://redirect.github.com/palantir/gradle-baseline/pull/2596";>palantir/gradle-baseline#2596
   
   
   
   5.16.0
   
   
   
   Type
   Description
   Link
   
   
   
   
   Fix
   Fix nullaway checkerframework dependency
   https://redirect.github.com/palantir/gradle-baseline/pull/2602";>palantir/gradle-baseline#2602
   
   
   
   5.15.0
   Automated release, no documented user facing changes
   5.14.0
   
   
   ... (truncated)
   
   
   Commits
   
   https://github.com/palantir/gradle-baseline/commit/aac80ff946a5add7fe9b56d4b523a59cf1720246";>aac80ff
 Autorelease 5.25.0
   https://github.com/palantir/gradle-baseline/commit/bee51c45a6d8ab57a8691671fe596c8b045a6336";>bee51c4
 Revert "Lazy exact dependencies (https://redirect.github.com/palantir/gradle-baseline/issues/2639";>#2639)"
 (https://redirect.github.com/palantir/gradle-baseline/issues/2642";>#2642)
   https://github.com/palantir/gradle-baseline/commit/3d12d9eb588c1c20a0d172af00abf57353160981";>3d12d9e
 Excavator:  Upgrades Baseline to the latest version (https://redirect.github.com/palantir/gradle-baseline/issues/2640";>#2640)
   https://github.com/palantir/gradle-baseline/commit/2381f401fb0050eae77a10f27397ad5835cdd3ca";>2381f40
 Autorelease 5.24.0
   https://github.com/palantir/gradle-baseline/commit/f6e43095b61de662685810defa070661dad8ee08";>f6e4309
 Lazy exact dependencies (https://redirect.github.com/palantir/gradle-baseline/issues/2639";>#2639)
   https://github.com/palantir/gradle-baseline/commit/642e1e3d675ca49517113b70f73144144914ba0e";>642e1e3
 Autorelease 5.23.0
   https://github.com/palantir/gradle-baseline/commit/437d3920294ba82c8296acf844ddfa866df1662c";>437d392
 Use a Proxy for JavaInstallationMetadata so we can 
work across Gradle 7 a...
   https://github.com/palantir/gradle-baseline/commit/777e9f7e69a3b21daa5

Re: [PR] Build: Bump com.fasterxml.jackson.dataformat:jackson-dataformat-xml from 2.9.9 to 2.15.2 [iceberg]

2023-10-14 Thread via GitHub


dependabot[bot] closed pull request #8789: Build: Bump 
com.fasterxml.jackson.dataformat:jackson-dataformat-xml from 2.9.9 to 2.15.2
URL: https://github.com/apache/iceberg/pull/8789


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org



Re: [PR] Build: Bump com.palantir.baseline:gradle-baseline-java from 4.42.0 to 5.24.0 [iceberg]

2023-10-14 Thread via GitHub


dependabot[bot] commented on PR #8812:
URL: https://github.com/apache/iceberg/pull/8812#issuecomment-1763268107

   Superseded by #8840.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org



Re: [PR] Build: Bump com.palantir.baseline:gradle-baseline-java from 4.42.0 to 5.24.0 [iceberg]

2023-10-14 Thread via GitHub


dependabot[bot] closed pull request #8812: Build: Bump 
com.palantir.baseline:gradle-baseline-java from 4.42.0 to 5.24.0
URL: https://github.com/apache/iceberg/pull/8812


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


-
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org



[PR] Build: Bump com.google.cloud:libraries-bom from 26.24.0 to 26.25.0 [iceberg]

2023-10-14 Thread via GitHub


dependabot[bot] opened a new pull request, #8841:
URL: https://github.com/apache/iceberg/pull/8841

   Bumps 
[com.google.cloud:libraries-bom](https://github.com/googleapis/java-cloud-bom) 
from 26.24.0 to 26.25.0.
   
   Release notes
   Sourced from https://github.com/googleapis/java-cloud-bom/releases";>com.google.cloud:libraries-bom's
 releases.
   
   v26.25.0
   GCP Libraries BOM 26.25.0
   Here are the differences from the previous version (26.24.0)
   The group ID of the following artifacts is 
com.google.cloud.
   Notable Changes
   google-cloud-bigquerystorage 2.44.0 (prev: 2.43.0)
   
   Add in-stream retry logic for retryable and quota errors (https://redirect.github.com/googleapis/java-bigquerystorage/issues/2243";>#2243)
 (https://github.com/googleapis/java-bigquerystorage/commit/6435a0491827779b01dd0c3cf184f6578bf33f3e";>6435a04)
   
   google-cloud-bigtable 2.28.0 (prev: 2.27.4)
   
   Add support for Cloud Bigtable Request Priorities in App Profiles (https://redirect.github.com/googleapis/java-bigtable/issues/1954";>#1954)
 (https://github.com/googleapis/java-bigtable/commit/88225717b870032b8892123262d2529ba1dbd481";>8822571)
   Add test profile to push metrics to test environment (https://redirect.github.com/googleapis/java-bigtable/issues/1921";>#1921)
 (https://github.com/googleapis/java-bigtable/commit/210431523ce54029db846a0d6777d5e417e039dd";>2104315)
   
   google-cloud-firestore 3.15.1 (prev: 3.14.4)
   
   Sum and Average aggregations (https://redirect.github.com/googleapis/java-firestore/issues/1387";>#1387)
 (https://github.com/googleapis/java-firestore/commit/afa5c0124c98a0a58259e54c9bb054248b4d4104";>afa5c01)
   
   google-cloud-spanner 6.50.1 (prev: 6.49.0)
   
   
   Support setting core pool size for async API in system property (https://redirect.github.com/googleapis/java-spanner/issues/2632";>#2632)
 (https://github.com/googleapis/java-spanner/commit/e51c55d332bacb9d174a24b0d842b2cba4762db8";>e51c55d),
 closes https://redirect.github.com/googleapis/java-spanner/issues/2631";>#2631
   
   
   Noop in case there is no change in  autocommit value for setAutocommit() 
method (https://redirect.github.com/googleapis/java-spanner/issues/2662";>#2662)
 (https://github.com/googleapis/java-spanner/commit/9f51b6445f064439379af752372a3490a2fd5087";>9f51b64)
   
   
   google-cloud-spanner-jdbc 2.14.0 (prev: 2.13.4)
   
   Support default schema and catalog for PostgreSQL databases (https://redirect.github.com/googleapis/java-spanner-jdbc/issues/1375";>#1375)
 (https://github.com/googleapis/java-spanner-jdbc/commit/2737ecec00abd51b796e13375f2ebdfbf8e1b201";>2737ece)
   
   google-cloud-storage 2.28.0 (prev: 2.27.1)
   
   Add https://github.com/BetaApi";>@​BetaApi 
BlobWriteSession#parallelCompositeUpload (https://redirect.github.com/googleapis/java-storage/issues/2239";>#2239)
 (https://github.com/googleapis/java-storage/commit/f8f4e221ae81cf69387827014c9f98a466bb7f19";>f8f4e22)
   
   Other libraries
   
   [aiplatform] add DatasetVersion and dataset version RPCs to 
DatasetService (https://redirect.github.com/googleapis/google-cloud-java/issues/9922";>#9922)
 (https://github.com/googleapis/google-cloud-java/commit/1f45cd036e0650aff38595a4a4f6afcb0d23b958";>1f45cd0)
   [batch] add InstancePolicy.reservation field for restricting jobs to a 
specific reservation (https://redirect.github.com/googleapis/google-cloud-java/issues/9933";>#9933)
 (https://github.com/googleapis/google-cloud-java/commit/42f3ee5cc0fc747bc79e183077bd8e6807e3f9b6";>42f3ee5)
   [dataplex] DataQualityDimension is now part of the 
DataQualityDimensionResult message (https://redirect.github.com/googleapis/google-cloud-java/issues/9949";>#9949)
 (https://github.com/googleapis/google-cloud-java/commit/6557fc87ab26da76e59aa9297ef98824eba9fa2c";>6557fc8)
   [dialogflow] Add the enable_partial_automated_agent_reply flag (https://redirect.github.com/googleapis/google-cloud-java/issues/9924";>#9924)
 (https://github.com/googleapis/google-cloud-java/commit/cfcf828228ac5b8355a7e24b70994298e2666958";>cfcf828)
   [networkconnectivity] add Network Connectivity Center APIs related to 
VPC spokes (https://redirect.github.com/googleapis/google-cloud-java/issues/9927";>#9927)
 (https://github.com/googleapis/google-cloud-java/commit/2164568460df563f4a51d6696c39e1a8e58d68e2";>2164568)
   [recaptchaenterprise] FirewallPolicy CRUD API (https://redirect.github.com/googleapis/google-cloud-java/issues/9937";>#9937)
 (https://github.com/googleapis/google-cloud-java/commit/3e9bd057c7e7a613c8b5c25d69ee42a9d969d034";>3e9bd05)
   
   Version Upgrades
   Minor Version Upgrades
   
   google-cloud-apigee-registry:0.28.0 (prev:0.27.0; Release Notes: https://github.com/googleapis/google-cloud-java/releases/tag/v1.22.0";>v0.28.0)
   google-cloud-video-intelligence:2.27.0 (prev:2.26.0; Release Notes: https://github.com/googleapis/google-cloud-java/releases/tag/v1.22.0";>v2.27.0)
   google-cloud-assured-workloads:2.28.0 (prev:2.27.0; Release Notes: