bryanck commented on code in PR #8834:
URL: https://github.com/apache/iceberg/pull/8834#discussion_r1359633367


##########
core/src/main/java/org/apache/iceberg/BaseFile.java:
##########
@@ -476,7 +472,7 @@ long[] splitOffsetArray() {
 
   @Override
   public List<Integer> equalityFieldIds() {
-    return ArrayUtil.toIntList(equalityIds);
+    return equalityIds == null ? ImmutableList.of() : Ints.asList(equalityIds);

Review Comment:
   Using the same Guava wrapper here as well (also with a slight change in 
behavior with a list that can't be added to).



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to