[jira] [Commented] (GEODE-9431) CI Failure: SegFault in apache-geode_unittests
[ https://issues.apache.org/jira/browse/GEODE-9431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382243#comment-17382243 ] Blake Bender commented on GEODE-9431: - This failure appears to be due to some upgrade we took on RHEL-8 several weeks ago - most likely compiler/toolchain. It only fails on RHEL-8, and only on release-built bits. Failure is a crash in `std::regex` code, way down in the guts of the library code. Here's the callstack: ``` Program received signal SIGSEGV, Segmentation fault. 0x in ?? () Missing separate debuginfos, use: yum debuginfo-install libgcc-8.4.1-1.el8.x86_64 libstdc++-8.4.1-1.el8.x86_64 openssl-libs-1.1.1g-15.el8_3.x86_64 zlib-1.2.11-17.el8.x86_64 (gdb) bt #0 0x in ?? () #1 0x0064c8cc in std::ctype::narrow (__dfault=32 ' ', __c=115 's', this=0x770286a0) at /usr/include/c++/8/bits/locale_facets.h:935 #2 std::__detail::_Scanner::_M_scan_normal (this=0x7fffde58) at /usr/include/c++/8/bits/regex_scanner.tcc:101 #3 std::__detail::_Scanner::_M_advance (this=) at /usr/include/c++/8/bits/regex_scanner.tcc:80 #4 0x006583c0 in std::__detail::_Scanner::_Scanner (__loc=..., __flags=, __end=, __begin=, this=, this=, __begin=, __end=, __flags=, __loc=...) at /usr/include/c++/8/bits/regex_constants.h:185 #5 std::__detail::_Compiler >::_Compiler (this=, __b=, __e=, __loc=..., __flags=) at /usr/include/c++/8/bits/regex_compiler.tcc:80 #6 0x00522da0 in std::__detail::__compile_nfa, char const*> (__flags=, __loc=..., __last=, __first=) at /usr/include/c++/8/bits/regex_compiler.h:193 #7 std::__cxx11::basic_regex >::basic_regex (__f=, __loc=..., __last=, __first=, this=, this=, __first=, __last=, __loc=..., __f=) at /usr/include/c++/8/bits/regex.h:761 #8 std::__cxx11::basic_regex >::basic_regex (__f=, __last=, __first=, this=, this=, __first=, __last=, __f=) at /usr/include/c++/8/bits/regex.h:506 #9 std::__cxx11::basic_regex >::basic_regex, std::allocator > (__f=, __s=..., this=, this=, __s=..., __f=) at /usr/include/c++/8/bits/regex.h:487 #10 apache::geode::statistics::forEachIndexStatFile >(void) ( this=, function=...) at /home/bblake/geode-native/cppcache/src/statistics/HostStatSampler.cpp:375 #11 0x00602181 in apache::geode::statistics::HostStatSampler::initRollIndex (this=0x7fffe040) at /home/bblake/geode-native/cppcache/src/statistics/HostStatSampler.cpp:124 #12 TestableHostStatSampler::initRollIndex (this=0x7fffe040) at /home/bblake/geode-native/cppcache/test/statistics/HostStatSamplerTest.cpp:67 #13 HostStatSamplerTest_initRollIndexNoFiles_Test::TestBody (this=) at /home/bblake/geode-native/cppcache/test/statistics/HostStatSamplerTest.cpp:401 #14 0x008400ca in testing::internal::HandleSehExceptionsInMethodIfSupported (location=0x93abd8 "the test body", method=, object=0xcf1600) at /home/bblake/geode-native/build/dependencies/gtest/gtest-extern-prefix/src/gtest-extern/googletest/src/gtest.cc:2414 #15 testing::internal::HandleExceptionsInMethodIfSupported (object=object@entry=0xcf1600, method=, location=location@entry=0x93abd8 "the test body") at /home/bblake/geode-native/build/dependencies/gtest/gtest-extern-prefix/src/gtest-extern/googletest/src/gtest.cc:2469 #16 0x00837ad0 in testing::Test::Run (this=this@entry=0xcf1600) at /home/bblake/geode-native/build/dependencies/gtest/gtest-extern-prefix/src/gtest-extern/googletest/src/gtest.cc:2508 #17 0x00837d2a in testing::Test::Run (this=0xcf1600) at /home/bblake/geode-native/build/dependencies/gtest/gtest-extern-prefix/src/gtest-extern/googletest/src/gtest.cc:2684 #18 testing::TestInfo::Run (this=0xcc9650) at /home/bblake/geode-native/build/dependencies/gtest/gtest-extern-prefix/src/gtest-extern/googletest/src/gtest.cc:2684 #19 0x00837e9b in testing::TestInfo::Run (this=) at /home/bblake/geode-native/build/dependencies/gtest/gtest-extern-prefix/src/gtest-extern/googletest/src/gtest.cc:2658 #20 testing::TestSuite::Run (this=0xcc6830) at /home/bblake/geode-native/build/dependencies/gtest/gtest-extern-prefix/src/gtest-extern/googletest/src/gtest.cc:2816 #21 0x008384c3 in testing::TestSuite::Run (this=) at /home/bblake/geode-native/build/dependencies/gtest/gtest-extern-prefix/src/gtest-extern/googletest/src/gtest.cc:2796 #22 testing::internal::UnitTestImpl::RunAllTests (this=0xcbff60) at /home/bblake/geode-native/build/dependencies/gtest/gtest-extern-prefix/src/gtest-extern/googletest/src/gtest.cc:5338 #23 0x0084058a in testing::internal::HandleSehExceptionsInMethodIfSupported ( location=0x93bff0 "auxiliary test code (environments or event listeners)", method=, object=0xcbff60) at /home/bblake/geode-native/build/dependencies/gtest/gtest-extern-prefix/src/gtest-extern/googletest/src/gtest.cc:2414 #24 testing::internal::HandleExceptionsInMethodIfSupported (object=0xcbff6
[jira] [Comment Edited] (GEODE-9431) CI Failure: SegFault in apache-geode_unittests
[
https://issues.apache.org/jira/browse/GEODE-9431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382243#comment-17382243
]
Blake Bender edited comment on GEODE-9431 at 7/16/21, 5:51 PM:
---
This failure appears to be due to some upgrade we took on RHEL-8 several weeks
ago - most likely compiler/toolchain. It only fails on RHEL-8, and only on
release-built bits. Failure is a crash in `std::regex` code, way down in the
guts of the library code. Here's the callstack:
{code:java}
Program received signal SIGSEGV, Segmentation fault.
0x in ?? ()
Missing separate debuginfos, use: yum debuginfo-install
libgcc-8.4.1-1.el8.x86_64 libstdc++-8.4.1-1.el8.x86_64
openssl-libs-1.1.1g-15.el8_3.x86_64 zlib-1.2.11-17.el8.x86_64
(gdb) bt
#0 0x in ?? ()
#1 0x0064c8cc in std::ctype::narrow (__dfault=32 ' ', __c=115
's', this=0x770286a0) at /usr/include/c++/8/bits/locale_facets.h:935
#2 std::__detail::_Scanner::_M_scan_normal (this=0x7fffde58) at
/usr/include/c++/8/bits/regex_scanner.tcc:101
#3 std::__detail::_Scanner::_M_advance (this=) at
/usr/include/c++/8/bits/regex_scanner.tcc:80
#4 0x006583c0 in std::_detail::_Scanner::_Scanner (_loc=...,
__flags=, __end=, __begin=,
this=,
this=, __begin=, __end=,
__flags=, __loc=...) at
/usr/include/c++/8/bits/regex_constants.h:185
#5 std::_detail::_Compiler >::_Compiler
(this=, __b=, __e=, __loc=...,
__flags=)
at /usr/include/c++/8/bits/regex_compiler.tcc:80
#6 0x00522da0 in
std::_detail::compile_nfa, char const*>
(_flags=, __loc=..., __last=, __first=)
at /usr/include/c++/8/bits/regex_compiler.h:193
#7 std::_cxx11::basic_regex
>::basic_regex (_f=, __loc=..., __last=, __first=,
this=, this=, __first=,
__last=, __loc=..., __f=) at
/usr/include/c++/8/bits/regex.h:761
#8 std::_cxx11::basic_regex
>::basic_regex (_f=, __last=,
__first=,
this=, this=, __first=,
__last=, __f=) at
/usr/include/c++/8/bits/regex.h:506
#9 std::_cxx11::basic_regex
>::basic_regex, std::allocator > (_f=, __s=..., this=,
this=, __s=..., __f=) at
/usr/include/c++/8/bits/regex.h:487
#10
apache::geode::statistics::forEachIndexStatFile >(void) (
this=, function=...) at
/home/bblake/geode-native/cppcache/src/statistics/HostStatSampler.cpp:375
#11 0x00602181 in
apache::geode::statistics::HostStatSampler::initRollIndex (this=0x7fffe040)
at /home/bblake/geode-native/cppcache/src/statistics/HostStatSampler.cpp:124
#12 TestableHostStatSampler::initRollIndex (this=0x7fffe040) at
/home/bblake/geode-native/cppcache/test/statistics/HostStatSamplerTest.cpp:67
#13 HostStatSamplerTest_initRollIndexNoFiles_Test::TestBody (this=) at
/home/bblake/geode-native/cppcache/test/statistics/HostStatSamplerTest.cpp:401
#14 0x008400ca in
testing::internal::HandleSehExceptionsInMethodIfSupported
(location=0x93abd8 "the test body", method=, object=0xcf1600)
at
/home/bblake/geode-native/build/dependencies/gtest/gtest-extern-prefix/src/gtest-extern/googletest/src/gtest.cc:2414
#15 testing::internal::HandleExceptionsInMethodIfSupported (object=object@entry=0xcf1600, method=,
location=location@entry=0x93abd8 "the test body")
at
/home/bblake/geode-native/build/dependencies/gtest/gtest-extern-prefix/src/gtest-extern/googletest/src/gtest.cc:2469
#16 0x00837ad0 in testing::Test::Run (this=this@entry=0xcf1600)
at
/home/bblake/geode-native/build/dependencies/gtest/gtest-extern-prefix/src/gtest-extern/googletest/src/gtest.cc:2508
#17 0x00837d2a in testing::Test::Run (this=0xcf1600) at
/home/bblake/geode-native/build/dependencies/gtest/gtest-extern-prefix/src/gtest-extern/googletest/src/gtest.cc:2684
#18 testing::TestInfo::Run (this=0xcc9650) at
/home/bblake/geode-native/build/dependencies/gtest/gtest-extern-prefix/src/gtest-extern/googletest/src/gtest.cc:2684
#19 0x00837e9b in testing::TestInfo::Run (this=)
at
/home/bblake/geode-native/build/dependencies/gtest/gtest-extern-prefix/src/gtest-extern/googletest/src/gtest.cc:2658
#20 testing::TestSuite::Run (this=0xcc6830) at
/home/bblake/geode-native/build/dependencies/gtest/gtest-extern-prefix/src/gtest-extern/googletest/src/gtest.cc:2816
#21 0x008384c3 in testing::TestSuite::Run (this=)
at
/home/bblake/geode-native/build/dependencies/gtest/gtest-extern-prefix/src/gtest-extern/googletest/src/gtest.cc:2796
#22 testing::internal::UnitTestImpl::RunAllTests (this=0xcbff60) at
/home/bblake/geode-native/build/dependencies/gtest/gtest-extern-prefix/src/gtest-extern/googletest/src/gtest.cc:5338
#23 0x0084058a in
testing::internal::HandleSehExceptionsInMethodIfSupported (
location=0x93bff0 "auxiliary test code (environments or event listeners)",
method=, object=0xcbff60)
at
/home/bblake/geode-native/build/dependencies/gtest/gtest-extern-prefix/src/gtest-extern/googletest/src/gtest.cc:2414
#24
[jira] [Comment Edited] (GEODE-9431) CI Failure: SegFault in apache-geode_unittests
[
https://issues.apache.org/jira/browse/GEODE-9431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382243#comment-17382243
]
Blake Bender edited comment on GEODE-9431 at 7/16/21, 5:53 PM:
---
This failure appears to be due to some upgrade we took on RHEL-8 several weeks
ago - most likely compiler/toolchain. It only fails on RHEL-8, and only on
release-built bits. Failure is a crash in `std::regex`, way down in the guts
of the library code. Here's the callstack:
{code:java}
Program received signal SIGSEGV, Segmentation fault.
0x in ?? ()
Missing separate debuginfos, use: yum debuginfo-install
libgcc-8.4.1-1.el8.x86_64 libstdc++-8.4.1-1.el8.x86_64
openssl-libs-1.1.1g-15.el8_3.x86_64 zlib-1.2.11-17.el8.x86_64
(gdb) bt
#0 0x in ?? ()
#1 0x0064c8cc in std::ctype::narrow (__dfault=32 ' ', __c=115
's', this=0x770286a0) at /usr/include/c++/8/bits/locale_facets.h:935
#2 std::__detail::_Scanner::_M_scan_normal (this=0x7fffde58) at
/usr/include/c++/8/bits/regex_scanner.tcc:101
#3 std::__detail::_Scanner::_M_advance (this=) at
/usr/include/c++/8/bits/regex_scanner.tcc:80
#4 0x006583c0 in std::_detail::_Scanner::_Scanner (_loc=...,
__flags=, __end=, __begin=,
this=,
this=, __begin=, __end=,
__flags=, __loc=...) at
/usr/include/c++/8/bits/regex_constants.h:185
#5 std::_detail::_Compiler >::_Compiler
(this=, __b=, __e=, __loc=...,
__flags=)
at /usr/include/c++/8/bits/regex_compiler.tcc:80
#6 0x00522da0 in
std::_detail::compile_nfa, char const*>
(_flags=, __loc=..., __last=, __first=)
at /usr/include/c++/8/bits/regex_compiler.h:193
#7 std::_cxx11::basic_regex
>::basic_regex (_f=, __loc=..., __last=, __first=,
this=, this=, __first=,
__last=, __loc=..., __f=) at
/usr/include/c++/8/bits/regex.h:761
#8 std::_cxx11::basic_regex
>::basic_regex (_f=, __last=,
__first=,
this=, this=, __first=,
__last=, __f=) at
/usr/include/c++/8/bits/regex.h:506
#9 std::_cxx11::basic_regex
>::basic_regex, std::allocator > (_f=, __s=..., this=,
this=, __s=..., __f=) at
/usr/include/c++/8/bits/regex.h:487
#10
apache::geode::statistics::forEachIndexStatFile >(void) (
this=, function=...) at
/home/bblake/geode-native/cppcache/src/statistics/HostStatSampler.cpp:375
#11 0x00602181 in
apache::geode::statistics::HostStatSampler::initRollIndex (this=0x7fffe040)
at /home/bblake/geode-native/cppcache/src/statistics/HostStatSampler.cpp:124
#12 TestableHostStatSampler::initRollIndex (this=0x7fffe040) at
/home/bblake/geode-native/cppcache/test/statistics/HostStatSamplerTest.cpp:67
#13 HostStatSamplerTest_initRollIndexNoFiles_Test::TestBody (this=) at
/home/bblake/geode-native/cppcache/test/statistics/HostStatSamplerTest.cpp:401
#14 0x008400ca in
testing::internal::HandleSehExceptionsInMethodIfSupported
(location=0x93abd8 "the test body", method=, object=0xcf1600)
at
/home/bblake/geode-native/build/dependencies/gtest/gtest-extern-prefix/src/gtest-extern/googletest/src/gtest.cc:2414
#15 testing::internal::HandleExceptionsInMethodIfSupported (object=object@entry=0xcf1600, method=,
location=location@entry=0x93abd8 "the test body")
at
/home/bblake/geode-native/build/dependencies/gtest/gtest-extern-prefix/src/gtest-extern/googletest/src/gtest.cc:2469
#16 0x00837ad0 in testing::Test::Run (this=this@entry=0xcf1600)
at
/home/bblake/geode-native/build/dependencies/gtest/gtest-extern-prefix/src/gtest-extern/googletest/src/gtest.cc:2508
#17 0x00837d2a in testing::Test::Run (this=0xcf1600) at
/home/bblake/geode-native/build/dependencies/gtest/gtest-extern-prefix/src/gtest-extern/googletest/src/gtest.cc:2684
#18 testing::TestInfo::Run (this=0xcc9650) at
/home/bblake/geode-native/build/dependencies/gtest/gtest-extern-prefix/src/gtest-extern/googletest/src/gtest.cc:2684
#19 0x00837e9b in testing::TestInfo::Run (this=)
at
/home/bblake/geode-native/build/dependencies/gtest/gtest-extern-prefix/src/gtest-extern/googletest/src/gtest.cc:2658
#20 testing::TestSuite::Run (this=0xcc6830) at
/home/bblake/geode-native/build/dependencies/gtest/gtest-extern-prefix/src/gtest-extern/googletest/src/gtest.cc:2816
#21 0x008384c3 in testing::TestSuite::Run (this=)
at
/home/bblake/geode-native/build/dependencies/gtest/gtest-extern-prefix/src/gtest-extern/googletest/src/gtest.cc:2796
#22 testing::internal::UnitTestImpl::RunAllTests (this=0xcbff60) at
/home/bblake/geode-native/build/dependencies/gtest/gtest-extern-prefix/src/gtest-extern/googletest/src/gtest.cc:5338
#23 0x0084058a in
testing::internal::HandleSehExceptionsInMethodIfSupported (
location=0x93bff0 "auxiliary test code (environments or event listeners)",
method=, object=0xcbff60)
at
/home/bblake/geode-native/build/dependencies/gtest/gtest-extern-prefix/src/gtest-extern/googletest/src/gtest.cc:2414
#24
tes
[jira] [Commented] (GEODE-9431) CI Failure: SegFault in apache-geode_unittests
[
https://issues.apache.org/jira/browse/GEODE-9431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382252#comment-17382252
]
Blake Bender commented on GEODE-9431:
-
Things we have tried, in an attempt to work around or fix this:
i. Moved the `regex` variable declaration out of
`HostStatSampler::forEachIndexStatFile` to see if it made any difference
ii. Simplified the `regex` to make sure it wasn't the string expression passed
in that was blowing up
iii. Made `HostStatSampler::forEachIndexStatFile` a regular method taking an
`std::function` parameter, rather than a template
iv. Turned off all compiler optimization (`-O0`), for the individual function,
then file, then entire code base
v. Added the same `regex` variable to the test code, to see if it only blows up
in library code, as opposed to app code. Spoiler alert: no
We are now in the process of investigation the following potential fixes:
vi. Figure out what compiler/tool/library(ies) were updated when we last built
our RHEL-8 image, and see if we can roll back
vii. Switch from `std::regex` to `boost::regex` to see if boost has the same
problem
> CI Failure: SegFault in apache-geode_unittests
> --
>
> Key: GEODE-9431
> URL: https://issues.apache.org/jira/browse/GEODE-9431
> Project: Geode
> Issue Type: Bug
> Components: native client
>Reporter: Kamilla Aslami
>Priority: Major
>
> {{Two consequent geode-native-develop/build-rhel-8-release runs failed with
> segmentation fault: }}
> {noformat}
> selected worker: 3eb01fee-0959-4e2d-8c25-44a153962eaa
> Warning: Permanently added '34.67.7.72' (ECDSA) to the list of known hosts.
> Test project /home/build/build/cppcache/test
> Start 1: apache-geode_unittests
> 1/1 Test #1: apache-geode_unittests ...***Exception: SegFault 0.43
> sec
> Running main() from
> /home/build/build/dependencies/gtest/gtest-extern-prefix/src/gtest-extern/googletest/src/gtest_main.cc
> [==] Running 374 tests from 42 test suites.
> [--] Global test environment set-up.
> [--] 6 tests from durationTest
> [ RUN ] durationTest.ceil
> [ OK ] durationTest.ceil (0 ms)
> [ RUN ] durationTest.toString
> [ OK ] durationTest.toString (0 ms)
> [ RUN ] durationTest.fromString
> [ OK ] durationTest.fromString (0 ms)
> [ RUN ] durationTest.fromStringWithCeil
> [ OK ] durationTest.fromStringWithCeil (0 ms)
> [ RUN ] durationTest.fromStringException
> [ OK ] durationTest.fromStringException (0 ms)
> [ RUN ] durationTest.assertBounds
> [ OK ] durationTest.assertBounds (1 ms)
> [--] 6 tests from durationTest (1 ms total){noformat}
> ...
> {noformat}
> 0% tests passed, 1 tests failed out of 1
> Total Test time (real) = 0.91 sec
> The following tests FAILED:
> 1 - apache-geode_unittests (SEGFAULT)
> Errors while running CTest{noformat}
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (GEODE-9431) CI Failure: SegFault in apache-geode_unittests
[
https://issues.apache.org/jira/browse/GEODE-9431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382252#comment-17382252
]
Blake Bender edited comment on GEODE-9431 at 7/16/21, 6:13 PM:
---
Things we have tried, in an attempt to work around or fix this:
i. Moved the {{regex}} variable declaration out of
`HostStatSampler::forEachIndexStatFile` to see if it made any difference
ii. Simplified the `regex` to make sure it wasn't the string expression passed
in that was blowing up
iii. Made `HostStatSampler::forEachIndexStatFile` a regular method taking an
`std::function` parameter, rather than a template
iv. Turned off all compiler optimization (`-O0`), for the individual function,
then file, then entire code base
v. Added the same `regex` variable to the test code, to see if it only blows up
in library code, as opposed to app code. Spoiler alert: no
We are now in the process of investigation the following potential fixes:
vi. Figure out what compiler/tool/library(ies) were updated when we last built
our RHEL-8 image, and see if we can roll back
vii. Switch from `std::regex` to `boost::regex` to see if boost has the same
problem
was (Author: bbender):
Things we have tried, in an attempt to work around or fix this:
i. Moved the `regex` variable declaration out of
`HostStatSampler::forEachIndexStatFile` to see if it made any difference
ii. Simplified the `regex` to make sure it wasn't the string expression passed
in that was blowing up
iii. Made `HostStatSampler::forEachIndexStatFile` a regular method taking an
`std::function` parameter, rather than a template
iv. Turned off all compiler optimization (`-O0`), for the individual function,
then file, then entire code base
v. Added the same `regex` variable to the test code, to see if it only blows up
in library code, as opposed to app code. Spoiler alert: no
We are now in the process of investigation the following potential fixes:
vi. Figure out what compiler/tool/library(ies) were updated when we last built
our RHEL-8 image, and see if we can roll back
vii. Switch from `std::regex` to `boost::regex` to see if boost has the same
problem
> CI Failure: SegFault in apache-geode_unittests
> --
>
> Key: GEODE-9431
> URL: https://issues.apache.org/jira/browse/GEODE-9431
> Project: Geode
> Issue Type: Bug
> Components: native client
>Reporter: Kamilla Aslami
>Priority: Major
>
> {{Two consequent geode-native-develop/build-rhel-8-release runs failed with
> segmentation fault: }}
> {noformat}
> selected worker: 3eb01fee-0959-4e2d-8c25-44a153962eaa
> Warning: Permanently added '34.67.7.72' (ECDSA) to the list of known hosts.
> Test project /home/build/build/cppcache/test
> Start 1: apache-geode_unittests
> 1/1 Test #1: apache-geode_unittests ...***Exception: SegFault 0.43
> sec
> Running main() from
> /home/build/build/dependencies/gtest/gtest-extern-prefix/src/gtest-extern/googletest/src/gtest_main.cc
> [==] Running 374 tests from 42 test suites.
> [--] Global test environment set-up.
> [--] 6 tests from durationTest
> [ RUN ] durationTest.ceil
> [ OK ] durationTest.ceil (0 ms)
> [ RUN ] durationTest.toString
> [ OK ] durationTest.toString (0 ms)
> [ RUN ] durationTest.fromString
> [ OK ] durationTest.fromString (0 ms)
> [ RUN ] durationTest.fromStringWithCeil
> [ OK ] durationTest.fromStringWithCeil (0 ms)
> [ RUN ] durationTest.fromStringException
> [ OK ] durationTest.fromStringException (0 ms)
> [ RUN ] durationTest.assertBounds
> [ OK ] durationTest.assertBounds (1 ms)
> [--] 6 tests from durationTest (1 ms total){noformat}
> ...
> {noformat}
> 0% tests passed, 1 tests failed out of 1
> Total Test time (real) = 0.91 sec
> The following tests FAILED:
> 1 - apache-geode_unittests (SEGFAULT)
> Errors while running CTest{noformat}
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (GEODE-9431) CI Failure: SegFault in apache-geode_unittests
[
https://issues.apache.org/jira/browse/GEODE-9431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382252#comment-17382252
]
Blake Bender edited comment on GEODE-9431 at 7/16/21, 6:17 PM:
---
Things we have tried, in an attempt to work around or fix this:
i. Moved the `regex` variable declaration out of
`HostStatSampler::forEachIndexStatFile` to see if it made any difference
ii. Simplified the `regex` to make sure it wasn't the string expression passed
in that was blowing up
iii. Made `HostStatSampler::forEachIndexStatFile` a regular method taking an
`std::function` parameter, rather than a template
iv. Turned off all compiler optimization (`-O0`), for the individual function,
then file, then entire code base
v. Added the same `regex` variable to the test code, to see if it only blows up
in library code, as opposed to app code. Spoiler alert: no
We are now in the process of investigation the following potential fixes:
vi. Figure out what compiler/tool/library(ies) were updated when we last built
our RHEL-8 image, and see if we can roll back
vii. Switch from `std::regex` to `boost::regex` to see if boost has the same
problem
was (Author: bbender):
Things we have tried, in an attempt to work around or fix this:
i. Moved the {code}regex{code} variable declaration out of
`HostStatSampler::forEachIndexStatFile` to see if it made any difference
ii. Simplified the `regex` to make sure it wasn't the string expression passed
in that was blowing up
iii. Made `HostStatSampler::forEachIndexStatFile` a regular method taking an
`std::function` parameter, rather than a template
iv. Turned off all compiler optimization (`-O0`), for the individual function,
then file, then entire code base
v. Added the same `regex` variable to the test code, to see if it only blows up
in library code, as opposed to app code. Spoiler alert: no
We are now in the process of investigation the following potential fixes:
vi. Figure out what compiler/tool/library(ies) were updated when we last built
our RHEL-8 image, and see if we can roll back
vii. Switch from `std::regex` to `boost::regex` to see if boost has the same
problem
> CI Failure: SegFault in apache-geode_unittests
> --
>
> Key: GEODE-9431
> URL: https://issues.apache.org/jira/browse/GEODE-9431
> Project: Geode
> Issue Type: Bug
> Components: native client
>Reporter: Kamilla Aslami
>Priority: Major
>
> {{Two consequent geode-native-develop/build-rhel-8-release runs failed with
> segmentation fault: }}
> {noformat}
> selected worker: 3eb01fee-0959-4e2d-8c25-44a153962eaa
> Warning: Permanently added '34.67.7.72' (ECDSA) to the list of known hosts.
> Test project /home/build/build/cppcache/test
> Start 1: apache-geode_unittests
> 1/1 Test #1: apache-geode_unittests ...***Exception: SegFault 0.43
> sec
> Running main() from
> /home/build/build/dependencies/gtest/gtest-extern-prefix/src/gtest-extern/googletest/src/gtest_main.cc
> [==] Running 374 tests from 42 test suites.
> [--] Global test environment set-up.
> [--] 6 tests from durationTest
> [ RUN ] durationTest.ceil
> [ OK ] durationTest.ceil (0 ms)
> [ RUN ] durationTest.toString
> [ OK ] durationTest.toString (0 ms)
> [ RUN ] durationTest.fromString
> [ OK ] durationTest.fromString (0 ms)
> [ RUN ] durationTest.fromStringWithCeil
> [ OK ] durationTest.fromStringWithCeil (0 ms)
> [ RUN ] durationTest.fromStringException
> [ OK ] durationTest.fromStringException (0 ms)
> [ RUN ] durationTest.assertBounds
> [ OK ] durationTest.assertBounds (1 ms)
> [--] 6 tests from durationTest (1 ms total){noformat}
> ...
> {noformat}
> 0% tests passed, 1 tests failed out of 1
> Total Test time (real) = 0.91 sec
> The following tests FAILED:
> 1 - apache-geode_unittests (SEGFAULT)
> Errors while running CTest{noformat}
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (GEODE-9431) CI Failure: SegFault in apache-geode_unittests
[
https://issues.apache.org/jira/browse/GEODE-9431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382252#comment-17382252
]
Blake Bender edited comment on GEODE-9431 at 7/16/21, 6:17 PM:
---
Things we have tried, in an attempt to work around or fix this:
i. Moved the {code}regex{code} variable declaration out of
`HostStatSampler::forEachIndexStatFile` to see if it made any difference
ii. Simplified the `regex` to make sure it wasn't the string expression passed
in that was blowing up
iii. Made `HostStatSampler::forEachIndexStatFile` a regular method taking an
`std::function` parameter, rather than a template
iv. Turned off all compiler optimization (`-O0`), for the individual function,
then file, then entire code base
v. Added the same `regex` variable to the test code, to see if it only blows up
in library code, as opposed to app code. Spoiler alert: no
We are now in the process of investigation the following potential fixes:
vi. Figure out what compiler/tool/library(ies) were updated when we last built
our RHEL-8 image, and see if we can roll back
vii. Switch from `std::regex` to `boost::regex` to see if boost has the same
problem
was (Author: bbender):
Things we have tried, in an attempt to work around or fix this:
i. Moved the {{regex}} variable declaration out of
`HostStatSampler::forEachIndexStatFile` to see if it made any difference
ii. Simplified the `regex` to make sure it wasn't the string expression passed
in that was blowing up
iii. Made `HostStatSampler::forEachIndexStatFile` a regular method taking an
`std::function` parameter, rather than a template
iv. Turned off all compiler optimization (`-O0`), for the individual function,
then file, then entire code base
v. Added the same `regex` variable to the test code, to see if it only blows up
in library code, as opposed to app code. Spoiler alert: no
We are now in the process of investigation the following potential fixes:
vi. Figure out what compiler/tool/library(ies) were updated when we last built
our RHEL-8 image, and see if we can roll back
vii. Switch from `std::regex` to `boost::regex` to see if boost has the same
problem
> CI Failure: SegFault in apache-geode_unittests
> --
>
> Key: GEODE-9431
> URL: https://issues.apache.org/jira/browse/GEODE-9431
> Project: Geode
> Issue Type: Bug
> Components: native client
>Reporter: Kamilla Aslami
>Priority: Major
>
> {{Two consequent geode-native-develop/build-rhel-8-release runs failed with
> segmentation fault: }}
> {noformat}
> selected worker: 3eb01fee-0959-4e2d-8c25-44a153962eaa
> Warning: Permanently added '34.67.7.72' (ECDSA) to the list of known hosts.
> Test project /home/build/build/cppcache/test
> Start 1: apache-geode_unittests
> 1/1 Test #1: apache-geode_unittests ...***Exception: SegFault 0.43
> sec
> Running main() from
> /home/build/build/dependencies/gtest/gtest-extern-prefix/src/gtest-extern/googletest/src/gtest_main.cc
> [==] Running 374 tests from 42 test suites.
> [--] Global test environment set-up.
> [--] 6 tests from durationTest
> [ RUN ] durationTest.ceil
> [ OK ] durationTest.ceil (0 ms)
> [ RUN ] durationTest.toString
> [ OK ] durationTest.toString (0 ms)
> [ RUN ] durationTest.fromString
> [ OK ] durationTest.fromString (0 ms)
> [ RUN ] durationTest.fromStringWithCeil
> [ OK ] durationTest.fromStringWithCeil (0 ms)
> [ RUN ] durationTest.fromStringException
> [ OK ] durationTest.fromStringException (0 ms)
> [ RUN ] durationTest.assertBounds
> [ OK ] durationTest.assertBounds (1 ms)
> [--] 6 tests from durationTest (1 ms total){noformat}
> ...
> {noformat}
> 0% tests passed, 1 tests failed out of 1
> Total Test time (real) = 0.91 sec
> The following tests FAILED:
> 1 - apache-geode_unittests (SEGFAULT)
> Errors while running CTest{noformat}
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Reopened] (GEODE-9139) SSLException in starting up a Locator
[
https://issues.apache.org/jira/browse/GEODE-9139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Owen Nichols reopened GEODE-9139:
-
Assignee: Ernest Burghardt (was: Bruce J Schuchardt)
reopened for backport
> SSLException in starting up a Locator
> -
>
> Key: GEODE-9139
> URL: https://issues.apache.org/jira/browse/GEODE-9139
> Project: Geode
> Issue Type: Bug
> Components: membership, messaging
>Reporter: Bruce J Schuchardt
>Assignee: Ernest Burghardt
>Priority: Major
> Labels: blocks-1.14.0, pull-request-available
> Fix For: 1.15.0
>
>
> If you start up a locator using its host name, without a domain name, as a
> bind address you may get an SSLException in the form
> {noformat}
> javax.net.ssl.SSLHandshakeException: java.security.cert.CertificateException:
> No subject alternative DNS name matching hostname.domainname found
> {noformat}
> The LocatorLauncher and InternalLocator throw away the bind address string
> and later do a reverse lookup to find the fully qualified hostname to use in
> endpoint identification matching.If the locator's own TLS certificate
> doesn't have the fully qualified name in it as a Subject Alternate Name the
> connection that the Locator makes to its own location service will fail.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (GEODE-9139) SSLException in starting up a Locator
[
https://issues.apache.org/jira/browse/GEODE-9139?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382265#comment-17382265
]
Owen Nichols edited comment on GEODE-9139 at 7/16/21, 6:58 PM:
---
reopened for backport (once GEODE‑9396 is ready for backport at the same time)
was (Author: onichols-pivotal):
reopened for backport
> SSLException in starting up a Locator
> -
>
> Key: GEODE-9139
> URL: https://issues.apache.org/jira/browse/GEODE-9139
> Project: Geode
> Issue Type: Bug
> Components: membership, messaging
>Reporter: Bruce J Schuchardt
>Assignee: Ernest Burghardt
>Priority: Major
> Labels: blocks-1.14.0, pull-request-available
> Fix For: 1.15.0
>
>
> If you start up a locator using its host name, without a domain name, as a
> bind address you may get an SSLException in the form
> {noformat}
> javax.net.ssl.SSLHandshakeException: java.security.cert.CertificateException:
> No subject alternative DNS name matching hostname.domainname found
> {noformat}
> The LocatorLauncher and InternalLocator throw away the bind address string
> and later do a reverse lookup to find the fully qualified hostname to use in
> endpoint identification matching.If the locator's own TLS certificate
> doesn't have the fully qualified name in it as a Subject Alternate Name the
> connection that the Locator makes to its own location service will fail.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (GEODE-9431) CI Failure: SegFault in apache-geode_unittests
[
https://issues.apache.org/jira/browse/GEODE-9431?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated GEODE-9431:
--
Labels: pull-request-available (was: )
> CI Failure: SegFault in apache-geode_unittests
> --
>
> Key: GEODE-9431
> URL: https://issues.apache.org/jira/browse/GEODE-9431
> Project: Geode
> Issue Type: Bug
> Components: native client
>Reporter: Kamilla Aslami
>Priority: Major
> Labels: pull-request-available
>
> {{Two consequent geode-native-develop/build-rhel-8-release runs failed with
> segmentation fault: }}
> {noformat}
> selected worker: 3eb01fee-0959-4e2d-8c25-44a153962eaa
> Warning: Permanently added '34.67.7.72' (ECDSA) to the list of known hosts.
> Test project /home/build/build/cppcache/test
> Start 1: apache-geode_unittests
> 1/1 Test #1: apache-geode_unittests ...***Exception: SegFault 0.43
> sec
> Running main() from
> /home/build/build/dependencies/gtest/gtest-extern-prefix/src/gtest-extern/googletest/src/gtest_main.cc
> [==] Running 374 tests from 42 test suites.
> [--] Global test environment set-up.
> [--] 6 tests from durationTest
> [ RUN ] durationTest.ceil
> [ OK ] durationTest.ceil (0 ms)
> [ RUN ] durationTest.toString
> [ OK ] durationTest.toString (0 ms)
> [ RUN ] durationTest.fromString
> [ OK ] durationTest.fromString (0 ms)
> [ RUN ] durationTest.fromStringWithCeil
> [ OK ] durationTest.fromStringWithCeil (0 ms)
> [ RUN ] durationTest.fromStringException
> [ OK ] durationTest.fromStringException (0 ms)
> [ RUN ] durationTest.assertBounds
> [ OK ] durationTest.assertBounds (1 ms)
> [--] 6 tests from durationTest (1 ms total){noformat}
> ...
> {noformat}
> 0% tests passed, 1 tests failed out of 1
> Total Test time (real) = 0.91 sec
> The following tests FAILED:
> 1 - apache-geode_unittests (SEGFAULT)
> Errors while running CTest{noformat}
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-9431) CI Failure: SegFault in apache-geode_unittests
[
https://issues.apache.org/jira/browse/GEODE-9431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382293#comment-17382293
]
ASF GitHub Bot commented on GEODE-9431:
---
mreddington opened a new pull request #831:
URL: https://github.com/apache/geode-native/pull/831
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> CI Failure: SegFault in apache-geode_unittests
> --
>
> Key: GEODE-9431
> URL: https://issues.apache.org/jira/browse/GEODE-9431
> Project: Geode
> Issue Type: Bug
> Components: native client
>Reporter: Kamilla Aslami
>Priority: Major
>
> {{Two consequent geode-native-develop/build-rhel-8-release runs failed with
> segmentation fault: }}
> {noformat}
> selected worker: 3eb01fee-0959-4e2d-8c25-44a153962eaa
> Warning: Permanently added '34.67.7.72' (ECDSA) to the list of known hosts.
> Test project /home/build/build/cppcache/test
> Start 1: apache-geode_unittests
> 1/1 Test #1: apache-geode_unittests ...***Exception: SegFault 0.43
> sec
> Running main() from
> /home/build/build/dependencies/gtest/gtest-extern-prefix/src/gtest-extern/googletest/src/gtest_main.cc
> [==] Running 374 tests from 42 test suites.
> [--] Global test environment set-up.
> [--] 6 tests from durationTest
> [ RUN ] durationTest.ceil
> [ OK ] durationTest.ceil (0 ms)
> [ RUN ] durationTest.toString
> [ OK ] durationTest.toString (0 ms)
> [ RUN ] durationTest.fromString
> [ OK ] durationTest.fromString (0 ms)
> [ RUN ] durationTest.fromStringWithCeil
> [ OK ] durationTest.fromStringWithCeil (0 ms)
> [ RUN ] durationTest.fromStringException
> [ OK ] durationTest.fromStringException (0 ms)
> [ RUN ] durationTest.assertBounds
> [ OK ] durationTest.assertBounds (1 ms)
> [--] 6 tests from durationTest (1 ms total){noformat}
> ...
> {noformat}
> 0% tests passed, 1 tests failed out of 1
> Total Test time (real) = 0.91 sec
> The following tests FAILED:
> 1 - apache-geode_unittests (SEGFAULT)
> Errors while running CTest{noformat}
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (GEODE-9426) Update docs for HTTP Session Management
[
https://issues.apache.org/jira/browse/GEODE-9426?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated GEODE-9426:
--
Labels: pull-request-available (was: )
> Update docs for HTTP Session Management
> ---
>
> Key: GEODE-9426
> URL: https://issues.apache.org/jira/browse/GEODE-9426
> Project: Geode
> Issue Type: Bug
> Components: docs
>Affects Versions: 1.13.3
>Reporter: Dave Barnes
>Assignee: Dave Barnes
>Priority: Major
> Labels: pull-request-available
>
> [From a community member] I suspect this affects many older versions ... but
> I wanted to document what I saw as I attempted to follow the docs:
> This page has incorrect jar:
> [https://geode.apache.org/docs/guide/113/tools_modules/http_session_mgmt/tomcat_installing_the_module.html]
>
> {{"geode-commons jar" should be "geode-common jar" ... no "s"}}
> Also missing geode tcp server jar (geode-tcp-server)
> And is missing this step (copied here from geode-examples):
> {nofomat}
> $ cp $CATALINA_HOME/bin/tomcat-juli.jar $CATALINA_HOME/lib/
> App would not start with this in context.xml ... it was not there already ...
> and when I added it, startup failed.
> Suggest working through both the geode-examples AND the official
> documentation to verify correctness. [Example treated separately - see
> GEODE-9430]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-9431) CI Failure: SegFault in apache-geode_unittests
[
https://issues.apache.org/jira/browse/GEODE-9431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382332#comment-17382332
]
ASF GitHub Bot commented on GEODE-9431:
---
pivotal-jbarrett commented on a change in pull request #831:
URL: https://github.com/apache/geode-native/pull/831#discussion_r671514280
##
File path: cppcache/include/geode/CacheableString.hpp
##
@@ -54,11 +54,11 @@ class APACHE_GEODE_EXPORT CacheableString
: m_str(std::move(value)), m_hashcode(0) {
bool ascii = isAscii(m_str);
-m_type = m_str.length() > (std::numeric_limits::max)()
- ? ascii ? DSCode::CacheableASCIIStringHuge
- : DSCode::CacheableStringHuge
- : ascii ? DSCode::CacheableASCIIString
- : DSCode::CacheableString;
+m_type =
+m_str.length() > (std::numeric_limits::max)()
+? ascii ? DSCode::CacheableASCIIStringHuge
+: DSCode::CacheableStringHuge
+: ascii ? DSCode::CacheableASCIIString : DSCode::CacheableString;
Review comment:
What is going on with formatting changes. There are several in this PR
that don't appear related to the change at hand and some that don't seem to
conform to the style guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> CI Failure: SegFault in apache-geode_unittests
> --
>
> Key: GEODE-9431
> URL: https://issues.apache.org/jira/browse/GEODE-9431
> Project: Geode
> Issue Type: Bug
> Components: native client
>Reporter: Kamilla Aslami
>Priority: Major
> Labels: pull-request-available
>
> {{Two consequent geode-native-develop/build-rhel-8-release runs failed with
> segmentation fault: }}
> {noformat}
> selected worker: 3eb01fee-0959-4e2d-8c25-44a153962eaa
> Warning: Permanently added '34.67.7.72' (ECDSA) to the list of known hosts.
> Test project /home/build/build/cppcache/test
> Start 1: apache-geode_unittests
> 1/1 Test #1: apache-geode_unittests ...***Exception: SegFault 0.43
> sec
> Running main() from
> /home/build/build/dependencies/gtest/gtest-extern-prefix/src/gtest-extern/googletest/src/gtest_main.cc
> [==] Running 374 tests from 42 test suites.
> [--] Global test environment set-up.
> [--] 6 tests from durationTest
> [ RUN ] durationTest.ceil
> [ OK ] durationTest.ceil (0 ms)
> [ RUN ] durationTest.toString
> [ OK ] durationTest.toString (0 ms)
> [ RUN ] durationTest.fromString
> [ OK ] durationTest.fromString (0 ms)
> [ RUN ] durationTest.fromStringWithCeil
> [ OK ] durationTest.fromStringWithCeil (0 ms)
> [ RUN ] durationTest.fromStringException
> [ OK ] durationTest.fromStringException (0 ms)
> [ RUN ] durationTest.assertBounds
> [ OK ] durationTest.assertBounds (1 ms)
> [--] 6 tests from durationTest (1 ms total){noformat}
> ...
> {noformat}
> 0% tests passed, 1 tests failed out of 1
> Total Test time (real) = 0.91 sec
> The following tests FAILED:
> 1 - apache-geode_unittests (SEGFAULT)
> Errors while running CTest{noformat}
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (GEODE-9396) Upgrades using SSL fail with mismatch of hostname in certificates
[ https://issues.apache.org/jira/browse/GEODE-9396?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Owen Nichols updated GEODE-9396: Labels: blocks-1.13.4 blocks-1.14.0 pull-request-available release-blocker (was: pull-request-available release-blocker) > Upgrades using SSL fail with mismatch of hostname in certificates > - > > Key: GEODE-9396 > URL: https://issues.apache.org/jira/browse/GEODE-9396 > Project: Geode > Issue Type: Bug > Components: membership >Affects Versions: 1.14.0, 1.15.0 >Reporter: Ernest Burghardt >Assignee: Bill Burcham >Priority: Major > Labels: blocks-1.13.4, blocks-1.14.0, pull-request-available, > release-blocker > > When upgrading from a previous version (prior to 1.14) the ssl handshake will > fail to complete in cases where the Certificate contains a symbolic name that > doesn't match the hostname used by the sslengine. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-9139) SSLException in starting up a Locator
[
https://issues.apache.org/jira/browse/GEODE-9139?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Owen Nichols updated GEODE-9139:
Labels: blocks-1.13.4 blocks-1.14.0 pull-request-available (was:
blocks-1.14.0 pull-request-available)
> SSLException in starting up a Locator
> -
>
> Key: GEODE-9139
> URL: https://issues.apache.org/jira/browse/GEODE-9139
> Project: Geode
> Issue Type: Bug
> Components: membership, messaging
>Reporter: Bruce J Schuchardt
>Assignee: Ernest Burghardt
>Priority: Major
> Labels: blocks-1.13.4, blocks-1.14.0, pull-request-available
> Fix For: 1.15.0
>
>
> If you start up a locator using its host name, without a domain name, as a
> bind address you may get an SSLException in the form
> {noformat}
> javax.net.ssl.SSLHandshakeException: java.security.cert.CertificateException:
> No subject alternative DNS name matching hostname.domainname found
> {noformat}
> The LocatorLauncher and InternalLocator throw away the bind address string
> and later do a reverse lookup to find the fully qualified hostname to use in
> endpoint identification matching.If the locator's own TLS certificate
> doesn't have the fully qualified name in it as a Subject Alternate Name the
> connection that the Locator makes to its own location service will fail.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Reopened] (GEODE-8609) Create a dunit suspect file per VM
[
https://issues.apache.org/jira/browse/GEODE-8609?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Owen Nichols reopened GEODE-8609:
-
reopened for backport
> Create a dunit suspect file per VM
> --
>
> Key: GEODE-8609
> URL: https://issues.apache.org/jira/browse/GEODE-8609
> Project: Geode
> Issue Type: Test
> Components: tests
>Reporter: Jens Deppe
>Assignee: Jens Deppe
>Priority: Major
> Labels: blocks-1.14.0, pull-request-available
> Fix For: 1.15.0
>
>
> In some situations, especially when restarting Dunit VMs, it appears that the
> suspect log file can be corrupted since suspect processing reports errors
> such as:
> {noformat}
> org.apache.geode.redis.internal.executor.CrashAndNoRepeatDUnitTest >
> classMethod FAILED
> java.lang.AssertionError: Suspicious strings were written to the log
> during this run.
> Fix the strings or use IgnoredException.addIgnoredException to ignore.
> ---
> Found suspect string in log4j at line 19594
> /home/geode/.gradle/caches/modules-2/files-2.1/antlr/antlr/2.7.7/83cd2cd674a21[warn
> 2020/10/11 15:23:24.988 GMT tid=105] Execution
> of Redis command APPEND append-key-1 -append-key-1-17484- failed:
> org.apache.geode.cache.execute.FunctionException:
> org.apache.geode.cache.execute.FunctionInvocationTargetException:
> memberDeparted event for < 172.17.0.20(server-3:2004):41003 > crashed,
> true{noformat}
> Where the suspected string is corrupted.
> The proposed fix will create a new dunit_suspect log for each VM. The logs
> will now be named {{dunit_suspect-vm.log}}. The {{locator}} vm and the
> test runner vm will have logs named {{dunit_suspect-locator.log}} and
> {{dunit_suspect-local.log}} respectively.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-9360) Initial revision of .net core support
[
https://issues.apache.org/jira/browse/GEODE-9360?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382358#comment-17382358
]
ASF GitHub Bot commented on GEODE-9360:
---
pivotal-jbarrett commented on a change in pull request #823:
URL: https://github.com/apache/geode-native/pull/823#discussion_r671527167
##
File path: netcore/NetCore.Test/CacheFactoryUnitTest.cs
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+using System;
+using Apache.Geode.Client;
+using Xunit;
+
+namespace GeodeDotNetTest {
+ [Collection("Geode .net Core Collection")]
+ public class CacheFactoryUnitTests {
Review comment:
The naming convention used by the Java and C++ sources is `ClassTest(s)`
where `Class` is the class under testing and `Test` or `Tests` (not consistent)
is used to denote unit tests. Unit tests are also isolated away from other
forms of longer feedback tests, like integration, also suffixing them
`UnitTest` was deemed redundant.
##
File path: .gitignore
##
@@ -18,3 +18,7 @@
/tools/gnmsg/.idea/
/tools/gnmsg/__pycache__/
+
+/netcore/*/bin/
Review comment:
Is there any way to get .NET build tools to not build in the source tree?
##
File path: netcore/.clang-format
##
@@ -0,0 +1,3 @@
+---
+Language:CSharp
+BasedOnStyle: Google
Review comment:
YES!
##
File path: netcore/NetCore.Test/CacheFactoryUnitTest.cs
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+using System;
+using Apache.Geode.Client;
+using Xunit;
+
+namespace GeodeDotNetTest {
+ [Collection("Geode .net Core Collection")]
+ public class CacheFactoryUnitTests {
+[Fact]
+public void TestCreateFactory() {
Review comment:
Since all these methods are tests, does it make sense to redundantly
prefix them all with `Test`? If read in plain English you have "Fact, test
create factory." This is is not a complete fact. More appropriately it should
be called `CacheFactoryCreateIsNotNull` read as "Fact, CacheFactory.Create is
not null", which is an asserted fact of this test.
##
File path: netcore/NetCore/IRegionService.cs
##
@@ -0,0 +1,31 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+using System;
+
+namespace Apache {
+ namespace Geode {
+namespace Client {
+ public interface IRegionService {
+//IPdxInstanceFactory CreatePdxInstanceFactory(String
className);
Review comment:
Delete commented out code.
##
File path: netcore/scripts/run-clang-format.cmd
##
@@ -0,0 +1,
[jira] [Updated] (GEODE-9338) Remove strong guarantees for redis PUBLISH command response
[
https://issues.apache.org/jira/browse/GEODE-9338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated GEODE-9338:
--
Labels: pull-request-available (was: )
> Remove strong guarantees for redis PUBLISH command response
> ---
>
> Key: GEODE-9338
> URL: https://issues.apache.org/jira/browse/GEODE-9338
> Project: Geode
> Issue Type: Improvement
> Components: redis
>Reporter: Jens Deppe
>Assignee: Hale Bales
>Priority: Major
> Labels: pull-request-available
>
> Redis' {{PUBLISH}} command responds with the number of clients that have
> received the published message. Our current implementation attempts to
> respond with as accurate a number as possible. To that end, each publish (see
> {{PubSubImpl.publishMessageToSubscribers}} and
> {{AbstractSubscription.publishMessage}} are effectively synchronous
> operations. The current flow is:
> - PUBLISH some_message
> - Issue a fn call to each server and attempt to publish to each subscribed
> client
> - Count how many successful publish messages were written and return those
> - Respond to the redis client with the aggregated successful publishings
> In redis clustering mode, the response is only the number of local
> publishings. We can go even further and not attempt to first publish before
> subscribing, but simply respond with the current number of subscribers,
> regardless whether they are connected or not.
> We should be able to perform all pubsub work on the regular netty thread and
> completely remove the subscriber EventLoopGroup.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
