[
https://issues.apache.org/jira/browse/GEODE-9431?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17382332#comment-17382332
]
ASF GitHub Bot commented on GEODE-9431:
---------------------------------------
pivotal-jbarrett commented on a change in pull request #831:
URL: https://github.com/apache/geode-native/pull/831#discussion_r671514280
##########
File path: cppcache/include/geode/CacheableString.hpp
##########
@@ -54,11 +54,11 @@ class APACHE_GEODE_EXPORT CacheableString
: m_str(std::move(value)), m_hashcode(0) {
bool ascii = isAscii(m_str);
- m_type = m_str.length() > (std::numeric_limits<uint16_t>::max)()
- ? ascii ? DSCode::CacheableASCIIStringHuge
- : DSCode::CacheableStringHuge
- : ascii ? DSCode::CacheableASCIIString
- : DSCode::CacheableString;
+ m_type =
+ m_str.length() > (std::numeric_limits<uint16_t>::max)()
+ ? ascii ? DSCode::CacheableASCIIStringHuge
+ : DSCode::CacheableStringHuge
+ : ascii ? DSCode::CacheableASCIIString : DSCode::CacheableString;
Review comment:
What is going on with formatting changes. There are several in this PR
that don't appear related to the change at hand and some that don't seem to
conform to the style guide.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> CI Failure: SegFault in apache-geode_unittests
> ----------------------------------------------
>
> Key: GEODE-9431
> URL: https://issues.apache.org/jira/browse/GEODE-9431
> Project: Geode
> Issue Type: Bug
> Components: native client
> Reporter: Kamilla Aslami
> Priority: Major
> Labels: pull-request-available
>
> {{Two consequent geode-native-develop/build-rhel-8-release runs failed with
> segmentation fault: }}
> {noformat}
> selected worker: 3eb01fee-0959-4e2d-8c25-44a153962eaa
> Warning: Permanently added '34.67.7.72' (ECDSA) to the list of known hosts.
> Test project /home/build/build/cppcache/test
> Start 1: apache-geode_unittests
> 1/1 Test #1: apache-geode_unittests ...........***Exception: SegFault 0.43
> sec
> Running main() from
> /home/build/build/dependencies/gtest/gtest-extern-prefix/src/gtest-extern/googletest/src/gtest_main.cc
> [==========] Running 374 tests from 42 test suites.
> [----------] Global test environment set-up.
> [----------] 6 tests from durationTest
> [ RUN ] durationTest.ceil
> [ OK ] durationTest.ceil (0 ms)
> [ RUN ] durationTest.toString
> [ OK ] durationTest.toString (0 ms)
> [ RUN ] durationTest.fromString
> [ OK ] durationTest.fromString (0 ms)
> [ RUN ] durationTest.fromStringWithCeil
> [ OK ] durationTest.fromStringWithCeil (0 ms)
> [ RUN ] durationTest.fromStringException
> [ OK ] durationTest.fromStringException (0 ms)
> [ RUN ] durationTest.assertBounds
> [ OK ] durationTest.assertBounds (1 ms)
> [----------] 6 tests from durationTest (1 ms total){noformat}
> ...
> {noformat}
> 0% tests passed, 1 tests failed out of 1
> Total Test time (real) = 0.91 sec
> The following tests FAILED:
> 1 - apache-geode_unittests (SEGFAULT)
> Errors while running CTest{noformat}
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
