[jira] [Commented] (GEODE-9322) Solve potential race condition in TransactionCleaningTest
[ https://issues.apache.org/jira/browse/GEODE-9322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17380792#comment-17380792 ] ASF GitHub Bot commented on GEODE-9322: --- gaussianrecurrence commented on pull request #810: URL: https://github.com/apache/geode-native/pull/810#issuecomment-880116969 > Looks good - though I don't fully understand the nature of the race condition you mention, I trust you've been over the details and fixed. Regarding this, basically it solves race condition in which the test proceeds before the server is actually stopped. Note that gfsh command "stop server" is not synchronous, so after its execution the server could be still up. > Quick question - this part of your description: "Modified RegisterKeysTest to use gmock_actions helper." I see no changes to RegisterKeysTest. Are they missing, or is your PR description just out of date? Thanks for noticing this. As it seems to me, I made this fix along with PR #809, so in order to make the changes work there was some duplicity on both PRs, as #809 was merged I guess the delta doesn't show the RegisterKeysTest anymore. I'll update the description. Just a comment: I would like to improve the readability for the code in general and ITs in particular. So do you think it is possible to add a comment on ITs with a short description of what it does, as well as what's the test for? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Solve potential race condition in TransactionCleaningTest > - > > Key: GEODE-9322 > URL: https://issues.apache.org/jira/browse/GEODE-9322 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: pull-request-available > > A possible race condition was detected in this new IT. > Given there is no check for servers start/stop, it might happen that the test > proceeds before the server is actually stopped/started. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9322) Solve potential race condition in TransactionCleaningTest
[ https://issues.apache.org/jira/browse/GEODE-9322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17380819#comment-17380819 ] ASF GitHub Bot commented on GEODE-9322: --- gaussianrecurrence edited a comment on pull request #810: URL: https://github.com/apache/geode-native/pull/810#issuecomment-880116969 > Looks good - though I don't fully understand the nature of the race condition you mention, I trust you've been over the details and fixed. Regarding this, basically it solves race condition in which the test proceeds before the server is actually stopped. Note that gfsh command "stop server" is not synchronous, so after its execution the server could be still up. And the equivalent happens with "start server" > Quick question - this part of your description: "Modified RegisterKeysTest to use gmock_actions helper." I see no changes to RegisterKeysTest. Are they missing, or is your PR description just out of date? Thanks for noticing this. As it seems to me, I made this fix along with PR #809, so in order to make the changes work there was some duplicity on both PRs, as #809 was merged I guess the delta doesn't show the RegisterKeysTest anymore. I'll update the description. Just a comment: I would like to improve the readability for the code in general and ITs in particular. So do you think it is possible to add a comment on ITs with a short description of what it does, as well as what's the test for? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Solve potential race condition in TransactionCleaningTest > - > > Key: GEODE-9322 > URL: https://issues.apache.org/jira/browse/GEODE-9322 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: pull-request-available > > A possible race condition was detected in this new IT. > Given there is no check for servers start/stop, it might happen that the test > proceeds before the server is actually stopped/started. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (GEODE-9304) Make RedisSortedSet's measurement of byes in use more accurate
[ https://issues.apache.org/jira/browse/GEODE-9304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Donal Evans reassigned GEODE-9304: -- Assignee: Donal Evans > Make RedisSortedSet's measurement of byes in use more accurate > -- > > Key: GEODE-9304 > URL: https://issues.apache.org/jira/browse/GEODE-9304 > Project: Geode > Issue Type: Bug > Components: redis >Affects Versions: 1.15.0 >Reporter: Ray Ingles >Assignee: Donal Evans >Priority: Major > > The current calculation of bytes in use by RedisSortedSet is inaccurate, and > needs to be improved. Once a strategy for size calculation for classes using > Object2ObjectCustomHash and OrderStatisticsTree has been decided, it should > be implemented for this data type. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-9304) Make RedisSortedSet's measurement of byes in use more accurate
[ https://issues.apache.org/jira/browse/GEODE-9304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-9304: -- Labels: pull-request-available (was: ) > Make RedisSortedSet's measurement of byes in use more accurate > -- > > Key: GEODE-9304 > URL: https://issues.apache.org/jira/browse/GEODE-9304 > Project: Geode > Issue Type: Bug > Components: redis >Affects Versions: 1.15.0 >Reporter: Ray Ingles >Assignee: Donal Evans >Priority: Major > Labels: pull-request-available > > The current calculation of bytes in use by RedisSortedSet is inaccurate, and > needs to be improved. Once a strategy for size calculation for classes using > Object2ObjectCustomHash and OrderStatisticsTree has been decided, it should > be implemented for this data type. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9392) A gfsh query returning a Struct containing a PdxInstance behaves differently than one returning just the PdxInstance in some cases
[
https://issues.apache.org/jira/browse/GEODE-9392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17380890#comment-17380890
]
Barrett Oglesby commented on GEODE-9392:
A {{select *}} query fails in the same way if a field of the value is a
PdxInstance and that PdxInstance contains an unsupported data type.
For example, if the region contains Product objects and a Product contains a
Relevance object which contains a java LocalDataTime.
LocalDateTime is not supported by PdxToJSON, so the query fails with a similar
stack to the above struct one:
{noformat}
[info 2021/07/14 15:53:00.349 PDT server1
tid=0x3f] Exception occurred:
org.apache.geode.pdx.JSONFormatterException: Could not create JSON document
from PdxInstance
at
org.apache.geode.pdx.JSONFormatter.fromPdxInstance(JSONFormatter.java:241)
at org.apache.geode.pdx.JSONFormatter.toJSON(JSONFormatter.java:226)
at
org.apache.geode.management.internal.cli.domain.DataCommandResult$SelectResultRow.valueToJson(DataCommandResult.java:731)
at
org.apache.geode.management.internal.cli.domain.DataCommandResult$SelectResultRow.resolvePdxToColumns(DataCommandResult.java:711)
at
org.apache.geode.management.internal.cli.domain.DataCommandResult$SelectResultRow.resolveObjectToColumns(DataCommandResult.java:688)
at
org.apache.geode.management.internal.cli.domain.DataCommandResult$SelectResultRow.createColumnValues(DataCommandResult.java:680)
at
org.apache.geode.management.internal.cli.domain.DataCommandResult$SelectResultRow.(DataCommandResult.java:663)
at
org.apache.geode.management.internal.cli.functions.DataCommandFunction.createSelectResultRow(DataCommandFunction.java:270)
at
org.apache.geode.management.internal.cli.functions.DataCommandFunction.select_SelectResults(DataCommandFunction.java:256)
at
org.apache.geode.management.internal.cli.functions.DataCommandFunction.select(DataCommandFunction.java:224)
at
org.apache.geode.management.internal.cli.functions.DataCommandFunction.select(DataCommandFunction.java:177)
at
org.apache.geode.management.internal.cli.functions.DataCommandFunction.execute(DataCommandFunction.java:126)
Caused by: java.lang.IllegalStateException: The pdx field valueChangeDate has a
value 2021-07-14T15:52:54.970 whose type class java.time.LocalDateTime can not
be converted to JSON.
at
org.apache.geode.pdx.internal.json.PdxToJSON.writeValue(PdxToJSON.java:148)
at
org.apache.geode.pdx.internal.json.PdxToJSON.getJSONString(PdxToJSON.java:178)
at
org.apache.geode.pdx.internal.json.PdxToJSON.getJSON(PdxToJSON.java:60)
{noformat}
> A gfsh query returning a Struct containing a PdxInstance behaves differently
> than one returning just the PdxInstance in some cases
> --
>
> Key: GEODE-9392
> URL: https://issues.apache.org/jira/browse/GEODE-9392
> Project: Geode
> Issue Type: Bug
> Components: gfsh
>Reporter: Barrett Oglesby
>Priority: Major
>
> This is true when the PdxInstance contains a data type that is not supported
> by PdxToJSON (like Date or Character).
> If objects like this are stored as PdxInstances:
> {noformat}
> public class Position {
> private String id;
> private Date tradeDate;
> private Character type;
> ...
> }
> {noformat}
> A query like this is successful:
> {noformat}
> Executing - query --query='select * from /positions'
> Result : true
> Limit : 100
> Rows : 10
> tradeDate | id | type
> - | -- |
> 1624316618413 | 3 | "a"
> 1624316618324 | 0 | "a"
> 1624316618418 | 5 | "a"
> 1624316618421 | 6 | "a"
> 1624316618407 | 1 | "a"
> 1624316618426 | 8 | "a"
> 1624316618428 | 9 | "a"
> 1624316618415 | 4 | "a"
> 1624316618423 | 7 | "a"
> 1624316618410 | 2 | "a"
> {noformat}
> But a query like this is not:
> {noformat}
> Executing - query --query="select key,value from /positions.entries where
> value.id = '0'"
> Result : false
> Message : Could not create JSON document from PdxInstance
> {noformat}
> It fails with this exception in the server:
> {noformat}
> org.apache.geode.pdx.JSONFormatterException: Could not create JSON document
> from PdxInstance
> at
> org.apache.geode.pdx.JSONFormatter.fromPdxInstance(JSONFormatter.java:241)
> at org.apache.geode.pdx.JSONFormatter.toJSON(JSONFormatter.java:226)
> at
> org.apache.geode.management.internal.cli.domain.DataCommandResult$SelectResultRow.valueToJson(DataCommandResult.java:732)
> at
> org.apache.geode.management.internal.cli.domain.DataCommandResult$SelectResultRow.resolveStructToColumns(DataCommandResult.java:717)
> at
> org.apache.geode.management.internal.cli.domain.DataCo
[jira] [Commented] (GEODE-8870) Remove obsolete version compatibility code
[ https://issues.apache.org/jira/browse/GEODE-8870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17380895#comment-17380895 ] ASF subversion and git services commented on GEODE-8870: Commit e3457ff764cd24383a5010d1d169bf4cfb19f5ea in geode's branch refs/heads/develop from Jacob Barrett [ https://gitbox.apache.org/repos/asf?p=geode.git;h=e3457ff ] GEODE-8870: Removes GFE_7099 > Remove obsolete version compatibility code > -- > > Key: GEODE-8870 > URL: https://issues.apache.org/jira/browse/GEODE-8870 > Project: Geode > Issue Type: Improvement >Reporter: Jacob Barrett >Assignee: Jacob Barrett >Priority: Major > Labels: pull-request-available > > As a followup to GEODE-8837 remove all obsolete backwards compatibility code. > This ticket will catch all changes to remove the obsolete code. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-9392) A gfsh query returning a Struct containing a PdxInstance behaves differently than one returning just the PdxInstance in some cases
[
https://issues.apache.org/jira/browse/GEODE-9392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17380896#comment-17380896
]
Barrett Oglesby commented on GEODE-9392:
Code using ObjectMapper like above didn't address the issue.
Since LocalDateTime not supported by default in ObjectMapper, it throws this
exception:
{noformat}
Caused by: java.lang.RuntimeException: Java 8 date/time type
`java.time.LocalDateTime` not supported by default: add Module
"com.fasterxml.jackson.datatype:jackson-datatype-jsr310" to enable handling
at
org.apache.geode.pdx.internal.json.PdxToJSON.getJSON(PdxToJSON.java:67)
at
org.apache.geode.pdx.JSONFormatter.fromPdxInstance(JSONFormatter.java:239)
{noformat}
I added jackson-datatype-jsr310-2.12.3.jar to the server's classpath and used
this code in the last else clause in PdxToJSON.writeValue:
{noformat}
ObjectMapper mapper = new ObjectMapper();
mapper.findAndRegisterModules();
jg.writeString(mapper.writeValueAsString(value));
{noformat}
And that worked:
{noformat}
Executing - query --query='select * from /data'
Result : true
Limit : 100
Rows : 1
productId | partnerProductId | onlineRelevance
-- | |
-
151895 | 151895 |
{"value":"value1","valueChangeDate":"[2021,7,14,16,18,29,78400]"}
{noformat}
> A gfsh query returning a Struct containing a PdxInstance behaves differently
> than one returning just the PdxInstance in some cases
> --
>
> Key: GEODE-9392
> URL: https://issues.apache.org/jira/browse/GEODE-9392
> Project: Geode
> Issue Type: Bug
> Components: gfsh
>Reporter: Barrett Oglesby
>Priority: Major
>
> This is true when the PdxInstance contains a data type that is not supported
> by PdxToJSON (like Date or Character).
> If objects like this are stored as PdxInstances:
> {noformat}
> public class Position {
> private String id;
> private Date tradeDate;
> private Character type;
> ...
> }
> {noformat}
> A query like this is successful:
> {noformat}
> Executing - query --query='select * from /positions'
> Result : true
> Limit : 100
> Rows : 10
> tradeDate | id | type
> - | -- |
> 1624316618413 | 3 | "a"
> 1624316618324 | 0 | "a"
> 1624316618418 | 5 | "a"
> 1624316618421 | 6 | "a"
> 1624316618407 | 1 | "a"
> 1624316618426 | 8 | "a"
> 1624316618428 | 9 | "a"
> 1624316618415 | 4 | "a"
> 1624316618423 | 7 | "a"
> 1624316618410 | 2 | "a"
> {noformat}
> But a query like this is not:
> {noformat}
> Executing - query --query="select key,value from /positions.entries where
> value.id = '0'"
> Result : false
> Message : Could not create JSON document from PdxInstance
> {noformat}
> It fails with this exception in the server:
> {noformat}
> org.apache.geode.pdx.JSONFormatterException: Could not create JSON document
> from PdxInstance
> at
> org.apache.geode.pdx.JSONFormatter.fromPdxInstance(JSONFormatter.java:241)
> at org.apache.geode.pdx.JSONFormatter.toJSON(JSONFormatter.java:226)
> at
> org.apache.geode.management.internal.cli.domain.DataCommandResult$SelectResultRow.valueToJson(DataCommandResult.java:732)
> at
> org.apache.geode.management.internal.cli.domain.DataCommandResult$SelectResultRow.resolveStructToColumns(DataCommandResult.java:717)
> at
> org.apache.geode.management.internal.cli.domain.DataCommandResult$SelectResultRow.resolveObjectToColumns(DataCommandResult.java:692)
> at
> org.apache.geode.management.internal.cli.domain.DataCommandResult$SelectResultRow.createColumnValues(DataCommandResult.java:680)
> at
> org.apache.geode.management.internal.cli.domain.DataCommandResult$SelectResultRow.(DataCommandResult.java:663)
> at
> org.apache.geode.management.internal.cli.functions.DataCommandFunction.createSelectResultRow(DataCommandFunction.java:270)
> at
> org.apache.geode.management.internal.cli.functions.DataCommandFunction.select_SelectResults(DataCommandFunction.java:256)
> at
> org.apache.geode.management.internal.cli.functions.DataCommandFunction.select(DataCommandFunction.java:224)
> at
> org.apache.geode.management.internal.cli.functions.DataCommandFunction.select(DataCommandFunction.java:177)
> at
> org.apache.geode.management.internal.cli.functions.DataCommandFunction.execute(DataCommandFunction.java:126)
> Caused by: java.lang.IllegalStateException: PdxInstance returns unknwon
> pdxfield tradeDate for type Mon Jun 21 16:03:38 PDT 2021
> at
> org.apache.geode.pdx.internal.json.PdxToJSON.writeValue(PdxToJSON.java:148)
> at
> org.apache.geode.pdx.internal.json.PdxToJSON.getJSONString(PdxTo
