[
https://issues.apache.org/jira/browse/GEODE-9322?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17380792#comment-17380792
]
ASF GitHub Bot commented on GEODE-9322:
---------------------------------------
gaussianrecurrence commented on pull request #810:
URL: https://github.com/apache/geode-native/pull/810#issuecomment-880116969
> Looks good - though I don't fully understand the nature of the race
condition you mention, I trust you've been over the details and fixed.
Regarding this, basically it solves race condition in which the test
proceeds before the server is actually stopped. Note that gfsh command "stop
server" is not synchronous, so after its execution the server could be still up.
> Quick question - this part of your description: "Modified RegisterKeysTest
to use gmock_actions helper." I see no changes to RegisterKeysTest. Are they
missing, or is your PR description just out of date?
Thanks for noticing this. As it seems to me, I made this fix along with PR
#809, so in order to make the changes work there was some duplicity on both
PRs, as #809 was merged I guess the delta doesn't show the RegisterKeysTest
anymore. I'll update the description.
Just a comment: I would like to improve the readability for the code in
general and ITs in particular. So do you think it is possible to add a comment
on ITs with a short description of what it does, as well as what's the test for?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@geode.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Solve potential race condition in TransactionCleaningTest
> ---------------------------------------------------------
>
> Key: GEODE-9322
> URL: https://issues.apache.org/jira/browse/GEODE-9322
> Project: Geode
> Issue Type: Bug
> Components: native client
> Reporter: Mario Salazar de Torres
> Assignee: Mario Salazar de Torres
> Priority: Major
> Labels: pull-request-available
>
> A possible race condition was detected in this new IT.
> Given there is no check for servers start/stop, it might happen that the test
> proceeds before the server is actually stopped/started.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
