[jira] [Commented] (GEODE-8202) New option for serial gw sender threads start when receivers share ip and port
[
https://issues.apache.org/jira/browse/GEODE-8202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17262644#comment-17262644
]
ASF GitHub Bot commented on GEODE-8202:
---
alb3rtobr commented on a change in pull request #5600:
URL: https://github.com/apache/geode/pull/5600#discussion_r555049292
##
File path:
geode-wan/src/main/java/org/apache/geode/internal/cache/wan/GatewaySenderEventRemoteDispatcher.java
##
@@ -362,11 +366,71 @@ public void destroyConnection() {
}
}
+ Connection retryInitializeConnection(Connection con) {
+final boolean isDebugEnabled = logger.isDebugEnabled();
+ServerLocation server = this.sender.getServerLocation();
+String connectedServerId = con.getEndpoint().getMemberId().getUniqueId();
+String expectedServerId = this.processor.getExpectedReceiverUniqueId();
+
+if (expectedServerId.equals("")) {
+ if (isDebugEnabled) {
+logger.debug("First dispatcher connected to server " +
connectedServerId);
+ }
+ this.processor.setExpectedReceiverUniqueId(connectedServerId);
+ return con;
+}
+
+int attempt = 0;
+final int attemptsPerServer = 5;
Review comment:
Take into account that this value is per server: if we have three
receivers sharing the same ip and port, we will have 15 attempts. For me its
sounds like a reasonable number of attempts.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> New option for serial gw sender threads start when receivers share ip and port
> --
>
> Key: GEODE-8202
> URL: https://issues.apache.org/jira/browse/GEODE-8202
> Project: Geode
> Issue Type: Improvement
>Reporter: Alberto Bustamante Reyes
>Assignee: Alberto Bustamante Reyes
>Priority: Major
> Labels: pull-request-available
>
> RFC:
> [https://cwiki.apache.org/confluence/display/GEODE/New+option+for+serial+gw+sender+dispatcher+threads+start|https://cwiki.apache.org/confluence/display/GEODE/New+option+for+serial+gw+sender+dispatcher+threads+start]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8202) New option for serial gw sender threads start when receivers share ip and port
[ https://issues.apache.org/jira/browse/GEODE-8202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17262649#comment-17262649 ] ASF GitHub Bot commented on GEODE-8202: --- alb3rtobr commented on pull request #5600: URL: https://github.com/apache/geode/pull/5600#issuecomment-757963215 Thanks for the detailed review @boglesby . I have created a test case to verify the changes you provided to avoid the creation of several senders with different value of `enforceThreadsConnectToSameReceiver`. Im moving this PR to draft until I finish to implement all your comments. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > New option for serial gw sender threads start when receivers share ip and port > -- > > Key: GEODE-8202 > URL: https://issues.apache.org/jira/browse/GEODE-8202 > Project: Geode > Issue Type: Improvement >Reporter: Alberto Bustamante Reyes >Assignee: Alberto Bustamante Reyes >Priority: Major > Labels: pull-request-available > > RFC: > [https://cwiki.apache.org/confluence/display/GEODE/New+option+for+serial+gw+sender+dispatcher+threads+start|https://cwiki.apache.org/confluence/display/GEODE/New+option+for+serial+gw+sender+dispatcher+threads+start] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8806) Native client does not honor log-file-size-limit properly
[
https://issues.apache.org/jira/browse/GEODE-8806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17262706#comment-17262706
]
ASF GitHub Bot commented on GEODE-8806:
---
pdxcodemonkey commented on a change in pull request #718:
URL: https://github.com/apache/geode-native/pull/718#discussion_r555109762
##
File path: cppcache/test/LoggingTest.cpp
##
@@ -0,0 +1,759 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include
+#include
+#include
+
+#include
+#include
+
+#include
+
+#include
+#include
+#include
+#include
+#include
+
+using apache::geode::client::CacheClosedException;
+using apache::geode::client::CacheFactory;
+using apache::geode::client::LogLevel;
+using apache::geode::client::RegionShortcut;
+
+namespace {
+
+const auto __1K__ = 1024;
+const auto __4K__ = 4 * __1K__;
+const auto __1M__ = (__1K__ * __1K__);
+const auto __1G__ = (__1K__ * __1K__ * __1K__);
+
+const auto LENGTH_OF_BANNER = 16;
+
+auto testLogFileName = std::string("LoggingTest.log");
+
+const char* __1KStringLiteral =
+""
+"AA"
+""
+"AA"
+""
+"AA"
+""
+"AA"
+""
+"AA"
+""
+"AA"
+""
+"AA"
+""
+"AA"
+""
+"AA"
+""
+"AA"
+""
+"AA"
+""
+"AA"
+""
+"AA"
+"AA";
+
+class LoggingTest : public testing::Test {
+ void scrubTestLogFiles() {
+// Close logger, just in case
+apache::geode::client::Log::close();
+
+if (boost::filesystem::exists(testLogFileName)) {
+ boost::filesystem::remove(testLogFileName);
+}
+
+std::map rolledFiles;
+LoggingTest::findRolledFiles(boost::filesystem::current_path().string(),
+ rolledFiles);
+for (auto& item : rolledFiles) {
+ boost::filesystem::remove(item.second);
+}
+ }
+
+ virtual void SetUp() { scrubTestLogFiles(); }
+
+ virtual void TearDown() { scrubTestLogFiles(); }
+
+ public:
+ static void writeRolledLogFile(const boost::filesystem::path& logdir,
+ int32_t rollIndex) {
+auto rolledPath =
+logdir / boost::filesystem::path("LoggingTest-" +
+ std::to_string(rollIndex) + ".log");
+auto rolledFile = fopen(rolledPath.string().c_str(), "w");
+fwrite("Test", 1, 4, rolledFile);
+fclose(rolledFile);
+ }
+
+ static int numOfLinesInFile(const char* fname) {
+char line[2048];
+char* read;
+int ln_cnt = 0;
+FILE* fp = fopen(fname, "r");
+if (fp == nullptr) {
+ return 0;
+}
+while (!!(read = fgets(line, sizeof line, fp))) {
+ ++ln_cnt;
+}
+
+if (!feof(fp)) {
+ fclose(fp);
+ return -2;
+}
+fclose(fp);
+return ln_cnt;
+ }
+
+ static int expected(LogLevel level) {
+int expected = static_cast(level);
+if (level >= LogLevel::Default) {
+ expected--;
+}
+return expected;
+ }
+
+ static int expectedWithBanner(LogLevel level) {
+int expected = LoggingTest::expected(level);
+if (level != LogLevel::None) {
+ expected += LENGTH_OF_BANNER;
+}
+return expected;
+ }
+
+ static void verifyL
[jira] [Commented] (GEODE-8806) Native client does not honor log-file-size-limit properly
[
https://issues.apache.org/jira/browse/GEODE-8806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17262709#comment-17262709
]
ASF GitHub Bot commented on GEODE-8806:
---
pdxcodemonkey commented on a change in pull request #718:
URL: https://github.com/apache/geode-native/pull/718#discussion_r555112125
##
File path: cppcache/integration/test/AuthInitializeTest.cpp
##
@@ -68,7 +68,7 @@ const int32_t CQ_PLUS_AUTH_TEST_REGION_ENTRY_COUNT = 10;
Cache createCache(std::shared_ptr auth) {
auto cache = CacheFactory()
- .set("log-level", "debug")
+ .set("log-level", "none")
Review comment:
Got em.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Native client does not honor log-file-size-limit properly
> -
>
> Key: GEODE-8806
> URL: https://issues.apache.org/jira/browse/GEODE-8806
> Project: Geode
> Issue Type: Bug
> Components: native client
>Reporter: Blake Bender
>Priority: Major
> Labels: pull-request-available
>
> As a user, I need to be able to limit the size of my log files and the amount
> of disk space used by geode-native. Unfortunately, the 10.x native client
> doesn't appear to "roll" log files correctly.
>
> repro steps:
> i. In a client application, set `log-file-size-limit` to 1 (for 1MB),
> `log-level` to `debug`, and `log-file` to something convenient like
> `native_app.log`
> ii. Run a long operation in the client that will generate a huge amount of
> logging, like 100,000 puts to a region
>
> expected behavior:
> * when native_app.log grows to > 1MB in size, it is followed by
> native_app-1.log, native_app-2.log, etc, each of which is ~1MB in size
> actual behavior:
> * native_app.log grows to > 1MB, then geode-native stops logging
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8806) Native client does not honor log-file-size-limit properly
[
https://issues.apache.org/jira/browse/GEODE-8806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17262721#comment-17262721
]
ASF GitHub Bot commented on GEODE-8806:
---
pdxcodemonkey commented on a change in pull request #718:
URL: https://github.com/apache/geode-native/pull/718#discussion_r555121685
##
File path: cppcache/test/LoggingTest.cpp
##
@@ -0,0 +1,759 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+#include
+#include
+#include
+
+#include
+#include
+
+#include
+
+#include
+#include
+#include
+#include
+#include
+
+using apache::geode::client::CacheClosedException;
+using apache::geode::client::CacheFactory;
+using apache::geode::client::LogLevel;
+using apache::geode::client::RegionShortcut;
+
+namespace {
+
+const auto __1K__ = 1024;
+const auto __4K__ = 4 * __1K__;
+const auto __1M__ = (__1K__ * __1K__);
+const auto __1G__ = (__1K__ * __1K__ * __1K__);
+
+const auto LENGTH_OF_BANNER = 16;
+
+auto testLogFileName = std::string("LoggingTest.log");
+
+const char* __1KStringLiteral =
+""
+"AA"
+""
+"AA"
+""
+"AA"
+""
+"AA"
+""
+"AA"
+""
+"AA"
+""
+"AA"
+""
+"AA"
+""
+"AA"
+""
+"AA"
+""
+"AA"
+""
+"AA"
+""
+"AA"
+"AA";
+
+class LoggingTest : public testing::Test {
+ void scrubTestLogFiles() {
+// Close logger, just in case
+apache::geode::client::Log::close();
+
+if (boost::filesystem::exists(testLogFileName)) {
+ boost::filesystem::remove(testLogFileName);
+}
+
+std::map rolledFiles;
+LoggingTest::findRolledFiles(boost::filesystem::current_path().string(),
+ rolledFiles);
+for (auto& item : rolledFiles) {
+ boost::filesystem::remove(item.second);
+}
+ }
+
+ virtual void SetUp() { scrubTestLogFiles(); }
+
+ virtual void TearDown() { scrubTestLogFiles(); }
+
+ public:
+ static void writeRolledLogFile(const boost::filesystem::path& logdir,
+ int32_t rollIndex) {
+auto rolledPath =
+logdir / boost::filesystem::path("LoggingTest-" +
+ std::to_string(rollIndex) + ".log");
+auto rolledFile = fopen(rolledPath.string().c_str(), "w");
+fwrite("Test", 1, 4, rolledFile);
+fclose(rolledFile);
+ }
+
+ static int numOfLinesInFile(const char* fname) {
+char line[2048];
+char* read;
+int ln_cnt = 0;
+FILE* fp = fopen(fname, "r");
+if (fp == nullptr) {
+ return 0;
+}
+while (!!(read = fgets(line, sizeof line, fp))) {
+ ++ln_cnt;
+}
+
+if (!feof(fp)) {
+ fclose(fp);
+ return -2;
+}
+fclose(fp);
+return ln_cnt;
+ }
+
+ static int expected(LogLevel level) {
+int expected = static_cast(level);
+if (level >= LogLevel::Default) {
+ expected--;
+}
+return expected;
+ }
+
+ static int expectedWithBanner(LogLevel level) {
+int expected = LoggingTest::expected(level);
+if (level != LogLevel::None) {
+ expected += LENGTH_OF_BANNER;
+}
+return expected;
+ }
+
+ static void verifyL
[jira] [Commented] (GEODE-8626) Omitting field-mapping tag of cache.xml when using Simple JDBC Connector
[
https://issues.apache.org/jira/browse/GEODE-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17262731#comment-17262731
]
ASF GitHub Bot commented on GEODE-8626:
---
masaki-yamakawa commented on a change in pull request #5637:
URL: https://github.com/apache/geode/pull/5637#discussion_r555132569
##
File path:
geode-connectors/src/distributedTest/java/org/apache/geode/connectors/jdbc/internal/cli/CreateMappingCommandDUnitTest.java
##
@@ -1142,7 +1142,7 @@ public void createMappingWithExistingQueueFails() {
+ " must not already exist.");
}
- private static class Employee implements PdxSerializable {
+ public static class Employee implements PdxSerializable {
Review comment:
Thank you for your detailed explanation. I have reverted the
`CreateMappingPreconditionCheckFunction` and `JdbcConnectorService` to the
original source code. And I have implemented similar methods in
`RegionMappingConfiguration`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Omitting field-mapping tag of cache.xml when using Simple JDBC Connector
>
>
> Key: GEODE-8626
> URL: https://issues.apache.org/jira/browse/GEODE-8626
> Project: Geode
> Issue Type: Improvement
> Components: jdbc
>Reporter: Masaki Yamakawa
>Priority: Minor
> Labels: pull-request-available
>
> When configuring Simple JDBC Connector with gfsh, I don't need to create
> field-mapping, the default field-mapping will be created from pdx and table
> meta data.
> On the other hand, when using cache.xml(cluster.xml), pdx and table meta data
> cannot be used, and field-mapping must be described in cache.xml.
> I would like to create field-mapping defaults based on pdx and table meta
> data when using cache.xml.
> If field-mapping is specified in cache.xml, the xml setting has priority, and
> only if there are no field-mapping tags.
> cache.xml will be as follows:
> {code:java}
>
> data-source="TestDataSource"
> table="employees"
> pdx-name="org.apache.geode.connectors.jdbc.Employee"
> ids="id">
>
>
>
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8626) Omitting field-mapping tag of cache.xml when using Simple JDBC Connector
[
https://issues.apache.org/jira/browse/GEODE-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17262733#comment-17262733
]
ASF GitHub Bot commented on GEODE-8626:
---
masaki-yamakawa commented on a change in pull request #5637:
URL: https://github.com/apache/geode/pull/5637#discussion_r555133247
##
File path:
geode-connectors/src/acceptanceTest/java/org/apache/geode/connectors/jdbc/GfshJdbcMappingIntegrationTest.java
##
@@ -0,0 +1,208 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express
+ * or implied. See the License for the specific language governing permissions
and limitations under
+ * the License.
+ */
+package org.apache.geode.connectors.jdbc;
+
+import java.lang.reflect.Constructor;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.List;
+import java.util.Set;
+
+import org.apache.geode.cache.CacheFactory;
+import org.apache.geode.cache.configuration.JndiBindingsType;
+import org.apache.geode.cache.configuration.RegionConfig;
+import org.apache.geode.cache.execute.Function;
+import org.apache.geode.cache.execute.ResultCollector;
+import org.apache.geode.connectors.jdbc.internal.cli.CreateMappingFunction;
+import
org.apache.geode.connectors.jdbc.internal.cli.CreateMappingPreconditionCheckFunction;
+import org.apache.geode.connectors.jdbc.internal.configuration.FieldMapping;
+import org.apache.geode.connectors.jdbc.internal.configuration.RegionMapping;
+import org.apache.geode.distributed.DistributedMember;
+import org.apache.geode.internal.cache.InternalCache;
+import org.apache.geode.management.configuration.RegionType;
+import
org.apache.geode.management.internal.cli.commands.CreateJndiBindingCommand;
+import
org.apache.geode.management.internal.cli.functions.CreateJndiBindingFunction;
+import
org.apache.geode.management.internal.cli.functions.CreateRegionFunctionArgs;
+import org.apache.geode.management.internal.cli.functions.RegionCreateFunction;
+import
org.apache.geode.management.internal.configuration.converters.RegionConverter;
+import org.apache.geode.management.internal.functions.CliFunctionResult;
+import org.apache.geode.management.internal.util.ManagementUtils;
+
+public class GfshJdbcMappingIntegrationTest extends JdbcMappingIntegrationTest
{
+
+ @Override
+ protected InternalCache createCacheAndCreateJdbcMapping(String
cacheXmlTestName)
+ throws Exception {
+InternalCache cache =
+(InternalCache) new CacheFactory().set("locators",
"").set("mcast-port", "0").create();
+Set targetMembers = findMembers(cache, null, null);
+
+CliFunctionResult createRegionFuncResult =
executeCreateRegionFunction(targetMembers);
Review comment:
I removed `GfshJdbcMappingIntegrationTest` because I no longer need to
impliment it.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Omitting field-mapping tag of cache.xml when using Simple JDBC Connector
>
>
> Key: GEODE-8626
> URL: https://issues.apache.org/jira/browse/GEODE-8626
> Project: Geode
> Issue Type: Improvement
> Components: jdbc
>Reporter: Masaki Yamakawa
>Priority: Minor
> Labels: pull-request-available
>
> When configuring Simple JDBC Connector with gfsh, I don't need to create
> field-mapping, the default field-mapping will be created from pdx and table
> meta data.
> On the other hand, when using cache.xml(cluster.xml), pdx and table meta data
> cannot be used, and field-mapping must be described in cache.xml.
> I would like to create field-mapping defaults based on pdx and table meta
> data when using cache.xml.
> If field-mapping is specified in cache.xml, the xml setting has priority, and
> only if there are no field-mapping tags.
> cache.xml will be as follows:
> {code:java}
>
> data-source="TestDataSource"
> table="employees"
> pdx-name="org.apache.geo
[jira] [Commented] (GEODE-8626) Omitting field-mapping tag of cache.xml when using Simple JDBC Connector
[
https://issues.apache.org/jira/browse/GEODE-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17262734#comment-17262734
]
ASF GitHub Bot commented on GEODE-8626:
---
masaki-yamakawa commented on pull request #5637:
URL: https://github.com/apache/geode/pull/5637#issuecomment-758029719
@jchen21 Thank you for your review. I have fixed the code following your
suggestion.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Omitting field-mapping tag of cache.xml when using Simple JDBC Connector
>
>
> Key: GEODE-8626
> URL: https://issues.apache.org/jira/browse/GEODE-8626
> Project: Geode
> Issue Type: Improvement
> Components: jdbc
>Reporter: Masaki Yamakawa
>Priority: Minor
> Labels: pull-request-available
>
> When configuring Simple JDBC Connector with gfsh, I don't need to create
> field-mapping, the default field-mapping will be created from pdx and table
> meta data.
> On the other hand, when using cache.xml(cluster.xml), pdx and table meta data
> cannot be used, and field-mapping must be described in cache.xml.
> I would like to create field-mapping defaults based on pdx and table meta
> data when using cache.xml.
> If field-mapping is specified in cache.xml, the xml setting has priority, and
> only if there are no field-mapping tags.
> cache.xml will be as follows:
> {code:java}
>
> data-source="TestDataSource"
> table="employees"
> pdx-name="org.apache.geode.connectors.jdbc.Employee"
> ids="id">
>
>
>
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8577) PubSubNativeRedisAcceptanceTest is flaky
[ https://issues.apache.org/jira/browse/GEODE-8577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17262736#comment-17262736 ] ASF GitHub Bot commented on GEODE-8577: --- jdeppe-pivotal merged pull request #5874: URL: https://github.com/apache/geode/pull/5874 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > PubSubNativeRedisAcceptanceTest is flaky > > > Key: GEODE-8577 > URL: https://issues.apache.org/jira/browse/GEODE-8577 > Project: Geode > Issue Type: Test > Components: redis >Reporter: Jens Deppe >Assignee: Sarah Abbey >Priority: Major > Labels: pull-request-available > > Going to disable this one test and work on fixing that. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8577) PubSubNativeRedisAcceptanceTest is flaky
[ https://issues.apache.org/jira/browse/GEODE-8577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17262737#comment-17262737 ] ASF subversion and git services commented on GEODE-8577: Commit cad1eb55f6de613a62efc2a3daf2935b2b7aebda in geode's branch refs/heads/develop from Jens Deppe [ https://gitbox.apache.org/repos/asf?p=geode.git;h=cad1eb5 ] GEODE-8577: Increase time to get Redis native connection (#5874) - It's possible that the test is exhausting the number of available sockets. Closed connections sit in TIME_WAIT for 60 seconds on Linux. This change increases the time to get a connection beyond that to allow for connections to be fully closed and ports to be released. > PubSubNativeRedisAcceptanceTest is flaky > > > Key: GEODE-8577 > URL: https://issues.apache.org/jira/browse/GEODE-8577 > Project: Geode > Issue Type: Test > Components: redis >Reporter: Jens Deppe >Assignee: Sarah Abbey >Priority: Major > Labels: pull-request-available > > Going to disable this one test and work on fixing that. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8806) Native client does not honor log-file-size-limit properly
[
https://issues.apache.org/jira/browse/GEODE-8806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17262750#comment-17262750
]
ASF GitHub Bot commented on GEODE-8806:
---
pivotal-jbarrett commented on a change in pull request #718:
URL: https://github.com/apache/geode-native/pull/718#discussion_r555152211
##
File path: cppcache/integration/test/CacheXmlTest.cpp
##
@@ -44,8 +44,7 @@ apache::geode::client::Cache createCacheUsingXmlConfig(
CacheFactory cacheFactory;
- auto cache = cacheFactory.set("log-level", "debug")
- .set("log-file", "geode_native.log")
+ auto cache = cacheFactory.set("log-level", "none")
.set("statistic-sampling-enabled", "false")
.set("cache-xml-file", xmlFile.c_str())
Review comment:
Not your fault, but if there is anything else to clean up can you figure
out why this is producing a `c_str()` only to covert it back to a `std::string`.
##
File path: cppcache/src/Log.cpp
##
@@ -502,178 +351,77 @@ LogLevel Log::charsToLevel(const std::string& chars) {
}
}
-char* Log::formatLogLine(char* buf, LogLevel level) {
- if (g_pid == 0) {
-g_pid = boost::this_process::get_id();
-ACE_OS::uname(&g_uname);
- }
+std::string Log::formatLogLine(LogLevel level) {
+ std::stringstream msg;
const size_t MINBUFSIZE = 128;
auto now = std::chrono::system_clock::now();
auto secs = std::chrono::system_clock::to_time_t(now);
auto microseconds = std::chrono::duration_cast(
now - std::chrono::system_clock::from_time_t(secs));
auto tm_val = apache::geode::util::chrono::localtime(secs);
- auto pbuf = buf;
- pbuf += std::snprintf(pbuf, 15, "[%s ", Log::levelToChars(level));
- pbuf += std::strftime(pbuf, MINBUFSIZE, "%Y/%m/%d %H:%M:%S", &tm_val);
- pbuf += std::snprintf(pbuf, 15, ".%06" PRId64 " ",
-static_cast(microseconds.count()));
- pbuf += std::strftime(pbuf, MINBUFSIZE, "%Z ", &tm_val);
+ msg << "[" << Log::levelToChars(level) << " ";
+ char timebuf[MINBUFSIZE];
- std::snprintf(pbuf, 300, "%s:%d %" PRIu64 "] ", g_uname.nodename, g_pid,
-hacks::aceThreadId(ACE_OS::thr_self()));
+ std::strftime(timebuf, MINBUFSIZE, "%Y/%m/%d %H:%M:%S", &tm_val);
+ msg << timebuf;
- return buf;
-}
+ std::snprintf(timebuf, 15, ".%06" PRId64 " ",
+static_cast(microseconds.count()));
+ msg << timebuf << " ";
-void Log::put(LogLevel level, const std::string& msg) {
- put(level, msg.c_str());
+ std::strftime(timebuf, MINBUFSIZE, "%Z ", &tm_val);
+ msg << timebuf << " " << boost::asio::ip::host_name() << ":"
Review comment:
I am a bit concerned this may result in a system call the resolver for
every log message. The previous code cached this. I suggest a `::hostname()`
method with a static resolved hostname using this method (Meyer's Singleton).
The likely hood of the hostname changing over the life of a client, while not
0, is pretty darn close to 0.
##
File path: cppcache/src/Log.cpp
##
@@ -502,178 +351,77 @@ LogLevel Log::charsToLevel(const std::string& chars) {
}
}
-char* Log::formatLogLine(char* buf, LogLevel level) {
- if (g_pid == 0) {
-g_pid = boost::this_process::get_id();
-ACE_OS::uname(&g_uname);
- }
+std::string Log::formatLogLine(LogLevel level) {
+ std::stringstream msg;
const size_t MINBUFSIZE = 128;
auto now = std::chrono::system_clock::now();
auto secs = std::chrono::system_clock::to_time_t(now);
auto microseconds = std::chrono::duration_cast(
now - std::chrono::system_clock::from_time_t(secs));
auto tm_val = apache::geode::util::chrono::localtime(secs);
- auto pbuf = buf;
- pbuf += std::snprintf(pbuf, 15, "[%s ", Log::levelToChars(level));
- pbuf += std::strftime(pbuf, MINBUFSIZE, "%Y/%m/%d %H:%M:%S", &tm_val);
- pbuf += std::snprintf(pbuf, 15, ".%06" PRId64 " ",
-static_cast(microseconds.count()));
- pbuf += std::strftime(pbuf, MINBUFSIZE, "%Z ", &tm_val);
+ msg << "[" << Log::levelToChars(level) << " ";
+ char timebuf[MINBUFSIZE];
- std::snprintf(pbuf, 300, "%s:%d %" PRIu64 "] ", g_uname.nodename, g_pid,
-hacks::aceThreadId(ACE_OS::thr_self()));
+ std::strftime(timebuf, MINBUFSIZE, "%Y/%m/%d %H:%M:%S", &tm_val);
+ msg << timebuf;
- return buf;
-}
+ std::snprintf(timebuf, 15, ".%06" PRId64 " ",
Review comment:
You should be able to do with with std stream formatting directives and
avoid the extra calls to `snprintf`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Native client does not honor log-file-size-lim
[jira] [Commented] (GEODE-8278) Gateway sender queues using heap memory way above configured value after server restart
[ https://issues.apache.org/jira/browse/GEODE-8278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17262790#comment-17262790 ] ASF subversion and git services commented on GEODE-8278: Commit 7c3e2ab245c057844100e1ae827c78a485b65dbc in geode's branch refs/heads/feature/GEODE-8278 from Barry Oglesby [ https://gitbox.apache.org/repos/asf?p=geode.git;h=7c3e2ab ] GEODE-8278: Update spotless > Gateway sender queues using heap memory way above configured value after > server restart > --- > > Key: GEODE-8278 > URL: https://issues.apache.org/jira/browse/GEODE-8278 > Project: Geode > Issue Type: Bug > Components: eviction >Reporter: Alberto Gomez >Assignee: Alberto Gomez >Priority: Major > Labels: pull-request-available > > In a Geode system with the following characteristics: > * WAN replication > * partition redundant regions > * overflow configured for the gateway senders queues by means of persistence > and maximum queue memory set. > * gateway receivers stopped in one site (B) > * Operations sent to the site that does not have the gateway receivers > stopped (A) > When operations are sent to site A, the gateway sender queues start to grow > as expected and the heap memory consumed by the queues does not grow > indefinitely given that there is overflow to disk when the limit is reached. > But, if a server is restarted, the restarted server will show a much higher > heap memory used than the memory used by this server before it was restarted > or by the other servers. > This can even provoke that the server cannot be restarted if the heap memory > it requires is above the limit configured. > According to the memory analyzer the entries taking up the memory are > subclasses of ```VMThinDiskLRURegionEntryHeap```. > The number of instances of this type are the same in the restarted server > than in the not restarted servers but on the restarted server they take much > more memory. The reason seems to be that the ```value``` member attribute of > the instances, in the case of the restarted server contains > ```VMCachedDeserializable``` objects while in the case of the not restarted > server the attribute contains either ```null``` or > ```GatewaySenderEventImpl``` objects that use much less memory than the > ```VMCachedDeserializable``` ones. > If redundancy is not configured for the region then the problem is not > manifested, i.e. the heap memory used by the restarted server is similar to > the one prior to the restart. > If the node not restarted is restarted then the previously restarted node > seems to release the extra memory (my guess is that it is processing the > other process queue). > Also, if traffic is sent again to the Geode cluster, then it seems eviction > kicks in and after some short time, the memory of the restarted server goes > down to the level it had before it had been restarted. > As a summary, the problem seems to be that if a server does GII > (getInitialImage) from another server, eviction does not occur for gateway > sender queue entries. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8806) Native client does not honor log-file-size-limit properly
[ https://issues.apache.org/jira/browse/GEODE-8806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17262817#comment-17262817 ] ASF GitHub Bot commented on GEODE-8806: --- codecov-io edited a comment on pull request #718: URL: https://github.com/apache/geode-native/pull/718#issuecomment-757540519 # [Codecov](https://codecov.io/gh/apache/geode-native/pull/718?src=pr&el=h1) Report > Merging [#718](https://codecov.io/gh/apache/geode-native/pull/718?src=pr&el=desc) (e0ed487) into [develop](https://codecov.io/gh/apache/geode-native/commit/c1886061ff94e328d4675206b34c3a4868510600?el=desc) (c188606) will **decrease** coverage by `0.09%`. > The diff coverage is `95.96%`. [](https://codecov.io/gh/apache/geode-native/pull/718?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## develop #718 +/- ## === - Coverage74.08% 73.98% -0.10% === Files 645 645 Lines5085850806 -52 === - Hits 3768037591 -89 - Misses 1317813215 +37 ``` | [Impacted Files](https://codecov.io/gh/apache/geode-native/pull/718?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [cppcache/integration-test/fw\_helper.hpp](https://codecov.io/gh/apache/geode-native/pull/718/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvaW50ZWdyYXRpb24tdGVzdC9md19oZWxwZXIuaHBw) | `56.60% <0.00%> (+1.04%)` | :arrow_up: | | [cppcache/src/Log.cpp](https://codecov.io/gh/apache/geode-native/pull/718/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL0xvZy5jcHA=) | `79.29% <89.86%> (+21.81%)` | :arrow_up: | | [cppcache/test/LoggingTest.cpp](https://codecov.io/gh/apache/geode-native/pull/718/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvdGVzdC9Mb2dnaW5nVGVzdC5jcHA=) | `99.32% <99.32%> (ø)` | | | [cppcache/src/ReadWriteLock.cpp](https://codecov.io/gh/apache/geode-native/pull/718/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1JlYWRXcml0ZUxvY2suY3Bw) | `62.50% <0.00%> (-37.50%)` | :arrow_down: | | [cppcache/src/TcrPoolEndPoint.cpp](https://codecov.io/gh/apache/geode-native/pull/718/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RjclBvb2xFbmRQb2ludC5jcHA=) | `83.09% <0.00%> (-7.05%)` | :arrow_down: | | [cppcache/src/TcrEndpoint.cpp](https://codecov.io/gh/apache/geode-native/pull/718/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RjckVuZHBvaW50LmNwcA==) | `53.52% <0.00%> (-3.67%)` | :arrow_down: | | [cppcache/src/ThinClientRedundancyManager.cpp](https://codecov.io/gh/apache/geode-native/pull/718/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRSZWR1bmRhbmN5TWFuYWdlci5jcHA=) | `72.30% <0.00%> (-3.45%)` | :arrow_down: | | [cppcache/src/ThinClientBaseDM.cpp](https://codecov.io/gh/apache/geode-native/pull/718/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRCYXNlRE0uY3Bw) | `65.55% <0.00%> (-3.34%)` | :arrow_down: | | [cppcache/src/TcrConnection.cpp](https://codecov.io/gh/apache/geode-native/pull/718/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RjckNvbm5lY3Rpb24uY3Bw) | `70.45% <0.00%> (-2.34%)` | :arrow_down: | | [cppcache/src/ExceptionTypes.cpp](https://codecov.io/gh/apache/geode-native/pull/718/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL0V4Y2VwdGlvblR5cGVzLmNwcA==) | `42.04% <0.00%> (-2.28%)` | :arrow_down: | | ... and [26 more](https://codecov.io/gh/apache/geode-native/pull/718/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/geode-native/pull/718?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/geode-native/pull/718?src=pr&el=footer). Last update [c188606...e0ed487](https://codecov.io/gh/apache/geode-native/pull/718?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Native client does not honor log-file-size-limit properly > - > > Key: GEODE-8806 > URL: https://issues.apache.org/jira/browse/GEODE-8806 > Project: Geode > Issue Type: Bug > Components: na
[jira] [Assigned] (GEODE-8803) RedisStatsIntegrationTest.opsPerformedOverLastSecond_ShouldUpdate_givenOperationsOccurring fails intermittently
[
https://issues.apache.org/jira/browse/GEODE-8803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Deppe reassigned GEODE-8803:
-
Assignee: John Hutchison (was: Jens Deppe)
> RedisStatsIntegrationTest.opsPerformedOverLastSecond_ShouldUpdate_givenOperationsOccurring
> fails intermittently
> ---
>
> Key: GEODE-8803
> URL: https://issues.apache.org/jira/browse/GEODE-8803
> Project: Geode
> Issue Type: Bug
> Components: redis
>Reporter: Kirk Lund
>Assignee: John Hutchison
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.14.0
>
>
> http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0578/test-results/integrationTest/1609804101/
> {noformat}
> java.lang.AssertionError:
> Expecting:
> <19.0>
> to be close to:
> <17.0>
> by less than <1.0> but difference was <2.0>.
> (a difference of exactly <1.0> being considered valid)
> at
> org.apache.geode.redis.internal.RedisStatsIntegrationTest.opsPerformedOverLastSecond_ShouldUpdate_givenOperationsOccurring(RedisStatsIntegrationTest.java:430)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> at
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> at
> org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
> at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
> at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> at
> org.apache.geode.test.junit.rules.serializable.SerializableExternalResource$1.evaluate(SerializableExternalResource.java:38)
> at org.junit.rules.RunRules.evaluate(RunRules.java:20)
> at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
> at
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.runTestClass(JUnitTestClassExecutor.java:110)
> at
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:58)
> at
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:38)
> at
> org.gradle.api.internal.tasks.testing.junit.AbstractJUnitTestClassProcessor.processTestClass(AbstractJUnitTestClassProcessor.java:62)
> at
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
> at
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
> at
> org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
> at
> org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
> at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
> at
> org.gradle.api.in
[jira] [Resolved] (GEODE-8803) RedisStatsIntegrationTest.opsPerformedOverLastSecond_ShouldUpdate_givenOperationsOccurring fails intermittently
[
https://issues.apache.org/jira/browse/GEODE-8803?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Deppe resolved GEODE-8803.
---
Fix Version/s: 1.14.0
Resolution: Fixed
> RedisStatsIntegrationTest.opsPerformedOverLastSecond_ShouldUpdate_givenOperationsOccurring
> fails intermittently
> ---
>
> Key: GEODE-8803
> URL: https://issues.apache.org/jira/browse/GEODE-8803
> Project: Geode
> Issue Type: Bug
> Components: redis
>Reporter: Kirk Lund
>Assignee: Jens Deppe
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.14.0
>
>
> http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0578/test-results/integrationTest/1609804101/
> {noformat}
> java.lang.AssertionError:
> Expecting:
> <19.0>
> to be close to:
> <17.0>
> by less than <1.0> but difference was <2.0>.
> (a difference of exactly <1.0> being considered valid)
> at
> org.apache.geode.redis.internal.RedisStatsIntegrationTest.opsPerformedOverLastSecond_ShouldUpdate_givenOperationsOccurring(RedisStatsIntegrationTest.java:430)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:59)
> at
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
> at
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:56)
> at
> org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:17)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> at
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
> at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> at
> org.junit.runners.BlockJUnit4ClassRunner$1.evaluate(BlockJUnit4ClassRunner.java:100)
> at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:366)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:103)
> at
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:63)
> at org.junit.runners.ParentRunner$4.run(ParentRunner.java:331)
> at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:79)
> at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:329)
> at org.junit.runners.ParentRunner.access$100(ParentRunner.java:66)
> at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:293)
> at
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
> at
> org.apache.geode.test.junit.rules.serializable.SerializableExternalResource$1.evaluate(SerializableExternalResource.java:38)
> at org.junit.rules.RunRules.evaluate(RunRules.java:20)
> at org.junit.runners.ParentRunner$3.evaluate(ParentRunner.java:306)
> at org.junit.runners.ParentRunner.run(ParentRunner.java:413)
> at
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.runTestClass(JUnitTestClassExecutor.java:110)
> at
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:58)
> at
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:38)
> at
> org.gradle.api.internal.tasks.testing.junit.AbstractJUnitTestClassProcessor.processTestClass(AbstractJUnitTestClassProcessor.java:62)
> at
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
> at
> org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
> at
> org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:32)
> at
> org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:93)
> at com.sun.proxy.$Proxy2.processTestClass(Unknown Source)
> at
> org.gradle.api.internal
[jira] [Resolved] (GEODE-8821) Add tests to validate Geode redis stats
[ https://issues.apache.org/jira/browse/GEODE-8821?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Deppe resolved GEODE-8821. --- Fix Version/s: 1.14.0 Resolution: Fixed > Add tests to validate Geode redis stats > --- > > Key: GEODE-8821 > URL: https://issues.apache.org/jira/browse/GEODE-8821 > Project: Geode > Issue Type: Test > Components: redis >Reporter: Jens Deppe >Assignee: Jens Deppe >Priority: Major > Labels: pull-request-available > Fix For: 1.14.0 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-8819) StressNewTestHelper should handle non org.apache.geode changed files
[ https://issues.apache.org/jira/browse/GEODE-8819?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Deppe resolved GEODE-8819. --- Fix Version/s: 1.14.0 Resolution: Fixed > StressNewTestHelper should handle non org.apache.geode changed files > > > Key: GEODE-8819 > URL: https://issues.apache.org/jira/browse/GEODE-8819 > Project: Geode > Issue Type: Bug > Components: build >Reporter: Jens Deppe >Assignee: Jens Deppe >Priority: Major > Labels: pull-request-available > Fix For: 1.14.0 > > > The utility throws a NPE if any input file is not in the org.apache.geode > package. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8818) Make docs of copy-on-read more visible to readers
[ https://issues.apache.org/jira/browse/GEODE-8818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17262839#comment-17262839 ] ASF GitHub Bot commented on GEODE-8818: --- davebarnes97 commented on a change in pull request #5888: URL: https://github.com/apache/geode/pull/5888#discussion_r555242529 ## File path: geode-docs/basic_config/data_entries_custom_classes/copy_on_read.html.md.erb ## @@ -0,0 +1,56 @@ +--- +title: Copy on Read Behavior +--- + + + +When you get an entry value from the cache, by default, the retrieval methods return a direct reference to the cached object. This provides the value as quickly as possible, but also opens the cache to direct, in-place changes. + +**Note:** +Do not directly modify cached values. Modifying a value in place bypasses the <%=vars.product_name%> distribution framework, including cache writers and listeners, expiration activities, and transaction management, and can produce undesired results. + +Always change your entries using copies of the retrieved objects—never directly modify the returned objects. You can do this in one of two ways: Review comment: Punctuation nit: please replace the hyphen in "objects-never" with an em-dash (—), a semicolon, or a full stop. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Make docs of copy-on-read more visible to readers > - > > Key: GEODE-8818 > URL: https://issues.apache.org/jira/browse/GEODE-8818 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Karen Smoler Miller >Assignee: Karen Smoler Miller >Priority: Major > Labels: pull-request-available > > Our users need more visibility of the copy-on-read region attribute. Promote > the subsection from within Basic Configuration and Programming, Data Entries, > Managing Data Entries to its own section within Data Entries. Update all > links within the manual to point to the new section. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8728) Configure Gradle to run parallel tests in isolation without Docker [PERMANENT]
[ https://issues.apache.org/jira/browse/GEODE-8728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17262866#comment-17262866 ] ASF GitHub Bot commented on GEODE-8728: --- lgtm-com[bot] commented on pull request #5848: URL: https://github.com/apache/geode/pull/5848#issuecomment-758153095 This pull request **fixes 1 alert** when merging 58f147a2e210b89aac1cf4b50c17205974d7a442 into cad1eb55f6de613a62efc2a3daf2935b2b7aebda - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-ba6a7896198102fb4aa474f320ab3b7d7689937f) **fixed alerts:** * 1 for Dereferenced variable may be null This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Configure Gradle to run parallel tests in isolation without Docker [PERMANENT] > -- > > Key: GEODE-8728 > URL: https://issues.apache.org/jira/browse/GEODE-8728 > Project: Geode > Issue Type: Test > Components: tests >Affects Versions: 1.14.0 >Reporter: Dale Emery >Assignee: Dale Emery >Priority: Major > Labels: GeodeOperationAPI, pull-request-available > > For tests to behave well when run in parallel, each must refrain from using > ports and test files that are in use by other tests. > Geode's Gradle build isolates concurrently executing tests by running each > test class in a Docker container. To do this, the build applies an open > source "Gradle Dockerized Test" plugin that is obsolete and appears to be > unmaintained. > This ticket removes the obsolete plugin and replaces it with a small amount > of custom Gradle code and a few minor changes to Geode: > - Configure Gradle to assign each concurrently executing test JVM a unique > working directory and a distinct range of ports. > - Change Geode's "available port" feature to allocate ports only from the > ranges assigned by Gradle. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (GEODE-8824) fix CODEOWNERS rules
Owen Nichols created GEODE-8824:
---
Summary: fix CODEOWNERS rules
Key: GEODE-8824
URL: https://issues.apache.org/jira/browse/GEODE-8824
Project: Geode
Issue Type: Bug
Components: github
Reporter: Owen Nichols
We are finding some quirks in how GitHub parses the rules in CODEOWNERS. It
seems to not support paths containing {{/**/}} and also a few rules were not
ordered correctly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8447) Pulse should localize “java.util.Date” in the displayed query result
[ https://issues.apache.org/jira/browse/GEODE-8447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17262868#comment-17262868 ] Jinmei Liao commented on GEODE-8447: Re-open because the localized format does not include seconds. > Pulse should localize “java.util.Date” in the displayed query result > > > Key: GEODE-8447 > URL: https://issues.apache.org/jira/browse/GEODE-8447 > Project: Geode > Issue Type: Bug > Components: management >Affects Versions: 1.12.0 >Reporter: Jinmei Liao >Assignee: Jinmei Liao >Priority: Major > Labels: pull-request-available > Fix For: 1.12.1, 1.14.0, 1.13.1 > > Attachments: CreatedOn-lastUpdated.JPG, Date-GF96.JPG > > > In previous versions of Geode, Pulse used to show Dates in localized string, > now it's not. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (GEODE-8824) fix CODEOWNERS rules
[
https://issues.apache.org/jira/browse/GEODE-8824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Owen Nichols reassigned GEODE-8824:
---
Assignee: Owen Nichols
> fix CODEOWNERS rules
>
>
> Key: GEODE-8824
> URL: https://issues.apache.org/jira/browse/GEODE-8824
> Project: Geode
> Issue Type: Bug
> Components: github
>Reporter: Owen Nichols
>Assignee: Owen Nichols
>Priority: Major
>
> We are finding some quirks in how GitHub parses the rules in CODEOWNERS. It
> seems to not support paths containing {{/**/}} and also a few rules were not
> ordered correctly.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8447) Pulse should localize “java.util.Date” in the displayed query result
[ https://issues.apache.org/jira/browse/GEODE-8447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17262871#comment-17262871 ] ASF GitHub Bot commented on GEODE-8447: --- jinmeiliao opened a new pull request #5891: URL: https://github.com/apache/geode/pull/5891 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Pulse should localize “java.util.Date” in the displayed query result > > > Key: GEODE-8447 > URL: https://issues.apache.org/jira/browse/GEODE-8447 > Project: Geode > Issue Type: Bug > Components: management >Affects Versions: 1.12.0 >Reporter: Jinmei Liao >Assignee: Jinmei Liao >Priority: Major > Labels: pull-request-available > Fix For: 1.12.1, 1.14.0, 1.13.1 > > Attachments: CreatedOn-lastUpdated.JPG, Date-GF96.JPG > > > In previous versions of Geode, Pulse used to show Dates in localized string, > now it's not. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Reopened] (GEODE-8696) Startup of JMX Manager may hang during crash of other members
[
https://issues.apache.org/jira/browse/GEODE-8696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk Lund reopened GEODE-8696:
--
> Startup of JMX Manager may hang during crash of other members
> -
>
> Key: GEODE-8696
> URL: https://issues.apache.org/jira/browse/GEODE-8696
> Project: Geode
> Issue Type: Bug
> Components: jmx, management
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>Priority: Major
> Labels: GeodeOperationAPI, pull-request-available
> Fix For: 1.14.0
>
>
> The fix for GEODE-7400 removed final from the executorService field to
> introduce a Supplier. I think this hang was caused by adding
> synchronized to FederatingManager.executeTask instead of making
> executorService a volatile field.
> _vm_3_thr_3_client2_host2_21145_ hung while synchronized on
> *0xf6316520*:
> {noformat}
> "vm_3_thr_3_client2_host2_21145" #56 daemon prio=5 os_prio=0
> tid=0x7f1854002000 nid=0x5326 waiting on condition [0x7f18520e2000]
>java.lang.Thread.State: WAITING (parking)
> at sun.misc.Unsafe.park(Native Method)
> - parking to wait for <0xf6364030> (a
> java.util.concurrent.FutureTask)
> at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)
> at java.util.concurrent.FutureTask.awaitDone(FutureTask.java:429)
> at java.util.concurrent.FutureTask.get(FutureTask.java:191)
> at
> java.util.concurrent.AbstractExecutorService.invokeAll(AbstractExecutorService.java:244)
> at
> org.apache.geode.management.internal.FederatingManager.startManagingActivity(FederatingManager.java:256)
> at
> org.apache.geode.management.internal.FederatingManager.startManager(FederatingManager.java:121)
> - locked <0xf6316520> (a
> org.apache.geode.management.internal.FederatingManager)
> at
> org.apache.geode.management.internal.SystemManagementService.startManager(SystemManagementService.java:373)
> - locked <0xfed91a70> (a java.util.HashMap)
> at
> org.apache.geode.management.internal.beans.ManagementAdapter.handleCacheCreation(ManagementAdapter.java:197)
> at
> org.apache.geode.management.internal.beans.ManagementListener.handleEvent(ManagementListener.java:127)
> at
> org.apache.geode.distributed.internal.InternalDistributedSystem.notifyResourceEventListeners(InternalDistributedSystem.java:2089)
> at
> org.apache.geode.distributed.internal.InternalDistributedSystem.handleResourceEvent(InternalDistributedSystem.java:643)
> at
> org.apache.geode.internal.cache.GemFireCacheImpl.initialize(GemFireCacheImpl.java:1363)
> at
> org.apache.geode.internal.cache.InternalCacheBuilder.create(InternalCacheBuilder.java:191)
> - locked <0xe11065f0> (a java.lang.Class for
> org.apache.geode.internal.cache.GemFireCacheImpl)
> - locked <0xe1101220> (a java.lang.Class for
> org.apache.geode.internal.cache.InternalCacheBuilder)
> at
> org.apache.geode.internal.cache.InternalCacheBuilder.create(InternalCacheBuilder.java:158)
> - locked <0xe1101220> (a java.lang.Class for
> org.apache.geode.internal.cache.InternalCacheBuilder)
> at org.apache.geode.cache.CacheFactory.create(CacheFactory.java:142)
> at
> hydra.CacheVersionHelper.configureAndCreateCache(CacheVersionHelper.java:51)
> at hydra.CacheHelper.createCacheWithHttpService(CacheHelper.java:127)
> - locked <0xfecab060> (a java.lang.Class for
> hydra.CacheHelper)
> at hydra.CacheHelper.createCache(CacheHelper.java:87)
> at
> splitBrain.NetworkPartitionTest.initialize(NetworkPartitionTest.java:293)
> at
> splitBrain.NetworkPartitionTest.initializeInstance(NetworkPartitionTest.java:228)
> - locked <0xe14a2db0> (a java.lang.Class for
> splitBrain.NetworkPartitionTest)
> at
> splitBrain.NetworkPartitionTest.HydraTask_initialize(NetworkPartitionTest.java:203)
> - locked <0xe14a2db0> (a java.lang.Class for
> splitBrain.NetworkPartitionTest)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at hydra.MethExecutor.execute(MethExecutor.java:173)
> at hydra.MethExecutor.execute(MethExecutor.java:141)
> at hydra.TestTask.execute(TestTask.java:197)
> at hydra.RemoteTestModule$1.run(RemoteTestModule.java:213)
> {noformat}
> _vm_3_thr_3_client2_host2_21145_ is waiting for _FederatingManager1_ to
> c
[jira] [Updated] (GEODE-8696) Startup of JMX Manager may hang during crash of other members
[
https://issues.apache.org/jira/browse/GEODE-8696?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Kirk Lund updated GEODE-8696:
-
Fix Version/s: (was: 1.14.0)
> Startup of JMX Manager may hang during crash of other members
> -
>
> Key: GEODE-8696
> URL: https://issues.apache.org/jira/browse/GEODE-8696
> Project: Geode
> Issue Type: Bug
> Components: jmx, management
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>Priority: Major
> Labels: GeodeOperationAPI, pull-request-available
>
> The fix for GEODE-7400 removed final from the executorService field to
> introduce a Supplier. I think this hang was caused by adding
> synchronized to FederatingManager.executeTask instead of making
> executorService a volatile field.
> _vm_3_thr_3_client2_host2_21145_ hung while synchronized on
> *0xf6316520*:
> {noformat}
> "vm_3_thr_3_client2_host2_21145" #56 daemon prio=5 os_prio=0
> tid=0x7f1854002000 nid=0x5326 waiting on condition [0x7f18520e2000]
>java.lang.Thread.State: WAITING (parking)
> at sun.misc.Unsafe.park(Native Method)
> - parking to wait for <0xf6364030> (a
> java.util.concurrent.FutureTask)
> at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)
> at java.util.concurrent.FutureTask.awaitDone(FutureTask.java:429)
> at java.util.concurrent.FutureTask.get(FutureTask.java:191)
> at
> java.util.concurrent.AbstractExecutorService.invokeAll(AbstractExecutorService.java:244)
> at
> org.apache.geode.management.internal.FederatingManager.startManagingActivity(FederatingManager.java:256)
> at
> org.apache.geode.management.internal.FederatingManager.startManager(FederatingManager.java:121)
> - locked <0xf6316520> (a
> org.apache.geode.management.internal.FederatingManager)
> at
> org.apache.geode.management.internal.SystemManagementService.startManager(SystemManagementService.java:373)
> - locked <0xfed91a70> (a java.util.HashMap)
> at
> org.apache.geode.management.internal.beans.ManagementAdapter.handleCacheCreation(ManagementAdapter.java:197)
> at
> org.apache.geode.management.internal.beans.ManagementListener.handleEvent(ManagementListener.java:127)
> at
> org.apache.geode.distributed.internal.InternalDistributedSystem.notifyResourceEventListeners(InternalDistributedSystem.java:2089)
> at
> org.apache.geode.distributed.internal.InternalDistributedSystem.handleResourceEvent(InternalDistributedSystem.java:643)
> at
> org.apache.geode.internal.cache.GemFireCacheImpl.initialize(GemFireCacheImpl.java:1363)
> at
> org.apache.geode.internal.cache.InternalCacheBuilder.create(InternalCacheBuilder.java:191)
> - locked <0xe11065f0> (a java.lang.Class for
> org.apache.geode.internal.cache.GemFireCacheImpl)
> - locked <0xe1101220> (a java.lang.Class for
> org.apache.geode.internal.cache.InternalCacheBuilder)
> at
> org.apache.geode.internal.cache.InternalCacheBuilder.create(InternalCacheBuilder.java:158)
> - locked <0xe1101220> (a java.lang.Class for
> org.apache.geode.internal.cache.InternalCacheBuilder)
> at org.apache.geode.cache.CacheFactory.create(CacheFactory.java:142)
> at
> hydra.CacheVersionHelper.configureAndCreateCache(CacheVersionHelper.java:51)
> at hydra.CacheHelper.createCacheWithHttpService(CacheHelper.java:127)
> - locked <0xfecab060> (a java.lang.Class for
> hydra.CacheHelper)
> at hydra.CacheHelper.createCache(CacheHelper.java:87)
> at
> splitBrain.NetworkPartitionTest.initialize(NetworkPartitionTest.java:293)
> at
> splitBrain.NetworkPartitionTest.initializeInstance(NetworkPartitionTest.java:228)
> - locked <0xe14a2db0> (a java.lang.Class for
> splitBrain.NetworkPartitionTest)
> at
> splitBrain.NetworkPartitionTest.HydraTask_initialize(NetworkPartitionTest.java:203)
> - locked <0xe14a2db0> (a java.lang.Class for
> splitBrain.NetworkPartitionTest)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at hydra.MethExecutor.execute(MethExecutor.java:173)
> at hydra.MethExecutor.execute(MethExecutor.java:141)
> at hydra.TestTask.execute(TestTask.java:197)
> at hydra.RemoteTestModule$1.run(RemoteTestModule.java:213)
> {noformat}
> _vm_3_thr_3_client2_host2_21145_ is waiting for _FederatingManager1_ to
[jira] [Commented] (GEODE-8696) Startup of JMX Manager may hang during crash of other members
[
https://issues.apache.org/jira/browse/GEODE-8696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17262878#comment-17262878
]
Kirk Lund commented on GEODE-8696:
--
I'm reverting and reopening GEODE-8696 because the fix causes a new 3-way
java-level deadlock:
{noformat}
Found one Java-level deadlock:
=
"Pooled High Priority Message Processor 5":
waiting to lock monitor 0x7f3ac400d558 (object 0xfd486c20, a
java.util.HashMap),
which is held by "vm_0_thr_0_locator_managing1_host1_13259"
"vm_0_thr_0_locator_managing1_host1_13259":
waiting for ownable synchronizer 0xfd2f3fb0, (a
java.util.concurrent.locks.ReentrantLock$NonfairSync),
which is held by "DM-MemberEventInvoker"
"DM-MemberEventInvoker":
waiting to lock monitor 0x7f3af8002d28 (object 0xfd3d12a8, a
org.apache.geode.management.internal.FederatingManager),
which is held by "vm_0_thr_0_locator_managing1_host1_13259"
{noformat}{noformat}
Java stack information for the threads listed above:
===
{noformat}{noformat}
"Pooled High Priority Message Processor 5":
at
org.apache.geode.management.internal.BaseManagementService.getExistingManagementService(BaseManagementService.java:106)
- waiting to lock <0xfd486c20> (a java.util.HashMap)
at
org.apache.geode.management.ManagementService.getExistingManagementService(ManagementService.java:52)
at
org.apache.geode.management.internal.JmxManagerAdvisee.fillInProfile(JmxManagerAdvisee.java:99)
at
org.apache.geode.distributed.internal.DistributionAdvisor.createProfile(DistributionAdvisor.java:1033)
at
org.apache.geode.management.internal.JmxManagerAdvisee.getProfile(JmxManagerAdvisee.java:65)
at
org.apache.geode.distributed.internal.DistributionAdvisor$Profile.handleDistributionAdvisee(DistributionAdvisor.java:1541)
at
org.apache.geode.management.internal.JmxManagerAdvisor$JmxManagerProfile.processIncoming(JmxManagerAdvisor.java:332)
at
org.apache.geode.internal.cache.UpdateAttributesProcessor$UpdateAttributesMessage.process(UpdateAttributesProcessor.java:291)
at
org.apache.geode.distributed.internal.DistributionMessage.scheduleAction(DistributionMessage.java:376)
at
org.apache.geode.distributed.internal.DistributionMessage$1.run(DistributionMessage.java:441)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
at
org.apache.geode.distributed.internal.ClusterOperationExecutors.runUntilShutdown(ClusterOperationExecutors.java:446)
at
org.apache.geode.distributed.internal.ClusterOperationExecutors.doHighPriorityThread(ClusterOperationExecutors.java:404)
at
org.apache.geode.distributed.internal.ClusterOperationExecutors$$Lambda$136/1646252585.invoke(Unknown
Source)
at
org.apache.geode.logging.internal.executors.LoggingThreadFactory.lambda$newThread$0(LoggingThreadFactory.java:120)
at
org.apache.geode.logging.internal.executors.LoggingThreadFactory$$Lambda$134/1613570844.run(Unknown
Source)
at java.lang.Thread.run(Thread.java:748)
{noformat}{noformat}
"vm_0_thr_0_locator_managing1_host1_13259":
at sun.misc.Unsafe.park(Native Method)
- parking to wait for <0xfd2f3fb0> (a
java.util.concurrent.locks.ReentrantLock$NonfairSync)
at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)
at
java.util.concurrent.locks.AbstractQueuedSynchronizer.parkAndCheckInterrupt(AbstractQueuedSynchronizer.java:836)
at
java.util.concurrent.locks.AbstractQueuedSynchronizer.acquireQueued(AbstractQueuedSynchronizer.java:870)
at
java.util.concurrent.locks.AbstractQueuedSynchronizer.acquire(AbstractQueuedSynchronizer.java:1199)
at
java.util.concurrent.locks.ReentrantLock$NonfairSync.lock(ReentrantLock.java:209)
at java.util.concurrent.locks.ReentrantLock.lock(ReentrantLock.java:285)
at
org.apache.geode.management.internal.FederatingManager.startManager(FederatingManager.java:134)
- locked <0xfd3d12a8> (a
org.apache.geode.management.internal.FederatingManager)
at
org.apache.geode.management.internal.SystemManagementService.startManager(SystemManagementService.java:373)
- locked <0xfd486c20> (a java.util.HashMap)
at
org.apache.geode.management.internal.beans.ManagementAdapter.handleCacheCreation(ManagementAdapter.java:199)
at
org.apache.geode.management.internal.beans.ManagementListener.handleEvent(ManagementListener.java:127)
at
org.apache.geode.distributed.internal.InternalDistributedSystem.notifyResourceEventListeners(InternalDistributedSystem.java:2086)
at
org.apache.geode.distributed.internal.InternalDistributedSystem.handleResourceEvent(InternalDistributedSystem.java:643)
at
org.apache.geode.internal.cache.GemFireCacheImpl.initialize(GemFireCacheImpl.java:1437)
at
org.apache.geode.interna
[jira] [Created] (GEODE-8825) CI failure: GatewayReceiverMBeanDUnitTest > testMBeanAndProxiesForGatewayReceiverAreRemovedOnDestroy
Jianxia Chen created GEODE-8825:
---
Summary: CI failure: GatewayReceiverMBeanDUnitTest >
testMBeanAndProxiesForGatewayReceiverAreRemovedOnDestroy
Key: GEODE-8825
URL: https://issues.apache.org/jira/browse/GEODE-8825
Project: Geode
Issue Type: Bug
Reporter: Jianxia Chen
{code:java}
org.apache.geode.internal.cache.wan.GatewayReceiverMBeanDUnitTest >
testMBeanAndProxiesForGatewayReceiverAreRemovedOnDestroy FAILED
org.apache.geode.test.dunit.RMIException: While invoking
org.apache.geode.internal.cache.wan.GatewayReceiverMBeanDUnitTest$$Lambda$202/0x0001008f0c40.run
in VM 0 running on Host c3e48bdac460 with 4 VMs
at org.apache.geode.test.dunit.VM.executeMethodOnObject(VM.java:623)
at org.apache.geode.test.dunit.VM.invoke(VM.java:447)
at
org.apache.geode.internal.cache.wan.GatewayReceiverMBeanDUnitTest.testMBeanAndProxiesForGatewayReceiverAreRemovedOnDestroy(GatewayReceiverMBeanDUnitTest.java:76)
Caused by:
java.lang.AssertionError: expected null, but was:-41002>
at org.junit.Assert.fail(Assert.java:89)
at org.junit.Assert.failNotNull(Assert.java:756)
at org.junit.Assert.assertNull(Assert.java:738)
at org.junit.Assert.assertNull(Assert.java:748)
at
org.apache.geode.internal.cache.wan.GatewayReceiverMBeanDUnitTest.verifyMBeanProxiesDoesNotExist(GatewayReceiverMBeanDUnitTest.java:106)
at
org.apache.geode.internal.cache.wan.GatewayReceiverMBeanDUnitTest.lambda$testMBeanAndProxiesForGatewayReceiverAreRemovedOnDestroy$bb17a952$3(GatewayReceiverMBeanDUnitTest.java:76)
{code}
https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK11/builds/704
=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0601/test-results/distributedTest/1610390301/
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Test report artifacts from this job are available at:
http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0601/test-artifacts/1610390301/distributedtestfiles-OpenJDK11-1.14.0-build.0601.tgz
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8825) CI failure: GatewayReceiverMBeanDUnitTest > testMBeanAndProxiesForGatewayReceiverAreRemovedOnDestroy
[
https://issues.apache.org/jira/browse/GEODE-8825?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17262879#comment-17262879
]
Geode Integration commented on GEODE-8825:
--
Seen in [DistributedTestOpenJDK11
#704|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK11/builds/704]
... see [test
results|http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0601/test-results/distributedTest/1610390301/]
or download
[artifacts|http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0601/test-artifacts/1610390301/distributedtestfiles-OpenJDK11-1.14.0-build.0601.tgz].
> CI failure: GatewayReceiverMBeanDUnitTest >
> testMBeanAndProxiesForGatewayReceiverAreRemovedOnDestroy
>
>
> Key: GEODE-8825
> URL: https://issues.apache.org/jira/browse/GEODE-8825
> Project: Geode
> Issue Type: Bug
>Reporter: Jianxia Chen
>Priority: Major
>
> {code:java}
> org.apache.geode.internal.cache.wan.GatewayReceiverMBeanDUnitTest >
> testMBeanAndProxiesForGatewayReceiverAreRemovedOnDestroy FAILED
> org.apache.geode.test.dunit.RMIException: While invoking
> org.apache.geode.internal.cache.wan.GatewayReceiverMBeanDUnitTest$$Lambda$202/0x0001008f0c40.run
> in VM 0 running on Host c3e48bdac460 with 4 VMs
> at org.apache.geode.test.dunit.VM.executeMethodOnObject(VM.java:623)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:447)
> at
> org.apache.geode.internal.cache.wan.GatewayReceiverMBeanDUnitTest.testMBeanAndProxiesForGatewayReceiverAreRemovedOnDestroy(GatewayReceiverMBeanDUnitTest.java:76)
> Caused by:
> java.lang.AssertionError: expected null, but was: GemFire:service=GatewayReceiver,type=Member,member=172.17.0.18(183)-41002>
> at org.junit.Assert.fail(Assert.java:89)
> at org.junit.Assert.failNotNull(Assert.java:756)
> at org.junit.Assert.assertNull(Assert.java:738)
> at org.junit.Assert.assertNull(Assert.java:748)
> at
> org.apache.geode.internal.cache.wan.GatewayReceiverMBeanDUnitTest.verifyMBeanProxiesDoesNotExist(GatewayReceiverMBeanDUnitTest.java:106)
> at
> org.apache.geode.internal.cache.wan.GatewayReceiverMBeanDUnitTest.lambda$testMBeanAndProxiesForGatewayReceiverAreRemovedOnDestroy$bb17a952$3(GatewayReceiverMBeanDUnitTest.java:76)
> {code}
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK11/builds/704
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0601/test-results/distributedTest/1610390301/
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> Test report artifacts from this job are available at:
> http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0601/test-artifacts/1610390301/distributedtestfiles-OpenJDK11-1.14.0-build.0601.tgz
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8696) Startup of JMX Manager may hang during crash of other members
[
https://issues.apache.org/jira/browse/GEODE-8696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17262882#comment-17262882
]
ASF GitHub Bot commented on GEODE-8696:
---
kirklund opened a new pull request #5892:
URL: https://github.com/apache/geode/pull/5892
This reverts commit 42726bd99c9ebb57ec5d3e987d47ecae9f4ea3a7.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Startup of JMX Manager may hang during crash of other members
> -
>
> Key: GEODE-8696
> URL: https://issues.apache.org/jira/browse/GEODE-8696
> Project: Geode
> Issue Type: Bug
> Components: jmx, management
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>Priority: Major
> Labels: GeodeOperationAPI, pull-request-available
>
> The fix for GEODE-7400 removed final from the executorService field to
> introduce a Supplier. I think this hang was caused by adding
> synchronized to FederatingManager.executeTask instead of making
> executorService a volatile field.
> _vm_3_thr_3_client2_host2_21145_ hung while synchronized on
> *0xf6316520*:
> {noformat}
> "vm_3_thr_3_client2_host2_21145" #56 daemon prio=5 os_prio=0
> tid=0x7f1854002000 nid=0x5326 waiting on condition [0x7f18520e2000]
>java.lang.Thread.State: WAITING (parking)
> at sun.misc.Unsafe.park(Native Method)
> - parking to wait for <0xf6364030> (a
> java.util.concurrent.FutureTask)
> at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)
> at java.util.concurrent.FutureTask.awaitDone(FutureTask.java:429)
> at java.util.concurrent.FutureTask.get(FutureTask.java:191)
> at
> java.util.concurrent.AbstractExecutorService.invokeAll(AbstractExecutorService.java:244)
> at
> org.apache.geode.management.internal.FederatingManager.startManagingActivity(FederatingManager.java:256)
> at
> org.apache.geode.management.internal.FederatingManager.startManager(FederatingManager.java:121)
> - locked <0xf6316520> (a
> org.apache.geode.management.internal.FederatingManager)
> at
> org.apache.geode.management.internal.SystemManagementService.startManager(SystemManagementService.java:373)
> - locked <0xfed91a70> (a java.util.HashMap)
> at
> org.apache.geode.management.internal.beans.ManagementAdapter.handleCacheCreation(ManagementAdapter.java:197)
> at
> org.apache.geode.management.internal.beans.ManagementListener.handleEvent(ManagementListener.java:127)
> at
> org.apache.geode.distributed.internal.InternalDistributedSystem.notifyResourceEventListeners(InternalDistributedSystem.java:2089)
> at
> org.apache.geode.distributed.internal.InternalDistributedSystem.handleResourceEvent(InternalDistributedSystem.java:643)
> at
> org.apache.geode.internal.cache.GemFireCacheImpl.initialize(GemFireCacheImpl.java:1363)
> at
> org.apache.geode.internal.cache.InternalCacheBuilder.create(InternalCacheBuilder.java:191)
> - locked <0xe11065f0> (a java.lang.Class for
> org.apache.geode.internal.cache.GemFireCacheImpl)
> - locked <0xe1101220> (a java.lang.Class for
> org.apache.geode.internal.cache.InternalCacheBuilder)
> at
> org.apache.geode.internal.cache.InternalCacheBuilder.create(InternalCacheBuilder.java:158)
> - locked <0xe1101220> (a java.lang.Class for
> org.apache.geode.internal.cache.InternalCacheBuilder)
> at org.apache.geode.cache.CacheFactory.create(CacheFactory.java:142)
> at
> hydra.CacheVersionHelper.configureAndCreateCache(CacheVersionHelper.java:51)
> at hydra.CacheHelper.createCacheWithHttpService(CacheHelper.java:127)
> - locked <0xfecab060> (a java.lang.Class for
> hydra.CacheHelper)
> at hydra.CacheHelper.createCache(CacheHelper.java:87)
> at
> splitBrain.NetworkPartitionTest.initialize(NetworkPartitionTest.java:293)
> at
> splitBrain.NetworkPartitionTest.initializeInstance(NetworkPartitionTest.java:228)
> - locked <0xe14a2db0> (a java.lang.Class for
> splitBrain.NetworkPartitionTest)
> at
> splitBrain.NetworkPartitionTest.HydraTask_initialize(NetworkPartitionTest.java:203)
> - locked <0xe14a2db0> (a java.lang.Class for
> splitBrain.NetworkPartitionTest)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.
[jira] [Commented] (GEODE-8447) Pulse should localize “java.util.Date” in the displayed query result
[
https://issues.apache.org/jira/browse/GEODE-8447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17262901#comment-17262901
]
ASF GitHub Bot commented on GEODE-8447:
---
kirklund commented on a change in pull request #5891:
URL: https://github.com/apache/geode/pull/5891#discussion_r555292554
##
File path:
geode-core/src/test/java/org/apache/geode/management/internal/json/QueryResultFormatterTest.java
##
@@ -119,16 +120,20 @@ public void testPrimitives() throws Exception {
QueryResultFormatter stringResult = new
QueryResultFormatter(100).add(RESULT, "String");
checkResult(stringResult,
"{\"result\":[[\"java.lang.String\",\"String\"]]}");
+ }
-Date date = new Date(0);
-String expectedString =
-new
SimpleDateFormat(QueryResultFormatter.DATE_FORMAT_PATTERN).format(date);
+ @Test
+ public void testDateTimes() throws Exception {
+long time = System.currentTimeMillis();
+Date date = new Date(time);
+SimpleDateFormat format = DateFormatter.createLocalizedDateFormat();
+String expectedString = format.format(date);
QueryResultFormatter javaDateResult =
new QueryResultFormatter(100).add(RESULT, date);
checkResult(javaDateResult,
"{\"result\":[[\"java.util.Date\",\"" + expectedString + "\"]]}");
-java.sql.Date sqlDate = new java.sql.Date(0);
+java.sql.Date sqlDate = new java.sql.Date(time);
Review comment:
This is probably another old bug, but I'm fairly certain that
`java.sql.Date` should be replaced by `java.util.Date`. The sql version should
only be used with JDBC.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Pulse should localize “java.util.Date” in the displayed query result
>
>
> Key: GEODE-8447
> URL: https://issues.apache.org/jira/browse/GEODE-8447
> Project: Geode
> Issue Type: Bug
> Components: management
>Affects Versions: 1.12.0
>Reporter: Jinmei Liao
>Assignee: Jinmei Liao
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.12.1, 1.14.0, 1.13.1
>
> Attachments: CreatedOn-lastUpdated.JPG, Date-GF96.JPG
>
>
> In previous versions of Geode, Pulse used to show Dates in localized string,
> now it's not.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8447) Pulse should localize “java.util.Date” in the displayed query result
[
https://issues.apache.org/jira/browse/GEODE-8447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17262904#comment-17262904
]
ASF GitHub Bot commented on GEODE-8447:
---
jinmeiliao commented on a change in pull request #5891:
URL: https://github.com/apache/geode/pull/5891#discussion_r555294957
##
File path:
geode-core/src/test/java/org/apache/geode/management/internal/json/QueryResultFormatterTest.java
##
@@ -119,16 +120,20 @@ public void testPrimitives() throws Exception {
QueryResultFormatter stringResult = new
QueryResultFormatter(100).add(RESULT, "String");
checkResult(stringResult,
"{\"result\":[[\"java.lang.String\",\"String\"]]}");
+ }
-Date date = new Date(0);
-String expectedString =
-new
SimpleDateFormat(QueryResultFormatter.DATE_FORMAT_PATTERN).format(date);
+ @Test
+ public void testDateTimes() throws Exception {
+long time = System.currentTimeMillis();
+Date date = new Date(time);
+SimpleDateFormat format = DateFormatter.createLocalizedDateFormat();
+String expectedString = format.format(date);
QueryResultFormatter javaDateResult =
new QueryResultFormatter(100).add(RESULT, date);
checkResult(javaDateResult,
"{\"result\":[[\"java.util.Date\",\"" + expectedString + "\"]]}");
-java.sql.Date sqlDate = new java.sql.Date(0);
+java.sql.Date sqlDate = new java.sql.Date(time);
Review comment:
This test is only to make sure our QueryResultFormatter can format
`java.sql.Date` object. It's used to format customer region data, they could
use any date time object.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Pulse should localize “java.util.Date” in the displayed query result
>
>
> Key: GEODE-8447
> URL: https://issues.apache.org/jira/browse/GEODE-8447
> Project: Geode
> Issue Type: Bug
> Components: management
>Affects Versions: 1.12.0
>Reporter: Jinmei Liao
>Assignee: Jinmei Liao
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.12.1, 1.14.0, 1.13.1
>
> Attachments: CreatedOn-lastUpdated.JPG, Date-GF96.JPG
>
>
> In previous versions of Geode, Pulse used to show Dates in localized string,
> now it's not.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8696) Startup of JMX Manager may hang during crash of other members
[
https://issues.apache.org/jira/browse/GEODE-8696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17262908#comment-17262908
]
ASF GitHub Bot commented on GEODE-8696:
---
kirklund opened a new pull request #5893:
URL: https://github.com/apache/geode/pull/5893
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Startup of JMX Manager may hang during crash of other members
> -
>
> Key: GEODE-8696
> URL: https://issues.apache.org/jira/browse/GEODE-8696
> Project: Geode
> Issue Type: Bug
> Components: jmx, management
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>Priority: Major
> Labels: GeodeOperationAPI, pull-request-available
>
> The fix for GEODE-7400 removed final from the executorService field to
> introduce a Supplier. I think this hang was caused by adding
> synchronized to FederatingManager.executeTask instead of making
> executorService a volatile field.
> _vm_3_thr_3_client2_host2_21145_ hung while synchronized on
> *0xf6316520*:
> {noformat}
> "vm_3_thr_3_client2_host2_21145" #56 daemon prio=5 os_prio=0
> tid=0x7f1854002000 nid=0x5326 waiting on condition [0x7f18520e2000]
>java.lang.Thread.State: WAITING (parking)
> at sun.misc.Unsafe.park(Native Method)
> - parking to wait for <0xf6364030> (a
> java.util.concurrent.FutureTask)
> at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)
> at java.util.concurrent.FutureTask.awaitDone(FutureTask.java:429)
> at java.util.concurrent.FutureTask.get(FutureTask.java:191)
> at
> java.util.concurrent.AbstractExecutorService.invokeAll(AbstractExecutorService.java:244)
> at
> org.apache.geode.management.internal.FederatingManager.startManagingActivity(FederatingManager.java:256)
> at
> org.apache.geode.management.internal.FederatingManager.startManager(FederatingManager.java:121)
> - locked <0xf6316520> (a
> org.apache.geode.management.internal.FederatingManager)
> at
> org.apache.geode.management.internal.SystemManagementService.startManager(SystemManagementService.java:373)
> - locked <0xfed91a70> (a java.util.HashMap)
> at
> org.apache.geode.management.internal.beans.ManagementAdapter.handleCacheCreation(ManagementAdapter.java:197)
> at
> org.apache.geode.management.internal.beans.ManagementListener.handleEvent(ManagementListener.java:127)
> at
> org.apache.geode.distributed.internal.InternalDistributedSystem.notifyResourceEventListeners(InternalDistributedSystem.java:2089)
> at
> org.apache.geode.distributed.internal.InternalDistributedSystem.handleResourceEvent(InternalDistributedSystem.java:643)
> at
> org.apache.geode.internal.cache.GemFireCacheImpl.initialize(GemFireCacheImpl.java:1363)
> at
> org.apache.geode.internal.cache.InternalCacheBuilder.create(InternalCacheBuilder.java:191)
> - locked <0xe11065f0> (a java.lang.Class for
> org.apache.geode.internal.cache.GemFireCacheImpl)
> - locked <0xe1101220> (a java.lang.Class for
> org.apache.geode.internal.cache.InternalCacheBuilder)
> at
> org.apache.geode.internal.cache.InternalCacheBuilder.create(InternalCacheBuilder.java:158)
> - locked <0xe1101220> (a java.lang.Class for
> org.apache.geode.internal.cache.InternalCacheBuilder)
> at org.apache.geode.cache.CacheFactory.create(CacheFactory.java:142)
> at
> hydra.CacheVersionHelper.configureAndCreateCache(CacheVersionHelper.java:51)
> at hydra.CacheHelper.createCacheWithHttpService(CacheHelper.java:127)
> - locked <0xfecab060> (a java.lang.Class for
> hydra.CacheHelper)
> at hydra.CacheHelper.createCache(CacheHelper.java:87)
> at
> splitBrain.NetworkPartitionTest.initialize(NetworkPartitionTest.java:293)
> at
> splitBrain.NetworkPartitionTest.initializeInstance(NetworkPartitionTest.java:228)
> - locked <0xe14a2db0> (a java.lang.Class for
> splitBrain.NetworkPartitionTest)
> at
> splitBrain.NetworkPartitionTest.HydraTask_initialize(NetworkPartitionTest.java:203)
> - locked <0xe14a2db0> (a java.lang.Class for
> splitBrain.NetworkPartitionTest)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at
> sun.reflect.DelegatingMethodAccessorImpl
[jira] [Commented] (GEODE-8447) Pulse should localize “java.util.Date” in the displayed query result
[
https://issues.apache.org/jira/browse/GEODE-8447?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17262923#comment-17262923
]
ASF GitHub Bot commented on GEODE-8447:
---
jchen21 commented on a change in pull request #5891:
URL: https://github.com/apache/geode/pull/5891#discussion_r555323938
##
File path:
geode-core/src/test/java/org/apache/geode/management/internal/json/QueryResultFormatterTest.java
##
@@ -119,16 +120,20 @@ public void testPrimitives() throws Exception {
QueryResultFormatter stringResult = new
QueryResultFormatter(100).add(RESULT, "String");
checkResult(stringResult,
"{\"result\":[[\"java.lang.String\",\"String\"]]}");
+ }
-Date date = new Date(0);
-String expectedString =
-new
SimpleDateFormat(QueryResultFormatter.DATE_FORMAT_PATTERN).format(date);
+ @Test
+ public void testDateTimes() throws Exception {
+long time = System.currentTimeMillis();
+Date date = new Date(time);
+SimpleDateFormat format = DateFormatter.createLocalizedDateFormat();
+String expectedString = format.format(date);
QueryResultFormatter javaDateResult =
new QueryResultFormatter(100).add(RESULT, date);
checkResult(javaDateResult,
"{\"result\":[[\"java.util.Date\",\"" + expectedString + "\"]]}");
-java.sql.Date sqlDate = new java.sql.Date(0);
+java.sql.Date sqlDate = new java.sql.Date(time);
Review comment:
The query result can contain either `java.util.Date` or `java.sql.Date`.
`java.util.Date` is tested in line 133.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Pulse should localize “java.util.Date” in the displayed query result
>
>
> Key: GEODE-8447
> URL: https://issues.apache.org/jira/browse/GEODE-8447
> Project: Geode
> Issue Type: Bug
> Components: management
>Affects Versions: 1.12.0
>Reporter: Jinmei Liao
>Assignee: Jinmei Liao
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.12.1, 1.14.0, 1.13.1
>
> Attachments: CreatedOn-lastUpdated.JPG, Date-GF96.JPG
>
>
> In previous versions of Geode, Pulse used to show Dates in localized string,
> now it's not.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (GEODE-8719) CI Failure: org.apache.geode.redis.internal.executor.CrashAndNoRepeatDUnitTest > givenServerCrashesDuringAPPEND_thenDataIsNotLost
[
https://issues.apache.org/jira/browse/GEODE-8719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Deppe reassigned GEODE-8719:
-
Assignee: Jens Deppe (was: John Hutchison)
> CI Failure:
> org.apache.geode.redis.internal.executor.CrashAndNoRepeatDUnitTest >
> givenServerCrashesDuringAPPEND_thenDataIsNotLost
> -
>
> Key: GEODE-8719
> URL: https://issues.apache.org/jira/browse/GEODE-8719
> Project: Geode
> Issue Type: Bug
> Components: redis
>Reporter: Sarah Abbey
>Assignee: Jens Deppe
>Priority: Minor
>
> CI failure: https://concourse.apachegeode-ci.info/builds/207449
> {code:java}
> org.apache.geode.redis.internal.executor.CrashAndNoRepeatDUnitTest >
> givenServerCrashesDuringAPPEND_thenDataIsNotLost FAILED
> org.apache.geode.test.dunit.RMIException: While invoking
> org.apache.geode.test.dunit.internal.IdentifiableCallable.call in VM 2
> running on Host e0e2f6af9445 with 4 VMs
> at org.apache.geode.test.dunit.VM.executeMethodOnObject(VM.java:623)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:460)
> at
> org.apache.geode.test.dunit.rules.ClusterStartupRule.startServerVM(ClusterStartupRule.java:268)
> at
> org.apache.geode.test.dunit.rules.ClusterStartupRule.startServerVM(ClusterStartupRule.java:261)
> at
> org.apache.geode.redis.internal.executor.CrashAndNoRepeatDUnitTest.startRedisVM(CrashAndNoRepeatDUnitTest.java:131)
> at
> org.apache.geode.redis.internal.executor.CrashAndNoRepeatDUnitTest.givenServerCrashesDuringAPPEND_thenDataIsNotLost(CrashAndNoRepeatDUnitTest.java:164)
> Caused by:
> org.apache.geode.management.ManagementException: Could not start
> Redis Server using bind address: localhost/127.0.0.1 and port: 44579. Please
> make sure nothing else is running on this address/port combination.
> Caused by:
> java.net.BindException: Address already in use
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8806) Native client does not honor log-file-size-limit properly
[
https://issues.apache.org/jira/browse/GEODE-8806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17262937#comment-17262937
]
ASF GitHub Bot commented on GEODE-8806:
---
pdxcodemonkey commented on a change in pull request #718:
URL: https://github.com/apache/geode-native/pull/718#discussion_r555344911
##
File path: cppcache/src/Log.cpp
##
@@ -502,178 +351,77 @@ LogLevel Log::charsToLevel(const std::string& chars) {
}
}
-char* Log::formatLogLine(char* buf, LogLevel level) {
- if (g_pid == 0) {
-g_pid = boost::this_process::get_id();
-ACE_OS::uname(&g_uname);
- }
+std::string Log::formatLogLine(LogLevel level) {
+ std::stringstream msg;
const size_t MINBUFSIZE = 128;
auto now = std::chrono::system_clock::now();
auto secs = std::chrono::system_clock::to_time_t(now);
auto microseconds = std::chrono::duration_cast(
now - std::chrono::system_clock::from_time_t(secs));
auto tm_val = apache::geode::util::chrono::localtime(secs);
- auto pbuf = buf;
- pbuf += std::snprintf(pbuf, 15, "[%s ", Log::levelToChars(level));
- pbuf += std::strftime(pbuf, MINBUFSIZE, "%Y/%m/%d %H:%M:%S", &tm_val);
- pbuf += std::snprintf(pbuf, 15, ".%06" PRId64 " ",
-static_cast(microseconds.count()));
- pbuf += std::strftime(pbuf, MINBUFSIZE, "%Z ", &tm_val);
+ msg << "[" << Log::levelToChars(level) << " ";
+ char timebuf[MINBUFSIZE];
- std::snprintf(pbuf, 300, "%s:%d %" PRIu64 "] ", g_uname.nodename, g_pid,
-hacks::aceThreadId(ACE_OS::thr_self()));
+ std::strftime(timebuf, MINBUFSIZE, "%Y/%m/%d %H:%M:%S", &tm_val);
+ msg << timebuf;
- return buf;
-}
+ std::snprintf(timebuf, 15, ".%06" PRId64 " ",
+static_cast(microseconds.count()));
+ msg << timebuf << " ";
-void Log::put(LogLevel level, const std::string& msg) {
- put(level, msg.c_str());
+ std::strftime(timebuf, MINBUFSIZE, "%Z ", &tm_val);
+ msg << timebuf << " " << boost::asio::ip::host_name() << ":"
Review comment:
Cached g_hostName string. Didn't read the fine print here and implement
an accessor, but I think we're okay as is.
##
File path: cppcache/src/Log.cpp
##
@@ -502,178 +351,77 @@ LogLevel Log::charsToLevel(const std::string& chars) {
}
}
-char* Log::formatLogLine(char* buf, LogLevel level) {
- if (g_pid == 0) {
-g_pid = boost::this_process::get_id();
-ACE_OS::uname(&g_uname);
- }
+std::string Log::formatLogLine(LogLevel level) {
+ std::stringstream msg;
const size_t MINBUFSIZE = 128;
auto now = std::chrono::system_clock::now();
auto secs = std::chrono::system_clock::to_time_t(now);
auto microseconds = std::chrono::duration_cast(
now - std::chrono::system_clock::from_time_t(secs));
auto tm_val = apache::geode::util::chrono::localtime(secs);
- auto pbuf = buf;
- pbuf += std::snprintf(pbuf, 15, "[%s ", Log::levelToChars(level));
- pbuf += std::strftime(pbuf, MINBUFSIZE, "%Y/%m/%d %H:%M:%S", &tm_val);
- pbuf += std::snprintf(pbuf, 15, ".%06" PRId64 " ",
-static_cast(microseconds.count()));
- pbuf += std::strftime(pbuf, MINBUFSIZE, "%Z ", &tm_val);
+ msg << "[" << Log::levelToChars(level) << " ";
+ char timebuf[MINBUFSIZE];
- std::snprintf(pbuf, 300, "%s:%d %" PRIu64 "] ", g_uname.nodename, g_pid,
-hacks::aceThreadId(ACE_OS::thr_self()));
+ std::strftime(timebuf, MINBUFSIZE, "%Y/%m/%d %H:%M:%S", &tm_val);
+ msg << timebuf;
- return buf;
-}
+ std::snprintf(timebuf, 15, ".%06" PRId64 " ",
Review comment:
Done.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Native client does not honor log-file-size-limit properly
> -
>
> Key: GEODE-8806
> URL: https://issues.apache.org/jira/browse/GEODE-8806
> Project: Geode
> Issue Type: Bug
> Components: native client
>Reporter: Blake Bender
>Priority: Major
> Labels: pull-request-available
>
> As a user, I need to be able to limit the size of my log files and the amount
> of disk space used by geode-native. Unfortunately, the 10.x native client
> doesn't appear to "roll" log files correctly.
>
> repro steps:
> i. In a client application, set `log-file-size-limit` to 1 (for 1MB),
> `log-level` to `debug`, and `log-file` to something convenient like
> `native_app.log`
> ii. Run a long operation in the client that will generate a huge amount of
> logging, like 100,000 puts to a region
>
> expected behavior:
> * when native_app.log grows to > 1MB in size, it is follow
[jira] [Commented] (GEODE-8806) Native client does not honor log-file-size-limit properly
[
https://issues.apache.org/jira/browse/GEODE-8806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17262939#comment-17262939
]
ASF GitHub Bot commented on GEODE-8806:
---
pdxcodemonkey commented on a change in pull request #718:
URL: https://github.com/apache/geode-native/pull/718#discussion_r555347162
##
File path: cppcache/integration/test/CacheXmlTest.cpp
##
@@ -44,8 +44,7 @@ apache::geode::client::Cache createCacheUsingXmlConfig(
CacheFactory cacheFactory;
- auto cache = cacheFactory.set("log-level", "debug")
- .set("log-file", "geode_native.log")
+ auto cache = cacheFactory.set("log-level", "none")
.set("statistic-sampling-enabled", "false")
.set("cache-xml-file", xmlFile.c_str())
Review comment:
Fixed
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Native client does not honor log-file-size-limit properly
> -
>
> Key: GEODE-8806
> URL: https://issues.apache.org/jira/browse/GEODE-8806
> Project: Geode
> Issue Type: Bug
> Components: native client
>Reporter: Blake Bender
>Priority: Major
> Labels: pull-request-available
>
> As a user, I need to be able to limit the size of my log files and the amount
> of disk space used by geode-native. Unfortunately, the 10.x native client
> doesn't appear to "roll" log files correctly.
>
> repro steps:
> i. In a client application, set `log-file-size-limit` to 1 (for 1MB),
> `log-level` to `debug`, and `log-file` to something convenient like
> `native_app.log`
> ii. Run a long operation in the client that will generate a huge amount of
> logging, like 100,000 puts to a region
>
> expected behavior:
> * when native_app.log grows to > 1MB in size, it is followed by
> native_app-1.log, native_app-2.log, etc, each of which is ~1MB in size
> actual behavior:
> * native_app.log grows to > 1MB, then geode-native stops logging
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (GEODE-8786) INFO command hit/miss ratios should match native Redis
[ https://issues.apache.org/jira/browse/GEODE-8786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Helena Bales reassigned GEODE-8786: --- Assignee: Helena Bales > INFO command hit/miss ratios should match native Redis > -- > > Key: GEODE-8786 > URL: https://issues.apache.org/jira/browse/GEODE-8786 > Project: Geode > Issue Type: Bug > Components: redis >Affects Versions: 1.14.0 >Reporter: Raymond Ingles >Assignee: Helena Bales >Priority: Major > Labels: pull-request-available > > Current hit/miss ratios for Geode Redis stats do not match those for native > Redis. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-8786) INFO command hit/miss ratios should match native Redis
[ https://issues.apache.org/jira/browse/GEODE-8786?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Helena Bales resolved GEODE-8786. - Fix Version/s: 1.14.0 Resolution: Fixed > INFO command hit/miss ratios should match native Redis > -- > > Key: GEODE-8786 > URL: https://issues.apache.org/jira/browse/GEODE-8786 > Project: Geode > Issue Type: Bug > Components: redis >Affects Versions: 1.14.0 >Reporter: Raymond Ingles >Assignee: Helena Bales >Priority: Major > Labels: pull-request-available > Fix For: 1.14.0 > > > Current hit/miss ratios for Geode Redis stats do not match those for native > Redis. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8806) Native client does not honor log-file-size-limit properly
[
https://issues.apache.org/jira/browse/GEODE-8806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17262943#comment-17262943
]
ASF GitHub Bot commented on GEODE-8806:
---
pivotal-jbarrett commented on a change in pull request #718:
URL: https://github.com/apache/geode-native/pull/718#discussion_r555354528
##
File path: cppcache/src/LocalRegion.cpp
##
@@ -717,7 +717,7 @@ void LocalRegion::registerEntryExpiryTask(
new EntryExpiryHandler(rptr, entry, getEntryExpirationAction(),
duration);
auto id = rptr->getCacheImpl()->getExpiryTaskManager().scheduleExpiryTask(
handler, duration, std::chrono::seconds::zero());
- if (Log::finestEnabled()) {
+ if (Log::logLevel() >= LogLevel::Finest) {
Review comment:
I am sort of indifferent on this change but the original was more
closely aligned with the Java based logger API. This change requires you to
know that log levels have order.
##
File path: clicache/src/Log.cpp
##
@@ -70,12 +70,6 @@ namespace Apache
static_cast(level));
}
- bool Log::Enabled(LogLevel level)
Review comment:
Doesn't this change the public API of the .NET library?
##
File path: cppcache/src/util/Log.hpp
##
@@ -182,315 +183,69 @@ class APACHE_GEODE_EXPORT Log {
* When invoking from outside either should have been invoked,
* or at least the first invocation should be single-threaded.
*/
- static char* formatLogLine(char* buf, LogLevel level);
-
- /**
- * Returns whether log messages at given level are enabled.
- */
- static bool enabled(LogLevel level);
-
- /**
- * Logs a message at given level.
- */
- static void log(LogLevel level, const char* msg);
-
- /**
- * Logs both a message and thrown exception.
- */
- static void logThrow(LogLevel level, const char* msg, const Exception& ex);
-
- /**
- * Logs both a message and caught exception.
- */
- static void logCatch(LogLevel level, const char* msg, const Exception& ex);
-
- /**
- * Returns whether "error" log messages are enabled.
- */
- static bool errorEnabled();
-
- /**
- * Logs a message.
- * The message level is "error".
- */
- static void error(const char* msg);
-
- static void error(const std::string& msg);
-
- /**
- * Logs both a message and thrown exception.
- * The message level is "error".
- */
- static void errorThrow(const char* msg, const Exception& ex);
-
- /**
- * Writes both a message and caught exception.
- * The message level is "error".
- */
- static void errorCatch(const char* msg, const Exception& ex);
-
- /**
- * Returns whether "warning" log messages are enabled.
- */
- static bool warningEnabled();
-
- /**
- * Logs a message.
- * The message level is "warning".
- */
- static void warning(const char* msg);
-
- /**
- * Logs both a message and thrown exception.
- * The message level is "warning".
- */
- static void warningThrow(const char* msg, const Exception& ex);
-
- /**
- * Writes both a message and caught exception.
- * The message level is "warning".
- */
- static void warningCatch(const char* msg, const Exception& ex);
-
- /**
- * Returns whether "info" log messages are enabled.
- */
- static bool infoEnabled();
-
- /**
- * Logs a message.
- * The message level is "info".
- */
- static void info(const char* msg);
-
- /**
- * Logs both a message and thrown exception.
- * The message level is "info".
- */
- static void infoThrow(const char* msg, const Exception& ex);
-
- /**
- * Writes both a message and caught exception.
- * The message level is "info".
- */
- static void infoCatch(const char* msg, const Exception& ex);
-
- /**
- * Returns whether "config" log messages are enabled.
- */
- static bool configEnabled();
-
- /**
- * Logs a message.
- * The message level is "config".
- */
- static void config(const char* msg);
-
- /**
- * Logs both a message and thrown exception.
- * The message level is "config".
- */
- static void configThrow(const char* msg, const Exception& ex);
-
- /**
- * Writes both a message and caught exception.
- * The message level is "config".
- */
- static void configCatch(const char* msg, const Exception& ex);
-
- /**
- * Returns whether "fine" log messages are enabled.
- */
- static bool fineEnabled();
-
- /**
- * Logs a message.
- * The message level is "fine".
- */
- static void fine(const char* msg);
-
- /**
- * Logs both a message and thrown exception.
- * The message level is "fine".
- */
- static void fineThrow(const char* msg, const Exception& ex);
-
- /**
- * Writes both a message and caught exception.
- * The message level is "fine".
- */
- static void fineCatch(const char* msg, const Exception& ex);
-
- /**
- * Returns whether "finer" log messages are enabled.
- */
- static bool finerEnabled();
-
-
[jira] [Commented] (GEODE-8806) Native client does not honor log-file-size-limit properly
[ https://issues.apache.org/jira/browse/GEODE-8806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17262946#comment-17262946 ] ASF GitHub Bot commented on GEODE-8806: --- pdxcodemonkey commented on a change in pull request #718: URL: https://github.com/apache/geode-native/pull/718#discussion_r555358952 ## File path: clicache/src/Log.cpp ## @@ -70,12 +70,6 @@ namespace Apache static_cast(level)); } - bool Log::Enabled(LogLevel level) Review comment: Maybe? I'll have a look. Easy enough to fix, if so. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Native client does not honor log-file-size-limit properly > - > > Key: GEODE-8806 > URL: https://issues.apache.org/jira/browse/GEODE-8806 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Blake Bender >Priority: Major > Labels: pull-request-available > > As a user, I need to be able to limit the size of my log files and the amount > of disk space used by geode-native. Unfortunately, the 10.x native client > doesn't appear to "roll" log files correctly. > > repro steps: > i. In a client application, set `log-file-size-limit` to 1 (for 1MB), > `log-level` to `debug`, and `log-file` to something convenient like > `native_app.log` > ii. Run a long operation in the client that will generate a huge amount of > logging, like 100,000 puts to a region > > expected behavior: > * when native_app.log grows to > 1MB in size, it is followed by > native_app-1.log, native_app-2.log, etc, each of which is ~1MB in size > actual behavior: > * native_app.log grows to > 1MB, then geode-native stops logging -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8818) Make docs of copy-on-read more visible to readers
[ https://issues.apache.org/jira/browse/GEODE-8818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17262960#comment-17262960 ] ASF GitHub Bot commented on GEODE-8818: --- karensmolermiller merged pull request #5888: URL: https://github.com/apache/geode/pull/5888 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Make docs of copy-on-read more visible to readers > - > > Key: GEODE-8818 > URL: https://issues.apache.org/jira/browse/GEODE-8818 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Karen Smoler Miller >Assignee: Karen Smoler Miller >Priority: Major > Labels: pull-request-available > > Our users need more visibility of the copy-on-read region attribute. Promote > the subsection from within Basic Configuration and Programming, Data Entries, > Managing Data Entries to its own section within Data Entries. Update all > links within the manual to point to the new section. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8818) Make docs of copy-on-read more visible to readers
[ https://issues.apache.org/jira/browse/GEODE-8818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17262962#comment-17262962 ] ASF subversion and git services commented on GEODE-8818: Commit 4cb8c870f9773630c9357eda7f26e230b44480ff in geode's branch refs/heads/develop from Karen Miller [ https://gitbox.apache.org/repos/asf?p=geode.git;h=4cb8c87 ] GEODE-8818: Make copy on read info more visible (#5888) * GEODE-8818: Make copy on read info more visible * GEODE-8818: Correct punctuation in copy-on-read section Co-authored-by: Karen Miller > Make docs of copy-on-read more visible to readers > - > > Key: GEODE-8818 > URL: https://issues.apache.org/jira/browse/GEODE-8818 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Karen Smoler Miller >Assignee: Karen Smoler Miller >Priority: Major > Labels: pull-request-available > > Our users need more visibility of the copy-on-read region attribute. Promote > the subsection from within Basic Configuration and Programming, Data Entries, > Managing Data Entries to its own section within Data Entries. Update all > links within the manual to point to the new section. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8818) Make docs of copy-on-read more visible to readers
[ https://issues.apache.org/jira/browse/GEODE-8818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17262961#comment-17262961 ] ASF subversion and git services commented on GEODE-8818: Commit 4cb8c870f9773630c9357eda7f26e230b44480ff in geode's branch refs/heads/develop from Karen Miller [ https://gitbox.apache.org/repos/asf?p=geode.git;h=4cb8c87 ] GEODE-8818: Make copy on read info more visible (#5888) * GEODE-8818: Make copy on read info more visible * GEODE-8818: Correct punctuation in copy-on-read section Co-authored-by: Karen Miller > Make docs of copy-on-read more visible to readers > - > > Key: GEODE-8818 > URL: https://issues.apache.org/jira/browse/GEODE-8818 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Karen Smoler Miller >Assignee: Karen Smoler Miller >Priority: Major > Labels: pull-request-available > > Our users need more visibility of the copy-on-read region attribute. Promote > the subsection from within Basic Configuration and Programming, Data Entries, > Managing Data Entries to its own section within Data Entries. Update all > links within the manual to point to the new section. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8818) Make docs of copy-on-read more visible to readers
[ https://issues.apache.org/jira/browse/GEODE-8818?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17262963#comment-17262963 ] ASF subversion and git services commented on GEODE-8818: Commit 4cb8c870f9773630c9357eda7f26e230b44480ff in geode's branch refs/heads/develop from Karen Miller [ https://gitbox.apache.org/repos/asf?p=geode.git;h=4cb8c87 ] GEODE-8818: Make copy on read info more visible (#5888) * GEODE-8818: Make copy on read info more visible * GEODE-8818: Correct punctuation in copy-on-read section Co-authored-by: Karen Miller > Make docs of copy-on-read more visible to readers > - > > Key: GEODE-8818 > URL: https://issues.apache.org/jira/browse/GEODE-8818 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Karen Smoler Miller >Assignee: Karen Smoler Miller >Priority: Major > Labels: pull-request-available > > Our users need more visibility of the copy-on-read region attribute. Promote > the subsection from within Basic Configuration and Programming, Data Entries, > Managing Data Entries to its own section within Data Entries. Update all > links within the manual to point to the new section. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8806) Native client does not honor log-file-size-limit properly
[
https://issues.apache.org/jira/browse/GEODE-8806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17262964#comment-17262964
]
ASF GitHub Bot commented on GEODE-8806:
---
pdxcodemonkey commented on a change in pull request #718:
URL: https://github.com/apache/geode-native/pull/718#discussion_r555374570
##
File path: cppcache/src/LocalRegion.cpp
##
@@ -717,7 +717,7 @@ void LocalRegion::registerEntryExpiryTask(
new EntryExpiryHandler(rptr, entry, getEntryExpirationAction(),
duration);
auto id = rptr->getCacheImpl()->getExpiryTaskManager().scheduleExpiryTask(
handler, duration, std::chrono::seconds::zero());
- if (Log::finestEnabled()) {
+ if (Log::logLevel() >= LogLevel::Finest) {
Review comment:
Put `Log::enabled(LogLevel level)` back in, and am using that now.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Native client does not honor log-file-size-limit properly
> -
>
> Key: GEODE-8806
> URL: https://issues.apache.org/jira/browse/GEODE-8806
> Project: Geode
> Issue Type: Bug
> Components: native client
>Reporter: Blake Bender
>Priority: Major
> Labels: pull-request-available
>
> As a user, I need to be able to limit the size of my log files and the amount
> of disk space used by geode-native. Unfortunately, the 10.x native client
> doesn't appear to "roll" log files correctly.
>
> repro steps:
> i. In a client application, set `log-file-size-limit` to 1 (for 1MB),
> `log-level` to `debug`, and `log-file` to something convenient like
> `native_app.log`
> ii. Run a long operation in the client that will generate a huge amount of
> logging, like 100,000 puts to a region
>
> expected behavior:
> * when native_app.log grows to > 1MB in size, it is followed by
> native_app-1.log, native_app-2.log, etc, each of which is ~1MB in size
> actual behavior:
> * native_app.log grows to > 1MB, then geode-native stops logging
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8696) Startup of JMX Manager may hang during crash of other members
[
https://issues.apache.org/jira/browse/GEODE-8696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17262968#comment-17262968
]
ASF GitHub Bot commented on GEODE-8696:
---
kirklund commented on pull request #5892:
URL: https://github.com/apache/geode/pull/5892#issuecomment-758275805
JMXMBeanReconnectDUnitTest keeps failing StressNewTest.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Startup of JMX Manager may hang during crash of other members
> -
>
> Key: GEODE-8696
> URL: https://issues.apache.org/jira/browse/GEODE-8696
> Project: Geode
> Issue Type: Bug
> Components: jmx, management
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>Priority: Major
> Labels: GeodeOperationAPI, pull-request-available
>
> The fix for GEODE-7400 removed final from the executorService field to
> introduce a Supplier. I think this hang was caused by adding
> synchronized to FederatingManager.executeTask instead of making
> executorService a volatile field.
> _vm_3_thr_3_client2_host2_21145_ hung while synchronized on
> *0xf6316520*:
> {noformat}
> "vm_3_thr_3_client2_host2_21145" #56 daemon prio=5 os_prio=0
> tid=0x7f1854002000 nid=0x5326 waiting on condition [0x7f18520e2000]
>java.lang.Thread.State: WAITING (parking)
> at sun.misc.Unsafe.park(Native Method)
> - parking to wait for <0xf6364030> (a
> java.util.concurrent.FutureTask)
> at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)
> at java.util.concurrent.FutureTask.awaitDone(FutureTask.java:429)
> at java.util.concurrent.FutureTask.get(FutureTask.java:191)
> at
> java.util.concurrent.AbstractExecutorService.invokeAll(AbstractExecutorService.java:244)
> at
> org.apache.geode.management.internal.FederatingManager.startManagingActivity(FederatingManager.java:256)
> at
> org.apache.geode.management.internal.FederatingManager.startManager(FederatingManager.java:121)
> - locked <0xf6316520> (a
> org.apache.geode.management.internal.FederatingManager)
> at
> org.apache.geode.management.internal.SystemManagementService.startManager(SystemManagementService.java:373)
> - locked <0xfed91a70> (a java.util.HashMap)
> at
> org.apache.geode.management.internal.beans.ManagementAdapter.handleCacheCreation(ManagementAdapter.java:197)
> at
> org.apache.geode.management.internal.beans.ManagementListener.handleEvent(ManagementListener.java:127)
> at
> org.apache.geode.distributed.internal.InternalDistributedSystem.notifyResourceEventListeners(InternalDistributedSystem.java:2089)
> at
> org.apache.geode.distributed.internal.InternalDistributedSystem.handleResourceEvent(InternalDistributedSystem.java:643)
> at
> org.apache.geode.internal.cache.GemFireCacheImpl.initialize(GemFireCacheImpl.java:1363)
> at
> org.apache.geode.internal.cache.InternalCacheBuilder.create(InternalCacheBuilder.java:191)
> - locked <0xe11065f0> (a java.lang.Class for
> org.apache.geode.internal.cache.GemFireCacheImpl)
> - locked <0xe1101220> (a java.lang.Class for
> org.apache.geode.internal.cache.InternalCacheBuilder)
> at
> org.apache.geode.internal.cache.InternalCacheBuilder.create(InternalCacheBuilder.java:158)
> - locked <0xe1101220> (a java.lang.Class for
> org.apache.geode.internal.cache.InternalCacheBuilder)
> at org.apache.geode.cache.CacheFactory.create(CacheFactory.java:142)
> at
> hydra.CacheVersionHelper.configureAndCreateCache(CacheVersionHelper.java:51)
> at hydra.CacheHelper.createCacheWithHttpService(CacheHelper.java:127)
> - locked <0xfecab060> (a java.lang.Class for
> hydra.CacheHelper)
> at hydra.CacheHelper.createCache(CacheHelper.java:87)
> at
> splitBrain.NetworkPartitionTest.initialize(NetworkPartitionTest.java:293)
> at
> splitBrain.NetworkPartitionTest.initializeInstance(NetworkPartitionTest.java:228)
> - locked <0xe14a2db0> (a java.lang.Class for
> splitBrain.NetworkPartitionTest)
> at
> splitBrain.NetworkPartitionTest.HydraTask_initialize(NetworkPartitionTest.java:203)
> - locked <0xe14a2db0> (a java.lang.Class for
> splitBrain.NetworkPartitionTest)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethod
[jira] [Commented] (GEODE-8806) Native client does not honor log-file-size-limit properly
[ https://issues.apache.org/jira/browse/GEODE-8806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17262970#comment-17262970 ] ASF GitHub Bot commented on GEODE-8806: --- pdxcodemonkey commented on a change in pull request #718: URL: https://github.com/apache/geode-native/pull/718#discussion_r555393229 ## File path: clicache/src/Log.cpp ## @@ -70,12 +70,6 @@ namespace Apache static_cast(level)); } - bool Log::Enabled(LogLevel level) Review comment: CLI Log class is actually `private`, but I think it makes sense to have an `Enabled()` method anyway, so it's back now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Native client does not honor log-file-size-limit properly > - > > Key: GEODE-8806 > URL: https://issues.apache.org/jira/browse/GEODE-8806 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Blake Bender >Priority: Major > Labels: pull-request-available > > As a user, I need to be able to limit the size of my log files and the amount > of disk space used by geode-native. Unfortunately, the 10.x native client > doesn't appear to "roll" log files correctly. > > repro steps: > i. In a client application, set `log-file-size-limit` to 1 (for 1MB), > `log-level` to `debug`, and `log-file` to something convenient like > `native_app.log` > ii. Run a long operation in the client that will generate a huge amount of > logging, like 100,000 puts to a region > > expected behavior: > * when native_app.log grows to > 1MB in size, it is followed by > native_app-1.log, native_app-2.log, etc, each of which is ~1MB in size > actual behavior: > * native_app.log grows to > 1MB, then geode-native stops logging -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8806) Native client does not honor log-file-size-limit properly
[
https://issues.apache.org/jira/browse/GEODE-8806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17262971#comment-17262971
]
ASF GitHub Bot commented on GEODE-8806:
---
pdxcodemonkey commented on a change in pull request #718:
URL: https://github.com/apache/geode-native/pull/718#discussion_r555393732
##
File path: cppcache/src/LocalRegion.cpp
##
@@ -717,7 +717,7 @@ void LocalRegion::registerEntryExpiryTask(
new EntryExpiryHandler(rptr, entry, getEntryExpirationAction(),
duration);
auto id = rptr->getCacheImpl()->getExpiryTaskManager().scheduleExpiryTask(
handler, duration, std::chrono::seconds::zero());
- if (Log::finestEnabled()) {
+ if (Log::logLevel() >= LogLevel::Finest) {
Review comment:
Added enabled() back, and using that now. No need for warningEnabled,
finestEnabled, etc helper functions tho.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Native client does not honor log-file-size-limit properly
> -
>
> Key: GEODE-8806
> URL: https://issues.apache.org/jira/browse/GEODE-8806
> Project: Geode
> Issue Type: Bug
> Components: native client
>Reporter: Blake Bender
>Priority: Major
> Labels: pull-request-available
>
> As a user, I need to be able to limit the size of my log files and the amount
> of disk space used by geode-native. Unfortunately, the 10.x native client
> doesn't appear to "roll" log files correctly.
>
> repro steps:
> i. In a client application, set `log-file-size-limit` to 1 (for 1MB),
> `log-level` to `debug`, and `log-file` to something convenient like
> `native_app.log`
> ii. Run a long operation in the client that will generate a huge amount of
> logging, like 100,000 puts to a region
>
> expected behavior:
> * when native_app.log grows to > 1MB in size, it is followed by
> native_app-1.log, native_app-2.log, etc, each of which is ~1MB in size
> actual behavior:
> * native_app.log grows to > 1MB, then geode-native stops logging
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8806) Native client does not honor log-file-size-limit properly
[
https://issues.apache.org/jira/browse/GEODE-8806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17262973#comment-17262973
]
ASF GitHub Bot commented on GEODE-8806:
---
pdxcodemonkey commented on a change in pull request #718:
URL: https://github.com/apache/geode-native/pull/718#discussion_r555394754
##
File path: cppcache/src/util/Log.hpp
##
@@ -182,315 +183,69 @@ class APACHE_GEODE_EXPORT Log {
* When invoking from outside either should have been invoked,
* or at least the first invocation should be single-threaded.
*/
- static char* formatLogLine(char* buf, LogLevel level);
-
- /**
- * Returns whether log messages at given level are enabled.
- */
- static bool enabled(LogLevel level);
-
- /**
- * Logs a message at given level.
- */
- static void log(LogLevel level, const char* msg);
-
- /**
- * Logs both a message and thrown exception.
- */
- static void logThrow(LogLevel level, const char* msg, const Exception& ex);
-
- /**
- * Logs both a message and caught exception.
- */
- static void logCatch(LogLevel level, const char* msg, const Exception& ex);
-
- /**
- * Returns whether "error" log messages are enabled.
- */
- static bool errorEnabled();
-
- /**
- * Logs a message.
- * The message level is "error".
- */
- static void error(const char* msg);
-
- static void error(const std::string& msg);
-
- /**
- * Logs both a message and thrown exception.
- * The message level is "error".
- */
- static void errorThrow(const char* msg, const Exception& ex);
-
- /**
- * Writes both a message and caught exception.
- * The message level is "error".
- */
- static void errorCatch(const char* msg, const Exception& ex);
-
- /**
- * Returns whether "warning" log messages are enabled.
- */
- static bool warningEnabled();
-
- /**
- * Logs a message.
- * The message level is "warning".
- */
- static void warning(const char* msg);
-
- /**
- * Logs both a message and thrown exception.
- * The message level is "warning".
- */
- static void warningThrow(const char* msg, const Exception& ex);
-
- /**
- * Writes both a message and caught exception.
- * The message level is "warning".
- */
- static void warningCatch(const char* msg, const Exception& ex);
-
- /**
- * Returns whether "info" log messages are enabled.
- */
- static bool infoEnabled();
-
- /**
- * Logs a message.
- * The message level is "info".
- */
- static void info(const char* msg);
-
- /**
- * Logs both a message and thrown exception.
- * The message level is "info".
- */
- static void infoThrow(const char* msg, const Exception& ex);
-
- /**
- * Writes both a message and caught exception.
- * The message level is "info".
- */
- static void infoCatch(const char* msg, const Exception& ex);
-
- /**
- * Returns whether "config" log messages are enabled.
- */
- static bool configEnabled();
-
- /**
- * Logs a message.
- * The message level is "config".
- */
- static void config(const char* msg);
-
- /**
- * Logs both a message and thrown exception.
- * The message level is "config".
- */
- static void configThrow(const char* msg, const Exception& ex);
-
- /**
- * Writes both a message and caught exception.
- * The message level is "config".
- */
- static void configCatch(const char* msg, const Exception& ex);
-
- /**
- * Returns whether "fine" log messages are enabled.
- */
- static bool fineEnabled();
-
- /**
- * Logs a message.
- * The message level is "fine".
- */
- static void fine(const char* msg);
-
- /**
- * Logs both a message and thrown exception.
- * The message level is "fine".
- */
- static void fineThrow(const char* msg, const Exception& ex);
-
- /**
- * Writes both a message and caught exception.
- * The message level is "fine".
- */
- static void fineCatch(const char* msg, const Exception& ex);
-
- /**
- * Returns whether "finer" log messages are enabled.
- */
- static bool finerEnabled();
-
- /**
- * Logs a message.
- * The message level is "finer".
- */
- static void finer(const char* msg);
-
- /**
- * Logs both a message and thrown exception.
- * The message level is "finer".
- */
- static void finerThrow(const char* msg, const Exception& ex);
-
- /**
- * Writes both a message and caught exception.
- * The message level is "finer".
- */
- static void finerCatch(const char* msg, const Exception& ex);
-
- /**
- * Returns whether "finest" log messages are enabled.
- */
- static bool finestEnabled();
-
- /**
- * Logs a message.
- * The message level is "finest".
- */
- static void finest(const char* msg);
-
- /**
- * Logs both a message and thrown exception.
- * The message level is "finest".
- */
- static void finestThrow(const char* msg, const Exception& ex);
-
- /**
- * Writes both a message and caught exce
[jira] [Commented] (GEODE-8696) Startup of JMX Manager may hang during crash of other members
[
https://issues.apache.org/jira/browse/GEODE-8696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17262977#comment-17262977
]
ASF GitHub Bot commented on GEODE-8696:
---
kirklund edited a comment on pull request #5892:
URL: https://github.com/apache/geode/pull/5892#issuecomment-758275805
JMXMBeanReconnectDUnitTest (GEODE-7710) keeps failing StressNewTest,
blocking the merge of this revert.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Startup of JMX Manager may hang during crash of other members
> -
>
> Key: GEODE-8696
> URL: https://issues.apache.org/jira/browse/GEODE-8696
> Project: Geode
> Issue Type: Bug
> Components: jmx, management
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>Priority: Major
> Labels: GeodeOperationAPI, pull-request-available
>
> The fix for GEODE-7400 removed final from the executorService field to
> introduce a Supplier. I think this hang was caused by adding
> synchronized to FederatingManager.executeTask instead of making
> executorService a volatile field.
> _vm_3_thr_3_client2_host2_21145_ hung while synchronized on
> *0xf6316520*:
> {noformat}
> "vm_3_thr_3_client2_host2_21145" #56 daemon prio=5 os_prio=0
> tid=0x7f1854002000 nid=0x5326 waiting on condition [0x7f18520e2000]
>java.lang.Thread.State: WAITING (parking)
> at sun.misc.Unsafe.park(Native Method)
> - parking to wait for <0xf6364030> (a
> java.util.concurrent.FutureTask)
> at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)
> at java.util.concurrent.FutureTask.awaitDone(FutureTask.java:429)
> at java.util.concurrent.FutureTask.get(FutureTask.java:191)
> at
> java.util.concurrent.AbstractExecutorService.invokeAll(AbstractExecutorService.java:244)
> at
> org.apache.geode.management.internal.FederatingManager.startManagingActivity(FederatingManager.java:256)
> at
> org.apache.geode.management.internal.FederatingManager.startManager(FederatingManager.java:121)
> - locked <0xf6316520> (a
> org.apache.geode.management.internal.FederatingManager)
> at
> org.apache.geode.management.internal.SystemManagementService.startManager(SystemManagementService.java:373)
> - locked <0xfed91a70> (a java.util.HashMap)
> at
> org.apache.geode.management.internal.beans.ManagementAdapter.handleCacheCreation(ManagementAdapter.java:197)
> at
> org.apache.geode.management.internal.beans.ManagementListener.handleEvent(ManagementListener.java:127)
> at
> org.apache.geode.distributed.internal.InternalDistributedSystem.notifyResourceEventListeners(InternalDistributedSystem.java:2089)
> at
> org.apache.geode.distributed.internal.InternalDistributedSystem.handleResourceEvent(InternalDistributedSystem.java:643)
> at
> org.apache.geode.internal.cache.GemFireCacheImpl.initialize(GemFireCacheImpl.java:1363)
> at
> org.apache.geode.internal.cache.InternalCacheBuilder.create(InternalCacheBuilder.java:191)
> - locked <0xe11065f0> (a java.lang.Class for
> org.apache.geode.internal.cache.GemFireCacheImpl)
> - locked <0xe1101220> (a java.lang.Class for
> org.apache.geode.internal.cache.InternalCacheBuilder)
> at
> org.apache.geode.internal.cache.InternalCacheBuilder.create(InternalCacheBuilder.java:158)
> - locked <0xe1101220> (a java.lang.Class for
> org.apache.geode.internal.cache.InternalCacheBuilder)
> at org.apache.geode.cache.CacheFactory.create(CacheFactory.java:142)
> at
> hydra.CacheVersionHelper.configureAndCreateCache(CacheVersionHelper.java:51)
> at hydra.CacheHelper.createCacheWithHttpService(CacheHelper.java:127)
> - locked <0xfecab060> (a java.lang.Class for
> hydra.CacheHelper)
> at hydra.CacheHelper.createCache(CacheHelper.java:87)
> at
> splitBrain.NetworkPartitionTest.initialize(NetworkPartitionTest.java:293)
> at
> splitBrain.NetworkPartitionTest.initializeInstance(NetworkPartitionTest.java:228)
> - locked <0xe14a2db0> (a java.lang.Class for
> splitBrain.NetworkPartitionTest)
> at
> splitBrain.NetworkPartitionTest.HydraTask_initialize(NetworkPartitionTest.java:203)
> - locked <0xe14a2db0> (a java.lang.Class for
> splitBrain.NetworkPartitionTest)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at
>
[jira] [Commented] (GEODE-8696) Startup of JMX Manager may hang during crash of other members
[
https://issues.apache.org/jira/browse/GEODE-8696?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17262982#comment-17262982
]
ASF GitHub Bot commented on GEODE-8696:
---
kirklund opened a new pull request #5894:
URL: https://github.com/apache/geode/pull/5894
FederatingManager now uses a ReentrantLock instead of synchronization.
Leave the redundant syncs in results in a java-level deadlock.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to d...@geode.apache.org.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Startup of JMX Manager may hang during crash of other members
> -
>
> Key: GEODE-8696
> URL: https://issues.apache.org/jira/browse/GEODE-8696
> Project: Geode
> Issue Type: Bug
> Components: jmx, management
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>Priority: Major
> Labels: GeodeOperationAPI, pull-request-available
>
> The fix for GEODE-7400 removed final from the executorService field to
> introduce a Supplier. I think this hang was caused by adding
> synchronized to FederatingManager.executeTask instead of making
> executorService a volatile field.
> _vm_3_thr_3_client2_host2_21145_ hung while synchronized on
> *0xf6316520*:
> {noformat}
> "vm_3_thr_3_client2_host2_21145" #56 daemon prio=5 os_prio=0
> tid=0x7f1854002000 nid=0x5326 waiting on condition [0x7f18520e2000]
>java.lang.Thread.State: WAITING (parking)
> at sun.misc.Unsafe.park(Native Method)
> - parking to wait for <0xf6364030> (a
> java.util.concurrent.FutureTask)
> at java.util.concurrent.locks.LockSupport.park(LockSupport.java:175)
> at java.util.concurrent.FutureTask.awaitDone(FutureTask.java:429)
> at java.util.concurrent.FutureTask.get(FutureTask.java:191)
> at
> java.util.concurrent.AbstractExecutorService.invokeAll(AbstractExecutorService.java:244)
> at
> org.apache.geode.management.internal.FederatingManager.startManagingActivity(FederatingManager.java:256)
> at
> org.apache.geode.management.internal.FederatingManager.startManager(FederatingManager.java:121)
> - locked <0xf6316520> (a
> org.apache.geode.management.internal.FederatingManager)
> at
> org.apache.geode.management.internal.SystemManagementService.startManager(SystemManagementService.java:373)
> - locked <0xfed91a70> (a java.util.HashMap)
> at
> org.apache.geode.management.internal.beans.ManagementAdapter.handleCacheCreation(ManagementAdapter.java:197)
> at
> org.apache.geode.management.internal.beans.ManagementListener.handleEvent(ManagementListener.java:127)
> at
> org.apache.geode.distributed.internal.InternalDistributedSystem.notifyResourceEventListeners(InternalDistributedSystem.java:2089)
> at
> org.apache.geode.distributed.internal.InternalDistributedSystem.handleResourceEvent(InternalDistributedSystem.java:643)
> at
> org.apache.geode.internal.cache.GemFireCacheImpl.initialize(GemFireCacheImpl.java:1363)
> at
> org.apache.geode.internal.cache.InternalCacheBuilder.create(InternalCacheBuilder.java:191)
> - locked <0xe11065f0> (a java.lang.Class for
> org.apache.geode.internal.cache.GemFireCacheImpl)
> - locked <0xe1101220> (a java.lang.Class for
> org.apache.geode.internal.cache.InternalCacheBuilder)
> at
> org.apache.geode.internal.cache.InternalCacheBuilder.create(InternalCacheBuilder.java:158)
> - locked <0xe1101220> (a java.l
[jira] [Commented] (GEODE-8728) Configure Gradle to run parallel tests in isolation without Docker [PERMANENT]
[ https://issues.apache.org/jira/browse/GEODE-8728?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17262986#comment-17262986 ] ASF GitHub Bot commented on GEODE-8728: --- lgtm-com[bot] commented on pull request #5848: URL: https://github.com/apache/geode/pull/5848#issuecomment-758294814 This pull request **fixes 1 alert** when merging 846e91f7a4ab8de27dcf7d1b4ef054ddb43b90fe into 4cb8c870f9773630c9357eda7f26e230b44480ff - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-2b1ba9465ed6001e8332d8bfcf6ac6a2229470f7) **fixed alerts:** * 1 for Dereferenced variable may be null This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Configure Gradle to run parallel tests in isolation without Docker [PERMANENT] > -- > > Key: GEODE-8728 > URL: https://issues.apache.org/jira/browse/GEODE-8728 > Project: Geode > Issue Type: Test > Components: tests >Affects Versions: 1.14.0 >Reporter: Dale Emery >Assignee: Dale Emery >Priority: Major > Labels: GeodeOperationAPI, pull-request-available > > For tests to behave well when run in parallel, each must refrain from using > ports and test files that are in use by other tests. > Geode's Gradle build isolates concurrently executing tests by running each > test class in a Docker container. To do this, the build applies an open > source "Gradle Dockerized Test" plugin that is obsolete and appears to be > unmaintained. > This ticket removes the obsolete plugin and replaces it with a small amount > of custom Gradle code and a few minor changes to Geode: > - Configure Gradle to assign each concurrently executing test JVM a unique > working directory and a distinct range of ports. > - Change Geode's "available port" feature to allocate ports only from the > ranges assigned by Gradle. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8626) Omitting field-mapping tag of cache.xml when using Simple JDBC Connector
[
https://issues.apache.org/jira/browse/GEODE-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17263012#comment-17263012
]
ASF GitHub Bot commented on GEODE-8626:
---
jchen21 commented on a change in pull request #5637:
URL: https://github.com/apache/geode/pull/5637#discussion_r555418639
##
File path:
geode-connectors/src/acceptanceTest/java/org/apache/geode/connectors/jdbc/CacheXmlJdbcMappingIntegrationTest.java
##
@@ -0,0 +1,284 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express
+ * or implied. See the License for the specific language governing permissions
and limitations under
+ * the License.
+ */
+package org.apache.geode.connectors.jdbc;
+
+import static
org.apache.geode.test.util.ResourceUtils.createTempFileFromResource;
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.catchThrowable;
+
+import java.net.URL;
+import java.sql.Connection;
+import java.sql.JDBCType;
+import java.sql.Statement;
+import java.util.Arrays;
+import java.util.List;
+
+import org.junit.After;
+import org.junit.Before;
+import org.junit.ClassRule;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.contrib.java.lang.system.RestoreSystemProperties;
+
+import org.apache.geode.cache.CacheFactory;
+import org.apache.geode.connectors.jdbc.internal.JdbcConnectorService;
+import org.apache.geode.connectors.jdbc.internal.configuration.FieldMapping;
+import org.apache.geode.connectors.jdbc.internal.configuration.RegionMapping;
+import
org.apache.geode.connectors.jdbc.test.junit.rules.DatabaseConnectionRule;
+import org.apache.geode.connectors.jdbc.test.junit.rules.MySqlConnectionRule;
+import org.apache.geode.internal.cache.InternalCache;
+import org.apache.geode.internal.jndi.JNDIInvoker;
+import org.apache.geode.pdx.FieldType;
+import org.apache.geode.pdx.internal.AutoSerializableManager;
+
+public class CacheXmlJdbcMappingIntegrationTest {
+
+ private static final URL COMPOSE_RESOURCE_PATH =
+ CacheXmlJdbcMappingIntegrationTest.class.getResource("mysql.yml");
+ protected static final String DATA_SOURCE_NAME = "TestDataSource";
+ protected static final String DB_NAME = "test";
+ protected static final String REGION_TABLE_NAME = "employees";
+ protected static final String REGION_NAME = "Region1";
+
+ @Rule
+ public RestoreSystemProperties restoreSystemProperties = new
RestoreSystemProperties();
+
+ private Connection connection;
+ private Statement statement;
+ private InternalCache cache;
+
+ @ClassRule
+ public static DatabaseConnectionRule dbRule = new
MySqlConnectionRule.Builder()
+
.file(COMPOSE_RESOURCE_PATH.getPath()).serviceName("db").port(3306).database(DB_NAME).build();
+
+ @Before
+ public void setUp() throws Exception {
+System.setProperty(AutoSerializableManager.NO_HARDCODED_EXCLUDES_PARAM,
"true");
+connection = dbRule.getConnection();
+statement = connection.createStatement();
+ }
+
+ @After
+ public void tearDown() throws Exception {
+JNDIInvoker.unMapDatasource(DATA_SOURCE_NAME);
+
+if (cache != null) {
+ cache.close();
+}
+
+if (statement == null) {
+ statement = connection.createStatement();
+}
+statement.execute("Drop table IF EXISTS " + REGION_TABLE_NAME);
+statement.close();
+
+if (connection != null) {
+ connection.close();
+}
+ }
+
+ private InternalCache createCacheAndCreateJdbcMapping(String
cacheXmlTestName)
+ throws Exception {
+String url = dbRule.getConnectionUrl().replaceAll("&", "&");
+System.setProperty("TestDataSourceUrl", url);
+InternalCache cache =
+(InternalCache) new CacheFactory().set("locators",
"").set("mcast-port", "0")
+.set("cache-xml-file", getXmlFileForTest(cacheXmlTestName))
+.create();
+return cache;
+ }
+
+ private InternalCache createCacheAndCreateJdbcMappingWithNonSerializedClass(
+ String cacheXmlTestName) throws Exception {
+return createCacheAndCreateJdbcMapping(cacheXmlTestName);
+ }
+
+ private InternalCache createCacheAndCreateJdbcMappingWithWrongDataSource(
+ String cacheXmlTestName) throws Exception {
+System.setProperty("TestDataSourceUrl", "jdbc:mysql://localhost/test");
+InternalCache cache
[jira] [Commented] (GEODE-8806) Native client does not honor log-file-size-limit properly
[ https://issues.apache.org/jira/browse/GEODE-8806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17263013#comment-17263013 ] ASF GitHub Bot commented on GEODE-8806: --- codecov-io edited a comment on pull request #718: URL: https://github.com/apache/geode-native/pull/718#issuecomment-757540519 # [Codecov](https://codecov.io/gh/apache/geode-native/pull/718?src=pr&el=h1) Report > Merging [#718](https://codecov.io/gh/apache/geode-native/pull/718?src=pr&el=desc) (9e2e560) into [develop](https://codecov.io/gh/apache/geode-native/commit/c1886061ff94e328d4675206b34c3a4868510600?el=desc) (c188606) will **increase** coverage by `0.84%`. > The diff coverage is `92.88%`. [](https://codecov.io/gh/apache/geode-native/pull/718?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## develop #718 +/- ## === + Coverage74.08% 74.93% +0.84% === Files 645 645 Lines5085849795-1063 === - Hits 3768037312 -368 + Misses 1317812483 -695 ``` | [Impacted Files](https://codecov.io/gh/apache/geode-native/pull/718?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [cppcache/integration-test/fw\_helper.hpp](https://codecov.io/gh/apache/geode-native/pull/718/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvaW50ZWdyYXRpb24tdGVzdC9md19oZWxwZXIuaHBw) | `56.60% <0.00%> (+1.04%)` | :arrow_up: | | [cppcache/src/ThinClientDistributionManager.cpp](https://codecov.io/gh/apache/geode-native/pull/718/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnREaXN0cmlidXRpb25NYW5hZ2VyLmNwcA==) | `2.35% <0.00%> (+0.18%)` | :arrow_up: | | [cppcache/src/statistics/GeodeStatisticsFactory.cpp](https://codecov.io/gh/apache/geode-native/pull/718/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL3N0YXRpc3RpY3MvR2VvZGVTdGF0aXN0aWNzRmFjdG9yeS5jcHA=) | `55.29% <0.00%> (ø)` | | | [cppcache/src/statistics/StatisticsManager.cpp](https://codecov.io/gh/apache/geode-native/pull/718/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL3N0YXRpc3RpY3MvU3RhdGlzdGljc01hbmFnZXIuY3Bw) | `46.42% <0.00%> (ø)` | | | [cppcache/src/CqService.cpp](https://codecov.io/gh/apache/geode-native/pull/718/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL0NxU2VydmljZS5jcHA=) | `59.12% <55.55%> (+4.21%)` | :arrow_up: | | [cppcache/src/Log.cpp](https://codecov.io/gh/apache/geode-native/pull/718/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL0xvZy5jcHA=) | `85.77% <86.66%> (+28.30%)` | :arrow_up: | | [cppcache/test/LoggingTest.cpp](https://codecov.io/gh/apache/geode-native/pull/718/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvdGVzdC9Mb2dnaW5nVGVzdC5jcHA=) | `99.28% <99.28%> (ø)` | | | [cppcache/src/CacheXmlParser.cpp](https://codecov.io/gh/apache/geode-native/pull/718/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL0NhY2hlWG1sUGFyc2VyLmNwcA==) | `75.22% <100.00%> (+0.27%)` | :arrow_up: | | [cppcache/src/LocalRegion.cpp](https://codecov.io/gh/apache/geode-native/pull/718/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL0xvY2FsUmVnaW9uLmNwcA==) | `72.04% <100.00%> (+3.06%)` | :arrow_up: | | [cppcache/src/TcrEndpoint.cpp](https://codecov.io/gh/apache/geode-native/pull/718/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RjckVuZHBvaW50LmNwcA==) | `56.23% <100.00%> (-0.96%)` | :arrow_down: | | ... and [99 more](https://codecov.io/gh/apache/geode-native/pull/718/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/geode-native/pull/718?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/geode-native/pull/718?src=pr&el=footer). Last update [c188606...9e2e560](https://codecov.io/gh/apache/geode-native/pull/718?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Native client does not honor log-file-size-limit properly > - > > Key: GEODE-8806 > URL: https://issues.apache.org/jira/browse/GEODE-8806 > Project: Geode > Issue Type: Bu
[jira] [Updated] (GEODE-5922) SerialGatewaySenderQueue concurrency is poorly implemented
[ https://issues.apache.org/jira/browse/GEODE-5922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Owen Nichols updated GEODE-5922: Fix Version/s: (was: 1.8.0) > SerialGatewaySenderQueue concurrency is poorly implemented > -- > > Key: GEODE-5922 > URL: https://issues.apache.org/jira/browse/GEODE-5922 > Project: Geode > Issue Type: Improvement > Components: wan >Reporter: Bruce J Schuchardt >Assignee: Bruce J Schuchardt >Priority: Major > Labels: blocks-1.14.0, pull-request-available > Time Spent: 20m > Remaining Estimate: 0h > > This class uses synchronization on the queue to limit access to one put at a > time. Synchronization isn't a fair locking mechanism so threads can be > blocked trying to add events to the queue while other more recent events get > the lock and insert their events. This causes inconsistent latency which > I've observed being as long as 30 seconds, causing client connections to be > shut down by the ClientHealthMonitor. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-8818) Make docs of copy-on-read more visible to readers
[ https://issues.apache.org/jira/browse/GEODE-8818?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Owen Nichols resolved GEODE-8818. - Fix Version/s: 1.14.0 Resolution: Fixed > Make docs of copy-on-read more visible to readers > - > > Key: GEODE-8818 > URL: https://issues.apache.org/jira/browse/GEODE-8818 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Karen Smoler Miller >Assignee: Karen Smoler Miller >Priority: Major > Labels: pull-request-available > Fix For: 1.14.0 > > > Our users need more visibility of the copy-on-read region attribute. Promote > the subsection from within Basic Configuration and Programming, Data Entries, > Managing Data Entries to its own section within Data Entries. Update all > links within the manual to point to the new section. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-5922) SerialGatewaySenderQueue concurrency is poorly implemented
[ https://issues.apache.org/jira/browse/GEODE-5922?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17263022#comment-17263022 ] Owen Nichols commented on GEODE-5922: - This is tricky to represent the fixed versions, since it was in the product for over two years before being reverted. Versions that did contain this original change include 1.8.0, 1.9.x, 1.10.0, 1.11.0, 1.12.0, 1.13.0, and 1.13.1 Version that will no longer have this change include 1.12.1+, 1.13.2+, and 1.14+ > SerialGatewaySenderQueue concurrency is poorly implemented > -- > > Key: GEODE-5922 > URL: https://issues.apache.org/jira/browse/GEODE-5922 > Project: Geode > Issue Type: Improvement > Components: wan >Reporter: Bruce J Schuchardt >Assignee: Bruce J Schuchardt >Priority: Major > Labels: blocks-1.14.0, pull-request-available > Time Spent: 20m > Remaining Estimate: 0h > > This class uses synchronization on the queue to limit access to one put at a > time. Synchronization isn't a fair locking mechanism so threads can be > blocked trying to add events to the queue while other more recent events get > the lock and insert their events. This causes inconsistent latency which > I've observed being as long as 30 seconds, causing client connections to be > shut down by the ClientHealthMonitor. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8806) Native client does not honor log-file-size-limit properly
[ https://issues.apache.org/jira/browse/GEODE-8806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17263032#comment-17263032 ] ASF subversion and git services commented on GEODE-8806: Commit 29afcad1466e787a65bbcdf0391b7294cb43ac1e in geode-native's branch refs/heads/develop from Blake Bender [ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=29afcad ] GEODE-8806: Refactor Logger code (#718) Replace all ACE usage by boost or std equivalents Fix log rolling code to properly honor file and disk space limits Move existing logging test from integration to unit tests, and add new tests Clean up global logger variables, and stop allocating/deallocating Remove a bunch or redundant code Co-authored-by: Blake Bender Co-authored-by: Matthew Reddington > Native client does not honor log-file-size-limit properly > - > > Key: GEODE-8806 > URL: https://issues.apache.org/jira/browse/GEODE-8806 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Blake Bender >Priority: Major > Labels: pull-request-available > > As a user, I need to be able to limit the size of my log files and the amount > of disk space used by geode-native. Unfortunately, the 10.x native client > doesn't appear to "roll" log files correctly. > > repro steps: > i. In a client application, set `log-file-size-limit` to 1 (for 1MB), > `log-level` to `debug`, and `log-file` to something convenient like > `native_app.log` > ii. Run a long operation in the client that will generate a huge amount of > logging, like 100,000 puts to a region > > expected behavior: > * when native_app.log grows to > 1MB in size, it is followed by > native_app-1.log, native_app-2.log, etc, each of which is ~1MB in size > actual behavior: > * native_app.log grows to > 1MB, then geode-native stops logging -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8806) Native client does not honor log-file-size-limit properly
[ https://issues.apache.org/jira/browse/GEODE-8806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17263033#comment-17263033 ] ASF GitHub Bot commented on GEODE-8806: --- pdxcodemonkey merged pull request #718: URL: https://github.com/apache/geode-native/pull/718 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Native client does not honor log-file-size-limit properly > - > > Key: GEODE-8806 > URL: https://issues.apache.org/jira/browse/GEODE-8806 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Blake Bender >Priority: Major > Labels: pull-request-available > > As a user, I need to be able to limit the size of my log files and the amount > of disk space used by geode-native. Unfortunately, the 10.x native client > doesn't appear to "roll" log files correctly. > > repro steps: > i. In a client application, set `log-file-size-limit` to 1 (for 1MB), > `log-level` to `debug`, and `log-file` to something convenient like > `native_app.log` > ii. Run a long operation in the client that will generate a huge amount of > logging, like 100,000 puts to a region > > expected behavior: > * when native_app.log grows to > 1MB in size, it is followed by > native_app-1.log, native_app-2.log, etc, each of which is ~1MB in size > actual behavior: > * native_app.log grows to > 1MB, then geode-native stops logging -- This message was sent by Atlassian Jira (v8.3.4#803005)
