[
https://issues.apache.org/jira/browse/GEODE-8806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17262817#comment-17262817
]
ASF GitHub Bot commented on GEODE-8806:
---------------------------------------
codecov-io edited a comment on pull request #718:
URL: https://github.com/apache/geode-native/pull/718#issuecomment-757540519
# [Codecov](https://codecov.io/gh/apache/geode-native/pull/718?src=pr&el=h1)
Report
> Merging
[#718](https://codecov.io/gh/apache/geode-native/pull/718?src=pr&el=desc)
(e0ed487) into
[develop](https://codecov.io/gh/apache/geode-native/commit/c1886061ff94e328d4675206b34c3a4868510600?el=desc)
(c188606) will **decrease** coverage by `0.09%`.
> The diff coverage is `95.96%`.
[](https://codecov.io/gh/apache/geode-native/pull/718?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #718 +/- ##
===========================================
- Coverage 74.08% 73.98% -0.10%
===========================================
Files 645 645
Lines 50858 50806 -52
===========================================
- Hits 37680 37591 -89
- Misses 13178 13215 +37
```
| [Impacted
Files](https://codecov.io/gh/apache/geode-native/pull/718?src=pr&el=tree) |
Coverage Δ | |
|---|---|---|
|
[cppcache/integration-test/fw\_helper.hpp](https://codecov.io/gh/apache/geode-native/pull/718/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvaW50ZWdyYXRpb24tdGVzdC9md19oZWxwZXIuaHBw)
| `56.60% <0.00%> (+1.04%)` | :arrow_up: |
|
[cppcache/src/Log.cpp](https://codecov.io/gh/apache/geode-native/pull/718/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL0xvZy5jcHA=)
| `79.29% <89.86%> (+21.81%)` | :arrow_up: |
|
[cppcache/test/LoggingTest.cpp](https://codecov.io/gh/apache/geode-native/pull/718/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvdGVzdC9Mb2dnaW5nVGVzdC5jcHA=)
| `99.32% <99.32%> (ø)` | |
|
[cppcache/src/ReadWriteLock.cpp](https://codecov.io/gh/apache/geode-native/pull/718/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1JlYWRXcml0ZUxvY2suY3Bw)
| `62.50% <0.00%> (-37.50%)` | :arrow_down: |
|
[cppcache/src/TcrPoolEndPoint.cpp](https://codecov.io/gh/apache/geode-native/pull/718/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RjclBvb2xFbmRQb2ludC5jcHA=)
| `83.09% <0.00%> (-7.05%)` | :arrow_down: |
|
[cppcache/src/TcrEndpoint.cpp](https://codecov.io/gh/apache/geode-native/pull/718/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RjckVuZHBvaW50LmNwcA==)
| `53.52% <0.00%> (-3.67%)` | :arrow_down: |
|
[cppcache/src/ThinClientRedundancyManager.cpp](https://codecov.io/gh/apache/geode-native/pull/718/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRSZWR1bmRhbmN5TWFuYWdlci5jcHA=)
| `72.30% <0.00%> (-3.45%)` | :arrow_down: |
|
[cppcache/src/ThinClientBaseDM.cpp](https://codecov.io/gh/apache/geode-native/pull/718/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRCYXNlRE0uY3Bw)
| `65.55% <0.00%> (-3.34%)` | :arrow_down: |
|
[cppcache/src/TcrConnection.cpp](https://codecov.io/gh/apache/geode-native/pull/718/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RjckNvbm5lY3Rpb24uY3Bw)
| `70.45% <0.00%> (-2.34%)` | :arrow_down: |
|
[cppcache/src/ExceptionTypes.cpp](https://codecov.io/gh/apache/geode-native/pull/718/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL0V4Y2VwdGlvblR5cGVzLmNwcA==)
| `42.04% <0.00%> (-2.28%)` | :arrow_down: |
| ... and [26
more](https://codecov.io/gh/apache/geode-native/pull/718/diff?src=pr&el=tree-more)
| |
------
[Continue to review full report at
Codecov](https://codecov.io/gh/apache/geode-native/pull/718?src=pr&el=continue).
> **Legend** - [Click here to learn
more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by
[Codecov](https://codecov.io/gh/apache/geode-native/pull/718?src=pr&el=footer).
Last update
[c188606...e0ed487](https://codecov.io/gh/apache/geode-native/pull/718?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Native client does not honor log-file-size-limit properly
> ---------------------------------------------------------
>
> Key: GEODE-8806
> URL: https://issues.apache.org/jira/browse/GEODE-8806
> Project: Geode
> Issue Type: Bug
> Components: native client
> Reporter: Blake Bender
> Priority: Major
> Labels: pull-request-available
>
> As a user, I need to be able to limit the size of my log files and the amount
> of disk space used by geode-native. Unfortunately, the 10.x native client
> doesn't appear to "roll" log files correctly.
>
> repro steps:
> i. In a client application, set `log-file-size-limit` to 1 (for 1MB),
> `log-level` to `debug`, and `log-file` to something convenient like
> `native_app.log`
> ii. Run a long operation in the client that will generate a huge amount of
> logging, like 100,000 puts to a region
>
> expected behavior:
> * when native_app.log grows to > 1MB in size, it is followed by
> native_app-1.log, native_app-2.log, etc, each of which is ~1MB in size
> actual behavior:
> * native_app.log grows to > 1MB, then geode-native stops logging
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
