[jira] [Created] (GEODE-8682) update jetty to recommended version
Owen Nichols created GEODE-8682: --- Summary: update jetty to recommended version Key: GEODE-8682 URL: https://issues.apache.org/jira/browse/GEODE-8682 Project: Geode Issue Type: Bug Components: management Reporter: Owen Nichols -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-8682) update jetty to recommended version
[ https://issues.apache.org/jira/browse/GEODE-8682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Owen Nichols resolved GEODE-8682. - Fix Version/s: 1.13.1 1.14.0 1.12.1 Resolution: Fixed > update jetty to recommended version > --- > > Key: GEODE-8682 > URL: https://issues.apache.org/jira/browse/GEODE-8682 > Project: Geode > Issue Type: Bug > Components: management >Reporter: Owen Nichols >Priority: Major > Fix For: 1.12.1, 1.14.0, 1.13.1 > > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8682) update jetty to recommended version
[ https://issues.apache.org/jira/browse/GEODE-8682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Owen Nichols updated GEODE-8682: Description: update jetty to [9.4.33.v20201020|https://mvnrepository.com/artifact/org.eclipse.jetty/jetty-server/9.4.33.v20201020] > update jetty to recommended version > --- > > Key: GEODE-8682 > URL: https://issues.apache.org/jira/browse/GEODE-8682 > Project: Geode > Issue Type: Bug > Components: management >Reporter: Owen Nichols >Priority: Major > Fix For: 1.12.1, 1.14.0, 1.13.1 > > > update jetty to > [9.4.33.v20201020|https://mvnrepository.com/artifact/org.eclipse.jetty/jetty-server/9.4.33.v20201020] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8676) Update bookbindery to latest
[ https://issues.apache.org/jira/browse/GEODE-8676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225366#comment-17225366 ] ASF GitHub Bot commented on GEODE-8676: --- moleske commented on pull request #683: URL: https://github.com/apache/geode-native/pull/683#issuecomment-720792021 bumped it again, but ran into some other problems. Hoping your ruby knowledge helps This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update bookbindery to latest > > > Key: GEODE-8676 > URL: https://issues.apache.org/jira/browse/GEODE-8676 > Project: Geode > Issue Type: Improvement > Components: docs, native client >Reporter: Michael Oleske >Priority: Major > Labels: pull-request-available > > [Bookbinder|https://github.com/pivotal-cf/bookbinder/releases] has a new > release and we should keep the tools we use to build our docs up to date -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (GEODE-8683) maximum-time-between-pings parameter in GatewayReceiver creation does not have any effect
Alberto Gomez created GEODE-8683: Summary: maximum-time-between-pings parameter in GatewayReceiver creation does not have any effect Key: GEODE-8683 URL: https://issues.apache.org/jira/browse/GEODE-8683 Project: Geode Issue Type: Bug Components: wan Reporter: Alberto Gomez The maximum-time-between-pings parameter than can be set at gateway sender creation has no effect, i.e. the value used as maximum time between pings for gateway sender connections to the gateway sender is either the default value (6) or the one set on the server where the receiver is running. The reason is that the ClientHealthMonitor is a server-side singleton that monitors the health of all clients. The value set for this parameter in the ClientHealthMonitor is first set when the server is started and the Acceptor is created. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (GEODE-8683) maximum-time-between-pings parameter in GatewayReceiver creation does not have any effect
[ https://issues.apache.org/jira/browse/GEODE-8683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alberto Gomez reassigned GEODE-8683: Assignee: Alberto Gomez > maximum-time-between-pings parameter in GatewayReceiver creation does not > have any effect > - > > Key: GEODE-8683 > URL: https://issues.apache.org/jira/browse/GEODE-8683 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: Alberto Gomez >Assignee: Alberto Gomez >Priority: Major > > The maximum-time-between-pings parameter than can be set at gateway sender > creation has no effect, i.e. the value used as maximum time between pings for > gateway sender connections to the gateway sender is either the default value > (6) or the one set on the server where the receiver is running. > The reason is that the ClientHealthMonitor is a server-side singleton that > monitors the health of all clients. The value set for this parameter in the > ClientHealthMonitor is first set when the server is started and the Acceptor > is created. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8656) Ping not sent to the right gateway receiver endpoint when several receivers have the same hostname-for-senders value
[ https://issues.apache.org/jira/browse/GEODE-8656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225378#comment-17225378 ] ASF GitHub Bot commented on GEODE-8656: --- albertogpz commented on pull request #5670: URL: https://github.com/apache/geode/pull/5670#issuecomment-720564213 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Ping not sent to the right gateway receiver endpoint when several receivers > have the same hostname-for-senders value > > > Key: GEODE-8656 > URL: https://issues.apache.org/jira/browse/GEODE-8656 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: Alberto Gomez >Assignee: Alberto Gomez >Priority: Major > Labels: pull-request-available > > When several gateway receivers have the same value for hostname-for-senders > (for example when running Geode under kubernetes and a load balancer balances > the load among the remote servers), the ping messages sent from the gateway > sender client are only sent to the receiver (endpoint) to which the sender > connected first. > The other receivers will not get the ping message which will imply that the > connections towards them will be closed after the configured timeout expires. > This ticket is a continuation of the work done ticket GEODE-7565. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8626) Omitting field-mapping tag of cache.xml when using Simple JDBC Connector
[
https://issues.apache.org/jira/browse/GEODE-8626?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225379#comment-17225379
]
ASF GitHub Bot commented on GEODE-8626:
---
kohlmu-pivotal commented on pull request #5637:
URL: https://github.com/apache/geode/pull/5637#issuecomment-720867380
@masaki-yamakawa I apologize for the delay in reviewing this change.
@jchen21 and @dschneider-pivotal would you be in a position to review this
PR?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Omitting field-mapping tag of cache.xml when using Simple JDBC Connector
>
>
> Key: GEODE-8626
> URL: https://issues.apache.org/jira/browse/GEODE-8626
> Project: Geode
> Issue Type: Improvement
> Components: jdbc
>Reporter: Masaki Yamakawa
>Priority: Minor
> Labels: pull-request-available
>
> When configuring Simple JDBC Connector with gfsh, I don't need to create
> field-mapping, the default field-mapping will be created from pdx and table
> meta data.
> On the other hand, when using cache.xml(cluster.xml), pdx and table meta data
> cannot be used, and field-mapping must be described in cache.xml.
> I would like to create field-mapping defaults based on pdx and table meta
> data when using cache.xml.
> If field-mapping is specified in cache.xml, the xml setting has priority, and
> only if there are no field-mapping tags.
> cache.xml will be as follows:
> {code:java}
>
> data-source="TestDataSource"
> table="employees"
> pdx-name="org.apache.geode.connectors.jdbc.Employee"
> ids="id">
>
>
>
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8655) Not handling exception on SNIHostName
[
https://issues.apache.org/jira/browse/GEODE-8655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225376#comment-17225376
]
ASF GitHub Bot commented on GEODE-8655:
---
mkevo commented on a change in pull request #5669:
URL: https://github.com/apache/geode/pull/5669#discussion_r515954661
##
File path:
geode-core/src/main/java/org/apache/geode/internal/net/SocketCreator.java
##
@@ -846,7 +846,14 @@ private boolean setServerNames(SSLParameters
modifiedParams, HostAndPort addr) {
// ignore - we'll see what happens with endpoint validation using a
numeric address...
}
}
-serverNames.add(new SNIHostName(hostName));
+try {
+ serverNames.add(new SNIHostName(hostName));
+} catch (Exception ex) {
Review comment:
This issue didn't exist before adding
[GEODE-7852](https://issues.apache.org/jira/browse/GEODE-7852).
I can't find it where it catches this exception from the [ticket
description](https://issues.apache.org/jira/browse/GEODE-8655) and where it
logs it. This catch is added to handle this exception:
` java.lang.IllegalArgumentException: Contains non-LDH ASCII characters`
I described a failure in the ticket, and need a help to write test for it as
it is using ipv6 and TLS.
You can try to reproduce it locally. If you need more information to
reproduce the issue please contact me via mail or slack.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Not handling exception on SNIHostName
> -
>
> Key: GEODE-8655
> URL: https://issues.apache.org/jira/browse/GEODE-8655
> Project: Geode
> Issue Type: Bug
> Components: locator, security
>Affects Versions: 1.13.0
>Reporter: Mario Kevo
>Assignee: Mario Kevo
>Priority: Major
> Labels: pull-request-available
>
> If we start locator with ipv6 and TLS enabled we got following error for
> status locator command:
>
> {quote}mkevo@mkevo-XPS-15-9570:~/apache-geode-1.13.0/bin/locator$
> _/usr/lib/jvm/java-8-openjdk-amd64/jre/bin/java -server -classpath
> /home/mkevo/apache-geode-1.13.0/lib/geode-core-1.13.0.jar:/home/mkevo/apache-geode-1.13.0/lib/geode-dependencies.jar
> -Djava.net.preferIPv6Addresses=true
> -DgemfireSecurityPropertyFile=/home/mkevo/geode-examples/clientSecurity/example_security.properties
> -Dgemfire.enable-cluster-configuration=true
> -Dgemfire.load-cluster-configuration-from-dir=false
> -Dgemfire.launcher.registerSignalHandlers=true -Djava.awt.headless=true
> -Dsun.rmi.dgc.server.gcInterval=9223372036854775806
> org.apache.geode.distributed.LocatorLauncher start locator --port=10334_
>
> gfsh>_status locator --dir=/home/mkevo/apache-geode-1.13.0/bin/locator
> --security-properties-file=/home/mkevo/geode-examples/clientSecurity/example_security.properties_
> *Locator in /home/mkevo/apache-geode-1.13.0/bin/locator on
> mkevo-XPS-15-9570[10334] is currently not responding.*
> {quote}
>
> From locator logs we found only this:
> {quote}Exception in processing request from fe80:0:0:0:f83e:ce0f:5143:f9ee%2:
> Read timed out
> {quote}
>
> After adding some logs we found the following:
> {quote}{color:#1d1c1d}TcpClient.stop(): exception connecting to locator
> HostAndPort[/0:0:0:0:0:0:0:0:10334]java.lang.IllegalArgumentException:
> Contains non-LDH ASCII characters{color}
> {quote}
> **
> It fails on creating SNIHostName from hostName(_setServerNames_ in
> SocketCreator.java) as it not handling above exception.
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8676) Update bookbindery to latest
[ https://issues.apache.org/jira/browse/GEODE-8676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225382#comment-17225382 ] ASF GitHub Bot commented on GEODE-8676: --- davebarnes97 commented on pull request #683: URL: https://github.com/apache/geode-native/pull/683#issuecomment-720767960 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update bookbindery to latest > > > Key: GEODE-8676 > URL: https://issues.apache.org/jira/browse/GEODE-8676 > Project: Geode > Issue Type: Improvement > Components: docs, native client >Reporter: Michael Oleske >Priority: Major > Labels: pull-request-available > > [Bookbinder|https://github.com/pivotal-cf/bookbinder/releases] has a new > release and we should keep the tools we use to build our docs up to date -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8672) Concurrent transactional destroy with GII could cause an entry to be removed and version information to be lost
[ https://issues.apache.org/jira/browse/GEODE-8672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225383#comment-17225383 ] ASF GitHub Bot commented on GEODE-8672: --- pivotal-eshu merged pull request #5691: URL: https://github.com/apache/geode/pull/5691 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Concurrent transactional destroy with GII could cause an entry to be removed > and version information to be lost > --- > > Key: GEODE-8672 > URL: https://issues.apache.org/jira/browse/GEODE-8672 > Project: Geode > Issue Type: Bug > Components: regions >Affects Versions: 1.1.0 >Reporter: Eric Shu >Assignee: Eric Shu >Priority: Major > Labels: pull-request-available > Fix For: 1.14.0 > > > In a newly rebalanced bucket, while GII is in progress, a transactional > destroy is applied to cache. There is a logic that it should be in token mode > and leaves the entry as a Destroyed token, even though the version tag of the > entry indicates that it has the correct version. > However, at end of the GII, there is a > cleanUpDestroyedTokensAndMarkGIIComplete method removes all the destroyed > entries – this wipes off the entry version tag information and cause the > subsequent creates starts fresh with new version tags. > This could leads to client server data inconsistency as the newly created > entries will be ignored by the clients as the newly created entry has lower > version number while client has high ones. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8546) Colocated regions missing some buckets after restart
[ https://issues.apache.org/jira/browse/GEODE-8546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225385#comment-17225385 ] ASF GitHub Bot commented on GEODE-8546: --- kohlmu-pivotal commented on pull request #5590: URL: https://github.com/apache/geode/pull/5590#issuecomment-720719096 @mivanac is this PR is still relevant or can it be closed? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Colocated regions missing some buckets after restart > > > Key: GEODE-8546 > URL: https://issues.apache.org/jira/browse/GEODE-8546 > Project: Geode > Issue Type: Bug > Components: regions >Affects Versions: 1.11.0, 1.12.0, 1.13.0 >Reporter: Mario Kevo >Assignee: Mario Kevo >Priority: Major > Labels: pull-request-available > > After restart all servers at the same time, some colocation regions missing > some buckets. > This issue exist for a long time and become visible from 1.11.0 by > introducing this changes GEODE-7042 . > How to reproduce the issue: > # Start two locators and two servers > # Create PARTITION_REDUNDANT_PERSISTENT region with redundant-copies=1 > # Create few PARTITION_REDUNDANT regions(I used six regions) colocated with > persistent region and redundant-copies=1 > # Put some entries. > # Restart servers(you can simply run "kill -15 " and then from > two terminals start both of them at the same time) > # It will take a time to get server startup finished and for the latest > region bucketCount will be lower than expected on one member -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8675) When is enabled in a query, log at the start of the query as well as the end
[
https://issues.apache.org/jira/browse/GEODE-8675?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225386#comment-17225386
]
ASF GitHub Bot commented on GEODE-8675:
---
DonalEvans merged pull request #5690:
URL: https://github.com/apache/geode/pull/5690
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> When is enabled in a query, log at the start of the query as well as
> the end
>
>
> Key: GEODE-8675
> URL: https://issues.apache.org/jira/browse/GEODE-8675
> Project: Geode
> Issue Type: Improvement
> Components: docs, querying
>Reporter: Donal Evans
>Assignee: Donal Evans
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.14.0
>
>
> Currently, if queries are run with prepended to the query,
> the query string, its duration, the number of results, and any indexes used
> are logged at {{info}} level once the query finishes, to aid in query
> debugging. It would be useful to also log the query string when the query
> begins, to help in cases where the query either does not complete, or takes
> an extremely long time to complete.
> Documentation, specifically the Query Debugging page, will also need to be
> updated to describe this new behaviour.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8583) create RestrictedInputValuesParameterRequirements in Redis Module
[ https://issues.apache.org/jira/browse/GEODE-8583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225392#comment-17225392 ] ASF GitHub Bot commented on GEODE-8583: --- jhutchison closed pull request #5604: URL: https://github.com/apache/geode/pull/5604 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > create RestrictedInputValuesParameterRequirements in Redis Module > - > > Key: GEODE-8583 > URL: https://issues.apache.org/jira/browse/GEODE-8583 > Project: Geode > Issue Type: Improvement >Reporter: John Hutchison >Priority: Minor > Labels: pull-request-available, redis > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8583) create RestrictedInputValuesParameterRequirements in Redis Module
[ https://issues.apache.org/jira/browse/GEODE-8583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225396#comment-17225396 ] ASF GitHub Bot commented on GEODE-8583: --- jhutchison commented on pull request #5604: URL: https://github.com/apache/geode/pull/5604#issuecomment-720559420 not needed for intended use case; no other current use cases for this object This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > create RestrictedInputValuesParameterRequirements in Redis Module > - > > Key: GEODE-8583 > URL: https://issues.apache.org/jira/browse/GEODE-8583 > Project: Geode > Issue Type: Improvement >Reporter: John Hutchison >Priority: Minor > Labels: pull-request-available, redis > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8661) Tests only use the latest heavy lifter image
[ https://issues.apache.org/jira/browse/GEODE-8661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225399#comment-17225399 ] ASF GitHub Bot commented on GEODE-8661: --- smgoller opened a new pull request #5697: URL: https://github.com/apache/geode/pull/5697 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, check Concourse for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to d...@geode.apache.org. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Tests only use the latest heavy lifter image > > > Key: GEODE-8661 > URL: https://issues.apache.org/jira/browse/GEODE-8661 > Project: Geode > Issue Type: Bug > Components: ci >Reporter: Sean Goller >Assignee: Sean Goller >Priority: Major > Labels: pull-request-available > > Test jobs should pay attention to the version of the heavy-lifter image > that's being passed to them. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8682) update jetty to recommended version
[ https://issues.apache.org/jira/browse/GEODE-8682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225401#comment-17225401 ] ASF GitHub Bot commented on GEODE-8682: --- onichols-pivotal opened a new pull request #5700: URL: https://github.com/apache/geode/pull/5700 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > update jetty to recommended version > --- > > Key: GEODE-8682 > URL: https://issues.apache.org/jira/browse/GEODE-8682 > Project: Geode > Issue Type: Bug > Components: management >Reporter: Owen Nichols >Priority: Major > Fix For: 1.12.1, 1.14.0, 1.13.1 > > > update jetty to > [9.4.33.v20201020|https://mvnrepository.com/artifact/org.eclipse.jetty/jetty-server/9.4.33.v20201020] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8682) update jetty to recommended version
[ https://issues.apache.org/jira/browse/GEODE-8682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-8682: -- Labels: pull-request-available (was: ) > update jetty to recommended version > --- > > Key: GEODE-8682 > URL: https://issues.apache.org/jira/browse/GEODE-8682 > Project: Geode > Issue Type: Bug > Components: management >Reporter: Owen Nichols >Priority: Major > Labels: pull-request-available > Fix For: 1.12.1, 1.14.0, 1.13.1 > > > update jetty to > [9.4.33.v20201020|https://mvnrepository.com/artifact/org.eclipse.jetty/jetty-server/9.4.33.v20201020] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8605) Alter some GW senders attributes in runtime
[
https://issues.apache.org/jira/browse/GEODE-8605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225403#comment-17225403
]
ASF GitHub Bot commented on GEODE-8605:
---
nabarunnag edited a comment on pull request #5630:
URL: https://github.com/apache/geode/pull/5630#issuecomment-720867436
We will wait to assign the team to review, in case this is decided to have
an RFC, and if more changes are requested. Will review it in case otherwise.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Alter some GW senders attributes in runtime
> ---
>
> Key: GEODE-8605
> URL: https://issues.apache.org/jira/browse/GEODE-8605
> Project: Geode
> Issue Type: New Feature
> Components: docs, gfsh, wan
>Reporter: Mario Ivanac
>Assignee: Mario Ivanac
>Priority: Major
> Labels: needs-review, pull-request-available
>
> We would like to introduce new command "alter gateway-sender" which would
> update some parameters in runtime. For now parameters of interest are:
> * {color:#6a8759}alert-threshold{color}
> * {color:#6a8759}batch-size{color}
> * {color:#6a8759}batch-time-interval{color}
> * {color:#6a8759}group-transaction-events{color}
> * {color:#6a8759}gateway-event-filter{color}
> * {color:#6a8759}gateway-transport-filter{color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8661) Tests only use the latest heavy lifter image
[ https://issues.apache.org/jira/browse/GEODE-8661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225406#comment-17225406 ] ASF GitHub Bot commented on GEODE-8661: --- smgoller merged pull request #5697: URL: https://github.com/apache/geode/pull/5697 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Tests only use the latest heavy lifter image > > > Key: GEODE-8661 > URL: https://issues.apache.org/jira/browse/GEODE-8661 > Project: Geode > Issue Type: Bug > Components: ci >Reporter: Sean Goller >Assignee: Sean Goller >Priority: Major > Labels: pull-request-available > > Test jobs should pay attention to the version of the heavy-lifter image > that's being passed to them. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8681) peer-to-peer message loss due to sending connection closing with TLS enabled
[
https://issues.apache.org/jira/browse/GEODE-8681?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated GEODE-8681:
--
Labels: pull-request-available release-blocker (was: release-blocker)
> peer-to-peer message loss due to sending connection closing with TLS enabled
>
>
> Key: GEODE-8681
> URL: https://issues.apache.org/jira/browse/GEODE-8681
> Project: Geode
> Issue Type: Bug
> Components: membership, messaging
>Affects Versions: 1.10.0, 1.11.0, 1.12.0, 1.13.0
>Reporter: Bruce J Schuchardt
>Assignee: Bruce J Schuchardt
>Priority: Major
> Labels: pull-request-available, release-blocker
>
> We have observed message loss when TLS is enabled and a distributed lock is
> released right after sending a message that doesn't require acknowledgement
> if the sending socket is immediately closed. The closing of sockets
> immediately after sending a message is frequently seen in function execution
> threads or server-side application threads that use this pattern:
> {code:java}
> try {
> DistributedSystem.setThreadsSocketPolicy(false);
> acquireDistributedLock(lockName);
> (perform one or more cache operations)
> } finally {
> distLockService.unlock(lockName);
> DistributedSystem.releaseThreadsSockets(); // closes the socket
> }
> {code}
> The fault seems to be in NioSSLEngine.unwrap(), which throws an
> SSLException() if it finds the SSLEngine is closed even though there is valid
> data in its decrypt buffer. It shouldn't throw an exception in that case.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8681) peer-to-peer message loss due to sending connection closing with TLS enabled
[
https://issues.apache.org/jira/browse/GEODE-8681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225408#comment-17225408
]
ASF GitHub Bot commented on GEODE-8681:
---
bschuchardt opened a new pull request #5699:
URL: https://github.com/apache/geode/pull/5699
A socket-read could pick up more than one message and a single unwrap()
could decrypt multiple messages.
Normally the engine isn't closed and it reports normal
status from an unwrap() operation, and Connection.processInputBuffer
picks up each message, one by one, from the buffer and dispatches them.
But if the SSLEngine is closed we were ignoring any already-decrypted
data sitting in the unwrapped buffer and instead we were throwing an
SSLException.
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to d...@geode.apache.org.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> peer-to-peer message loss due to sending connection closing with TLS enabled
>
>
> Key: GEODE-8681
> URL: https://issues.apache.org/jira/browse/GEODE-8681
> Project: Geode
> Issue Type: Bug
> Components: membership, messaging
>Affects Versions: 1.10.0, 1.11.0, 1.12.0, 1.13.0
>Reporter: Bruce J Schuchardt
>Assignee: Bruce J Schuchardt
>Priority: Major
> Labels: release-blocker
>
> We have observed message loss when TLS is enabled and a distributed lock is
> released right after sending a message that doesn't require acknowledgement
> if the sending socket is immediately closed. The closing of sockets
> immediately after sending a message is frequently seen in function execution
> threads or server-side application threads that use this pattern:
> {code:java}
> try {
> DistributedSystem.setThreadsSocketPolicy(false);
> acquireDistributedLock(lockName);
> (perform one or more cache operations)
> } finally {
> distLockService.unlock(lockName);
> DistributedSystem.releaseThreadsSockets(); // closes the socket
> }
> {code}
> The fault seems to be in NioSSLEngine.unwrap(), which throws an
> SSLException() if it finds the SSLEngine is closed even though there is valid
> data in its decrypt buffer. It shouldn't throw an exception in that case.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8605) Alter some GW senders attributes in runtime
[
https://issues.apache.org/jira/browse/GEODE-8605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225411#comment-17225411
]
ASF GitHub Bot commented on GEODE-8605:
---
nabarunnag commented on pull request #5630:
URL: https://github.com/apache/geode/pull/5630#issuecomment-720867436
Will wait assign team to review, in case this is decided to have an RFC, and
if more changes are requested. Will review it in case otherwise.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Alter some GW senders attributes in runtime
> ---
>
> Key: GEODE-8605
> URL: https://issues.apache.org/jira/browse/GEODE-8605
> Project: Geode
> Issue Type: New Feature
> Components: docs, gfsh, wan
>Reporter: Mario Ivanac
>Assignee: Mario Ivanac
>Priority: Major
> Labels: needs-review, pull-request-available
>
> We would like to introduce new command "alter gateway-sender" which would
> update some parameters in runtime. For now parameters of interest are:
> * {color:#6a8759}alert-threshold{color}
> * {color:#6a8759}batch-size{color}
> * {color:#6a8759}batch-time-interval{color}
> * {color:#6a8759}group-transaction-events{color}
> * {color:#6a8759}gateway-event-filter{color}
> * {color:#6a8759}gateway-transport-filter{color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8605) Alter some GW senders attributes in runtime
[
https://issues.apache.org/jira/browse/GEODE-8605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225410#comment-17225410
]
ASF GitHub Bot commented on GEODE-8605:
---
mivanac commented on pull request #5630:
URL: https://github.com/apache/geode/pull/5630#issuecomment-721001848
RFC created
https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=165223754
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Alter some GW senders attributes in runtime
> ---
>
> Key: GEODE-8605
> URL: https://issues.apache.org/jira/browse/GEODE-8605
> Project: Geode
> Issue Type: New Feature
> Components: docs, gfsh, wan
>Reporter: Mario Ivanac
>Assignee: Mario Ivanac
>Priority: Major
> Labels: needs-review, pull-request-available
>
> We would like to introduce new command "alter gateway-sender" which would
> update some parameters in runtime. For now parameters of interest are:
> * {color:#6a8759}alert-threshold{color}
> * {color:#6a8759}batch-size{color}
> * {color:#6a8759}batch-time-interval{color}
> * {color:#6a8759}group-transaction-events{color}
> * {color:#6a8759}gateway-event-filter{color}
> * {color:#6a8759}gateway-transport-filter{color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8293) activeCQCount has negative value
[
https://issues.apache.org/jira/browse/GEODE-8293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225409#comment-17225409
]
ASF GitHub Bot commented on GEODE-8293:
---
kohlmu-pivotal commented on a change in pull request #5620:
URL: https://github.com/apache/geode/pull/5620#discussion_r516386386
##
File path:
geode-cq/src/distributedTest/java/org/apache/geode/cache/query/cq/CQMetricsDUnitTest.java
##
@@ -0,0 +1,169 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express
+ * or implied. See the License for the specific language governing permissions
and limitations under
+ * the License.
+ */
+package org.apache.geode.cache.query.cq;
+
+import static org.apache.geode.test.awaitility.GeodeAwaitility.await;
+import static org.apache.geode.test.dunit.rules.ClusterStartupRule.getCache;
+import static org.assertj.core.api.Assertions.assertThat;
+
+import java.io.Serializable;
+
+import org.junit.Before;
+import org.junit.Rule;
+import org.junit.Test;
+
+import org.apache.geode.cache.Cache;
+import org.apache.geode.cache.Region;
+import org.apache.geode.cache.client.ClientCache;
+import org.apache.geode.cache.client.ClientCacheFactory;
+import org.apache.geode.cache.client.ClientRegionShortcut;
+import org.apache.geode.cache.query.CqAttributes;
+import org.apache.geode.cache.query.CqAttributesFactory;
+import org.apache.geode.cache.query.CqEvent;
+import org.apache.geode.cache.query.CqListener;
+import org.apache.geode.cache.query.CqServiceStatistics;
+import org.apache.geode.cache.query.QueryService;
+import org.apache.geode.cache.query.data.Portfolio;
+import org.apache.geode.management.DistributedSystemMXBean;
+import org.apache.geode.management.ManagementService;
+import org.apache.geode.test.dunit.rules.ClusterStartupRule;
+import org.apache.geode.test.dunit.rules.MemberVM;
+import org.apache.geode.test.junit.rules.GfshCommandRule;
+
+public class CQMetricsDUnitTest {
+
+ private CqAttributes cqa;
+ private QueryService qs;
+ private TestCqListener testListener;
+ private MemberVM locator, server1, server2;
+
+ @Rule
+ public ClusterStartupRule cluster = new ClusterStartupRule(5);
+
+ @Rule
+ public GfshCommandRule gfsh = new GfshCommandRule();
+
+ @Before
+ public void setUpServers() throws Exception {
+locator = cluster.startLocatorVM(0, l ->
l.withoutClusterConfigurationService());
+server1 = cluster.startServerVM(1, locator.getPort());
+server2 = cluster.startServerVM(2, locator.getPort());
+
+ClientCache clientCache = createClientCache(locator.getPort());
+Region region =
+
clientCache.createClientRegionFactory(ClientRegionShortcut.CACHING_PROXY).create("region");
+
+qs = clientCache.getQueryService();
+CqAttributesFactory cqaf = new CqAttributesFactory();
+testListener = new TestCqListener();
+cqaf.addCqListener(testListener);
+
+cqa = cqaf.create();
+gfsh.connectAndVerify(locator);
+ }
+
+ @Test
+ public void testStopCq() throws Exception {
+gfsh.executeAndAssertThat("create region --name=region --type=PARTITION")
+.statusIsSuccess();
+qs.newCq("Select * from /region r where r.ID = 1", cqa).execute();
+
+server1.invoke(() -> populateRegion(0, 100));
+
+locator.invoke(() -> {
+ Cache cache = getCache();
+ ManagementService service =
ManagementService.getManagementService(cache);
+ DistributedSystemMXBean dsmbean = service.getDistributedSystemMXBean();
+ await().untilAsserted(() ->
assertThat(dsmbean.getActiveCQCount()).isEqualTo(2));
+});
+
+// stop cq
+qs.stopCqs();
+
+locator.invoke(() -> {
+ Cache cache = getCache();
+ ManagementService service =
ManagementService.getManagementService(cache);
+ DistributedSystemMXBean dsmbean = service.getDistributedSystemMXBean();
+ await().untilAsserted(() ->
assertThat(dsmbean.getActiveCQCount()).isEqualTo(0));
+});
+
+checkActiveCqCount(server1, 0);
+checkActiveCqCount(server2, 0);
+ }
+
+ @Test
+ public void testCloseCq() throws Exception {
+gfsh.executeAndAssertThat("create region --name=region --type=PARTITION")
+.statusIsSuccess();
+qs.newCq("Select * from /region r where r.ID = 1", cqa).execute();
+
+server1.invoke(() -> populateRegion(0, 100));
+
[jira] [Commented] (GEODE-8546) Colocated regions missing some buckets after restart
[ https://issues.apache.org/jira/browse/GEODE-8546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225415#comment-17225415 ] ASF GitHub Bot commented on GEODE-8546: --- mkevo commented on pull request #5590: URL: https://github.com/apache/geode/pull/5590#issuecomment-721092745 Hi @kohlmu-pivotal , We are trying to write a test, but without success. @DonalEvans suggest us to use **PartitionListener interface**, specifically, overriding the afterBucketCreated() method to artificially slow down colocation and make it possible to hit the issue more easily. But we don't have an idea how to slow down colocation. We hit the issue only if we add sleep for more than 15 seconds, but it is hardcoded and fix will not working it as it will always wait for hardcoded value. If you or someone else can help with this, we will appreciate it. If you want I can send you detail steps how to reproduce the issue locally via mail. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Colocated regions missing some buckets after restart > > > Key: GEODE-8546 > URL: https://issues.apache.org/jira/browse/GEODE-8546 > Project: Geode > Issue Type: Bug > Components: regions >Affects Versions: 1.11.0, 1.12.0, 1.13.0 >Reporter: Mario Kevo >Assignee: Mario Kevo >Priority: Major > Labels: pull-request-available > > After restart all servers at the same time, some colocation regions missing > some buckets. > This issue exist for a long time and become visible from 1.11.0 by > introducing this changes GEODE-7042 . > How to reproduce the issue: > # Start two locators and two servers > # Create PARTITION_REDUNDANT_PERSISTENT region with redundant-copies=1 > # Create few PARTITION_REDUNDANT regions(I used six regions) colocated with > persistent region and redundant-copies=1 > # Put some entries. > # Restart servers(you can simply run "kill -15 " and then from > two terminals start both of them at the same time) > # It will take a time to get server startup finished and for the latest > region bucketCount will be lower than expected on one member -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8444) When requester's RVV equals provider's rvvGC, should do fullGII
[ https://issues.apache.org/jira/browse/GEODE-8444?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225417#comment-17225417 ] ASF GitHub Bot commented on GEODE-8444: --- kohlmu-pivotal commented on pull request #5467: URL: https://github.com/apache/geode/pull/5467#issuecomment-720806309 @dschneider-pivotal would you possibly be able to review this. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > When requester's RVV equals provider's rvvGC, should do fullGII > > > Key: GEODE-8444 > URL: https://issues.apache.org/jira/browse/GEODE-8444 > Project: Geode > Issue Type: Improvement >Reporter: Xiaojian Zhou >Assignee: Xiaojian Zhou >Priority: Major > Labels: GeodeOperationAPI, pull-request-available > > In current design, when requester's RVV equals provider's rvvGC, we treated > as dominated. > But if the last operation at provider is a destroy and the tombstone is GCed > when requester is offline, the provider lost the information about this key > when GII. So we should do fullGII instead of deltaGII in this case. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8647) Support using multiple DistributedMap Rules in one test
[
https://issues.apache.org/jira/browse/GEODE-8647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225419#comment-17225419
]
ASF GitHub Bot commented on GEODE-8647:
---
pivotal-jbarrett commented on a change in pull request #682:
URL: https://github.com/apache/geode-native/pull/682#discussion_r516176141
##
File path: clicache/src/DataInput.cpp
##
@@ -878,8 +877,6 @@ namespace Apache
void DataInput::Cleanup()
{
Review comment:
If this method is empty perhaps we can remove it?
##
File path: clicache/src/DataInput.hpp
##
@@ -663,7 +664,7 @@ namespace Apache
m_buffer =
const_cast(nativeptr->currentBufferPosition());
if ( m_buffer != NULL) {
m_bufferLength =
static_cast(nativeptr->getBytesRemaining());
- }
+ }
Review comment:
Some strange formatting mess here.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Support using multiple DistributedMap Rules in one test
> ---
>
> Key: GEODE-8647
> URL: https://issues.apache.org/jira/browse/GEODE-8647
> Project: Geode
> Issue Type: Wish
> Components: tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>Priority: Major
> Labels: pull-request-available
>
> Support using multiple DistributedMap Rules in one test. Right now the Rule
> only supports having one instance in a test.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8547) Command "show missing-disk-stores" not working, when all servers are down
[ https://issues.apache.org/jira/browse/GEODE-8547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225424#comment-17225424 ] ASF GitHub Bot commented on GEODE-8547: --- mivanac commented on pull request #5567: URL: https://github.com/apache/geode/pull/5567#issuecomment-720912624 Hi, when I remove my changes in ShowMissingDiskStoreCommand, this TC fails. Problem here is that without these changes, command is rejected, with message "No caching members found". This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Command "show missing-disk-stores" not working, when all servers are down > - > > Key: GEODE-8547 > URL: https://issues.apache.org/jira/browse/GEODE-8547 > Project: Geode > Issue Type: Bug > Components: gfsh >Reporter: Mario Ivanac >Assignee: Mario Ivanac >Priority: Major > Labels: needs-review, pull-request-available > > If cluster with 2 locators and 2 servers was ungracefully shutdown it can > happen that locators that are able to start up are not having most recent > data to bring up Cluster Configuration Service. > If we excute command "show missing-disk-stores" it will not work, since all > servers are down, > so we are stuck in this situation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8661) Tests only use the latest heavy lifter image
[ https://issues.apache.org/jira/browse/GEODE-8661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225427#comment-17225427 ] ASF GitHub Bot commented on GEODE-8661: --- smgoller commented on pull request #5697: URL: https://github.com/apache/geode/pull/5697#issuecomment-720629404 Fixing Mass Test Run. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Tests only use the latest heavy lifter image > > > Key: GEODE-8661 > URL: https://issues.apache.org/jira/browse/GEODE-8661 > Project: Geode > Issue Type: Bug > Components: ci >Reporter: Sean Goller >Assignee: Sean Goller >Priority: Major > Labels: pull-request-available > > Test jobs should pay attention to the version of the heavy-lifter image > that's being passed to them. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8668) Implement Redis SELECT command
[
https://issues.apache.org/jira/browse/GEODE-8668?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225425#comment-17225425
]
ASF GitHub Bot commented on GEODE-8668:
---
sabbey37 merged pull request #5682:
URL: https://github.com/apache/geode/pull/5682
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Implement Redis SELECT command
> --
>
> Key: GEODE-8668
> URL: https://issues.apache.org/jira/browse/GEODE-8668
> Project: Geode
> Issue Type: Improvement
> Components: redis
>Reporter: Sarah Abbey
>Assignee: Sarah Abbey
>Priority: Minor
> Labels: pull-request-available
> Fix For: 1.14.0
>
>
> We are implementing [SELECT|https://redis.io/commands/select] because some
> Redis analysis tools (like Redis Insight) require the {{SELECT}} command in
> order to function properly. {{SELECT}} returns {{ERR Only DB 0 supported}}
> if anything other than 0 is passed in as a DB index argument.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8605) Alter some GW senders attributes in runtime
[
https://issues.apache.org/jira/browse/GEODE-8605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225429#comment-17225429
]
ASF GitHub Bot commented on GEODE-8605:
---
kohlmu-pivotal commented on pull request #5630:
URL: https://github.com/apache/geode/pull/5630#issuecomment-720868290
@nabarunnag thank you for the response. I would prefer if this feature
change goes through an RFC process, as I believe that there might be more
fields that we would want to change at runtime, or scenarios that we will have
to consider.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Alter some GW senders attributes in runtime
> ---
>
> Key: GEODE-8605
> URL: https://issues.apache.org/jira/browse/GEODE-8605
> Project: Geode
> Issue Type: New Feature
> Components: docs, gfsh, wan
>Reporter: Mario Ivanac
>Assignee: Mario Ivanac
>Priority: Major
> Labels: needs-review, pull-request-available
>
> We would like to introduce new command "alter gateway-sender" which would
> update some parameters in runtime. For now parameters of interest are:
> * {color:#6a8759}alert-threshold{color}
> * {color:#6a8759}batch-size{color}
> * {color:#6a8759}batch-time-interval{color}
> * {color:#6a8759}group-transaction-events{color}
> * {color:#6a8759}gateway-event-filter{color}
> * {color:#6a8759}gateway-transport-filter{color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8020) buffer corruption in SSL communications
[
https://issues.apache.org/jira/browse/GEODE-8020?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225431#comment-17225431
]
ASF GitHub Bot commented on GEODE-8020:
---
Bill opened a new pull request #5698:
URL: https://github.com/apache/geode/pull/5698
* GEODE-8020: buffer management problems
This fixes some buffer handling in MsgStreamerList and alters
MstStreamer to avoid creating MsgStreamerList and VersionedMsgStreamers
during normal, non-upgrade, operations.
It also changes NioSslEngine to use synchronization in more places,
notably the close() method, which was possibly allowing multiple threads to
change the state of the engine.
* revert unnecessary change to ClusterCommunicationsDUnitTest
* fixing another null version check
* renamed new BufferPool property
* restore logging of ssl exceptions
(cherry picked from commit 7375c591f25bbba413237aed1f56f8a9f70075df)
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to d...@geode.apache.org.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> buffer corruption in SSL communications
> ---
>
> Key: GEODE-8020
> URL: https://issues.apache.org/jira/browse/GEODE-8020
> Project: Geode
> Issue Type: Bug
> Components: membership, messaging
>Reporter: Bruce J Schuchardt
>Assignee: Bruce J Schuchardt
>Priority: Major
> Fix For: 1.13.0, 1.14.0
>
>
> update: May 8, 2020: the main problem described here seemed to only occur on
> JDK8 when TLSv1 is used. JDK11 with TLSv1 doesn't exhibit the problem. Nor is
> the problem apparent when TLSv1.2 is used on either JDK. This issue is marked
> resolved but the problem still occurs on JDK8 with TLSv1. Recommend customers
> use TLSv1.2 or later. Other buffering problems were found in this
> investigation and a PR was merged to address those.
> When running an application with SSL enabled I ran into a hang with a lost
> message. The sender had a 15 second ack-wait warning pointing to another
> server in the cluster. That server had this in its log file at the time the
> message would have been processed:
> {noformat}
> [info 2020/04/21 11:22:39.437 PDT rs-bschuchardt-1053-hydra-client-1(bridgegemfire4_host1_12599:12599):41003
> unshared ordered uid=354 dom #2 port=55262> tid=0xad] P2P message
> reader@2580db5f io exception for
> rs-bschuchardt-1053-hydra-client-1(bridgegemfire4_host1_12599:12599):41003@354(GEODE
> 1.10.0)
> javax.net.ssl.SSLException: bad record MAC
> at sun.security.ssl.Alerts.getSSLException(Alerts.java:214)
> at sun.security.ssl.SSLEngineImpl.fatal(SSLEngineImpl.java:1728)
> at sun.security.ssl.SSLEngineImpl.readRecord(SSLEngineImpl.java:986)
> at sun.security.ssl.SSLEngineImpl.readNetRecord(SSLEngineImpl.java:912)
> at sun.security.ssl.SSLEngineImpl.unwrap(SSLEngineImpl.java:782)
> at javax.net.ssl.SSLEngine.unwrap(SSLEngine.java:626)
> at
> org.apache.geode.internal.net.NioSslEngine.unwrap(NioSslEngine.java:275)
> at
> org.apache.geode.internal.tcp.Connection.processInputBuffer(Connection.java:2894)
> at
> org.apache.geode.internal.tcp.Connection.readMessages(Connection.java:1745)
> at org.apache.geode.internal.tcp.Connection.run(Connection.java:1577)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> Caused by: javax.crypto.BadPaddin
[jira] [Updated] (GEODE-8020) buffer corruption in SSL communications
[
https://issues.apache.org/jira/browse/GEODE-8020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated GEODE-8020:
--
Labels: pull-request-available (was: )
> buffer corruption in SSL communications
> ---
>
> Key: GEODE-8020
> URL: https://issues.apache.org/jira/browse/GEODE-8020
> Project: Geode
> Issue Type: Bug
> Components: membership, messaging
>Reporter: Bruce J Schuchardt
>Assignee: Bruce J Schuchardt
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.13.0, 1.14.0
>
>
> update: May 8, 2020: the main problem described here seemed to only occur on
> JDK8 when TLSv1 is used. JDK11 with TLSv1 doesn't exhibit the problem. Nor is
> the problem apparent when TLSv1.2 is used on either JDK. This issue is marked
> resolved but the problem still occurs on JDK8 with TLSv1. Recommend customers
> use TLSv1.2 or later. Other buffering problems were found in this
> investigation and a PR was merged to address those.
> When running an application with SSL enabled I ran into a hang with a lost
> message. The sender had a 15 second ack-wait warning pointing to another
> server in the cluster. That server had this in its log file at the time the
> message would have been processed:
> {noformat}
> [info 2020/04/21 11:22:39.437 PDT rs-bschuchardt-1053-hydra-client-1(bridgegemfire4_host1_12599:12599):41003
> unshared ordered uid=354 dom #2 port=55262> tid=0xad] P2P message
> reader@2580db5f io exception for
> rs-bschuchardt-1053-hydra-client-1(bridgegemfire4_host1_12599:12599):41003@354(GEODE
> 1.10.0)
> javax.net.ssl.SSLException: bad record MAC
> at sun.security.ssl.Alerts.getSSLException(Alerts.java:214)
> at sun.security.ssl.SSLEngineImpl.fatal(SSLEngineImpl.java:1728)
> at sun.security.ssl.SSLEngineImpl.readRecord(SSLEngineImpl.java:986)
> at sun.security.ssl.SSLEngineImpl.readNetRecord(SSLEngineImpl.java:912)
> at sun.security.ssl.SSLEngineImpl.unwrap(SSLEngineImpl.java:782)
> at javax.net.ssl.SSLEngine.unwrap(SSLEngine.java:626)
> at
> org.apache.geode.internal.net.NioSslEngine.unwrap(NioSslEngine.java:275)
> at
> org.apache.geode.internal.tcp.Connection.processInputBuffer(Connection.java:2894)
> at
> org.apache.geode.internal.tcp.Connection.readMessages(Connection.java:1745)
> at org.apache.geode.internal.tcp.Connection.run(Connection.java:1577)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at java.lang.Thread.run(Thread.java:748)
> Caused by: javax.crypto.BadPaddingException: bad record MAC
> at sun.security.ssl.InputRecord.decrypt(InputRecord.java:219)
> at
> sun.security.ssl.EngineInputRecord.decrypt(EngineInputRecord.java:177)
> at sun.security.ssl.SSLEngineImpl.readRecord(SSLEngineImpl.java:979)
> ... 10 more
> {noformat}
> I bisected to see when this problem was introduced and found it was this
> commit:
> {noformat}
> commit 418d929e3e03185cd6330c828c9b9ed395a76d4b
> Author: Mario Ivanac <48509724+miva...@users.noreply.github.com>
> Date: Fri Nov 1 20:28:57 2019 +0100
> GEODE-6661: Fixed use of Direct and Non-Direct buffers (#4267)
> - Fixed use of Direct and Non-Direct buffers
> {noformat}
> That commit modified the NioSSLEngine to use a "direct" byte buffer instead
> of a heap byte buffer. If I revert that one part of the PR the test works
> okay.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-7679) Partitioned Region clear is successful while region is being altered
[
https://issues.apache.org/jira/browse/GEODE-7679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225434#comment-17225434
]
ASF GitHub Bot commented on GEODE-7679:
---
jchen21 commented on a change in pull request #5516:
URL: https://github.com/apache/geode/pull/5516#discussion_r516337589
##
File path:
geode-core/src/distributedTest/java/org/apache/geode/internal/cache/PartitionedRegionClearWithAlterRegionDUnitTest.java
##
@@ -0,0 +1,533 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express
+ * or implied. See the License for the specific language governing permissions
and limitations under
+ * the License.
+ */
+package org.apache.geode.internal.cache;
+
+import static org.apache.geode.test.awaitility.GeodeAwaitility.await;
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
+
+import java.io.Serializable;
+import java.util.concurrent.ExecutionException;
+import java.util.concurrent.Future;
+import java.util.concurrent.TimeoutException;
+import java.util.stream.IntStream;
+
+import org.junit.Rule;
+import org.junit.Test;
+
+import org.apache.geode.cache.AttributesMutator;
+import org.apache.geode.cache.CacheListener;
+import org.apache.geode.cache.CacheLoader;
+import org.apache.geode.cache.CacheLoaderException;
+import org.apache.geode.cache.CacheWriter;
+import org.apache.geode.cache.CacheWriterException;
+import org.apache.geode.cache.EntryEvent;
+import org.apache.geode.cache.ExpirationAction;
+import org.apache.geode.cache.ExpirationAttributes;
+import org.apache.geode.cache.LoaderHelper;
+import org.apache.geode.cache.PartitionedRegionPartialClearException;
+import org.apache.geode.cache.Region;
+import org.apache.geode.cache.RegionEvent;
+import org.apache.geode.cache.RegionShortcut;
+import org.apache.geode.distributed.internal.ClusterDistributionManager;
+import org.apache.geode.distributed.internal.DistributionMessage;
+import org.apache.geode.distributed.internal.DistributionMessageObserver;
+import org.apache.geode.distributed.internal.InternalDistributedSystem;
+import
org.apache.geode.distributed.internal.membership.api.MembershipManagerHelper;
+import org.apache.geode.test.dunit.AsyncInvocation;
+import org.apache.geode.test.dunit.DUnitBlackboard;
+import org.apache.geode.test.dunit.VM;
+import org.apache.geode.test.dunit.rules.CacheRule;
+import org.apache.geode.test.dunit.rules.DistributedRule;
+import org.apache.geode.test.junit.rules.ExecutorServiceRule;
+
+public class PartitionedRegionClearWithAlterRegionDUnitTest implements
Serializable {
+
+ @Rule
+ public DistributedRule distributedRule = new DistributedRule();
+
+ @Rule
+ public CacheRule cacheRule = new CacheRule();
+
+ @Rule
+ public ExecutorServiceRule executorServiceRule = new ExecutorServiceRule();
+
+ private VM server1;
+
+ private VM server2;
+
+ private VM server3;
+
+ private static volatile DUnitBlackboard blackboard;
+
+ private static final String REGION_NAME = "testRegion";
+
+ private static final int NUM_ENTRIES = 100;
+
+ private static final String GATE_NAME = "ALLOW_ALTER_REGION";
+
+ private void initialize() {
+server1 = VM.getVM(0);
+server2 = VM.getVM(1);
+
+server1.invoke(() -> {
+ cacheRule.createCache();
+
cacheRule.getCache().createRegionFactory(RegionShortcut.PARTITION).setStatisticsEnabled(true)
+ .create(REGION_NAME);
+});
+
+server2.invoke(() -> {
+ cacheRule.createCache();
+
cacheRule.getCache().createRegionFactory(RegionShortcut.PARTITION).setStatisticsEnabled(true)
+ .create(REGION_NAME);
+});
+
+server1.invoke(() -> {
+ populateRegion();
+ Region region = cacheRule.getCache().getRegion(REGION_NAME);
+ assertThat(region.size()).isEqualTo(NUM_ENTRIES);
+});
+
+server2.invoke(() -> {
+ Region region = cacheRule.getCache().getRegion(REGION_NAME);
+ assertThat(region.size()).isEqualTo(NUM_ENTRIES);
+});
+ }
+
+ @Test
+ public void testClearRegionWhileAddingCacheLoader() throws
InterruptedException {
+initialize();
+
+AsyncInvocation asyncInvocation1 = server1.invokeAsync(() -> {
+
DistributionMessageObserver.setInstance(getDistributionMessageObserver());
+
[jira] [Commented] (GEODE-8605) Alter some GW senders attributes in runtime
[
https://issues.apache.org/jira/browse/GEODE-8605?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225433#comment-17225433
]
ASF GitHub Bot commented on GEODE-8605:
---
mivanac edited a comment on pull request #5630:
URL: https://github.com/apache/geode/pull/5630#issuecomment-721001848
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Alter some GW senders attributes in runtime
> ---
>
> Key: GEODE-8605
> URL: https://issues.apache.org/jira/browse/GEODE-8605
> Project: Geode
> Issue Type: New Feature
> Components: docs, gfsh, wan
>Reporter: Mario Ivanac
>Assignee: Mario Ivanac
>Priority: Major
> Labels: needs-review, pull-request-available
>
> We would like to introduce new command "alter gateway-sender" which would
> update some parameters in runtime. For now parameters of interest are:
> * {color:#6a8759}alert-threshold{color}
> * {color:#6a8759}batch-size{color}
> * {color:#6a8759}batch-time-interval{color}
> * {color:#6a8759}group-transaction-events{color}
> * {color:#6a8759}gateway-event-filter{color}
> * {color:#6a8759}gateway-transport-filter{color}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8329) Durable CQ not registered as durable after server failover
[
https://issues.apache.org/jira/browse/GEODE-8329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225439#comment-17225439
]
ASF GitHub Bot commented on GEODE-8329:
---
kohlmu-pivotal commented on pull request #5360:
URL: https://github.com/apache/geode/pull/5360#issuecomment-720804056
@agingade do you have further comments on this PR?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Durable CQ not registered as durable after server failover
> --
>
> Key: GEODE-8329
> URL: https://issues.apache.org/jira/browse/GEODE-8329
> Project: Geode
> Issue Type: Bug
>Reporter: Jakov Varenina
>Assignee: Jakov Varenina
>Priority: Major
> Labels: pull-request-available
>
> {color:#172b4d}It seems that aftter server failover the java client is
> wrongly re-registering CQ on new server as not durable. Command *list
> durable-cq* prints that there are no durable CQ which is correct, since CQ is
> wrongly registered by client as not durable and therefore following
> printout:{color}
> {code:java}
> gfsh>list durable-cqs --durable-client-id=AppCounters
> Member | Status | CQ Name
> --- | --- |
> server1 | OK | randomTracker
> server2 | IGNORED | No client found with client-id : AppCounters
> server3 | IGNORED | No client found with client-id : AppCounters
>
> after shutdown of server1:
>
> gfsh>list durable-cqs --durable-client-id=AppCounters
> Member | Status | CQ Name
> --- | --- |
> ---
> server2 | IGNORED | No durable cqs found for durable-client-id :
> "AppCounters". --> server2 is hosting CQ, but it is not flagged as durable
> server3 | IGNORED | No client found with client-id : AppCounters{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8656) Ping not sent to the right gateway receiver endpoint when several receivers have the same hostname-for-senders value
[ https://issues.apache.org/jira/browse/GEODE-8656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225440#comment-17225440 ] ASF GitHub Bot commented on GEODE-8656: --- Bill commented on pull request #5670: URL: https://github.com/apache/geode/pull/5670#issuecomment-720610506 @albertogpz if you want to use Docker in your tests, yeah, the easiest way to do that right now is to make your test an "acceptanceTest" which means putting it in an `/geode-assembly/src/acceptanceTest` hierarchy. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Ping not sent to the right gateway receiver endpoint when several receivers > have the same hostname-for-senders value > > > Key: GEODE-8656 > URL: https://issues.apache.org/jira/browse/GEODE-8656 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: Alberto Gomez >Assignee: Alberto Gomez >Priority: Major > Labels: pull-request-available > > When several gateway receivers have the same value for hostname-for-senders > (for example when running Geode under kubernetes and a load balancer balances > the load among the remote servers), the ping messages sent from the gateway > sender client are only sent to the receiver (endpoint) to which the sender > connected first. > The other receivers will not get the ping message which will imply that the > connections towards them will be closed after the configured timeout expires. > This ticket is a continuation of the work done ticket GEODE-7565. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (GEODE-8677) Confirm binary data storage in Geode Redis is independent of encoding
[ https://issues.apache.org/jira/browse/GEODE-8677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarah Abbey reassigned GEODE-8677: -- Assignee: Raymond Ingles > Confirm binary data storage in Geode Redis is independent of encoding > - > > Key: GEODE-8677 > URL: https://issues.apache.org/jira/browse/GEODE-8677 > Project: Geode > Issue Type: Improvement > Components: redis >Affects Versions: 1.14.0 >Reporter: Raymond Ingles >Assignee: Raymond Ingles >Priority: Major > > Current Geode Redis tests are not comprehensive enough to ensure that binary > data is always returned correctly. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-8677) Confirm binary data storage in Geode Redis is independent of encoding
[ https://issues.apache.org/jira/browse/GEODE-8677?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sarah Abbey resolved GEODE-8677. Fix Version/s: 1.14.0 Resolution: Fixed > Confirm binary data storage in Geode Redis is independent of encoding > - > > Key: GEODE-8677 > URL: https://issues.apache.org/jira/browse/GEODE-8677 > Project: Geode > Issue Type: Improvement > Components: redis >Affects Versions: 1.14.0 >Reporter: Raymond Ingles >Assignee: Raymond Ingles >Priority: Major > Fix For: 1.14.0 > > > Current Geode Redis tests are not comprehensive enough to ensure that binary > data is always returned correctly. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8676) Update bookbindery to latest
[ https://issues.apache.org/jira/browse/GEODE-8676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225448#comment-17225448 ] ASF GitHub Bot commented on GEODE-8676: --- davebarnes97 edited a comment on pull request #683: URL: https://github.com/apache/geode-native/pull/683#issuecomment-720767960 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Update bookbindery to latest > > > Key: GEODE-8676 > URL: https://issues.apache.org/jira/browse/GEODE-8676 > Project: Geode > Issue Type: Improvement > Components: docs, native client >Reporter: Michael Oleske >Priority: Major > Labels: pull-request-available > > [Bookbinder|https://github.com/pivotal-cf/bookbinder/releases] has a new > release and we should keep the tools we use to build our docs up to date -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8672) Concurrent transactional destroy with GII could cause an entry to be removed and version information to be lost
[
https://issues.apache.org/jira/browse/GEODE-8672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225451#comment-17225451
]
ASF GitHub Bot commented on GEODE-8672:
---
kohlmu-pivotal commented on a change in pull request #5691:
URL: https://github.com/apache/geode/pull/5691#discussion_r516206148
##
File path:
geode-core/src/distributedTest/java/org/apache/geode/internal/cache/control/RebalanceOperationDistributedTest.java
##
@@ -2820,68 +2823,58 @@ private void doRebalance() throws TimeoutException,
InterruptedException {
private void doConcurrentPutInTx(String s) throws Exception {
for (int i = 0; i < totalNumberOfBuckets; i++) {
- synchronized (list) {
-list.add(i);
- }
-}
-
-Thread[] threads = new Thread[totalNumberOfBuckets];
-for (int i = 0; i < totalNumberOfBuckets; i++) {
- threads[i] = new Thread(() -> doPutOpInTx(s));
+ queue.add(i);
}
+ExecutorService pool = Executors.newCachedThreadPool();
+Future[] futures = new Future[totalNumberOfBuckets];
for (int i = 0; i < totalNumberOfBuckets; i++) {
- threads[i].start();
+ futures[i] = pool.submit(() -> doPutOpInTx(s));
Review comment:
I was more thinking in the line of using the `invokeAll` rather than the
single `submit`. With `invokeAll` you can create all the operations up front
and then invoke all of them at the same time.
Are we not concerned that if we do it this way, that there is a possibility
that the concurrency issue is possibly not ever hit?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Concurrent transactional destroy with GII could cause an entry to be removed
> and version information to be lost
> ---
>
> Key: GEODE-8672
> URL: https://issues.apache.org/jira/browse/GEODE-8672
> Project: Geode
> Issue Type: Bug
> Components: regions
>Affects Versions: 1.1.0
>Reporter: Eric Shu
>Assignee: Eric Shu
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.14.0
>
>
> In a newly rebalanced bucket, while GII is in progress, a transactional
> destroy is applied to cache. There is a logic that it should be in token mode
> and leaves the entry as a Destroyed token, even though the version tag of the
> entry indicates that it has the correct version.
> However, at end of the GII, there is a
> cleanUpDestroyedTokensAndMarkGIIComplete method removes all the destroyed
> entries – this wipes off the entry version tag information and cause the
> subsequent creates starts fresh with new version tags.
> This could leads to client server data inconsistency as the newly created
> entries will be ignored by the clients as the newly created entry has lower
> version number while client has high ones.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8656) Ping not sent to the right gateway receiver endpoint when several receivers have the same hostname-for-senders value
[ https://issues.apache.org/jira/browse/GEODE-8656?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225452#comment-17225452 ] ASF GitHub Bot commented on GEODE-8656: --- albertogpz commented on pull request #5670: URL: https://github.com/apache/geode/pull/5670#issuecomment-721133690 > > @albertogpz if you want to use Docker in your tests, yeah, the easiest way to do that right now is to make your test an "acceptanceTest" which means putting it in an `/geode-assembly/src/acceptanceTest` hierarchy. > > Thanks, @Bill . How hard would it be to use docker-compose in a distributedTest? I am saying it because I used in my test the org.apache.geode.test.dunit.VM class. If I move it to be an acceptanceTest I would have to implement it in a different way. It looks to me that in acceptanceTest, Geode processes are started with gfsh. Any suggestion? I finally created the test as acceptanceTest. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Ping not sent to the right gateway receiver endpoint when several receivers > have the same hostname-for-senders value > > > Key: GEODE-8656 > URL: https://issues.apache.org/jira/browse/GEODE-8656 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: Alberto Gomez >Assignee: Alberto Gomez >Priority: Major > Labels: pull-request-available > > When several gateway receivers have the same value for hostname-for-senders > (for example when running Geode under kubernetes and a load balancer balances > the load among the remote servers), the ping messages sent from the gateway > sender client are only sent to the receiver (endpoint) to which the sender > connected first. > The other receivers will not get the ping message which will imply that the > connections towards them will be closed after the configured timeout expires. > This ticket is a continuation of the work done ticket GEODE-7565. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8682) update jetty to recommended version
[ https://issues.apache.org/jira/browse/GEODE-8682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225511#comment-17225511 ] ASF GitHub Bot commented on GEODE-8682: --- onichols-pivotal merged pull request #5700: URL: https://github.com/apache/geode/pull/5700 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > update jetty to recommended version > --- > > Key: GEODE-8682 > URL: https://issues.apache.org/jira/browse/GEODE-8682 > Project: Geode > Issue Type: Bug > Components: management >Reporter: Owen Nichols >Priority: Major > Labels: pull-request-available > Fix For: 1.12.1, 1.14.0, 1.13.1 > > > update jetty to > [9.4.33.v20201020|https://mvnrepository.com/artifact/org.eclipse.jetty/jetty-server/9.4.33.v20201020] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8682) update jetty to recommended version
[ https://issues.apache.org/jira/browse/GEODE-8682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225512#comment-17225512 ] ASF subversion and git services commented on GEODE-8682: Commit 39db7929cff991c8c07763a4a9b8391a1045a234 in geode's branch refs/heads/develop from Owen Nichols [ https://gitbox.apache.org/repos/asf?p=geode.git;h=39db792 ] GEODE-8682: Bump jetty from 9.4.32.v20200930 to 9.4.33.v20201020 (#5700) > update jetty to recommended version > --- > > Key: GEODE-8682 > URL: https://issues.apache.org/jira/browse/GEODE-8682 > Project: Geode > Issue Type: Bug > Components: management >Reporter: Owen Nichols >Priority: Major > Labels: pull-request-available > Fix For: 1.12.1, 1.14.0, 1.13.1 > > > update jetty to > [9.4.33.v20201020|https://mvnrepository.com/artifact/org.eclipse.jetty/jetty-server/9.4.33.v20201020] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8682) update jetty to recommended version
[ https://issues.apache.org/jira/browse/GEODE-8682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225514#comment-17225514 ] ASF subversion and git services commented on GEODE-8682: Commit 39db7929cff991c8c07763a4a9b8391a1045a234 in geode's branch refs/heads/develop from Owen Nichols [ https://gitbox.apache.org/repos/asf?p=geode.git;h=39db792 ] GEODE-8682: Bump jetty from 9.4.32.v20200930 to 9.4.33.v20201020 (#5700) > update jetty to recommended version > --- > > Key: GEODE-8682 > URL: https://issues.apache.org/jira/browse/GEODE-8682 > Project: Geode > Issue Type: Bug > Components: management >Reporter: Owen Nichols >Priority: Major > Labels: pull-request-available > Fix For: 1.12.1, 1.14.0, 1.13.1 > > > update jetty to > [9.4.33.v20201020|https://mvnrepository.com/artifact/org.eclipse.jetty/jetty-server/9.4.33.v20201020] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8496) bump dependencies for 1.14
[ https://issues.apache.org/jira/browse/GEODE-8496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225539#comment-17225539 ] ASF subversion and git services commented on GEODE-8496: Commit fdaa2be509d0a86de63f576f35b300d8f2aa6817 in geode's branch refs/heads/support/1.13 from Jinmei Liao [ https://gitbox.apache.org/repos/asf?p=geode.git;h=fdaa2be ] GEODE-8496: fix rest management test after dependency bump (#5547) (cherry picked from commit c49389e99ca801d70f2f2c46a98c960ebad9b872) > bump dependencies for 1.14 > -- > > Key: GEODE-8496 > URL: https://issues.apache.org/jira/browse/GEODE-8496 > Project: Geode > Issue Type: Improvement > Components: build >Reporter: Owen Nichols >Priority: Major > Labels: pull-request-available > Fix For: 1.14.0 > > > now is a good time in the lull between 1.13 and 1.14 to roll 3rd party > libraries to latest versions wherever possible. Doing this proactively helps > us stay ahead of CVEs and keep up with bugfixes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8496) bump dependencies for 1.14
[ https://issues.apache.org/jira/browse/GEODE-8496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225541#comment-17225541 ] ASF subversion and git services commented on GEODE-8496: Commit 43f489004ab05632d0c1a1bea86b2a19799e27fc in geode's branch refs/heads/support/1.12 from Jinmei Liao [ https://gitbox.apache.org/repos/asf?p=geode.git;h=43f4890 ] GEODE-8496: fix rest management test after dependency bump (#5547) (cherry picked from commit c49389e99ca801d70f2f2c46a98c960ebad9b872) (cherry picked from commit fdaa2be509d0a86de63f576f35b300d8f2aa6817) > bump dependencies for 1.14 > -- > > Key: GEODE-8496 > URL: https://issues.apache.org/jira/browse/GEODE-8496 > Project: Geode > Issue Type: Improvement > Components: build >Reporter: Owen Nichols >Priority: Major > Labels: pull-request-available > Fix For: 1.14.0 > > > now is a good time in the lull between 1.13 and 1.14 to roll 3rd party > libraries to latest versions wherever possible. Doing this proactively helps > us stay ahead of CVEs and keep up with bugfixes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8496) bump dependencies for 1.14
[ https://issues.apache.org/jira/browse/GEODE-8496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225553#comment-17225553 ] ASF subversion and git services commented on GEODE-8496: Commit 9b6ec9e6adbf55a07f62cb1fd89ca2e0e54a2d49 in geode's branch refs/heads/support/1.13 from Owen Nichols [ https://gitbox.apache.org/repos/asf?p=geode.git;h=9b6ec9e ] GEODE-8496: fix rest management test after dependency bump (#5547) > bump dependencies for 1.14 > -- > > Key: GEODE-8496 > URL: https://issues.apache.org/jira/browse/GEODE-8496 > Project: Geode > Issue Type: Improvement > Components: build >Reporter: Owen Nichols >Priority: Major > Labels: pull-request-available > Fix For: 1.14.0 > > > now is a good time in the lull between 1.13 and 1.14 to roll 3rd party > libraries to latest versions wherever possible. Doing this proactively helps > us stay ahead of CVEs and keep up with bugfixes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7679) Partitioned Region clear is successful while region is being altered
[ https://issues.apache.org/jira/browse/GEODE-7679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225580#comment-17225580 ] ASF GitHub Bot commented on GEODE-7679: --- jchen21 merged pull request #5516: URL: https://github.com/apache/geode/pull/5516 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Partitioned Region clear is successful while region is being altered > > > Key: GEODE-7679 > URL: https://issues.apache.org/jira/browse/GEODE-7679 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Jianxia Chen >Priority: Major > Labels: GeodeCommons, pull-request-available > > Clear operations are successful and while alter region commands are being > executed. > Acceptance : > * DUnit tests validating the above behavior. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7679) Partitioned Region clear is successful while region is being altered
[ https://issues.apache.org/jira/browse/GEODE-7679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225583#comment-17225583 ] ASF subversion and git services commented on GEODE-7679: Commit 1d0d1de0d26853ca771be4da65f02244037ad6a3 in geode's branch refs/heads/feature/GEODE-7665 from Jianxia Chen [ https://gitbox.apache.org/repos/asf?p=geode.git;h=1d0d1de ] GEODE-7679 Partitioned Region clear is successful while region is being altered (#5516) > Partitioned Region clear is successful while region is being altered > > > Key: GEODE-7679 > URL: https://issues.apache.org/jira/browse/GEODE-7679 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Jianxia Chen >Priority: Major > Labels: GeodeCommons, pull-request-available > > Clear operations are successful and while alter region commands are being > executed. > Acceptance : > * DUnit tests validating the above behavior. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7679) Partitioned Region clear is successful while region is being altered
[ https://issues.apache.org/jira/browse/GEODE-7679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225586#comment-17225586 ] ASF subversion and git services commented on GEODE-7679: Commit 1d0d1de0d26853ca771be4da65f02244037ad6a3 in geode's branch refs/heads/feature/GEODE-7665 from Jianxia Chen [ https://gitbox.apache.org/repos/asf?p=geode.git;h=1d0d1de ] GEODE-7679 Partitioned Region clear is successful while region is being altered (#5516) > Partitioned Region clear is successful while region is being altered > > > Key: GEODE-7679 > URL: https://issues.apache.org/jira/browse/GEODE-7679 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Jianxia Chen >Priority: Major > Labels: GeodeCommons, pull-request-available > > Clear operations are successful and while alter region commands are being > executed. > Acceptance : > * DUnit tests validating the above behavior. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8683) maximum-time-between-pings parameter in GatewayReceiver creation does not have any effect
[ https://issues.apache.org/jira/browse/GEODE-8683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alberto Gomez updated GEODE-8683: - Description: The maximum-time-between-pings parameter than can be set at gateway sender creation has no effect, i.e. the value used as maximum time between pings for gateway sender connections to the gateway receiver is either the default value (6) or the one set on the server where the receiver is running. The reason is that the ClientHealthMonitor is a server-side singleton that monitors the health of all clients. The value set for this parameter in the ClientHealthMonitor is first set when the server is started and the Acceptor is created. was: The maximum-time-between-pings parameter than can be set at gateway sender creation has no effect, i.e. the value used as maximum time between pings for gateway sender connections to the gateway sender is either the default value (6) or the one set on the server where the receiver is running. The reason is that the ClientHealthMonitor is a server-side singleton that monitors the health of all clients. The value set for this parameter in the ClientHealthMonitor is first set when the server is started and the Acceptor is created. > maximum-time-between-pings parameter in GatewayReceiver creation does not > have any effect > - > > Key: GEODE-8683 > URL: https://issues.apache.org/jira/browse/GEODE-8683 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: Alberto Gomez >Assignee: Alberto Gomez >Priority: Major > > The maximum-time-between-pings parameter than can be set at gateway sender > creation has no effect, i.e. the value used as maximum time between pings for > gateway sender connections to the gateway receiver is either the default > value (6) or the one set on the server where the receiver is running. > The reason is that the ClientHealthMonitor is a server-side singleton that > monitors the health of all clients. The value set for this parameter in the > ClientHealthMonitor is first set when the server is started and the Acceptor > is created. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8683) maximum-time-between-pings parameter in GatewayReceiver creation does not have any effect
[ https://issues.apache.org/jira/browse/GEODE-8683?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Alberto Gomez updated GEODE-8683: - Description: The maximum-time-between-pings parameter than can be set at gateway sender creation has no effect, i.e. the value used as maximum time between pings for gateway sender connections to the gateway receiver is either the default value (6) or the one set on the server where the receiver is running. The reason is that the ClientHealthMonitor is a server-side singleton that monitors the health of all clients. The value set for this parameter in the ClientHealthMonitor is first set when the server is started and the first Acceptor is created. was: The maximum-time-between-pings parameter than can be set at gateway sender creation has no effect, i.e. the value used as maximum time between pings for gateway sender connections to the gateway receiver is either the default value (6) or the one set on the server where the receiver is running. The reason is that the ClientHealthMonitor is a server-side singleton that monitors the health of all clients. The value set for this parameter in the ClientHealthMonitor is first set when the server is started and the Acceptor is created. > maximum-time-between-pings parameter in GatewayReceiver creation does not > have any effect > - > > Key: GEODE-8683 > URL: https://issues.apache.org/jira/browse/GEODE-8683 > Project: Geode > Issue Type: Bug > Components: wan >Reporter: Alberto Gomez >Assignee: Alberto Gomez >Priority: Major > > The maximum-time-between-pings parameter than can be set at gateway sender > creation has no effect, i.e. the value used as maximum time between pings for > gateway sender connections to the gateway receiver is either the default > value (6) or the one set on the server where the receiver is running. > The reason is that the ClientHealthMonitor is a server-side singleton that > monitors the health of all clients. The value set for this parameter in the > ClientHealthMonitor is first set when the server is started and the first > Acceptor is created. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7679) Partitioned Region clear is successful while region is being altered
[ https://issues.apache.org/jira/browse/GEODE-7679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225591#comment-17225591 ] ASF subversion and git services commented on GEODE-7679: Commit 1d0d1de0d26853ca771be4da65f02244037ad6a3 in geode's branch refs/heads/feature/GEODE-7665 from Jianxia Chen [ https://gitbox.apache.org/repos/asf?p=geode.git;h=1d0d1de ] GEODE-7679 Partitioned Region clear is successful while region is being altered (#5516) > Partitioned Region clear is successful while region is being altered > > > Key: GEODE-7679 > URL: https://issues.apache.org/jira/browse/GEODE-7679 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Jianxia Chen >Priority: Major > Labels: GeodeCommons, pull-request-available > > Clear operations are successful and while alter region commands are being > executed. > Acceptance : > * DUnit tests validating the above behavior. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7679) Partitioned Region clear is successful while region is being altered
[ https://issues.apache.org/jira/browse/GEODE-7679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225595#comment-17225595 ] ASF subversion and git services commented on GEODE-7679: Commit 1d0d1de0d26853ca771be4da65f02244037ad6a3 in geode's branch refs/heads/feature/GEODE-7665 from Jianxia Chen [ https://gitbox.apache.org/repos/asf?p=geode.git;h=1d0d1de ] GEODE-7679 Partitioned Region clear is successful while region is being altered (#5516) > Partitioned Region clear is successful while region is being altered > > > Key: GEODE-7679 > URL: https://issues.apache.org/jira/browse/GEODE-7679 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Jianxia Chen >Priority: Major > Labels: GeodeCommons, pull-request-available > > Clear operations are successful and while alter region commands are being > executed. > Acceptance : > * DUnit tests validating the above behavior. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7679) Partitioned Region clear is successful while region is being altered
[ https://issues.apache.org/jira/browse/GEODE-7679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225599#comment-17225599 ] ASF subversion and git services commented on GEODE-7679: Commit 1d0d1de0d26853ca771be4da65f02244037ad6a3 in geode's branch refs/heads/feature/GEODE-7665 from Jianxia Chen [ https://gitbox.apache.org/repos/asf?p=geode.git;h=1d0d1de ] GEODE-7679 Partitioned Region clear is successful while region is being altered (#5516) > Partitioned Region clear is successful while region is being altered > > > Key: GEODE-7679 > URL: https://issues.apache.org/jira/browse/GEODE-7679 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Jianxia Chen >Priority: Major > Labels: GeodeCommons, pull-request-available > > Clear operations are successful and while alter region commands are being > executed. > Acceptance : > * DUnit tests validating the above behavior. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-8650) Support using multiple DistributedReference Rules in one test
[ https://issues.apache.org/jira/browse/GEODE-8650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund resolved GEODE-8650. -- Fix Version/s: 1.14.0 Resolution: Fixed > Support using multiple DistributedReference Rules in one test > - > > Key: GEODE-8650 > URL: https://issues.apache.org/jira/browse/GEODE-8650 > Project: Geode > Issue Type: Wish > Components: tests >Reporter: Kirk Lund >Assignee: Kirk Lund >Priority: Major > Labels: pull-request-available > Fix For: 1.14.0 > > > Support using multiple DistributedReference Rules in one test. Right now the > Rule only supports having one instance in a test. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (GEODE-8684) Setting a session's maxInactiveInterval does not work when the commit valve is disabled
Jens Deppe created GEODE-8684:
-
Summary: Setting a session's maxInactiveInterval does not work
when the commit valve is disabled
Key: GEODE-8684
URL: https://issues.apache.org/jira/browse/GEODE-8684
Project: Geode
Issue Type: Bug
Components: http session
Affects Versions: 1.14.0
Reporter: Jens Deppe
I was using the {{CommandServlet}}, in an external test, and noticed that when
the commit valve is disabled, attempting to set the session's
maxInactiveInterval does not cause the session's maxInactiveInterval to be
changed and it remains at the default.
My setup consisted of 2 Geode servers and a single Tomcat instance (9.0.39). I
was checking the sessions with the following gfsh query:
{code:java}
query --query="select e.key,e.value.maxInactiveInterval from
/gemfire_modules_sessions.entries as e
{code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (GEODE-7679) Partitioned Region clear is successful while region is being altered
[ https://issues.apache.org/jira/browse/GEODE-7679?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jianxia Chen resolved GEODE-7679. - Resolution: Fixed > Partitioned Region clear is successful while region is being altered > > > Key: GEODE-7679 > URL: https://issues.apache.org/jira/browse/GEODE-7679 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Jianxia Chen >Priority: Major > Labels: GeodeCommons, pull-request-available > > Clear operations are successful and while alter region commands are being > executed. > Acceptance : > * DUnit tests validating the above behavior. > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8684) Setting a session's maxInactiveInterval does not work when the commit valve is disabled
[
https://issues.apache.org/jira/browse/GEODE-8684?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jens Deppe updated GEODE-8684:
--
Description:
I was using the {{CommandServlet}}, in an external test, and noticed that when
the commit valve is disabled, attempting to set the session's
maxInactiveInterval does not cause the session's maxInactiveInterval to be
changed and it remains at the default.
My setup consisted of 2 Geode servers and a single Tomcat instance (9.0.39). I
was checking the sessions with the following gfsh query:
{code:java}
query --query="select e.key,e.value.maxInactiveInterval from
/gemfire_modules_sessions.entries as e
{code}
My {{context.xml}} includes the following:
{code:xml}
{code}
was:
I was using the {{CommandServlet}}, in an external test, and noticed that when
the commit valve is disabled, attempting to set the session's
maxInactiveInterval does not cause the session's maxInactiveInterval to be
changed and it remains at the default.
My setup consisted of 2 Geode servers and a single Tomcat instance (9.0.39). I
was checking the sessions with the following gfsh query:
{code:java}
query --query="select e.key,e.value.maxInactiveInterval from
/gemfire_modules_sessions.entries as e
{code}
> Setting a session's maxInactiveInterval does not work when the commit valve
> is disabled
> ---
>
> Key: GEODE-8684
> URL: https://issues.apache.org/jira/browse/GEODE-8684
> Project: Geode
> Issue Type: Bug
> Components: http session
>Affects Versions: 1.14.0
>Reporter: Jens Deppe
>Priority: Major
>
> I was using the {{CommandServlet}}, in an external test, and noticed that
> when the commit valve is disabled, attempting to set the session's
> maxInactiveInterval does not cause the session's maxInactiveInterval to be
> changed and it remains at the default.
> My setup consisted of 2 Geode servers and a single Tomcat instance (9.0.39).
> I was checking the sessions with the following gfsh query:
> {code:java}
> query --query="select e.key,e.value.maxInactiveInterval from
> /gemfire_modules_sessions.entries as e
> {code}
> My {{context.xml}} includes the following:
> {code:xml}
>className="org.apache.geode.modules.session.catalina.Tomcat8DeltaSessionManager"
> enableLocalCache="false"
> enableCommitValve="false"
> regionAttributesId="PARTITION_REDUNDANT"
> />
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8466) Create a ClassLoaderService to abstract away dealing with the default ClassLoader directly
[ https://issues.apache.org/jira/browse/GEODE-8466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225642#comment-17225642 ] ASF GitHub Bot commented on GEODE-8466: --- lgtm-com[bot] commented on pull request #5658: URL: https://github.com/apache/geode/pull/5658#issuecomment-721343753 This pull request **introduces 3 alerts** and **fixes 1** when merging 30ece9bc340c2893797887fe6421c0c28ed654b6 into 39db7929cff991c8c07763a4a9b8391a1045a234 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-e584682641fe7c6af9f2b617ea5b2fc22b3308b2) **new alerts:** * 2 for Potential input resource leak * 1 for Use of a broken or risky cryptographic algorithm **fixed alerts:** * 1 for Use of a broken or risky cryptographic algorithm This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Create a ClassLoaderService to abstract away dealing with the default > ClassLoader directly > -- > > Key: GEODE-8466 > URL: https://issues.apache.org/jira/browse/GEODE-8466 > Project: Geode > Issue Type: New Feature > Components: core >Reporter: Udo Kohlmeyer >Assignee: Udo Kohlmeyer >Priority: Major > Labels: pull-request-available > > With the addition of ClassLoader isolation using JBoss Modules GEODE-8067, > the manner in which we interact with the ClassLoader needs to change. > An abstraction is required around the default functions like > `findResourceAsStream`, `loadClass` and `loadService`. > As these features will behave differently between different ClassLoader > implementations, it is best to have a single service that will expose that > functionality in a transparent manner. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8546) Colocated regions missing some buckets after restart
[ https://issues.apache.org/jira/browse/GEODE-8546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225681#comment-17225681 ] ASF GitHub Bot commented on GEODE-8546: --- kohlmu-pivotal commented on pull request #5590: URL: https://github.com/apache/geode/pull/5590#issuecomment-721376888 @DonalEvans Do you have any capacity to assist with this? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Colocated regions missing some buckets after restart > > > Key: GEODE-8546 > URL: https://issues.apache.org/jira/browse/GEODE-8546 > Project: Geode > Issue Type: Bug > Components: regions >Affects Versions: 1.11.0, 1.12.0, 1.13.0 >Reporter: Mario Kevo >Assignee: Mario Kevo >Priority: Major > Labels: pull-request-available > > After restart all servers at the same time, some colocation regions missing > some buckets. > This issue exist for a long time and become visible from 1.11.0 by > introducing this changes GEODE-7042 . > How to reproduce the issue: > # Start two locators and two servers > # Create PARTITION_REDUNDANT_PERSISTENT region with redundant-copies=1 > # Create few PARTITION_REDUNDANT regions(I used six regions) colocated with > persistent region and redundant-copies=1 > # Put some entries. > # Restart servers(you can simply run "kill -15 " and then from > two terminals start both of them at the same time) > # It will take a time to get server startup finished and for the latest > region bucketCount will be lower than expected on one member -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8547) Command "show missing-disk-stores" not working, when all servers are down
[ https://issues.apache.org/jira/browse/GEODE-8547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225683#comment-17225683 ] ASF GitHub Bot commented on GEODE-8547: --- jinmeiliao commented on pull request #5567: URL: https://github.com/apache/geode/pull/5567#issuecomment-721378276 I believe it's as designed that if no members are up and running, then `show missing disk-store` will not work. I don't quite understand what's the problem you are trying to solve by this fix? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Command "show missing-disk-stores" not working, when all servers are down > - > > Key: GEODE-8547 > URL: https://issues.apache.org/jira/browse/GEODE-8547 > Project: Geode > Issue Type: Bug > Components: gfsh >Reporter: Mario Ivanac >Assignee: Mario Ivanac >Priority: Major > Labels: needs-review, pull-request-available > > If cluster with 2 locators and 2 servers was ungracefully shutdown it can > happen that locators that are able to start up are not having most recent > data to bring up Cluster Configuration Service. > If we excute command "show missing-disk-stores" it will not work, since all > servers are down, > so we are stuck in this situation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8547) Command "show missing-disk-stores" not working, when all servers are down
[ https://issues.apache.org/jira/browse/GEODE-8547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225685#comment-17225685 ] Jinmei Liao commented on GEODE-8547: when all servers are down, "show missing-diskstore` is not supposed to work. I don't quite get how this would improve this situation: "If cluster with 2 locators and 2 servers was ungracefully shutdown it can happen that locators that are able to start up are not having most recent data to bring up Cluster Configuration Service. " > Command "show missing-disk-stores" not working, when all servers are down > - > > Key: GEODE-8547 > URL: https://issues.apache.org/jira/browse/GEODE-8547 > Project: Geode > Issue Type: Bug > Components: gfsh >Reporter: Mario Ivanac >Assignee: Mario Ivanac >Priority: Major > Labels: needs-review, pull-request-available > > If cluster with 2 locators and 2 servers was ungracefully shutdown it can > happen that locators that are able to start up are not having most recent > data to bring up Cluster Configuration Service. > If we excute command "show missing-disk-stores" it will not work, since all > servers are down, > so we are stuck in this situation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8547) Command "show missing-disk-stores" not working, when all servers are down
[ https://issues.apache.org/jira/browse/GEODE-8547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225698#comment-17225698 ] ASF GitHub Bot commented on GEODE-8547: --- mivanac commented on pull request #5567: URL: https://github.com/apache/geode/pull/5567#issuecomment-721383598 We are solving a problem when all members are shutdown, and after some time we are trying to startup. Let say, that due to some problems locator with latest info, cannot start. In this case, remaining locator will not start, so we need to use command revoke missing-disk-store, which needs input from command show missing disk-store. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Command "show missing-disk-stores" not working, when all servers are down > - > > Key: GEODE-8547 > URL: https://issues.apache.org/jira/browse/GEODE-8547 > Project: Geode > Issue Type: Bug > Components: gfsh >Reporter: Mario Ivanac >Assignee: Mario Ivanac >Priority: Major > Labels: needs-review, pull-request-available > > If cluster with 2 locators and 2 servers was ungracefully shutdown it can > happen that locators that are able to start up are not having most recent > data to bring up Cluster Configuration Service. > If we excute command "show missing-disk-stores" it will not work, since all > servers are down, > so we are stuck in this situation. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8547) Command "show missing-disk-stores" not working, when all servers are down
[
https://issues.apache.org/jira/browse/GEODE-8547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225711#comment-17225711
]
Jinmei Liao commented on GEODE-8547:
since when we tried to start a locator with out-of-date disk-store first, we
got the following message:
{quote}
Use the gfsh show missing-disk-stores command to see all disk stores that are
being waited on by other members.
{quote}
I would be a good idea for the "show missing-disk-stores" command to list out
the missing disk store even when no servers are availble.
> Command "show missing-disk-stores" not working, when all servers are down
> -
>
> Key: GEODE-8547
> URL: https://issues.apache.org/jira/browse/GEODE-8547
> Project: Geode
> Issue Type: Bug
> Components: gfsh
>Reporter: Mario Ivanac
>Assignee: Mario Ivanac
>Priority: Major
> Labels: needs-review, pull-request-available
>
> If cluster with 2 locators and 2 servers was ungracefully shutdown it can
> happen that locators that are able to start up are not having most recent
> data to bring up Cluster Configuration Service.
> If we excute command "show missing-disk-stores" it will not work, since all
> servers are down,
> so we are stuck in this situation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Comment Edited] (GEODE-8547) Command "show missing-disk-stores" not working, when all servers are down
[
https://issues.apache.org/jira/browse/GEODE-8547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225711#comment-17225711
]
Jinmei Liao edited comment on GEODE-8547 at 11/3/20, 10:07 PM:
---
since when we tried to start a locator with out-of-date disk-store first, we
got the following message:
{quote}
Use the gfsh show missing-disk-stores command to see all disk stores that are
being waited on by other members.
{quote}
It would be a good idea for the "show missing-disk-stores" command to list out
the missing disk store even when no servers are availble.
was (Author: jinmeiliao):
since when we tried to start a locator with out-of-date disk-store first, we
got the following message:
{quote}
Use the gfsh show missing-disk-stores command to see all disk stores that are
being waited on by other members.
{quote}
I would be a good idea for the "show missing-disk-stores" command to list out
the missing disk store even when no servers are availble.
> Command "show missing-disk-stores" not working, when all servers are down
> -
>
> Key: GEODE-8547
> URL: https://issues.apache.org/jira/browse/GEODE-8547
> Project: Geode
> Issue Type: Bug
> Components: gfsh
>Reporter: Mario Ivanac
>Assignee: Mario Ivanac
>Priority: Major
> Labels: needs-review, pull-request-available
>
> If cluster with 2 locators and 2 servers was ungracefully shutdown it can
> happen that locators that are able to start up are not having most recent
> data to bring up Cluster Configuration Service.
> If we excute command "show missing-disk-stores" it will not work, since all
> servers are down,
> so we are stuck in this situation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8553) Reduce ThinClientLocatorHelper lock time
[ https://issues.apache.org/jira/browse/GEODE-8553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225715#comment-17225715 ] ASF GitHub Bot commented on GEODE-8553: --- gaussianrecurrence commented on pull request #660: URL: https://github.com/apache/geode-native/pull/660#issuecomment-721399787 Ok @pdxcodemonkey and @pivotal-jbarrett I think I came up with an integration test for this change. It works as follows: * Set 5s connect-timeout. * Deploy 1 locator. * Add 1 non-existent locator to the pool. * Send 64 concurrent requests to get the server list. * By probability if there are no interlocks ~50%+-E% of the requests should have completed in a brief period of time. * Note that E% is the error allowance percentage, which is set to 10%. * Therefore a 10 seconds timeout is set in order to reach the request completed treshold. * Test passes if the number of completed requests before the timeout was greater or equal to the thresholds, otherwise it fails. It does not cover everything, but I'd would appreciate your feedback in order to see If I am in the right direction. Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Reduce ThinClientLocatorHelper lock time > > > Key: GEODE-8553 > URL: https://issues.apache.org/jira/browse/GEODE-8553 > Project: Geode > Issue Type: Improvement > Components: native client >Affects Versions: 1.12.0, 1.13.0 >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: pull-request-available > > During my troublshootings, I've seen that locking m_locatorLock for the whole > scope of the class function members might cause some inter-locks. > Problem here and in many other places of the NC is that networking operations > are performed while a mutex is locked. Therefore if *thread A* takes longer > than expected in performing its network operation, it might block another one > which does not requires any resource of the first *thread A*. Hence, the > inter-lock. > This improvement is the first one of a series regarding to lock scope > reduction when it comes with code regarding networking in NC. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8547) Command "show missing-disk-stores" not working, when all servers are down
[
https://issues.apache.org/jira/browse/GEODE-8547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225718#comment-17225718
]
ASF GitHub Bot commented on GEODE-8547:
---
jinmeiliao commented on a change in pull request #5567:
URL: https://github.com/apache/geode/pull/5567#discussion_r516987265
##
File path:
geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/ShowMissingDiskStoreCommand.java
##
@@ -53,16 +53,19 @@ public ResultModel showMissingDiskStore() {
Set dataMembers =
DiskStoreCommandsUtils.getNormalMembers((InternalCache) getCache());
-if (dataMembers.isEmpty()) {
- return
ResultModel.createInfo(CliStrings.NO_CACHING_MEMBERS_FOUND_MESSAGE);
+List missingRegions = null;
+boolean cacheMemberExist = false;
+
+if (!dataMembers.isEmpty()) {
+ cacheMemberExist = true;
Review comment:
I believe you don't need this boolean. If no servers, `missingRegions`
will be null, otherwise, it's empty or has data
##
File path:
geode-gfsh/src/distributedTest/java/org/apache/geode/management/internal/cli/commands/ShowMissingDiskStoreCommandDUnitTest.java
##
@@ -156,6 +160,71 @@ public void
stoppingAndRestartingMemberDoesNotResultInMissingDiskStore() {
assertThat(missingDiskStoreIds).isNull();
}
+
+ @Test
+ public void stopAllMembersAndStart2ndLocator() throws Exception {
+
IgnoredException.addIgnoredException(DistributedSystemDisconnectedException.class);
+
+MemberVM locator1 = lsRule.startLocatorVM(1, locator.getPort());
+
+MemberVM server1 = lsRule.startServerVM(2, locator.getPort(),
locator1.getPort());
+@SuppressWarnings("unused")
Review comment:
instead of suppress the warning, just don't assign it to a variable
##
File path:
geode-gfsh/src/distributedTest/java/org/apache/geode/management/internal/cli/commands/ShowMissingDiskStoreCommandDUnitTest.java
##
@@ -156,6 +160,71 @@ public void
stoppingAndRestartingMemberDoesNotResultInMissingDiskStore() {
assertThat(missingDiskStoreIds).isNull();
}
+
+ @Test
+ public void stopAllMembersAndStart2ndLocator() throws Exception {
+
IgnoredException.addIgnoredException(DistributedSystemDisconnectedException.class);
+
+MemberVM locator1 = lsRule.startLocatorVM(1, locator.getPort());
+
+MemberVM server1 = lsRule.startServerVM(2, locator.getPort(),
locator1.getPort());
+@SuppressWarnings("unused")
+MemberVM server2 = lsRule.startServerVM(3, locator.getPort(),
locator1.getPort());
+
+final String testRegionName = "regionA";
+CommandStringBuilder csb;
+csb = new CommandStringBuilder(CliStrings.CREATE_DISK_STORE)
+.addOption(CliStrings.CREATE_DISK_STORE__NAME, "diskStore")
+.addOption(CliStrings.CREATE_DISK_STORE__DIRECTORY_AND_SIZE,
"diskStoreDir");
+
gfshConnector.executeAndAssertThat(csb.getCommandString()).statusIsSuccess();
+
+CommandStringBuilder createRegion = new
CommandStringBuilder(CliStrings.CREATE_REGION)
+.addOption(CliStrings.CREATE_REGION__REGION, testRegionName)
+.addOption(CliStrings.CREATE_REGION__DISKSTORE, "diskStore")
+.addOption(CliStrings.CREATE_REGION__REGIONSHORTCUT,
+RegionShortcut.PARTITION_REDUNDANT_PERSISTENT.toString());
+await().untilAsserted(() ->
gfshConnector.executeAndAssertThat(createRegion.getCommandString())
+.statusIsSuccess());
+
+
+lsRule.stop(1, false);
+
+// Add data to the region
+addData(server1, testRegionName);
Review comment:
you also don't need to add data and do rebalance
##
File path:
geode-gfsh/src/main/java/org/apache/geode/management/internal/cli/commands/ShowMissingDiskStoreCommand.java
##
@@ -113,7 +116,9 @@ private ResultModel toMissingDiskStoresTabularResult(
}
TabularResultModel missingRegionsSection =
result.addTable(MISSING_COLOCATED_REGIONS_SECTION);
-if (hasMissingColocatedRegions) {
+if (!cacheMemberExist) {
Review comment:
here you can do something like:
```
if (missingColocatedRegions == null) {
// set the header as "no caching members"
}
else if (missingColocatedRegions.isEmpty()) {
}
else{
}
##
File path:
geode-gfsh/src/distributedTest/java/org/apache/geode/management/internal/cli/commands/ShowMissingDiskStoreCommandDUnitTest.java
##
@@ -156,6 +160,71 @@ public void
stoppingAndRestartingMemberDoesNotResultInMissingDiskStore() {
assertThat(missingDiskStoreIds).isNull();
}
+
+ @Test
+ public void stopAllMembersAndStart2ndLocator() throws Exception {
+
IgnoredException.addIgnoredException(DistributedSystemDisconnectedException.class);
+
+MemberVM locator1 = lsRule.startLocatorVM(1, locator.getPort());
+
+MemberVM server1 = lsRule.startServerVM(2, locator.getPort(),
locator1.getPort());
+@Suppres
[jira] [Commented] (GEODE-8547) Command "show missing-disk-stores" not working, when all servers are down
[
https://issues.apache.org/jira/browse/GEODE-8547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225719#comment-17225719
]
ASF GitHub Bot commented on GEODE-8547:
---
jinmeiliao commented on a change in pull request #5567:
URL: https://github.com/apache/geode/pull/5567#discussion_r516989089
##
File path:
geode-gfsh/src/distributedTest/java/org/apache/geode/management/internal/cli/commands/ShowMissingDiskStoreCommandDUnitTest.java
##
@@ -156,6 +160,71 @@ public void
stoppingAndRestartingMemberDoesNotResultInMissingDiskStore() {
assertThat(missingDiskStoreIds).isNull();
}
+
+ @Test
+ public void stopAllMembersAndStart2ndLocator() throws Exception {
+
IgnoredException.addIgnoredException(DistributedSystemDisconnectedException.class);
+
+MemberVM locator1 = lsRule.startLocatorVM(1, locator.getPort());
+
+MemberVM server1 = lsRule.startServerVM(2, locator.getPort(),
locator1.getPort());
+@SuppressWarnings("unused")
+MemberVM server2 = lsRule.startServerVM(3, locator.getPort(),
locator1.getPort());
+
+final String testRegionName = "regionA";
+CommandStringBuilder csb;
+csb = new CommandStringBuilder(CliStrings.CREATE_DISK_STORE)
+.addOption(CliStrings.CREATE_DISK_STORE__NAME, "diskStore")
+.addOption(CliStrings.CREATE_DISK_STORE__DIRECTORY_AND_SIZE,
"diskStoreDir");
+
gfshConnector.executeAndAssertThat(csb.getCommandString()).statusIsSuccess();
+
+CommandStringBuilder createRegion = new
CommandStringBuilder(CliStrings.CREATE_REGION)
+.addOption(CliStrings.CREATE_REGION__REGION, testRegionName)
+.addOption(CliStrings.CREATE_REGION__DISKSTORE, "diskStore")
+.addOption(CliStrings.CREATE_REGION__REGIONSHORTCUT,
+RegionShortcut.PARTITION_REDUNDANT_PERSISTENT.toString());
+await().untilAsserted(() ->
gfshConnector.executeAndAssertThat(createRegion.getCommandString())
+.statusIsSuccess());
+
+
+lsRule.stop(1, false);
+
+// Add data to the region
+addData(server1, testRegionName);
Review comment:
you also don't need to add data and do rebalance. Maybe add a comment in
your test making it clear that you are starting a stale locator first (locator
1 shutdown before locator0, and now you are starting locator 1 first), locator
1 won't start properly until a diskstore on locator 0 is revoked
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Command "show missing-disk-stores" not working, when all servers are down
> -
>
> Key: GEODE-8547
> URL: https://issues.apache.org/jira/browse/GEODE-8547
> Project: Geode
> Issue Type: Bug
> Components: gfsh
>Reporter: Mario Ivanac
>Assignee: Mario Ivanac
>Priority: Major
> Labels: needs-review, pull-request-available
>
> If cluster with 2 locators and 2 servers was ungracefully shutdown it can
> happen that locators that are able to start up are not having most recent
> data to bring up Cluster Configuration Service.
> If we excute command "show missing-disk-stores" it will not work, since all
> servers are down,
> so we are stuck in this situation.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8293) activeCQCount has negative value
[
https://issues.apache.org/jira/browse/GEODE-8293?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225728#comment-17225728
]
ASF GitHub Bot commented on GEODE-8293:
---
kohlmu-pivotal commented on a change in pull request #5620:
URL: https://github.com/apache/geode/pull/5620#discussion_r517013379
##
File path:
geode-cq/src/distributedTest/java/org/apache/geode/cache/query/cq/CQMetricsDUnitTest.java
##
@@ -0,0 +1,175 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express
+ * or implied. See the License for the specific language governing permissions
and limitations under
+ * the License.
+ */
+package org.apache.geode.cache.query.cq;
+
+import static org.apache.geode.test.awaitility.GeodeAwaitility.await;
+import static org.apache.geode.test.dunit.rules.ClusterStartupRule.getCache;
+import static org.assertj.core.api.Assertions.assertThat;
+
+import java.io.Serializable;
+import java.util.concurrent.TimeUnit;
+
+import org.junit.Before;
+import org.junit.Rule;
+import org.junit.Test;
+
+import org.apache.geode.cache.Cache;
+import org.apache.geode.cache.Region;
+import org.apache.geode.cache.client.ClientCache;
+import org.apache.geode.cache.client.ClientCacheFactory;
+import org.apache.geode.cache.client.ClientRegionShortcut;
+import org.apache.geode.cache.query.CqAttributes;
+import org.apache.geode.cache.query.CqAttributesFactory;
+import org.apache.geode.cache.query.CqEvent;
+import org.apache.geode.cache.query.CqListener;
+import org.apache.geode.cache.query.CqServiceStatistics;
+import org.apache.geode.cache.query.QueryService;
+import org.apache.geode.cache.query.data.Portfolio;
+import org.apache.geode.management.DistributedSystemMXBean;
+import org.apache.geode.management.ManagementService;
+import org.apache.geode.test.dunit.rules.ClusterStartupRule;
+import org.apache.geode.test.dunit.rules.MemberVM;
+import org.apache.geode.test.junit.rules.GfshCommandRule;
+
+public class CQMetricsDUnitTest {
+
+ private CqAttributes cqa;
+ private QueryService qs;
Review comment:
Please use longer variable names
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> activeCQCount has negative value
>
>
> Key: GEODE-8293
> URL: https://issues.apache.org/jira/browse/GEODE-8293
> Project: Geode
> Issue Type: Bug
> Components: statistics
>Reporter: Mario Kevo
>Assignee: Mario Kevo
>Priority: Major
> Labels: pull-request-available
>
> In case you have more than one server in the system and you close CQ there
> will be negative value of active cqs.
> The problem is when you started more than one server and execute cq on it. In
> that case we got incCqsActive on one server, but when it is closed we have
> decCqsActive on both servers.
> {code:java}
> gfsh>show metrics --categories=query
> Cluster-wide MetricsCategory | Metric | Value
> | | -
> query| activeCQCount| 1
> | queryRequestRate | 0.0
> {code}
> After cq is closed or stopped:
> {code:java}
> gfsh>show metrics --categories=query
> Cluster-wide Metrics
> Category | Metric | Value
> | | -
> query| activeCQCount| -1
> | queryRequestRate | 0.0
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8496) bump dependencies for 1.14
[ https://issues.apache.org/jira/browse/GEODE-8496?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225745#comment-17225745 ] ASF subversion and git services commented on GEODE-8496: Commit 6b8f5b03cc3c0927cd7eef23e5cc627a780f8a0c in geode's branch refs/heads/support/1.13 from Owen Nichols [ https://gitbox.apache.org/repos/asf?p=geode.git;h=6b8f5b0 ] Revert "GEODE-8496: Bump jetty from 9.4.21.v20190926 to 9.4.33.v20201020 (#5574)" This reverts commits: * 23d2dc7553cb30e600ba5792e87b0e26ce0eb028 * fdaa2be509d0a86de63f576f35b300d8f2aa6817 * 9b6ec9e6adbf55a07f62cb1fd89ca2e0e54a2d49 We should consider undoing this revert when the timing is better. > bump dependencies for 1.14 > -- > > Key: GEODE-8496 > URL: https://issues.apache.org/jira/browse/GEODE-8496 > Project: Geode > Issue Type: Improvement > Components: build >Reporter: Owen Nichols >Priority: Major > Labels: pull-request-available > Fix For: 1.14.0 > > > now is a good time in the lull between 1.13 and 1.14 to roll 3rd party > libraries to latest versions wherever possible. Doing this proactively helps > us stay ahead of CVEs and keep up with bugfixes. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8682) update jetty to recommended version
[ https://issues.apache.org/jira/browse/GEODE-8682?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225747#comment-17225747 ] ASF subversion and git services commented on GEODE-8682: Commit 4060542d8162ca466b27269f52dc7a312a2ed257 in geode's branch refs/heads/support/1.12 from Owen Nichols [ https://gitbox.apache.org/repos/asf?p=geode.git;h=4060542 ] Revert "GEODE-8682: Bump jetty from 9.4.21.v20190926 to 9.4.33.v20201020" This reverts commits: * 5f14c41422d42809f5cc96e782bdde60c87d68bd * 43f489004ab05632d0c1a1bea86b2a19799e27fc We should consider undoing this revert when the timing is better. > update jetty to recommended version > --- > > Key: GEODE-8682 > URL: https://issues.apache.org/jira/browse/GEODE-8682 > Project: Geode > Issue Type: Bug > Components: management >Reporter: Owen Nichols >Priority: Major > Labels: pull-request-available > Fix For: 1.12.1, 1.14.0, 1.13.1 > > > update jetty to > [9.4.33.v20201020|https://mvnrepository.com/artifact/org.eclipse.jetty/jetty-server/9.4.33.v20201020] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-7671) Partitioned Region clear operations can occur successfully during GII
[ https://issues.apache.org/jira/browse/GEODE-7671?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225762#comment-17225762 ] ASF GitHub Bot commented on GEODE-7671: --- kohlmu-pivotal commented on pull request #5512: URL: https://github.com/apache/geode/pull/5512#issuecomment-721458537 Moving this PR to a draft state... There seems to be too little movement on this PR to indicate that it is genuinely ready for review. @BenjaminPerryRoss, you can still request people to continue reviewing... but at this stage I don't feel this PR to be ready. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Partitioned Region clear operations can occur successfully during GII > -- > > Key: GEODE-7671 > URL: https://issues.apache.org/jira/browse/GEODE-7671 > Project: Geode > Issue Type: Sub-task > Components: regions >Reporter: Nabarun Nag >Assignee: Benjamin P Ross >Priority: Major > Labels: GeodeCommons, pull-request-available > > Clear operations are successful when the region is undergoing GII > Acceptance : > * Passing DUnit tests where clear operations are successful on partitioned > region when they are undergoing GII from another member > * Test coverage to when a member departs in this scenario > * Test coverage to when a member restarts in this scenario > * Unit tests with complete code coverage for the newly written code. > > analyze if these tests are needed for offheap? -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8682) update jetty to recommended version
[ https://issues.apache.org/jira/browse/GEODE-8682?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Owen Nichols updated GEODE-8682: Fix Version/s: (was: 1.13.1) (was: 1.12.1) > update jetty to recommended version > --- > > Key: GEODE-8682 > URL: https://issues.apache.org/jira/browse/GEODE-8682 > Project: Geode > Issue Type: Bug > Components: management >Reporter: Owen Nichols >Priority: Major > Labels: pull-request-available > Fix For: 1.14.0 > > > update jetty to > [9.4.33.v20201020|https://mvnrepository.com/artifact/org.eclipse.jetty/jetty-server/9.4.33.v20201020] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8466) Create a ClassLoaderService to abstract away dealing with the default ClassLoader directly
[ https://issues.apache.org/jira/browse/GEODE-8466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225770#comment-17225770 ] ASF GitHub Bot commented on GEODE-8466: --- lgtm-com[bot] commented on pull request #5658: URL: https://github.com/apache/geode/pull/5658#issuecomment-721466752 This pull request **introduces 3 alerts** and **fixes 1** when merging 2f94c29b87ab4108b5ca55d7b6d49f384f7c6393 into 39db7929cff991c8c07763a4a9b8391a1045a234 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-c173806780d0ec648b95a0a6ca8f6525f5eb7a57) **new alerts:** * 2 for Potential input resource leak * 1 for Use of a broken or risky cryptographic algorithm **fixed alerts:** * 1 for Use of a broken or risky cryptographic algorithm This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Create a ClassLoaderService to abstract away dealing with the default > ClassLoader directly > -- > > Key: GEODE-8466 > URL: https://issues.apache.org/jira/browse/GEODE-8466 > Project: Geode > Issue Type: New Feature > Components: core >Reporter: Udo Kohlmeyer >Assignee: Udo Kohlmeyer >Priority: Major > Labels: pull-request-available > > With the addition of ClassLoader isolation using JBoss Modules GEODE-8067, > the manner in which we interact with the ClassLoader needs to change. > An abstraction is required around the default functions like > `findResourceAsStream`, `loadClass` and `loadService`. > As these features will behave differently between different ClassLoader > implementations, it is best to have a single service that will expose that > functionality in a transparent manner. -- This message was sent by Atlassian Jira (v8.3.4#803005)
