[ https://issues.apache.org/jira/browse/GEODE-8655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17225376#comment-17225376 ]
ASF GitHub Bot commented on GEODE-8655: --------------------------------------- mkevo commented on a change in pull request #5669: URL: https://github.com/apache/geode/pull/5669#discussion_r515954661 ########## File path: geode-core/src/main/java/org/apache/geode/internal/net/SocketCreator.java ########## @@ -846,7 +846,14 @@ private boolean setServerNames(SSLParameters modifiedParams, HostAndPort addr) { // ignore - we'll see what happens with endpoint validation using a numeric address... } } - serverNames.add(new SNIHostName(hostName)); + try { + serverNames.add(new SNIHostName(hostName)); + } catch (Exception ex) { Review comment: This issue didn't exist before adding [GEODE-7852](https://issues.apache.org/jira/browse/GEODE-7852). I can't find it where it catches this exception from the [ticket description](https://issues.apache.org/jira/browse/GEODE-8655) and where it logs it. This catch is added to handle this exception: ` java.lang.IllegalArgumentException: Contains non-LDH ASCII characters` I described a failure in the ticket, and need a help to write test for it as it is using ipv6 and TLS. You can try to reproduce it locally. If you need more information to reproduce the issue please contact me via mail or slack. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Not handling exception on SNIHostName > ------------------------------------- > > Key: GEODE-8655 > URL: https://issues.apache.org/jira/browse/GEODE-8655 > Project: Geode > Issue Type: Bug > Components: locator, security > Affects Versions: 1.13.0 > Reporter: Mario Kevo > Assignee: Mario Kevo > Priority: Major > Labels: pull-request-available > > If we start locator with ipv6 and TLS enabled we got following error for > status locator command: > > {quote}mkevo@mkevo-XPS-15-9570:~/apache-geode-1.13.0/bin/locator$ > _/usr/lib/jvm/java-8-openjdk-amd64/jre/bin/java -server -classpath > /home/mkevo/apache-geode-1.13.0/lib/geode-core-1.13.0.jar:/home/mkevo/apache-geode-1.13.0/lib/geode-dependencies.jar > -Djava.net.preferIPv6Addresses=true > -DgemfireSecurityPropertyFile=/home/mkevo/geode-examples/clientSecurity/example_security.properties > -Dgemfire.enable-cluster-configuration=true > -Dgemfire.load-cluster-configuration-from-dir=false > -Dgemfire.launcher.registerSignalHandlers=true -Djava.awt.headless=true > -Dsun.rmi.dgc.server.gcInterval=9223372036854775806 > org.apache.geode.distributed.LocatorLauncher start locator --port=10334_ > > gfsh>_status locator --dir=/home/mkevo/apache-geode-1.13.0/bin/locator > --security-properties-file=/home/mkevo/geode-examples/clientSecurity/example_security.properties_ > *Locator in /home/mkevo/apache-geode-1.13.0/bin/locator on > mkevo-XPS-15-9570[10334] is currently not responding.* > {quote} > > From locator logs we found only this: > {quote}Exception in processing request from fe80:0:0:0:f83e:ce0f:5143:f9ee%2: > Read timed out > {quote} > > After adding some logs we found the following: > {quote}{color:#1d1c1d}TcpClient.stop(): exception connecting to locator > HostAndPort[/0:0:0:0:0:0:0:0:10334]java.lang.IllegalArgumentException: > Contains non-LDH ASCII characters{color} > {quote} > ** > It fails on creating SNIHostName from hostName(_setServerNames_ in > SocketCreator.java) as it not handling above exception. > > -- This message was sent by Atlassian Jira (v8.3.4#803005)