[jira] [Resolved] (GEODE-8569) Missing message security footer check in gnmsg
[ https://issues.apache.org/jira/browse/GEODE-8569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender resolved GEODE-8569. - Resolution: Fixed > Missing message security footer check in gnmsg > -- > > Key: GEODE-8569 > URL: https://issues.apache.org/jira/browse/GEODE-8569 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Blake Bender >Assignee: Blake Bender >Priority: Major > Labels: pull-request-available > > In an older version of the `gnmsg.py` script, there was a function called > request_requires_security_footer that returned a boolean based on the message > name, indictating whether or not the message needed the security footer in a > server conversation with authentication. In the refactor that moved the > client message decoding into a class, this method was left out, so attempting > to decode messages from a client log that used AuthInitialize will throw an > exception attempting to call this missing function. We need to add this call > to the ClientMessageDecoder class. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (GEODE-8569) Missing message security footer check in gnmsg
[ https://issues.apache.org/jira/browse/GEODE-8569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender closed GEODE-8569. --- > Missing message security footer check in gnmsg > -- > > Key: GEODE-8569 > URL: https://issues.apache.org/jira/browse/GEODE-8569 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Blake Bender >Assignee: Blake Bender >Priority: Major > Labels: pull-request-available > > In an older version of the `gnmsg.py` script, there was a function called > request_requires_security_footer that returned a boolean based on the message > name, indictating whether or not the message needed the security footer in a > server conversation with authentication. In the refactor that moved the > client message decoding into a class, this method was left out, so attempting > to decode messages from a client log that used AuthInitialize will throw an > exception attempting to call this missing function. We need to add this call > to the ClientMessageDecoder class. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8157) Write "drop proxy test" for C# (clicache)
[
https://issues.apache.org/jira/browse/GEODE-8157?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219750#comment-17219750
]
ASF GitHub Bot commented on GEODE-8157:
---
pdxcodemonkey commented on a change in pull request #674:
URL: https://github.com/apache/geode-native/pull/674#discussion_r510963460
##
File path: clicache/acceptance-test/SNITests.cs
##
@@ -127,5 +133,38 @@ public void ConnectionWithoutProxyFails()
Assert.Throws(() => region.Put("1", "one"));
}
+
Review comment:
This is probably a correct test until such time as we resolve
GEODE-8628. If it turns out NC should be honoring the read timeout value and
throwing a timeout exception (what I would've expected), then when we fix it to
do so properly, we can update this test to expect throw rather than just
checking if the put is complete. @echobravopapa I'm in favor of resolving this
bug and merging the new test, then writing one to actually shut down and
restart the proxy and catch the proper exception etc. To my mind, these are
different tests, both valid. Let us know what you think.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Write "drop proxy test" for C# (clicache)
> -
>
> Key: GEODE-8157
> URL: https://issues.apache.org/jira/browse/GEODE-8157
> Project: Geode
> Issue Type: New Feature
> Components: native client
>Reporter: Blake Bender
>Priority: Major
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Closed] (GEODE-8340) Enforce Switch compiler warnings as errors
[ https://issues.apache.org/jira/browse/GEODE-8340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender closed GEODE-8340. --- > Enforce Switch compiler warnings as errors > -- > > Key: GEODE-8340 > URL: https://issues.apache.org/jira/browse/GEODE-8340 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Michael Oleske >Priority: Major > Labels: pull-request-available > > Given I compile the code without exempting no-switch-enum and > no-implicit-fallthrough and no-covered-switch-default > Then it should compile > Note - was marked as a todo, seems reasonable to tackle all these at once -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (GEODE-8593) Update native client examples to use Builder pattern
[
https://issues.apache.org/jira/browse/GEODE-8593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Blake Bender closed GEODE-8593.
---
> Update native client examples to use Builder pattern
>
>
> Key: GEODE-8593
> URL: https://issues.apache.org/jira/browse/GEODE-8593
> Project: Geode
> Issue Type: Improvement
> Components: docs, native client
>Affects Versions: 1.13.0
>Reporter: Dave Barnes
>Priority: Major
> Labels: pull-request-available
>
> For both C++ and .NET examples, the section of code that creates the
> connection pool should be improved to better illustrate the Builder pattern.
> For example, in the C++ examples, current code is:
> ```
> auto cacheFactory = CacheFactory();
> cacheFactory.set("log-level", "none");
> auto cache = cacheFactory.create();
> auto poolFactory = cache.getPoolManager().createFactory();
>
> poolFactory.addLocator("localhost", 10334);
> auto pool = poolFactory.create("pool");
> ```
> The improved version would be:
> ```
> auto cache = CacheFactory()
>.set("log-level", "debug")
>.set("ssl-enabled", "true")
>.set("ssl-truststore", clientTruststore.string())
>.create();
> cache.getPoolManager()
> .createFactory()
> .addLocator("localhost", 10334)
> .create("pool");
> ```
> Similarly for .NET examples.
> These doc snippets also appear in the user guides, so they'll need updating
> in the docs, as well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Resolved] (GEODE-8340) Enforce Switch compiler warnings as errors
[ https://issues.apache.org/jira/browse/GEODE-8340?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Blake Bender resolved GEODE-8340. - Resolution: Fixed > Enforce Switch compiler warnings as errors > -- > > Key: GEODE-8340 > URL: https://issues.apache.org/jira/browse/GEODE-8340 > Project: Geode > Issue Type: Improvement > Components: native client >Reporter: Michael Oleske >Priority: Major > Labels: pull-request-available > > Given I compile the code without exempting no-switch-enum and > no-implicit-fallthrough and no-covered-switch-default > Then it should compile > Note - was marked as a todo, seems reasonable to tackle all these at once -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8536) StackOverflow can occur when Lucene IndexWriter is unable to be created
[
https://issues.apache.org/jira/browse/GEODE-8536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219757#comment-17219757
]
ASF GitHub Bot commented on GEODE-8536:
---
DonalEvans merged pull request #5656:
URL: https://github.com/apache/geode/pull/5656
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> StackOverflow can occur when Lucene IndexWriter is unable to be created
> ---
>
> Key: GEODE-8536
> URL: https://issues.apache.org/jira/browse/GEODE-8536
> Project: Geode
> Issue Type: Bug
> Components: functions, lucene
>Affects Versions: 1.12.0, 1.13.0, 1.14.0
>Reporter: Donal Evans
>Assignee: Donal Evans
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.14.0
>
>
> If, during a call to IndexRepositoryFactory.computeIndexRepository(), an
> IOException is encountered when attempting to construct an IndexWriter, the
> function retry logic will reattempt the execution. This allows transient
> exceptions caused by concurrent modification of the fileAndChunk region to be
> ignored and subsequent executions to succeed (see GEODE-7703). However, if
> the IOException is consistently thrown, the infinitely retrying function can
> cause a StackOverflow:
> {noformat}
> java.lang.StackOverflowError
> at
> org.apache.geode.SystemFailure.startWatchDog(SystemFailure.java:320)
> at
> org.apache.geode.SystemFailure.notifyWatchDog(SystemFailure.java:758)
> at org.apache.geode.SystemFailure.setFailure(SystemFailure.java:813)
> at
> org.apache.geode.SystemFailure.initiateFailure(SystemFailure.java:790)
> at
> org.apache.geode.internal.InternalDataSerializer.invokeToData(InternalDataSerializer.java:2251)
> at
> org.apache.geode.internal.InternalDataSerializer.basicWriteObject(InternalDataSerializer.java:2031)
> at
> org.apache.geode.DataSerializer.writeObject(DataSerializer.java:2839)
> at
> org.apache.geode.internal.cache.partitioned.PartitionedRegionFunctionStreamingMessage.toData(PartitionedRegionFunctionStreamingMessage.java:192)
> at
> org.apache.geode.internal.serialization.internal.DSFIDSerializerImpl.invokeToData(DSFIDSerializerImpl.java:213)
> at
> org.apache.geode.internal.serialization.internal.DSFIDSerializerImpl.write(DSFIDSerializerImpl.java:137)
> at
> org.apache.geode.internal.InternalDataSerializer.writeDSFID(InternalDataSerializer.java:1484)
> at
> org.apache.geode.internal.tcp.MsgStreamer.writeMessage(MsgStreamer.java:247)
> at
> org.apache.geode.distributed.internal.direct.DirectChannel.sendToMany(DirectChannel.java:306)
> at
> org.apache.geode.distributed.internal.direct.DirectChannel.sendToOne(DirectChannel.java:182)
> at
> org.apache.geode.distributed.internal.direct.DirectChannel.send(DirectChannel.java:511)
> at
> org.apache.geode.distributed.internal.DistributionImpl.directChannelSend(DistributionImpl.java:346)
> at
> org.apache.geode.distributed.internal.DistributionImpl.send(DistributionImpl.java:291)
> at
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendViaMembershipManager(ClusterDistributionManager.java:2058)
> at
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendOutgoing(ClusterDistributionManager.java:1986)
> at
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendMessage(ClusterDistributionManager.java:2023)
> at
> org.apache.geode.distributed.internal.ClusterDistributionManager.putOutgoing(ClusterDistributionManager.java:1083)
> at
> org.apache.geode.internal.cache.execute.PartitionedRegionFunctionResultWaiter.getPartitionedDataFrom(PartitionedRegionFunctionResultWaiter.java:89)
> at
> org.apache.geode.internal.cache.PartitionedRegion.executeOnAllBuckets(PartitionedRegion.java:4079)
> at
> org.apache.geode.internal.cache.PartitionedRegion.executeFunction(PartitionedRegion.java:3583)
> at
> org.apache.geode.internal.cache.execute.PartitionedRegionFunctionExecutor.executeFunction(PartitionedRegionFunctionExecutor.java:220)
> at
> org.apache.geode.internal.cache.execute.AbstractExecution.execute(AbstractExecution.java:376)
> at
> org.apache.geode.internal.cache.execute.AbstractExecution.execute(AbstractExecution.java:359)
> at
> org.apache.geode.internal.cache.execute.LocalResultCollectorImpl.getResultInternal(LocalResul
[jira] [Resolved] (GEODE-8593) Update native client examples to use Builder pattern
[
https://issues.apache.org/jira/browse/GEODE-8593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Blake Bender resolved GEODE-8593.
-
Resolution: Fixed
> Update native client examples to use Builder pattern
>
>
> Key: GEODE-8593
> URL: https://issues.apache.org/jira/browse/GEODE-8593
> Project: Geode
> Issue Type: Improvement
> Components: docs, native client
>Affects Versions: 1.13.0
>Reporter: Dave Barnes
>Priority: Major
> Labels: pull-request-available
>
> For both C++ and .NET examples, the section of code that creates the
> connection pool should be improved to better illustrate the Builder pattern.
> For example, in the C++ examples, current code is:
> ```
> auto cacheFactory = CacheFactory();
> cacheFactory.set("log-level", "none");
> auto cache = cacheFactory.create();
> auto poolFactory = cache.getPoolManager().createFactory();
>
> poolFactory.addLocator("localhost", 10334);
> auto pool = poolFactory.create("pool");
> ```
> The improved version would be:
> ```
> auto cache = CacheFactory()
>.set("log-level", "debug")
>.set("ssl-enabled", "true")
>.set("ssl-truststore", clientTruststore.string())
>.create();
> cache.getPoolManager()
> .createFactory()
> .addLocator("localhost", 10334)
> .create("pool");
> ```
> Similarly for .NET examples.
> These doc snippets also appear in the user guides, so they'll need updating
> in the docs, as well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8536) StackOverflow can occur when Lucene IndexWriter is unable to be created
[
https://issues.apache.org/jira/browse/GEODE-8536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219759#comment-17219759
]
ASF subversion and git services commented on GEODE-8536:
Commit 293dd68148ff61b937d837c010bcf97ea36a34f9 in geode's branch
refs/heads/develop from Donal Evans
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=293dd68 ]
Revert "GEODE-8536: Allow limited retries when creating Lucene IndexWriter
(#5589)" (#5656)
This reverts commit d2c1d67fd0010c208c320e41a1ef8d6e44710bd1.
> StackOverflow can occur when Lucene IndexWriter is unable to be created
> ---
>
> Key: GEODE-8536
> URL: https://issues.apache.org/jira/browse/GEODE-8536
> Project: Geode
> Issue Type: Bug
> Components: functions, lucene
>Affects Versions: 1.12.0, 1.13.0, 1.14.0
>Reporter: Donal Evans
>Assignee: Donal Evans
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.14.0
>
>
> If, during a call to IndexRepositoryFactory.computeIndexRepository(), an
> IOException is encountered when attempting to construct an IndexWriter, the
> function retry logic will reattempt the execution. This allows transient
> exceptions caused by concurrent modification of the fileAndChunk region to be
> ignored and subsequent executions to succeed (see GEODE-7703). However, if
> the IOException is consistently thrown, the infinitely retrying function can
> cause a StackOverflow:
> {noformat}
> java.lang.StackOverflowError
> at
> org.apache.geode.SystemFailure.startWatchDog(SystemFailure.java:320)
> at
> org.apache.geode.SystemFailure.notifyWatchDog(SystemFailure.java:758)
> at org.apache.geode.SystemFailure.setFailure(SystemFailure.java:813)
> at
> org.apache.geode.SystemFailure.initiateFailure(SystemFailure.java:790)
> at
> org.apache.geode.internal.InternalDataSerializer.invokeToData(InternalDataSerializer.java:2251)
> at
> org.apache.geode.internal.InternalDataSerializer.basicWriteObject(InternalDataSerializer.java:2031)
> at
> org.apache.geode.DataSerializer.writeObject(DataSerializer.java:2839)
> at
> org.apache.geode.internal.cache.partitioned.PartitionedRegionFunctionStreamingMessage.toData(PartitionedRegionFunctionStreamingMessage.java:192)
> at
> org.apache.geode.internal.serialization.internal.DSFIDSerializerImpl.invokeToData(DSFIDSerializerImpl.java:213)
> at
> org.apache.geode.internal.serialization.internal.DSFIDSerializerImpl.write(DSFIDSerializerImpl.java:137)
> at
> org.apache.geode.internal.InternalDataSerializer.writeDSFID(InternalDataSerializer.java:1484)
> at
> org.apache.geode.internal.tcp.MsgStreamer.writeMessage(MsgStreamer.java:247)
> at
> org.apache.geode.distributed.internal.direct.DirectChannel.sendToMany(DirectChannel.java:306)
> at
> org.apache.geode.distributed.internal.direct.DirectChannel.sendToOne(DirectChannel.java:182)
> at
> org.apache.geode.distributed.internal.direct.DirectChannel.send(DirectChannel.java:511)
> at
> org.apache.geode.distributed.internal.DistributionImpl.directChannelSend(DistributionImpl.java:346)
> at
> org.apache.geode.distributed.internal.DistributionImpl.send(DistributionImpl.java:291)
> at
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendViaMembershipManager(ClusterDistributionManager.java:2058)
> at
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendOutgoing(ClusterDistributionManager.java:1986)
> at
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendMessage(ClusterDistributionManager.java:2023)
> at
> org.apache.geode.distributed.internal.ClusterDistributionManager.putOutgoing(ClusterDistributionManager.java:1083)
> at
> org.apache.geode.internal.cache.execute.PartitionedRegionFunctionResultWaiter.getPartitionedDataFrom(PartitionedRegionFunctionResultWaiter.java:89)
> at
> org.apache.geode.internal.cache.PartitionedRegion.executeOnAllBuckets(PartitionedRegion.java:4079)
> at
> org.apache.geode.internal.cache.PartitionedRegion.executeFunction(PartitionedRegion.java:3583)
> at
> org.apache.geode.internal.cache.execute.PartitionedRegionFunctionExecutor.executeFunction(PartitionedRegionFunctionExecutor.java:220)
> at
> org.apache.geode.internal.cache.execute.AbstractExecution.execute(AbstractExecution.java:376)
> at
> org.apache.geode.internal.cache.execute.AbstractExecution.execute(AbstractExecution.java:359)
> at
> org.apache.geode.internal.cache.execute.LocalResultCollectorImpl.getResultInternal(LocalResultCollectorImpl.java:139)
> at
> org.apache.geo
[jira] [Commented] (GEODE-8536) StackOverflow can occur when Lucene IndexWriter is unable to be created
[
https://issues.apache.org/jira/browse/GEODE-8536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219760#comment-17219760
]
ASF subversion and git services commented on GEODE-8536:
Commit 293dd68148ff61b937d837c010bcf97ea36a34f9 in geode's branch
refs/heads/develop from Donal Evans
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=293dd68 ]
Revert "GEODE-8536: Allow limited retries when creating Lucene IndexWriter
(#5589)" (#5656)
This reverts commit d2c1d67fd0010c208c320e41a1ef8d6e44710bd1.
> StackOverflow can occur when Lucene IndexWriter is unable to be created
> ---
>
> Key: GEODE-8536
> URL: https://issues.apache.org/jira/browse/GEODE-8536
> Project: Geode
> Issue Type: Bug
> Components: functions, lucene
>Affects Versions: 1.12.0, 1.13.0, 1.14.0
>Reporter: Donal Evans
>Assignee: Donal Evans
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.14.0
>
>
> If, during a call to IndexRepositoryFactory.computeIndexRepository(), an
> IOException is encountered when attempting to construct an IndexWriter, the
> function retry logic will reattempt the execution. This allows transient
> exceptions caused by concurrent modification of the fileAndChunk region to be
> ignored and subsequent executions to succeed (see GEODE-7703). However, if
> the IOException is consistently thrown, the infinitely retrying function can
> cause a StackOverflow:
> {noformat}
> java.lang.StackOverflowError
> at
> org.apache.geode.SystemFailure.startWatchDog(SystemFailure.java:320)
> at
> org.apache.geode.SystemFailure.notifyWatchDog(SystemFailure.java:758)
> at org.apache.geode.SystemFailure.setFailure(SystemFailure.java:813)
> at
> org.apache.geode.SystemFailure.initiateFailure(SystemFailure.java:790)
> at
> org.apache.geode.internal.InternalDataSerializer.invokeToData(InternalDataSerializer.java:2251)
> at
> org.apache.geode.internal.InternalDataSerializer.basicWriteObject(InternalDataSerializer.java:2031)
> at
> org.apache.geode.DataSerializer.writeObject(DataSerializer.java:2839)
> at
> org.apache.geode.internal.cache.partitioned.PartitionedRegionFunctionStreamingMessage.toData(PartitionedRegionFunctionStreamingMessage.java:192)
> at
> org.apache.geode.internal.serialization.internal.DSFIDSerializerImpl.invokeToData(DSFIDSerializerImpl.java:213)
> at
> org.apache.geode.internal.serialization.internal.DSFIDSerializerImpl.write(DSFIDSerializerImpl.java:137)
> at
> org.apache.geode.internal.InternalDataSerializer.writeDSFID(InternalDataSerializer.java:1484)
> at
> org.apache.geode.internal.tcp.MsgStreamer.writeMessage(MsgStreamer.java:247)
> at
> org.apache.geode.distributed.internal.direct.DirectChannel.sendToMany(DirectChannel.java:306)
> at
> org.apache.geode.distributed.internal.direct.DirectChannel.sendToOne(DirectChannel.java:182)
> at
> org.apache.geode.distributed.internal.direct.DirectChannel.send(DirectChannel.java:511)
> at
> org.apache.geode.distributed.internal.DistributionImpl.directChannelSend(DistributionImpl.java:346)
> at
> org.apache.geode.distributed.internal.DistributionImpl.send(DistributionImpl.java:291)
> at
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendViaMembershipManager(ClusterDistributionManager.java:2058)
> at
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendOutgoing(ClusterDistributionManager.java:1986)
> at
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendMessage(ClusterDistributionManager.java:2023)
> at
> org.apache.geode.distributed.internal.ClusterDistributionManager.putOutgoing(ClusterDistributionManager.java:1083)
> at
> org.apache.geode.internal.cache.execute.PartitionedRegionFunctionResultWaiter.getPartitionedDataFrom(PartitionedRegionFunctionResultWaiter.java:89)
> at
> org.apache.geode.internal.cache.PartitionedRegion.executeOnAllBuckets(PartitionedRegion.java:4079)
> at
> org.apache.geode.internal.cache.PartitionedRegion.executeFunction(PartitionedRegion.java:3583)
> at
> org.apache.geode.internal.cache.execute.PartitionedRegionFunctionExecutor.executeFunction(PartitionedRegionFunctionExecutor.java:220)
> at
> org.apache.geode.internal.cache.execute.AbstractExecution.execute(AbstractExecution.java:376)
> at
> org.apache.geode.internal.cache.execute.AbstractExecution.execute(AbstractExecution.java:359)
> at
> org.apache.geode.internal.cache.execute.LocalResultCollectorImpl.getResultInternal(LocalResultCollectorImpl.java:139)
> at
> org.apache.geo
[jira] [Updated] (GEODE-8067) ClassLoader Isolation
[ https://issues.apache.org/jira/browse/GEODE-8067?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-8067: -- Labels: pull-request-available (was: ) > ClassLoader Isolation > - > > Key: GEODE-8067 > URL: https://issues.apache.org/jira/browse/GEODE-8067 > Project: Geode > Issue Type: New Feature > Components: client/server >Reporter: Udo Kohlmeyer >Assignee: Udo Kohlmeyer >Priority: Major > Labels: pull-request-available > > This is the root jira for the first pass implementation for [ClassLoader > Isolation|https://cwiki.apache.org/confluence/display/GEODE/ClassLoader+Isolation] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8067) ClassLoader Isolation
[ https://issues.apache.org/jira/browse/GEODE-8067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219787#comment-17219787 ] ASF GitHub Bot commented on GEODE-8067: --- rhoughton-pivot opened a new pull request #5660: URL: https://github.com/apache/geode/pull/5660 * Improve project resolution of our nested subprojects for jar manifests * Remove bom from modules list * Move manifest module attributes to java config, not publish Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, check Concourse for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to d...@geode.apache.org. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > ClassLoader Isolation > - > > Key: GEODE-8067 > URL: https://issues.apache.org/jira/browse/GEODE-8067 > Project: Geode > Issue Type: New Feature > Components: client/server >Reporter: Udo Kohlmeyer >Assignee: Udo Kohlmeyer >Priority: Major > > This is the root jira for the first pass implementation for [ClassLoader > Isolation|https://cwiki.apache.org/confluence/display/GEODE/ClassLoader+Isolation] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8536) StackOverflow can occur when Lucene IndexWriter is unable to be created
[
https://issues.apache.org/jira/browse/GEODE-8536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219784#comment-17219784
]
ASF GitHub Bot commented on GEODE-8536:
---
DonalEvans opened a new pull request #5659:
URL: https://github.com/apache/geode/pull/5659
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [x] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [x] Is your initial contribution a single, squashed commit?
- [x] Does `gradlew build` run cleanly?
- [x] Have you written or updated unit tests to verify your changes?
- [N/A] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to d...@geode.apache.org.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> StackOverflow can occur when Lucene IndexWriter is unable to be created
> ---
>
> Key: GEODE-8536
> URL: https://issues.apache.org/jira/browse/GEODE-8536
> Project: Geode
> Issue Type: Bug
> Components: functions, lucene
>Affects Versions: 1.12.0, 1.13.0, 1.14.0
>Reporter: Donal Evans
>Assignee: Donal Evans
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.14.0
>
>
> If, during a call to IndexRepositoryFactory.computeIndexRepository(), an
> IOException is encountered when attempting to construct an IndexWriter, the
> function retry logic will reattempt the execution. This allows transient
> exceptions caused by concurrent modification of the fileAndChunk region to be
> ignored and subsequent executions to succeed (see GEODE-7703). However, if
> the IOException is consistently thrown, the infinitely retrying function can
> cause a StackOverflow:
> {noformat}
> java.lang.StackOverflowError
> at
> org.apache.geode.SystemFailure.startWatchDog(SystemFailure.java:320)
> at
> org.apache.geode.SystemFailure.notifyWatchDog(SystemFailure.java:758)
> at org.apache.geode.SystemFailure.setFailure(SystemFailure.java:813)
> at
> org.apache.geode.SystemFailure.initiateFailure(SystemFailure.java:790)
> at
> org.apache.geode.internal.InternalDataSerializer.invokeToData(InternalDataSerializer.java:2251)
> at
> org.apache.geode.internal.InternalDataSerializer.basicWriteObject(InternalDataSerializer.java:2031)
> at
> org.apache.geode.DataSerializer.writeObject(DataSerializer.java:2839)
> at
> org.apache.geode.internal.cache.partitioned.PartitionedRegionFunctionStreamingMessage.toData(PartitionedRegionFunctionStreamingMessage.java:192)
> at
> org.apache.geode.internal.serialization.internal.DSFIDSerializerImpl.invokeToData(DSFIDSerializerImpl.java:213)
> at
> org.apache.geode.internal.serialization.internal.DSFIDSerializerImpl.write(DSFIDSerializerImpl.java:137)
> at
> org.apache.geode.internal.InternalDataSerializer.writeDSFID(InternalDataSerializer.java:1484)
> at
> org.apache.geode.internal.tcp.MsgStreamer.writeMessage(MsgStreamer.java:247)
> at
> org.apache.geode.distributed.internal.direct.DirectChannel.sendToMany(DirectChannel.java:306)
> at
> org.apache.geode.distributed.internal.direct.DirectChannel.sendToOne(DirectChannel.java:182)
> at
> org.apache.geode.distributed.internal.direct.DirectChannel.send(DirectChannel.java:511)
> at
> org.apache.geode.distributed.internal.DistributionImpl.directChannelSend(DistributionImpl.java:346)
> at
> org.apache.geode.distributed.internal.DistributionImpl.send(DistributionImpl.java:291)
> at
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendViaMembershipManager(ClusterDistributionManager.java:2058)
> at
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendOutgoing(ClusterDistributionManager.java:1986)
> at
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendM
[jira] [Created] (GEODE-8648) RandomRule should use SecureRandom instead of Random
Kirk Lund created GEODE-8648: Summary: RandomRule should use SecureRandom instead of Random Key: GEODE-8648 URL: https://issues.apache.org/jira/browse/GEODE-8648 Project: Geode Issue Type: Wish Reporter: Kirk Lund RandomRule should use SecureRandom instead of Random -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8648) RandomRule should use SecureRandom instead of Random
[ https://issues.apache.org/jira/browse/GEODE-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-8648: - Component/s: tests Description: RandomRule should use java.security.SecureRandom instead of java.util.Random. (was: RandomRule should use SecureRandom instead of Random) > RandomRule should use SecureRandom instead of Random > > > Key: GEODE-8648 > URL: https://issues.apache.org/jira/browse/GEODE-8648 > Project: Geode > Issue Type: Wish > Components: tests >Reporter: Kirk Lund >Priority: Major > > RandomRule should use java.security.SecureRandom instead of java.util.Random. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (GEODE-8648) RandomRule should use SecureRandom instead of Random
[ https://issues.apache.org/jira/browse/GEODE-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund reassigned GEODE-8648: Assignee: Kirk Lund > RandomRule should use SecureRandom instead of Random > > > Key: GEODE-8648 > URL: https://issues.apache.org/jira/browse/GEODE-8648 > Project: Geode > Issue Type: Wish > Components: tests >Reporter: Kirk Lund >Assignee: Kirk Lund >Priority: Major > > RandomRule should use java.security.SecureRandom instead of java.util.Random. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Closed] (GEODE-8646) RandomRule should use SecureRandom instead of Random
[ https://issues.apache.org/jira/browse/GEODE-8646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund closed GEODE-8646. > RandomRule should use SecureRandom instead of Random > > > Key: GEODE-8646 > URL: https://issues.apache.org/jira/browse/GEODE-8646 > Project: Geode > Issue Type: Wish > Components: tests >Reporter: Kirk Lund >Assignee: Kirk Lund >Priority: Major > > RandomRule should use java.security.SecureRandom instead of java.util.Random -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-8646) RandomRule should use SecureRandom instead of Random
[ https://issues.apache.org/jira/browse/GEODE-8646?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund resolved GEODE-8646. -- Resolution: Duplicate > RandomRule should use SecureRandom instead of Random > > > Key: GEODE-8646 > URL: https://issues.apache.org/jira/browse/GEODE-8646 > Project: Geode > Issue Type: Wish > Components: tests >Reporter: Kirk Lund >Assignee: Kirk Lund >Priority: Major > > RandomRule should use java.security.SecureRandom instead of java.util.Random -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-8648) RandomRule should use SecureRandom instead of Random
[ https://issues.apache.org/jira/browse/GEODE-8648?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund resolved GEODE-8648. -- Fix Version/s: 1.14.0 Resolution: Fixed > RandomRule should use SecureRandom instead of Random > > > Key: GEODE-8648 > URL: https://issues.apache.org/jira/browse/GEODE-8648 > Project: Geode > Issue Type: Wish > Components: tests >Reporter: Kirk Lund >Assignee: Kirk Lund >Priority: Major > Fix For: 1.14.0 > > > RandomRule should use java.security.SecureRandom instead of java.util.Random. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-8595) RandomRule to provide GsRandom utilities for dunit tests
[ https://issues.apache.org/jira/browse/GEODE-8595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund resolved GEODE-8595. -- Fix Version/s: 1.14.0 Resolution: Fixed > RandomRule to provide GsRandom utilities for dunit tests > > > Key: GEODE-8595 > URL: https://issues.apache.org/jira/browse/GEODE-8595 > Project: Geode > Issue Type: Wish > Components: tests >Reporter: Kirk Lund >Assignee: Kirk Lund >Priority: Major > Labels: pull-request-available > Fix For: 1.14.0 > > > RandomRule to provide GsRandom utilities for dunit tests. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-8594) DistributedMap junit rule for use in distributed tests
[ https://issues.apache.org/jira/browse/GEODE-8594?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund resolved GEODE-8594. -- Fix Version/s: 1.14.0 Resolution: Fixed > DistributedMap junit rule for use in distributed tests > -- > > Key: GEODE-8594 > URL: https://issues.apache.org/jira/browse/GEODE-8594 > Project: Geode > Issue Type: Wish > Components: tests >Reporter: Kirk Lund >Assignee: Kirk Lund >Priority: Major > Labels: pull-request-available > Fix For: 1.14.0 > > > DistributedMap will provide a map that any dunit vm can use and share data > with other vms. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8531) Coredump when removing an entry
[ https://issues.apache.org/jira/browse/GEODE-8531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219838#comment-17219838 ] ASF GitHub Bot commented on GEODE-8531: --- codecov-io commented on pull request #667: URL: https://github.com/apache/geode-native/pull/667#issuecomment-715476248 # [Codecov](https://codecov.io/gh/apache/geode-native/pull/667?src=pr&el=h1) Report > Merging [#667](https://codecov.io/gh/apache/geode-native/pull/667?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/geode-native/commit/5f06ae2044004397492249fcf13bcd90e75b955b?el=desc) will **decrease** coverage by `0.01%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/geode-native/pull/667?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## develop #667 +/- ## === - Coverage74.03% 74.01% -0.02% === Files 644 644 Lines5113351135 +2 === - Hits 3785437847 -7 - Misses 1327913288 +9 ``` | [Impacted Files](https://codecov.io/gh/apache/geode-native/pull/667?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [cppcache/src/MapSegment.cpp](https://codecov.io/gh/apache/geode-native/pull/667/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL01hcFNlZ21lbnQuY3Bw) | `68.06% <100.00%> (+2.25%)` | :arrow_up: | | [...tion-test/testThinClientRemoteQueryFailoverPdx.cpp](https://codecov.io/gh/apache/geode-native/pull/667/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvaW50ZWdyYXRpb24tdGVzdC90ZXN0VGhpbkNsaWVudFJlbW90ZVF1ZXJ5RmFpbG92ZXJQZHguY3Bw) | `85.48% <0.00%> (-4.04%)` | :arrow_down: | | [cppcache/src/ClientMetadataService.cpp](https://codecov.io/gh/apache/geode-native/pull/667/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL0NsaWVudE1ldGFkYXRhU2VydmljZS5jcHA=) | `62.24% <0.00%> (-3.67%)` | :arrow_down: | | [cppcache/src/TcrEndpoint.cpp](https://codecov.io/gh/apache/geode-native/pull/667/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RjckVuZHBvaW50LmNwcA==) | `54.27% <0.00%> (-2.11%)` | :arrow_down: | | [cppcache/src/TXCommitMessage.cpp](https://codecov.io/gh/apache/geode-native/pull/667/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RYQ29tbWl0TWVzc2FnZS5jcHA=) | `74.50% <0.00%> (-1.97%)` | :arrow_down: | | [cppcache/src/RemoteQuery.cpp](https://codecov.io/gh/apache/geode-native/pull/667/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1JlbW90ZVF1ZXJ5LmNwcA==) | `75.53% <0.00%> (-1.07%)` | :arrow_down: | | [cppcache/src/TcrConnection.cpp](https://codecov.io/gh/apache/geode-native/pull/667/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RjckNvbm5lY3Rpb24uY3Bw) | `72.48% <0.00%> (-0.48%)` | :arrow_down: | | [cppcache/src/ThinClientPoolDM.cpp](https://codecov.io/gh/apache/geode-native/pull/667/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRQb29sRE0uY3Bw) | `75.87% <0.00%> (-0.22%)` | :arrow_down: | | [cppcache/src/ThinClientRedundancyManager.cpp](https://codecov.io/gh/apache/geode-native/pull/667/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRSZWR1bmRhbmN5TWFuYWdlci5jcHA=) | `75.62% <0.00%> (-0.16%)` | :arrow_down: | | [cppcache/src/ThinClientLocatorHelper.cpp](https://codecov.io/gh/apache/geode-native/pull/667/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRMb2NhdG9ySGVscGVyLmNwcA==) | `86.11% <0.00%> (ø)` | | | ... and [9 more](https://codecov.io/gh/apache/geode-native/pull/667/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/geode-native/pull/667?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/geode-native/pull/667?src=pr&el=footer). Last update [5f06ae2...fc0b015](https://codecov.io/gh/apache/geode-native/pull/667?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Coredump when removing an entry > --- > > Key: GEODE-8531 > URL: https://issues.apache.org/jira/browse/GEODE-8531 > Project: Geode > Issue Type: Bug >
[jira] [Commented] (GEODE-8536) StackOverflow can occur when Lucene IndexWriter is unable to be created
[
https://issues.apache.org/jira/browse/GEODE-8536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219882#comment-17219882
]
ASF GitHub Bot commented on GEODE-8536:
---
DonalEvans merged pull request #5659:
URL: https://github.com/apache/geode/pull/5659
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> StackOverflow can occur when Lucene IndexWriter is unable to be created
> ---
>
> Key: GEODE-8536
> URL: https://issues.apache.org/jira/browse/GEODE-8536
> Project: Geode
> Issue Type: Bug
> Components: functions, lucene
>Affects Versions: 1.12.0, 1.13.0, 1.14.0
>Reporter: Donal Evans
>Assignee: Donal Evans
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.14.0
>
>
> If, during a call to IndexRepositoryFactory.computeIndexRepository(), an
> IOException is encountered when attempting to construct an IndexWriter, the
> function retry logic will reattempt the execution. This allows transient
> exceptions caused by concurrent modification of the fileAndChunk region to be
> ignored and subsequent executions to succeed (see GEODE-7703). However, if
> the IOException is consistently thrown, the infinitely retrying function can
> cause a StackOverflow:
> {noformat}
> java.lang.StackOverflowError
> at
> org.apache.geode.SystemFailure.startWatchDog(SystemFailure.java:320)
> at
> org.apache.geode.SystemFailure.notifyWatchDog(SystemFailure.java:758)
> at org.apache.geode.SystemFailure.setFailure(SystemFailure.java:813)
> at
> org.apache.geode.SystemFailure.initiateFailure(SystemFailure.java:790)
> at
> org.apache.geode.internal.InternalDataSerializer.invokeToData(InternalDataSerializer.java:2251)
> at
> org.apache.geode.internal.InternalDataSerializer.basicWriteObject(InternalDataSerializer.java:2031)
> at
> org.apache.geode.DataSerializer.writeObject(DataSerializer.java:2839)
> at
> org.apache.geode.internal.cache.partitioned.PartitionedRegionFunctionStreamingMessage.toData(PartitionedRegionFunctionStreamingMessage.java:192)
> at
> org.apache.geode.internal.serialization.internal.DSFIDSerializerImpl.invokeToData(DSFIDSerializerImpl.java:213)
> at
> org.apache.geode.internal.serialization.internal.DSFIDSerializerImpl.write(DSFIDSerializerImpl.java:137)
> at
> org.apache.geode.internal.InternalDataSerializer.writeDSFID(InternalDataSerializer.java:1484)
> at
> org.apache.geode.internal.tcp.MsgStreamer.writeMessage(MsgStreamer.java:247)
> at
> org.apache.geode.distributed.internal.direct.DirectChannel.sendToMany(DirectChannel.java:306)
> at
> org.apache.geode.distributed.internal.direct.DirectChannel.sendToOne(DirectChannel.java:182)
> at
> org.apache.geode.distributed.internal.direct.DirectChannel.send(DirectChannel.java:511)
> at
> org.apache.geode.distributed.internal.DistributionImpl.directChannelSend(DistributionImpl.java:346)
> at
> org.apache.geode.distributed.internal.DistributionImpl.send(DistributionImpl.java:291)
> at
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendViaMembershipManager(ClusterDistributionManager.java:2058)
> at
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendOutgoing(ClusterDistributionManager.java:1986)
> at
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendMessage(ClusterDistributionManager.java:2023)
> at
> org.apache.geode.distributed.internal.ClusterDistributionManager.putOutgoing(ClusterDistributionManager.java:1083)
> at
> org.apache.geode.internal.cache.execute.PartitionedRegionFunctionResultWaiter.getPartitionedDataFrom(PartitionedRegionFunctionResultWaiter.java:89)
> at
> org.apache.geode.internal.cache.PartitionedRegion.executeOnAllBuckets(PartitionedRegion.java:4079)
> at
> org.apache.geode.internal.cache.PartitionedRegion.executeFunction(PartitionedRegion.java:3583)
> at
> org.apache.geode.internal.cache.execute.PartitionedRegionFunctionExecutor.executeFunction(PartitionedRegionFunctionExecutor.java:220)
> at
> org.apache.geode.internal.cache.execute.AbstractExecution.execute(AbstractExecution.java:376)
> at
> org.apache.geode.internal.cache.execute.AbstractExecution.execute(AbstractExecution.java:359)
> at
> org.apache.geode.internal.cache.execute.LocalResultCollectorImpl.getResultInternal(LocalResul
[jira] [Commented] (GEODE-8536) StackOverflow can occur when Lucene IndexWriter is unable to be created
[
https://issues.apache.org/jira/browse/GEODE-8536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219883#comment-17219883
]
ASF subversion and git services commented on GEODE-8536:
Commit 872718ec9d119e332c328caf4493bdf8e8a83dcf in geode's branch
refs/heads/develop from Donal Evans
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=872718e ]
GEODE-8536: Allow limited retries when creating Lucene IndexWriter (#5659)
Authored-by: Donal Evans
> StackOverflow can occur when Lucene IndexWriter is unable to be created
> ---
>
> Key: GEODE-8536
> URL: https://issues.apache.org/jira/browse/GEODE-8536
> Project: Geode
> Issue Type: Bug
> Components: functions, lucene
>Affects Versions: 1.12.0, 1.13.0, 1.14.0
>Reporter: Donal Evans
>Assignee: Donal Evans
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.14.0
>
>
> If, during a call to IndexRepositoryFactory.computeIndexRepository(), an
> IOException is encountered when attempting to construct an IndexWriter, the
> function retry logic will reattempt the execution. This allows transient
> exceptions caused by concurrent modification of the fileAndChunk region to be
> ignored and subsequent executions to succeed (see GEODE-7703). However, if
> the IOException is consistently thrown, the infinitely retrying function can
> cause a StackOverflow:
> {noformat}
> java.lang.StackOverflowError
> at
> org.apache.geode.SystemFailure.startWatchDog(SystemFailure.java:320)
> at
> org.apache.geode.SystemFailure.notifyWatchDog(SystemFailure.java:758)
> at org.apache.geode.SystemFailure.setFailure(SystemFailure.java:813)
> at
> org.apache.geode.SystemFailure.initiateFailure(SystemFailure.java:790)
> at
> org.apache.geode.internal.InternalDataSerializer.invokeToData(InternalDataSerializer.java:2251)
> at
> org.apache.geode.internal.InternalDataSerializer.basicWriteObject(InternalDataSerializer.java:2031)
> at
> org.apache.geode.DataSerializer.writeObject(DataSerializer.java:2839)
> at
> org.apache.geode.internal.cache.partitioned.PartitionedRegionFunctionStreamingMessage.toData(PartitionedRegionFunctionStreamingMessage.java:192)
> at
> org.apache.geode.internal.serialization.internal.DSFIDSerializerImpl.invokeToData(DSFIDSerializerImpl.java:213)
> at
> org.apache.geode.internal.serialization.internal.DSFIDSerializerImpl.write(DSFIDSerializerImpl.java:137)
> at
> org.apache.geode.internal.InternalDataSerializer.writeDSFID(InternalDataSerializer.java:1484)
> at
> org.apache.geode.internal.tcp.MsgStreamer.writeMessage(MsgStreamer.java:247)
> at
> org.apache.geode.distributed.internal.direct.DirectChannel.sendToMany(DirectChannel.java:306)
> at
> org.apache.geode.distributed.internal.direct.DirectChannel.sendToOne(DirectChannel.java:182)
> at
> org.apache.geode.distributed.internal.direct.DirectChannel.send(DirectChannel.java:511)
> at
> org.apache.geode.distributed.internal.DistributionImpl.directChannelSend(DistributionImpl.java:346)
> at
> org.apache.geode.distributed.internal.DistributionImpl.send(DistributionImpl.java:291)
> at
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendViaMembershipManager(ClusterDistributionManager.java:2058)
> at
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendOutgoing(ClusterDistributionManager.java:1986)
> at
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendMessage(ClusterDistributionManager.java:2023)
> at
> org.apache.geode.distributed.internal.ClusterDistributionManager.putOutgoing(ClusterDistributionManager.java:1083)
> at
> org.apache.geode.internal.cache.execute.PartitionedRegionFunctionResultWaiter.getPartitionedDataFrom(PartitionedRegionFunctionResultWaiter.java:89)
> at
> org.apache.geode.internal.cache.PartitionedRegion.executeOnAllBuckets(PartitionedRegion.java:4079)
> at
> org.apache.geode.internal.cache.PartitionedRegion.executeFunction(PartitionedRegion.java:3583)
> at
> org.apache.geode.internal.cache.execute.PartitionedRegionFunctionExecutor.executeFunction(PartitionedRegionFunctionExecutor.java:220)
> at
> org.apache.geode.internal.cache.execute.AbstractExecution.execute(AbstractExecution.java:376)
> at
> org.apache.geode.internal.cache.execute.AbstractExecution.execute(AbstractExecution.java:359)
> at
> org.apache.geode.internal.cache.execute.LocalResultCollectorImpl.getResultInternal(LocalResultCollectorImpl.java:139)
> at
> org.apache.geode.internal.cache.execute.ResultCollectorHolder.getRes
[jira] [Commented] (GEODE-8536) StackOverflow can occur when Lucene IndexWriter is unable to be created
[
https://issues.apache.org/jira/browse/GEODE-8536?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219885#comment-17219885
]
ASF subversion and git services commented on GEODE-8536:
Commit 872718ec9d119e332c328caf4493bdf8e8a83dcf in geode's branch
refs/heads/develop from Donal Evans
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=872718e ]
GEODE-8536: Allow limited retries when creating Lucene IndexWriter (#5659)
Authored-by: Donal Evans
> StackOverflow can occur when Lucene IndexWriter is unable to be created
> ---
>
> Key: GEODE-8536
> URL: https://issues.apache.org/jira/browse/GEODE-8536
> Project: Geode
> Issue Type: Bug
> Components: functions, lucene
>Affects Versions: 1.12.0, 1.13.0, 1.14.0
>Reporter: Donal Evans
>Assignee: Donal Evans
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.14.0
>
>
> If, during a call to IndexRepositoryFactory.computeIndexRepository(), an
> IOException is encountered when attempting to construct an IndexWriter, the
> function retry logic will reattempt the execution. This allows transient
> exceptions caused by concurrent modification of the fileAndChunk region to be
> ignored and subsequent executions to succeed (see GEODE-7703). However, if
> the IOException is consistently thrown, the infinitely retrying function can
> cause a StackOverflow:
> {noformat}
> java.lang.StackOverflowError
> at
> org.apache.geode.SystemFailure.startWatchDog(SystemFailure.java:320)
> at
> org.apache.geode.SystemFailure.notifyWatchDog(SystemFailure.java:758)
> at org.apache.geode.SystemFailure.setFailure(SystemFailure.java:813)
> at
> org.apache.geode.SystemFailure.initiateFailure(SystemFailure.java:790)
> at
> org.apache.geode.internal.InternalDataSerializer.invokeToData(InternalDataSerializer.java:2251)
> at
> org.apache.geode.internal.InternalDataSerializer.basicWriteObject(InternalDataSerializer.java:2031)
> at
> org.apache.geode.DataSerializer.writeObject(DataSerializer.java:2839)
> at
> org.apache.geode.internal.cache.partitioned.PartitionedRegionFunctionStreamingMessage.toData(PartitionedRegionFunctionStreamingMessage.java:192)
> at
> org.apache.geode.internal.serialization.internal.DSFIDSerializerImpl.invokeToData(DSFIDSerializerImpl.java:213)
> at
> org.apache.geode.internal.serialization.internal.DSFIDSerializerImpl.write(DSFIDSerializerImpl.java:137)
> at
> org.apache.geode.internal.InternalDataSerializer.writeDSFID(InternalDataSerializer.java:1484)
> at
> org.apache.geode.internal.tcp.MsgStreamer.writeMessage(MsgStreamer.java:247)
> at
> org.apache.geode.distributed.internal.direct.DirectChannel.sendToMany(DirectChannel.java:306)
> at
> org.apache.geode.distributed.internal.direct.DirectChannel.sendToOne(DirectChannel.java:182)
> at
> org.apache.geode.distributed.internal.direct.DirectChannel.send(DirectChannel.java:511)
> at
> org.apache.geode.distributed.internal.DistributionImpl.directChannelSend(DistributionImpl.java:346)
> at
> org.apache.geode.distributed.internal.DistributionImpl.send(DistributionImpl.java:291)
> at
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendViaMembershipManager(ClusterDistributionManager.java:2058)
> at
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendOutgoing(ClusterDistributionManager.java:1986)
> at
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendMessage(ClusterDistributionManager.java:2023)
> at
> org.apache.geode.distributed.internal.ClusterDistributionManager.putOutgoing(ClusterDistributionManager.java:1083)
> at
> org.apache.geode.internal.cache.execute.PartitionedRegionFunctionResultWaiter.getPartitionedDataFrom(PartitionedRegionFunctionResultWaiter.java:89)
> at
> org.apache.geode.internal.cache.PartitionedRegion.executeOnAllBuckets(PartitionedRegion.java:4079)
> at
> org.apache.geode.internal.cache.PartitionedRegion.executeFunction(PartitionedRegion.java:3583)
> at
> org.apache.geode.internal.cache.execute.PartitionedRegionFunctionExecutor.executeFunction(PartitionedRegionFunctionExecutor.java:220)
> at
> org.apache.geode.internal.cache.execute.AbstractExecution.execute(AbstractExecution.java:376)
> at
> org.apache.geode.internal.cache.execute.AbstractExecution.execute(AbstractExecution.java:359)
> at
> org.apache.geode.internal.cache.execute.LocalResultCollectorImpl.getResultInternal(LocalResultCollectorImpl.java:139)
> at
> org.apache.geode.internal.cache.execute.ResultCollectorHolder.getRes
[jira] [Resolved] (GEODE-8640) CI Failure: IndexRepositoryFactoryIntegrationTest.shouldRetryWhenIOExceptionEncounteredOnceDuringComputingRepository
[
https://issues.apache.org/jira/browse/GEODE-8640?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Donal Evans resolved GEODE-8640.
Fix Version/s: 1.14.0
Resolution: Fixed
> CI Failure:
> IndexRepositoryFactoryIntegrationTest.shouldRetryWhenIOExceptionEncounteredOnceDuringComputingRepository
>
>
> Key: GEODE-8640
> URL: https://issues.apache.org/jira/browse/GEODE-8640
> Project: Geode
> Issue Type: Test
> Components: tests
>Reporter: Jens Deppe
>Assignee: Donal Evans
>Priority: Major
> Fix For: 1.14.0
>
>
> This is a new test which failed on Windows:
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/WindowsIntegrationTestOpenJDK8/builds/500
> {noformat}
> org.apache.geode.cache.lucene.internal.IndexRepositoryFactoryIntegrationTest
> > shouldRetryWhenIOExceptionEncounteredOnceDuringComputingRepository FAILED
> org.mockito.exceptions.verification.TooManyActualInvocations:
> indexRepositoryFactory.getIndexWriter(
> ,
>
> );
> Wanted 20 times:
> -> at
> org.apache.geode.cache.lucene.internal.IndexRepositoryFactoryIntegrationTest.shouldRetryWhenIOExceptionEncounteredOnceDuringComputingRepository(IndexRepositoryFactoryIntegrationTest.java:108)
> But was 21 times:
> -> at
> org.apache.geode.cache.lucene.internal.IndexRepositoryFactory.buildIndexWriter(IndexRepositoryFactory.java:160)
> -> at
> org.apache.geode.cache.lucene.internal.IndexRepositoryFactory.buildIndexWriter(IndexRepositoryFactory.java:160)
> -> at
> org.apache.geode.cache.lucene.internal.IndexRepositoryFactory.buildIndexWriter(IndexRepositoryFactory.java:160)
> -> at
> org.apache.geode.cache.lucene.internal.IndexRepositoryFactory.buildIndexWriter(IndexRepositoryFactory.java:160)
> -> at
> org.apache.geode.cache.lucene.internal.IndexRepositoryFactory.buildIndexWriter(IndexRepositoryFactory.java:160)
> -> at
> org.apache.geode.cache.lucene.internal.IndexRepositoryFactory.buildIndexWriter(IndexRepositoryFactory.java:160)
> -> at
> org.apache.geode.cache.lucene.internal.IndexRepositoryFactory.buildIndexWriter(IndexRepositoryFactory.java:160)
> -> at
> org.apache.geode.cache.lucene.internal.IndexRepositoryFactory.buildIndexWriter(IndexRepositoryFactory.java:160)
> -> at
> org.apache.geode.cache.lucene.internal.IndexRepositoryFactory.buildIndexWriter(IndexRepositoryFactory.java:160)
> -> at
> org.apache.geode.cache.lucene.internal.IndexRepositoryFactory.buildIndexWriter(IndexRepositoryFactory.java:160)
> -> at
> org.apache.geode.cache.lucene.internal.IndexRepositoryFactory.buildIndexWriter(IndexRepositoryFactory.java:160)
> -> at
> org.apache.geode.cache.lucene.internal.IndexRepositoryFactory.buildIndexWriter(IndexRepositoryFactory.java:160)
> -> at
> org.apache.geode.cache.lucene.internal.IndexRepositoryFactory.buildIndexWriter(IndexRepositoryFactory.java:160)
> -> at
> org.apache.geode.cache.lucene.internal.IndexRepositoryFactory.buildIndexWriter(IndexRepositoryFactory.java:160)
> -> at
> org.apache.geode.cache.lucene.internal.IndexRepositoryFactory.buildIndexWriter(IndexRepositoryFactory.java:160)
> -> at
> org.apache.geode.cache.lucene.internal.IndexRepositoryFactory.buildIndexWriter(IndexRepositoryFactory.java:160)
> -> at
> org.apache.geode.cache.lucene.internal.IndexRepositoryFactory.buildIndexWriter(IndexRepositoryFactory.java:160)
> -> at
> org.apache.geode.cache.lucene.internal.IndexRepositoryFactory.buildIndexWriter(IndexRepositoryFactory.java:160)
> -> at
> org.apache.geode.cache.lucene.internal.IndexRepositoryFactory.buildIndexWriter(IndexRepositoryFactory.java:160)
> -> at
> org.apache.geode.cache.lucene.internal.IndexRepositoryFactory.buildIndexWriter(IndexRepositoryFactory.java:160)
> -> at
> org.apache.geode.cache.lucene.internal.IndexRepositoryFactory.buildIndexWriter(IndexRepositoryFactory.java:160)
> at
> org.apache.geode.cache.lucene.internal.IndexRepositoryFactoryIntegrationTest.shouldRetryWhenIOExceptionEncounteredOnceDuringComputingRepository(IndexRepositoryFactoryIntegrationTest.java:108)
> {noformat}
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0426/test-results/integrationTest/1603316110/
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> Test report artifacts from this job are available at:
> http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0426/test-artifacts/1603316110/windows-integrationtestfiles-OpenJDK8-1.14.0-build.0426.tgz
--
This message was sent by Atlassi
[jira] [Commented] (GEODE-8567) CI Failure: ConcurrentSerialGatewaySenderOperationsDistributedTest > testRestartSerialGatewaySendersWhilePutting
[ https://issues.apache.org/jira/browse/GEODE-8567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219891#comment-17219891 ] Geode Integration commented on GEODE-8567: -- Seen in [DistributedTestOpenJDK11 #544|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK11/builds/544] ... see [test results|http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0437/test-results/distributedTest/1603476472/] or download [artifacts|http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0437/test-artifacts/1603476472/distributedtestfiles-OpenJDK11-1.14.0-build.0437.tgz]. > CI Failure: ConcurrentSerialGatewaySenderOperationsDistributedTest > > testRestartSerialGatewaySendersWhilePutting > > > Key: GEODE-8567 > URL: https://issues.apache.org/jira/browse/GEODE-8567 > Project: Geode > Issue Type: Improvement > Components: wan >Reporter: Owen Nichols >Priority: Major > > ConcurrentSerialGatewaySenderOperationsDistributedTest > > testRestartSerialGatewaySendersWhilePutting[1: numDispatchers=3] FAILED > seen in > [DistributedTestOpenJDK11|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK11/builds/490] > #490 > > Task :geode-wan:distributedTest > org.apache.geode.internal.cache.wan.concurrent.ConcurrentSerialGatewaySenderOperationsDistributedTest > > testRestartSerialGatewaySendersWhilePutting[1: numDispatchers=3] FAILED > org.apache.geode.test.dunit.RMIException: While invoking > org.apache.geode.internal.cache.wan.serial.SerialGatewaySenderOperationsDistributedTest$$Lambda$490/0x00010094b040.run > in VM 5 running on Host 60d64fc07216 with 8 VMs > Caused by: > org.awaitility.core.ConditionTimeoutException: Assertion condition > defined as a lambda expression in > org.apache.geode.internal.cache.wan.serial.SerialGatewaySenderOperationsDistributedTest > that uses org.apache.geode.internal.cache.wan.InternalGatewaySender, > org.apache.geode.internal.cache.wan.InternalGatewaySenderint [Sender > statistics unprocessed event map size] expected:<[0]> but was:<[2]> within 5 > minutes. > Caused by: > org.junit.ComparisonFailure: [Sender statistics unprocessed event > map size] expected:<[0]> but was:<[2]> > =-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI > =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= > [*http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0380/test-results/distributedTest/1601531249/*] > =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= > Test report artifacts from this job are available at: > [*http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0380/test-artifacts/1601531249/distributedtestfiles-OpenJDK11-1.14.0-build.0380.tgz*] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8567) CI Failure: ConcurrentSerialGatewaySenderOperationsDistributedTest > testRestartSerialGatewaySendersWhilePutting
[ https://issues.apache.org/jira/browse/GEODE-8567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219894#comment-17219894 ] John Hutchison commented on GEODE-8567: --- occurred again here: https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK11/builds/544 > CI Failure: ConcurrentSerialGatewaySenderOperationsDistributedTest > > testRestartSerialGatewaySendersWhilePutting > > > Key: GEODE-8567 > URL: https://issues.apache.org/jira/browse/GEODE-8567 > Project: Geode > Issue Type: Improvement > Components: wan >Reporter: Owen Nichols >Priority: Major > > ConcurrentSerialGatewaySenderOperationsDistributedTest > > testRestartSerialGatewaySendersWhilePutting[1: numDispatchers=3] FAILED > seen in > [DistributedTestOpenJDK11|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK11/builds/490] > #490 > > Task :geode-wan:distributedTest > org.apache.geode.internal.cache.wan.concurrent.ConcurrentSerialGatewaySenderOperationsDistributedTest > > testRestartSerialGatewaySendersWhilePutting[1: numDispatchers=3] FAILED > org.apache.geode.test.dunit.RMIException: While invoking > org.apache.geode.internal.cache.wan.serial.SerialGatewaySenderOperationsDistributedTest$$Lambda$490/0x00010094b040.run > in VM 5 running on Host 60d64fc07216 with 8 VMs > Caused by: > org.awaitility.core.ConditionTimeoutException: Assertion condition > defined as a lambda expression in > org.apache.geode.internal.cache.wan.serial.SerialGatewaySenderOperationsDistributedTest > that uses org.apache.geode.internal.cache.wan.InternalGatewaySender, > org.apache.geode.internal.cache.wan.InternalGatewaySenderint [Sender > statistics unprocessed event map size] expected:<[0]> but was:<[2]> within 5 > minutes. > Caused by: > org.junit.ComparisonFailure: [Sender statistics unprocessed event > map size] expected:<[0]> but was:<[2]> > =-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI > =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= > [*http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0380/test-results/distributedTest/1601531249/*] > =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= > Test report artifacts from this job are available at: > [*http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0380/test-artifacts/1601531249/distributedtestfiles-OpenJDK11-1.14.0-build.0380.tgz*] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8567) CI Failure: ConcurrentSerialGatewaySenderOperationsDistributedTest > testRestartSerialGatewaySendersWhilePutting
[ https://issues.apache.org/jira/browse/GEODE-8567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219893#comment-17219893 ] Geode Integration commented on GEODE-8567: -- Seen in [DistributedTestOpenJDK11 #544|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK11/builds/544] ... see [test results|http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0437/test-results/distributedTest/1603476472/] or download [artifacts|http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0437/test-artifacts/1603476472/distributedtestfiles-OpenJDK11-1.14.0-build.0437.tgz]. > CI Failure: ConcurrentSerialGatewaySenderOperationsDistributedTest > > testRestartSerialGatewaySendersWhilePutting > > > Key: GEODE-8567 > URL: https://issues.apache.org/jira/browse/GEODE-8567 > Project: Geode > Issue Type: Improvement > Components: wan >Reporter: Owen Nichols >Priority: Major > > ConcurrentSerialGatewaySenderOperationsDistributedTest > > testRestartSerialGatewaySendersWhilePutting[1: numDispatchers=3] FAILED > seen in > [DistributedTestOpenJDK11|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK11/builds/490] > #490 > > Task :geode-wan:distributedTest > org.apache.geode.internal.cache.wan.concurrent.ConcurrentSerialGatewaySenderOperationsDistributedTest > > testRestartSerialGatewaySendersWhilePutting[1: numDispatchers=3] FAILED > org.apache.geode.test.dunit.RMIException: While invoking > org.apache.geode.internal.cache.wan.serial.SerialGatewaySenderOperationsDistributedTest$$Lambda$490/0x00010094b040.run > in VM 5 running on Host 60d64fc07216 with 8 VMs > Caused by: > org.awaitility.core.ConditionTimeoutException: Assertion condition > defined as a lambda expression in > org.apache.geode.internal.cache.wan.serial.SerialGatewaySenderOperationsDistributedTest > that uses org.apache.geode.internal.cache.wan.InternalGatewaySender, > org.apache.geode.internal.cache.wan.InternalGatewaySenderint [Sender > statistics unprocessed event map size] expected:<[0]> but was:<[2]> within 5 > minutes. > Caused by: > org.junit.ComparisonFailure: [Sender statistics unprocessed event > map size] expected:<[0]> but was:<[2]> > =-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI > =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= > [*http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0380/test-results/distributedTest/1601531249/*] > =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= > Test report artifacts from this job are available at: > [*http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0380/test-artifacts/1601531249/distributedtestfiles-OpenJDK11-1.14.0-build.0380.tgz*] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (GEODE-8567) CI Failure: ConcurrentSerialGatewaySenderOperationsDistributedTest > testRestartSerialGatewaySendersWhilePutting
[ https://issues.apache.org/jira/browse/GEODE-8567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219894#comment-17219894 ] John Hutchison edited comment on GEODE-8567 at 10/23/20, 7:33 PM: -- http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0437/test-results/distributedTest/1603476472/ Test report artifacts from this job are available at: http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0437/test-artifacts/1603476472/distributedtestfiles-OpenJDK11-1.14.0-build.0437.tgz was (Author: john hutch): occurred again here: https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK11/builds/544 > CI Failure: ConcurrentSerialGatewaySenderOperationsDistributedTest > > testRestartSerialGatewaySendersWhilePutting > > > Key: GEODE-8567 > URL: https://issues.apache.org/jira/browse/GEODE-8567 > Project: Geode > Issue Type: Improvement > Components: wan >Reporter: Owen Nichols >Priority: Major > > ConcurrentSerialGatewaySenderOperationsDistributedTest > > testRestartSerialGatewaySendersWhilePutting[1: numDispatchers=3] FAILED > seen in > [DistributedTestOpenJDK11|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK11/builds/490] > #490 > > Task :geode-wan:distributedTest > org.apache.geode.internal.cache.wan.concurrent.ConcurrentSerialGatewaySenderOperationsDistributedTest > > testRestartSerialGatewaySendersWhilePutting[1: numDispatchers=3] FAILED > org.apache.geode.test.dunit.RMIException: While invoking > org.apache.geode.internal.cache.wan.serial.SerialGatewaySenderOperationsDistributedTest$$Lambda$490/0x00010094b040.run > in VM 5 running on Host 60d64fc07216 with 8 VMs > Caused by: > org.awaitility.core.ConditionTimeoutException: Assertion condition > defined as a lambda expression in > org.apache.geode.internal.cache.wan.serial.SerialGatewaySenderOperationsDistributedTest > that uses org.apache.geode.internal.cache.wan.InternalGatewaySender, > org.apache.geode.internal.cache.wan.InternalGatewaySenderint [Sender > statistics unprocessed event map size] expected:<[0]> but was:<[2]> within 5 > minutes. > Caused by: > org.junit.ComparisonFailure: [Sender statistics unprocessed event > map size] expected:<[0]> but was:<[2]> > =-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI > =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= > [*http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0380/test-results/distributedTest/1601531249/*] > =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= > Test report artifacts from this job are available at: > [*http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0380/test-artifacts/1601531249/distributedtestfiles-OpenJDK11-1.14.0-build.0380.tgz*] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Comment Edited] (GEODE-8567) CI Failure: ConcurrentSerialGatewaySenderOperationsDistributedTest > testRestartSerialGatewaySendersWhilePutting
[ https://issues.apache.org/jira/browse/GEODE-8567?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219894#comment-17219894 ] John Hutchison edited comment on GEODE-8567 at 10/23/20, 7:33 PM: -- [http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0437/test-results/distributedTest/1603476472/] Test report artifacts from this job are available at: [http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0437/test-artifacts/1603476472/distributedtestfiles-OpenJDK11-1.14.0-build.0437.tgz] was (Author: john hutch): http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0437/test-results/distributedTest/1603476472/ Test report artifacts from this job are available at: http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0437/test-artifacts/1603476472/distributedtestfiles-OpenJDK11-1.14.0-build.0437.tgz > CI Failure: ConcurrentSerialGatewaySenderOperationsDistributedTest > > testRestartSerialGatewaySendersWhilePutting > > > Key: GEODE-8567 > URL: https://issues.apache.org/jira/browse/GEODE-8567 > Project: Geode > Issue Type: Improvement > Components: wan >Reporter: Owen Nichols >Priority: Major > > ConcurrentSerialGatewaySenderOperationsDistributedTest > > testRestartSerialGatewaySendersWhilePutting[1: numDispatchers=3] FAILED > seen in > [DistributedTestOpenJDK11|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK11/builds/490] > #490 > > Task :geode-wan:distributedTest > org.apache.geode.internal.cache.wan.concurrent.ConcurrentSerialGatewaySenderOperationsDistributedTest > > testRestartSerialGatewaySendersWhilePutting[1: numDispatchers=3] FAILED > org.apache.geode.test.dunit.RMIException: While invoking > org.apache.geode.internal.cache.wan.serial.SerialGatewaySenderOperationsDistributedTest$$Lambda$490/0x00010094b040.run > in VM 5 running on Host 60d64fc07216 with 8 VMs > Caused by: > org.awaitility.core.ConditionTimeoutException: Assertion condition > defined as a lambda expression in > org.apache.geode.internal.cache.wan.serial.SerialGatewaySenderOperationsDistributedTest > that uses org.apache.geode.internal.cache.wan.InternalGatewaySender, > org.apache.geode.internal.cache.wan.InternalGatewaySenderint [Sender > statistics unprocessed event map size] expected:<[0]> but was:<[2]> within 5 > minutes. > Caused by: > org.junit.ComparisonFailure: [Sender statistics unprocessed event > map size] expected:<[0]> but was:<[2]> > =-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI > =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= > [*http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0380/test-results/distributedTest/1601531249/*] > =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-= > Test report artifacts from this job are available at: > [*http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0380/test-artifacts/1601531249/distributedtestfiles-OpenJDK11-1.14.0-build.0380.tgz*] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8067) ClassLoader Isolation
[ https://issues.apache.org/jira/browse/GEODE-8067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219898#comment-17219898 ] ASF GitHub Bot commented on GEODE-8067: --- kohlmu-pivotal merged pull request #5660: URL: https://github.com/apache/geode/pull/5660 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > ClassLoader Isolation > - > > Key: GEODE-8067 > URL: https://issues.apache.org/jira/browse/GEODE-8067 > Project: Geode > Issue Type: New Feature > Components: client/server >Reporter: Udo Kohlmeyer >Assignee: Udo Kohlmeyer >Priority: Major > Labels: pull-request-available > > This is the root jira for the first pass implementation for [ClassLoader > Isolation|https://cwiki.apache.org/confluence/display/GEODE/ClassLoader+Isolation] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8067) ClassLoader Isolation
[ https://issues.apache.org/jira/browse/GEODE-8067?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219902#comment-17219902 ] ASF subversion and git services commented on GEODE-8067: Commit 0fdfc1ad1e272eed9bf5e2ee59816b75b262d9c6 in geode's branch refs/heads/develop from Robert Houghton [ https://gitbox.apache.org/repos/asf?p=geode.git;h=0fdfc1a ] GEODE-8067: Improve manifest module resolution (#5660) * Improve project resolution of our nested subprojects for jar manifests * Remove bom from modules list * Move manifest module attributes to java config, not publish > ClassLoader Isolation > - > > Key: GEODE-8067 > URL: https://issues.apache.org/jira/browse/GEODE-8067 > Project: Geode > Issue Type: New Feature > Components: client/server >Reporter: Udo Kohlmeyer >Assignee: Udo Kohlmeyer >Priority: Major > Labels: pull-request-available > > This is the root jira for the first pass implementation for [ClassLoader > Isolation|https://cwiki.apache.org/confluence/display/GEODE/ClassLoader+Isolation] -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (GEODE-8649) Update Redis INFO command to support more fields
Raymond Ingles created GEODE-8649:
-
Summary: Update Redis INFO command to support more fields
Key: GEODE-8649
URL: https://issues.apache.org/jira/browse/GEODE-8649
Project: Geode
Issue Type: Improvement
Components: redis
Affects Versions: 1.14.0
Reporter: Raymond Ingles
Various monitoring software suites use the Redis INFO command to gather data
about a running Redis instance. Adding the following fields will allow at least
Datadog's Redis Dashboard to function with Geode Redis:
* {{instantaneous_ops_per_sec}}
* {{keyspace_hits}} and {{keyspace_misses}}
* {{evicted_keys}}
* {{mem_fragmentation_ratio}})
* {{blocked_clients}})
* {{used_memory}}
* {{connected_slaves}}
* {{rejected_connections}}
* {{connected_clients}}
* {{keys}}
* {{rdb_changes_since_last_save}} and {{rdb_last_save_time}}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (GEODE-8650) Support using multiple DistributedReference Rules in one test
Kirk Lund created GEODE-8650: Summary: Support using multiple DistributedReference Rules in one test Key: GEODE-8650 URL: https://issues.apache.org/jira/browse/GEODE-8650 Project: Geode Issue Type: Wish Components: tests Reporter: Kirk Lund Support using multiple DistributedReference Rules in one test. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8650) Support using multiple DistributedReference Rules in one test
[ https://issues.apache.org/jira/browse/GEODE-8650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund updated GEODE-8650: - Description: Support using multiple DistributedReference Rules in one test. Right now the Rule only supports having one instance in a test. (was: Support using multiple DistributedReference Rules in one test.) > Support using multiple DistributedReference Rules in one test > - > > Key: GEODE-8650 > URL: https://issues.apache.org/jira/browse/GEODE-8650 > Project: Geode > Issue Type: Wish > Components: tests >Reporter: Kirk Lund >Assignee: Kirk Lund >Priority: Major > > Support using multiple DistributedReference Rules in one test. Right now the > Rule only supports having one instance in a test. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (GEODE-8650) Support using multiple DistributedReference Rules in one test
[ https://issues.apache.org/jira/browse/GEODE-8650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kirk Lund reassigned GEODE-8650: Assignee: Kirk Lund > Support using multiple DistributedReference Rules in one test > - > > Key: GEODE-8650 > URL: https://issues.apache.org/jira/browse/GEODE-8650 > Project: Geode > Issue Type: Wish > Components: tests >Reporter: Kirk Lund >Assignee: Kirk Lund >Priority: Major > > Support using multiple DistributedReference Rules in one test. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8650) Support using multiple DistributedReference Rules in one test
[ https://issues.apache.org/jira/browse/GEODE-8650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-8650: -- Labels: pull-request-available (was: ) > Support using multiple DistributedReference Rules in one test > - > > Key: GEODE-8650 > URL: https://issues.apache.org/jira/browse/GEODE-8650 > Project: Geode > Issue Type: Wish > Components: tests >Reporter: Kirk Lund >Assignee: Kirk Lund >Priority: Major > Labels: pull-request-available > > Support using multiple DistributedReference Rules in one test. Right now the > Rule only supports having one instance in a test. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8650) Support using multiple DistributedReference Rules in one test
[ https://issues.apache.org/jira/browse/GEODE-8650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219928#comment-17219928 ] ASF GitHub Bot commented on GEODE-8650: --- kirklund opened a new pull request #5664: URL: https://github.com/apache/geode/pull/5664 Includes additional improvements for usage of DistributedReference in tests. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support using multiple DistributedReference Rules in one test > - > > Key: GEODE-8650 > URL: https://issues.apache.org/jira/browse/GEODE-8650 > Project: Geode > Issue Type: Wish > Components: tests >Reporter: Kirk Lund >Assignee: Kirk Lund >Priority: Major > > Support using multiple DistributedReference Rules in one test. Right now the > Rule only supports having one instance in a test. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-5782) LauncherMemberMXBeanIntegrationTest can fail intermittently
[
https://issues.apache.org/jira/browse/GEODE-5782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219931#comment-17219931
]
ASF GitHub Bot commented on GEODE-5782:
---
kirklund commented on a change in pull request #5648:
URL: https://github.com/apache/geode/pull/5648#discussion_r511141909
##
File path:
geode-core/src/integrationTest/java/org/apache/geode/distributed/LauncherMemberMXBeanIntegrationTest.java
##
@@ -227,6 +227,8 @@ public void showJVMMetrics_returnsOJVMMetricsType()
if (cdsValue.equals(osMetricValue)) {
break;
}
+System.gc();
+System.runFinalization();
Review comment:
I'm really reluctant to add `gc()` or `runFinalization()`. Why do you
think these will fix flakiness in this test?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> LauncherMemberMXBeanIntegrationTest can fail intermittently
> ---
>
> Key: GEODE-5782
> URL: https://issues.apache.org/jira/browse/GEODE-5782
> Project: Geode
> Issue Type: Test
> Components: jmx
>Affects Versions: 1.9.0
>Reporter: Jens Deppe
>Assignee: Jens Deppe
>Priority: Major
> Labels: pull-request-available
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Noticed this failure:
> {noformat}
> org.apache.geode.distributed.LauncherMemberMXBeanIntegrationTest >
> showOSMetrics_reconstructsOSMetricsFromCompositeDataType FAILED
> org.junit.ComparisonFailure: expected:<204.[68]> but was:<204.[55]>
> at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native
> Method)
> at
> sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62)
> at
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at
> org.apache.geode.distributed.LauncherMemberMXBeanIntegrationTest.showOSMetrics_reconstructsOSMetricsFromCompositeDataType(LauncherMemberMXBeanIntegrationTest.java:143)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-6150) Allow use of client/server max-threads with SSL
[ https://issues.apache.org/jira/browse/GEODE-6150?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219934#comment-17219934 ] ASF GitHub Bot commented on GEODE-6150: --- lgtm-com[bot] commented on pull request #5270: URL: https://github.com/apache/geode/pull/5270#issuecomment-715586038 This pull request **introduces 10 alerts** and **fixes 2** when merging 0d64a52b557f693d2efeb32183e6250e884abdf5 into 0fdfc1ad1e272eed9bf5e2ee59816b75b262d9c6 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode/rev/pr-370dabfbf4f68f1f62b81c97f126c51f64625bd7) **new alerts:** * 4 for Potential output resource leak * 4 for Dereferenced variable may be null * 2 for Potential input resource leak **fixed alerts:** * 2 for Potential input resource leak This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Allow use of client/server max-threads with SSL > --- > > Key: GEODE-6150 > URL: https://issues.apache.org/jira/browse/GEODE-6150 > Project: Geode > Issue Type: New Feature > Components: client/server >Reporter: Bruce J Schuchardt >Assignee: Mario Ivanac >Priority: Major > Labels: SmallFeature, pull-request-available > > Cache servers have a max-threads setting that causes the server to limit the > number of threads used by clients. The implementation uses Java new I/O > though and that doesn't currently play well with SSL/TLS secure > communications. If you attempt to configure the server to use secure > communications _and_ max-threads it throws an IllegalArgumentException with > the message > Selector thread pooling can not be used with client/server SSL. The selector > can be disabled by setting max-threads=0. > The server code should be modified to use the JDK's SSLEngine to implement > SSL/TLS over NIO and get rid of this restriction. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8618) OQL grammar specification in docs is incomplete
[
https://issues.apache.org/jira/browse/GEODE-8618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219953#comment-17219953
]
John Blum commented on GEODE-8618:
--
The doc also does not specify the grammar for {{GROUP BY}}.
> OQL grammar specification in docs is incomplete
> ---
>
> Key: GEODE-8618
> URL: https://issues.apache.org/jira/browse/GEODE-8618
> Project: Geode
> Issue Type: Improvement
> Components: docs, querying
>Affects Versions: 1.11.0, 1.12.0, 1.13.0
>Reporter: John Blum
>Priority: Minor
>
> For example, there are no rules for the {{ORDER BY}} and {{LIMIT}} clauses.
> Referring to this section in the docs:
> https://geode.apache.org/docs/guide/113/developing/querying_basics/query_grammar_and_reserved_words.html
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (GEODE-8651) MsgReader's readHeader and readMessage should be synchronized
Xiaojian Zhou created GEODE-8651: Summary: MsgReader's readHeader and readMessage should be synchronized Key: GEODE-8651 URL: https://issues.apache.org/jira/browse/GEODE-8651 Project: Geode Issue Type: Bug Components: membership Reporter: Xiaojian Zhou When the connection reads direct ack, there're 2 steps: readHeader and readMessage. Another thread could jump in between to clear the buffer. The another thread is doing notifyHandShakeWaiter's second call, which could clear the buffer. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8651) MsgReader's readHeader and readMessage should be synchronized
[ https://issues.apache.org/jira/browse/GEODE-8651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-8651: -- Labels: pull-request-available (was: ) > MsgReader's readHeader and readMessage should be synchronized > - > > Key: GEODE-8651 > URL: https://issues.apache.org/jira/browse/GEODE-8651 > Project: Geode > Issue Type: Bug > Components: membership >Reporter: Xiaojian Zhou >Priority: Major > Labels: pull-request-available > > When the connection reads direct ack, there're 2 steps: readHeader and > readMessage. > Another thread could jump in between to clear the buffer. > The another thread is doing notifyHandShakeWaiter's second call, which could > clear the buffer. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8651) MsgReader's readHeader and readMessage should be synchronized
[ https://issues.apache.org/jira/browse/GEODE-8651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219956#comment-17219956 ] ASF GitHub Bot commented on GEODE-8651: --- gesterzhou opened a new pull request #5665: URL: https://github.com/apache/geode/pull/5665 …ized Co-authored-by: Anil Co-authored-by: Darrel Schneider Co-authored-by: Bill Burcham Co-authored-by: Ernie Burghardt Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, check Concourse for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to d...@geode.apache.org. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > MsgReader's readHeader and readMessage should be synchronized > - > > Key: GEODE-8651 > URL: https://issues.apache.org/jira/browse/GEODE-8651 > Project: Geode > Issue Type: Bug > Components: membership >Reporter: Xiaojian Zhou >Priority: Major > > When the connection reads direct ack, there're 2 steps: readHeader and > readMessage. > Another thread could jump in between to clear the buffer. > The another thread is doing notifyHandShakeWaiter's second call, which could > clear the buffer. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8651) MsgReader's readHeader and readMessage should be synchronized
[ https://issues.apache.org/jira/browse/GEODE-8651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219957#comment-17219957 ] ASF subversion and git services commented on GEODE-8651: Commit 46addf39f4e8576c24553098ae45e20c85801812 in geode's branch refs/heads/feature/GEODE-8651 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=46addf3 ] GEODE-8651: MsgReader's readHeader and readMessage should be synchronized Co-authored-by: Anil Co-authored-by: Darrel Schneider Co-authored-by: Bill Burcham Co-authored-by: Ernie Burghardt > MsgReader's readHeader and readMessage should be synchronized > - > > Key: GEODE-8651 > URL: https://issues.apache.org/jira/browse/GEODE-8651 > Project: Geode > Issue Type: Bug > Components: membership >Reporter: Xiaojian Zhou >Priority: Major > Labels: pull-request-available > > When the connection reads direct ack, there're 2 steps: readHeader and > readMessage. > Another thread could jump in between to clear the buffer. > The another thread is doing notifyHandShakeWaiter's second call, which could > clear the buffer. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8651) MsgReader's readHeader and readMessage should be synchronized
[ https://issues.apache.org/jira/browse/GEODE-8651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219959#comment-17219959 ] ASF subversion and git services commented on GEODE-8651: Commit 46addf39f4e8576c24553098ae45e20c85801812 in geode's branch refs/heads/feature/GEODE-8651 from zhouxh [ https://gitbox.apache.org/repos/asf?p=geode.git;h=46addf3 ] GEODE-8651: MsgReader's readHeader and readMessage should be synchronized Co-authored-by: Anil Co-authored-by: Darrel Schneider Co-authored-by: Bill Burcham Co-authored-by: Ernie Burghardt > MsgReader's readHeader and readMessage should be synchronized > - > > Key: GEODE-8651 > URL: https://issues.apache.org/jira/browse/GEODE-8651 > Project: Geode > Issue Type: Bug > Components: membership >Reporter: Xiaojian Zhou >Priority: Major > Labels: pull-request-available > > When the connection reads direct ack, there're 2 steps: readHeader and > readMessage. > Another thread could jump in between to clear the buffer. > The another thread is doing notifyHandShakeWaiter's second call, which could > clear the buffer. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8651) MsgReader's readHeader and readMessage should be synchronized
[ https://issues.apache.org/jira/browse/GEODE-8651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219965#comment-17219965 ] ASF GitHub Bot commented on GEODE-8651: --- kohlmu-pivotal commented on pull request #5665: URL: https://github.com/apache/geode/pull/5665#issuecomment-715627743 I would like to also point out that it does not make sense that any of the people that were added to review (except @bschuchardt ) to review this code. As the rest have all be names co-authors, which in reality does sort of defeat the point if they review what they authored This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > MsgReader's readHeader and readMessage should be synchronized > - > > Key: GEODE-8651 > URL: https://issues.apache.org/jira/browse/GEODE-8651 > Project: Geode > Issue Type: Bug > Components: membership >Reporter: Xiaojian Zhou >Priority: Major > Labels: pull-request-available > > When the connection reads direct ack, there're 2 steps: readHeader and > readMessage. > Another thread could jump in between to clear the buffer. > The another thread is doing notifyHandShakeWaiter's second call, which could > clear the buffer. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8651) MsgReader's readHeader and readMessage should be synchronized
[ https://issues.apache.org/jira/browse/GEODE-8651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219966#comment-17219966 ] ASF GitHub Bot commented on GEODE-8651: --- kohlmu-pivotal edited a comment on pull request #5665: URL: https://github.com/apache/geode/pull/5665#issuecomment-715627743 I would like to also point out that it does not make sense that any of the people that were added to review (except @bschuchardt ) to review this code. As the rest have all be named as co-authors, which in reality does sort of defeat the point if they review what they authored This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > MsgReader's readHeader and readMessage should be synchronized > - > > Key: GEODE-8651 > URL: https://issues.apache.org/jira/browse/GEODE-8651 > Project: Geode > Issue Type: Bug > Components: membership >Reporter: Xiaojian Zhou >Priority: Major > Labels: pull-request-available > > When the connection reads direct ack, there're 2 steps: readHeader and > readMessage. > Another thread could jump in between to clear the buffer. > The another thread is doing notifyHandShakeWaiter's second call, which could > clear the buffer. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8651) MsgReader's readHeader and readMessage should be synchronized
[ https://issues.apache.org/jira/browse/GEODE-8651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219967#comment-17219967 ] ASF GitHub Bot commented on GEODE-8651: --- gesterzhou commented on pull request #5665: URL: https://github.com/apache/geode/pull/5665#issuecomment-715628486 We have some tests to verify it. However, we are adding unit test, on the way. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > MsgReader's readHeader and readMessage should be synchronized > - > > Key: GEODE-8651 > URL: https://issues.apache.org/jira/browse/GEODE-8651 > Project: Geode > Issue Type: Bug > Components: membership >Reporter: Xiaojian Zhou >Priority: Major > Labels: pull-request-available > > When the connection reads direct ack, there're 2 steps: readHeader and > readMessage. > Another thread could jump in between to clear the buffer. > The another thread is doing notifyHandShakeWaiter's second call, which could > clear the buffer. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8645) Reduce netty threads used by PubSubIntegrationTest
[
https://issues.apache.org/jira/browse/GEODE-8645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219970#comment-17219970
]
ASF GitHub Bot commented on GEODE-8645:
---
kohlmu-pivotal commented on a change in pull request #5655:
URL: https://github.com/apache/geode/pull/5655#discussion_r511197468
##
File path:
geode-redis/src/integrationTest/java/org/apache/geode/redis/internal/executor/pubsub/PubSubIntegrationTest.java
##
@@ -16,13 +16,20 @@
package org.apache.geode.redis.internal.executor.pubsub;
import org.junit.ClassRule;
+import org.junit.contrib.java.lang.system.ProvideSystemProperty;
+import org.junit.rules.RuleChain;
import org.apache.geode.redis.GeodeRedisServerRule;
public class PubSubIntegrationTest extends AbstractPubSubIntegrationTest {
- @ClassRule
+
public static GeodeRedisServerRule server = new GeodeRedisServerRule();
+ @ClassRule
+ public static RuleChain chain = RuleChain.outerRule(
+ new ProvideSystemProperty("io.netty.eventLoopThreads", "10"))
+ .around(server);
+
Review comment:
@kirklund would you be happy with the instead of the
`RestoreSystemProperties` and the changing of the properties in a
`@BeforeClass` block?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Reduce netty threads used by PubSubIntegrationTest
> --
>
> Key: GEODE-8645
> URL: https://issues.apache.org/jira/browse/GEODE-8645
> Project: Geode
> Issue Type: Test
> Components: redis, tests
>Reporter: Jens Deppe
>Priority: Major
> Labels: pull-request-available
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8650) Support using multiple DistributedReference Rules in one test
[
https://issues.apache.org/jira/browse/GEODE-8650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219972#comment-17219972
]
ASF GitHub Bot commented on GEODE-8650:
---
kohlmu-pivotal commented on a change in pull request #5664:
URL: https://github.com/apache/geode/pull/5664#discussion_r511198069
##
File path:
geode-dunit/src/main/java/org/apache/geode/test/dunit/rules/DistributedReference.java
##
@@ -187,47 +197,76 @@ public V get() {
* @param newValue the new value
*/
public DistributedReference set(V newValue) {
-REFERENCE.set(newValue);
+REFERENCE.get().put(identity, newValue);
return this;
}
+ @Override
+ protected void before() {
+invoker().invokeInEveryVMAndController(() -> invokeBefore());
+ }
+
@Override
protected void after() {
-invoker().invokeInEveryVMAndController(this::invokeAfter);
+invoker().invokeInEveryVMAndController(() -> invokeAfter());
+ }
+
+ protected void afterCreateVM(VM vm) {
+vm.invoke(() -> invokeBefore());
+ }
+
+ protected void beforeBounceVM(VM vm) {
+// override if needed
+ }
+
+ protected void afterBounceVM(VM vm) {
+vm.invoke(() -> invokeBefore());
+ }
+
+ private void invokeBefore() {
+REFERENCE.compareAndSet(null, new HashMap<>());
+REFERENCE.get().putIfAbsent(identity, null);
}
private void invokeAfter() {
-V value = get();
-if (value == null) {
+Map references = REFERENCE.getAndSet(null);
+if (references == null) {
+ return;
+}
+
+for (Object object : references.values()) {
+ invokeAfter(object);
+}
+ }
+
+ private void invokeAfter(Object object) {
+if (object == null) {
return;
}
-REFERENCE.set(null);
if (autoClose.get()) {
- autoClose(value);
+ autoClose(object);
}
}
- private void autoClose(V value) {
-if (value instanceof AutoCloseable) {
- close((AutoCloseable) value);
+ private void autoClose(Object object) {
+if (object instanceof AutoCloseable) {
+ close((AutoCloseable) object);
-} else if (hasMethod(value.getClass(), "close")) {
- invokeMethod(value, "close");
+} else if (object instanceof AtomicBoolean) {
+ toFalse((AtomicBoolean) object);
-} else if (hasMethod(value.getClass(), "disconnect")) {
- invokeMethod(value, "disconnect");
+} else if (object instanceof CountDownLatch) {
+ openLatch((CountDownLatch) object);
-} else if (hasMethod(value.getClass(), "stop")) {
- invokeMethod(value, "stop");
-}
- }
+} else if (hasMethod(object.getClass(), "close")) {
+ invokeMethod(object, "close");
Review comment:
Could we not leverage method overloading here.
Instead of `toFalse((AtomicBoolean)object)` we use `close(object)` and then
have a `close(AtomicBoolean)` in the CompletionUtils?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Support using multiple DistributedReference Rules in one test
> -
>
> Key: GEODE-8650
> URL: https://issues.apache.org/jira/browse/GEODE-8650
> Project: Geode
> Issue Type: Wish
> Components: tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>Priority: Major
> Labels: pull-request-available
>
> Support using multiple DistributedReference Rules in one test. Right now the
> Rule only supports having one instance in a test.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (GEODE-8652) member hung in Connection.notifyHandshakeWaiter() during disconnect waiting for a lock held by another thread in Connection.readAck()
Bill Burcham created GEODE-8652:
---
Summary: member hung in Connection.notifyHandshakeWaiter() during
disconnect waiting for a lock held by another thread in Connection.readAck()
Key: GEODE-8652
URL: https://issues.apache.org/jira/browse/GEODE-8652
Project: Geode
Issue Type: Bug
Components: membership, messaging
Affects Versions: 1.14.0
Reporter: Bill Burcham
An application encountered the following hang in a TLS-enabled cluster.
Let's call the cluster members ds3 -> ds1.
ds3 sends a {{PutAllPRMessage}} to ds1 and is stuck in {{SocketChannel.read()}}
waiting for the acknowledgement.
{{ClusterDistributionManager.uncleanShutdown()}} is invoked on ds3 to shut the
member down. That thread blocks trying to acquire a lock on the
{{NioSslEngine}} held by the first thread (the one doing waiting for the ack to
the put-all.)
Somehow the shutdown thread must be allowed to proceed.
Here's the hung thread in ds3 (a.k.a. vm_3_thr_34_dataStore3_host1_8592) trying
to shut down the member but it's stuck waiting for the monitor on the
{{NioSslEngine}}:
{noformat}
"vm_3_thr_34_dataStore3_host1_8592" #795 daemon prio=5 os_prio=0
tid=0x7fdb9c011000 nid=0x2fcc waiting for monitor entry [0x7fdb6f4b7000]
java.lang.Thread.State: BLOCKED (on object monitor)
at
org.apache.geode.internal.tcp.Connection.notifyHandshakeWaiter(Connection.java:804)
- waiting to lock <0xf2635b28> (a
org.apache.geode.internal.net.NioSslEngine)
at org.apache.geode.internal.tcp.Connection.close(Connection.java:1350)
at
org.apache.geode.internal.tcp.Connection.closePartialConnect(Connection.java:1278)
at
org.apache.geode.internal.tcp.ConnectionTable.closeCon(ConnectionTable.java:612)
at
org.apache.geode.internal.tcp.ConnectionTable.closeCon(ConnectionTable.java:604)
at
org.apache.geode.internal.tcp.ConnectionTable.close(ConnectionTable.java:661)
- locked <0xf2678cf8> (a java.util.ArrayList)
- locked <0xf1187348> (a java.util.concurrent.ConcurrentHashMap)
at org.apache.geode.internal.tcp.TCPConduit.stop(TCPConduit.java:487)
at
org.apache.geode.distributed.internal.direct.DirectChannel.disconnect(DirectChannel.java:644)
- locked <0xf11867a8> (a
org.apache.geode.distributed.internal.direct.DirectChannel)
at
org.apache.geode.distributed.internal.DistributionImpl.disconnectDirectChannel(DistributionImpl.java:631)
at
org.apache.geode.distributed.internal.DistributionImpl.access$200(DistributionImpl.java:82)
at
org.apache.geode.distributed.internal.DistributionImpl$LifecycleListenerImpl.disconnect(DistributionImpl.java:904)
at
org.apache.geode.distributed.internal.membership.gms.GMSMembership$ManagerImpl.stop(GMSMembership.java:1908)
at
org.apache.geode.distributed.internal.membership.gms.Services.stop(Services.java:302)
at
org.apache.geode.distributed.internal.membership.gms.GMSMembership.shutdown(GMSMembership.java:1262)
at
org.apache.geode.distributed.internal.membership.gms.GMSMembership.disconnect(GMSMembership.java:1847)
at
org.apache.geode.distributed.internal.DistributionImpl.disconnect(DistributionImpl.java:501)
at
org.apache.geode.distributed.internal.ClusterDistributionManager.uncleanShutdown(ClusterDistributionManager.java:1291)
{noformat}
That thread is waiting on a lock held by this thread (in ds3) which is waiting
on an acknowledgement to a PutAllPRMessage sent to ds1.
{noformat}
"vm_3_thr_37_dataStore3_host1_8592" #857 daemon prio=5 os_prio=0
tid=0x7fdb9c030800 nid=0x30d1 runnable [0x7fdb732f]
java.lang.Thread.State: RUNNABLE
at sun.nio.ch.FileDispatcherImpl.read0(Native Method)
at sun.nio.ch.SocketDispatcher.read(SocketDispatcher.java:39)
at sun.nio.ch.IOUtil.readIntoNativeBuffer(IOUtil.java:223)
at sun.nio.ch.IOUtil.read(IOUtil.java:192)
at sun.nio.ch.SocketChannelImpl.read(SocketChannelImpl.java:378)
- locked <0xf2643380> (a java.lang.Object)
at
org.apache.geode.internal.net.NioSslEngine.readAtLeast(NioSslEngine.java:330)
at
org.apache.geode.internal.tcp.MsgReader.readAtLeast(MsgReader.java:129)
at org.apache.geode.internal.tcp.MsgReader.readHeader(MsgReader.java:58)
==> - locked <0xf2635b28> (a
org.apache.geode.internal.net.NioSslEngine)
at
org.apache.geode.internal.tcp.Connection.readAck(Connection.java:2652)
at
org.apache.geode.distributed.internal.direct.DirectChannel.readAcks(DirectChannel.java:392)
at
org.apache.geode.distributed.internal.direct.DirectChannel.sendToMany(DirectChannel.java:342)
at
org.apache.geode.distributed.internal.direct.DirectChannel.sendToOne(DirectChannel.java:182)
at
org.apache.geode.distribut
[jira] [Commented] (GEODE-8593) Update native client examples to use Builder pattern
[
https://issues.apache.org/jira/browse/GEODE-8593?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219983#comment-17219983
]
Dave Barnes commented on GEODE-8593:
Reopened 23-Oct-2020. First PR fixed the C++ docs.
.NET docs still need similar treatment.
> Update native client examples to use Builder pattern
>
>
> Key: GEODE-8593
> URL: https://issues.apache.org/jira/browse/GEODE-8593
> Project: Geode
> Issue Type: Improvement
> Components: docs, native client
>Affects Versions: 1.13.0
>Reporter: Dave Barnes
>Priority: Major
> Labels: pull-request-available
>
> For both C++ and .NET examples, the section of code that creates the
> connection pool should be improved to better illustrate the Builder pattern.
> For example, in the C++ examples, current code is:
> ```
> auto cacheFactory = CacheFactory();
> cacheFactory.set("log-level", "none");
> auto cache = cacheFactory.create();
> auto poolFactory = cache.getPoolManager().createFactory();
>
> poolFactory.addLocator("localhost", 10334);
> auto pool = poolFactory.create("pool");
> ```
> The improved version would be:
> ```
> auto cache = CacheFactory()
>.set("log-level", "debug")
>.set("ssl-enabled", "true")
>.set("ssl-truststore", clientTruststore.string())
>.create();
> cache.getPoolManager()
> .createFactory()
> .addLocator("localhost", 10334)
> .create("pool");
> ```
> Similarly for .NET examples.
> These doc snippets also appear in the user guides, so they'll need updating
> in the docs, as well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (GEODE-8593) Update native client examples to use Builder pattern
[
https://issues.apache.org/jira/browse/GEODE-8593?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dave Barnes reassigned GEODE-8593:
--
Assignee: Dave Barnes
> Update native client examples to use Builder pattern
>
>
> Key: GEODE-8593
> URL: https://issues.apache.org/jira/browse/GEODE-8593
> Project: Geode
> Issue Type: Improvement
> Components: docs, native client
>Affects Versions: 1.13.0
>Reporter: Dave Barnes
>Assignee: Dave Barnes
>Priority: Major
> Labels: pull-request-available
>
> For both C++ and .NET examples, the section of code that creates the
> connection pool should be improved to better illustrate the Builder pattern.
> For example, in the C++ examples, current code is:
> ```
> auto cacheFactory = CacheFactory();
> cacheFactory.set("log-level", "none");
> auto cache = cacheFactory.create();
> auto poolFactory = cache.getPoolManager().createFactory();
>
> poolFactory.addLocator("localhost", 10334);
> auto pool = poolFactory.create("pool");
> ```
> The improved version would be:
> ```
> auto cache = CacheFactory()
>.set("log-level", "debug")
>.set("ssl-enabled", "true")
>.set("ssl-truststore", clientTruststore.string())
>.create();
> cache.getPoolManager()
> .createFactory()
> .addLocator("localhost", 10334)
> .create("pool");
> ```
> Similarly for .NET examples.
> These doc snippets also appear in the user guides, so they'll need updating
> in the docs, as well.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8652) member hung in Connection.notifyHandshakeWaiter() during disconnect waiting for a lock held by another thread in Connection.readAck()
[
https://issues.apache.org/jira/browse/GEODE-8652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219984#comment-17219984
]
ASF GitHub Bot commented on GEODE-8652:
---
Bill opened a new pull request #5666:
URL: https://github.com/apache/geode/pull/5666
- NioSslEngine.close() to proceed even if readers (or writers) are
operating on its ByteBuffers, allowing Connection.close() to close its
socket and proceed.
Co-authored-by: Bill Burcham
Co-authored-by: Darrel Schneider
Co-authored-by: Ernie Burghardt
Thank you for submitting a contribution to Apache Geode.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in
the commit message?
- [ ] Has your PR been rebased against the latest commit within the target
branch (typically `develop`)?
- [ ] Is your initial contribution a single, squashed commit?
- [ ] Does `gradlew build` run cleanly?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
### Note:
Please ensure that once the PR is submitted, check Concourse for build
issues and
submit an update to your PR as soon as possible. If you need help, please
send an
email to d...@geode.apache.org.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> member hung in Connection.notifyHandshakeWaiter() during disconnect waiting
> for a lock held by another thread in Connection.readAck()
> --
>
> Key: GEODE-8652
> URL: https://issues.apache.org/jira/browse/GEODE-8652
> Project: Geode
> Issue Type: Bug
> Components: membership, messaging
>Affects Versions: 1.14.0
>Reporter: Bill Burcham
>Priority: Major
>
> An application encountered the following hang in a TLS-enabled cluster.
> Let's call the cluster members ds3 -> ds1.
> ds3 sends a {{PutAllPRMessage}} to ds1 and is stuck in
> {{SocketChannel.read()}} waiting for the acknowledgement.
> {{ClusterDistributionManager.uncleanShutdown()}} is invoked on ds3 to shut
> the member down. That thread blocks trying to acquire a lock on the
> {{NioSslEngine}} held by the first thread (the one doing waiting for the ack
> to the put-all.)
> Somehow the shutdown thread must be allowed to proceed.
> Here's the hung thread in ds3 (a.k.a. vm_3_thr_34_dataStore3_host1_8592)
> trying to shut down the member but it's stuck waiting for the monitor on the
> {{NioSslEngine}}:
> {noformat}
> "vm_3_thr_34_dataStore3_host1_8592" #795 daemon prio=5 os_prio=0
> tid=0x7fdb9c011000 nid=0x2fcc waiting for monitor entry
> [0x7fdb6f4b7000]
>java.lang.Thread.State: BLOCKED (on object monitor)
> at
> org.apache.geode.internal.tcp.Connection.notifyHandshakeWaiter(Connection.java:804)
> - waiting to lock <0xf2635b28> (a
> org.apache.geode.internal.net.NioSslEngine)
> at org.apache.geode.internal.tcp.Connection.close(Connection.java:1350)
> at
> org.apache.geode.internal.tcp.Connection.closePartialConnect(Connection.java:1278)
> at
> org.apache.geode.internal.tcp.ConnectionTable.closeCon(ConnectionTable.java:612)
> at
> org.apache.geode.internal.tcp.ConnectionTable.closeCon(ConnectionTable.java:604)
> at
> org.apache.geode.internal.tcp.ConnectionTable.close(ConnectionTable.java:661)
> - locked <0xf2678cf8> (a java.util.ArrayList)
> - locked <0xf1187348> (a java.util.concurrent.ConcurrentHashMap)
> at org.apache.geode.internal.tcp.TCPConduit.stop(TCPConduit.java:487)
> at
> org.apache.geode.distributed.internal.direct.DirectChannel.disconnect(DirectChannel.java:644)
> - locked <0xf11867a8> (a
> org.apache.geode.distributed.internal.direct.DirectChannel)
> at
> org.apache.geode.distributed.internal.DistributionImpl.disconnectDirectChannel(DistributionImpl.java:631)
> at
> org.apache.geode.distributed.internal.DistributionImpl.access$200(DistributionImpl.java:82)
> at
> org.apache.geode.distributed.internal.DistributionImpl$LifecycleListenerImpl.disconnect(DistributionImpl.java:904)
> at
> org.apache.geode.distribu
[jira] [Updated] (GEODE-8652) member hung in Connection.notifyHandshakeWaiter() during disconnect waiting for a lock held by another thread in Connection.readAck()
[
https://issues.apache.org/jira/browse/GEODE-8652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated GEODE-8652:
--
Labels: pull-request-available (was: )
> member hung in Connection.notifyHandshakeWaiter() during disconnect waiting
> for a lock held by another thread in Connection.readAck()
> --
>
> Key: GEODE-8652
> URL: https://issues.apache.org/jira/browse/GEODE-8652
> Project: Geode
> Issue Type: Bug
> Components: membership, messaging
>Affects Versions: 1.14.0
>Reporter: Bill Burcham
>Priority: Major
> Labels: pull-request-available
>
> An application encountered the following hang in a TLS-enabled cluster.
> Let's call the cluster members ds3 -> ds1.
> ds3 sends a {{PutAllPRMessage}} to ds1 and is stuck in
> {{SocketChannel.read()}} waiting for the acknowledgement.
> {{ClusterDistributionManager.uncleanShutdown()}} is invoked on ds3 to shut
> the member down. That thread blocks trying to acquire a lock on the
> {{NioSslEngine}} held by the first thread (the one doing waiting for the ack
> to the put-all.)
> Somehow the shutdown thread must be allowed to proceed.
> Here's the hung thread in ds3 (a.k.a. vm_3_thr_34_dataStore3_host1_8592)
> trying to shut down the member but it's stuck waiting for the monitor on the
> {{NioSslEngine}}:
> {noformat}
> "vm_3_thr_34_dataStore3_host1_8592" #795 daemon prio=5 os_prio=0
> tid=0x7fdb9c011000 nid=0x2fcc waiting for monitor entry
> [0x7fdb6f4b7000]
>java.lang.Thread.State: BLOCKED (on object monitor)
> at
> org.apache.geode.internal.tcp.Connection.notifyHandshakeWaiter(Connection.java:804)
> - waiting to lock <0xf2635b28> (a
> org.apache.geode.internal.net.NioSslEngine)
> at org.apache.geode.internal.tcp.Connection.close(Connection.java:1350)
> at
> org.apache.geode.internal.tcp.Connection.closePartialConnect(Connection.java:1278)
> at
> org.apache.geode.internal.tcp.ConnectionTable.closeCon(ConnectionTable.java:612)
> at
> org.apache.geode.internal.tcp.ConnectionTable.closeCon(ConnectionTable.java:604)
> at
> org.apache.geode.internal.tcp.ConnectionTable.close(ConnectionTable.java:661)
> - locked <0xf2678cf8> (a java.util.ArrayList)
> - locked <0xf1187348> (a java.util.concurrent.ConcurrentHashMap)
> at org.apache.geode.internal.tcp.TCPConduit.stop(TCPConduit.java:487)
> at
> org.apache.geode.distributed.internal.direct.DirectChannel.disconnect(DirectChannel.java:644)
> - locked <0xf11867a8> (a
> org.apache.geode.distributed.internal.direct.DirectChannel)
> at
> org.apache.geode.distributed.internal.DistributionImpl.disconnectDirectChannel(DistributionImpl.java:631)
> at
> org.apache.geode.distributed.internal.DistributionImpl.access$200(DistributionImpl.java:82)
> at
> org.apache.geode.distributed.internal.DistributionImpl$LifecycleListenerImpl.disconnect(DistributionImpl.java:904)
> at
> org.apache.geode.distributed.internal.membership.gms.GMSMembership$ManagerImpl.stop(GMSMembership.java:1908)
> at
> org.apache.geode.distributed.internal.membership.gms.Services.stop(Services.java:302)
> at
> org.apache.geode.distributed.internal.membership.gms.GMSMembership.shutdown(GMSMembership.java:1262)
> at
> org.apache.geode.distributed.internal.membership.gms.GMSMembership.disconnect(GMSMembership.java:1847)
> at
> org.apache.geode.distributed.internal.DistributionImpl.disconnect(DistributionImpl.java:501)
> at
> org.apache.geode.distributed.internal.ClusterDistributionManager.uncleanShutdown(ClusterDistributionManager.java:1291)
> {noformat}
> That thread is waiting on a lock held by this thread (in ds3) which is
> waiting on an acknowledgement to a PutAllPRMessage sent to ds1.
> {noformat}
> "vm_3_thr_37_dataStore3_host1_8592" #857 daemon prio=5 os_prio=0
> tid=0x7fdb9c030800 nid=0x30d1 runnable [0x7fdb732f]
>java.lang.Thread.State: RUNNABLE
> at sun.nio.ch.FileDispatcherImpl.read0(Native Method)
> at sun.nio.ch.SocketDispatcher.read(SocketDispatcher.java:39)
> at sun.nio.ch.IOUtil.readIntoNativeBuffer(IOUtil.java:223)
> at sun.nio.ch.IOUtil.read(IOUtil.java:192)
> at sun.nio.ch.SocketChannelImpl.read(SocketChannelImpl.java:378)
> - locked <0xf2643380> (a java.lang.Object)
> at
> org.apache.geode.internal.net.NioSslEngine.readAtLeast(NioSslEngine.java:330)
> at
> org.apache.geode.internal.tcp.MsgReader.readAtLeast(MsgReader.java:129)
> at
> org.apache.geode.internal.tcp.MsgReader.readHeader(MsgReader.java:58)
> ==> - locked <0xf2635b28> (a
>
[jira] [Commented] (GEODE-8647) Support using multiple DistributedMap Rules in one test
[ https://issues.apache.org/jira/browse/GEODE-8647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219988#comment-17219988 ] ASF GitHub Bot commented on GEODE-8647: --- kirklund opened a new pull request #5667: URL: https://github.com/apache/geode/pull/5667 Includes additional improvements for usage of DistributedMap. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Support using multiple DistributedMap Rules in one test > --- > > Key: GEODE-8647 > URL: https://issues.apache.org/jira/browse/GEODE-8647 > Project: Geode > Issue Type: Wish > Components: tests >Reporter: Kirk Lund >Assignee: Kirk Lund >Priority: Major > > Support using multiple DistributedMap Rules in one test. Right now the Rule > only supports having one instance in a test. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8647) Support using multiple DistributedMap Rules in one test
[ https://issues.apache.org/jira/browse/GEODE-8647?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-8647: -- Labels: pull-request-available (was: ) > Support using multiple DistributedMap Rules in one test > --- > > Key: GEODE-8647 > URL: https://issues.apache.org/jira/browse/GEODE-8647 > Project: Geode > Issue Type: Wish > Components: tests >Reporter: Kirk Lund >Assignee: Kirk Lund >Priority: Major > Labels: pull-request-available > > Support using multiple DistributedMap Rules in one test. Right now the Rule > only supports having one instance in a test. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8650) Support using multiple DistributedReference Rules in one test
[
https://issues.apache.org/jira/browse/GEODE-8650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219989#comment-17219989
]
ASF GitHub Bot commented on GEODE-8650:
---
kirklund commented on a change in pull request #5664:
URL: https://github.com/apache/geode/pull/5664#discussion_r511235182
##
File path:
geode-dunit/src/main/java/org/apache/geode/test/dunit/rules/DistributedReference.java
##
@@ -187,47 +197,76 @@ public V get() {
* @param newValue the new value
*/
public DistributedReference set(V newValue) {
-REFERENCE.set(newValue);
+REFERENCE.get().put(identity, newValue);
return this;
}
+ @Override
+ protected void before() {
+invoker().invokeInEveryVMAndController(() -> invokeBefore());
+ }
+
@Override
protected void after() {
-invoker().invokeInEveryVMAndController(this::invokeAfter);
+invoker().invokeInEveryVMAndController(() -> invokeAfter());
+ }
+
+ protected void afterCreateVM(VM vm) {
+vm.invoke(() -> invokeBefore());
+ }
+
+ protected void beforeBounceVM(VM vm) {
+// override if needed
+ }
+
+ protected void afterBounceVM(VM vm) {
+vm.invoke(() -> invokeBefore());
+ }
+
+ private void invokeBefore() {
+REFERENCE.compareAndSet(null, new HashMap<>());
+REFERENCE.get().putIfAbsent(identity, null);
}
private void invokeAfter() {
-V value = get();
-if (value == null) {
+Map references = REFERENCE.getAndSet(null);
+if (references == null) {
+ return;
+}
+
+for (Object object : references.values()) {
+ invokeAfter(object);
+}
+ }
+
+ private void invokeAfter(Object object) {
+if (object == null) {
return;
}
-REFERENCE.set(null);
if (autoClose.get()) {
- autoClose(value);
+ autoClose(object);
}
}
- private void autoClose(V value) {
-if (value instanceof AutoCloseable) {
- close((AutoCloseable) value);
+ private void autoClose(Object object) {
+if (object instanceof AutoCloseable) {
+ close((AutoCloseable) object);
-} else if (hasMethod(value.getClass(), "close")) {
- invokeMethod(value, "close");
+} else if (object instanceof AtomicBoolean) {
+ toFalse((AtomicBoolean) object);
-} else if (hasMethod(value.getClass(), "disconnect")) {
- invokeMethod(value, "disconnect");
+} else if (object instanceof CountDownLatch) {
+ openLatch((CountDownLatch) object);
-} else if (hasMethod(value.getClass(), "stop")) {
- invokeMethod(value, "stop");
-}
- }
+} else if (hasMethod(object.getClass(), "close")) {
+ invokeMethod(object, "close");
Review comment:
Do we really want a method called `close(AtomicBoolean)` that sets the
specified value to false? I started out with multiple `close` methods and then
I changed them from that to:
* toFalse(AtomicBoolean)
* openLatch(CountDownLatch)
And then what about opening `CountDownLatch`? Do we change that to `close`
as well even tho close is the opposite of open?
I was thinking that my creation of `CompletionUtils` might be slightly more
controversial because it's of dubious value outside `DistributedReference`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Support using multiple DistributedReference Rules in one test
> -
>
> Key: GEODE-8650
> URL: https://issues.apache.org/jira/browse/GEODE-8650
> Project: Geode
> Issue Type: Wish
> Components: tests
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>Priority: Major
> Labels: pull-request-available
>
> Support using multiple DistributedReference Rules in one test. Right now the
> Rule only supports having one instance in a test.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
