[
https://issues.apache.org/jira/browse/GEODE-8651?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17219965#comment-17219965
]
ASF GitHub Bot commented on GEODE-8651:
---------------------------------------
kohlmu-pivotal commented on pull request #5665:
URL: https://github.com/apache/geode/pull/5665#issuecomment-715627743
I would like to also point out that it does not make sense that any of the
people that were added to review (except @bschuchardt ) to review this code. As
the rest have all be names co-authors, which in reality does sort of defeat the
point if they review what they authored
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> MsgReader's readHeader and readMessage should be synchronized
> -------------------------------------------------------------
>
> Key: GEODE-8651
> URL: https://issues.apache.org/jira/browse/GEODE-8651
> Project: Geode
> Issue Type: Bug
> Components: membership
> Reporter: Xiaojian Zhou
> Priority: Major
> Labels: pull-request-available
>
> When the connection reads direct ack, there're 2 steps: readHeader and
> readMessage.
> Another thread could jump in between to clear the buffer.
> The another thread is doing notifyHandShakeWaiter's second call, which could
> clear the buffer.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
