[jira] [Created] (GEODE-8599) Remove class name from PdxFieldType
Mario Salazar de Torres created GEODE-8599: -- Summary: Remove class name from PdxFieldType Key: GEODE-8599 URL: https://issues.apache.org/jira/browse/GEODE-8599 Project: Geode Issue Type: Improvement Components: native client Affects Versions: 1.13.0, 1.12.0, 1.11.0 Reporter: Mario Salazar de Torres *AS A* native client contributor *I WANT* to remove class name from PdxFieldType *SO THAT* overhead is removed and comparisons are made using typeId instead. --- *Additional information* Having class name into PdxFieldType is the consequence of lacking a good implementation for enums in C++ as opposed to Java. Thing is that class name as part of the PdxFieldType adds nothing but overhead as is not serialized. Instead typeId can be used. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (GEODE-8600) Faulty statistics for parallel GW senders
[ https://issues.apache.org/jira/browse/GEODE-8600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mario Ivanac reassigned GEODE-8600: --- Assignee: Mario Ivanac > Faulty statistics for parallel GW senders > - > > Key: GEODE-8600 > URL: https://issues.apache.org/jira/browse/GEODE-8600 > Project: Geode > Issue Type: Bug > Components: statistics, wan >Reporter: Mario Ivanac >Assignee: Mario Ivanac >Priority: Major > > When using getEventQueueSize method of GatewaySenderStats class, we receive > negative value. This occurres for parallel GW sender, when GW sender is > stoped with events in queue. After GW sender is re-started GW, and events > are unqueued, getEventQueueSize shows negative value. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (GEODE-8600) Faulty statistics for parallel GW senders
Mario Ivanac created GEODE-8600: --- Summary: Faulty statistics for parallel GW senders Key: GEODE-8600 URL: https://issues.apache.org/jira/browse/GEODE-8600 Project: Geode Issue Type: Bug Components: statistics, wan Reporter: Mario Ivanac When using getEventQueueSize method of GatewaySenderStats class, we receive negative value. This occurres for parallel GW sender, when GW sender is stoped with events in queue. After GW sender is re-started GW, and events are unqueued, getEventQueueSize shows negative value. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8512) Be able to specify 'expectDomainClass' when calling createPdxInstanceFactory
[ https://issues.apache.org/jira/browse/GEODE-8512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17211980#comment-17211980 ] ASF GitHub Bot commented on GEODE-8512: --- gaussianrecurrence commented on pull request #661: URL: https://github.com/apache/geode-native/pull/661#issuecomment-706737873 - Requested changes have been made. - Branch has been rebased. - clang-format passed. - Compilation runs OK both in Linux and Windows. - All tests passed both in Linux and Windows (thanks to @moleske for contributing GitHub actions) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Be able to specify 'expectDomainClass' when calling createPdxInstanceFactory > > > Key: GEODE-8512 > URL: https://issues.apache.org/jira/browse/GEODE-8512 > Project: Geode > Issue Type: Improvement > Components: native client >Affects Versions: 1.13.0 >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Minor > Labels: JsonFormatter, pull-request-available > > Within Java client, you can specify if the PdxInstance you want to create is > a Java domain class or not, but this is not the case for geode-native C++ > client. > Thing is that in order to implement JsonFormatter in C++ client, having this > change is mandatory, otherwise creating PdxType's with __GEMFIRE_JSON > classname will present some issues while using cquery's. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8531) Coredump when removing an entry
[
https://issues.apache.org/jira/browse/GEODE-8531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17211981#comment-17211981
]
ASF GitHub Bot commented on GEODE-8531:
---
gaussianrecurrence edited a comment on pull request #667:
URL: https://github.com/apache/geode-native/pull/667#issuecomment-703578739
**Revision 2** uploaded:
- [x] clang-format executed.
**Linux tests** list:
- [x] Unit tests passed.
- [x] Old integration tests passed.
- [x] New integration tests passed.
- [x] Acceptance tests passed.
**Windows tests** list:
- [x] Unit tests passed.
- [x] Old integration tests passed.
- [x] New integration tests passed.
- [?] Acceptance tests passed.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Coredump when removing an entry
> ---
>
> Key: GEODE-8531
> URL: https://issues.apache.org/jira/browse/GEODE-8531
> Project: Geode
> Issue Type: Bug
> Components: native client
>Reporter: Mario Salazar de Torres
>Assignee: Mario Salazar de Torres
>Priority: Major
> Labels: pull-request-available
> Attachments: notifications-no-massif.log
>
>
> The scenario is the following:
> *HAVING* a configured concurrency-checks-enabled=false in the
> client-cache.xml for a region
> *HAVING* a configured subscription-notification for the pool on which the
> region is defined
> *HAVING* regsitered interest on all the keys of this region, values included
> *WHEN* a LOCAL_DESTROY notification arrives and therefore
> {color:#4c9aff}MapSegment::remove{color}{color:#172b4d} is called{color}
> {color:#172b4d}*THEN* the application crashes, claiming that the variable
> entry is a nullptr.{color}
>
> This is the segmentation report:
> {code:java}
> [debug 2020/09/24 17:21:07.263036 CEST DESKTOP-3SQUK3P:586546
> 140013383710464] Region::destroy: region [/region] destroying key
> [entry-152150]
> Segmentation fault
> *** Segmentation fault
> Register dump: RAX: RBX: RCX:
>
> RDX: RSI: 7f57580008e0 RDI: 7f5767ffe670
> RBP: 7f5767ffe6c0 R8 : 7f5758000d70 R9 : 563da49f0ac0
> R10: 000c R11: 7f57815a2058 R12: 563da6971a48
> R13: 563da696dbd0 R14: R15: 7ffd06db85a0
> RSP: 7f5767ffe610 RIP: 7f578159ac47 EFLAGS: 00010202 CS: 0033
> FS: GS: Trap: 000e Error: 0004 OldMask:
> CR2: FPUCW: 037f FPUSW: TAG: 7f57
> RIP: 80b37f70 RDP: ST(0) ST(1)
>
> ST(2) ST(3)
> ST(4) ST(5) c000
> ST(6) c000 ST(7) e000 e000
> mxcsr: 1f80
> XMM0: 25252525 XMM1:
> 25252525
> XMM2: 25252525 XMM3:
> 25252525
> XMM4: 25252525 XMM5:
> 25252525
> XMM6: 25252525 XMM7:
> 25252525
> XMM8: 25252525 XMM9:
> 25252525
> XMM10: 25252525 XMM11:
> 25252525
> XMM12: 25252525 XMM13:
> 25252525
> XMM14: 25252525 XMM15:
> 25252525Backtrace:
> /usr/local/lib/libapache-geode.so(_ZN6apache5geode6client10MapSegment6removeERKSt10shared_ptrINS1_12CacheableKeyEERS3_INS1_12SerializableEERS3_INS1_12MapEntryImplEEiS3_INS1_10VersionTagEEbRb+0x287)[0x7f578159ac47]
> /usr/local/lib/libapache-geode.so(_ZN6apache5geode6client20ConcurrentEntriesMap6removeERKSt10shared_ptrINS1_12CacheableKeyEERS3_INS1_12SerializableEERS3_INS1_12MapEntryImplEEiS3_INS1_10VersionTagEEb+0xa0)[0x7f57814e1782]
> /usr/local/lib/libapache-geode.so(+0x77173d)[0x7f578157673d]
> /usr/local/lib/libapache-geode.so(_ZN6apache5geode6client11LocalRegion13updateNoThrowINS1_14DestroyActionsEEE9GfErrTypeRKSt10shared_ptrINS1_12CacheableKeyEERKS6_INS1_12SerializableEESE_RSC_iNS1_15CacheEventFlagsES6_INS1_10VersionTagEEPNS1_9DataInputES6_INS1_7EventIdEE+0x515)[0x7f578157af2b]
> /usr/local/lib/libapache-geode.so(_ZN6apache5geode6client11LocalRegion14destroyNoThrowERKSt10shared_ptrINS1_12CacheableKeyEERKS3_INS1_12SerializableEEiNS1_15CacheEventFlagsES3_INS1_1
[jira] [Commented] (GEODE-8553) Reduce ThinClientLocatorHelper lock time
[ https://issues.apache.org/jira/browse/GEODE-8553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17211982#comment-17211982 ] ASF GitHub Bot commented on GEODE-8553: --- gaussianrecurrence commented on pull request #660: URL: https://github.com/apache/geode-native/pull/660#issuecomment-706738731 - Branch rebased. - Clang-format passed - Compilation ran OK both in Linux and Windows. - All tests passed both in Linux and Windows. Please let me know your feeling about the pending topic (the tests). If you think I might need to come up with an intermediate test, or maybe I should make a prior PR to setup all the necessary scaffolding in order to make connection tests in the future. Thanks 🙂 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Reduce ThinClientLocatorHelper lock time > > > Key: GEODE-8553 > URL: https://issues.apache.org/jira/browse/GEODE-8553 > Project: Geode > Issue Type: Improvement > Components: native client >Affects Versions: 1.12.0, 1.13.0 >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: pull-request-available > > During my troublshootings, I've seen that locking m_locatorLock for the whole > scope of the class function members might cause some inter-locks. > Problem here and in many other places of the NC is that networking operations > are performed while a mutex is locked. Therefore if *thread A* takes longer > than expected in performing its network operation, it might block another one > which does not requires any resource of the first *thread A*. Hence, the > inter-lock. > This improvement is the first one of a series regarding to lock scope > reduction when it comes with code regarding networking in NC. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8600) Faulty statistics for parallel GW senders
[ https://issues.apache.org/jira/browse/GEODE-8600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17212008#comment-17212008 ] ASF GitHub Bot commented on GEODE-8600: --- mivanac opened a new pull request #5616: URL: https://github.com/apache/geode/pull/5616 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [*] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [*] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [*] Is your initial contribution a single, squashed commit? - [*] Does `gradlew build` run cleanly? - [*] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, check Concourse for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to d...@geode.apache.org. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Faulty statistics for parallel GW senders > - > > Key: GEODE-8600 > URL: https://issues.apache.org/jira/browse/GEODE-8600 > Project: Geode > Issue Type: Bug > Components: statistics, wan >Reporter: Mario Ivanac >Assignee: Mario Ivanac >Priority: Major > > When using getEventQueueSize method of GatewaySenderStats class, we receive > negative value. This occurres for parallel GW sender, when GW sender is > stoped with events in queue. After GW sender is re-started GW, and events > are unqueued, getEventQueueSize shows negative value. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8600) Faulty statistics for parallel GW senders
[ https://issues.apache.org/jira/browse/GEODE-8600?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-8600: -- Labels: pull-request-available (was: ) > Faulty statistics for parallel GW senders > - > > Key: GEODE-8600 > URL: https://issues.apache.org/jira/browse/GEODE-8600 > Project: Geode > Issue Type: Bug > Components: statistics, wan >Reporter: Mario Ivanac >Assignee: Mario Ivanac >Priority: Major > Labels: pull-request-available > > When using getEventQueueSize method of GatewaySenderStats class, we receive > negative value. This occurres for parallel GW sender, when GW sender is > stoped with events in queue. After GW sender is re-started GW, and events > are unqueued, getEventQueueSize shows negative value. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8512) Be able to specify 'expectDomainClass' when calling createPdxInstanceFactory
[ https://issues.apache.org/jira/browse/GEODE-8512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17212009#comment-17212009 ] ASF GitHub Bot commented on GEODE-8512: --- codecov-io commented on pull request #661: URL: https://github.com/apache/geode-native/pull/661#issuecomment-706752784 # [Codecov](https://codecov.io/gh/apache/geode-native/pull/661?src=pr&el=h1) Report > Merging [#661](https://codecov.io/gh/apache/geode-native/pull/661?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/geode-native/commit/5f06ae2044004397492249fcf13bcd90e75b955b?el=desc) will **decrease** coverage by `0.05%`. > The diff coverage is `91.87%`. [](https://codecov.io/gh/apache/geode-native/pull/661?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## develop #661 +/- ## === - Coverage74.03% 73.97% -0.06% === Files 644 644 Lines5113351188 +55 === + Hits 3785437867 +13 - Misses 1327913321 +42 ``` | [Impacted Files](https://codecov.io/gh/apache/geode-native/pull/661?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [cppcache/include/geode/Cache.hpp](https://codecov.io/gh/apache/geode-native/pull/661/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvaW5jbHVkZS9nZW9kZS9DYWNoZS5ocHA=) | `100.00% <ø> (ø)` | | | [cppcache/include/geode/PdxInstanceFactory.hpp](https://codecov.io/gh/apache/geode-native/pull/661/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvaW5jbHVkZS9nZW9kZS9QZHhJbnN0YW5jZUZhY3RvcnkuaHBw) | `100.00% <ø> (ø)` | | | [cppcache/include/geode/RegionService.hpp](https://codecov.io/gh/apache/geode-native/pull/661/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvaW5jbHVkZS9nZW9kZS9SZWdpb25TZXJ2aWNlLmhwcA==) | `100.00% <ø> (ø)` | | | [cppcache/src/AuthenticatedView.cpp](https://codecov.io/gh/apache/geode-native/pull/661/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL0F1dGhlbnRpY2F0ZWRWaWV3LmNwcA==) | `26.86% <0.00%> (-0.83%)` | :arrow_down: | | [cppcache/src/CacheImpl.hpp](https://codecov.io/gh/apache/geode-native/pull/661/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL0NhY2hlSW1wbC5ocHA=) | `100.00% <ø> (ø)` | | | [cppcache/src/DataOutput.cpp](https://codecov.io/gh/apache/geode-native/pull/661/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL0RhdGFPdXRwdXQuY3Bw) | `76.62% <ø> (ø)` | | | [cppcache/src/PdxInstanceFactory.cpp](https://codecov.io/gh/apache/geode-native/pull/661/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1BkeEluc3RhbmNlRmFjdG9yeS5jcHA=) | `95.36% <ø> (ø)` | | | [cppcache/src/PdxType.hpp](https://codecov.io/gh/apache/geode-native/pull/661/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1BkeFR5cGUuaHBw) | `62.22% <ø> (ø)` | | | [tests/cpp/security/XmlAuthzCredentialGenerator.hpp](https://codecov.io/gh/apache/geode-native/pull/661/diff?src=pr&el=tree#diff-dGVzdHMvY3BwL3NlY3VyaXR5L1htbEF1dGh6Q3JlZGVudGlhbEdlbmVyYXRvci5ocHA=) | `0.71% <0.00%> (ø)` | | | [cppcache/test/PdxTypeTest.cpp](https://codecov.io/gh/apache/geode-native/pull/661/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvdGVzdC9QZHhUeXBlVGVzdC5jcHA=) | `98.69% <97.14%> (-1.31%)` | :arrow_down: | | ... and [19 more](https://codecov.io/gh/apache/geode-native/pull/661/diff?src=pr&el=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/geode-native/pull/661?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/geode-native/pull/661?src=pr&el=footer). Last update [5f06ae2...bcfa4e5](https://codecov.io/gh/apache/geode-native/pull/661?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Be able to specify 'expectDomainClass' when calling createPdxInstanceFactory > > > Key: GEODE-8512 > URL: https://issues.apache.org/jira/browse/GEODE-8512 > Project: Geode > Issue Type: Improvement > Components: native client >Affects Versions: 1.13.0 >Reporter: Mario
[jira] [Commented] (GEODE-8553) Reduce ThinClientLocatorHelper lock time
[ https://issues.apache.org/jira/browse/GEODE-8553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17212011#comment-17212011 ] ASF GitHub Bot commented on GEODE-8553: --- codecov-io commented on pull request #660: URL: https://github.com/apache/geode-native/pull/660#issuecomment-706753854 # [Codecov](https://codecov.io/gh/apache/geode-native/pull/660?src=pr&el=h1) Report > Merging [#660](https://codecov.io/gh/apache/geode-native/pull/660?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/geode-native/commit/5f06ae2044004397492249fcf13bcd90e75b955b?el=desc) will **decrease** coverage by `0.07%`. > The diff coverage is `93.12%`. [](https://codecov.io/gh/apache/geode-native/pull/660?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## develop #660 +/- ## === - Coverage74.03% 73.95% -0.08% === Files 644 644 Lines5113351030 -103 === - Hits 3785437740 -114 - Misses 1327913290 +11 ``` | [Impacted Files](https://codecov.io/gh/apache/geode-native/pull/660?src=pr&el=tree) | Coverage Δ | | |---|---|---| | [cppcache/src/ThinClientLocatorHelper.cpp](https://codecov.io/gh/apache/geode-native/pull/660/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRMb2NhdG9ySGVscGVyLmNwcA==) | `91.15% <92.85%> (+5.04%)` | :arrow_up: | | [cppcache/src/ThinClientLocatorHelper.hpp](https://codecov.io/gh/apache/geode-native/pull/660/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRMb2NhdG9ySGVscGVyLmhwcA==) | `100.00% <100.00%> (ø)` | | | [cppcache/src/ThinClientPoolDM.cpp](https://codecov.io/gh/apache/geode-native/pull/660/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRQb29sRE0uY3Bw) | `75.46% <100.00%> (-0.63%)` | :arrow_down: | | [...tion-test/testThinClientRemoteQueryFailoverPdx.cpp](https://codecov.io/gh/apache/geode-native/pull/660/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvaW50ZWdyYXRpb24tdGVzdC90ZXN0VGhpbkNsaWVudFJlbW90ZVF1ZXJ5RmFpbG92ZXJQZHguY3Bw) | `85.48% <0.00%> (-4.04%)` | :arrow_down: | | [cppcache/src/TXCommitMessage.cpp](https://codecov.io/gh/apache/geode-native/pull/660/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RYQ29tbWl0TWVzc2FnZS5jcHA=) | `74.50% <0.00%> (-1.97%)` | :arrow_down: | | [cppcache/src/TcrEndpoint.cpp](https://codecov.io/gh/apache/geode-native/pull/660/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RjckVuZHBvaW50LmNwcA==) | `54.55% <0.00%> (-1.83%)` | :arrow_down: | | [cppcache/src/RemoteQuery.cpp](https://codecov.io/gh/apache/geode-native/pull/660/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1JlbW90ZVF1ZXJ5LmNwcA==) | `75.53% <0.00%> (-1.07%)` | :arrow_down: | | [cppcache/src/ThinClientRedundancyManager.cpp](https://codecov.io/gh/apache/geode-native/pull/660/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRSZWR1bmRhbmN5TWFuYWdlci5jcHA=) | `75.31% <0.00%> (-0.47%)` | :arrow_down: | | [cppcache/src/TcrConnection.cpp](https://codecov.io/gh/apache/geode-native/pull/660/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RjckNvbm5lY3Rpb24uY3Bw) | `72.79% <0.00%> (-0.16%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/geode-native/pull/660?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/geode-native/pull/660?src=pr&el=footer). Last update [5f06ae2...1f3142d](https://codecov.io/gh/apache/geode-native/pull/660?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Reduce ThinClientLocatorHelper lock time > > > Key: GEODE-8553 > URL: https://issues.apache.org/jira/browse/GEODE-8553 > Project: Geode > Issue Type: Improvement > Components: native client >Affects Versions: 1.12.0, 1.13.0 >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Major > Labels: pull-request-available > > During my troublsho
[jira] [Commented] (GEODE-8512) Be able to specify 'expectDomainClass' when calling createPdxInstanceFactory
[ https://issues.apache.org/jira/browse/GEODE-8512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17212121#comment-17212121 ] ASF GitHub Bot commented on GEODE-8512: --- moleske commented on a change in pull request #661: URL: https://github.com/apache/geode-native/pull/661#discussion_r503035325 ## File path: CMakeLists.txt ## @@ -254,6 +254,7 @@ elseif(CMAKE_CXX_COMPILER_ID MATCHES "Clang") -Wno-undefined-func-template #TODO fix -Wno-float-equal #TODO fix -Wno-conversion #TODO fix +-Wno-missing-variable-declarations #TODO fix Review comment: Is there a reason this was added back in? It was recently fixed in https://github.com/apache/geode-native/pull/645 with it only being applied to the [old integration tests](https://github.com/apache/geode-native/blob/develop/cppcache/integration-test/CMakeLists.txt#L110) to save hassle on the old stuff This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Be able to specify 'expectDomainClass' when calling createPdxInstanceFactory > > > Key: GEODE-8512 > URL: https://issues.apache.org/jira/browse/GEODE-8512 > Project: Geode > Issue Type: Improvement > Components: native client >Affects Versions: 1.13.0 >Reporter: Mario Salazar de Torres >Assignee: Mario Salazar de Torres >Priority: Minor > Labels: JsonFormatter, pull-request-available > > Within Java client, you can specify if the PdxInstance you want to create is > a Java domain class or not, but this is not the case for geode-native C++ > client. > Thing is that in order to implement JsonFormatter in C++ client, having this > change is mandatory, otherwise creating PdxType's with __GEMFIRE_JSON > classname will present some issues while using cquery's. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
