[
https://issues.apache.org/jira/browse/GEODE-8512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17212121#comment-17212121
]
ASF GitHub Bot commented on GEODE-8512:
---------------------------------------
moleske commented on a change in pull request #661:
URL: https://github.com/apache/geode-native/pull/661#discussion_r503035325
##########
File path: CMakeLists.txt
##########
@@ -254,6 +254,7 @@ elseif(CMAKE_CXX_COMPILER_ID MATCHES "Clang")
-Wno-undefined-func-template #TODO fix
-Wno-float-equal #TODO fix
-Wno-conversion #TODO fix
+ -Wno-missing-variable-declarations #TODO fix
Review comment:
Is there a reason this was added back in? It was recently fixed in
https://github.com/apache/geode-native/pull/645 with it only being applied to
the [old integration
tests](https://github.com/apache/geode-native/blob/develop/cppcache/integration-test/CMakeLists.txt#L110)
to save hassle on the old stuff
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Be able to specify 'expectDomainClass' when calling createPdxInstanceFactory
> ----------------------------------------------------------------------------
>
> Key: GEODE-8512
> URL: https://issues.apache.org/jira/browse/GEODE-8512
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Affects Versions: 1.13.0
> Reporter: Mario Salazar de Torres
> Assignee: Mario Salazar de Torres
> Priority: Minor
> Labels: JsonFormatter, pull-request-available
>
> Within Java client, you can specify if the PdxInstance you want to create is
> a Java domain class or not, but this is not the case for geode-native C++
> client.
> Thing is that in order to implement JsonFormatter in C++ client, having this
> change is mandatory, otherwise creating PdxType's with __GEMFIRE_JSON
> classname will present some issues while using cquery's.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
