[jira] [Commented] (GEODE-8565) c++ client tries to connect to down server until IO error is thrown

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-8565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210183#comment-17210183
 ] 

ASF GitHub Bot commented on GEODE-8565:
---

alb3rtobr commented on pull request #662:
URL: https://github.com/apache/geode-native/pull/662#issuecomment-705540765


   There is still one issue on windows build, Im on it
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> c++ client tries to connect to down server until IO error is thrown
> ---
>
> Key: GEODE-8565
> URL: https://issues.apache.org/jira/browse/GEODE-8565
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Alberto Bustamante Reyes
>Assignee: Alberto Bustamante Reyes
>Priority: Major
>  Labels: pull-request-available
>
> This ticket is an improvement over GEODE-8231:
> {quote}If a C++ client connected to a cluster is sending operations to a 
> partitioned region and one of the server goes down, the client keeps trying 
> to send operations to the down server. This can be observed in the logs by a 
> continuous flow of lines containing: "IO error in handshake with endpoint..."
> {quote}
> After that improvement, the c++ client removes the metadata info of the 
> failing server once the "IO error in handshake" is received.
> But it has been observed that before that error is received, "timeout error" 
> can be returned. So the client will try to reconnect until the "IO error in 
> handshake" is received.
> This ticket aims to extend the GEODE-8231 solution so the client removes the 
> server metadata information when a timeout is received.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-8202) New option for serial gw sender threads start when receivers share ip and port

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-8202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210200#comment-17210200
 ] 

ASF GitHub Bot commented on GEODE-8202:
---

davebarnes97 edited a comment on pull request #5600:
URL: https://github.com/apache/geode/pull/5600#issuecomment-705557152


   @alb3rtobr Thank you for improving the parameter name. With that in place, 
here is a suggested doc edit. I'm using present tense, rather than future 
tense, where possible, and changing some singular/plural to comply with common 
usage:
   
   
   This parameter applies only to serial gateway senders. If true, receiver 
member id is checked by all dispatcher threads when the connection is 
established to ensure they connect to the same receiver. Instead of starting 
all dispatcher threads in parallel, one thread is started first, and after that 
the rest are started in parallel.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> New option for serial gw sender threads start when receivers share ip and port
> --
>
> Key: GEODE-8202
> URL: https://issues.apache.org/jira/browse/GEODE-8202
> Project: Geode
>  Issue Type: Improvement
>Reporter: Alberto Bustamante Reyes
>Assignee: Alberto Bustamante Reyes
>Priority: Major
>  Labels: pull-request-available
>
> RFC: 
> [https://cwiki.apache.org/confluence/display/GEODE/New+option+for+serial+gw+sender+dispatcher+threads+start|https://cwiki.apache.org/confluence/display/GEODE/New+option+for+serial+gw+sender+dispatcher+threads+start]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-8202) New option for serial gw sender threads start when receivers share ip and port

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-8202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210198#comment-17210198
 ] 

ASF GitHub Bot commented on GEODE-8202:
---

davebarnes97 commented on pull request #5600:
URL: https://github.com/apache/geode/pull/5600#issuecomment-705557152


   @alb3rtobr Thank you for improving the parameter name. With that in place, 
here is a suggested doc edit. I'm using present tense, rather than future 
tense, where possible, and changing some singular/plural to comply with common 
usage.
   
   This parameter applies only to serial gateway senders. If true, receiver 
member id is checked by all dispatcher threads when the connection is 
established to ensure they connect to the same receiver. Instead of starting 
all dispatcher threads in parallel, one thread is started first, and after that 
the rest are started in parallel.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> New option for serial gw sender threads start when receivers share ip and port
> --
>
> Key: GEODE-8202
> URL: https://issues.apache.org/jira/browse/GEODE-8202
> Project: Geode
>  Issue Type: Improvement
>Reporter: Alberto Bustamante Reyes
>Assignee: Alberto Bustamante Reyes
>Priority: Major
>  Labels: pull-request-available
>
> RFC: 
> [https://cwiki.apache.org/confluence/display/GEODE/New+option+for+serial+gw+sender+dispatcher+threads+start|https://cwiki.apache.org/confluence/display/GEODE/New+option+for+serial+gw+sender+dispatcher+threads+start]



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-8582) Redis SCAN returns internal server error

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-8582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210215#comment-17210215
 ] 

ASF GitHub Bot commented on GEODE-8582:
---

sabbey37 merged pull request #5603:
URL: https://github.com/apache/geode/pull/5603


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Redis SCAN returns internal server error
> 
>
> Key: GEODE-8582
> URL: https://issues.apache.org/jira/browse/GEODE-8582
> Project: Geode
>  Issue Type: Bug
>  Components: redis
>Reporter: Sarah Abbey
>Assignee: Sarah Abbey
>Priority: Minor
>  Labels: pull-request-available
>
> Encountered when running tests from redis-py:
> {code:java}
> 127.0.0.1:7000> set a 1
> OK
> 127.0.0.1:7000> set b 2
> OK
> 127.0.0.1:7000> set c 3
> OK
> 127.0.0.1:7000> scan 0
> (error) ERR The server had an internal error please try again
> {code}
> Also found bug in count where we don't return the last key.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-8582) Redis SCAN returns internal server error

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-8582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210216#comment-17210216
 ] 

ASF subversion and git services commented on GEODE-8582:


Commit bcdf3ca64d8aca83cdd48629d8a35be6352d2861 in geode's branch 
refs/heads/develop from Sarah
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=bcdf3ca ]

GEODE-8582: Redis SCAN returns internal server error (#5603)

Co-authored-by: Darrel Schneider 

> Redis SCAN returns internal server error
> 
>
> Key: GEODE-8582
> URL: https://issues.apache.org/jira/browse/GEODE-8582
> Project: Geode
>  Issue Type: Bug
>  Components: redis
>Reporter: Sarah Abbey
>Assignee: Sarah Abbey
>Priority: Minor
>  Labels: pull-request-available
>
> Encountered when running tests from redis-py:
> {code:java}
> 127.0.0.1:7000> set a 1
> OK
> 127.0.0.1:7000> set b 2
> OK
> 127.0.0.1:7000> set c 3
> OK
> 127.0.0.1:7000> scan 0
> (error) ERR The server had an internal error please try again
> {code}
> Also found bug in count where we don't return the last key.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-8582) Redis SCAN returns internal server error

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-8582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210217#comment-17210217
 ] 

ASF subversion and git services commented on GEODE-8582:


Commit bcdf3ca64d8aca83cdd48629d8a35be6352d2861 in geode's branch 
refs/heads/develop from Sarah
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=bcdf3ca ]

GEODE-8582: Redis SCAN returns internal server error (#5603)

Co-authored-by: Darrel Schneider 

> Redis SCAN returns internal server error
> 
>
> Key: GEODE-8582
> URL: https://issues.apache.org/jira/browse/GEODE-8582
> Project: Geode
>  Issue Type: Bug
>  Components: redis
>Reporter: Sarah Abbey
>Assignee: Sarah Abbey
>Priority: Minor
>  Labels: pull-request-available
>
> Encountered when running tests from redis-py:
> {code:java}
> 127.0.0.1:7000> set a 1
> OK
> 127.0.0.1:7000> set b 2
> OK
> 127.0.0.1:7000> set c 3
> OK
> 127.0.0.1:7000> scan 0
> (error) ERR The server had an internal error please try again
> {code}
> Also found bug in count where we don't return the last key.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-8582) Redis SCAN returns internal server error

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-8582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210220#comment-17210220
 ] 

ASF subversion and git services commented on GEODE-8582:


Commit bcdf3ca64d8aca83cdd48629d8a35be6352d2861 in geode's branch 
refs/heads/develop from Sarah
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=bcdf3ca ]

GEODE-8582: Redis SCAN returns internal server error (#5603)

Co-authored-by: Darrel Schneider 

> Redis SCAN returns internal server error
> 
>
> Key: GEODE-8582
> URL: https://issues.apache.org/jira/browse/GEODE-8582
> Project: Geode
>  Issue Type: Bug
>  Components: redis
>Reporter: Sarah Abbey
>Assignee: Sarah Abbey
>Priority: Minor
>  Labels: pull-request-available
>
> Encountered when running tests from redis-py:
> {code:java}
> 127.0.0.1:7000> set a 1
> OK
> 127.0.0.1:7000> set b 2
> OK
> 127.0.0.1:7000> set c 3
> OK
> 127.0.0.1:7000> scan 0
> (error) ERR The server had an internal error please try again
> {code}
> Also found bug in count where we don't return the last key.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-8582) Redis SCAN returns internal server error

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-8582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210221#comment-17210221
 ] 

ASF subversion and git services commented on GEODE-8582:


Commit bcdf3ca64d8aca83cdd48629d8a35be6352d2861 in geode's branch 
refs/heads/develop from Sarah
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=bcdf3ca ]

GEODE-8582: Redis SCAN returns internal server error (#5603)

Co-authored-by: Darrel Schneider 

> Redis SCAN returns internal server error
> 
>
> Key: GEODE-8582
> URL: https://issues.apache.org/jira/browse/GEODE-8582
> Project: Geode
>  Issue Type: Bug
>  Components: redis
>Reporter: Sarah Abbey
>Assignee: Sarah Abbey
>Priority: Minor
>  Labels: pull-request-available
>
> Encountered when running tests from redis-py:
> {code:java}
> 127.0.0.1:7000> set a 1
> OK
> 127.0.0.1:7000> set b 2
> OK
> 127.0.0.1:7000> set c 3
> OK
> 127.0.0.1:7000> scan 0
> (error) ERR The server had an internal error please try again
> {code}
> Also found bug in count where we don't return the last key.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-8583) create RestrictedInputValuesParameterRequirements in Redis Module

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-8583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210223#comment-17210223
 ] 

ASF GitHub Bot commented on GEODE-8583:
---

jdeppe-pivotal commented on a change in pull request #5604:
URL: https://github.com/apache/geode/pull/5604#discussion_r501729688



##
File path: 
geode-redis/src/main/java/org/apache/geode/redis/internal/ParameterRequirements/RestrictedInputValuesParameterRequirements.java
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional 
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY 
KIND, either express
+ * or implied. See the License for the specific language governing permissions 
and limitations under
+ * the License.
+ */
+
+package org.apache.geode.redis.internal.ParameterRequirements;
+
+import java.util.List;
+
+import org.apache.geode.redis.internal.netty.Command;
+import org.apache.geode.redis.internal.netty.ExecutionHandlerContext;
+
+public class RestrictedInputValuesParameterRequirements implements 
ParameterRequirements {
+
+  List allowedValues = null;
+
+  public RestrictedInputValuesParameterRequirements(List 
allowedValues) {
+this.allowedValues = allowedValues;
+  }
+
+  @Override
+  public void checkParameters(Command command,
+  ExecutionHandlerContext executionHandlerContext) {
+List parameters = command.getProcessedCommand();
+String commandType = command.getCommandType().name();
+
+parameters.forEach(parameter -> {
+  String parameterString = parameter.toString();

Review comment:
   I don't thing this is what you want here. `parameter.toString()` is just 
going to produce something like `[B@6ea12c19`. You need to create a new String 
from the byte array.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> create RestrictedInputValuesParameterRequirements in Redis Module
> -
>
> Key: GEODE-8583
> URL: https://issues.apache.org/jira/browse/GEODE-8583
> Project: Geode
>  Issue Type: Improvement
>Reporter: John Hutchison
>Priority: Minor
>  Labels: pull-request-available, redis
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-8583) create RestrictedInputValuesParameterRequirements in Redis Module

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-8583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210224#comment-17210224
 ] 

ASF GitHub Bot commented on GEODE-8583:
---

jdeppe-pivotal commented on a change in pull request #5604:
URL: https://github.com/apache/geode/pull/5604#discussion_r501729688



##
File path: 
geode-redis/src/main/java/org/apache/geode/redis/internal/ParameterRequirements/RestrictedInputValuesParameterRequirements.java
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional 
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY 
KIND, either express
+ * or implied. See the License for the specific language governing permissions 
and limitations under
+ * the License.
+ */
+
+package org.apache.geode.redis.internal.ParameterRequirements;
+
+import java.util.List;
+
+import org.apache.geode.redis.internal.netty.Command;
+import org.apache.geode.redis.internal.netty.ExecutionHandlerContext;
+
+public class RestrictedInputValuesParameterRequirements implements 
ParameterRequirements {
+
+  List allowedValues = null;
+
+  public RestrictedInputValuesParameterRequirements(List 
allowedValues) {
+this.allowedValues = allowedValues;
+  }
+
+  @Override
+  public void checkParameters(Command command,
+  ExecutionHandlerContext executionHandlerContext) {
+List parameters = command.getProcessedCommand();
+String commandType = command.getCommandType().name();
+
+parameters.forEach(parameter -> {
+  String parameterString = parameter.toString();

Review comment:
   I don't think this is what you want here. `parameter.toString()` is just 
going to produce something like `[B@6ea12c19`. You need to create a new String 
from the byte array.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> create RestrictedInputValuesParameterRequirements in Redis Module
> -
>
> Key: GEODE-8583
> URL: https://issues.apache.org/jira/browse/GEODE-8583
> Project: Geode
>  Issue Type: Improvement
>Reporter: John Hutchison
>Priority: Minor
>  Labels: pull-request-available, redis
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (GEODE-8582) Redis SCAN returns internal server error

[Sarah Abbey (Jira)]

 [ 
https://issues.apache.org/jira/browse/GEODE-8582?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sarah Abbey resolved GEODE-8582.

Fix Version/s: 1.14.0
   Resolution: Fixed

> Redis SCAN returns internal server error
> 
>
> Key: GEODE-8582
> URL: https://issues.apache.org/jira/browse/GEODE-8582
> Project: Geode
>  Issue Type: Bug
>  Components: redis
>Reporter: Sarah Abbey
>Assignee: Sarah Abbey
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> Encountered when running tests from redis-py:
> {code:java}
> 127.0.0.1:7000> set a 1
> OK
> 127.0.0.1:7000> set b 2
> OK
> 127.0.0.1:7000> set c 3
> OK
> 127.0.0.1:7000> scan 0
> (error) ERR The server had an internal error please try again
> {code}
> Also found bug in count where we don't return the last key.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-8512) Be able to specify 'expectDomainClass' when calling createPdxInstanceFactory

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-8512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210294#comment-17210294
 ] 

ASF GitHub Bot commented on GEODE-8512:
---

gaussianrecurrence commented on a change in pull request #661:
URL: https://github.com/apache/geode-native/pull/661#discussion_r501818944



##
File path: cppcache/integration/test/PdxJsonTypeTest.cpp
##
@@ -68,6 +68,32 @@ std::shared_ptr setupRegion(Cache& cache) {
   return region;
 }
 
+TEST(PdxJsonTypeTest, testGfshQueryJsonInstances) {
+  Cluster cluster{LocatorCount{1}, ServerCount{1}};
+  cluster.start();
+
+  auto& gfsh = cluster.getGfsh();
+  gfsh.create().region().withName("region").withType("REPLICATE").execute();
+
+  auto cache = cluster.createCache();
+  auto region = setupRegion(cache);
+  const std::string query_stmt{"SELECT * FROM /region"};
+
+  region->put("non-java-domain-class-entry",
+  cache.createPdxInstanceFactory(gemfireJsonClassName, false)
+  .writeString("foo", "bar")
+  .create());
+
+  EXPECT_NO_THROW(gfsh.query(query_stmt).execute());
+
+  region->put("java-domain-class-entry",
+  cache.createPdxInstanceFactory(gemfireJsonClassName)
+  .writeString("foo", "bar")
+  .create());
+
+  EXPECT_THROW(gfsh.query(query_stmt).execute(), GfshExecuteException);

Review comment:
   Hi @mmartell,
   
   I think there's a singularity in the code. And with this I mean that it 
seems with those entries this test shows that code fails in failing. TBH I 
don't have a clue about what's happenning, I've tried changing the entries I 
write and these are the results:
   
   1.  **FAILED**: [1st: non-java-domain-class-entry => {foo: bar}; 2nd: 
java-domain-class-entry => {foo: bar}]
   2. **PASSED**: [1st: non-java-domain-class-entry => {foo: bar}; 2nd: 
java-domain-class-entry => {foo2: bar}]
   3. **PASSED**: [1st: non-java-domain-class-entry => {foo: bar}; 2nd: 
java-domain-class-entry => {foo: bar2}]
   4. **FAILED**: [1st: non-java-domain-class-entry => {foo: bar}; 2nd: 
non-java-domain-class-entry => {foo: bar}]
   5. **FAILED**: [1st: non-java-domain-class-entry => {foo: bar}; 2nd: 
non-java-domain-class-entry => {foo2: bar}]
   6.  **PASSED**: [1st: entry-1 => {entryName: entry-1}; 2nd: entry-2 => 
{entryName: entry-2}]
   7.  **PASSED**: [1st: entry-1 => {entryName: entry-1}; 2nd: entry-2 => 
{entryName: entry-1}]
   
   Cases **4 and 5** would somehow make sense to me, but should not be 
happenning as the PdxType should be different.
   But the f... up cases are **1 and 7** as they are equivalent but still 1 
fails and 7 not.
   
   If you have any idea about what could be happening, I'd appreciate your 
ideas.
   My feeling here is that there are some issues with hashing functions either 
on the client or on the server, or even maybe in both. That's the only 
explanation for case 1 failing and 7 not as of my understanding.
   
   Anyhow, will keep digging on this matter :S
   





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Be able to specify 'expectDomainClass' when calling createPdxInstanceFactory
> 
>
> Key: GEODE-8512
> URL: https://issues.apache.org/jira/browse/GEODE-8512
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Affects Versions: 1.13.0
>Reporter: Mario Salazar de Torres
>Assignee: Mario Salazar de Torres
>Priority: Minor
>  Labels: JsonFormatter, pull-request-available
>
> Within Java client, you can specify if the PdxInstance you want to create is 
> a Java domain class or not, but this is not the case for geode-native C++ 
> client.
> Thing is that in order to implement JsonFormatter in C++ client, having this 
> change is mandatory, otherwise creating PdxType's with __GEMFIRE_JSON 
> classname will present some issues while using cquery's.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-8584) Message transmission fails with IllegalStateException in socket i/o code

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-8584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210293#comment-17210293
 ] 

ASF GitHub Bot commented on GEODE-8584:
---

agingade commented on a change in pull request #5605:
URL: https://github.com/apache/geode/pull/5605#discussion_r501818461



##
File path: 
geode-core/src/main/java/org/apache/geode/internal/tcp/Connection.java
##
@@ -2588,17 +2592,20 @@ void writeFully(SocketChannel channel, ByteBuffer 
buffer, boolean forceAsync,
   }
   // fall through
 }
-ByteBuffer wrappedBuffer = ioFilter.wrap(buffer);
-while (wrappedBuffer.remaining() > 0) {
-  int amtWritten = 0;
-  long start = stats.startSocketWrite(true);
-  try {
-amtWritten = channel.write(wrappedBuffer);
-  } finally {
-stats.endSocketWrite(true, start, amtWritten, 0);
+// synchronize on the ioFilter while using its network buffer
+synchronized (ioFilter) {
+  ByteBuffer wrappedBuffer = ioFilter.wrap(buffer);
+  while (wrappedBuffer.remaining() > 0) {
+int amtWritten = 0;
+long start = stats.startSocketWrite(true);
+try {
+  amtWritten = channel.write(wrappedBuffer);

Review comment:
   Is there anything that needs to be done, if write throws 
exception...Sorry I may be asking wrong question as I don't have much context 
here.

##
File path: 
geode-core/src/main/java/org/apache/geode/internal/net/NioSslEngine.java
##
@@ -396,9 +402,17 @@ public synchronized void close(SocketChannel 
socketChannel) {
 } catch (IOException e) {
   throw new GemFireIOException("exception closing SSL session", e);
 } finally {
-  bufferPool.releaseBuffer(TRACKED_SENDER, myNetData);
-  bufferPool.releaseBuffer(TRACKED_RECEIVER, peerAppData);
+  logger.info("NioSSLEngine releasing two buffers myNetData={}({}), 
peerAppData={}({})",

Review comment:
   This should be info or debug level log? just checking...





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Message transmission fails with IllegalStateException in socket i/o code
> 
>
> Key: GEODE-8584
> URL: https://issues.apache.org/jira/browse/GEODE-8584
> Project: Geode
>  Issue Type: Bug
>  Components: membership, messaging
>Affects Versions: 1.12.0, 1.13.0, 1.14.0
>Reporter: Bruce J Schuchardt
>Priority: Major
>  Labels: pull-request-available
>
> Transmission of an update operation failed with a toData exception caused by 
> an IllegalStateException in socket i/o code.  It shouldn't be possible for 
> this exception to happen unless multiple threads are using the buffer at the 
> same time.
>  
> {noformat}
> org.apache.geode.ToDataException: toData failed on dsfid=71 msg:null
>   at 
> org.apache.geode.internal.InternalDataSerializer.writeDSFID(InternalDataSerializer.java:1509)
>   at 
> org.apache.geode.internal.tcp.MsgStreamer.writeMessage(MsgStreamer.java:249)
>   at 
> org.apache.geode.distributed.internal.direct.DirectChannel.sendToMany(DirectChannel.java:306)
>   at 
> org.apache.geode.distributed.internal.direct.DirectChannel.sendToOne(DirectChannel.java:182)
>   at 
> org.apache.geode.distributed.internal.direct.DirectChannel.send(DirectChannel.java:511)
>   at 
> org.apache.geode.distributed.internal.DistributionImpl.directChannelSend(DistributionImpl.java:346)
>   at 
> org.apache.geode.distributed.internal.DistributionImpl.send(DistributionImpl.java:291)
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendViaMembershipManager(ClusterDistributionManager.java:2053)
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendOutgoing(ClusterDistributionManager.java:1981)
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendMessage(ClusterDistributionManager.java:2018)
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.putOutgoing(ClusterDistributionManager.java:1083)
>   at 
> org.apache.geode.internal.cache.DistributedCacheOperation._distribute(DistributedCacheOperation.java:572)
>   at 
> org.apache.geode.internal.cache.DistributedCacheOperation.startOperation(DistributedCacheOperation.java:277)
>   at 
> org.apache.geode.internal.cache.DistributedCacheOperation.distribute(DistributedCacheOperation.java:318)
>   at 
> org.apache.geode.i

[jira] [Commented] (GEODE-8584) Message transmission fails with IllegalStateException in socket i/o code

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-8584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210301#comment-17210301
 ] 

ASF GitHub Bot commented on GEODE-8584:
---

bschuchardt commented on a change in pull request #5605:
URL: https://github.com/apache/geode/pull/5605#discussion_r501833149



##
File path: 
geode-core/src/main/java/org/apache/geode/internal/net/NioSslEngine.java
##
@@ -396,9 +402,17 @@ public synchronized void close(SocketChannel 
socketChannel) {
 } catch (IOException e) {
   throw new GemFireIOException("exception closing SSL session", e);
 } finally {
-  bufferPool.releaseBuffer(TRACKED_SENDER, myNetData);
-  bufferPool.releaseBuffer(TRACKED_RECEIVER, peerAppData);
+  logger.info("NioSSLEngine releasing two buffers myNetData={}({}), 
peerAppData={}({})",

Review comment:
   thanks for catching that Anil - that's debug output that I meant to 
delete





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Message transmission fails with IllegalStateException in socket i/o code
> 
>
> Key: GEODE-8584
> URL: https://issues.apache.org/jira/browse/GEODE-8584
> Project: Geode
>  Issue Type: Bug
>  Components: membership, messaging
>Affects Versions: 1.12.0, 1.13.0, 1.14.0
>Reporter: Bruce J Schuchardt
>Priority: Major
>  Labels: pull-request-available
>
> Transmission of an update operation failed with a toData exception caused by 
> an IllegalStateException in socket i/o code.  It shouldn't be possible for 
> this exception to happen unless multiple threads are using the buffer at the 
> same time.
>  
> {noformat}
> org.apache.geode.ToDataException: toData failed on dsfid=71 msg:null
>   at 
> org.apache.geode.internal.InternalDataSerializer.writeDSFID(InternalDataSerializer.java:1509)
>   at 
> org.apache.geode.internal.tcp.MsgStreamer.writeMessage(MsgStreamer.java:249)
>   at 
> org.apache.geode.distributed.internal.direct.DirectChannel.sendToMany(DirectChannel.java:306)
>   at 
> org.apache.geode.distributed.internal.direct.DirectChannel.sendToOne(DirectChannel.java:182)
>   at 
> org.apache.geode.distributed.internal.direct.DirectChannel.send(DirectChannel.java:511)
>   at 
> org.apache.geode.distributed.internal.DistributionImpl.directChannelSend(DistributionImpl.java:346)
>   at 
> org.apache.geode.distributed.internal.DistributionImpl.send(DistributionImpl.java:291)
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendViaMembershipManager(ClusterDistributionManager.java:2053)
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendOutgoing(ClusterDistributionManager.java:1981)
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendMessage(ClusterDistributionManager.java:2018)
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.putOutgoing(ClusterDistributionManager.java:1083)
>   at 
> org.apache.geode.internal.cache.DistributedCacheOperation._distribute(DistributedCacheOperation.java:572)
>   at 
> org.apache.geode.internal.cache.DistributedCacheOperation.startOperation(DistributedCacheOperation.java:277)
>   at 
> org.apache.geode.internal.cache.DistributedCacheOperation.distribute(DistributedCacheOperation.java:318)
>   at 
> org.apache.geode.internal.cache.DistributedRegion.distributeUpdate(DistributedRegion.java:520)
>   at 
> org.apache.geode.internal.cache.DistributedRegion.basicPutPart3(DistributedRegion.java:498)
>   at 
> org.apache.geode.internal.cache.map.RegionMapPut.doAfterCompletionActions(RegionMapPut.java:307)
>   at 
> org.apache.geode.internal.cache.map.AbstractRegionMapPut.doPut(AbstractRegionMapPut.java:185)
>   at 
> org.apache.geode.internal.cache.map.AbstractRegionMapPut.runWhileLockedForCacheModification(AbstractRegionMapPut.java:119)
>   at 
> org.apache.geode.internal.cache.map.RegionMapPut.runWhileLockedForCacheModification(RegionMapPut.java:161)
>   at 
> org.apache.geode.internal.cache.map.AbstractRegionMapPut.put(AbstractRegionMapPut.java:169)
>   at 
> org.apache.geode.internal.cache.AbstractRegionMap.basicPut(AbstractRegionMap.java:2044)
>   at 
> org.apache.geode.internal.cache.LocalRegion.virtualPut(LocalRegion.java:5599)
>   at 
> org.apache.geode.internal.cache.DistributedRegion.virtualPut(DistributedRegion.java:393)
>   at 
> org.apache.geode.internal.cache.LocalRegion.virtualPut(LocalRegi

[jira] [Commented] (GEODE-8584) Message transmission fails with IllegalStateException in socket i/o code

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-8584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210302#comment-17210302
 ] 

ASF GitHub Bot commented on GEODE-8584:
---

bschuchardt commented on a change in pull request #5605:
URL: https://github.com/apache/geode/pull/5605#discussion_r501833784



##
File path: 
geode-core/src/main/java/org/apache/geode/internal/tcp/Connection.java
##
@@ -2588,17 +2592,20 @@ void writeFully(SocketChannel channel, ByteBuffer 
buffer, boolean forceAsync,
   }
   // fall through
 }
-ByteBuffer wrappedBuffer = ioFilter.wrap(buffer);
-while (wrappedBuffer.remaining() > 0) {
-  int amtWritten = 0;
-  long start = stats.startSocketWrite(true);
-  try {
-amtWritten = channel.write(wrappedBuffer);
-  } finally {
-stats.endSocketWrite(true, start, amtWritten, 0);
+// synchronize on the ioFilter while using its network buffer
+synchronized (ioFilter) {
+  ByteBuffer wrappedBuffer = ioFilter.wrap(buffer);
+  while (wrappedBuffer.remaining() > 0) {
+int amtWritten = 0;
+long start = stats.startSocketWrite(true);
+try {
+  amtWritten = channel.write(wrappedBuffer);

Review comment:
   handlers for declared exceptions are already in place





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Message transmission fails with IllegalStateException in socket i/o code
> 
>
> Key: GEODE-8584
> URL: https://issues.apache.org/jira/browse/GEODE-8584
> Project: Geode
>  Issue Type: Bug
>  Components: membership, messaging
>Affects Versions: 1.12.0, 1.13.0, 1.14.0
>Reporter: Bruce J Schuchardt
>Priority: Major
>  Labels: pull-request-available
>
> Transmission of an update operation failed with a toData exception caused by 
> an IllegalStateException in socket i/o code.  It shouldn't be possible for 
> this exception to happen unless multiple threads are using the buffer at the 
> same time.
>  
> {noformat}
> org.apache.geode.ToDataException: toData failed on dsfid=71 msg:null
>   at 
> org.apache.geode.internal.InternalDataSerializer.writeDSFID(InternalDataSerializer.java:1509)
>   at 
> org.apache.geode.internal.tcp.MsgStreamer.writeMessage(MsgStreamer.java:249)
>   at 
> org.apache.geode.distributed.internal.direct.DirectChannel.sendToMany(DirectChannel.java:306)
>   at 
> org.apache.geode.distributed.internal.direct.DirectChannel.sendToOne(DirectChannel.java:182)
>   at 
> org.apache.geode.distributed.internal.direct.DirectChannel.send(DirectChannel.java:511)
>   at 
> org.apache.geode.distributed.internal.DistributionImpl.directChannelSend(DistributionImpl.java:346)
>   at 
> org.apache.geode.distributed.internal.DistributionImpl.send(DistributionImpl.java:291)
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendViaMembershipManager(ClusterDistributionManager.java:2053)
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendOutgoing(ClusterDistributionManager.java:1981)
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendMessage(ClusterDistributionManager.java:2018)
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.putOutgoing(ClusterDistributionManager.java:1083)
>   at 
> org.apache.geode.internal.cache.DistributedCacheOperation._distribute(DistributedCacheOperation.java:572)
>   at 
> org.apache.geode.internal.cache.DistributedCacheOperation.startOperation(DistributedCacheOperation.java:277)
>   at 
> org.apache.geode.internal.cache.DistributedCacheOperation.distribute(DistributedCacheOperation.java:318)
>   at 
> org.apache.geode.internal.cache.DistributedRegion.distributeUpdate(DistributedRegion.java:520)
>   at 
> org.apache.geode.internal.cache.DistributedRegion.basicPutPart3(DistributedRegion.java:498)
>   at 
> org.apache.geode.internal.cache.map.RegionMapPut.doAfterCompletionActions(RegionMapPut.java:307)
>   at 
> org.apache.geode.internal.cache.map.AbstractRegionMapPut.doPut(AbstractRegionMapPut.java:185)
>   at 
> org.apache.geode.internal.cache.map.AbstractRegionMapPut.runWhileLockedForCacheModification(AbstractRegionMapPut.java:119)
>   at 
> org.apache.geode.internal.cache.map.RegionMapPut.runWhileLockedForCacheModification(RegionMapPut.java:161)
>   at 
> org.apache.geode.internal

[jira] [Commented] (GEODE-8573) SerialGatewaySenderOperationsDistributedTest.testRestartSerialGatewaySendersWhilePutting

[Jens Deppe (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-8573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210309#comment-17210309
 ] 

Jens Deppe commented on GEODE-8573:
---

Failed again:

=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0402/test-results/distributedTest/1602172929/
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

Test report artifacts from this job are available at:

http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0402/test-artifacts/1602172929/distributedtestfiles-OpenJDK8-1.14.0-build.0402.tgz

> SerialGatewaySenderOperationsDistributedTest.testRestartSerialGatewaySendersWhilePutting
> 
>
> Key: GEODE-8573
> URL: https://issues.apache.org/jira/browse/GEODE-8573
> Project: Geode
>  Issue Type: Bug
>  Components: wan
>Affects Versions: 1.14.0
>Reporter: Mark Hanson
>Assignee: Mark Hanson
>Priority: Major
>
> [https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK8/builds/521]
>  
> {noformat}
> org.apache.geode.internal.cache.wan.serial.SerialGatewaySenderOperationsDistributedTest
>  > testRestartSerialGatewaySendersWhilePutting[1: numDispatchers=3] FAILED
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.internal.cache.wan.serial.SerialGatewaySenderOperationsDistributedTest$$Lambda$356/426344166.run
>  in VM 5 running on Host 538fd3213f62 with 8 VMs
> at org.apache.geode.test.dunit.VM.executeMethodOnObject(VM.java:620)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:447)
> at 
> org.apache.geode.internal.cache.wan.serial.SerialGatewaySenderOperationsDistributedTest.testRestartSerialGatewaySendersWhilePutting(SerialGatewaySenderOperationsDistributedTest.java:407)
> Caused by:
> org.awaitility.core.ConditionTimeoutException: Assertion condition 
> defined as a lambda expression in 
> org.apache.geode.internal.cache.wan.serial.SerialGatewaySenderOperationsDistributedTest
>  that uses org.apache.geode.internal.cache.wan.InternalGatewaySender, 
> org.apache.geode.internal.cache.wan.InternalGatewaySenderint [Sender 
> statistics unprocessed event map size] expected:<[0]> but was:<[3]> within 5 
> minutes.
> at 
> org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:165)
> at 
> org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
> at 
> org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
> at 
> org.awaitility.core.ConditionFactory.until(ConditionFactory.java:895)
> at 
> org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:679)
> at 
> org.apache.geode.internal.cache.wan.serial.SerialGatewaySenderOperationsDistributedTest.validateSecondaryQueueSizeStat(SerialGatewaySenderOperationsDistributedTest.java:1216)
> at 
> org.apache.geode.internal.cache.wan.serial.SerialGatewaySenderOperationsDistributedTest.lambda$testRestartSerialGatewaySendersWhilePutting$bb17a952$23(SerialGatewaySenderOperationsDistributedTest.java:407)
> Caused by:
> org.junit.ComparisonFailure: [Sender statistics unprocessed event 
> map size] expected:<[0]> but was:<[3]>
> at 
> sun.reflect.GeneratedConstructorAccessor81.newInstance(Unknown Source)
> at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at 
> org.apache.geode.internal.cache.wan.serial.SerialGatewaySenderOperationsDistributedTest.lambda$validateSecondaryQueueSizeStat$8(SerialGatewaySenderOperationsDistributedTest.java:1219)
>  {noformat}
>  
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI 
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
>  
> [http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0389/test-results/distributedTest/1601774166/]
>  
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> Test report artifacts from this job are available at:
> [http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0389/test-artifacts/1601774166/distributedtestfiles-OpenJDK8-1.14.0-build.0389.tgz]
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-8573) SerialGatewaySenderOperationsDistributedTest.testRestartSerialGatewaySendersWhilePutting

[Geode Integration (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-8573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210310#comment-17210310
 ] 

Geode Integration commented on GEODE-8573:
--

Seen in [DistributedTestOpenJDK8 
#536|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK8/builds/536]
 ... see [test 
results|http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0402/test-results/distributedTest/1602172929/]
 or download 
[artifacts|http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0402/test-artifacts/1602172929/distributedtestfiles-OpenJDK8-1.14.0-build.0402.tgz].

> SerialGatewaySenderOperationsDistributedTest.testRestartSerialGatewaySendersWhilePutting
> 
>
> Key: GEODE-8573
> URL: https://issues.apache.org/jira/browse/GEODE-8573
> Project: Geode
>  Issue Type: Bug
>  Components: wan
>Affects Versions: 1.14.0
>Reporter: Mark Hanson
>Assignee: Mark Hanson
>Priority: Major
>
> [https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK8/builds/521]
>  
> {noformat}
> org.apache.geode.internal.cache.wan.serial.SerialGatewaySenderOperationsDistributedTest
>  > testRestartSerialGatewaySendersWhilePutting[1: numDispatchers=3] FAILED
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.internal.cache.wan.serial.SerialGatewaySenderOperationsDistributedTest$$Lambda$356/426344166.run
>  in VM 5 running on Host 538fd3213f62 with 8 VMs
> at org.apache.geode.test.dunit.VM.executeMethodOnObject(VM.java:620)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:447)
> at 
> org.apache.geode.internal.cache.wan.serial.SerialGatewaySenderOperationsDistributedTest.testRestartSerialGatewaySendersWhilePutting(SerialGatewaySenderOperationsDistributedTest.java:407)
> Caused by:
> org.awaitility.core.ConditionTimeoutException: Assertion condition 
> defined as a lambda expression in 
> org.apache.geode.internal.cache.wan.serial.SerialGatewaySenderOperationsDistributedTest
>  that uses org.apache.geode.internal.cache.wan.InternalGatewaySender, 
> org.apache.geode.internal.cache.wan.InternalGatewaySenderint [Sender 
> statistics unprocessed event map size] expected:<[0]> but was:<[3]> within 5 
> minutes.
> at 
> org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:165)
> at 
> org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
> at 
> org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
> at 
> org.awaitility.core.ConditionFactory.until(ConditionFactory.java:895)
> at 
> org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:679)
> at 
> org.apache.geode.internal.cache.wan.serial.SerialGatewaySenderOperationsDistributedTest.validateSecondaryQueueSizeStat(SerialGatewaySenderOperationsDistributedTest.java:1216)
> at 
> org.apache.geode.internal.cache.wan.serial.SerialGatewaySenderOperationsDistributedTest.lambda$testRestartSerialGatewaySendersWhilePutting$bb17a952$23(SerialGatewaySenderOperationsDistributedTest.java:407)
> Caused by:
> org.junit.ComparisonFailure: [Sender statistics unprocessed event 
> map size] expected:<[0]> but was:<[3]>
> at 
> sun.reflect.GeneratedConstructorAccessor81.newInstance(Unknown Source)
> at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at 
> org.apache.geode.internal.cache.wan.serial.SerialGatewaySenderOperationsDistributedTest.lambda$validateSecondaryQueueSizeStat$8(SerialGatewaySenderOperationsDistributedTest.java:1219)
>  {noformat}
>  
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI 
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
>  
> [http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0389/test-results/distributedTest/1601774166/]
>  
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> Test report artifacts from this job are available at:
> [http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0389/test-artifacts/1601774166/distributedtestfiles-OpenJDK8-1.14.0-build.0389.tgz]
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-8583) create RestrictedInputValuesParameterRequirements in Redis Module

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-8583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210318#comment-17210318
 ] 

ASF GitHub Bot commented on GEODE-8583:
---

jhutchison commented on a change in pull request #5604:
URL: https://github.com/apache/geode/pull/5604#discussion_r501859545



##
File path: 
geode-redis/src/main/java/org/apache/geode/redis/internal/ParameterRequirements/RestrictedInputValuesParameterRequirements.java
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional 
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY 
KIND, either express
+ * or implied. See the License for the specific language governing permissions 
and limitations under
+ * the License.
+ */
+
+package org.apache.geode.redis.internal.ParameterRequirements;
+
+import java.util.List;
+
+import org.apache.geode.redis.internal.netty.Command;
+import org.apache.geode.redis.internal.netty.ExecutionHandlerContext;
+
+public class RestrictedInputValuesParameterRequirements implements 
ParameterRequirements {
+
+  List allowedValues = null;
+
+  public RestrictedInputValuesParameterRequirements(List 
allowedValues) {
+this.allowedValues = allowedValues;
+  }
+
+  @Override
+  public void checkParameters(Command command,
+  ExecutionHandlerContext executionHandlerContext) {
+List parameters = command.getProcessedCommand();
+String commandType = command.getCommandType().name();
+
+parameters.forEach(parameter -> {
+  String parameterString = parameter.toString();
+  if (isNotAllowed(parameterString) &&
+  !parameterString.equalsIgnoreCase(commandType)) {

Review comment:
   > This PR changes way too many files. I didn't look at all of them. But 
it should have only changed 2 or 3.
   > I'm not sure I like this change because now we have the parameters in two 
places. We still have the switch statement in InfoExecutor that checks for each 
one, but now we also have a list of them in another place 
(ALLOWED_INFO_COMMANDS). The other confusing thing is that the INFO command 
does allow other keywords it just ignores them. In native redis "INFO foobar" 
does not give an error but just returns nothing. But by adding a 
RestrictedInputValuesParameterRequirements to INFO it makes me think that any 
other params would cause an error.
   
   I'll double check, but the large number of files changed should be the 
result of my moving the RedisConstants class into a new subdirectory (because 
there is now another constants files to hold specifically allowed parameters , 
and it seemed to  make sense to group them together).To be addressed below, 
 I did forget to make the change to allow an error mesg for the class to be 
passed in as a parameter.  As you say, for info, the error mesg will just be an 
empty string, but other commands can pass in other other err msgs as is 
appropriate to match native  redis behavior.
   
   I still like having the logic for the commands in the executor for now.  I 
see your point about the list of allowable commands being in 2 places.  
Ultimately I would like to use a singleton  enum, but wasn't able to figure out 
how to make that work without some more playing around (let me know if you have 
thoughts) 





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> create RestrictedInputValuesParameterRequirements in Redis Module
> -
>
> Key: GEODE-8583
> URL: https://issues.apache.org/jira/browse/GEODE-8583
> Project: Geode
>  Issue Type: Improvement
>Reporter: John Hutchison
>Priority: Minor
>  Labels: pull-request-available, redis
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-8583) create RestrictedInputValuesParameterRequirements in Redis Module

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-8583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210320#comment-17210320
 ] 

ASF GitHub Bot commented on GEODE-8583:
---

jhutchison commented on a change in pull request #5604:
URL: https://github.com/apache/geode/pull/5604#discussion_r501861215



##
File path: 
geode-redis/src/main/java/org/apache/geode/redis/internal/GeodeRedisServer.java
##
@@ -93,13 +86,21 @@ public GeodeRedisServer(String bindAddress, int port, 
InternalCache cache) {
 CommandFunction.register(regionProvider.getDataRegion(), stripedExecutor, 
redisStats);
 RenameFunction.register(regionProvider.getDataRegion(), stripedExecutor, 
redisStats);
 RedisCommandFunction.register();
+
 passiveExpirationManager =
 new PassiveExpirationManager(regionProvider.getDataRegion(), 
redisStats);
-redisCommandExecutor = 
LoggingExecutors.newCachedThreadPool("GeodeRedisServer-Command-", true);
-nettyRedisServer = new NettyRedisServer(() -> 
cache.getInternalDistributedSystem().getConfig(),
-regionProvider, pubSub,
-this::allowUnsupportedCommands, this::shutdown, port, bindAddress, 
redisStats,
-redisCommandExecutor);
+redisCommandExecutor =
+LoggingExecutors.newCachedThreadPool("Redis Command", true);

Review comment:
   makes sense.  I think I'm going to slowly lobby to see if I can get some 
things updated in Spotless...   





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> create RestrictedInputValuesParameterRequirements in Redis Module
> -
>
> Key: GEODE-8583
> URL: https://issues.apache.org/jira/browse/GEODE-8583
> Project: Geode
>  Issue Type: Improvement
>Reporter: John Hutchison
>Priority: Minor
>  Labels: pull-request-available, redis
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-8583) create RestrictedInputValuesParameterRequirements in Redis Module

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-8583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210322#comment-17210322
 ] 

ASF GitHub Bot commented on GEODE-8583:
---

jhutchison commented on a change in pull request #5604:
URL: https://github.com/apache/geode/pull/5604#discussion_r501861889



##
File path: 
geode-redis/src/main/java/org/apache/geode/redis/internal/ParameterRequirements/RestrictedInputValuesParameterRequirements.java
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional 
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY 
KIND, either express
+ * or implied. See the License for the specific language governing permissions 
and limitations under
+ * the License.
+ */
+
+package org.apache.geode.redis.internal.ParameterRequirements;
+
+import java.util.List;
+
+import org.apache.geode.redis.internal.netty.Command;
+import org.apache.geode.redis.internal.netty.ExecutionHandlerContext;
+
+public class RestrictedInputValuesParameterRequirements implements 
ParameterRequirements {
+
+  List allowedValues = null;
+
+  public RestrictedInputValuesParameterRequirements(List 
allowedValues) {
+this.allowedValues = allowedValues;
+  }
+
+  @Override
+  public void checkParameters(Command command,
+  ExecutionHandlerContext executionHandlerContext) {
+List parameters = command.getProcessedCommand();
+String commandType = command.getCommandType().name();
+
+parameters.forEach(parameter -> {
+  String parameterString = parameter.toString();
+  if (isNotAllowed(parameterString) &&
+  !parameterString.equalsIgnoreCase(commandType)) {
+throw new RedisParametersMismatchException("");

Review comment:
   the idea is to allow a mesg to be passed as a parameter.  I'm only using 
it for info command now, and forgot to make that change.  Thanks for the catch





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> create RestrictedInputValuesParameterRequirements in Redis Module
> -
>
> Key: GEODE-8583
> URL: https://issues.apache.org/jira/browse/GEODE-8583
> Project: Geode
>  Issue Type: Improvement
>Reporter: John Hutchison
>Priority: Minor
>  Labels: pull-request-available, redis
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-8583) create RestrictedInputValuesParameterRequirements in Redis Module

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-8583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210323#comment-17210323
 ] 

ASF GitHub Bot commented on GEODE-8583:
---

jhutchison commented on a change in pull request #5604:
URL: https://github.com/apache/geode/pull/5604#discussion_r501862775



##
File path: 
geode-redis/src/main/java/org/apache/geode/redis/internal/ParameterRequirements/RestrictedInputValuesParameterRequirements.java
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional 
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY 
KIND, either express
+ * or implied. See the License for the specific language governing permissions 
and limitations under
+ * the License.
+ */
+
+package org.apache.geode.redis.internal.ParameterRequirements;
+
+import java.util.List;
+
+import org.apache.geode.redis.internal.netty.Command;
+import org.apache.geode.redis.internal.netty.ExecutionHandlerContext;
+
+public class RestrictedInputValuesParameterRequirements implements 
ParameterRequirements {
+
+  List allowedValues = null;
+
+  public RestrictedInputValuesParameterRequirements(List 
allowedValues) {
+this.allowedValues = allowedValues;
+  }
+
+  @Override
+  public void checkParameters(Command command,
+  ExecutionHandlerContext executionHandlerContext) {
+List parameters = command.getProcessedCommand();
+String commandType = command.getCommandType().name();
+
+parameters.forEach(parameter -> {
+  String parameterString = parameter.toString();
+  if (isNotAllowed(parameterString) &&
+  !parameterString.equalsIgnoreCase(commandType)) {

Review comment:
   Also, I left the commit history, in an attempt to make it easy to see 
that a lot of files were changed when I moved the redisConstants class.  Is 
there a better way to communicate/show that in PRs?  just a separate PR? 





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> create RestrictedInputValuesParameterRequirements in Redis Module
> -
>
> Key: GEODE-8583
> URL: https://issues.apache.org/jira/browse/GEODE-8583
> Project: Geode
>  Issue Type: Improvement
>Reporter: John Hutchison
>Priority: Minor
>  Labels: pull-request-available, redis
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-8583) create RestrictedInputValuesParameterRequirements in Redis Module

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-8583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210324#comment-17210324
 ] 

ASF GitHub Bot commented on GEODE-8583:
---

jhutchison commented on a change in pull request #5604:
URL: https://github.com/apache/geode/pull/5604#discussion_r501863115



##
File path: 
geode-redis/src/main/java/org/apache/geode/redis/internal/ParameterRequirements/RestrictedInputValuesParameterRequirements.java
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional 
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY 
KIND, either express
+ * or implied. See the License for the specific language governing permissions 
and limitations under
+ * the License.
+ */
+
+package org.apache.geode.redis.internal.ParameterRequirements;
+
+import java.util.List;
+
+import org.apache.geode.redis.internal.netty.Command;
+import org.apache.geode.redis.internal.netty.ExecutionHandlerContext;
+
+public class RestrictedInputValuesParameterRequirements implements 
ParameterRequirements {
+
+  List allowedValues = null;

Review comment:
   will do, thx





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> create RestrictedInputValuesParameterRequirements in Redis Module
> -
>
> Key: GEODE-8583
> URL: https://issues.apache.org/jira/browse/GEODE-8583
> Project: Geode
>  Issue Type: Improvement
>Reporter: John Hutchison
>Priority: Minor
>  Labels: pull-request-available, redis
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-8583) create RestrictedInputValuesParameterRequirements in Redis Module

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-8583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210325#comment-17210325
 ] 

ASF GitHub Bot commented on GEODE-8583:
---

jhutchison commented on a change in pull request #5604:
URL: https://github.com/apache/geode/pull/5604#discussion_r501864369



##
File path: 
geode-redis/src/main/java/org/apache/geode/redis/internal/ParameterRequirements/RestrictedInputValuesParameterRequirements.java
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional 
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY 
KIND, either express
+ * or implied. See the License for the specific language governing permissions 
and limitations under
+ * the License.
+ */
+
+package org.apache.geode.redis.internal.ParameterRequirements;
+
+import java.util.List;
+
+import org.apache.geode.redis.internal.netty.Command;
+import org.apache.geode.redis.internal.netty.ExecutionHandlerContext;
+
+public class RestrictedInputValuesParameterRequirements implements 
ParameterRequirements {
+
+  List allowedValues = null;
+
+  public RestrictedInputValuesParameterRequirements(List 
allowedValues) {

Review comment:
   So the reason I did this, was to allow the list of a parameters to exist 
as a constant, and allow that constant to be passed in when the command type is 
declared.  Didn't seem to work with the variable arg option (but that is how I 
had it before introducing the constant list of params)





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> create RestrictedInputValuesParameterRequirements in Redis Module
> -
>
> Key: GEODE-8583
> URL: https://issues.apache.org/jira/browse/GEODE-8583
> Project: Geode
>  Issue Type: Improvement
>Reporter: John Hutchison
>Priority: Minor
>  Labels: pull-request-available, redis
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-8583) create RestrictedInputValuesParameterRequirements in Redis Module

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-8583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210327#comment-17210327
 ] 

ASF GitHub Bot commented on GEODE-8583:
---

jhutchison commented on a change in pull request #5604:
URL: https://github.com/apache/geode/pull/5604#discussion_r501864551



##
File path: 
geode-redis/src/main/java/org/apache/geode/redis/internal/ParameterRequirements/RestrictedInputValuesParameterRequirements.java
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional 
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY 
KIND, either express
+ * or implied. See the License for the specific language governing permissions 
and limitations under
+ * the License.
+ */
+
+package org.apache.geode.redis.internal.ParameterRequirements;
+
+import java.util.List;
+
+import org.apache.geode.redis.internal.netty.Command;
+import org.apache.geode.redis.internal.netty.ExecutionHandlerContext;
+
+public class RestrictedInputValuesParameterRequirements implements 
ParameterRequirements {
+
+  List allowedValues = null;
+
+  public RestrictedInputValuesParameterRequirements(List 
allowedValues) {
+this.allowedValues = allowedValues;
+  }
+
+  @Override
+  public void checkParameters(Command command,
+  ExecutionHandlerContext executionHandlerContext) {
+List parameters = command.getProcessedCommand();
+String commandType = command.getCommandType().name();
+
+parameters.forEach(parameter -> {
+  String parameterString = parameter.toString();
+  if (isNotAllowed(parameterString) &&
+  !parameterString.equalsIgnoreCase(commandType)) {
+throw new RedisParametersMismatchException("");
+  }
+});
+  }
+
+  private boolean isNotAllowed(String parameterString) {
+return (allowedValues.contains(parameterString));

Review comment:
   probably.  Thanks





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> create RestrictedInputValuesParameterRequirements in Redis Module
> -
>
> Key: GEODE-8583
> URL: https://issues.apache.org/jira/browse/GEODE-8583
> Project: Geode
>  Issue Type: Improvement
>Reporter: John Hutchison
>Priority: Minor
>  Labels: pull-request-available, redis
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-8584) Message transmission fails with IllegalStateException in socket i/o code

[Bruce J Schuchardt (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-8584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210348#comment-17210348
 ] 

Bruce J Schuchardt commented on GEODE-8584:
---

Here is the crux of the problem:

{noformat}
[info 2020/10/07 15:54:20.931 PDT  tid=0x9e] 
BRUCE: acquired direct buffer 1a7301b8 of size 65536. requested size 65536 
from: [info 2020/10/07 15:54:20.931 PDT  
tid=0x9e] BRUCE: acquired direct buffer 1a7301b8 of size 65536. requested size 
65536 from:  
org.apache.geode.internal.net.BufferPool.acquireDirectSenderBuffer(BufferPool.java:92)
 
org.apache.geode.internal.net.BufferPool.acquireDirectBuffer(BufferPool.java:286)
 
org.apache.geode.internal.net.BufferPool.expandWriteBufferIfNeeded(BufferPool.java:270)
 
org.apache.geode.internal.net.NioSslEngine.expandWriteBuffer(NioSslEngine.java:212)

[info 2020/10/07 15:54:27.077 PDT :41002> tid=0x94] 
NioSSLEngine releasing two buffers myNetData=1a7301b8(direct), 
peerAppData=6fffd1b(direct)
[info 2020/10/07 15:54:27.077 PDT :41002> tid=0x94] BRUCE: 
releasing direct buffer 1a7301b8


[info 2020/10/07 15:54:27.078 PDT  tid=0xeb] 
Exception occurred while processing 
UpdateOperation(EntryEventImpl[op=UPDATE;region=/testRegion;key=85;callbackArg=null;originRemote=false;originMember=10.32.108.97(clientgemfire2_host1_10891:10891):41001;callbacksInvoked;version={v42;
 rv571; mbr=414d94d5780a4d72-b562d4269a59a785; ds=1; 
time=1602111267048};id=EventID[id=44 bytes;threadID=37;sequenceID=10]])
org.apache.geode.ToDataException: toData failed on dsfid=71 msg:null
at 
org.apache.geode.internal.InternalDataSerializer.writeDSFID(InternalDataSerializer.java:1509)
at 
org.apache.geode.internal.tcp.MsgStreamer.writeMessage(MsgStreamer.java:249)
at 
org.apache.geode.distributed.internal.direct.DirectChannel.sendToMany(DirectChannel.java:306)
{noformat}

The thread that's writing a serialized message to the socket is using the 
NioSslEngine's "myNetData" buffer.  Another thread is closing the connection 
and has invoked the NioFilter's close() method.  That method closes out the TLS 
session and modifies the "myNetData" buffer in the process.

> Message transmission fails with IllegalStateException in socket i/o code
> 
>
> Key: GEODE-8584
> URL: https://issues.apache.org/jira/browse/GEODE-8584
> Project: Geode
>  Issue Type: Bug
>  Components: membership, messaging
>Affects Versions: 1.12.0, 1.13.0, 1.14.0
>Reporter: Bruce J Schuchardt
>Priority: Major
>  Labels: pull-request-available
>
> Transmission of an update operation failed with a toData exception caused by 
> an IllegalStateException in socket i/o code.  It shouldn't be possible for 
> this exception to happen unless multiple threads are using the buffer at the 
> same time.
>  
> {noformat}
> org.apache.geode.ToDataException: toData failed on dsfid=71 msg:null
>   at 
> org.apache.geode.internal.InternalDataSerializer.writeDSFID(InternalDataSerializer.java:1509)
>   at 
> org.apache.geode.internal.tcp.MsgStreamer.writeMessage(MsgStreamer.java:249)
>   at 
> org.apache.geode.distributed.internal.direct.DirectChannel.sendToMany(DirectChannel.java:306)
>   at 
> org.apache.geode.distributed.internal.direct.DirectChannel.sendToOne(DirectChannel.java:182)
>   at 
> org.apache.geode.distributed.internal.direct.DirectChannel.send(DirectChannel.java:511)
>   at 
> org.apache.geode.distributed.internal.DistributionImpl.directChannelSend(DistributionImpl.java:346)
>   at 
> org.apache.geode.distributed.internal.DistributionImpl.send(DistributionImpl.java:291)
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendViaMembershipManager(ClusterDistributionManager.java:2053)
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendOutgoing(ClusterDistributionManager.java:1981)
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendMessage(ClusterDistributionManager.java:2018)
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.putOutgoing(ClusterDistributionManager.java:1083)
>   at 
> org.apache.geode.internal.cache.DistributedCacheOperation._distribute(DistributedCacheOperation.java:572)
>   at 
> org.apache.geode.internal.cache.DistributedCacheOperation.startOperation(DistributedCacheOperation.java:277)
>   at 
> org.apache.geode.internal.cache.DistributedCacheOperation.distribute(DistributedCacheOperation.java:318)
>   at 
> org.apache.geode.internal.cache.DistributedRegion.distributeUpdate(DistributedRegion.java:520)
>   at 
> org.apache.geode.internal.cache.DistributedRegion.basicPutPart3(DistributedRegion.java:498)
>   at 
> org.apache.geode.internal.cache.map.Region

[jira] [Created] (GEODE-8586) Redis SPOP with count on empty set returns NIL instead of empty array

[John Hutchison (Jira)]

John Hutchison created GEODE-8586:
-

 Summary: Redis SPOP with count on empty set returns NIL instead of 
empty array
 Key: GEODE-8586
 URL: https://issues.apache.org/jira/browse/GEODE-8586
 Project: Geode
  Issue Type: Bug
  Components: redis
Reporter: John Hutchison






--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-8584) Message transmission fails with IllegalStateException in socket i/o code

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-8584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210356#comment-17210356
 ] 

ASF GitHub Bot commented on GEODE-8584:
---

dschneider-pivotal commented on a change in pull request #5605:
URL: https://github.com/apache/geode/pull/5605#discussion_r501899913



##
File path: 
geode-core/src/main/java/org/apache/geode/internal/net/NioSslEngine.java
##
@@ -52,6 +53,11 @@
 public class NioSslEngine implements NioFilter {
   private static final Logger logger = LogService.getLogger();
 
+  // this variable requires the MakeImmutable annotation but the buffer is 
empty and
+  // not really modifiable
+  @MakeImmutable
+  private static final ByteBuffer EMPTY_BUFFER = ByteBuffer.allocate(0);

Review comment:
   did you consider adding ".asReadOnlyBuffer()" so that this would be 
immutable?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Message transmission fails with IllegalStateException in socket i/o code
> 
>
> Key: GEODE-8584
> URL: https://issues.apache.org/jira/browse/GEODE-8584
> Project: Geode
>  Issue Type: Bug
>  Components: membership, messaging
>Affects Versions: 1.12.0, 1.13.0, 1.14.0
>Reporter: Bruce J Schuchardt
>Priority: Major
>  Labels: pull-request-available
>
> Transmission of an update operation failed with a toData exception caused by 
> an IllegalStateException in socket i/o code.  It shouldn't be possible for 
> this exception to happen unless multiple threads are using the buffer at the 
> same time.
>  
> {noformat}
> org.apache.geode.ToDataException: toData failed on dsfid=71 msg:null
>   at 
> org.apache.geode.internal.InternalDataSerializer.writeDSFID(InternalDataSerializer.java:1509)
>   at 
> org.apache.geode.internal.tcp.MsgStreamer.writeMessage(MsgStreamer.java:249)
>   at 
> org.apache.geode.distributed.internal.direct.DirectChannel.sendToMany(DirectChannel.java:306)
>   at 
> org.apache.geode.distributed.internal.direct.DirectChannel.sendToOne(DirectChannel.java:182)
>   at 
> org.apache.geode.distributed.internal.direct.DirectChannel.send(DirectChannel.java:511)
>   at 
> org.apache.geode.distributed.internal.DistributionImpl.directChannelSend(DistributionImpl.java:346)
>   at 
> org.apache.geode.distributed.internal.DistributionImpl.send(DistributionImpl.java:291)
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendViaMembershipManager(ClusterDistributionManager.java:2053)
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendOutgoing(ClusterDistributionManager.java:1981)
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendMessage(ClusterDistributionManager.java:2018)
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.putOutgoing(ClusterDistributionManager.java:1083)
>   at 
> org.apache.geode.internal.cache.DistributedCacheOperation._distribute(DistributedCacheOperation.java:572)
>   at 
> org.apache.geode.internal.cache.DistributedCacheOperation.startOperation(DistributedCacheOperation.java:277)
>   at 
> org.apache.geode.internal.cache.DistributedCacheOperation.distribute(DistributedCacheOperation.java:318)
>   at 
> org.apache.geode.internal.cache.DistributedRegion.distributeUpdate(DistributedRegion.java:520)
>   at 
> org.apache.geode.internal.cache.DistributedRegion.basicPutPart3(DistributedRegion.java:498)
>   at 
> org.apache.geode.internal.cache.map.RegionMapPut.doAfterCompletionActions(RegionMapPut.java:307)
>   at 
> org.apache.geode.internal.cache.map.AbstractRegionMapPut.doPut(AbstractRegionMapPut.java:185)
>   at 
> org.apache.geode.internal.cache.map.AbstractRegionMapPut.runWhileLockedForCacheModification(AbstractRegionMapPut.java:119)
>   at 
> org.apache.geode.internal.cache.map.RegionMapPut.runWhileLockedForCacheModification(RegionMapPut.java:161)
>   at 
> org.apache.geode.internal.cache.map.AbstractRegionMapPut.put(AbstractRegionMapPut.java:169)
>   at 
> org.apache.geode.internal.cache.AbstractRegionMap.basicPut(AbstractRegionMap.java:2044)
>   at 
> org.apache.geode.internal.cache.LocalRegion.virtualPut(LocalRegion.java:5599)
>   at 
> org.apache.geode.internal.cache.DistributedRegion.virtualPut(DistributedRegion.java:393)
>   at 
> org.apache.geode.internal.cache.LocalRegion.virtualPut(LocalRegion.java:5577)
>   at 
> org.apache.geode.internal.cache.LocalRegion

[jira] [Commented] (GEODE-8574) ClassCastException when hitting members REST endpoint

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-8574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210361#comment-17210361
 ] 

ASF subversion and git services commented on GEODE-8574:


Commit 45d484b7808c9f290a9742aa7cc3feb0153a766b in geode's branch 
refs/heads/support/1.13 from Jinmei Liao
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=45d484b ]

GEODE-8574: ClusterManagementService should not throw ClassCastExcept… (#5596)

(cherry picked from commit 73f6783b07f1151c1617978fb57822ade5b71414)


> ClassCastException when hitting members REST endpoint
> -
>
> Key: GEODE-8574
> URL: https://issues.apache.org/jira/browse/GEODE-8574
> Project: Geode
>  Issue Type: Improvement
>  Components: rest (admin)
>Affects Versions: 1.13.0
>Reporter: Jason Huynh
>Assignee: Jinmei Liao
>Priority: Major
>  Labels: GeodeOperationAPI, pull-request-available
> Fix For: 1.14.0
>
>
> This might be similar to https://issues.apache.org/jira/browse/GEODE-8078
> We see a FunctionInvocationTargetException when trying to use the rest 
> endpoint while servers are restarting/recovering
> [error 2020/10/01 21:49:57.381 GMT  tid=0x46] class 
> org.apache.geode.cache.execute.FunctionInvocationTargetException cannot be 
> cast to class org.apache.geode.management.runtime.RuntimeInfo 
> (org.apache.geode.cache.execute.FunctionInvocationTargetException and 
> org.apache.geode.management.runtime.RuntimeInfo are in unnamed module of 
> loader 'app')
> java.lang.ClassCastException: class 
> org.apache.geode.cache.execute.FunctionInvocationTargetException cannot be 
> cast to class org.apache.geode.management.runtime.RuntimeInfo 
> (org.apache.geode.cache.execute.FunctionInvocationTargetException and 
> org.apache.geode.management.runtime.RuntimeInfo are in unnamed module of 
> loader 'app')
> at 
> org.apache.geode.management.internal.api.LocatorClusterManagementService.list(LocatorClusterManagementService.java:459)
> at 
> org.apache.geode.management.internal.api.LocatorClusterManagementService.get(LocatorClusterManagementService.java:476)
> at 
> org.apache.geode.management.internal.rest.controllers.MemberManagementController.getMember(MemberManagementController.java:50)
> at 
> org.apache.geode.management.internal.rest.controllers.MemberManagementController$$FastClassBySpringCGLIB$$3634e452.invoke()
> at org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:218)
> at 
> org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.invokeJoinpoint(CglibAopProxy.java:771)
> at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163)
> at 
> org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:749)
> at 
> org.springframework.security.access.intercept.aopalliance.MethodSecurityInterceptor.invoke(MethodSecurityInterceptor.java:61)
> at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186)
> at 
> org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:749)
> at 
> org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:691)
> at 
> org.apache.geode.management.internal.rest.controllers.MemberManagementController$$EnhancerBySpringCGLIB$$ef2756b6.getMember()
> at jdk.internal.reflect.GeneratedMethodAccessor237.invoke(Unknown Source)
> at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:566)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-8574) ClassCastException when hitting members REST endpoint

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-8574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210360#comment-17210360
 ] 

ASF subversion and git services commented on GEODE-8574:


Commit 45d484b7808c9f290a9742aa7cc3feb0153a766b in geode's branch 
refs/heads/support/1.13 from Jinmei Liao
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=45d484b ]

GEODE-8574: ClusterManagementService should not throw ClassCastExcept… (#5596)

(cherry picked from commit 73f6783b07f1151c1617978fb57822ade5b71414)


> ClassCastException when hitting members REST endpoint
> -
>
> Key: GEODE-8574
> URL: https://issues.apache.org/jira/browse/GEODE-8574
> Project: Geode
>  Issue Type: Improvement
>  Components: rest (admin)
>Affects Versions: 1.13.0
>Reporter: Jason Huynh
>Assignee: Jinmei Liao
>Priority: Major
>  Labels: GeodeOperationAPI, pull-request-available
> Fix For: 1.14.0
>
>
> This might be similar to https://issues.apache.org/jira/browse/GEODE-8078
> We see a FunctionInvocationTargetException when trying to use the rest 
> endpoint while servers are restarting/recovering
> [error 2020/10/01 21:49:57.381 GMT  tid=0x46] class 
> org.apache.geode.cache.execute.FunctionInvocationTargetException cannot be 
> cast to class org.apache.geode.management.runtime.RuntimeInfo 
> (org.apache.geode.cache.execute.FunctionInvocationTargetException and 
> org.apache.geode.management.runtime.RuntimeInfo are in unnamed module of 
> loader 'app')
> java.lang.ClassCastException: class 
> org.apache.geode.cache.execute.FunctionInvocationTargetException cannot be 
> cast to class org.apache.geode.management.runtime.RuntimeInfo 
> (org.apache.geode.cache.execute.FunctionInvocationTargetException and 
> org.apache.geode.management.runtime.RuntimeInfo are in unnamed module of 
> loader 'app')
> at 
> org.apache.geode.management.internal.api.LocatorClusterManagementService.list(LocatorClusterManagementService.java:459)
> at 
> org.apache.geode.management.internal.api.LocatorClusterManagementService.get(LocatorClusterManagementService.java:476)
> at 
> org.apache.geode.management.internal.rest.controllers.MemberManagementController.getMember(MemberManagementController.java:50)
> at 
> org.apache.geode.management.internal.rest.controllers.MemberManagementController$$FastClassBySpringCGLIB$$3634e452.invoke()
> at org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:218)
> at 
> org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.invokeJoinpoint(CglibAopProxy.java:771)
> at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163)
> at 
> org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:749)
> at 
> org.springframework.security.access.intercept.aopalliance.MethodSecurityInterceptor.invoke(MethodSecurityInterceptor.java:61)
> at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186)
> at 
> org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:749)
> at 
> org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:691)
> at 
> org.apache.geode.management.internal.rest.controllers.MemberManagementController$$EnhancerBySpringCGLIB$$ef2756b6.getMember()
> at jdk.internal.reflect.GeneratedMethodAccessor237.invoke(Unknown Source)
> at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:566)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (GEODE-8587) Redis glob pattern does not match carriage return, line feed, and tab

[Sarah Abbey (Jira)]

Sarah Abbey created GEODE-8587:
--

 Summary: Redis glob pattern does not match carriage return, line 
feed, and tab
 Key: GEODE-8587
 URL: https://issues.apache.org/jira/browse/GEODE-8587
 Project: Geode
  Issue Type: Bug
  Components: redis
Reporter: Sarah Abbey


Glob pattern should match carriage return, line feed, and tab



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Assigned] (GEODE-8587) Redis glob pattern does not match carriage return, line feed, and tab

[Sarah Abbey (Jira)]

 [ 
https://issues.apache.org/jira/browse/GEODE-8587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sarah Abbey reassigned GEODE-8587:
--

Assignee: Sarah Abbey

> Redis glob pattern does not match carriage return, line feed, and tab
> -
>
> Key: GEODE-8587
> URL: https://issues.apache.org/jira/browse/GEODE-8587
> Project: Geode
>  Issue Type: Bug
>  Components: redis
>Reporter: Sarah Abbey
>Assignee: Sarah Abbey
>Priority: Major
>
> Glob pattern should match carriage return, line feed, and tab



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-8584) Message transmission fails with IllegalStateException in socket i/o code

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-8584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210374#comment-17210374
 ] 

ASF GitHub Bot commented on GEODE-8584:
---

Bill commented on a change in pull request #5605:
URL: https://github.com/apache/geode/pull/5605#discussion_r501922128



##
File path: 
geode-core/src/main/java/org/apache/geode/internal/net/NioSslEngine.java
##
@@ -52,6 +53,11 @@
 public class NioSslEngine implements NioFilter {
   private static final Logger logger = LogService.getLogger();
 
+  // this variable requires the MakeImmutable annotation but the buffer is 
empty and
+  // not really modifiable
+  @MakeImmutable
+  private static final ByteBuffer EMPTY_BUFFER = ByteBuffer.allocate(0);

Review comment:
   That won't satisfy PMD (since it returns a `ByteBuffer` which is not 
considered an immutable object by PMD) but it still might be valuable.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Message transmission fails with IllegalStateException in socket i/o code
> 
>
> Key: GEODE-8584
> URL: https://issues.apache.org/jira/browse/GEODE-8584
> Project: Geode
>  Issue Type: Bug
>  Components: membership, messaging
>Affects Versions: 1.12.0, 1.13.0, 1.14.0
>Reporter: Bruce J Schuchardt
>Priority: Major
>  Labels: pull-request-available
>
> Transmission of an update operation failed with a toData exception caused by 
> an IllegalStateException in socket i/o code.  It shouldn't be possible for 
> this exception to happen unless multiple threads are using the buffer at the 
> same time.
>  
> {noformat}
> org.apache.geode.ToDataException: toData failed on dsfid=71 msg:null
>   at 
> org.apache.geode.internal.InternalDataSerializer.writeDSFID(InternalDataSerializer.java:1509)
>   at 
> org.apache.geode.internal.tcp.MsgStreamer.writeMessage(MsgStreamer.java:249)
>   at 
> org.apache.geode.distributed.internal.direct.DirectChannel.sendToMany(DirectChannel.java:306)
>   at 
> org.apache.geode.distributed.internal.direct.DirectChannel.sendToOne(DirectChannel.java:182)
>   at 
> org.apache.geode.distributed.internal.direct.DirectChannel.send(DirectChannel.java:511)
>   at 
> org.apache.geode.distributed.internal.DistributionImpl.directChannelSend(DistributionImpl.java:346)
>   at 
> org.apache.geode.distributed.internal.DistributionImpl.send(DistributionImpl.java:291)
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendViaMembershipManager(ClusterDistributionManager.java:2053)
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendOutgoing(ClusterDistributionManager.java:1981)
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendMessage(ClusterDistributionManager.java:2018)
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.putOutgoing(ClusterDistributionManager.java:1083)
>   at 
> org.apache.geode.internal.cache.DistributedCacheOperation._distribute(DistributedCacheOperation.java:572)
>   at 
> org.apache.geode.internal.cache.DistributedCacheOperation.startOperation(DistributedCacheOperation.java:277)
>   at 
> org.apache.geode.internal.cache.DistributedCacheOperation.distribute(DistributedCacheOperation.java:318)
>   at 
> org.apache.geode.internal.cache.DistributedRegion.distributeUpdate(DistributedRegion.java:520)
>   at 
> org.apache.geode.internal.cache.DistributedRegion.basicPutPart3(DistributedRegion.java:498)
>   at 
> org.apache.geode.internal.cache.map.RegionMapPut.doAfterCompletionActions(RegionMapPut.java:307)
>   at 
> org.apache.geode.internal.cache.map.AbstractRegionMapPut.doPut(AbstractRegionMapPut.java:185)
>   at 
> org.apache.geode.internal.cache.map.AbstractRegionMapPut.runWhileLockedForCacheModification(AbstractRegionMapPut.java:119)
>   at 
> org.apache.geode.internal.cache.map.RegionMapPut.runWhileLockedForCacheModification(RegionMapPut.java:161)
>   at 
> org.apache.geode.internal.cache.map.AbstractRegionMapPut.put(AbstractRegionMapPut.java:169)
>   at 
> org.apache.geode.internal.cache.AbstractRegionMap.basicPut(AbstractRegionMap.java:2044)
>   at 
> org.apache.geode.internal.cache.LocalRegion.virtualPut(LocalRegion.java:5599)
>   at 
> org.apache.geode.internal.cache.DistributedRegion.virtualPut(DistributedRegion.java:393)
>   at 
> org.apache.geode.internal.cache.LocalRegion.virtualPut(LocalRegion.java:5577)
>   at

[jira] [Updated] (GEODE-8587) Redis glob pattern does not match carriage return, line feed, and tab

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/GEODE-8587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated GEODE-8587:
--
Labels: pull-request-available  (was: )

> Redis glob pattern does not match carriage return, line feed, and tab
> -
>
> Key: GEODE-8587
> URL: https://issues.apache.org/jira/browse/GEODE-8587
> Project: Geode
>  Issue Type: Bug
>  Components: redis
>Reporter: Sarah Abbey
>Assignee: Sarah Abbey
>Priority: Major
>  Labels: pull-request-available
>
> Glob pattern should match carriage return, line feed, and tab



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-8587) Redis glob pattern does not match carriage return, line feed, and tab

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-8587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210375#comment-17210375
 ] 

ASF GitHub Bot commented on GEODE-8587:
---

sabbey37 opened a new pull request #5608:
URL: https://github.com/apache/geode/pull/5608


   Glob pattern should match carriage return, line feed, and tab
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Redis glob pattern does not match carriage return, line feed, and tab
> -
>
> Key: GEODE-8587
> URL: https://issues.apache.org/jira/browse/GEODE-8587
> Project: Geode
>  Issue Type: Bug
>  Components: redis
>Reporter: Sarah Abbey
>Assignee: Sarah Abbey
>Priority: Major
>
> Glob pattern should match carriage return, line feed, and tab



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-8583) create RestrictedInputValuesParameterRequirements in Redis Module

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-8583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210394#comment-17210394
 ] 

ASF GitHub Bot commented on GEODE-8583:
---

dschneider-pivotal commented on a change in pull request #5604:
URL: https://github.com/apache/geode/pull/5604#discussion_r501946115



##
File path: 
geode-redis/src/main/java/org/apache/geode/redis/internal/ParameterRequirements/RestrictedInputValuesParameterRequirements.java
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional 
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY 
KIND, either express
+ * or implied. See the License for the specific language governing permissions 
and limitations under
+ * the License.
+ */
+
+package org.apache.geode.redis.internal.ParameterRequirements;
+
+import java.util.List;
+
+import org.apache.geode.redis.internal.netty.Command;
+import org.apache.geode.redis.internal.netty.ExecutionHandlerContext;
+
+public class RestrictedInputValuesParameterRequirements implements 
ParameterRequirements {
+
+  List allowedValues = null;
+
+  public RestrictedInputValuesParameterRequirements(List 
allowedValues) {
+this.allowedValues = allowedValues;
+  }
+
+  @Override
+  public void checkParameters(Command command,
+  ExecutionHandlerContext executionHandlerContext) {
+List parameters = command.getProcessedCommand();
+String commandType = command.getCommandType().name();
+
+parameters.forEach(parameter -> {
+  String parameterString = parameter.toString();
+  if (isNotAllowed(parameterString) &&
+  !parameterString.equalsIgnoreCase(commandType)) {

Review comment:
   I should have looked at the diffs with the commit history, my bad for 
not doing so, that is a good way to address this. 





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> create RestrictedInputValuesParameterRequirements in Redis Module
> -
>
> Key: GEODE-8583
> URL: https://issues.apache.org/jira/browse/GEODE-8583
> Project: Geode
>  Issue Type: Improvement
>Reporter: John Hutchison
>Priority: Minor
>  Labels: pull-request-available, redis
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-8565) c++ client tries to connect to down server until IO error is thrown

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-8565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210400#comment-17210400
 ] 

ASF GitHub Bot commented on GEODE-8565:
---

pdxcodemonkey commented on pull request #662:
URL: https://github.com/apache/geode-native/pull/662#issuecomment-705764533


   @alb3rtobr The build fix has a clangformat issue, sorry.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> c++ client tries to connect to down server until IO error is thrown
> ---
>
> Key: GEODE-8565
> URL: https://issues.apache.org/jira/browse/GEODE-8565
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Alberto Bustamante Reyes
>Assignee: Alberto Bustamante Reyes
>Priority: Major
>  Labels: pull-request-available
>
> This ticket is an improvement over GEODE-8231:
> {quote}If a C++ client connected to a cluster is sending operations to a 
> partitioned region and one of the server goes down, the client keeps trying 
> to send operations to the down server. This can be observed in the logs by a 
> continuous flow of lines containing: "IO error in handshake with endpoint..."
> {quote}
> After that improvement, the c++ client removes the metadata info of the 
> failing server once the "IO error in handshake" is received.
> But it has been observed that before that error is received, "timeout error" 
> can be returned. So the client will try to reconnect until the "IO error in 
> handshake" is received.
> This ticket aims to extend the GEODE-8231 solution so the client removes the 
> server metadata information when a timeout is received.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-8565) c++ client tries to connect to down server until IO error is thrown

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-8565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210403#comment-17210403
 ] 

ASF GitHub Bot commented on GEODE-8565:
---

alb3rtobr commented on pull request #662:
URL: https://github.com/apache/geode-native/pull/662#issuecomment-705768480


   > @alb3rtobr The build fix has a clangformat issue, sorry.
   
   I hate when this happens.. sorry! 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> c++ client tries to connect to down server until IO error is thrown
> ---
>
> Key: GEODE-8565
> URL: https://issues.apache.org/jira/browse/GEODE-8565
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Alberto Bustamante Reyes
>Assignee: Alberto Bustamante Reyes
>Priority: Major
>  Labels: pull-request-available
>
> This ticket is an improvement over GEODE-8231:
> {quote}If a C++ client connected to a cluster is sending operations to a 
> partitioned region and one of the server goes down, the client keeps trying 
> to send operations to the down server. This can be observed in the logs by a 
> continuous flow of lines containing: "IO error in handshake with endpoint..."
> {quote}
> After that improvement, the c++ client removes the metadata info of the 
> failing server once the "IO error in handshake" is received.
> But it has been observed that before that error is received, "timeout error" 
> can be returned. So the client will try to reconnect until the "IO error in 
> handshake" is received.
> This ticket aims to extend the GEODE-8231 solution so the client removes the 
> server metadata information when a timeout is received.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-8586) Redis SPOP with count on empty set returns NIL instead of empty array

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-8586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210430#comment-17210430
 ] 

ASF GitHub Bot commented on GEODE-8586:
---

jhutchison opened a new pull request #5609:
URL: https://github.com/apache/geode/pull/5609


   … empty array
   
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, check Concourse for build 
issues and
   submit an update to your PR as soon as possible. If you need help, please 
send an
   email to d...@geode.apache.org.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Redis SPOP with count on empty set returns NIL instead of empty array
> -
>
> Key: GEODE-8586
> URL: https://issues.apache.org/jira/browse/GEODE-8586
> Project: Geode
>  Issue Type: Bug
>  Components: redis
>Reporter: John Hutchison
>Priority: Major
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (GEODE-8586) Redis SPOP with count on empty set returns NIL instead of empty array

[ASF GitHub Bot (Jira)]

 [ 
https://issues.apache.org/jira/browse/GEODE-8586?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated GEODE-8586:
--
Labels: pull-request-available  (was: )

> Redis SPOP with count on empty set returns NIL instead of empty array
> -
>
> Key: GEODE-8586
> URL: https://issues.apache.org/jira/browse/GEODE-8586
> Project: Geode
>  Issue Type: Bug
>  Components: redis
>Reporter: John Hutchison
>Priority: Major
>  Labels: pull-request-available
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-8512) Be able to specify 'expectDomainClass' when calling createPdxInstanceFactory

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-8512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210442#comment-17210442
 ] 

ASF GitHub Bot commented on GEODE-8512:
---

gaussianrecurrence commented on a change in pull request #661:
URL: https://github.com/apache/geode-native/pull/661#discussion_r501994956



##
File path: cppcache/integration/test/PdxJsonTypeTest.cpp
##
@@ -68,6 +68,32 @@ std::shared_ptr setupRegion(Cache& cache) {
   return region;
 }
 
+TEST(PdxJsonTypeTest, testGfshQueryJsonInstances) {
+  Cluster cluster{LocatorCount{1}, ServerCount{1}};
+  cluster.start();
+
+  auto& gfsh = cluster.getGfsh();
+  gfsh.create().region().withName("region").withType("REPLICATE").execute();
+
+  auto cache = cluster.createCache();
+  auto region = setupRegion(cache);
+  const std::string query_stmt{"SELECT * FROM /region"};
+
+  region->put("non-java-domain-class-entry",
+  cache.createPdxInstanceFactory(gemfireJsonClassName, false)
+  .writeString("foo", "bar")
+  .create());
+
+  EXPECT_NO_THROW(gfsh.query(query_stmt).execute());
+
+  region->put("java-domain-class-entry",
+  cache.createPdxInstanceFactory(gemfireJsonClassName)
+  .writeString("foo", "bar")
+  .create());
+
+  EXPECT_THROW(gfsh.query(query_stmt).execute(), GfshExecuteException);

Review comment:
   Ok, so I've been going throught the query engine code of the server and 
finally located the problem.
   As I feared org.apache.geode.cache.query.internal.Bag addAndGetOccurence 
method uses mapGet on the different objects added, and PdxInstanceImpl hash is 
not considering noJavaDomainClass attribute and neither is the equals operator 
therefore all PdxInstanceImpl with the same hash that are equals as of equals 
operator are not added but instead the previous existing copy inside bag is 
duplicated.
   Now the question, and here is where I need your help, is: "Is this a bug or 
a feature?" 
   Because as of my point of view is a bug, but there might be many more 
implications than the one I am able to see.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Be able to specify 'expectDomainClass' when calling createPdxInstanceFactory
> 
>
> Key: GEODE-8512
> URL: https://issues.apache.org/jira/browse/GEODE-8512
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Affects Versions: 1.13.0
>Reporter: Mario Salazar de Torres
>Assignee: Mario Salazar de Torres
>Priority: Minor
>  Labels: JsonFormatter, pull-request-available
>
> Within Java client, you can specify if the PdxInstance you want to create is 
> a Java domain class or not, but this is not the case for geode-native C++ 
> client.
> Thing is that in order to implement JsonFormatter in C++ client, having this 
> change is mandatory, otherwise creating PdxType's with __GEMFIRE_JSON 
> classname will present some issues while using cquery's.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-8583) create RestrictedInputValuesParameterRequirements in Redis Module

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-8583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210448#comment-17210448
 ] 

ASF GitHub Bot commented on GEODE-8583:
---

jhutchison commented on a change in pull request #5604:
URL: https://github.com/apache/geode/pull/5604#discussion_r502004821



##
File path: 
geode-redis/src/main/java/org/apache/geode/redis/internal/ParameterRequirements/RestrictedInputValuesParameterRequirements.java
##
@@ -0,0 +1,49 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional 
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY 
KIND, either express
+ * or implied. See the License for the specific language governing permissions 
and limitations under
+ * the License.
+ */
+
+package org.apache.geode.redis.internal.ParameterRequirements;
+
+import java.util.List;
+
+import org.apache.geode.redis.internal.netty.Command;
+import org.apache.geode.redis.internal.netty.ExecutionHandlerContext;
+
+public class RestrictedInputValuesParameterRequirements implements 
ParameterRequirements {
+
+  List allowedValues = null;
+
+  public RestrictedInputValuesParameterRequirements(List 
allowedValues) {
+this.allowedValues = allowedValues;
+  }
+
+  @Override
+  public void checkParameters(Command command,
+  ExecutionHandlerContext executionHandlerContext) {
+List parameters = command.getProcessedCommand();
+String commandType = command.getCommandType().name();
+
+parameters.forEach(parameter -> {
+  String parameterString = parameter.toString();
+  if (isNotAllowed(parameterString) &&
+  !parameterString.equalsIgnoreCase(commandType)) {

Review comment:
   looks like I also included some left over gemfire servers in one of the 
commits too :).  





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> create RestrictedInputValuesParameterRequirements in Redis Module
> -
>
> Key: GEODE-8583
> URL: https://issues.apache.org/jira/browse/GEODE-8583
> Project: Geode
>  Issue Type: Improvement
>Reporter: John Hutchison
>Priority: Minor
>  Labels: pull-request-available, redis
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-8584) Message transmission fails with IllegalStateException in socket i/o code

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-8584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210458#comment-17210458
 ] 

ASF GitHub Bot commented on GEODE-8584:
---

bschuchardt merged pull request #5605:
URL: https://github.com/apache/geode/pull/5605


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Message transmission fails with IllegalStateException in socket i/o code
> 
>
> Key: GEODE-8584
> URL: https://issues.apache.org/jira/browse/GEODE-8584
> Project: Geode
>  Issue Type: Bug
>  Components: membership, messaging
>Affects Versions: 1.12.0, 1.13.0, 1.14.0
>Reporter: Bruce J Schuchardt
>Priority: Major
>  Labels: pull-request-available
>
> Transmission of an update operation failed with a toData exception caused by 
> an IllegalStateException in socket i/o code.  It shouldn't be possible for 
> this exception to happen unless multiple threads are using the buffer at the 
> same time.
>  
> {noformat}
> org.apache.geode.ToDataException: toData failed on dsfid=71 msg:null
>   at 
> org.apache.geode.internal.InternalDataSerializer.writeDSFID(InternalDataSerializer.java:1509)
>   at 
> org.apache.geode.internal.tcp.MsgStreamer.writeMessage(MsgStreamer.java:249)
>   at 
> org.apache.geode.distributed.internal.direct.DirectChannel.sendToMany(DirectChannel.java:306)
>   at 
> org.apache.geode.distributed.internal.direct.DirectChannel.sendToOne(DirectChannel.java:182)
>   at 
> org.apache.geode.distributed.internal.direct.DirectChannel.send(DirectChannel.java:511)
>   at 
> org.apache.geode.distributed.internal.DistributionImpl.directChannelSend(DistributionImpl.java:346)
>   at 
> org.apache.geode.distributed.internal.DistributionImpl.send(DistributionImpl.java:291)
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendViaMembershipManager(ClusterDistributionManager.java:2053)
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendOutgoing(ClusterDistributionManager.java:1981)
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendMessage(ClusterDistributionManager.java:2018)
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.putOutgoing(ClusterDistributionManager.java:1083)
>   at 
> org.apache.geode.internal.cache.DistributedCacheOperation._distribute(DistributedCacheOperation.java:572)
>   at 
> org.apache.geode.internal.cache.DistributedCacheOperation.startOperation(DistributedCacheOperation.java:277)
>   at 
> org.apache.geode.internal.cache.DistributedCacheOperation.distribute(DistributedCacheOperation.java:318)
>   at 
> org.apache.geode.internal.cache.DistributedRegion.distributeUpdate(DistributedRegion.java:520)
>   at 
> org.apache.geode.internal.cache.DistributedRegion.basicPutPart3(DistributedRegion.java:498)
>   at 
> org.apache.geode.internal.cache.map.RegionMapPut.doAfterCompletionActions(RegionMapPut.java:307)
>   at 
> org.apache.geode.internal.cache.map.AbstractRegionMapPut.doPut(AbstractRegionMapPut.java:185)
>   at 
> org.apache.geode.internal.cache.map.AbstractRegionMapPut.runWhileLockedForCacheModification(AbstractRegionMapPut.java:119)
>   at 
> org.apache.geode.internal.cache.map.RegionMapPut.runWhileLockedForCacheModification(RegionMapPut.java:161)
>   at 
> org.apache.geode.internal.cache.map.AbstractRegionMapPut.put(AbstractRegionMapPut.java:169)
>   at 
> org.apache.geode.internal.cache.AbstractRegionMap.basicPut(AbstractRegionMap.java:2044)
>   at 
> org.apache.geode.internal.cache.LocalRegion.virtualPut(LocalRegion.java:5599)
>   at 
> org.apache.geode.internal.cache.DistributedRegion.virtualPut(DistributedRegion.java:393)
>   at 
> org.apache.geode.internal.cache.LocalRegion.virtualPut(LocalRegion.java:5577)
>   at 
> org.apache.geode.internal.cache.LocalRegionDataView.putEntry(LocalRegionDataView.java:157)
>   at 
> org.apache.geode.internal.cache.LocalRegion.basicPut(LocalRegion.java:5035)
>   at 
> org.apache.geode.internal.cache.LocalRegion.replaceWithCallbackArgument(LocalRegion.java:10600)
>   at 
> org.apache.geode.internal.cache.LocalRegion.replace(LocalRegion.java:10566)
> [application code traces deleted]
> Caused by: java.lang.IllegalArgumentException
>   at java.nio.Buffer.position(Buffer.java:244)
>   at sun.nio.ch.IOUtil.writeFromNativeBuffer(IOUtil.java:96)
>   at sun.nio.ch.IOUtil.write(IOUtil.java:51

[jira] [Resolved] (GEODE-8584) Message transmission fails with IllegalStateException in socket i/o code

[Bruce J Schuchardt (Jira)]

 [ 
https://issues.apache.org/jira/browse/GEODE-8584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bruce J Schuchardt resolved GEODE-8584.
---
Fix Version/s: 1.14.0
   Resolution: Fixed

> Message transmission fails with IllegalStateException in socket i/o code
> 
>
> Key: GEODE-8584
> URL: https://issues.apache.org/jira/browse/GEODE-8584
> Project: Geode
>  Issue Type: Bug
>  Components: membership, messaging
>Affects Versions: 1.12.0, 1.13.0, 1.14.0
>Reporter: Bruce J Schuchardt
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> Transmission of an update operation failed with a toData exception caused by 
> an IllegalStateException in socket i/o code.  It shouldn't be possible for 
> this exception to happen unless multiple threads are using the buffer at the 
> same time.
>  
> {noformat}
> org.apache.geode.ToDataException: toData failed on dsfid=71 msg:null
>   at 
> org.apache.geode.internal.InternalDataSerializer.writeDSFID(InternalDataSerializer.java:1509)
>   at 
> org.apache.geode.internal.tcp.MsgStreamer.writeMessage(MsgStreamer.java:249)
>   at 
> org.apache.geode.distributed.internal.direct.DirectChannel.sendToMany(DirectChannel.java:306)
>   at 
> org.apache.geode.distributed.internal.direct.DirectChannel.sendToOne(DirectChannel.java:182)
>   at 
> org.apache.geode.distributed.internal.direct.DirectChannel.send(DirectChannel.java:511)
>   at 
> org.apache.geode.distributed.internal.DistributionImpl.directChannelSend(DistributionImpl.java:346)
>   at 
> org.apache.geode.distributed.internal.DistributionImpl.send(DistributionImpl.java:291)
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendViaMembershipManager(ClusterDistributionManager.java:2053)
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendOutgoing(ClusterDistributionManager.java:1981)
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendMessage(ClusterDistributionManager.java:2018)
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.putOutgoing(ClusterDistributionManager.java:1083)
>   at 
> org.apache.geode.internal.cache.DistributedCacheOperation._distribute(DistributedCacheOperation.java:572)
>   at 
> org.apache.geode.internal.cache.DistributedCacheOperation.startOperation(DistributedCacheOperation.java:277)
>   at 
> org.apache.geode.internal.cache.DistributedCacheOperation.distribute(DistributedCacheOperation.java:318)
>   at 
> org.apache.geode.internal.cache.DistributedRegion.distributeUpdate(DistributedRegion.java:520)
>   at 
> org.apache.geode.internal.cache.DistributedRegion.basicPutPart3(DistributedRegion.java:498)
>   at 
> org.apache.geode.internal.cache.map.RegionMapPut.doAfterCompletionActions(RegionMapPut.java:307)
>   at 
> org.apache.geode.internal.cache.map.AbstractRegionMapPut.doPut(AbstractRegionMapPut.java:185)
>   at 
> org.apache.geode.internal.cache.map.AbstractRegionMapPut.runWhileLockedForCacheModification(AbstractRegionMapPut.java:119)
>   at 
> org.apache.geode.internal.cache.map.RegionMapPut.runWhileLockedForCacheModification(RegionMapPut.java:161)
>   at 
> org.apache.geode.internal.cache.map.AbstractRegionMapPut.put(AbstractRegionMapPut.java:169)
>   at 
> org.apache.geode.internal.cache.AbstractRegionMap.basicPut(AbstractRegionMap.java:2044)
>   at 
> org.apache.geode.internal.cache.LocalRegion.virtualPut(LocalRegion.java:5599)
>   at 
> org.apache.geode.internal.cache.DistributedRegion.virtualPut(DistributedRegion.java:393)
>   at 
> org.apache.geode.internal.cache.LocalRegion.virtualPut(LocalRegion.java:5577)
>   at 
> org.apache.geode.internal.cache.LocalRegionDataView.putEntry(LocalRegionDataView.java:157)
>   at 
> org.apache.geode.internal.cache.LocalRegion.basicPut(LocalRegion.java:5035)
>   at 
> org.apache.geode.internal.cache.LocalRegion.replaceWithCallbackArgument(LocalRegion.java:10600)
>   at 
> org.apache.geode.internal.cache.LocalRegion.replace(LocalRegion.java:10566)
> [application code traces deleted]
> Caused by: java.lang.IllegalArgumentException
>   at java.nio.Buffer.position(Buffer.java:244)
>   at sun.nio.ch.IOUtil.writeFromNativeBuffer(IOUtil.java:96)
>   at sun.nio.ch.IOUtil.write(IOUtil.java:51)
>   at sun.nio.ch.SocketChannelImpl.write(SocketChannelImpl.java:469)
>   at 
> org.apache.geode.internal.tcp.Connection.writeFully(Connection.java:2596)
>   at 
> org.apache.geode.internal.tcp.Connection.sendPreserialized(Connection.java:1866)
>   at 
> org.apache.geode.internal.tcp.MsgStreamer.realFlush(MsgStreamer.java:330)
>   at org.apache.geode.in

[jira] [Commented] (GEODE-8584) Message transmission fails with IllegalStateException in socket i/o code

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-8584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210459#comment-17210459
 ] 

ASF subversion and git services commented on GEODE-8584:


Commit f4d44d658a6273d7de27479a67c05117310205a7 in geode's branch 
refs/heads/develop from Bruce Schuchardt
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=f4d44d6 ]

GEODE-8584: Message transmission fails with IllegalStateException in socket i/o 
code (#5605)

* GEODE-8584: Message transmission fails with IllegalStateException in socket 
i/o code

Add appropriate synchronization when using ioFilter's buffers.
to do: add testing
to do: document the need for synchronization in the NioFilter interface.

* revised synchronization across all uses of NioFilter, added test

* remove dangling debug logging

* fix pmd problem

* fix pmd problem

* remove unnecessary volatile modifier

> Message transmission fails with IllegalStateException in socket i/o code
> 
>
> Key: GEODE-8584
> URL: https://issues.apache.org/jira/browse/GEODE-8584
> Project: Geode
>  Issue Type: Bug
>  Components: membership, messaging
>Affects Versions: 1.12.0, 1.13.0, 1.14.0
>Reporter: Bruce J Schuchardt
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> Transmission of an update operation failed with a toData exception caused by 
> an IllegalStateException in socket i/o code.  It shouldn't be possible for 
> this exception to happen unless multiple threads are using the buffer at the 
> same time.
>  
> {noformat}
> org.apache.geode.ToDataException: toData failed on dsfid=71 msg:null
>   at 
> org.apache.geode.internal.InternalDataSerializer.writeDSFID(InternalDataSerializer.java:1509)
>   at 
> org.apache.geode.internal.tcp.MsgStreamer.writeMessage(MsgStreamer.java:249)
>   at 
> org.apache.geode.distributed.internal.direct.DirectChannel.sendToMany(DirectChannel.java:306)
>   at 
> org.apache.geode.distributed.internal.direct.DirectChannel.sendToOne(DirectChannel.java:182)
>   at 
> org.apache.geode.distributed.internal.direct.DirectChannel.send(DirectChannel.java:511)
>   at 
> org.apache.geode.distributed.internal.DistributionImpl.directChannelSend(DistributionImpl.java:346)
>   at 
> org.apache.geode.distributed.internal.DistributionImpl.send(DistributionImpl.java:291)
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendViaMembershipManager(ClusterDistributionManager.java:2053)
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendOutgoing(ClusterDistributionManager.java:1981)
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendMessage(ClusterDistributionManager.java:2018)
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.putOutgoing(ClusterDistributionManager.java:1083)
>   at 
> org.apache.geode.internal.cache.DistributedCacheOperation._distribute(DistributedCacheOperation.java:572)
>   at 
> org.apache.geode.internal.cache.DistributedCacheOperation.startOperation(DistributedCacheOperation.java:277)
>   at 
> org.apache.geode.internal.cache.DistributedCacheOperation.distribute(DistributedCacheOperation.java:318)
>   at 
> org.apache.geode.internal.cache.DistributedRegion.distributeUpdate(DistributedRegion.java:520)
>   at 
> org.apache.geode.internal.cache.DistributedRegion.basicPutPart3(DistributedRegion.java:498)
>   at 
> org.apache.geode.internal.cache.map.RegionMapPut.doAfterCompletionActions(RegionMapPut.java:307)
>   at 
> org.apache.geode.internal.cache.map.AbstractRegionMapPut.doPut(AbstractRegionMapPut.java:185)
>   at 
> org.apache.geode.internal.cache.map.AbstractRegionMapPut.runWhileLockedForCacheModification(AbstractRegionMapPut.java:119)
>   at 
> org.apache.geode.internal.cache.map.RegionMapPut.runWhileLockedForCacheModification(RegionMapPut.java:161)
>   at 
> org.apache.geode.internal.cache.map.AbstractRegionMapPut.put(AbstractRegionMapPut.java:169)
>   at 
> org.apache.geode.internal.cache.AbstractRegionMap.basicPut(AbstractRegionMap.java:2044)
>   at 
> org.apache.geode.internal.cache.LocalRegion.virtualPut(LocalRegion.java:5599)
>   at 
> org.apache.geode.internal.cache.DistributedRegion.virtualPut(DistributedRegion.java:393)
>   at 
> org.apache.geode.internal.cache.LocalRegion.virtualPut(LocalRegion.java:5577)
>   at 
> org.apache.geode.internal.cache.LocalRegionDataView.putEntry(LocalRegionDataView.java:157)
>   at 
> org.apache.geode.internal.cache.LocalRegion.basicPut(LocalRegion.java:5035)
>   at 
> org.apache.geode.internal.cache.LocalRegion.replaceWithCallbackArgument(LocalRegion.java:10600)
>   

[jira] [Created] (GEODE-8588) Create multi-node concurrency (Dunit) tests for redis HDEL command

[John Hutchison (Jira)]

John Hutchison created GEODE-8588:
-

 Summary: Create multi-node concurrency (Dunit) tests for redis 
HDEL command
 Key: GEODE-8588
 URL: https://issues.apache.org/jira/browse/GEODE-8588
 Project: Geode
  Issue Type: Test
  Components: redis
Reporter: John Hutchison






--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-8584) Message transmission fails with IllegalStateException in socket i/o code

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-8584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210460#comment-17210460
 ] 

ASF subversion and git services commented on GEODE-8584:


Commit f4d44d658a6273d7de27479a67c05117310205a7 in geode's branch 
refs/heads/develop from Bruce Schuchardt
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=f4d44d6 ]

GEODE-8584: Message transmission fails with IllegalStateException in socket i/o 
code (#5605)

* GEODE-8584: Message transmission fails with IllegalStateException in socket 
i/o code

Add appropriate synchronization when using ioFilter's buffers.
to do: add testing
to do: document the need for synchronization in the NioFilter interface.

* revised synchronization across all uses of NioFilter, added test

* remove dangling debug logging

* fix pmd problem

* fix pmd problem

* remove unnecessary volatile modifier

> Message transmission fails with IllegalStateException in socket i/o code
> 
>
> Key: GEODE-8584
> URL: https://issues.apache.org/jira/browse/GEODE-8584
> Project: Geode
>  Issue Type: Bug
>  Components: membership, messaging
>Affects Versions: 1.12.0, 1.13.0, 1.14.0
>Reporter: Bruce J Schuchardt
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> Transmission of an update operation failed with a toData exception caused by 
> an IllegalStateException in socket i/o code.  It shouldn't be possible for 
> this exception to happen unless multiple threads are using the buffer at the 
> same time.
>  
> {noformat}
> org.apache.geode.ToDataException: toData failed on dsfid=71 msg:null
>   at 
> org.apache.geode.internal.InternalDataSerializer.writeDSFID(InternalDataSerializer.java:1509)
>   at 
> org.apache.geode.internal.tcp.MsgStreamer.writeMessage(MsgStreamer.java:249)
>   at 
> org.apache.geode.distributed.internal.direct.DirectChannel.sendToMany(DirectChannel.java:306)
>   at 
> org.apache.geode.distributed.internal.direct.DirectChannel.sendToOne(DirectChannel.java:182)
>   at 
> org.apache.geode.distributed.internal.direct.DirectChannel.send(DirectChannel.java:511)
>   at 
> org.apache.geode.distributed.internal.DistributionImpl.directChannelSend(DistributionImpl.java:346)
>   at 
> org.apache.geode.distributed.internal.DistributionImpl.send(DistributionImpl.java:291)
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendViaMembershipManager(ClusterDistributionManager.java:2053)
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendOutgoing(ClusterDistributionManager.java:1981)
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendMessage(ClusterDistributionManager.java:2018)
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.putOutgoing(ClusterDistributionManager.java:1083)
>   at 
> org.apache.geode.internal.cache.DistributedCacheOperation._distribute(DistributedCacheOperation.java:572)
>   at 
> org.apache.geode.internal.cache.DistributedCacheOperation.startOperation(DistributedCacheOperation.java:277)
>   at 
> org.apache.geode.internal.cache.DistributedCacheOperation.distribute(DistributedCacheOperation.java:318)
>   at 
> org.apache.geode.internal.cache.DistributedRegion.distributeUpdate(DistributedRegion.java:520)
>   at 
> org.apache.geode.internal.cache.DistributedRegion.basicPutPart3(DistributedRegion.java:498)
>   at 
> org.apache.geode.internal.cache.map.RegionMapPut.doAfterCompletionActions(RegionMapPut.java:307)
>   at 
> org.apache.geode.internal.cache.map.AbstractRegionMapPut.doPut(AbstractRegionMapPut.java:185)
>   at 
> org.apache.geode.internal.cache.map.AbstractRegionMapPut.runWhileLockedForCacheModification(AbstractRegionMapPut.java:119)
>   at 
> org.apache.geode.internal.cache.map.RegionMapPut.runWhileLockedForCacheModification(RegionMapPut.java:161)
>   at 
> org.apache.geode.internal.cache.map.AbstractRegionMapPut.put(AbstractRegionMapPut.java:169)
>   at 
> org.apache.geode.internal.cache.AbstractRegionMap.basicPut(AbstractRegionMap.java:2044)
>   at 
> org.apache.geode.internal.cache.LocalRegion.virtualPut(LocalRegion.java:5599)
>   at 
> org.apache.geode.internal.cache.DistributedRegion.virtualPut(DistributedRegion.java:393)
>   at 
> org.apache.geode.internal.cache.LocalRegion.virtualPut(LocalRegion.java:5577)
>   at 
> org.apache.geode.internal.cache.LocalRegionDataView.putEntry(LocalRegionDataView.java:157)
>   at 
> org.apache.geode.internal.cache.LocalRegion.basicPut(LocalRegion.java:5035)
>   at 
> org.apache.geode.internal.cache.LocalRegion.replaceWithCallbackArgument(LocalRegion.java:10600)
>   

[jira] [Commented] (GEODE-8584) Message transmission fails with IllegalStateException in socket i/o code

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-8584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210467#comment-17210467
 ] 

ASF subversion and git services commented on GEODE-8584:


Commit fb901bc6e3b4502b9ddf82849b82217adcef9629 in geode's branch 
refs/heads/support/1.13 from Bruce Schuchardt
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=fb901bc ]

GEODE-8584: Message transmission fails with IllegalStateException in socket i/o 
code (#5605)

* GEODE-8584: Message transmission fails with IllegalStateException in socket 
i/o code

Add appropriate synchronization when using ioFilter's buffers.
to do: add testing
to do: document the need for synchronization in the NioFilter interface.

* revised synchronization across all uses of NioFilter, added test

* remove dangling debug logging

* fix pmd problem

* fix pmd problem

* remove unnecessary volatile modifier

(cherry picked from commit f4d44d658a6273d7de27479a67c05117310205a7)


> Message transmission fails with IllegalStateException in socket i/o code
> 
>
> Key: GEODE-8584
> URL: https://issues.apache.org/jira/browse/GEODE-8584
> Project: Geode
>  Issue Type: Bug
>  Components: membership, messaging
>Affects Versions: 1.12.0, 1.13.0, 1.14.0
>Reporter: Bruce J Schuchardt
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> Transmission of an update operation failed with a toData exception caused by 
> an IllegalStateException in socket i/o code.  It shouldn't be possible for 
> this exception to happen unless multiple threads are using the buffer at the 
> same time.
>  
> {noformat}
> org.apache.geode.ToDataException: toData failed on dsfid=71 msg:null
>   at 
> org.apache.geode.internal.InternalDataSerializer.writeDSFID(InternalDataSerializer.java:1509)
>   at 
> org.apache.geode.internal.tcp.MsgStreamer.writeMessage(MsgStreamer.java:249)
>   at 
> org.apache.geode.distributed.internal.direct.DirectChannel.sendToMany(DirectChannel.java:306)
>   at 
> org.apache.geode.distributed.internal.direct.DirectChannel.sendToOne(DirectChannel.java:182)
>   at 
> org.apache.geode.distributed.internal.direct.DirectChannel.send(DirectChannel.java:511)
>   at 
> org.apache.geode.distributed.internal.DistributionImpl.directChannelSend(DistributionImpl.java:346)
>   at 
> org.apache.geode.distributed.internal.DistributionImpl.send(DistributionImpl.java:291)
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendViaMembershipManager(ClusterDistributionManager.java:2053)
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendOutgoing(ClusterDistributionManager.java:1981)
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendMessage(ClusterDistributionManager.java:2018)
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.putOutgoing(ClusterDistributionManager.java:1083)
>   at 
> org.apache.geode.internal.cache.DistributedCacheOperation._distribute(DistributedCacheOperation.java:572)
>   at 
> org.apache.geode.internal.cache.DistributedCacheOperation.startOperation(DistributedCacheOperation.java:277)
>   at 
> org.apache.geode.internal.cache.DistributedCacheOperation.distribute(DistributedCacheOperation.java:318)
>   at 
> org.apache.geode.internal.cache.DistributedRegion.distributeUpdate(DistributedRegion.java:520)
>   at 
> org.apache.geode.internal.cache.DistributedRegion.basicPutPart3(DistributedRegion.java:498)
>   at 
> org.apache.geode.internal.cache.map.RegionMapPut.doAfterCompletionActions(RegionMapPut.java:307)
>   at 
> org.apache.geode.internal.cache.map.AbstractRegionMapPut.doPut(AbstractRegionMapPut.java:185)
>   at 
> org.apache.geode.internal.cache.map.AbstractRegionMapPut.runWhileLockedForCacheModification(AbstractRegionMapPut.java:119)
>   at 
> org.apache.geode.internal.cache.map.RegionMapPut.runWhileLockedForCacheModification(RegionMapPut.java:161)
>   at 
> org.apache.geode.internal.cache.map.AbstractRegionMapPut.put(AbstractRegionMapPut.java:169)
>   at 
> org.apache.geode.internal.cache.AbstractRegionMap.basicPut(AbstractRegionMap.java:2044)
>   at 
> org.apache.geode.internal.cache.LocalRegion.virtualPut(LocalRegion.java:5599)
>   at 
> org.apache.geode.internal.cache.DistributedRegion.virtualPut(DistributedRegion.java:393)
>   at 
> org.apache.geode.internal.cache.LocalRegion.virtualPut(LocalRegion.java:5577)
>   at 
> org.apache.geode.internal.cache.LocalRegionDataView.putEntry(LocalRegionDataView.java:157)
>   at 
> org.apache.geode.internal.cache.LocalRegion.basicPut(LocalRegion.java:5035)
>   at 
> org.apache.geode.internal.ca

[jira] [Commented] (GEODE-8584) Message transmission fails with IllegalStateException in socket i/o code

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-8584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210468#comment-17210468
 ] 

ASF subversion and git services commented on GEODE-8584:


Commit fb901bc6e3b4502b9ddf82849b82217adcef9629 in geode's branch 
refs/heads/support/1.13 from Bruce Schuchardt
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=fb901bc ]

GEODE-8584: Message transmission fails with IllegalStateException in socket i/o 
code (#5605)

* GEODE-8584: Message transmission fails with IllegalStateException in socket 
i/o code

Add appropriate synchronization when using ioFilter's buffers.
to do: add testing
to do: document the need for synchronization in the NioFilter interface.

* revised synchronization across all uses of NioFilter, added test

* remove dangling debug logging

* fix pmd problem

* fix pmd problem

* remove unnecessary volatile modifier

(cherry picked from commit f4d44d658a6273d7de27479a67c05117310205a7)


> Message transmission fails with IllegalStateException in socket i/o code
> 
>
> Key: GEODE-8584
> URL: https://issues.apache.org/jira/browse/GEODE-8584
> Project: Geode
>  Issue Type: Bug
>  Components: membership, messaging
>Affects Versions: 1.12.0, 1.13.0, 1.14.0
>Reporter: Bruce J Schuchardt
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> Transmission of an update operation failed with a toData exception caused by 
> an IllegalStateException in socket i/o code.  It shouldn't be possible for 
> this exception to happen unless multiple threads are using the buffer at the 
> same time.
>  
> {noformat}
> org.apache.geode.ToDataException: toData failed on dsfid=71 msg:null
>   at 
> org.apache.geode.internal.InternalDataSerializer.writeDSFID(InternalDataSerializer.java:1509)
>   at 
> org.apache.geode.internal.tcp.MsgStreamer.writeMessage(MsgStreamer.java:249)
>   at 
> org.apache.geode.distributed.internal.direct.DirectChannel.sendToMany(DirectChannel.java:306)
>   at 
> org.apache.geode.distributed.internal.direct.DirectChannel.sendToOne(DirectChannel.java:182)
>   at 
> org.apache.geode.distributed.internal.direct.DirectChannel.send(DirectChannel.java:511)
>   at 
> org.apache.geode.distributed.internal.DistributionImpl.directChannelSend(DistributionImpl.java:346)
>   at 
> org.apache.geode.distributed.internal.DistributionImpl.send(DistributionImpl.java:291)
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendViaMembershipManager(ClusterDistributionManager.java:2053)
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendOutgoing(ClusterDistributionManager.java:1981)
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendMessage(ClusterDistributionManager.java:2018)
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.putOutgoing(ClusterDistributionManager.java:1083)
>   at 
> org.apache.geode.internal.cache.DistributedCacheOperation._distribute(DistributedCacheOperation.java:572)
>   at 
> org.apache.geode.internal.cache.DistributedCacheOperation.startOperation(DistributedCacheOperation.java:277)
>   at 
> org.apache.geode.internal.cache.DistributedCacheOperation.distribute(DistributedCacheOperation.java:318)
>   at 
> org.apache.geode.internal.cache.DistributedRegion.distributeUpdate(DistributedRegion.java:520)
>   at 
> org.apache.geode.internal.cache.DistributedRegion.basicPutPart3(DistributedRegion.java:498)
>   at 
> org.apache.geode.internal.cache.map.RegionMapPut.doAfterCompletionActions(RegionMapPut.java:307)
>   at 
> org.apache.geode.internal.cache.map.AbstractRegionMapPut.doPut(AbstractRegionMapPut.java:185)
>   at 
> org.apache.geode.internal.cache.map.AbstractRegionMapPut.runWhileLockedForCacheModification(AbstractRegionMapPut.java:119)
>   at 
> org.apache.geode.internal.cache.map.RegionMapPut.runWhileLockedForCacheModification(RegionMapPut.java:161)
>   at 
> org.apache.geode.internal.cache.map.AbstractRegionMapPut.put(AbstractRegionMapPut.java:169)
>   at 
> org.apache.geode.internal.cache.AbstractRegionMap.basicPut(AbstractRegionMap.java:2044)
>   at 
> org.apache.geode.internal.cache.LocalRegion.virtualPut(LocalRegion.java:5599)
>   at 
> org.apache.geode.internal.cache.DistributedRegion.virtualPut(DistributedRegion.java:393)
>   at 
> org.apache.geode.internal.cache.LocalRegion.virtualPut(LocalRegion.java:5577)
>   at 
> org.apache.geode.internal.cache.LocalRegionDataView.putEntry(LocalRegionDataView.java:157)
>   at 
> org.apache.geode.internal.cache.LocalRegion.basicPut(LocalRegion.java:5035)
>   at 
> org.apache.geode.internal.ca

[jira] [Commented] (GEODE-8584) Message transmission fails with IllegalStateException in socket i/o code

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-8584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210476#comment-17210476
 ] 

ASF subversion and git services commented on GEODE-8584:


Commit 2ccaf7b8fe1cb490a3d3001b61b12ea52c5ed1d0 in geode's branch 
refs/heads/support/1.12 from Bruce Schuchardt
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=2ccaf7b ]

GEODE-8584: Message transmission fails with IllegalStateException in socket i/o 
code (#5605)

* GEODE-8584: Message transmission fails with IllegalStateException in socket 
i/o code

Add appropriate synchronization when using ioFilter's buffers.
to do: add testing
to do: document the need for synchronization in the NioFilter interface.

* revised synchronization across all uses of NioFilter, added test

* remove dangling debug logging

* fix pmd problem

* fix pmd problem

* remove unnecessary volatile modifier

(cherry picked from commit f4d44d658a6273d7de27479a67c05117310205a7)


> Message transmission fails with IllegalStateException in socket i/o code
> 
>
> Key: GEODE-8584
> URL: https://issues.apache.org/jira/browse/GEODE-8584
> Project: Geode
>  Issue Type: Bug
>  Components: membership, messaging
>Affects Versions: 1.12.0, 1.13.0, 1.14.0
>Reporter: Bruce J Schuchardt
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> Transmission of an update operation failed with a toData exception caused by 
> an IllegalStateException in socket i/o code.  It shouldn't be possible for 
> this exception to happen unless multiple threads are using the buffer at the 
> same time.
>  
> {noformat}
> org.apache.geode.ToDataException: toData failed on dsfid=71 msg:null
>   at 
> org.apache.geode.internal.InternalDataSerializer.writeDSFID(InternalDataSerializer.java:1509)
>   at 
> org.apache.geode.internal.tcp.MsgStreamer.writeMessage(MsgStreamer.java:249)
>   at 
> org.apache.geode.distributed.internal.direct.DirectChannel.sendToMany(DirectChannel.java:306)
>   at 
> org.apache.geode.distributed.internal.direct.DirectChannel.sendToOne(DirectChannel.java:182)
>   at 
> org.apache.geode.distributed.internal.direct.DirectChannel.send(DirectChannel.java:511)
>   at 
> org.apache.geode.distributed.internal.DistributionImpl.directChannelSend(DistributionImpl.java:346)
>   at 
> org.apache.geode.distributed.internal.DistributionImpl.send(DistributionImpl.java:291)
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendViaMembershipManager(ClusterDistributionManager.java:2053)
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendOutgoing(ClusterDistributionManager.java:1981)
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendMessage(ClusterDistributionManager.java:2018)
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.putOutgoing(ClusterDistributionManager.java:1083)
>   at 
> org.apache.geode.internal.cache.DistributedCacheOperation._distribute(DistributedCacheOperation.java:572)
>   at 
> org.apache.geode.internal.cache.DistributedCacheOperation.startOperation(DistributedCacheOperation.java:277)
>   at 
> org.apache.geode.internal.cache.DistributedCacheOperation.distribute(DistributedCacheOperation.java:318)
>   at 
> org.apache.geode.internal.cache.DistributedRegion.distributeUpdate(DistributedRegion.java:520)
>   at 
> org.apache.geode.internal.cache.DistributedRegion.basicPutPart3(DistributedRegion.java:498)
>   at 
> org.apache.geode.internal.cache.map.RegionMapPut.doAfterCompletionActions(RegionMapPut.java:307)
>   at 
> org.apache.geode.internal.cache.map.AbstractRegionMapPut.doPut(AbstractRegionMapPut.java:185)
>   at 
> org.apache.geode.internal.cache.map.AbstractRegionMapPut.runWhileLockedForCacheModification(AbstractRegionMapPut.java:119)
>   at 
> org.apache.geode.internal.cache.map.RegionMapPut.runWhileLockedForCacheModification(RegionMapPut.java:161)
>   at 
> org.apache.geode.internal.cache.map.AbstractRegionMapPut.put(AbstractRegionMapPut.java:169)
>   at 
> org.apache.geode.internal.cache.AbstractRegionMap.basicPut(AbstractRegionMap.java:2044)
>   at 
> org.apache.geode.internal.cache.LocalRegion.virtualPut(LocalRegion.java:5599)
>   at 
> org.apache.geode.internal.cache.DistributedRegion.virtualPut(DistributedRegion.java:393)
>   at 
> org.apache.geode.internal.cache.LocalRegion.virtualPut(LocalRegion.java:5577)
>   at 
> org.apache.geode.internal.cache.LocalRegionDataView.putEntry(LocalRegionDataView.java:157)
>   at 
> org.apache.geode.internal.cache.LocalRegion.basicPut(LocalRegion.java:5035)
>   at 
> org.apache.geode.internal.ca

[jira] [Commented] (GEODE-8584) Message transmission fails with IllegalStateException in socket i/o code

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-8584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210475#comment-17210475
 ] 

ASF subversion and git services commented on GEODE-8584:


Commit 2ccaf7b8fe1cb490a3d3001b61b12ea52c5ed1d0 in geode's branch 
refs/heads/support/1.12 from Bruce Schuchardt
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=2ccaf7b ]

GEODE-8584: Message transmission fails with IllegalStateException in socket i/o 
code (#5605)

* GEODE-8584: Message transmission fails with IllegalStateException in socket 
i/o code

Add appropriate synchronization when using ioFilter's buffers.
to do: add testing
to do: document the need for synchronization in the NioFilter interface.

* revised synchronization across all uses of NioFilter, added test

* remove dangling debug logging

* fix pmd problem

* fix pmd problem

* remove unnecessary volatile modifier

(cherry picked from commit f4d44d658a6273d7de27479a67c05117310205a7)


> Message transmission fails with IllegalStateException in socket i/o code
> 
>
> Key: GEODE-8584
> URL: https://issues.apache.org/jira/browse/GEODE-8584
> Project: Geode
>  Issue Type: Bug
>  Components: membership, messaging
>Affects Versions: 1.12.0, 1.13.0, 1.14.0
>Reporter: Bruce J Schuchardt
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> Transmission of an update operation failed with a toData exception caused by 
> an IllegalStateException in socket i/o code.  It shouldn't be possible for 
> this exception to happen unless multiple threads are using the buffer at the 
> same time.
>  
> {noformat}
> org.apache.geode.ToDataException: toData failed on dsfid=71 msg:null
>   at 
> org.apache.geode.internal.InternalDataSerializer.writeDSFID(InternalDataSerializer.java:1509)
>   at 
> org.apache.geode.internal.tcp.MsgStreamer.writeMessage(MsgStreamer.java:249)
>   at 
> org.apache.geode.distributed.internal.direct.DirectChannel.sendToMany(DirectChannel.java:306)
>   at 
> org.apache.geode.distributed.internal.direct.DirectChannel.sendToOne(DirectChannel.java:182)
>   at 
> org.apache.geode.distributed.internal.direct.DirectChannel.send(DirectChannel.java:511)
>   at 
> org.apache.geode.distributed.internal.DistributionImpl.directChannelSend(DistributionImpl.java:346)
>   at 
> org.apache.geode.distributed.internal.DistributionImpl.send(DistributionImpl.java:291)
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendViaMembershipManager(ClusterDistributionManager.java:2053)
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendOutgoing(ClusterDistributionManager.java:1981)
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendMessage(ClusterDistributionManager.java:2018)
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.putOutgoing(ClusterDistributionManager.java:1083)
>   at 
> org.apache.geode.internal.cache.DistributedCacheOperation._distribute(DistributedCacheOperation.java:572)
>   at 
> org.apache.geode.internal.cache.DistributedCacheOperation.startOperation(DistributedCacheOperation.java:277)
>   at 
> org.apache.geode.internal.cache.DistributedCacheOperation.distribute(DistributedCacheOperation.java:318)
>   at 
> org.apache.geode.internal.cache.DistributedRegion.distributeUpdate(DistributedRegion.java:520)
>   at 
> org.apache.geode.internal.cache.DistributedRegion.basicPutPart3(DistributedRegion.java:498)
>   at 
> org.apache.geode.internal.cache.map.RegionMapPut.doAfterCompletionActions(RegionMapPut.java:307)
>   at 
> org.apache.geode.internal.cache.map.AbstractRegionMapPut.doPut(AbstractRegionMapPut.java:185)
>   at 
> org.apache.geode.internal.cache.map.AbstractRegionMapPut.runWhileLockedForCacheModification(AbstractRegionMapPut.java:119)
>   at 
> org.apache.geode.internal.cache.map.RegionMapPut.runWhileLockedForCacheModification(RegionMapPut.java:161)
>   at 
> org.apache.geode.internal.cache.map.AbstractRegionMapPut.put(AbstractRegionMapPut.java:169)
>   at 
> org.apache.geode.internal.cache.AbstractRegionMap.basicPut(AbstractRegionMap.java:2044)
>   at 
> org.apache.geode.internal.cache.LocalRegion.virtualPut(LocalRegion.java:5599)
>   at 
> org.apache.geode.internal.cache.DistributedRegion.virtualPut(DistributedRegion.java:393)
>   at 
> org.apache.geode.internal.cache.LocalRegion.virtualPut(LocalRegion.java:5577)
>   at 
> org.apache.geode.internal.cache.LocalRegionDataView.putEntry(LocalRegionDataView.java:157)
>   at 
> org.apache.geode.internal.cache.LocalRegion.basicPut(LocalRegion.java:5035)
>   at 
> org.apache.geode.internal.ca

[jira] [Commented] (GEODE-8579) Locators should stop waiting for locator-wait-time if all locators contacted

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-8579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210485#comment-17210485
 ] 

ASF GitHub Bot commented on GEODE-8579:
---

upthewaterspout merged pull request #5598:
URL: https://github.com/apache/geode/pull/5598


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Locators should stop waiting for locator-wait-time if all locators contacted
> 
>
> Key: GEODE-8579
> URL: https://issues.apache.org/jira/browse/GEODE-8579
> Project: Geode
>  Issue Type: Improvement
>  Components: membership
>Reporter: Dan Smith
>Priority: Major
>  Labels: pull-request-available
>
> If locator-wait-time is set on one or more locators, the locators can 
> currently end up waiting for the entire locator-wait-time before starting up, 
> even if all locators can contact each other.
> If the locators can all contact each other, they should start up right away 
> and not wait any longer, even if locator-wait-time is set.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-8579) Locators should stop waiting for locator-wait-time if all locators contacted

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-8579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210486#comment-17210486
 ] 

ASF subversion and git services commented on GEODE-8579:


Commit faef81114d5a60bb1bcc4fdcb5c7fa7dd894bc86 in geode's branch 
refs/heads/develop from Dan Smith
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=faef811 ]

GEODE-8579: Stop waiting locator-wait-time if all locators are available

If we can contact all other locators, we should stop waiting for
locator-wait-time to elapse.

Moving AvailablePort to the geode-membership project so that 
it can be used to write tests at this level.

> Locators should stop waiting for locator-wait-time if all locators contacted
> 
>
> Key: GEODE-8579
> URL: https://issues.apache.org/jira/browse/GEODE-8579
> Project: Geode
>  Issue Type: Improvement
>  Components: membership
>Reporter: Dan Smith
>Assignee: Dan Smith
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> If locator-wait-time is set on one or more locators, the locators can 
> currently end up waiting for the entire locator-wait-time before starting up, 
> even if all locators can contact each other.
> If the locators can all contact each other, they should start up right away 
> and not wait any longer, even if locator-wait-time is set.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (GEODE-8579) Locators should stop waiting for locator-wait-time if all locators contacted

[Dan Smith (Jira)]

 [ 
https://issues.apache.org/jira/browse/GEODE-8579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Dan Smith resolved GEODE-8579.
--
Fix Version/s: 1.14.0
 Assignee: Dan Smith
   Resolution: Fixed

> Locators should stop waiting for locator-wait-time if all locators contacted
> 
>
> Key: GEODE-8579
> URL: https://issues.apache.org/jira/browse/GEODE-8579
> Project: Geode
>  Issue Type: Improvement
>  Components: membership
>Reporter: Dan Smith
>Assignee: Dan Smith
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> If locator-wait-time is set on one or more locators, the locators can 
> currently end up waiting for the entire locator-wait-time before starting up, 
> even if all locators can contact each other.
> If the locators can all contact each other, they should start up right away 
> and not wait any longer, even if locator-wait-time is set.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (GEODE-8584) Message transmission fails with IllegalStateException in socket i/o code

[Bruce J Schuchardt (Jira)]

 [ 
https://issues.apache.org/jira/browse/GEODE-8584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bruce J Schuchardt updated GEODE-8584:
--
Fix Version/s: 1.13.1
   1.12.1

> Message transmission fails with IllegalStateException in socket i/o code
> 
>
> Key: GEODE-8584
> URL: https://issues.apache.org/jira/browse/GEODE-8584
> Project: Geode
>  Issue Type: Bug
>  Components: membership, messaging
>Affects Versions: 1.12.0, 1.13.0, 1.14.0
>Reporter: Bruce J Schuchardt
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.12.1, 1.14.0, 1.13.1
>
>
> Transmission of an update operation failed with a toData exception caused by 
> an IllegalStateException in socket i/o code.  It shouldn't be possible for 
> this exception to happen unless multiple threads are using the buffer at the 
> same time.
>  
> {noformat}
> org.apache.geode.ToDataException: toData failed on dsfid=71 msg:null
>   at 
> org.apache.geode.internal.InternalDataSerializer.writeDSFID(InternalDataSerializer.java:1509)
>   at 
> org.apache.geode.internal.tcp.MsgStreamer.writeMessage(MsgStreamer.java:249)
>   at 
> org.apache.geode.distributed.internal.direct.DirectChannel.sendToMany(DirectChannel.java:306)
>   at 
> org.apache.geode.distributed.internal.direct.DirectChannel.sendToOne(DirectChannel.java:182)
>   at 
> org.apache.geode.distributed.internal.direct.DirectChannel.send(DirectChannel.java:511)
>   at 
> org.apache.geode.distributed.internal.DistributionImpl.directChannelSend(DistributionImpl.java:346)
>   at 
> org.apache.geode.distributed.internal.DistributionImpl.send(DistributionImpl.java:291)
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendViaMembershipManager(ClusterDistributionManager.java:2053)
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendOutgoing(ClusterDistributionManager.java:1981)
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.sendMessage(ClusterDistributionManager.java:2018)
>   at 
> org.apache.geode.distributed.internal.ClusterDistributionManager.putOutgoing(ClusterDistributionManager.java:1083)
>   at 
> org.apache.geode.internal.cache.DistributedCacheOperation._distribute(DistributedCacheOperation.java:572)
>   at 
> org.apache.geode.internal.cache.DistributedCacheOperation.startOperation(DistributedCacheOperation.java:277)
>   at 
> org.apache.geode.internal.cache.DistributedCacheOperation.distribute(DistributedCacheOperation.java:318)
>   at 
> org.apache.geode.internal.cache.DistributedRegion.distributeUpdate(DistributedRegion.java:520)
>   at 
> org.apache.geode.internal.cache.DistributedRegion.basicPutPart3(DistributedRegion.java:498)
>   at 
> org.apache.geode.internal.cache.map.RegionMapPut.doAfterCompletionActions(RegionMapPut.java:307)
>   at 
> org.apache.geode.internal.cache.map.AbstractRegionMapPut.doPut(AbstractRegionMapPut.java:185)
>   at 
> org.apache.geode.internal.cache.map.AbstractRegionMapPut.runWhileLockedForCacheModification(AbstractRegionMapPut.java:119)
>   at 
> org.apache.geode.internal.cache.map.RegionMapPut.runWhileLockedForCacheModification(RegionMapPut.java:161)
>   at 
> org.apache.geode.internal.cache.map.AbstractRegionMapPut.put(AbstractRegionMapPut.java:169)
>   at 
> org.apache.geode.internal.cache.AbstractRegionMap.basicPut(AbstractRegionMap.java:2044)
>   at 
> org.apache.geode.internal.cache.LocalRegion.virtualPut(LocalRegion.java:5599)
>   at 
> org.apache.geode.internal.cache.DistributedRegion.virtualPut(DistributedRegion.java:393)
>   at 
> org.apache.geode.internal.cache.LocalRegion.virtualPut(LocalRegion.java:5577)
>   at 
> org.apache.geode.internal.cache.LocalRegionDataView.putEntry(LocalRegionDataView.java:157)
>   at 
> org.apache.geode.internal.cache.LocalRegion.basicPut(LocalRegion.java:5035)
>   at 
> org.apache.geode.internal.cache.LocalRegion.replaceWithCallbackArgument(LocalRegion.java:10600)
>   at 
> org.apache.geode.internal.cache.LocalRegion.replace(LocalRegion.java:10566)
> [application code traces deleted]
> Caused by: java.lang.IllegalArgumentException
>   at java.nio.Buffer.position(Buffer.java:244)
>   at sun.nio.ch.IOUtil.writeFromNativeBuffer(IOUtil.java:96)
>   at sun.nio.ch.IOUtil.write(IOUtil.java:51)
>   at sun.nio.ch.SocketChannelImpl.write(SocketChannelImpl.java:469)
>   at 
> org.apache.geode.internal.tcp.Connection.writeFully(Connection.java:2596)
>   at 
> org.apache.geode.internal.tcp.Connection.sendPreserialized(Connection.java:1866)
>   at 
> org.apache.geode.internal.tcp.MsgStreamer.realFlush(MsgStreamer.java:330)
>   at org.

[jira] [Commented] (GEODE-8517) GatewaySenderEventImpl's 2 new attributes were introduced in 1.14 not 1.13

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-8517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210492#comment-17210492
 ] 

ASF GitHub Bot commented on GEODE-8517:
---

jchen21 commented on a change in pull request #5530:
URL: https://github.com/apache/geode/pull/5530#discussion_r501259365



##
File path: 
geode-core/src/main/java/org/apache/geode/internal/cache/wan/GatewaySenderEventImpl.java
##
@@ -754,8 +754,8 @@ protected void serializeKey(DataOutput out,
   @Override
   public void fromData(DataInput in,
   DeserializationContext context) throws IOException, 
ClassNotFoundException {
-fromDataPre_GEODE_1_13_0_0(in, context);
-if (version >= KnownVersion.GEODE_1_13_0.ordinal()) {
+fromDataPre_GEODE_1_14_0_0(in, context);
+if (version >= KnownVersion.GEODE_1_14_0.ordinal()) {

Review comment:
   There is no need for condition check here. The appropriate version of 
`fromData()` is invoked by `DSFIDSerializerImpl.invokeFromData()` and 
`InternalDataSerializer.invokeFromData()`.  For older versions, it will not 
invoke `fromData()`. Instead, it will invoke `fromDataPre_GEODE_1_9_0_0` or 
`fromDataPre_GEODE_1_14_0_0` depending on the version from `DataInput` or 
`DeserializationContext`.
   





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> GatewaySenderEventImpl's 2 new attributes were introduced in 1.14 not 1.13
> --
>
> Key: GEODE-8517
> URL: https://issues.apache.org/jira/browse/GEODE-8517
> Project: Geode
>  Issue Type: Bug
>  Components: serialization
>Affects Versions: 1.14.0
>Reporter: Xiaojian Zhou
>Assignee: Xiaojian Zhou
>Priority: Major
>  Labels: GeodeOperationAPI, pull-request-available
>
> GEODE-7971 introduced 2 new attributes isLastEventInTransaction and 
> transactionId. At that time, the in-coming release was 1.13. So the 
> GatewaySenderEventImpl specified GEODE_1_13_0 for the code changes. However, 
> due to the release schedule change, the 2 attributes are actually introduced 
> in 1.14. The 1.13 does not have them. 
> So rollingUpgrade from 1.13 to 1.14 for PARALLEL_GATEWAY_SENDER_QUEUE region 
> with GatewaySenderEventImpl will encounter serialization issue. This issue 
> will only be triggered in TX use case. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (GEODE-8589) make locatorsStopWaitingForLocatorWaitTimeIfAllLocatorsContacted test deterministic

[Bill Burcham (Jira)]

Bill Burcham created GEODE-8589:
---

 Summary: make 
locatorsStopWaitingForLocatorWaitTimeIfAllLocatorsContacted test deterministic
 Key: GEODE-8589
 URL: https://issues.apache.org/jira/browse/GEODE-8589
 Project: Geode
  Issue Type: Improvement
  Components: membership
Reporter: Bill Burcham


A recent commit added a new test: 
{{MembershipIntegrationTest.locatorsStopWaitingForLocatorWaitTimeIfAllLocatorsContacted()}}

That's a good test. But it would be better if it ran faster and was less 
susceptible to timing issues. The problem is that the logic we are trying to 
test, {{GMSJoinLeave.leave()}} uses {{System.currentTimeMillis()}} to get the 
current time and it uses {{Thread.sleep()}} to sleep:

{code:java}
long now = System.currentTimeMillis();
...
if (state.joinedMembersContacted <= 0 && ((now >= locatorGiveUpTime 
&&
tries >= minimumRetriesBeforeBecomingCoordinator) ||
state.locatorsContacted >= locators.size())) {
...
if (System.currentTimeMillis() > giveupTime) {
  break;
}
...
  Thread.sleep(retrySleep);
...
  giveupTime = System.currentTimeMillis() + timeout;
...
  if (!this.isJoined) {
logger.debug("giving up attempting to join the distributed system after 
"
+ (System.currentTimeMillis() - startTime) + "ms");
  }
...
  if (!this.isJoined && state.hasContactedAJoinedLocator) {
throw new MemberStartupException("Unable to join the distributed system 
in "
+ (System.currentTimeMillis() - startTime) + "ms");
  }
{code}

The opportunity is to _inject_ objects that handle these two functions (time 
keeping and sleeping). This will enable us to artifically control these in our 
test! Sleeping doesn't have to take any time at all. And we can make time pass 
as quickly as we want to.

For an example of how this can be done, see [PR 
#5422|https://github.com/apache/geode/pull/5422] for GEODE-6950.

This particular test 
({{locatorsStopWaitingForLocatorWaitTimeIfAllLocatorsContacted()}}) is a little 
bit more involved than that one in that more objects are involved. In addition 
to {{GMSJoinLeave}}, other classes involved in the test also need current time 
and need to sleep.

When this ticket is complete, {{GMSJoinLeave}} and TBD other classes will have

* functional interfaces {{MillisecondProvider}} and {{Sleeper}}, currently 
defined inside {{PrimaryHandler}} will be moved higher in the (internal) 
hierarchy for use by other membership classes
* {{GMSJoinLeave}} will take a {{MillisecondProvider}} and {{Sleeper}} in its 
constructor and will delegate to those instead of calling 
{{System.currentTimeMillis()}} and {{Thread.sleep()}} directly
* TBD other classes may require injection of {{MillisecondProvider}} and 
{{Sleeper}}
* TBD other changes may be necessary in cases where collaborating classes 
currently spin up threads or synchronize between threads e.g. calling {{wait()}}
* {{locatorsStopWaitingForLocatorWaitTimeIfAllLocatorsContacted()}} will no 
longer employ {{Thread.sleep()}} nor will it call {{CompletableFuture.get(long 
timeout, TimeUnit unit)}}—instead it will operate deterministically (ideally in 
the same thread but not necessarily) with respect to the unit under test.




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (GEODE-8589) make locatorsStopWaitingForLocatorWaitTimeIfAllLocatorsContacted test deterministic

[Bill Burcham (Jira)]

 [ 
https://issues.apache.org/jira/browse/GEODE-8589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bill Burcham updated GEODE-8589:

Description: 
A recent commit added a new test: 
{{MembershipIntegrationTest.locatorsStopWaitingForLocatorWaitTimeIfAllLocatorsContacted()}}

That's a good test. But it would be better if it ran faster and was less 
susceptible to timing issues. The problem is that the logic we are trying to 
test, {{GMSJoinLeave.leave()}} uses {{System.currentTimeMillis()}} to get the 
current time and it uses {{Thread.sleep()}} to sleep:

{code:java}
long now = System.currentTimeMillis();
...
if (state.joinedMembersContacted <= 0 && ((now >= locatorGiveUpTime 
&&
tries >= minimumRetriesBeforeBecomingCoordinator) ||
state.locatorsContacted >= locators.size())) {
...
if (System.currentTimeMillis() > giveupTime) {
  break;
}
...
  Thread.sleep(retrySleep);
...
  giveupTime = System.currentTimeMillis() + timeout;
...
  if (!this.isJoined) {
logger.debug("giving up attempting to join the distributed system after 
"
+ (System.currentTimeMillis() - startTime) + "ms");
  }
...
  if (!this.isJoined && state.hasContactedAJoinedLocator) {
throw new MemberStartupException("Unable to join the distributed system 
in "
+ (System.currentTimeMillis() - startTime) + "ms");
  }
{code}

The opportunity is to _inject_ objects that handle these two functions (time 
keeping and sleeping). This will enable us to artifically control these in our 
test! Sleeping doesn't have to take any time at all. And we can make time pass 
as quickly as we want to.

For an example of how this can be done, see [PR 
#5422|https://github.com/apache/geode/pull/5422] for GEODE-6950.

This particular test 
({{locatorsStopWaitingForLocatorWaitTimeIfAllLocatorsContacted()}}) is a little 
bit more involved than that one in that more objects are involved. In addition 
to {{GMSJoinLeave}}, other classes involved in the test also need current time 
and need to sleep.

When this ticket is complete:

* functional interfaces {{MillisecondProvider}} and {{Sleeper}}, currently 
defined inside {{PrimaryHandler}} will be moved higher in the (internal) 
hierarchy for use by other membership classes
* {{GMSJoinLeave}} will take a {{MillisecondProvider}} and {{Sleeper}} in its 
constructor and will delegate to those instead of calling 
{{System.currentTimeMillis()}} and {{Thread.sleep()}} directly
* TBD other classes may require injection of {{MillisecondProvider}} and 
{{Sleeper}}
* TBD other changes may be necessary in cases where collaborating classes 
currently spin up threads or synchronize between threads e.g. calling {{wait()}}
* {{locatorsStopWaitingForLocatorWaitTimeIfAllLocatorsContacted()}} will no 
longer employ {{Thread.sleep()}} nor will it call {{CompletableFuture.get(long 
timeout, TimeUnit unit)}}—instead it will operate deterministically (ideally in 
the same thread but not necessarily) with respect to the unit under test.


  was:
A recent commit added a new test: 
{{MembershipIntegrationTest.locatorsStopWaitingForLocatorWaitTimeIfAllLocatorsContacted()}}

That's a good test. But it would be better if it ran faster and was less 
susceptible to timing issues. The problem is that the logic we are trying to 
test, {{GMSJoinLeave.leave()}} uses {{System.currentTimeMillis()}} to get the 
current time and it uses {{Thread.sleep()}} to sleep:

{code:java}
long now = System.currentTimeMillis();
...
if (state.joinedMembersContacted <= 0 && ((now >= locatorGiveUpTime 
&&
tries >= minimumRetriesBeforeBecomingCoordinator) ||
state.locatorsContacted >= locators.size())) {
...
if (System.currentTimeMillis() > giveupTime) {
  break;
}
...
  Thread.sleep(retrySleep);
...
  giveupTime = System.currentTimeMillis() + timeout;
...
  if (!this.isJoined) {
logger.debug("giving up attempting to join the distributed system after 
"
+ (System.currentTimeMillis() - startTime) + "ms");
  }
...
  if (!this.isJoined && state.hasContactedAJoinedLocator) {
throw new MemberStartupException("Unable to join the distributed system 
in "
+ (System.currentTimeMillis() - startTime) + "ms");
  }
{code}

The opportunity is to _inject_ objects that handle these two functions (time 
keeping and sleeping). This will enable us to artifically control these in our 
test! Sleeping doesn't have to take any time at all. And we can make time pass 
as quickly as we want to.

For an example of how this can be done, see [PR 
#5422|https://github.com/apache/geode/pull/5422] for GEODE-6950.

This particular test 
({{locatorsStopWaitingForLocatorWaitTimeIfAllLocatorsContacted()}}) is a little 

[jira] [Commented] (GEODE-8579) Locators should stop waiting for locator-wait-time if all locators contacted

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-8579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210502#comment-17210502
 ] 

ASF GitHub Bot commented on GEODE-8579:
---

Bill commented on a change in pull request #5598:
URL: https://github.com/apache/geode/pull/5598#discussion_r502058030



##
File path: 
geode-membership/src/integrationTest/java/org/apache/geode/distributed/internal/membership/gms/MembershipIntegrationTest.java
##
@@ -272,6 +276,65 @@ public void secondMembershipPausesForLocatorWaitTime()
 stop(coordinatorLocator, lateJoiningLocator);
   }
 
+  @Test
+  public void locatorsStopWaitingForLocatorWaitTimeIfAllLocatorsContacted()
+  throws IOException, MemberStartupException, InterruptedException, 
TimeoutException,
+  ExecutionException {
+
+final Supplier executorServiceSupplier =
+() -> LoggingExecutors.newCachedThreadPool("membership", false);
+
+int[] locatorPorts = AvailablePortHelper.getRandomAvailableTCPPorts(2);
+
+int locatorWaitTime = (int) Duration.ofMinutes(5).getSeconds();
+final MembershipConfig config =
+createMembershipConfig(true, locatorWaitTime, locatorPorts[0], 
locatorPorts[1]);
+
+CompletableFuture> createMembership0 =
+launchLocator(executorServiceSupplier, locatorPorts[0], config);
+
+// Assert that membership 0 is waiting for the other locator to start
+Thread.sleep(5000);
+assertThat(createMembership0.getNow(null)).isNull();
+
+CompletableFuture> createMembership1 =
+launchLocator(executorServiceSupplier, locatorPorts[1], config);
+
+// Make sure the members are created in less than the locator-wait-time
+Membership membership0 = createMembership0.get(2, 
TimeUnit.MINUTES);
+Membership membership1 = createMembership1.get(2, 
TimeUnit.MINUTES);
+
+// Make sure the members see each other in the view
+assertThat(membership0.getView().getMembers()).hasSize(2);
+assertThat(membership1.getView().getMembers()).hasSize(2);
+  }

Review comment:
   Here's that new ticket: https://issues.apache.org/jira/browse/GEODE-8589





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Locators should stop waiting for locator-wait-time if all locators contacted
> 
>
> Key: GEODE-8579
> URL: https://issues.apache.org/jira/browse/GEODE-8579
> Project: Geode
>  Issue Type: Improvement
>  Components: membership
>Reporter: Dan Smith
>Assignee: Dan Smith
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> If locator-wait-time is set on one or more locators, the locators can 
> currently end up waiting for the entire locator-wait-time before starting up, 
> even if all locators can contact each other.
> If the locators can all contact each other, they should start up right away 
> and not wait any longer, even if locator-wait-time is set.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (GEODE-8589) make locatorsStopWaitingForLocatorWaitTimeIfAllLocatorsContacted test deterministic

[Bill Burcham (Jira)]

 [ 
https://issues.apache.org/jira/browse/GEODE-8589?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bill Burcham updated GEODE-8589:

Labels: membership  (was: )

> make locatorsStopWaitingForLocatorWaitTimeIfAllLocatorsContacted test 
> deterministic
> ---
>
> Key: GEODE-8589
> URL: https://issues.apache.org/jira/browse/GEODE-8589
> Project: Geode
>  Issue Type: Improvement
>  Components: membership
>Reporter: Bill Burcham
>Priority: Major
>  Labels: membership
>
> A recent commit added a new test: 
> {{MembershipIntegrationTest.locatorsStopWaitingForLocatorWaitTimeIfAllLocatorsContacted()}}
> That's a good test. But it would be better if it ran faster and was less 
> susceptible to timing issues. The problem is that the logic we are trying to 
> test, {{GMSJoinLeave.leave()}} uses {{System.currentTimeMillis()}} to get the 
> current time and it uses {{Thread.sleep()}} to sleep:
> {code:java}
> long now = System.currentTimeMillis();
> ...
> if (state.joinedMembersContacted <= 0 && ((now >= 
> locatorGiveUpTime &&
> tries >= minimumRetriesBeforeBecomingCoordinator) ||
> state.locatorsContacted >= locators.size())) {
> ...
> if (System.currentTimeMillis() > giveupTime) {
>   break;
> }
> ...
>   Thread.sleep(retrySleep);
> ...
>   giveupTime = System.currentTimeMillis() + timeout;
> ...
>   if (!this.isJoined) {
> logger.debug("giving up attempting to join the distributed system 
> after "
> + (System.currentTimeMillis() - startTime) + "ms");
>   }
> ...
>   if (!this.isJoined && state.hasContactedAJoinedLocator) {
> throw new MemberStartupException("Unable to join the distributed 
> system in "
> + (System.currentTimeMillis() - startTime) + "ms");
>   }
> {code}
> The opportunity is to _inject_ objects that handle these two functions (time 
> keeping and sleeping). This will enable us to artifically control these in 
> our test! Sleeping doesn't have to take any time at all. And we can make time 
> pass as quickly as we want to.
> For an example of how this can be done, see [PR 
> #5422|https://github.com/apache/geode/pull/5422] for GEODE-6950.
> This particular test 
> ({{locatorsStopWaitingForLocatorWaitTimeIfAllLocatorsContacted()}}) is a 
> little bit more involved than that one in that more objects are involved. In 
> addition to {{GMSJoinLeave}}, other classes involved in the test also need 
> current time and need to sleep.
> When this ticket is complete:
> * functional interfaces {{MillisecondProvider}} and {{Sleeper}}, currently 
> defined inside {{PrimaryHandler}} will be moved higher in the (internal) 
> hierarchy for use by other membership classes
> * {{GMSJoinLeave}} will take a {{MillisecondProvider}} and {{Sleeper}} in its 
> constructor and will delegate to those instead of calling 
> {{System.currentTimeMillis()}} and {{Thread.sleep()}} directly
> * TBD other classes may require injection of {{MillisecondProvider}} and 
> {{Sleeper}}
> * TBD other changes may be necessary in cases where collaborating classes 
> currently spin up threads or synchronize between threads e.g. calling 
> {{wait()}}
> * {{locatorsStopWaitingForLocatorWaitTimeIfAllLocatorsContacted()}} will no 
> longer employ {{Thread.sleep()}} nor will it call 
> {{CompletableFuture.get(long timeout, TimeUnit unit)}}—instead it will 
> operate deterministically (ideally in the same thread but not necessarily) 
> with respect to the unit under test.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-8587) Redis glob pattern does not match carriage return, line feed, and tab

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-8587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210513#comment-17210513
 ] 

ASF GitHub Bot commented on GEODE-8587:
---

sabbey37 merged pull request #5608:
URL: https://github.com/apache/geode/pull/5608


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Redis glob pattern does not match carriage return, line feed, and tab
> -
>
> Key: GEODE-8587
> URL: https://issues.apache.org/jira/browse/GEODE-8587
> Project: Geode
>  Issue Type: Bug
>  Components: redis
>Reporter: Sarah Abbey
>Assignee: Sarah Abbey
>Priority: Major
>  Labels: pull-request-available
>
> Glob pattern should match carriage return, line feed, and tab



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Resolved] (GEODE-8587) Redis glob pattern does not match carriage return, line feed, and tab

[Sarah Abbey (Jira)]

 [ 
https://issues.apache.org/jira/browse/GEODE-8587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sarah Abbey resolved GEODE-8587.

Fix Version/s: 1.14.0
   Resolution: Fixed

> Redis glob pattern does not match carriage return, line feed, and tab
> -
>
> Key: GEODE-8587
> URL: https://issues.apache.org/jira/browse/GEODE-8587
> Project: Geode
>  Issue Type: Bug
>  Components: redis
>Reporter: Sarah Abbey
>Assignee: Sarah Abbey
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> Glob pattern should match carriage return, line feed, and tab



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-8587) Redis glob pattern does not match carriage return, line feed, and tab

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-8587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210514#comment-17210514
 ] 

ASF subversion and git services commented on GEODE-8587:


Commit c9ba7fa3566d0f32a5c009539130b7f60bb3b275 in geode's branch 
refs/heads/develop from Sarah
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=c9ba7fa ]

GEODE-8587: Redis glob pattern does not match carriage return, line feed, and 
tab (#5608)



> Redis glob pattern does not match carriage return, line feed, and tab
> -
>
> Key: GEODE-8587
> URL: https://issues.apache.org/jira/browse/GEODE-8587
> Project: Geode
>  Issue Type: Bug
>  Components: redis
>Reporter: Sarah Abbey
>Assignee: Sarah Abbey
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> Glob pattern should match carriage return, line feed, and tab



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (GEODE-8587) Redis glob pattern does not match carriage return, line feed, and tab

[Sarah Abbey (Jira)]

 [ 
https://issues.apache.org/jira/browse/GEODE-8587?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Sarah Abbey updated GEODE-8587:
---
Priority: Minor  (was: Major)

> Redis glob pattern does not match carriage return, line feed, and tab
> -
>
> Key: GEODE-8587
> URL: https://issues.apache.org/jira/browse/GEODE-8587
> Project: Geode
>  Issue Type: Bug
>  Components: redis
>Reporter: Sarah Abbey
>Assignee: Sarah Abbey
>Priority: Minor
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> Glob pattern should match carriage return, line feed, and tab



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-8587) Redis glob pattern does not match carriage return, line feed, and tab

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-8587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210515#comment-17210515
 ] 

ASF subversion and git services commented on GEODE-8587:


Commit c9ba7fa3566d0f32a5c009539130b7f60bb3b275 in geode's branch 
refs/heads/develop from Sarah
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=c9ba7fa ]

GEODE-8587: Redis glob pattern does not match carriage return, line feed, and 
tab (#5608)



> Redis glob pattern does not match carriage return, line feed, and tab
> -
>
> Key: GEODE-8587
> URL: https://issues.apache.org/jira/browse/GEODE-8587
> Project: Geode
>  Issue Type: Bug
>  Components: redis
>Reporter: Sarah Abbey
>Assignee: Sarah Abbey
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> Glob pattern should match carriage return, line feed, and tab



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-8574) ClassCastException when hitting members REST endpoint

[ASF subversion and git services (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-8574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210525#comment-17210525
 ] 

ASF subversion and git services commented on GEODE-8574:


Commit 443aef9e9a1d2b5eaf5db8db68785bfabf4a724b in geode's branch 
refs/heads/support/1.13 from Jinmei Liao
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=443aef9 ]

GEODE-8574: ClusterManagementService should not throw ClassCastExcept… (#5596) 
- spotless

(cherry picked from commit 73f6783b07f1151c1617978fb57822ade5b71414)


> ClassCastException when hitting members REST endpoint
> -
>
> Key: GEODE-8574
> URL: https://issues.apache.org/jira/browse/GEODE-8574
> Project: Geode
>  Issue Type: Improvement
>  Components: rest (admin)
>Affects Versions: 1.13.0
>Reporter: Jason Huynh
>Assignee: Jinmei Liao
>Priority: Major
>  Labels: GeodeOperationAPI, pull-request-available
> Fix For: 1.14.0
>
>
> This might be similar to https://issues.apache.org/jira/browse/GEODE-8078
> We see a FunctionInvocationTargetException when trying to use the rest 
> endpoint while servers are restarting/recovering
> [error 2020/10/01 21:49:57.381 GMT  tid=0x46] class 
> org.apache.geode.cache.execute.FunctionInvocationTargetException cannot be 
> cast to class org.apache.geode.management.runtime.RuntimeInfo 
> (org.apache.geode.cache.execute.FunctionInvocationTargetException and 
> org.apache.geode.management.runtime.RuntimeInfo are in unnamed module of 
> loader 'app')
> java.lang.ClassCastException: class 
> org.apache.geode.cache.execute.FunctionInvocationTargetException cannot be 
> cast to class org.apache.geode.management.runtime.RuntimeInfo 
> (org.apache.geode.cache.execute.FunctionInvocationTargetException and 
> org.apache.geode.management.runtime.RuntimeInfo are in unnamed module of 
> loader 'app')
> at 
> org.apache.geode.management.internal.api.LocatorClusterManagementService.list(LocatorClusterManagementService.java:459)
> at 
> org.apache.geode.management.internal.api.LocatorClusterManagementService.get(LocatorClusterManagementService.java:476)
> at 
> org.apache.geode.management.internal.rest.controllers.MemberManagementController.getMember(MemberManagementController.java:50)
> at 
> org.apache.geode.management.internal.rest.controllers.MemberManagementController$$FastClassBySpringCGLIB$$3634e452.invoke()
> at org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:218)
> at 
> org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.invokeJoinpoint(CglibAopProxy.java:771)
> at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163)
> at 
> org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:749)
> at 
> org.springframework.security.access.intercept.aopalliance.MethodSecurityInterceptor.invoke(MethodSecurityInterceptor.java:61)
> at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186)
> at 
> org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:749)
> at 
> org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:691)
> at 
> org.apache.geode.management.internal.rest.controllers.MemberManagementController$$EnhancerBySpringCGLIB$$ef2756b6.getMember()
> at jdk.internal.reflect.GeneratedMethodAccessor237.invoke(Unknown Source)
> at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:566)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Updated] (GEODE-8574) ClassCastException when hitting members REST endpoint

[Owen Nichols (Jira)]

 [ 
https://issues.apache.org/jira/browse/GEODE-8574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Owen Nichols updated GEODE-8574:

Fix Version/s: 1.13.1

> ClassCastException when hitting members REST endpoint
> -
>
> Key: GEODE-8574
> URL: https://issues.apache.org/jira/browse/GEODE-8574
> Project: Geode
>  Issue Type: Improvement
>  Components: rest (admin)
>Affects Versions: 1.13.0
>Reporter: Jason Huynh
>Assignee: Jinmei Liao
>Priority: Major
>  Labels: GeodeOperationAPI, pull-request-available
> Fix For: 1.14.0, 1.13.1
>
>
> This might be similar to https://issues.apache.org/jira/browse/GEODE-8078
> We see a FunctionInvocationTargetException when trying to use the rest 
> endpoint while servers are restarting/recovering
> [error 2020/10/01 21:49:57.381 GMT  tid=0x46] class 
> org.apache.geode.cache.execute.FunctionInvocationTargetException cannot be 
> cast to class org.apache.geode.management.runtime.RuntimeInfo 
> (org.apache.geode.cache.execute.FunctionInvocationTargetException and 
> org.apache.geode.management.runtime.RuntimeInfo are in unnamed module of 
> loader 'app')
> java.lang.ClassCastException: class 
> org.apache.geode.cache.execute.FunctionInvocationTargetException cannot be 
> cast to class org.apache.geode.management.runtime.RuntimeInfo 
> (org.apache.geode.cache.execute.FunctionInvocationTargetException and 
> org.apache.geode.management.runtime.RuntimeInfo are in unnamed module of 
> loader 'app')
> at 
> org.apache.geode.management.internal.api.LocatorClusterManagementService.list(LocatorClusterManagementService.java:459)
> at 
> org.apache.geode.management.internal.api.LocatorClusterManagementService.get(LocatorClusterManagementService.java:476)
> at 
> org.apache.geode.management.internal.rest.controllers.MemberManagementController.getMember(MemberManagementController.java:50)
> at 
> org.apache.geode.management.internal.rest.controllers.MemberManagementController$$FastClassBySpringCGLIB$$3634e452.invoke()
> at org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:218)
> at 
> org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.invokeJoinpoint(CglibAopProxy.java:771)
> at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163)
> at 
> org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:749)
> at 
> org.springframework.security.access.intercept.aopalliance.MethodSecurityInterceptor.invoke(MethodSecurityInterceptor.java:61)
> at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186)
> at 
> org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:749)
> at 
> org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:691)
> at 
> org.apache.geode.management.internal.rest.controllers.MemberManagementController$$EnhancerBySpringCGLIB$$ef2756b6.getMember()
> at jdk.internal.reflect.GeneratedMethodAccessor237.invoke(Unknown Source)
> at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:566)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-7732) CI Failure: JMXMBeanReconnectDUnitTest.serverMXBeansOnLocatorAreRestoredAfterCrashedServerReturns failed

[Ernest Burghardt (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-7732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210533#comment-17210533
 ] 

Ernest Burghardt commented on GEODE-7732:
-

https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK11/builds/511
 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 
http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0403/test-results/distributedTest/1602200193/
 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 
 
Test report artifacts from this job are available at:
 
 
http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0403/test-artifacts/1602200193/distributedtestfiles-OpenJDK11-1.14.0-build.0403.tgz
 

> CI Failure: 
> JMXMBeanReconnectDUnitTest.serverMXBeansOnLocatorAreRestoredAfterCrashedServerReturns
>  failed
> 
>
> Key: GEODE-7732
> URL: https://issues.apache.org/jira/browse/GEODE-7732
> Project: Geode
>  Issue Type: Bug
>  Components: jmx
>Affects Versions: 1.12.0
>Reporter: Eric Shu
>Assignee: Kirk Lund
>Priority: Major
>  Labels: flaky
> Fix For: 1.13.0
>
>
> This failed @ 
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK11/builds/1487
> {noformat}
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.management.JMXMBeanReconnectDUnitTest$$Lambda$209/0x000840bb5c40.call
>  in VM 2 running on Host e8b6d1c09a6c with 4 VMs
>   at org.apache.geode.test.dunit.VM.executeMethodOnObject(VM.java:610)
>   at org.apache.geode.test.dunit.VM.invoke(VM.java:462)
>   at 
> org.apache.geode.management.JMXMBeanReconnectDUnitTest.setUp(JMXMBeanReconnectDUnitTest.java:177)
>   at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:566)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at 
> org.apache.geode.test.dunit.rules.AbstractDistributedRule$1.evaluate(AbstractDistributedRule.java:59)
>   at 
> org.apache.geode.test.dunit.rules.AbstractDistributedRule$1.evaluate(AbstractDistributedRule.java:59)
>   at 
> org.apache.geode.test.junit.rules.DescribedExternalResource$1.evaluate(DescribedExternalResource.java:40)
>   at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
>   at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.runTestClass(JUnitTestClassExecutor.java:110)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:58)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:38)
>   at 
> org.gradle.api.internal.tasks.testing.junit.AbstractJUnitTestClassProcessor.processTestClass(AbstractJUnitTestClassProcessor.java:62)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
>   at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> jdk.internal.reflect.DelegatingMet

[jira] [Commented] (GEODE-7732) CI Failure: JMXMBeanReconnectDUnitTest.serverMXBeansOnLocatorAreRestoredAfterCrashedServerReturns failed

[Geode Integration (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-7732?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210534#comment-17210534
 ] 

Geode Integration commented on GEODE-7732:
--

Seen in [DistributedTestOpenJDK11 
#511|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK11/builds/511]
 ... see [test 
results|http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0403/test-results/distributedTest/1602200193/]
 or download 
[artifacts|http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0403/test-artifacts/1602200193/distributedtestfiles-OpenJDK11-1.14.0-build.0403.tgz].

> CI Failure: 
> JMXMBeanReconnectDUnitTest.serverMXBeansOnLocatorAreRestoredAfterCrashedServerReturns
>  failed
> 
>
> Key: GEODE-7732
> URL: https://issues.apache.org/jira/browse/GEODE-7732
> Project: Geode
>  Issue Type: Bug
>  Components: jmx
>Affects Versions: 1.12.0
>Reporter: Eric Shu
>Assignee: Kirk Lund
>Priority: Major
>  Labels: flaky
> Fix For: 1.13.0
>
>
> This failed @ 
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK11/builds/1487
> {noformat}
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.management.JMXMBeanReconnectDUnitTest$$Lambda$209/0x000840bb5c40.call
>  in VM 2 running on Host e8b6d1c09a6c with 4 VMs
>   at org.apache.geode.test.dunit.VM.executeMethodOnObject(VM.java:610)
>   at org.apache.geode.test.dunit.VM.invoke(VM.java:462)
>   at 
> org.apache.geode.management.JMXMBeanReconnectDUnitTest.setUp(JMXMBeanReconnectDUnitTest.java:177)
>   at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:566)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at 
> org.apache.geode.test.dunit.rules.AbstractDistributedRule$1.evaluate(AbstractDistributedRule.java:59)
>   at 
> org.apache.geode.test.dunit.rules.AbstractDistributedRule$1.evaluate(AbstractDistributedRule.java:59)
>   at 
> org.apache.geode.test.junit.rules.DescribedExternalResource$1.evaluate(DescribedExternalResource.java:40)
>   at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
>   at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.runTestClass(JUnitTestClassExecutor.java:110)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:58)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:38)
>   at 
> org.gradle.api.internal.tasks.testing.junit.AbstractJUnitTestClassProcessor.processTestClass(AbstractJUnitTestClassProcessor.java:62)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
>   at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:566)
>   at 
> org

[jira] [Issue Comment Deleted] (GEODE-7732) CI Failure: JMXMBeanReconnectDUnitTest.serverMXBeansOnLocatorAreRestoredAfterCrashedServerReturns failed

[Ernest Burghardt (Jira)]

 [ 
https://issues.apache.org/jira/browse/GEODE-7732?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ernest Burghardt updated GEODE-7732:

Comment: was deleted

(was: 
https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK11/builds/511
 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 
http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0403/test-results/distributedTest/1602200193/
 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 
 
Test report artifacts from this job are available at:
 
 
http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0403/test-artifacts/1602200193/distributedtestfiles-OpenJDK11-1.14.0-build.0403.tgz
 )

> CI Failure: 
> JMXMBeanReconnectDUnitTest.serverMXBeansOnLocatorAreRestoredAfterCrashedServerReturns
>  failed
> 
>
> Key: GEODE-7732
> URL: https://issues.apache.org/jira/browse/GEODE-7732
> Project: Geode
>  Issue Type: Bug
>  Components: jmx
>Affects Versions: 1.12.0
>Reporter: Eric Shu
>Assignee: Kirk Lund
>Priority: Major
>  Labels: flaky
> Fix For: 1.13.0
>
>
> This failed @ 
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK11/builds/1487
> {noformat}
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.management.JMXMBeanReconnectDUnitTest$$Lambda$209/0x000840bb5c40.call
>  in VM 2 running on Host e8b6d1c09a6c with 4 VMs
>   at org.apache.geode.test.dunit.VM.executeMethodOnObject(VM.java:610)
>   at org.apache.geode.test.dunit.VM.invoke(VM.java:462)
>   at 
> org.apache.geode.management.JMXMBeanReconnectDUnitTest.setUp(JMXMBeanReconnectDUnitTest.java:177)
>   at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
>   at java.lang.reflect.Method.invoke(Method.java:566)
>   at 
> org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:50)
>   at 
> org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:12)
>   at 
> org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:47)
>   at 
> org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:24)
>   at 
> org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:27)
>   at 
> org.apache.geode.test.dunit.rules.AbstractDistributedRule$1.evaluate(AbstractDistributedRule.java:59)
>   at 
> org.apache.geode.test.dunit.rules.AbstractDistributedRule$1.evaluate(AbstractDistributedRule.java:59)
>   at 
> org.apache.geode.test.junit.rules.DescribedExternalResource$1.evaluate(DescribedExternalResource.java:40)
>   at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:48)
>   at org.junit.rules.RunRules.evaluate(RunRules.java:20)
>   at org.junit.runners.ParentRunner.runLeaf(ParentRunner.java:325)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:78)
>   at 
> org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:57)
>   at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
>   at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
>   at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
>   at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
>   at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
>   at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.runTestClass(JUnitTestClassExecutor.java:110)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:58)
>   at 
> org.gradle.api.internal.tasks.testing.junit.JUnitTestClassExecutor.execute(JUnitTestClassExecutor.java:38)
>   at 
> org.gradle.api.internal.tasks.testing.junit.AbstractJUnitTestClassProcessor.processTestClass(AbstractJUnitTestClassProcessor.java:62)
>   at 
> org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.processTestClass(SuiteTestClassProcessor.java:51)
>   at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
>   at 
> jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>   at 
> jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(D

[jira] [Commented] (GEODE-7710) JMXMBeanReconnectDUnitTest fails intermittently because one locator is missing the LockServiceMXBean

[Ernest Burghardt (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-7710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210535#comment-17210535
 ] 

Ernest Burghardt commented on GEODE-7710:
-

[https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK11/builds/511]
 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 
http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0403/test-results/distributedTest/1602200193/
 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 
 
Test report artifacts from this job are available at:
 
 
http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0403/test-artifacts/1602200193/distributedtestfiles-OpenJDK11-1.14.0-build.0403.tgz
 

> JMXMBeanReconnectDUnitTest fails intermittently because one locator is 
> missing the LockServiceMXBean
> 
>
> Key: GEODE-7710
> URL: https://issues.apache.org/jira/browse/GEODE-7710
> Project: Geode
>  Issue Type: Bug
>  Components: tests
>Affects Versions: 1.13.0
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>Priority: Major
>  Labels: flaky
>  Time Spent: 5h
>  Remaining Estimate: 0h
>
> Multiple tests in JMXMBeanReconnectDUnitTest may fail an await due to one of 
> the locators missing the LockServiceMXBean for the cluster config service.
> {noformat}
> but could not find:
>  
> <[GemFire:service=LockService,name=__CLUSTER_CONFIG_LS,type=Member,member=locator1]>
> {noformat}
> These test failures are caused by *GEODE-7739*.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-7710) JMXMBeanReconnectDUnitTest fails intermittently because one locator is missing the LockServiceMXBean

[Geode Integration (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-7710?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210536#comment-17210536
 ] 

Geode Integration commented on GEODE-7710:
--

Seen in [DistributedTestOpenJDK11 
#511|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK11/builds/511]
 ... see [test 
results|http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0403/test-results/distributedTest/1602200193/]
 or download 
[artifacts|http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0403/test-artifacts/1602200193/distributedtestfiles-OpenJDK11-1.14.0-build.0403.tgz].

> JMXMBeanReconnectDUnitTest fails intermittently because one locator is 
> missing the LockServiceMXBean
> 
>
> Key: GEODE-7710
> URL: https://issues.apache.org/jira/browse/GEODE-7710
> Project: Geode
>  Issue Type: Bug
>  Components: tests
>Affects Versions: 1.13.0
>Reporter: Kirk Lund
>Assignee: Kirk Lund
>Priority: Major
>  Labels: flaky
>  Time Spent: 5h
>  Remaining Estimate: 0h
>
> Multiple tests in JMXMBeanReconnectDUnitTest may fail an await due to one of 
> the locators missing the LockServiceMXBean for the cluster config service.
> {noformat}
> but could not find:
>  
> <[GemFire:service=LockService,name=__CLUSTER_CONFIG_LS,type=Member,member=locator1]>
> {noformat}
> These test failures are caused by *GEODE-7739*.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-7845) Rollingupgrade should not conflict with the new ClearPRMessage

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210540#comment-17210540
 ] 

ASF GitHub Bot commented on GEODE-7845:
---

mhansonp commented on pull request #5577:
URL: https://github.com/apache/geode/pull/5577#issuecomment-705896856


   > Is this PR really changing 69 files?
   
   Nope. I rebased to the latest of feature/GEODE-7665



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Rollingupgrade should not conflict with the new ClearPRMessage 
> ---
>
> Key: GEODE-7845
> URL: https://issues.apache.org/jira/browse/GEODE-7845
> Project: Geode
>  Issue Type: Improvement
>  Components: core
>Reporter: Xiaojian Zhou
>Assignee: Mark Hanson
>Priority: Major
>  Labels: GeodeCommons, pull-request-available
>
> PartitionedRegion clear introduced a new ClearPRMessage. In case of doing 
> rolling upgrade, the user called PR.clear. The new ClearPRMessage should not 
> fail. It should not be sent to the old members. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-8554) CI Failure: JMXMBeanReconnectDUnitTest.locatorMXBeansOnOtherLocatorAreRestoredAfterCrashedLocatorReturns

[Jens Deppe (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-8554?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210545#comment-17210545
 ] 

Jens Deppe commented on GEODE-8554:
---

Similar issue:

 

=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0403/test-results/distributedTest/1602200193/
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

Test report artifacts from this job are available at:

http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0403/test-artifacts/1602200193/distributedtestfiles-OpenJDK11-1.14.0-build.0403.tgz

> CI Failure: 
> JMXMBeanReconnectDUnitTest.locatorMXBeansOnOtherLocatorAreRestoredAfterCrashedLocatorReturns
> 
>
> Key: GEODE-8554
> URL: https://issues.apache.org/jira/browse/GEODE-8554
> Project: Geode
>  Issue Type: Bug
>Reporter: Jianxia Chen
>Assignee: Kirk Lund
>Priority: Major
>
> {noformat}
> org.apache.geode.management.JMXMBeanReconnectDUnitTest > 
> locatorMXBeansOnOtherLocatorAreRestoredAfterCrashedLocatorReturns FAILED
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.management.JMXMBeanReconnectDUnitTest$$Lambda$355/858468979.call
>  in VM -1 running on Host 7a5c340f5c23 with 4 VMs
> at org.apache.geode.test.dunit.VM.executeMethodOnObject(VM.java:620)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:472)
> at 
> org.apache.geode.management.JMXMBeanReconnectDUnitTest.setUp(JMXMBeanReconnectDUnitTest.java:191)
> Caused by:
> org.awaitility.core.ConditionTimeoutException: Assertion condition 
> defined as a lambda expression in 
> org.apache.geode.management.JMXMBeanReconnectDUnitTest [GemFire mbeans on 
> locator2] 
> Expecting HashSet:
>  <[GemFire:type=Member,member=locator1,
> 
> GemFire:service=LockService,name=__CLUSTER_CONFIG_LS,type=Member,member=locator2,
> GemFire:type=Member,member=server1,
> GemFire:service=Manager,type=Member,member=locator1,
> GemFire:service=Locator,type=Member,member=locator2,
> GemFire:type=Member,member=locator2,
> GemFire:service=Region,name=/region1,type=Member,member=server1,
> GemFire:service=FileUploader,type=Distributed,
> 
> GemFire:service=DiskStore,name=cluster_config,type=Member,member=locator2,
> GemFire:service=Manager,type=Member,member=locator2,
> GemFire:service=Locator,type=Member,member=locator1,
> GemFire:service=System,type=Distributed,
> GemFire:service=AccessControl,type=Distributed,
> 
> GemFire:service=LockService,name=__CLUSTER_CONFIG_LS,type=Distributed,
> GemFire:service=Region,name=/region1,type=Distributed]>
> to contain:
>  <[GemFire:type=Member,member=locator1,
> GemFire:service=Locator,type=Member,member=locator1,
> GemFire:service=Manager,type=Member,member=locator1,
> 
> GemFire:service=DiskStore,name=cluster_config,type=Member,member=locator1,
> 
> GemFire:service=LockService,name=__CLUSTER_CONFIG_LS,type=Member,member=locator1]>
> but could not find the following element(s):
>  
> <[GemFire:service=DiskStore,name=cluster_config,type=Member,member=locator1,
> 
> GemFire:service=LockService,name=__CLUSTER_CONFIG_LS,type=Member,member=locator1]>
>  within 5 minutes.
> at 
> org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:165)
> at 
> org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
> at 
> org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
> at 
> org.awaitility.core.ConditionFactory.until(ConditionFactory.java:895)
> at 
> org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:679)
> at 
> org.apache.geode.management.JMXMBeanReconnectDUnitTest.lambda$setUp$515fd116$3(JMXMBeanReconnectDUnitTest.java:192)
> at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> at 
> sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
> at 
> sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.lang.reflect.Method.invoke(Method.java:498)
> at 
> org.apache.geode.test.dunit.internal.MethodInvoker.executeObject(MethodInvoker.java:123)
> at 
> org.apache.geode.test.dunit.internal.RemoteDUnitVM.executeMethodOnObject(RemoteDUnitVM.java:78)
> at 
> org

[jira] [Commented] (GEODE-7845) Rollingupgrade should not conflict with the new ClearPRMessage

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210546#comment-17210546
 ] 

ASF GitHub Bot commented on GEODE-7845:
---

mhansonp commented on a change in pull request #5577:
URL: https://github.com/apache/geode/pull/5577#discussion_r502103297



##
File path: 
geode-core/src/main/java/org/apache/geode/cache/PartitionedRegionVersionException.java
##
@@ -0,0 +1,29 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more 
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional 
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache 
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the 
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software 
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY 
KIND, either express
+ * or implied. See the License for the specific language governing permissions 
and limitations under
+ * the License.
+ */
+package org.apache.geode.cache;

Review comment:
   We looked and found that the other errors of this type were all in the 
same package. If we move this one, we should move the rest, but given they are 
all public API, I think it is best to skip.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Rollingupgrade should not conflict with the new ClearPRMessage 
> ---
>
> Key: GEODE-7845
> URL: https://issues.apache.org/jira/browse/GEODE-7845
> Project: Geode
>  Issue Type: Improvement
>  Components: core
>Reporter: Xiaojian Zhou
>Assignee: Mark Hanson
>Priority: Major
>  Labels: GeodeCommons, pull-request-available
>
> PartitionedRegion clear introduced a new ClearPRMessage. In case of doing 
> rolling upgrade, the user called PR.clear. The new ClearPRMessage should not 
> fail. It should not be sent to the old members. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-8266) StatForNotQueuedConflated not incremented in time

[Jens Deppe (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-8266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210547#comment-17210547
 ] 

Jens Deppe commented on GEODE-8266:
---

Recurring failure:

 

=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0405/test-results/test/1602201871/
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

Test report artifacts from this job are available at:

http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0405/test-artifacts/1602201871/windows-unittestfiles-OpenJDK8-1.14.0-build.0405.tgz

> StatForNotQueuedConflated not incremented in time
> -
>
> Key: GEODE-8266
> URL: https://issues.apache.org/jira/browse/GEODE-8266
> Project: Geode
>  Issue Type: Bug
>  Components: wan
>Reporter: Bill Burcham
>Priority: Major
>
> Failed here: 
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/WindowsUnitTestOpenJDK11/builds/259#A
> {code}
> org.apache.geode.internal.cache.wan.parallel.ParallelGatewaySenderQueueJUnitTest
>  > 
> whenNullPeekedEventFromBucketRegionQueueTheStatForNotQueuedConflatedShouldBeIncremented
>  FAILED
> java.lang.AssertionError: expected:<1> but was:<0>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:834)
> at org.junit.Assert.assertEquals(Assert.java:645)
> at org.junit.Assert.assertEquals(Assert.java:631)
> at 
> org.apache.geode.internal.cache.wan.parallel.ParallelGatewaySenderQueueJUnitTest.whenNullPeekedEventFromBucketRegionQueueTheStatForNotQueuedConflatedShouldBeIncremented(ParallelGatewaySenderQueueJUnitTest.java:146)
> {code}
> It appears we are waiting 100ms for the statistic to be incremented. Perhaps 
> we need to wait longer. Or maybe there is product bug here?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-8266) StatForNotQueuedConflated not incremented in time

[Geode Integration (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-8266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210548#comment-17210548
 ] 

Geode Integration commented on GEODE-8266:
--

Seen in [WindowsUnitTestOpenJDK8 
#496|https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/WindowsUnitTestOpenJDK8/builds/496]
 ... see [test 
results|http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0405/test-results/test/1602201871/]
 or download 
[artifacts|http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0405/test-artifacts/1602201871/windows-unittestfiles-OpenJDK8-1.14.0-build.0405.tgz].

> StatForNotQueuedConflated not incremented in time
> -
>
> Key: GEODE-8266
> URL: https://issues.apache.org/jira/browse/GEODE-8266
> Project: Geode
>  Issue Type: Bug
>  Components: wan
>Reporter: Bill Burcham
>Priority: Major
>
> Failed here: 
> https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/WindowsUnitTestOpenJDK11/builds/259#A
> {code}
> org.apache.geode.internal.cache.wan.parallel.ParallelGatewaySenderQueueJUnitTest
>  > 
> whenNullPeekedEventFromBucketRegionQueueTheStatForNotQueuedConflatedShouldBeIncremented
>  FAILED
> java.lang.AssertionError: expected:<1> but was:<0>
> at org.junit.Assert.fail(Assert.java:88)
> at org.junit.Assert.failNotEquals(Assert.java:834)
> at org.junit.Assert.assertEquals(Assert.java:645)
> at org.junit.Assert.assertEquals(Assert.java:631)
> at 
> org.apache.geode.internal.cache.wan.parallel.ParallelGatewaySenderQueueJUnitTest.whenNullPeekedEventFromBucketRegionQueueTheStatForNotQueuedConflatedShouldBeIncremented(ParallelGatewaySenderQueueJUnitTest.java:146)
> {code}
> It appears we are waiting 100ms for the statistic to be incremented. Perhaps 
> we need to wait longer. Or maybe there is product bug here?



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Commented] (GEODE-7845) Rollingupgrade should not conflict with the new ClearPRMessage

[ASF GitHub Bot (Jira)]

[ 
https://issues.apache.org/jira/browse/GEODE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210549#comment-17210549
 ] 

ASF GitHub Bot commented on GEODE-7845:
---

mhansonp commented on pull request #5577:
URL: https://github.com/apache/geode/pull/5577#issuecomment-705903342


   @jujoramos @jinmeiliao 
   > @mhansonp: just FYI, I have an old 
[PR](https://github.com/apache/geode/pull/5393) opened (draft as the feature is 
not yet implemented) to test the backward compatibility of the `clear` 
operation, it might be useful for your current work.
   
   I looked at the Juan's code and it looked like the code I really needed (the 
core of the tests) had not been implemented yet, so it was not as much help as 
I hoped.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Rollingupgrade should not conflict with the new ClearPRMessage 
> ---
>
> Key: GEODE-7845
> URL: https://issues.apache.org/jira/browse/GEODE-7845
> Project: Geode
>  Issue Type: Improvement
>  Components: core
>Reporter: Xiaojian Zhou
>Assignee: Mark Hanson
>Priority: Major
>  Labels: GeodeCommons, pull-request-available
>
> PartitionedRegion clear introduced a new ClearPRMessage. In case of doing 
> rolling upgrade, the user called PR.clear. The new ClearPRMessage should not 
> fail. It should not be sent to the old members. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Assigned] (GEODE-8590) Session state modules leak dependencies in POM

[Jacob Barrett (Jira)]

 [ 
https://issues.apache.org/jira/browse/GEODE-8590?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jacob Barrett reassigned GEODE-8590:


Assignee: Jacob Barrett

> Session state modules leak dependencies in POM
> --
>
> Key: GEODE-8590
> URL: https://issues.apache.org/jira/browse/GEODE-8590
> Project: Geode
>  Issue Type: Bug
>  Components: http session
>Reporter: Jacob Barrett
>Assignee: Jacob Barrett
>Priority: Major
>
> The http session state modules leak dependencies through the POM. Many of the 
> dependencies listed aren't even required. Many of those listed should be 
> compileOnly/provided scope since the modules are designed to be dropped into 
> a container which provides many of those dependencies.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

[jira] [Created] (GEODE-8590) Session state modules leak dependencies in POM

[Jacob Barrett (Jira)]

Jacob Barrett created GEODE-8590:


 Summary: Session state modules leak dependencies in POM
 Key: GEODE-8590
 URL: https://issues.apache.org/jira/browse/GEODE-8590
 Project: Geode
  Issue Type: Bug
  Components: http session
Reporter: Jacob Barrett


The http session state modules leak dependencies through the POM. Many of the 
dependencies listed aren't even required. Many of those listed should be 
compileOnly/provided scope since the modules are designed to be dropped into a 
container which provides many of those dependencies.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)