[
https://issues.apache.org/jira/browse/GEODE-8583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17210320#comment-17210320
]
ASF GitHub Bot commented on GEODE-8583:
---------------------------------------
jhutchison commented on a change in pull request #5604:
URL: https://github.com/apache/geode/pull/5604#discussion_r501861215
##########
File path:
geode-redis/src/main/java/org/apache/geode/redis/internal/GeodeRedisServer.java
##########
@@ -93,13 +86,21 @@ public GeodeRedisServer(String bindAddress, int port,
InternalCache cache) {
CommandFunction.register(regionProvider.getDataRegion(), stripedExecutor,
redisStats);
RenameFunction.register(regionProvider.getDataRegion(), stripedExecutor,
redisStats);
RedisCommandFunction.register();
+
passiveExpirationManager =
new PassiveExpirationManager(regionProvider.getDataRegion(),
redisStats);
- redisCommandExecutor =
LoggingExecutors.newCachedThreadPool("GeodeRedisServer-Command-", true);
- nettyRedisServer = new NettyRedisServer(() ->
cache.getInternalDistributedSystem().getConfig(),
- regionProvider, pubSub,
- this::allowUnsupportedCommands, this::shutdown, port, bindAddress,
redisStats,
- redisCommandExecutor);
+ redisCommandExecutor =
+ LoggingExecutors.newCachedThreadPool("Redis Command", true);
Review comment:
makes sense. I think I'm going to slowly lobby to see if I can get some
things updated in Spotless...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> create RestrictedInputValuesParameterRequirements in Redis Module
> -----------------------------------------------------------------
>
> Key: GEODE-8583
> URL: https://issues.apache.org/jira/browse/GEODE-8583
> Project: Geode
> Issue Type: Improvement
> Reporter: John Hutchison
> Priority: Minor
> Labels: pull-request-available, redis
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
