[jira] [Commented] (GEODE-8546) Colocated regions missing some buckets after restart

2020-10-05 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8546?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17207952#comment-17207952
 ] 

ASF GitHub Bot commented on GEODE-8546:
---

mivanac opened a new pull request #5590:
URL: https://github.com/apache/geode/pull/5590


   Co-authored-by: Mario Kevo mario.k...@est.tech
   
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [*] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?
   
   - [*] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?
   
   - [*] Is your initial contribution a single, squashed commit?
   
   - [*] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, check Concourse for build 
issues and
   submit an update to your PR as soon as possible. If you need help, please 
send an
   email to d...@geode.apache.org.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Colocated regions missing some buckets after restart
> 
>
> Key: GEODE-8546
> URL: https://issues.apache.org/jira/browse/GEODE-8546
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Affects Versions: 1.11.0, 1.12.0, 1.13.0
>Reporter: Mario Kevo
>Assignee: Mario Kevo
>Priority: Major
>
> After restart all servers at the same time, some colocation regions missing 
> some buckets.
> This issue exist for a long time and become visible from 1.11.0 by 
> introducing this changes GEODE-7042 .
> How to reproduce the issue:
>  #  Start two locators and two servers
>  #  Create PARTITION_REDUNDANT_PERSISTENT region with redundant-copies=1
>  #  Create few PARTITION_REDUNDANT regions(I used six regions) colocated with 
> persistent region and redundant-copies=1
>  #  Put some entries.
>  #  Restart servers(you can simply run "kill -15 " and then from 
> two terminals start both of them at the same time)
>  #  It will take a time to get server startup finished and for the latest 
> region bucketCount will be lower than expected on one member



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (GEODE-8546) Colocated regions missing some buckets after restart

2020-10-05 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-8546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated GEODE-8546:
--
Labels: pull-request-available  (was: )

> Colocated regions missing some buckets after restart
> 
>
> Key: GEODE-8546
> URL: https://issues.apache.org/jira/browse/GEODE-8546
> Project: Geode
>  Issue Type: Bug
>  Components: regions
>Affects Versions: 1.11.0, 1.12.0, 1.13.0
>Reporter: Mario Kevo
>Assignee: Mario Kevo
>Priority: Major
>  Labels: pull-request-available
>
> After restart all servers at the same time, some colocation regions missing 
> some buckets.
> This issue exist for a long time and become visible from 1.11.0 by 
> introducing this changes GEODE-7042 .
> How to reproduce the issue:
>  #  Start two locators and two servers
>  #  Create PARTITION_REDUNDANT_PERSISTENT region with redundant-copies=1
>  #  Create few PARTITION_REDUNDANT regions(I used six regions) colocated with 
> persistent region and redundant-copies=1
>  #  Put some entries.
>  #  Restart servers(you can simply run "kill -15 " and then from 
> two terminals start both of them at the same time)
>  #  It will take a time to get server startup finished and for the latest 
> region bucketCount will be lower than expected on one member



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8480) Add tx manager check in geode-native transaction example

2020-10-05 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17207995#comment-17207995
 ] 

ASF GitHub Bot commented on GEODE-8480:
---

alb3rtobr commented on pull request #648:
URL: https://github.com/apache/geode-native/pull/648#issuecomment-703556959


   PR rebased to fix conflict with `CMakeLists.txt`



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add tx manager check in geode-native transaction example
> 
>
> Key: GEODE-8480
> URL: https://issues.apache.org/jira/browse/GEODE-8480
> Project: Geode
>  Issue Type: Improvement
>  Components: docs, native client
>Reporter: Alberto Bustamante Reyes
>Assignee: Alberto Bustamante Reyes
>Priority: Minor
>  Labels: pull-request-available
>
> Transactions documentation & example in the geode C++ client is not checking 
> if the transaction manager exists before calling to rollback, as it is done 
> in the transactions documentation and example in geode.
> I have seen that depending on the exception, the rollback can generate an 
> error so I think its something that should be added to the example.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (GEODE-8531) Coredump when removing an entry

2020-10-05 Thread Mario Salazar de Torres (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-8531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mario Salazar de Torres reassigned GEODE-8531:
--

Assignee: Mario Salazar de Torres

> Coredump when removing an entry
> ---
>
> Key: GEODE-8531
> URL: https://issues.apache.org/jira/browse/GEODE-8531
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Mario Salazar de Torres
>Assignee: Mario Salazar de Torres
>Priority: Major
> Attachments: notifications-no-massif.log
>
>
> The scenario is the following:
> *HAVING* a configured concurrency-checks-enabled=false in the 
> client-cache.xml for a region
> *HAVING* a configured subscription-notification for the pool on which the 
> region is defined
> *HAVING* regsitered interest on all the keys of this region, values included
> *WHEN* a LOCAL_DESTROY notification arrives and therefore 
> {color:#4c9aff}MapSegment::remove{color}{color:#172b4d} is called{color}
> {color:#172b4d}*THEN* the application crashes, claiming that the variable 
> entry is a nullptr.{color}
>  
> This is the segmentation report:
> {code:java}
> [debug 2020/09/24 17:21:07.263036 CEST DESKTOP-3SQUK3P:586546 
> 140013383710464] Region::destroy: region [/region] destroying key 
> [entry-152150]
> Segmentation fault
> *** Segmentation fault
> Register dump: RAX:    RBX:    RCX: 
> 
>  RDX:    RSI: 7f57580008e0   RDI: 7f5767ffe670
>  RBP: 7f5767ffe6c0   R8 : 7f5758000d70   R9 : 563da49f0ac0
>  R10: 000c   R11: 7f57815a2058   R12: 563da6971a48
>  R13: 563da696dbd0   R14:    R15: 7ffd06db85a0
>  RSP: 7f5767ffe610 RIP: 7f578159ac47   EFLAGS: 00010202 CS: 0033   
> FS:    GS:  Trap: 000e   Error: 0004   OldMask:    
> CR2:  FPUCW: 037f   FPUSW:    TAG: 7f57
>  RIP: 80b37f70   RDP:  ST(0)     ST(1)  
> 
>  ST(2)     ST(3)  
>  ST(4)     ST(5)  c000
>  ST(6)  c000   ST(7) e000 e000
>  mxcsr: 1f80
>  XMM0:  25252525 XMM1:  
> 25252525
>  XMM2:  25252525 XMM3:  
> 25252525
>  XMM4:  25252525 XMM5:  
> 25252525
>  XMM6:  25252525 XMM7:  
> 25252525
>  XMM8:  25252525 XMM9:  
> 25252525
>  XMM10: 25252525 XMM11: 
> 25252525
>  XMM12: 25252525 XMM13: 
> 25252525
>  XMM14: 25252525 XMM15: 
> 25252525Backtrace:
> /usr/local/lib/libapache-geode.so(_ZN6apache5geode6client10MapSegment6removeERKSt10shared_ptrINS1_12CacheableKeyEERS3_INS1_12SerializableEERS3_INS1_12MapEntryImplEEiS3_INS1_10VersionTagEEbRb+0x287)[0x7f578159ac47]
> /usr/local/lib/libapache-geode.so(_ZN6apache5geode6client20ConcurrentEntriesMap6removeERKSt10shared_ptrINS1_12CacheableKeyEERS3_INS1_12SerializableEERS3_INS1_12MapEntryImplEEiS3_INS1_10VersionTagEEb+0xa0)[0x7f57814e1782]
> /usr/local/lib/libapache-geode.so(+0x77173d)[0x7f578157673d]
> /usr/local/lib/libapache-geode.so(_ZN6apache5geode6client11LocalRegion13updateNoThrowINS1_14DestroyActionsEEE9GfErrTypeRKSt10shared_ptrINS1_12CacheableKeyEERKS6_INS1_12SerializableEESE_RSC_iNS1_15CacheEventFlagsES6_INS1_10VersionTagEEPNS1_9DataInputES6_INS1_7EventIdEE+0x515)[0x7f578157af2b]
> /usr/local/lib/libapache-geode.so(_ZN6apache5geode6client11LocalRegion14destroyNoThrowERKSt10shared_ptrINS1_12CacheableKeyEERKS3_INS1_12SerializableEEiNS1_15CacheEventFlagsES3_INS1_10VersionTagEE+0xae)[0x7f578156cf9a]
> /usr/local/lib/libapache-geode.so(_ZN6apache5geode6client16ThinClientRegion25clientNotificationHandlerERNS1_10TcrMessageE+0x1dd)[0x7f57816e13bf]
> /usr/local/lib/libapache-geode.so(_ZN6apache5geode6client16ThinClientRegion19receiveNotificationEPNS1_10TcrMessageE+0x124)[0x7f57816e1fd4]
> /usr/local/lib/libapache-geode.so(+0x86dbc2)[0x7f5781672bc2]
> /usr/local/lib/libapache-geode.so(+0x871aec)[0x7f5781676aec]
> /usr/local/lib/libapache-geode.so(+0x8726a4)[0x7f57816776a4]
> /usr/local/lib/libapache-geode.so(+0x871bba)[0x7f5781676bba]
> /usr/local/lib/libapache-geode.so(+0x873683)[0x7f5781678683]
> /usr/local/lib/libapache-geode.so(+0x873624)[0x7f5781678624]
> /usr/local/lib/libapache-geode.so(_ZNSt6thread11_State_implINS_8_InvokerISt5tupleIJMN6apache5geode6client4TaskINS5_11TcrEndpointEEEFvvEPS8_E6_M_runEv+0x1c)[0x7f57816785f4]
> /usr/lib/x86_64-linux-gnu/libstdc++

[jira] [Commented] (GEODE-8531) Coredump when removing an entry

2020-10-05 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208017#comment-17208017
 ] 

ASF GitHub Bot commented on GEODE-8531:
---

gaussianrecurrence opened a new pull request #667:
URL: https://github.com/apache/geode-native/pull/667


- Fixed a coredump in MapSegment::remove whenever the the region holding the
  MapSegment object had consistency checks disabled.
- Added an integration test in RegisterKeysTest TS as it was were this issue
  was detected.
   
   ---
   **Linux tests** list:
   - [ ]  Unit tests passed.
   - [ ]  Old integration tests passed.
   - [ ]  New integration tests passed.
   - [ ]  Acceptance tests passed.
   
   
   
   **Windows tests** list:
   - [ ]  Unit tests passed.
   - [ ]  Old integration tests passed.
   - [ ]  New integration tests passed.
   - [ ]  Acceptance tests passed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Coredump when removing an entry
> ---
>
> Key: GEODE-8531
> URL: https://issues.apache.org/jira/browse/GEODE-8531
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Mario Salazar de Torres
>Assignee: Mario Salazar de Torres
>Priority: Major
> Attachments: notifications-no-massif.log
>
>
> The scenario is the following:
> *HAVING* a configured concurrency-checks-enabled=false in the 
> client-cache.xml for a region
> *HAVING* a configured subscription-notification for the pool on which the 
> region is defined
> *HAVING* regsitered interest on all the keys of this region, values included
> *WHEN* a LOCAL_DESTROY notification arrives and therefore 
> {color:#4c9aff}MapSegment::remove{color}{color:#172b4d} is called{color}
> {color:#172b4d}*THEN* the application crashes, claiming that the variable 
> entry is a nullptr.{color}
>  
> This is the segmentation report:
> {code:java}
> [debug 2020/09/24 17:21:07.263036 CEST DESKTOP-3SQUK3P:586546 
> 140013383710464] Region::destroy: region [/region] destroying key 
> [entry-152150]
> Segmentation fault
> *** Segmentation fault
> Register dump: RAX:    RBX:    RCX: 
> 
>  RDX:    RSI: 7f57580008e0   RDI: 7f5767ffe670
>  RBP: 7f5767ffe6c0   R8 : 7f5758000d70   R9 : 563da49f0ac0
>  R10: 000c   R11: 7f57815a2058   R12: 563da6971a48
>  R13: 563da696dbd0   R14:    R15: 7ffd06db85a0
>  RSP: 7f5767ffe610 RIP: 7f578159ac47   EFLAGS: 00010202 CS: 0033   
> FS:    GS:  Trap: 000e   Error: 0004   OldMask:    
> CR2:  FPUCW: 037f   FPUSW:    TAG: 7f57
>  RIP: 80b37f70   RDP:  ST(0)     ST(1)  
> 
>  ST(2)     ST(3)  
>  ST(4)     ST(5)  c000
>  ST(6)  c000   ST(7) e000 e000
>  mxcsr: 1f80
>  XMM0:  25252525 XMM1:  
> 25252525
>  XMM2:  25252525 XMM3:  
> 25252525
>  XMM4:  25252525 XMM5:  
> 25252525
>  XMM6:  25252525 XMM7:  
> 25252525
>  XMM8:  25252525 XMM9:  
> 25252525
>  XMM10: 25252525 XMM11: 
> 25252525
>  XMM12: 25252525 XMM13: 
> 25252525
>  XMM14: 25252525 XMM15: 
> 25252525Backtrace:
> /usr/local/lib/libapache-geode.so(_ZN6apache5geode6client10MapSegment6removeERKSt10shared_ptrINS1_12CacheableKeyEERS3_INS1_12SerializableEERS3_INS1_12MapEntryImplEEiS3_INS1_10VersionTagEEbRb+0x287)[0x7f578159ac47]
> /usr/local/lib/libapache-geode.so(_ZN6apache5geode6client20ConcurrentEntriesMap6removeERKSt10shared_ptrINS1_12CacheableKeyEERS3_INS1_12SerializableEERS3_INS1_12MapEntryImplEEiS3_INS1_10VersionTagEEb+0xa0)[0x7f57814e1782]
> /usr/local/lib/libapache-geode.so(+0x77173d)[0x7f578157673d]
> /usr/local/lib/libapache-geode.so(_ZN6apache5geode6client11LocalRegion13updateNoThrowINS1_14DestroyActionsEEE9GfErrTypeRKSt10shared_ptrINS1_12CacheableKeyEERKS6_INS1_12SerializableEESE_RSC_iNS1_15CacheEventFlagsES6_INS1_10VersionTagEEPNS1_9DataInputES6_INS1_7EventIdEE+0x515)[0x7f578157af2b]
> /usr/local/lib/libapache-geode.so(_ZN6apache5geode6client11LocalRegion14dest

[jira] [Updated] (GEODE-8531) Coredump when removing an entry

2020-10-05 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-8531?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated GEODE-8531:
--
Labels: pull-request-available  (was: )

> Coredump when removing an entry
> ---
>
> Key: GEODE-8531
> URL: https://issues.apache.org/jira/browse/GEODE-8531
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Mario Salazar de Torres
>Assignee: Mario Salazar de Torres
>Priority: Major
>  Labels: pull-request-available
> Attachments: notifications-no-massif.log
>
>
> The scenario is the following:
> *HAVING* a configured concurrency-checks-enabled=false in the 
> client-cache.xml for a region
> *HAVING* a configured subscription-notification for the pool on which the 
> region is defined
> *HAVING* regsitered interest on all the keys of this region, values included
> *WHEN* a LOCAL_DESTROY notification arrives and therefore 
> {color:#4c9aff}MapSegment::remove{color}{color:#172b4d} is called{color}
> {color:#172b4d}*THEN* the application crashes, claiming that the variable 
> entry is a nullptr.{color}
>  
> This is the segmentation report:
> {code:java}
> [debug 2020/09/24 17:21:07.263036 CEST DESKTOP-3SQUK3P:586546 
> 140013383710464] Region::destroy: region [/region] destroying key 
> [entry-152150]
> Segmentation fault
> *** Segmentation fault
> Register dump: RAX:    RBX:    RCX: 
> 
>  RDX:    RSI: 7f57580008e0   RDI: 7f5767ffe670
>  RBP: 7f5767ffe6c0   R8 : 7f5758000d70   R9 : 563da49f0ac0
>  R10: 000c   R11: 7f57815a2058   R12: 563da6971a48
>  R13: 563da696dbd0   R14:    R15: 7ffd06db85a0
>  RSP: 7f5767ffe610 RIP: 7f578159ac47   EFLAGS: 00010202 CS: 0033   
> FS:    GS:  Trap: 000e   Error: 0004   OldMask:    
> CR2:  FPUCW: 037f   FPUSW:    TAG: 7f57
>  RIP: 80b37f70   RDP:  ST(0)     ST(1)  
> 
>  ST(2)     ST(3)  
>  ST(4)     ST(5)  c000
>  ST(6)  c000   ST(7) e000 e000
>  mxcsr: 1f80
>  XMM0:  25252525 XMM1:  
> 25252525
>  XMM2:  25252525 XMM3:  
> 25252525
>  XMM4:  25252525 XMM5:  
> 25252525
>  XMM6:  25252525 XMM7:  
> 25252525
>  XMM8:  25252525 XMM9:  
> 25252525
>  XMM10: 25252525 XMM11: 
> 25252525
>  XMM12: 25252525 XMM13: 
> 25252525
>  XMM14: 25252525 XMM15: 
> 25252525Backtrace:
> /usr/local/lib/libapache-geode.so(_ZN6apache5geode6client10MapSegment6removeERKSt10shared_ptrINS1_12CacheableKeyEERS3_INS1_12SerializableEERS3_INS1_12MapEntryImplEEiS3_INS1_10VersionTagEEbRb+0x287)[0x7f578159ac47]
> /usr/local/lib/libapache-geode.so(_ZN6apache5geode6client20ConcurrentEntriesMap6removeERKSt10shared_ptrINS1_12CacheableKeyEERS3_INS1_12SerializableEERS3_INS1_12MapEntryImplEEiS3_INS1_10VersionTagEEb+0xa0)[0x7f57814e1782]
> /usr/local/lib/libapache-geode.so(+0x77173d)[0x7f578157673d]
> /usr/local/lib/libapache-geode.so(_ZN6apache5geode6client11LocalRegion13updateNoThrowINS1_14DestroyActionsEEE9GfErrTypeRKSt10shared_ptrINS1_12CacheableKeyEERKS6_INS1_12SerializableEESE_RSC_iNS1_15CacheEventFlagsES6_INS1_10VersionTagEEPNS1_9DataInputES6_INS1_7EventIdEE+0x515)[0x7f578157af2b]
> /usr/local/lib/libapache-geode.so(_ZN6apache5geode6client11LocalRegion14destroyNoThrowERKSt10shared_ptrINS1_12CacheableKeyEERKS3_INS1_12SerializableEEiNS1_15CacheEventFlagsES3_INS1_10VersionTagEE+0xae)[0x7f578156cf9a]
> /usr/local/lib/libapache-geode.so(_ZN6apache5geode6client16ThinClientRegion25clientNotificationHandlerERNS1_10TcrMessageE+0x1dd)[0x7f57816e13bf]
> /usr/local/lib/libapache-geode.so(_ZN6apache5geode6client16ThinClientRegion19receiveNotificationEPNS1_10TcrMessageE+0x124)[0x7f57816e1fd4]
> /usr/local/lib/libapache-geode.so(+0x86dbc2)[0x7f5781672bc2]
> /usr/local/lib/libapache-geode.so(+0x871aec)[0x7f5781676aec]
> /usr/local/lib/libapache-geode.so(+0x8726a4)[0x7f57816776a4]
> /usr/local/lib/libapache-geode.so(+0x871bba)[0x7f5781676bba]
> /usr/local/lib/libapache-geode.so(+0x873683)[0x7f5781678683]
> /usr/local/lib/libapache-geode.so(+0x873624)[0x7f5781678624]
> /usr/local/lib/libapache-geode.so(_ZNSt6thread11_State_implINS_8_InvokerISt5tupleIJMN6apache5geode6client4TaskINS5_11TcrEndpointEEEFvvEPS8_E6_M_runEv+0x1c)[0x7f57816785f4]
> /usr/lib

[jira] [Commented] (GEODE-8531) Coredump when removing an entry

2020-10-05 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8531?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208027#comment-17208027
 ] 

ASF GitHub Bot commented on GEODE-8531:
---

gaussianrecurrence commented on pull request #667:
URL: https://github.com/apache/geode-native/pull/667#issuecomment-703578739


   **Revision 1** uploaded:
   
   - [x] clang-format executed.
   
   **Linux tests** list:
   - [x]  Unit tests passed.
   - [ ]  Old integration tests passed.
   - [ ]  New integration tests passed.
   - [ ]  Acceptance tests passed.
   
   
   
   **Windows tests** list:
   - [ ]  Unit tests passed.
   - [ ]  Old integration tests passed.
   - [ ]  New integration tests passed.
   - [ ]  Acceptance tests passed.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Coredump when removing an entry
> ---
>
> Key: GEODE-8531
> URL: https://issues.apache.org/jira/browse/GEODE-8531
> Project: Geode
>  Issue Type: Bug
>  Components: native client
>Reporter: Mario Salazar de Torres
>Assignee: Mario Salazar de Torres
>Priority: Major
>  Labels: pull-request-available
> Attachments: notifications-no-massif.log
>
>
> The scenario is the following:
> *HAVING* a configured concurrency-checks-enabled=false in the 
> client-cache.xml for a region
> *HAVING* a configured subscription-notification for the pool on which the 
> region is defined
> *HAVING* regsitered interest on all the keys of this region, values included
> *WHEN* a LOCAL_DESTROY notification arrives and therefore 
> {color:#4c9aff}MapSegment::remove{color}{color:#172b4d} is called{color}
> {color:#172b4d}*THEN* the application crashes, claiming that the variable 
> entry is a nullptr.{color}
>  
> This is the segmentation report:
> {code:java}
> [debug 2020/09/24 17:21:07.263036 CEST DESKTOP-3SQUK3P:586546 
> 140013383710464] Region::destroy: region [/region] destroying key 
> [entry-152150]
> Segmentation fault
> *** Segmentation fault
> Register dump: RAX:    RBX:    RCX: 
> 
>  RDX:    RSI: 7f57580008e0   RDI: 7f5767ffe670
>  RBP: 7f5767ffe6c0   R8 : 7f5758000d70   R9 : 563da49f0ac0
>  R10: 000c   R11: 7f57815a2058   R12: 563da6971a48
>  R13: 563da696dbd0   R14:    R15: 7ffd06db85a0
>  RSP: 7f5767ffe610 RIP: 7f578159ac47   EFLAGS: 00010202 CS: 0033   
> FS:    GS:  Trap: 000e   Error: 0004   OldMask:    
> CR2:  FPUCW: 037f   FPUSW:    TAG: 7f57
>  RIP: 80b37f70   RDP:  ST(0)     ST(1)  
> 
>  ST(2)     ST(3)  
>  ST(4)     ST(5)  c000
>  ST(6)  c000   ST(7) e000 e000
>  mxcsr: 1f80
>  XMM0:  25252525 XMM1:  
> 25252525
>  XMM2:  25252525 XMM3:  
> 25252525
>  XMM4:  25252525 XMM5:  
> 25252525
>  XMM6:  25252525 XMM7:  
> 25252525
>  XMM8:  25252525 XMM9:  
> 25252525
>  XMM10: 25252525 XMM11: 
> 25252525
>  XMM12: 25252525 XMM13: 
> 25252525
>  XMM14: 25252525 XMM15: 
> 25252525Backtrace:
> /usr/local/lib/libapache-geode.so(_ZN6apache5geode6client10MapSegment6removeERKSt10shared_ptrINS1_12CacheableKeyEERS3_INS1_12SerializableEERS3_INS1_12MapEntryImplEEiS3_INS1_10VersionTagEEbRb+0x287)[0x7f578159ac47]
> /usr/local/lib/libapache-geode.so(_ZN6apache5geode6client20ConcurrentEntriesMap6removeERKSt10shared_ptrINS1_12CacheableKeyEERS3_INS1_12SerializableEERS3_INS1_12MapEntryImplEEiS3_INS1_10VersionTagEEb+0xa0)[0x7f57814e1782]
> /usr/local/lib/libapache-geode.so(+0x77173d)[0x7f578157673d]
> /usr/local/lib/libapache-geode.so(_ZN6apache5geode6client11LocalRegion13updateNoThrowINS1_14DestroyActionsEEE9GfErrTypeRKSt10shared_ptrINS1_12CacheableKeyEERKS6_INS1_12SerializableEESE_RSC_iNS1_15CacheEventFlagsES6_INS1_10VersionTagEEPNS1_9DataInputES6_INS1_7EventIdEE+0x515)[0x7f578157af2b]
> /usr/local/lib/libapache-geode.so(_ZN6apache5geode6client11LocalRegion14destroyNoThrowERKSt10shared_ptrINS1_12CacheableKeyEERKS3_INS1_12SerializableEEiNS1_15CacheEventFlagsES3_INS1_10Versio

[jira] [Commented] (GEODE-8566) Redis native tests should not also stand up a Geode server

2020-10-05 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208079#comment-17208079
 ] 

ASF GitHub Bot commented on GEODE-8566:
---

sabbey37 commented on a change in pull request #5584:
URL: https://github.com/apache/geode/pull/5584#discussion_r499597781



##
File path: 
geode-redis/src/acceptanceTest/java/org/apache/geode/redis/internal/executor/key/RenameNativeRedisAcceptanceTest.java
##
@@ -14,30 +14,25 @@
  */
 package org.apache.geode.redis.internal.executor.key;
 
-import java.util.Random;
-
-import org.junit.BeforeClass;
 import org.junit.ClassRule;
 import org.junit.Ignore;
 import org.junit.Test;
-import redis.clients.jedis.Jedis;
 
 import org.apache.geode.NativeRedisTestRule;
 
-public class RenameNativeRedisAcceptanceTest extends RenameIntegrationTest {
+public class RenameNativeRedisAcceptanceTest extends 
AbstractRenameIntegrationTest {
+
   @ClassRule
   public static NativeRedisTestRule redis = new NativeRedisTestRule();
 
-  @BeforeClass
-  public static void setUp() {
-rand = new Random();
-jedis = new Jedis("localhost", redis.getPort(), 1000);
-jedis2 = new Jedis("localhost", redis.getPort(), 1000);
-jedis3 = new Jedis("localhost", redis.getPort(), 1000);
+  @Override
+  public int getPort() {
+return redis.getPort();
   }
 
   @Override
   @Test
   @Ignore("native redis does implement renamenx")
   public void renamenxIsUnimplemented() {}
+

Review comment:
   sounds good!





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Redis native tests should not also stand up a Geode server
> --
>
> Key: GEODE-8566
> URL: https://issues.apache.org/jira/browse/GEODE-8566
> Project: Geode
>  Issue Type: Test
>  Components: redis
>Reporter: Jens Deppe
>Priority: Major
>  Labels: pull-request-available
>
> Our native acceptance tests currently extend from the integration tests and 
> both classes have a {{@ClassRule}} that results in both a native (container) 
> instance and a Geode instance starting up. Mostly not a problem except for 
> {{PubSubNativeAcceptanceTest}} which was not testing against native redis.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8553) Reduce ThinClientLocatorHelper lock time

2020-10-05 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208153#comment-17208153
 ] 

ASF GitHub Bot commented on GEODE-8553:
---

pdxcodemonkey commented on pull request #660:
URL: https://github.com/apache/geode-native/pull/660#issuecomment-703724456


   Windows build still hitting an issue:
   ```
   C:\nativeclient\cppcache\src\ThinClientPoolDM.cpp(572): error C2220: warning 
treated as error - no 'object' file generated 
[C:\build\cppcache\static\apache-geode-static.vcxproj]
   C:\nativeclient\cppcache\src\ThinClientPoolDM.cpp(572): warning C4267: 
'argument': conversion from 'size_t' to 'int32_t', possible loss of data 
[C:\build\cppcache\static\apache-geode-static.vcxproj]
   ```  



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Reduce ThinClientLocatorHelper lock time
> 
>
> Key: GEODE-8553
> URL: https://issues.apache.org/jira/browse/GEODE-8553
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Affects Versions: 1.12.0, 1.13.0
>Reporter: Mario Salazar de Torres
>Assignee: Mario Salazar de Torres
>Priority: Major
>  Labels: pull-request-available
>
> During my troublshootings, I've seen that locking m_locatorLock for the whole 
> scope of the class function members might cause some inter-locks.
> Problem here and in many other places of the NC is that networking operations 
> are performed while a mutex is locked. Therefore if *thread A* takes longer 
> than expected in performing its network operation, it might block another one 
> which does not requires any resource of the first *thread A*. Hence, the 
> inter-lock.
> This improvement is the first one of a series regarding to lock scope 
> reduction when it comes with code regarding networking in NC.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8419) SSL/TLS protocol and cipher suite configuration is ignored

2020-10-05 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208182#comment-17208182
 ] 

ASF GitHub Bot commented on GEODE-8419:
---

Bill commented on pull request #5587:
URL: https://github.com/apache/geode/pull/5587#issuecomment-703755073


   The only failure in CI was RedisTestOpenJDK11. That test runs in CI but the 
test isn't present on `support/1.12` so it's not a showstopper.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> SSL/TLS protocol and cipher suite configuration is ignored
> --
>
> Key: GEODE-8419
> URL: https://issues.apache.org/jira/browse/GEODE-8419
> Project: Geode
>  Issue Type: Bug
>  Components: client/server, membership, security
>Affects Versions: 1.10.0, 1.11.0, 1.12.0, 1.13.0, 1.14.0
>Reporter: Jacob Barrett
>Assignee: Bruce J Schuchardt
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> Configuring {{ssl-protocols}} or {{ssl-ciphers}} properties, or per-component 
> ssl properties, have no effect. Configuring {{ssl-protocols}} may effect the 
> {{SSLContext}} selected and limit some of the protocols allowed but does not 
> restrict to just the set specified in the property. The {{ssl-ciphers}} 
> property does not limit cipher selection at all.
> The result is that all ciphers allowed under the match {{SSLContext}} are 
> allowed and negotiated. This can result in an unintended cipher being used in 
> SSL/TLS communication. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (GEODE-8573) SerialGatewaySenderOperationsDistributedTest.testRestartSerialGatewaySendersWhilePutting

2020-10-05 Thread Mark Hanson (Jira)
Mark Hanson created GEODE-8573:
--

 Summary: 
SerialGatewaySenderOperationsDistributedTest.testRestartSerialGatewaySendersWhilePutting
 Key: GEODE-8573
 URL: https://issues.apache.org/jira/browse/GEODE-8573
 Project: Geode
  Issue Type: Bug
  Components: wan
Affects Versions: 1.14.0
Reporter: Mark Hanson


{noformat}
org.apache.geode.internal.cache.wan.serial.SerialGatewaySenderOperationsDistributedTest
 > testRestartSerialGatewaySendersWhilePutting[1: numDispatchers=3] FAILED
org.apache.geode.test.dunit.RMIException: While invoking 
org.apache.geode.internal.cache.wan.serial.SerialGatewaySenderOperationsDistributedTest$$Lambda$356/426344166.run
 in VM 5 running on Host 538fd3213f62 with 8 VMs
at org.apache.geode.test.dunit.VM.executeMethodOnObject(VM.java:620)
at org.apache.geode.test.dunit.VM.invoke(VM.java:447)
at 
org.apache.geode.internal.cache.wan.serial.SerialGatewaySenderOperationsDistributedTest.testRestartSerialGatewaySendersWhilePutting(SerialGatewaySenderOperationsDistributedTest.java:407)
Caused by:
org.awaitility.core.ConditionTimeoutException: Assertion condition 
defined as a lambda expression in 
org.apache.geode.internal.cache.wan.serial.SerialGatewaySenderOperationsDistributedTest
 that uses org.apache.geode.internal.cache.wan.InternalGatewaySender, 
org.apache.geode.internal.cache.wan.InternalGatewaySenderint [Sender statistics 
unprocessed event map size] expected:<[0]> but was:<[3]> within 5 minutes.
at 
org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:165)
at 
org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
at 
org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
at 
org.awaitility.core.ConditionFactory.until(ConditionFactory.java:895)
at 
org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:679)
at 
org.apache.geode.internal.cache.wan.serial.SerialGatewaySenderOperationsDistributedTest.validateSecondaryQueueSizeStat(SerialGatewaySenderOperationsDistributedTest.java:1216)
at 
org.apache.geode.internal.cache.wan.serial.SerialGatewaySenderOperationsDistributedTest.lambda$testRestartSerialGatewaySendersWhilePutting$bb17a952$23(SerialGatewaySenderOperationsDistributedTest.java:407)
Caused by:
org.junit.ComparisonFailure: [Sender statistics unprocessed event 
map size] expected:<[0]> but was:<[3]>
at 
sun.reflect.GeneratedConstructorAccessor81.newInstance(Unknown Source)
at 
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at 
org.apache.geode.internal.cache.wan.serial.SerialGatewaySenderOperationsDistributedTest.lambda$validateSecondaryQueueSizeStat$8(SerialGatewaySenderOperationsDistributedTest.java:1219)
 {noformat}
 

=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
[http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0389/test-results/distributedTest/1601774166/]
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

Test report artifacts from this job are available at:

[http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0389/test-artifacts/1601774166/distributedtestfiles-OpenJDK8-1.14.0-build.0389.tgz]

 

 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (GEODE-8573) SerialGatewaySenderOperationsDistributedTest.testRestartSerialGatewaySendersWhilePutting

2020-10-05 Thread Mark Hanson (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-8573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Hanson reassigned GEODE-8573:
--

Assignee: Mark Hanson

> SerialGatewaySenderOperationsDistributedTest.testRestartSerialGatewaySendersWhilePutting
> 
>
> Key: GEODE-8573
> URL: https://issues.apache.org/jira/browse/GEODE-8573
> Project: Geode
>  Issue Type: Bug
>  Components: wan
>Affects Versions: 1.14.0
>Reporter: Mark Hanson
>Assignee: Mark Hanson
>Priority: Major
>
> {noformat}
> org.apache.geode.internal.cache.wan.serial.SerialGatewaySenderOperationsDistributedTest
>  > testRestartSerialGatewaySendersWhilePutting[1: numDispatchers=3] FAILED
> org.apache.geode.test.dunit.RMIException: While invoking 
> org.apache.geode.internal.cache.wan.serial.SerialGatewaySenderOperationsDistributedTest$$Lambda$356/426344166.run
>  in VM 5 running on Host 538fd3213f62 with 8 VMs
> at org.apache.geode.test.dunit.VM.executeMethodOnObject(VM.java:620)
> at org.apache.geode.test.dunit.VM.invoke(VM.java:447)
> at 
> org.apache.geode.internal.cache.wan.serial.SerialGatewaySenderOperationsDistributedTest.testRestartSerialGatewaySendersWhilePutting(SerialGatewaySenderOperationsDistributedTest.java:407)
> Caused by:
> org.awaitility.core.ConditionTimeoutException: Assertion condition 
> defined as a lambda expression in 
> org.apache.geode.internal.cache.wan.serial.SerialGatewaySenderOperationsDistributedTest
>  that uses org.apache.geode.internal.cache.wan.InternalGatewaySender, 
> org.apache.geode.internal.cache.wan.InternalGatewaySenderint [Sender 
> statistics unprocessed event map size] expected:<[0]> but was:<[3]> within 5 
> minutes.
> at 
> org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:165)
> at 
> org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
> at 
> org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
> at 
> org.awaitility.core.ConditionFactory.until(ConditionFactory.java:895)
> at 
> org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:679)
> at 
> org.apache.geode.internal.cache.wan.serial.SerialGatewaySenderOperationsDistributedTest.validateSecondaryQueueSizeStat(SerialGatewaySenderOperationsDistributedTest.java:1216)
> at 
> org.apache.geode.internal.cache.wan.serial.SerialGatewaySenderOperationsDistributedTest.lambda$testRestartSerialGatewaySendersWhilePutting$bb17a952$23(SerialGatewaySenderOperationsDistributedTest.java:407)
> Caused by:
> org.junit.ComparisonFailure: [Sender statistics unprocessed event 
> map size] expected:<[0]> but was:<[3]>
> at 
> sun.reflect.GeneratedConstructorAccessor81.newInstance(Unknown Source)
> at 
> sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
> at 
> org.apache.geode.internal.cache.wan.serial.SerialGatewaySenderOperationsDistributedTest.lambda$validateSecondaryQueueSizeStat$8(SerialGatewaySenderOperationsDistributedTest.java:1219)
>  {noformat}
>  
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI 
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> [http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0389/test-results/distributedTest/1601774166/]
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> Test report artifacts from this job are available at:
> [http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0389/test-artifacts/1601774166/distributedtestfiles-OpenJDK8-1.14.0-build.0389.tgz]
>  
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (GEODE-8573) SerialGatewaySenderOperationsDistributedTest.testRestartSerialGatewaySendersWhilePutting

2020-10-05 Thread Mark Hanson (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-8573?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Hanson updated GEODE-8573:
---
Description: 
[https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/DistributedTestOpenJDK8/builds/521]

 
{noformat}
org.apache.geode.internal.cache.wan.serial.SerialGatewaySenderOperationsDistributedTest
 > testRestartSerialGatewaySendersWhilePutting[1: numDispatchers=3] FAILED
org.apache.geode.test.dunit.RMIException: While invoking 
org.apache.geode.internal.cache.wan.serial.SerialGatewaySenderOperationsDistributedTest$$Lambda$356/426344166.run
 in VM 5 running on Host 538fd3213f62 with 8 VMs
at org.apache.geode.test.dunit.VM.executeMethodOnObject(VM.java:620)
at org.apache.geode.test.dunit.VM.invoke(VM.java:447)
at 
org.apache.geode.internal.cache.wan.serial.SerialGatewaySenderOperationsDistributedTest.testRestartSerialGatewaySendersWhilePutting(SerialGatewaySenderOperationsDistributedTest.java:407)
Caused by:
org.awaitility.core.ConditionTimeoutException: Assertion condition 
defined as a lambda expression in 
org.apache.geode.internal.cache.wan.serial.SerialGatewaySenderOperationsDistributedTest
 that uses org.apache.geode.internal.cache.wan.InternalGatewaySender, 
org.apache.geode.internal.cache.wan.InternalGatewaySenderint [Sender statistics 
unprocessed event map size] expected:<[0]> but was:<[3]> within 5 minutes.
at 
org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:165)
at 
org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
at 
org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
at 
org.awaitility.core.ConditionFactory.until(ConditionFactory.java:895)
at 
org.awaitility.core.ConditionFactory.untilAsserted(ConditionFactory.java:679)
at 
org.apache.geode.internal.cache.wan.serial.SerialGatewaySenderOperationsDistributedTest.validateSecondaryQueueSizeStat(SerialGatewaySenderOperationsDistributedTest.java:1216)
at 
org.apache.geode.internal.cache.wan.serial.SerialGatewaySenderOperationsDistributedTest.lambda$testRestartSerialGatewaySendersWhilePutting$bb17a952$23(SerialGatewaySenderOperationsDistributedTest.java:407)
Caused by:
org.junit.ComparisonFailure: [Sender statistics unprocessed event 
map size] expected:<[0]> but was:<[3]>
at 
sun.reflect.GeneratedConstructorAccessor81.newInstance(Unknown Source)
at 
sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
at 
org.apache.geode.internal.cache.wan.serial.SerialGatewaySenderOperationsDistributedTest.lambda$validateSecondaryQueueSizeStat$8(SerialGatewaySenderOperationsDistributedTest.java:1219)
 {noformat}
 

=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
 
[http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0389/test-results/distributedTest/1601774166/]
 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

Test report artifacts from this job are available at:

[http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0389/test-artifacts/1601774166/distributedtestfiles-OpenJDK8-1.14.0-build.0389.tgz]

 

 

  was:
{noformat}
org.apache.geode.internal.cache.wan.serial.SerialGatewaySenderOperationsDistributedTest
 > testRestartSerialGatewaySendersWhilePutting[1: numDispatchers=3] FAILED
org.apache.geode.test.dunit.RMIException: While invoking 
org.apache.geode.internal.cache.wan.serial.SerialGatewaySenderOperationsDistributedTest$$Lambda$356/426344166.run
 in VM 5 running on Host 538fd3213f62 with 8 VMs
at org.apache.geode.test.dunit.VM.executeMethodOnObject(VM.java:620)
at org.apache.geode.test.dunit.VM.invoke(VM.java:447)
at 
org.apache.geode.internal.cache.wan.serial.SerialGatewaySenderOperationsDistributedTest.testRestartSerialGatewaySendersWhilePutting(SerialGatewaySenderOperationsDistributedTest.java:407)
Caused by:
org.awaitility.core.ConditionTimeoutException: Assertion condition 
defined as a lambda expression in 
org.apache.geode.internal.cache.wan.serial.SerialGatewaySenderOperationsDistributedTest
 that uses org.apache.geode.internal.cache.wan.InternalGatewaySender, 
org.apache.geode.internal.cache.wan.InternalGatewaySenderint [Sender statistics 
unprocessed event map size] expected:<[0]> but was:<[3]> within 5 minutes.
at 
org.awaitility.core.ConditionAwaiter.await(ConditionAwaiter.java:165)
at 
org.awaitility.core.AssertionCondition.await(AssertionCondition.java:119)
at 
org.awaitility.core.AssertionCondition.await(AssertionCondition.java:31)
at 
org.awaitility.core.ConditionFactory.until(ConditionFactory.java:895)
   

[jira] [Commented] (GEODE-8566) Redis native tests should not also stand up a Geode server

2020-10-05 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208186#comment-17208186
 ] 

ASF GitHub Bot commented on GEODE-8566:
---

jdeppe-pivotal merged pull request #5584:
URL: https://github.com/apache/geode/pull/5584


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Redis native tests should not also stand up a Geode server
> --
>
> Key: GEODE-8566
> URL: https://issues.apache.org/jira/browse/GEODE-8566
> Project: Geode
>  Issue Type: Test
>  Components: redis
>Reporter: Jens Deppe
>Priority: Major
>  Labels: pull-request-available
>
> Our native acceptance tests currently extend from the integration tests and 
> both classes have a {{@ClassRule}} that results in both a native (container) 
> instance and a Geode instance starting up. Mostly not a problem except for 
> {{PubSubNativeAcceptanceTest}} which was not testing against native redis.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8566) Redis native tests should not also stand up a Geode server

2020-10-05 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208188#comment-17208188
 ] 

ASF subversion and git services commented on GEODE-8566:


Commit fb3bcac1a5b34e3f082a63ac1d5042b7bf7e9f7e in geode's branch 
refs/heads/develop from Jens Deppe
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=fb3bcac ]

GEODE-8566: Redis native tests should not also stand up a Geode server (#5584)



> Redis native tests should not also stand up a Geode server
> --
>
> Key: GEODE-8566
> URL: https://issues.apache.org/jira/browse/GEODE-8566
> Project: Geode
>  Issue Type: Test
>  Components: redis
>Reporter: Jens Deppe
>Priority: Major
>  Labels: pull-request-available
>
> Our native acceptance tests currently extend from the integration tests and 
> both classes have a {{@ClassRule}} that results in both a native (container) 
> instance and a Geode instance starting up. Mostly not a problem except for 
> {{PubSubNativeAcceptanceTest}} which was not testing against native redis.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8566) Redis native tests should not also stand up a Geode server

2020-10-05 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8566?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208190#comment-17208190
 ] 

ASF subversion and git services commented on GEODE-8566:


Commit fb3bcac1a5b34e3f082a63ac1d5042b7bf7e9f7e in geode's branch 
refs/heads/develop from Jens Deppe
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=fb3bcac ]

GEODE-8566: Redis native tests should not also stand up a Geode server (#5584)



> Redis native tests should not also stand up a Geode server
> --
>
> Key: GEODE-8566
> URL: https://issues.apache.org/jira/browse/GEODE-8566
> Project: Geode
>  Issue Type: Test
>  Components: redis
>Reporter: Jens Deppe
>Priority: Major
>  Labels: pull-request-available
>
> Our native acceptance tests currently extend from the integration tests and 
> both classes have a {{@ClassRule}} that results in both a native (container) 
> instance and a Geode instance starting up. Mostly not a problem except for 
> {{PubSubNativeAcceptanceTest}} which was not testing against native redis.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-7845) Rollingupgrade should not conflict with the new ClearPRMessage

2020-10-05 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-7845?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208191#comment-17208191
 ] 

ASF GitHub Bot commented on GEODE-7845:
---

jinmeiliao commented on pull request #5577:
URL: https://github.com/apache/geode/pull/5577#issuecomment-703762447


   Is this PR really changing 69 files? 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Rollingupgrade should not conflict with the new ClearPRMessage 
> ---
>
> Key: GEODE-7845
> URL: https://issues.apache.org/jira/browse/GEODE-7845
> Project: Geode
>  Issue Type: Improvement
>  Components: core
>Reporter: Xiaojian Zhou
>Assignee: Mark Hanson
>Priority: Major
>  Labels: GeodeCommons, pull-request-available
>
> PartitionedRegion clear introduced a new ClearPRMessage. In case of doing 
> rolling upgrade, the user called PR.clear. The new ClearPRMessage should not 
> fail. It should not be sent to the old members. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8565) c++ client tries to connect to down server until IO error is thrown

2020-10-05 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8565?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208200#comment-17208200
 ] 

ASF GitHub Bot commented on GEODE-8565:
---

alb3rtobr commented on pull request #662:
URL: https://github.com/apache/geode-native/pull/662#issuecomment-703769126


   I have added extra logic in the test cases added in GEODE-8231 to verify 
that the client metadata was verified at the first error that appeared:
   In case there was a timeout received by the client, the log has to contain a 
message saying the `bucketServerLocation` was removed due to a timeout.
   And if there was an IO error, the log has to contain a message saying the 
`bucketServerLocation` was removed due to an IO error.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> c++ client tries to connect to down server until IO error is thrown
> ---
>
> Key: GEODE-8565
> URL: https://issues.apache.org/jira/browse/GEODE-8565
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Alberto Bustamante Reyes
>Assignee: Alberto Bustamante Reyes
>Priority: Major
>  Labels: pull-request-available
>
> This ticket is an improvement over GEODE-8231:
> {quote}If a C++ client connected to a cluster is sending operations to a 
> partitioned region and one of the server goes down, the client keeps trying 
> to send operations to the down server. This can be observed in the logs by a 
> continuous flow of lines containing: "IO error in handshake with endpoint..."
> {quote}
> After that improvement, the c++ client removes the metadata info of the 
> failing server once the "IO error in handshake" is received.
> But it has been observed that before that error is received, "timeout error" 
> can be returned. So the client will try to reconnect until the "IO error in 
> handshake" is received.
> This ticket aims to extend the GEODE-8231 solution so the client removes the 
> server metadata information when a timeout is received.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8348) CI does not build benchmarks image

2020-10-05 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208206#comment-17208206
 ] 

ASF subversion and git services commented on GEODE-8348:


Commit 9819b5f39c3f7dbbd25e467a9af9f60db368d949 in geode-benchmarks's branch 
refs/heads/feature/GEODE-7665 from Sean Goller
[ https://gitbox.apache.org/repos/asf?p=geode-benchmarks.git;h=9819b5f ]

GEODE-8348: Add support for customizable purpose tag. (#131)

* GEODE-8348: Add support for customizable purpose tag.

* GEODE-8348: purpose value fixes.

> CI does not build benchmarks image
> --
>
> Key: GEODE-8348
> URL: https://issues.apache.org/jira/browse/GEODE-8348
> Project: Geode
>  Issue Type: Bug
>  Components: ci
>Reporter: Sean Goller
>Assignee: Sean Goller
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> The CI infrastructure relies on the existence of a google compute image in 
> order to function. Currently that image is not build anywhere in CI. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8348) CI does not build benchmarks image

2020-10-05 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208205#comment-17208205
 ] 

ASF subversion and git services commented on GEODE-8348:


Commit 9819b5f39c3f7dbbd25e467a9af9f60db368d949 in geode-benchmarks's branch 
refs/heads/feature/GEODE-7665 from Sean Goller
[ https://gitbox.apache.org/repos/asf?p=geode-benchmarks.git;h=9819b5f ]

GEODE-8348: Add support for customizable purpose tag. (#131)

* GEODE-8348: Add support for customizable purpose tag.

* GEODE-8348: purpose value fixes.

> CI does not build benchmarks image
> --
>
> Key: GEODE-8348
> URL: https://issues.apache.org/jira/browse/GEODE-8348
> Project: Geode
>  Issue Type: Bug
>  Components: ci
>Reporter: Sean Goller
>Assignee: Sean Goller
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> The CI infrastructure relies on the existence of a google compute image in 
> order to function. Currently that image is not build anywhere in CI. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8348) CI does not build benchmarks image

2020-10-05 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208204#comment-17208204
 ] 

ASF subversion and git services commented on GEODE-8348:


Commit 9819b5f39c3f7dbbd25e467a9af9f60db368d949 in geode-benchmarks's branch 
refs/heads/feature/GEODE-7665 from Sean Goller
[ https://gitbox.apache.org/repos/asf?p=geode-benchmarks.git;h=9819b5f ]

GEODE-8348: Add support for customizable purpose tag. (#131)

* GEODE-8348: Add support for customizable purpose tag.

* GEODE-8348: purpose value fixes.

> CI does not build benchmarks image
> --
>
> Key: GEODE-8348
> URL: https://issues.apache.org/jira/browse/GEODE-8348
> Project: Geode
>  Issue Type: Bug
>  Components: ci
>Reporter: Sean Goller
>Assignee: Sean Goller
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> The CI infrastructure relies on the existence of a google compute image in 
> order to function. Currently that image is not build anywhere in CI. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Resolved] (GEODE-8566) Redis native tests should not also stand up a Geode server

2020-10-05 Thread Jens Deppe (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-8566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jens Deppe resolved GEODE-8566.
---
Fix Version/s: 1.14.0
   Resolution: Fixed

> Redis native tests should not also stand up a Geode server
> --
>
> Key: GEODE-8566
> URL: https://issues.apache.org/jira/browse/GEODE-8566
> Project: Geode
>  Issue Type: Test
>  Components: redis
>Reporter: Jens Deppe
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> Our native acceptance tests currently extend from the integration tests and 
> both classes have a {{@ClassRule}} that results in both a native (container) 
> instance and a Geode instance starting up. Mostly not a problem except for 
> {{PubSubNativeAcceptanceTest}} which was not testing against native redis.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8553) Reduce ThinClientLocatorHelper lock time

2020-10-05 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208234#comment-17208234
 ] 

ASF GitHub Bot commented on GEODE-8553:
---

gaussianrecurrence commented on pull request #660:
URL: https://github.com/apache/geode-native/pull/660#issuecomment-703800820


   So sorry @pdxcodemonkey,
   Will fix the issue and compile/run tests in all platforms, just to be sure. 
It might take a while.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Reduce ThinClientLocatorHelper lock time
> 
>
> Key: GEODE-8553
> URL: https://issues.apache.org/jira/browse/GEODE-8553
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Affects Versions: 1.12.0, 1.13.0
>Reporter: Mario Salazar de Torres
>Assignee: Mario Salazar de Torres
>Priority: Major
>  Labels: pull-request-available
>
> During my troublshootings, I've seen that locking m_locatorLock for the whole 
> scope of the class function members might cause some inter-locks.
> Problem here and in many other places of the NC is that networking operations 
> are performed while a mutex is locked. Therefore if *thread A* takes longer 
> than expected in performing its network operation, it might block another one 
> which does not requires any resource of the first *thread A*. Hence, the 
> inter-lock.
> This improvement is the first one of a series regarding to lock scope 
> reduction when it comes with code regarding networking in NC.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8525) PubSubNativeRedisAcceptanceTest.concurrentSubscribers_andPublishers_doesNotHang CI failure

2020-10-05 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208243#comment-17208243
 ] 

ASF GitHub Bot commented on GEODE-8525:
---

jdeppe-pivotal opened a new pull request #5591:
URL: https://github.com/apache/geode/pull/5591


   
   Co-Authored-by: Jens Deppe 
   Co-Authored-by: Sarah Abbey 
   
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, check Concourse for build 
issues and
   submit an update to your PR as soon as possible. If you need help, please 
send an
   email to d...@geode.apache.org.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> PubSubNativeRedisAcceptanceTest.concurrentSubscribers_andPublishers_doesNotHang
>  CI failure
> --
>
> Key: GEODE-8525
> URL: https://issues.apache.org/jira/browse/GEODE-8525
> Project: Geode
>  Issue Type: Bug
>  Components: redis
>Reporter: Sarah Abbey
>Assignee: Sarah Abbey
>Priority: Minor
>
> {code:java}
> org.apache.geode.redis.internal.executor.pubsub.PubSubNativeRedisAcceptanceTest
>  > concurrentSubscribers_andPublishers_doesNotHang FAILED
> java.util.concurrent.ExecutionException: 
> java.util.concurrent.ExecutionException: java.lang.RuntimeException: 
> java.util.concurrent.ExecutionException: java.lang.RuntimeException: 
> inner.get() errored after unsubscribe: null
> Caused by:
> java.util.concurrent.ExecutionException: java.lang.RuntimeException: 
> java.util.concurrent.ExecutionException: java.lang.RuntimeException: 
> inner.get() errored after unsubscribe: null
> Caused by:
> java.lang.RuntimeException: 
> java.util.concurrent.ExecutionException: java.lang.RuntimeException: 
> inner.get() errored after unsubscribe: null
> Caused by:
> java.util.concurrent.ExecutionException: 
> java.lang.RuntimeException: inner.get() errored after unsubscribe: null
> Caused by:
> java.lang.RuntimeException: inner.get() errored after 
> unsubscribe: null
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (GEODE-8525) PubSubNativeRedisAcceptanceTest.concurrentSubscribers_andPublishers_doesNotHang CI failure

2020-10-05 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-8525?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated GEODE-8525:
--
Labels: pull-request-available  (was: )

> PubSubNativeRedisAcceptanceTest.concurrentSubscribers_andPublishers_doesNotHang
>  CI failure
> --
>
> Key: GEODE-8525
> URL: https://issues.apache.org/jira/browse/GEODE-8525
> Project: Geode
>  Issue Type: Bug
>  Components: redis
>Reporter: Sarah Abbey
>Assignee: Sarah Abbey
>Priority: Minor
>  Labels: pull-request-available
>
> {code:java}
> org.apache.geode.redis.internal.executor.pubsub.PubSubNativeRedisAcceptanceTest
>  > concurrentSubscribers_andPublishers_doesNotHang FAILED
> java.util.concurrent.ExecutionException: 
> java.util.concurrent.ExecutionException: java.lang.RuntimeException: 
> java.util.concurrent.ExecutionException: java.lang.RuntimeException: 
> inner.get() errored after unsubscribe: null
> Caused by:
> java.util.concurrent.ExecutionException: java.lang.RuntimeException: 
> java.util.concurrent.ExecutionException: java.lang.RuntimeException: 
> inner.get() errored after unsubscribe: null
> Caused by:
> java.lang.RuntimeException: 
> java.util.concurrent.ExecutionException: java.lang.RuntimeException: 
> inner.get() errored after unsubscribe: null
> Caused by:
> java.util.concurrent.ExecutionException: 
> java.lang.RuntimeException: inner.get() errored after unsubscribe: null
> Caused by:
> java.lang.RuntimeException: inner.get() errored after 
> unsubscribe: null
> {code}



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (GEODE-8574) ClassCastException when hitting members REST endpoint

2020-10-05 Thread Jason Huynh (Jira)
Jason Huynh created GEODE-8574:
--

 Summary: ClassCastException when hitting members REST endpoint
 Key: GEODE-8574
 URL: https://issues.apache.org/jira/browse/GEODE-8574
 Project: Geode
  Issue Type: Improvement
  Components: rest (admin)
Affects Versions: 1.13.0
Reporter: Jason Huynh


This might be similar to https://issues.apache.org/jira/browse/GEODE-8078

We see a FunctionInvocationTargetException when trying to use the rest endpoint 
while servers are restarting/recovering

[error 2020/10/01 21:49:57.381 GMT  tid=0x46] class 
org.apache.geode.cache.execute.FunctionInvocationTargetException cannot be cast 
to class org.apache.geode.management.runtime.RuntimeInfo 
(org.apache.geode.cache.execute.FunctionInvocationTargetException and 
org.apache.geode.management.runtime.RuntimeInfo are in unnamed module of loader 
'app')
java.lang.ClassCastException: class 
org.apache.geode.cache.execute.FunctionInvocationTargetException cannot be cast 
to class org.apache.geode.management.runtime.RuntimeInfo 
(org.apache.geode.cache.execute.FunctionInvocationTargetException and 
org.apache.geode.management.runtime.RuntimeInfo are in unnamed module of loader 
'app')
at 
org.apache.geode.management.internal.api.LocatorClusterManagementService.list(LocatorClusterManagementService.java:459)
at 
org.apache.geode.management.internal.api.LocatorClusterManagementService.get(LocatorClusterManagementService.java:476)
at 
org.apache.geode.management.internal.rest.controllers.MemberManagementController.getMember(MemberManagementController.java:50)
at 
org.apache.geode.management.internal.rest.controllers.MemberManagementController$$FastClassBySpringCGLIB$$3634e452.invoke()
at org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:218)
at 
org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.invokeJoinpoint(CglibAopProxy.java:771)
at 
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163)
at 
org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:749)
at 
org.springframework.security.access.intercept.aopalliance.MethodSecurityInterceptor.invoke(MethodSecurityInterceptor.java:61)
at 
org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186)
at 
org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:749)
at 
org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:691)
at 
org.apache.geode.management.internal.rest.controllers.MemberManagementController$$EnhancerBySpringCGLIB$$ef2756b6.getMember()
at jdk.internal.reflect.GeneratedMethodAccessor237.invoke(Unknown Source)
at 
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:566)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (GEODE-8574) ClassCastException when hitting members REST endpoint

2020-10-05 Thread Anilkumar Gingade (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-8574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Anilkumar Gingade updated GEODE-8574:
-
Labels: GeodeOperationAPI  (was: )

> ClassCastException when hitting members REST endpoint
> -
>
> Key: GEODE-8574
> URL: https://issues.apache.org/jira/browse/GEODE-8574
> Project: Geode
>  Issue Type: Improvement
>  Components: rest (admin)
>Affects Versions: 1.13.0
>Reporter: Jason Huynh
>Priority: Major
>  Labels: GeodeOperationAPI
>
> This might be similar to https://issues.apache.org/jira/browse/GEODE-8078
> We see a FunctionInvocationTargetException when trying to use the rest 
> endpoint while servers are restarting/recovering
> [error 2020/10/01 21:49:57.381 GMT  tid=0x46] class 
> org.apache.geode.cache.execute.FunctionInvocationTargetException cannot be 
> cast to class org.apache.geode.management.runtime.RuntimeInfo 
> (org.apache.geode.cache.execute.FunctionInvocationTargetException and 
> org.apache.geode.management.runtime.RuntimeInfo are in unnamed module of 
> loader 'app')
> java.lang.ClassCastException: class 
> org.apache.geode.cache.execute.FunctionInvocationTargetException cannot be 
> cast to class org.apache.geode.management.runtime.RuntimeInfo 
> (org.apache.geode.cache.execute.FunctionInvocationTargetException and 
> org.apache.geode.management.runtime.RuntimeInfo are in unnamed module of 
> loader 'app')
> at 
> org.apache.geode.management.internal.api.LocatorClusterManagementService.list(LocatorClusterManagementService.java:459)
> at 
> org.apache.geode.management.internal.api.LocatorClusterManagementService.get(LocatorClusterManagementService.java:476)
> at 
> org.apache.geode.management.internal.rest.controllers.MemberManagementController.getMember(MemberManagementController.java:50)
> at 
> org.apache.geode.management.internal.rest.controllers.MemberManagementController$$FastClassBySpringCGLIB$$3634e452.invoke()
> at org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:218)
> at 
> org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.invokeJoinpoint(CglibAopProxy.java:771)
> at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163)
> at 
> org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:749)
> at 
> org.springframework.security.access.intercept.aopalliance.MethodSecurityInterceptor.invoke(MethodSecurityInterceptor.java:61)
> at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186)
> at 
> org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:749)
> at 
> org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:691)
> at 
> org.apache.geode.management.internal.rest.controllers.MemberManagementController$$EnhancerBySpringCGLIB$$ef2756b6.getMember()
> at jdk.internal.reflect.GeneratedMethodAccessor237.invoke(Unknown Source)
> at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:566)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (GEODE-8575) IntegrationTest failure IndexRepositoryFactoryIntegrationTest.shouldThrowInternalGemfireErrorWhenIOExceptionEncounteredConsistentlyDuringComputingRepository FAILED

2020-10-05 Thread Mark Hanson (Jira)
Mark Hanson created GEODE-8575:
--

 Summary: IntegrationTest failure 
IndexRepositoryFactoryIntegrationTest.shouldThrowInternalGemfireErrorWhenIOExceptionEncounteredConsistentlyDuringComputingRepository
 FAILED
 Key: GEODE-8575
 URL: https://issues.apache.org/jira/browse/GEODE-8575
 Project: Geode
  Issue Type: Bug
  Components: lucene
Affects Versions: 1.14.0
Reporter: Mark Hanson


[https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/IntegrationTestOpenJDK11/builds/478]

 
{noformat}
org.apache.geode.cache.lucene.internal.IndexRepositoryFactoryIntegrationTest > 
shouldThrowInternalGemfireErrorWhenIOExceptionEncounteredConsistentlyDuringComputingRepository
 FAILED
org.mockito.exceptions.misusing.UnfinishedStubbingException: 
Unfinished stubbing detected here:
-> at 
org.apache.geode.cache.lucene.internal.IndexRepositoryFactoryIntegrationTest.shouldThrowInternalGemfireErrorWhenIOExceptionEncounteredConsistentlyDuringComputingRepository(IndexRepositoryFactoryIntegrationTest.java:102)
E.g. thenReturn() may be missing.
Examples of correct stubbing:
when(mock.isOk()).thenReturn(true);
when(mock.isOk()).thenThrow(exception);
doThrow(exception).when(mock).someVoidMethod();
Hints:
 1. missing thenReturn()
 2. you are trying to stub a final method, which is not supported
 3. you are stubbing the behaviour of another mock inside before 
'thenReturn' instruction is completed
at 
org.apache.geode.cache.lucene.internal.IndexRepositoryFactoryIntegrationTest.shouldThrowInternalGemfireErrorWhenIOExceptionEncounteredConsistentlyDuringComputingRepository(IndexRepositoryFactoryIntegrationTest.java:102)
 {noformat}
 

 

=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
[http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0388/test-results/integrationTest/1601691512/]
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

Test report artifacts from this job are available at:

[http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0388/test-artifacts/1601691512/integrationtestfiles-OpenJDK11-1.14.0-build.0388.tgz]

 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (GEODE-8575) IntegrationTest failure IndexRepositoryFactoryIntegrationTest.shouldThrowInternalGemfireErrorWhenIOExceptionEncounteredConsistentlyDuringComputingRepository FAILED

2020-10-05 Thread Mark Hanson (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-8575?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Hanson reassigned GEODE-8575:
--

Assignee: Donal Evans

> IntegrationTest failure 
> IndexRepositoryFactoryIntegrationTest.shouldThrowInternalGemfireErrorWhenIOExceptionEncounteredConsistentlyDuringComputingRepository
>  FAILED
> ---
>
> Key: GEODE-8575
> URL: https://issues.apache.org/jira/browse/GEODE-8575
> Project: Geode
>  Issue Type: Bug
>  Components: lucene
>Affects Versions: 1.14.0
>Reporter: Mark Hanson
>Assignee: Donal Evans
>Priority: Major
>
> [https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/IntegrationTestOpenJDK11/builds/478]
>  
> {noformat}
> org.apache.geode.cache.lucene.internal.IndexRepositoryFactoryIntegrationTest 
> > 
> shouldThrowInternalGemfireErrorWhenIOExceptionEncounteredConsistentlyDuringComputingRepository
>  FAILED
> org.mockito.exceptions.misusing.UnfinishedStubbingException: 
> Unfinished stubbing detected here:
> -> at 
> org.apache.geode.cache.lucene.internal.IndexRepositoryFactoryIntegrationTest.shouldThrowInternalGemfireErrorWhenIOExceptionEncounteredConsistentlyDuringComputingRepository(IndexRepositoryFactoryIntegrationTest.java:102)
> E.g. thenReturn() may be missing.
> Examples of correct stubbing:
> when(mock.isOk()).thenReturn(true);
> when(mock.isOk()).thenThrow(exception);
> doThrow(exception).when(mock).someVoidMethod();
> Hints:
>  1. missing thenReturn()
>  2. you are trying to stub a final method, which is not supported
>  3. you are stubbing the behaviour of another mock inside before 
> 'thenReturn' instruction is completed
> at 
> org.apache.geode.cache.lucene.internal.IndexRepositoryFactoryIntegrationTest.shouldThrowInternalGemfireErrorWhenIOExceptionEncounteredConsistentlyDuringComputingRepository(IndexRepositoryFactoryIntegrationTest.java:102)
>  {noformat}
>  
>  
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI 
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> [http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0388/test-results/integrationTest/1601691512/]
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> Test report artifacts from this job are available at:
> [http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0388/test-artifacts/1601691512/integrationtestfiles-OpenJDK11-1.14.0-build.0388.tgz]
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (GEODE-8574) ClassCastException when hitting members REST endpoint

2020-10-05 Thread Jinmei Liao (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-8574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jinmei Liao reassigned GEODE-8574:
--

Assignee: Jinmei Liao

> ClassCastException when hitting members REST endpoint
> -
>
> Key: GEODE-8574
> URL: https://issues.apache.org/jira/browse/GEODE-8574
> Project: Geode
>  Issue Type: Improvement
>  Components: rest (admin)
>Affects Versions: 1.13.0
>Reporter: Jason Huynh
>Assignee: Jinmei Liao
>Priority: Major
>  Labels: GeodeOperationAPI
>
> This might be similar to https://issues.apache.org/jira/browse/GEODE-8078
> We see a FunctionInvocationTargetException when trying to use the rest 
> endpoint while servers are restarting/recovering
> [error 2020/10/01 21:49:57.381 GMT  tid=0x46] class 
> org.apache.geode.cache.execute.FunctionInvocationTargetException cannot be 
> cast to class org.apache.geode.management.runtime.RuntimeInfo 
> (org.apache.geode.cache.execute.FunctionInvocationTargetException and 
> org.apache.geode.management.runtime.RuntimeInfo are in unnamed module of 
> loader 'app')
> java.lang.ClassCastException: class 
> org.apache.geode.cache.execute.FunctionInvocationTargetException cannot be 
> cast to class org.apache.geode.management.runtime.RuntimeInfo 
> (org.apache.geode.cache.execute.FunctionInvocationTargetException and 
> org.apache.geode.management.runtime.RuntimeInfo are in unnamed module of 
> loader 'app')
> at 
> org.apache.geode.management.internal.api.LocatorClusterManagementService.list(LocatorClusterManagementService.java:459)
> at 
> org.apache.geode.management.internal.api.LocatorClusterManagementService.get(LocatorClusterManagementService.java:476)
> at 
> org.apache.geode.management.internal.rest.controllers.MemberManagementController.getMember(MemberManagementController.java:50)
> at 
> org.apache.geode.management.internal.rest.controllers.MemberManagementController$$FastClassBySpringCGLIB$$3634e452.invoke()
> at org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:218)
> at 
> org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.invokeJoinpoint(CglibAopProxy.java:771)
> at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163)
> at 
> org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:749)
> at 
> org.springframework.security.access.intercept.aopalliance.MethodSecurityInterceptor.invoke(MethodSecurityInterceptor.java:61)
> at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186)
> at 
> org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:749)
> at 
> org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:691)
> at 
> org.apache.geode.management.internal.rest.controllers.MemberManagementController$$EnhancerBySpringCGLIB$$ef2756b6.getMember()
> at jdk.internal.reflect.GeneratedMethodAccessor237.invoke(Unknown Source)
> at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:566)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8553) Reduce ThinClientLocatorHelper lock time

2020-10-05 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8553?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208283#comment-17208283
 ] 

ASF GitHub Bot commented on GEODE-8553:
---

pdxcodemonkey commented on pull request #660:
URL: https://github.com/apache/geode-native/pull/660#issuecomment-703854698


   If you push the build fix to your branch, my pipeline will run build/test 
for all platforms automatically...



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Reduce ThinClientLocatorHelper lock time
> 
>
> Key: GEODE-8553
> URL: https://issues.apache.org/jira/browse/GEODE-8553
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Affects Versions: 1.12.0, 1.13.0
>Reporter: Mario Salazar de Torres
>Assignee: Mario Salazar de Torres
>Priority: Major
>  Labels: pull-request-available
>
> During my troublshootings, I've seen that locking m_locatorLock for the whole 
> scope of the class function members might cause some inter-locks.
> Problem here and in many other places of the NC is that networking operations 
> are performed while a mutex is locked. Therefore if *thread A* takes longer 
> than expected in performing its network operation, it might block another one 
> which does not requires any resource of the first *thread A*. Hence, the 
> inter-lock.
> This improvement is the first one of a series regarding to lock scope 
> reduction when it comes with code regarding networking in NC.
>  



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (GEODE-8576) "security-peer-auth-init" property should not be marked as deprecated

2020-10-05 Thread Jinmei Liao (Jira)
Jinmei Liao created GEODE-8576:
--

 Summary: "security-peer-auth-init" property should not be marked 
as deprecated
 Key: GEODE-8576
 URL: https://issues.apache.org/jira/browse/GEODE-8576
 Project: Geode
  Issue Type: Bug
  Components: configuration
Reporter: Jinmei Liao


in some cases, this is still useful if credentials are not supplied as plain 
text in "security-username" and "security-password"



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (GEODE-8576) "security-peer-auth-init" property should not be marked as deprecated

2020-10-05 Thread Jinmei Liao (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-8576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jinmei Liao updated GEODE-8576:
---
Affects Version/s: 1.13.0

> "security-peer-auth-init" property should not be marked as deprecated
> -
>
> Key: GEODE-8576
> URL: https://issues.apache.org/jira/browse/GEODE-8576
> Project: Geode
>  Issue Type: Bug
>  Components: configuration
>Affects Versions: 1.13.0
>Reporter: Jinmei Liao
>Priority: Major
>
> in some cases, this is still useful if credentials are not supplied as plain 
> text in "security-username" and "security-password"



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Assigned] (GEODE-8576) "security-peer-auth-init" property should not be marked as deprecated

2020-10-05 Thread Jinmei Liao (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-8576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jinmei Liao reassigned GEODE-8576:
--

Assignee: Jinmei Liao

> "security-peer-auth-init" property should not be marked as deprecated
> -
>
> Key: GEODE-8576
> URL: https://issues.apache.org/jira/browse/GEODE-8576
> Project: Geode
>  Issue Type: Bug
>  Components: configuration
>Affects Versions: 1.13.0
>Reporter: Jinmei Liao
>Assignee: Jinmei Liao
>Priority: Major
>  Labels: GeodeOperationAPI
>
> in some cases, this is still useful if credentials are not supplied as plain 
> text in "security-username" and "security-password"



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (GEODE-8576) "security-peer-auth-init" property should not be marked as deprecated

2020-10-05 Thread Jinmei Liao (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-8576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jinmei Liao updated GEODE-8576:
---
Labels: GeodeOperationAPI  (was: )

> "security-peer-auth-init" property should not be marked as deprecated
> -
>
> Key: GEODE-8576
> URL: https://issues.apache.org/jira/browse/GEODE-8576
> Project: Geode
>  Issue Type: Bug
>  Components: configuration
>Affects Versions: 1.13.0
>Reporter: Jinmei Liao
>Priority: Major
>  Labels: GeodeOperationAPI
>
> in some cases, this is still useful if credentials are not supplied as plain 
> text in "security-username" and "security-password"



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8419) SSL/TLS protocol and cipher suite configuration is ignored

2020-10-05 Thread Bill Burcham (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208318#comment-17208318
 ] 

Bill Burcham commented on GEODE-8419:
-

I went to port this to `support/1.13` just now but I see it's already there 
Q.E.D.

> SSL/TLS protocol and cipher suite configuration is ignored
> --
>
> Key: GEODE-8419
> URL: https://issues.apache.org/jira/browse/GEODE-8419
> Project: Geode
>  Issue Type: Bug
>  Components: client/server, membership, security
>Affects Versions: 1.10.0, 1.11.0, 1.12.0, 1.13.0, 1.14.0
>Reporter: Jacob Barrett
>Assignee: Bruce J Schuchardt
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> Configuring {{ssl-protocols}} or {{ssl-ciphers}} properties, or per-component 
> ssl properties, have no effect. Configuring {{ssl-protocols}} may effect the 
> {{SSLContext}} selected and limit some of the protocols allowed but does not 
> restrict to just the set specified in the property. The {{ssl-ciphers}} 
> property does not limit cipher selection at all.
> The result is that all ciphers allowed under the match {{SSLContext}} are 
> allowed and negotiated. This can result in an unintended cipher being used in 
> SSL/TLS communication. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (GEODE-8576) "security-peer-auth-init" property should not be marked as deprecated

2020-10-05 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-8576?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated GEODE-8576:
--
Labels: GeodeOperationAPI pull-request-available  (was: GeodeOperationAPI)

> "security-peer-auth-init" property should not be marked as deprecated
> -
>
> Key: GEODE-8576
> URL: https://issues.apache.org/jira/browse/GEODE-8576
> Project: Geode
>  Issue Type: Bug
>  Components: configuration
>Affects Versions: 1.13.0
>Reporter: Jinmei Liao
>Assignee: Jinmei Liao
>Priority: Major
>  Labels: GeodeOperationAPI, pull-request-available
>
> in some cases, this is still useful if credentials are not supplied as plain 
> text in "security-username" and "security-password"



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8576) "security-peer-auth-init" property should not be marked as deprecated

2020-10-05 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8576?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208319#comment-17208319
 ] 

ASF GitHub Bot commented on GEODE-8576:
---

jinmeiliao opened a new pull request #5592:
URL: https://github.com/apache/geode/pull/5592


   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, check Concourse for build 
issues and
   submit an update to your PR as soon as possible. If you need help, please 
send an
   email to d...@geode.apache.org.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> "security-peer-auth-init" property should not be marked as deprecated
> -
>
> Key: GEODE-8576
> URL: https://issues.apache.org/jira/browse/GEODE-8576
> Project: Geode
>  Issue Type: Bug
>  Components: configuration
>Affects Versions: 1.13.0
>Reporter: Jinmei Liao
>Assignee: Jinmei Liao
>Priority: Major
>  Labels: GeodeOperationAPI
>
> in some cases, this is still useful if credentials are not supplied as plain 
> text in "security-username" and "security-password"



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Issue Comment Deleted] (GEODE-8419) SSL/TLS protocol and cipher suite configuration is ignored

2020-10-05 Thread Bill Burcham (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-8419?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Bill Burcham updated GEODE-8419:

Comment: was deleted

(was: I went to port this to `support/1.13` just now but I see it's already 
there Q.E.D.)

> SSL/TLS protocol and cipher suite configuration is ignored
> --
>
> Key: GEODE-8419
> URL: https://issues.apache.org/jira/browse/GEODE-8419
> Project: Geode
>  Issue Type: Bug
>  Components: client/server, membership, security
>Affects Versions: 1.10.0, 1.11.0, 1.12.0, 1.13.0, 1.14.0
>Reporter: Jacob Barrett
>Assignee: Bruce J Schuchardt
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> Configuring {{ssl-protocols}} or {{ssl-ciphers}} properties, or per-component 
> ssl properties, have no effect. Configuring {{ssl-protocols}} may effect the 
> {{SSLContext}} selected and limit some of the protocols allowed but does not 
> restrict to just the set specified in the property. The {{ssl-ciphers}} 
> property does not limit cipher selection at all.
> The result is that all ciphers allowed under the match {{SSLContext}} are 
> allowed and negotiated. This can result in an unintended cipher being used in 
> SSL/TLS communication. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8571) Enforce no documentation

2020-10-05 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208322#comment-17208322
 ] 

ASF GitHub Bot commented on GEODE-8571:
---

moleske commented on a change in pull request #666:
URL: https://github.com/apache/geode-native/pull/666#discussion_r499879025



##
File path: cppcache/include/geode/internal/chrono/duration.hpp
##
@@ -145,8 +145,8 @@ inline
 /**
  * Converts std::chrono::duration to std::string.
  *
- * @tparam Rep
- * @tparam Period
+ * @tparam Rep the something that reps
+ * @tparam Period the something else that periods

Review comment:
   Ended up just removing it since it is internal . Let me know what you 
think @karensmolermiller 





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Enforce no documentation
> 
>
> Key: GEODE-8571
> URL: https://issues.apache.org/jira/browse/GEODE-8571
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Michael Oleske
>Priority: Major
>  Labels: pull-request-available
>
> Given I compile the code without exempting no-documentation
> Then it should compile
> Note - was marked as a todo



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Reopened] (GEODE-8566) Redis native tests should not also stand up a Geode server

2020-10-05 Thread Mark Hanson (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-8566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Mark Hanson reopened GEODE-8566:

  Assignee: Jens Deppe

[https://concourse.apachegeode-ci.info/teams/main/pipelines/apache-develop-main/jobs/AcceptanceTestOpenJDK8/builds/483]

 
{noformat}
org.apache.geode.redis.internal.executor.pubsub.PubSubNativeRedisAcceptanceTest 
> ensureOrderingOfPublishedMessages FAILED
java.util.concurrent.ExecutionException: java.lang.RuntimeException: Tried 
10 times, but could not get a good connection.Caused by:
java.lang.RuntimeException: Tried 10 times, but could not get a good 
connection.Caused by:
redis.clients.jedis.exceptions.JedisConnectionException: 
java.net.SocketException: Connection resetCaused by:
java.net.SocketException: Connection 
resetorg.apache.geode.redis.internal.executor.pubsub.PubSubNativeRedisAcceptanceTest
 > testOneSubscriberOneChannelTwoTimes FAILED
org.awaitility.core.ConditionTimeoutException: Condition with lambda 
expression in 
org.apache.geode.redis.internal.executor.pubsub.AbstractPubSubIntegrationTest 
that uses org.apache.geode.redis.mocks.MockSubscriber was not fulfilled within 
5 minutes.
 {noformat}
{noformat}
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=  Test Results URI 
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0390/test-results/acceptanceTest/1601923245/
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=Test
 report artifacts from this job are available 
at:http://files.apachegeode-ci.info/builds/apache-develop-main/1.14.0-build.0390/test-artifacts/1601923245/acceptancetestfiles-OpenJDK8-1.14.0-build.0390.tgz
 {noformat}

> Redis native tests should not also stand up a Geode server
> --
>
> Key: GEODE-8566
> URL: https://issues.apache.org/jira/browse/GEODE-8566
> Project: Geode
>  Issue Type: Test
>  Components: redis
>Reporter: Jens Deppe
>Assignee: Jens Deppe
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> Our native acceptance tests currently extend from the integration tests and 
> both classes have a {{@ClassRule}} that results in both a native (container) 
> instance and a Geode instance starting up. Mostly not a problem except for 
> {{PubSubNativeAcceptanceTest}} which was not testing against native redis.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Created] (GEODE-8577) PubSubNativeRedisAcceptanceTest is flaky

2020-10-05 Thread Jens Deppe (Jira)
Jens Deppe created GEODE-8577:
-

 Summary: PubSubNativeRedisAcceptanceTest is flaky
 Key: GEODE-8577
 URL: https://issues.apache.org/jira/browse/GEODE-8577
 Project: Geode
  Issue Type: Test
  Components: redis
Reporter: Jens Deppe


Going to disable this one test and work on fixing that.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8577) PubSubNativeRedisAcceptanceTest is flaky

2020-10-05 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208340#comment-17208340
 ] 

ASF GitHub Bot commented on GEODE-8577:
---

jdeppe-pivotal opened a new pull request #5593:
URL: https://github.com/apache/geode/pull/5593


   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, check Concourse for build 
issues and
   submit an update to your PR as soon as possible. If you need help, please 
send an
   email to d...@geode.apache.org.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> PubSubNativeRedisAcceptanceTest is flaky
> 
>
> Key: GEODE-8577
> URL: https://issues.apache.org/jira/browse/GEODE-8577
> Project: Geode
>  Issue Type: Test
>  Components: redis
>Reporter: Jens Deppe
>Priority: Major
>
> Going to disable this one test and work on fixing that.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (GEODE-8577) PubSubNativeRedisAcceptanceTest is flaky

2020-10-05 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-8577?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated GEODE-8577:
--
Labels: pull-request-available  (was: )

> PubSubNativeRedisAcceptanceTest is flaky
> 
>
> Key: GEODE-8577
> URL: https://issues.apache.org/jira/browse/GEODE-8577
> Project: Geode
>  Issue Type: Test
>  Components: redis
>Reporter: Jens Deppe
>Priority: Major
>  Labels: pull-request-available
>
> Going to disable this one test and work on fixing that.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8577) PubSubNativeRedisAcceptanceTest is flaky

2020-10-05 Thread Sarah Abbey (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208345#comment-17208345
 ] 

Sarah Abbey commented on GEODE-8577:


Failure in CI: https://concourse.apachegeode-ci.info/builds/195137



> PubSubNativeRedisAcceptanceTest is flaky
> 
>
> Key: GEODE-8577
> URL: https://issues.apache.org/jira/browse/GEODE-8577
> Project: Geode
>  Issue Type: Test
>  Components: redis
>Reporter: Jens Deppe
>Priority: Major
>  Labels: pull-request-available
>
> Going to disable this one test and work on fixing that.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8419) SSL/TLS protocol and cipher suite configuration is ignored

2020-10-05 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208353#comment-17208353
 ] 

ASF subversion and git services commented on GEODE-8419:


Commit ec649411c14b05c38aaf2edb8299a7daf7ed027b in geode's branch 
refs/heads/feature/GEODE-8419-backport-1-13 from Bruce Schuchardt
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=ec64941 ]

GEODE-8419: SSL/TLS protocol and cipher suite configuration is ignored (#5465)

* GEODE-8419: SSL/TLS protocol and cipher suite configuration is ignored

Configure cipher suites when creating an SSLEngine

(cherry picked from commit 537721ff815cf40eff85fde65db9b5e787471c89)


> SSL/TLS protocol and cipher suite configuration is ignored
> --
>
> Key: GEODE-8419
> URL: https://issues.apache.org/jira/browse/GEODE-8419
> Project: Geode
>  Issue Type: Bug
>  Components: client/server, membership, security
>Affects Versions: 1.10.0, 1.11.0, 1.12.0, 1.13.0, 1.14.0
>Reporter: Jacob Barrett
>Assignee: Bruce J Schuchardt
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> Configuring {{ssl-protocols}} or {{ssl-ciphers}} properties, or per-component 
> ssl properties, have no effect. Configuring {{ssl-protocols}} may effect the 
> {{SSLContext}} selected and limit some of the protocols allowed but does not 
> restrict to just the set specified in the property. The {{ssl-ciphers}} 
> property does not limit cipher selection at all.
> The result is that all ciphers allowed under the match {{SSLContext}} are 
> allowed and negotiated. This can result in an unintended cipher being used in 
> SSL/TLS communication. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8419) SSL/TLS protocol and cipher suite configuration is ignored

2020-10-05 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208351#comment-17208351
 ] 

ASF subversion and git services commented on GEODE-8419:


Commit 8754e5fd0f0be1735c627e849e03345e351db683 in geode's branch 
refs/heads/feature/GEODE-8419-backport-1-13 from Bill Burcham
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=8754e5f ]

GEODE-8419: move SSLUtil to net package in preparation for cherry-pick


> SSL/TLS protocol and cipher suite configuration is ignored
> --
>
> Key: GEODE-8419
> URL: https://issues.apache.org/jira/browse/GEODE-8419
> Project: Geode
>  Issue Type: Bug
>  Components: client/server, membership, security
>Affects Versions: 1.10.0, 1.11.0, 1.12.0, 1.13.0, 1.14.0
>Reporter: Jacob Barrett
>Assignee: Bruce J Schuchardt
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> Configuring {{ssl-protocols}} or {{ssl-ciphers}} properties, or per-component 
> ssl properties, have no effect. Configuring {{ssl-protocols}} may effect the 
> {{SSLContext}} selected and limit some of the protocols allowed but does not 
> restrict to just the set specified in the property. The {{ssl-ciphers}} 
> property does not limit cipher selection at all.
> The result is that all ciphers allowed under the match {{SSLContext}} are 
> allowed and negotiated. This can result in an unintended cipher being used in 
> SSL/TLS communication. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8419) SSL/TLS protocol and cipher suite configuration is ignored

2020-10-05 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208352#comment-17208352
 ] 

ASF subversion and git services commented on GEODE-8419:


Commit ec649411c14b05c38aaf2edb8299a7daf7ed027b in geode's branch 
refs/heads/feature/GEODE-8419-backport-1-13 from Bruce Schuchardt
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=ec64941 ]

GEODE-8419: SSL/TLS protocol and cipher suite configuration is ignored (#5465)

* GEODE-8419: SSL/TLS protocol and cipher suite configuration is ignored

Configure cipher suites when creating an SSLEngine

(cherry picked from commit 537721ff815cf40eff85fde65db9b5e787471c89)


> SSL/TLS protocol and cipher suite configuration is ignored
> --
>
> Key: GEODE-8419
> URL: https://issues.apache.org/jira/browse/GEODE-8419
> Project: Geode
>  Issue Type: Bug
>  Components: client/server, membership, security
>Affects Versions: 1.10.0, 1.11.0, 1.12.0, 1.13.0, 1.14.0
>Reporter: Jacob Barrett
>Assignee: Bruce J Schuchardt
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> Configuring {{ssl-protocols}} or {{ssl-ciphers}} properties, or per-component 
> ssl properties, have no effect. Configuring {{ssl-protocols}} may effect the 
> {{SSLContext}} selected and limit some of the protocols allowed but does not 
> restrict to just the set specified in the property. The {{ssl-ciphers}} 
> property does not limit cipher selection at all.
> The result is that all ciphers allowed under the match {{SSLContext}} are 
> allowed and negotiated. This can result in an unintended cipher being used in 
> SSL/TLS communication. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8419) SSL/TLS protocol and cipher suite configuration is ignored

2020-10-05 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208356#comment-17208356
 ] 

ASF subversion and git services commented on GEODE-8419:


Commit ec649411c14b05c38aaf2edb8299a7daf7ed027b in geode's branch 
refs/heads/feature/GEODE-8419-backport-1-13 from Bruce Schuchardt
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=ec64941 ]

GEODE-8419: SSL/TLS protocol and cipher suite configuration is ignored (#5465)

* GEODE-8419: SSL/TLS protocol and cipher suite configuration is ignored

Configure cipher suites when creating an SSLEngine

(cherry picked from commit 537721ff815cf40eff85fde65db9b5e787471c89)


> SSL/TLS protocol and cipher suite configuration is ignored
> --
>
> Key: GEODE-8419
> URL: https://issues.apache.org/jira/browse/GEODE-8419
> Project: Geode
>  Issue Type: Bug
>  Components: client/server, membership, security
>Affects Versions: 1.10.0, 1.11.0, 1.12.0, 1.13.0, 1.14.0
>Reporter: Jacob Barrett
>Assignee: Bruce J Schuchardt
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> Configuring {{ssl-protocols}} or {{ssl-ciphers}} properties, or per-component 
> ssl properties, have no effect. Configuring {{ssl-protocols}} may effect the 
> {{SSLContext}} selected and limit some of the protocols allowed but does not 
> restrict to just the set specified in the property. The {{ssl-ciphers}} 
> property does not limit cipher selection at all.
> The result is that all ciphers allowed under the match {{SSLContext}} are 
> allowed and negotiated. This can result in an unintended cipher being used in 
> SSL/TLS communication. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8419) SSL/TLS protocol and cipher suite configuration is ignored

2020-10-05 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208355#comment-17208355
 ] 

ASF subversion and git services commented on GEODE-8419:


Commit ec649411c14b05c38aaf2edb8299a7daf7ed027b in geode's branch 
refs/heads/feature/GEODE-8419-backport-1-13 from Bruce Schuchardt
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=ec64941 ]

GEODE-8419: SSL/TLS protocol and cipher suite configuration is ignored (#5465)

* GEODE-8419: SSL/TLS protocol and cipher suite configuration is ignored

Configure cipher suites when creating an SSLEngine

(cherry picked from commit 537721ff815cf40eff85fde65db9b5e787471c89)


> SSL/TLS protocol and cipher suite configuration is ignored
> --
>
> Key: GEODE-8419
> URL: https://issues.apache.org/jira/browse/GEODE-8419
> Project: Geode
>  Issue Type: Bug
>  Components: client/server, membership, security
>Affects Versions: 1.10.0, 1.11.0, 1.12.0, 1.13.0, 1.14.0
>Reporter: Jacob Barrett
>Assignee: Bruce J Schuchardt
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> Configuring {{ssl-protocols}} or {{ssl-ciphers}} properties, or per-component 
> ssl properties, have no effect. Configuring {{ssl-protocols}} may effect the 
> {{SSLContext}} selected and limit some of the protocols allowed but does not 
> restrict to just the set specified in the property. The {{ssl-ciphers}} 
> property does not limit cipher selection at all.
> The result is that all ciphers allowed under the match {{SSLContext}} are 
> allowed and negotiated. This can result in an unintended cipher being used in 
> SSL/TLS communication. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8419) SSL/TLS protocol and cipher suite configuration is ignored

2020-10-05 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208354#comment-17208354
 ] 

ASF subversion and git services commented on GEODE-8419:


Commit 8754e5fd0f0be1735c627e849e03345e351db683 in geode's branch 
refs/heads/feature/GEODE-8419-backport-1-13 from Bill Burcham
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=8754e5f ]

GEODE-8419: move SSLUtil to net package in preparation for cherry-pick


> SSL/TLS protocol and cipher suite configuration is ignored
> --
>
> Key: GEODE-8419
> URL: https://issues.apache.org/jira/browse/GEODE-8419
> Project: Geode
>  Issue Type: Bug
>  Components: client/server, membership, security
>Affects Versions: 1.10.0, 1.11.0, 1.12.0, 1.13.0, 1.14.0
>Reporter: Jacob Barrett
>Assignee: Bruce J Schuchardt
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> Configuring {{ssl-protocols}} or {{ssl-ciphers}} properties, or per-component 
> ssl properties, have no effect. Configuring {{ssl-protocols}} may effect the 
> {{SSLContext}} selected and limit some of the protocols allowed but does not 
> restrict to just the set specified in the property. The {{ssl-ciphers}} 
> property does not limit cipher selection at all.
> The result is that all ciphers allowed under the match {{SSLContext}} are 
> allowed and negotiated. This can result in an unintended cipher being used in 
> SSL/TLS communication. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8419) SSL/TLS protocol and cipher suite configuration is ignored

2020-10-05 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208357#comment-17208357
 ] 

ASF GitHub Bot commented on GEODE-8419:
---

Bill opened a new pull request #5594:
URL: https://github.com/apache/geode/pull/5594


   Backport of GEODE-8419 to `support/1.13`
   
   Cherry-picked from `develop`
   
   Note that two commits will be merged: one to move `SSLUtil` and a second one 
with the actual cherry-picked changes from `develop`.
   
   See also: https://github.com/apache/geode/pull/5587 for `support/1.12` 
backport.
   
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?
   
   - [x] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [x] Does `gradlew build` run cleanly?
   
   - [x] Have you written or updated unit tests to verify your changes?
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> SSL/TLS protocol and cipher suite configuration is ignored
> --
>
> Key: GEODE-8419
> URL: https://issues.apache.org/jira/browse/GEODE-8419
> Project: Geode
>  Issue Type: Bug
>  Components: client/server, membership, security
>Affects Versions: 1.10.0, 1.11.0, 1.12.0, 1.13.0, 1.14.0
>Reporter: Jacob Barrett
>Assignee: Bruce J Schuchardt
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> Configuring {{ssl-protocols}} or {{ssl-ciphers}} properties, or per-component 
> ssl properties, have no effect. Configuring {{ssl-protocols}} may effect the 
> {{SSLContext}} selected and limit some of the protocols allowed but does not 
> restrict to just the set specified in the property. The {{ssl-ciphers}} 
> property does not limit cipher selection at all.
> The result is that all ciphers allowed under the match {{SSLContext}} are 
> allowed and negotiated. This can result in an unintended cipher being used in 
> SSL/TLS communication. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8577) PubSubNativeRedisAcceptanceTest is flaky

2020-10-05 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208364#comment-17208364
 ] 

ASF GitHub Bot commented on GEODE-8577:
---

dschneider-pivotal commented on a change in pull request #5593:
URL: https://github.com/apache/geode/pull/5593#discussion_r499898286



##
File path: 
geode-redis/src/acceptanceTest/java/org/apache/geode/redis/internal/executor/pubsub/PubSubNativeRedisAcceptanceTest.java
##
@@ -16,9 +16,11 @@
 package org.apache.geode.redis.internal.executor.pubsub;
 
 import org.junit.ClassRule;
+import org.junit.Ignore;
 
 import org.apache.geode.NativeRedisTestRule;
 
+@Ignore

Review comment:
   I'd suggest having a geode ticket that will not be fixed until this 
Ignore can be removed. You can reference that ticket in the Ignore comment. I 
think it is okay for that to be GEODE-8577. You just need to be careful to not 
mark GEODE-8577 as fixed when you push this ignore.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> PubSubNativeRedisAcceptanceTest is flaky
> 
>
> Key: GEODE-8577
> URL: https://issues.apache.org/jira/browse/GEODE-8577
> Project: Geode
>  Issue Type: Test
>  Components: redis
>Reporter: Jens Deppe
>Priority: Major
>  Labels: pull-request-available
>
> Going to disable this one test and work on fixing that.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8572) LogExporter throws if a directory matches its file selector

2020-10-05 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208369#comment-17208369
 ] 

ASF GitHub Bot commented on GEODE-8572:
---

demery-pivotal opened a new pull request #5595:
URL: https://github.com/apache/geode/pull/5595


   Changed LogExporter to refrain from attempting to read directories, even
   when a directory's path matches the exporter's file selector predicates.
   
   Changed LogExporterIntegrationTest to configure the server to write
   files in a unique subdirectory of the current working directory. Some
   tests were configuring the server to use a temporary folder that could
   be reused by other tests.
   
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, check Concourse for build 
issues and
   submit an update to your PR as soon as possible. If you need help, please 
send an
   email to d...@geode.apache.org.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> LogExporter throws if a directory matches its file selector
> ---
>
> Key: GEODE-8572
> URL: https://issues.apache.org/jira/browse/GEODE-8572
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Affects Versions: 1.13.0
>Reporter: Dale Emery
>Priority: Major
>  Labels: GeodeOperationAPI
>
> {{LogExporter}} tries to read and export any directory entry whose name is 
> accepted by its log file selector predicate. The predicate accepts any entry 
> whose name, when converted to lower case, contains ".log". If one of those 
> entries is directory, the predicate accepts it anyway. When {{LogExporter}} 
> attempts to create a {{FileReader}}  read it, the {{FileReader}} constructor 
> throws {{FileNotFoundException}}.
> There is a stat file selector predicate that works similarly.
> {{LogExporter}}'s log and stat file selector predicates should accept only 
> files, and not directories. And perhaps the should accept only files whose 
> names _end_ in the appropriate extension, rather than _containing_ the 
> characters. The predicates are defined in {{LogExporter}}'s 
> {{findLogFiles()}} and {{findStatFiles()}} methods.
> I discovered this defect by running {{LogExporterIntegrationTest}} on macOS. 
> Each test's preparation writes some to-be-exported files into a temporary 
> directory that, on macOS, may contain numerous other files and directories. 
> One of those directories (e.g. 
> /var/folders/yz/6y59fxln38d7lf2jxng1zgg4gn/T/com.apple.LoginUserService), 
> which matches the {{LogExporter}}'s predicate.
> These tests should also be changed to write their to-be-exported files to a 
> directory that is known to be empty.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8480) Add tx manager check in geode-native transaction example

2020-10-05 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208368#comment-17208368
 ] 

ASF GitHub Bot commented on GEODE-8480:
---

codecov-commenter commented on pull request #648:
URL: https://github.com/apache/geode-native/pull/648#issuecomment-703916868


   # [Codecov](https://codecov.io/gh/apache/geode-native/pull/648?src=pr&el=h1) 
Report
   > Merging 
[#648](https://codecov.io/gh/apache/geode-native/pull/648?src=pr&el=desc) into 
[develop](https://codecov.io/gh/apache/geode-native/commit/4617f22a1fa91464e8f9a38b08eeff206c1677d4?el=desc)
 will **increase** coverage by `0.26%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/geode-native/pull/648/graphs/tree.svg?width=650&height=150&src=pr&token=plpAqoqGag)](https://codecov.io/gh/apache/geode-native/pull/648?src=pr&el=tree)
   
   ```diff
   @@ Coverage Diff @@
   ##   develop #648  +/-   ##
   ===
   + Coverage73.95%   74.21%   +0.26% 
   ===
 Files  644  644  
 Lines5113251132  
   ===
   + Hits 3781337948 +135 
   + Misses   1331913184 -135 
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/geode-native/pull/648?src=pr&el=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[cppcache/src/ThinClientStickyManager.cpp](https://codecov.io/gh/apache/geode-native/pull/648/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRTdGlja3lNYW5hZ2VyLmNwcA==)
 | `77.88% <0.00%> (-10.58%)` | :arrow_down: |
   | 
[...test/testThinClientPoolExecuteHAFunctionPrSHOP.cpp](https://codecov.io/gh/apache/geode-native/pull/648/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvaW50ZWdyYXRpb24tdGVzdC90ZXN0VGhpbkNsaWVudFBvb2xFeGVjdXRlSEFGdW5jdGlvblByU0hPUC5jcHA=)
 | `91.20% <0.00%> (-3.71%)` | :arrow_down: |
   | 
[cppcache/src/ClientMetadataService.cpp](https://codecov.io/gh/apache/geode-native/pull/648/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL0NsaWVudE1ldGFkYXRhU2VydmljZS5jcHA=)
 | `64.98% <0.00%> (-0.92%)` | :arrow_down: |
   | 
[cppcache/src/ClientMetadata.cpp](https://codecov.io/gh/apache/geode-native/pull/648/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL0NsaWVudE1ldGFkYXRhLmNwcA==)
 | `65.16% <0.00%> (-0.57%)` | :arrow_down: |
   | 
[cppcache/src/ThinClientLocatorHelper.cpp](https://codecov.io/gh/apache/geode-native/pull/648/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRMb2NhdG9ySGVscGVyLmNwcA==)
 | `85.71% <0.00%> (-0.40%)` | :arrow_down: |
   | 
[cppcache/src/ExecutionImpl.cpp](https://codecov.io/gh/apache/geode-native/pull/648/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL0V4ZWN1dGlvbkltcGwuY3Bw)
 | `67.69% <0.00%> (-0.39%)` | :arrow_down: |
   | 
[cppcache/src/TcrConnection.cpp](https://codecov.io/gh/apache/geode-native/pull/648/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RjckNvbm5lY3Rpb24uY3Bw)
 | `72.48% <0.00%> (-0.32%)` | :arrow_down: |
   | 
[cppcache/src/ThinClientRedundancyManager.cpp](https://codecov.io/gh/apache/geode-native/pull/648/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRSZWR1bmRhbmN5TWFuYWdlci5jcHA=)
 | `75.62% <0.00%> (-0.32%)` | :arrow_down: |
   | 
[cppcache/src/TcrMessage.cpp](https://codecov.io/gh/apache/geode-native/pull/648/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1Rjck1lc3NhZ2UuY3Bw)
 | `85.62% <0.00%> (+0.31%)` | :arrow_up: |
   | 
[cppcache/src/ThinClientPoolDM.cpp](https://codecov.io/gh/apache/geode-native/pull/648/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRQb29sRE0uY3Bw)
 | `75.48% <0.00%> (+0.35%)` | :arrow_up: |
   | ... and [15 
more](https://codecov.io/gh/apache/geode-native/pull/648/diff?src=pr&el=tree-more)
 | |
   
   --
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/geode-native/pull/648?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute  (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/geode-native/pull/648?src=pr&el=footer). 
Last update 
[4617f22...b824345](https://codecov.io/gh/apache/geode-native/pull/648?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add tx manager check in geode-native transaction example
> 
>
> Key: GEODE-8480
> URL: 

[jira] [Updated] (GEODE-8572) LogExporter throws if a directory matches its file selector

2020-10-05 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-8572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated GEODE-8572:
--
Labels: GeodeOperationAPI pull-request-available  (was: GeodeOperationAPI)

> LogExporter throws if a directory matches its file selector
> ---
>
> Key: GEODE-8572
> URL: https://issues.apache.org/jira/browse/GEODE-8572
> Project: Geode
>  Issue Type: Bug
>  Components: gfsh
>Affects Versions: 1.13.0
>Reporter: Dale Emery
>Priority: Major
>  Labels: GeodeOperationAPI, pull-request-available
>
> {{LogExporter}} tries to read and export any directory entry whose name is 
> accepted by its log file selector predicate. The predicate accepts any entry 
> whose name, when converted to lower case, contains ".log". If one of those 
> entries is directory, the predicate accepts it anyway. When {{LogExporter}} 
> attempts to create a {{FileReader}}  read it, the {{FileReader}} constructor 
> throws {{FileNotFoundException}}.
> There is a stat file selector predicate that works similarly.
> {{LogExporter}}'s log and stat file selector predicates should accept only 
> files, and not directories. And perhaps the should accept only files whose 
> names _end_ in the appropriate extension, rather than _containing_ the 
> characters. The predicates are defined in {{LogExporter}}'s 
> {{findLogFiles()}} and {{findStatFiles()}} methods.
> I discovered this defect by running {{LogExporterIntegrationTest}} on macOS. 
> Each test's preparation writes some to-be-exported files into a temporary 
> directory that, on macOS, may contain numerous other files and directories. 
> One of those directories (e.g. 
> /var/folders/yz/6y59fxln38d7lf2jxng1zgg4gn/T/com.apple.LoginUserService), 
> which matches the {{LogExporter}}'s predicate.
> These tests should also be changed to write their to-be-exported files to a 
> directory that is known to be empty.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8571) Enforce no documentation

2020-10-05 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208374#comment-17208374
 ] 

ASF GitHub Bot commented on GEODE-8571:
---

pdxcodemonkey merged pull request #666:
URL: https://github.com/apache/geode-native/pull/666


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Enforce no documentation
> 
>
> Key: GEODE-8571
> URL: https://issues.apache.org/jira/browse/GEODE-8571
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Michael Oleske
>Priority: Major
>  Labels: pull-request-available
>
> Given I compile the code without exempting no-documentation
> Then it should compile
> Note - was marked as a todo



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8571) Enforce no documentation

2020-10-05 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8571?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208373#comment-17208373
 ] 

ASF subversion and git services commented on GEODE-8571:


Commit 6816274c0296b3370d7a261d6ed6942b2e405cf2 in geode-native's branch 
refs/heads/develop from M. Oleske
[ https://gitbox.apache.org/repos/asf?p=geode-native.git;h=6816274 ]

GEODE-8571: Enforce documentation errors (#666)

* Enforce documentation errors

Authored-by: M. Oleske 

> Enforce no documentation
> 
>
> Key: GEODE-8571
> URL: https://issues.apache.org/jira/browse/GEODE-8571
> Project: Geode
>  Issue Type: Improvement
>  Components: native client
>Reporter: Michael Oleske
>Priority: Major
>  Labels: pull-request-available
>
> Given I compile the code without exempting no-documentation
> Then it should compile
> Note - was marked as a todo



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8574) ClassCastException when hitting members REST endpoint

2020-10-05 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8574?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208382#comment-17208382
 ] 

ASF GitHub Bot commented on GEODE-8574:
---

jinmeiliao opened a new pull request #5596:
URL: https://github.com/apache/geode/pull/5596


   …ion when function execution throws an Exception.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> ClassCastException when hitting members REST endpoint
> -
>
> Key: GEODE-8574
> URL: https://issues.apache.org/jira/browse/GEODE-8574
> Project: Geode
>  Issue Type: Improvement
>  Components: rest (admin)
>Affects Versions: 1.13.0
>Reporter: Jason Huynh
>Assignee: Jinmei Liao
>Priority: Major
>  Labels: GeodeOperationAPI
>
> This might be similar to https://issues.apache.org/jira/browse/GEODE-8078
> We see a FunctionInvocationTargetException when trying to use the rest 
> endpoint while servers are restarting/recovering
> [error 2020/10/01 21:49:57.381 GMT  tid=0x46] class 
> org.apache.geode.cache.execute.FunctionInvocationTargetException cannot be 
> cast to class org.apache.geode.management.runtime.RuntimeInfo 
> (org.apache.geode.cache.execute.FunctionInvocationTargetException and 
> org.apache.geode.management.runtime.RuntimeInfo are in unnamed module of 
> loader 'app')
> java.lang.ClassCastException: class 
> org.apache.geode.cache.execute.FunctionInvocationTargetException cannot be 
> cast to class org.apache.geode.management.runtime.RuntimeInfo 
> (org.apache.geode.cache.execute.FunctionInvocationTargetException and 
> org.apache.geode.management.runtime.RuntimeInfo are in unnamed module of 
> loader 'app')
> at 
> org.apache.geode.management.internal.api.LocatorClusterManagementService.list(LocatorClusterManagementService.java:459)
> at 
> org.apache.geode.management.internal.api.LocatorClusterManagementService.get(LocatorClusterManagementService.java:476)
> at 
> org.apache.geode.management.internal.rest.controllers.MemberManagementController.getMember(MemberManagementController.java:50)
> at 
> org.apache.geode.management.internal.rest.controllers.MemberManagementController$$FastClassBySpringCGLIB$$3634e452.invoke()
> at org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:218)
> at 
> org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.invokeJoinpoint(CglibAopProxy.java:771)
> at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163)
> at 
> org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:749)
> at 
> org.springframework.security.access.intercept.aopalliance.MethodSecurityInterceptor.invoke(MethodSecurityInterceptor.java:61)
> at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186)
> at 
> org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:749)
> at 
> org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:691)
> at 
> org.apache.geode.management.internal.rest.controllers.MemberManagementController$$EnhancerBySpringCGLIB$$ef2756b6.getMember()
> at jdk.internal.reflect.GeneratedMethodAccessor237.invoke(Unknown Source)
> at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:566)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Updated] (GEODE-8574) ClassCastException when hitting members REST endpoint

2020-10-05 Thread ASF GitHub Bot (Jira)


 [ 
https://issues.apache.org/jira/browse/GEODE-8574?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

ASF GitHub Bot updated GEODE-8574:
--
Labels: GeodeOperationAPI pull-request-available  (was: GeodeOperationAPI)

> ClassCastException when hitting members REST endpoint
> -
>
> Key: GEODE-8574
> URL: https://issues.apache.org/jira/browse/GEODE-8574
> Project: Geode
>  Issue Type: Improvement
>  Components: rest (admin)
>Affects Versions: 1.13.0
>Reporter: Jason Huynh
>Assignee: Jinmei Liao
>Priority: Major
>  Labels: GeodeOperationAPI, pull-request-available
>
> This might be similar to https://issues.apache.org/jira/browse/GEODE-8078
> We see a FunctionInvocationTargetException when trying to use the rest 
> endpoint while servers are restarting/recovering
> [error 2020/10/01 21:49:57.381 GMT  tid=0x46] class 
> org.apache.geode.cache.execute.FunctionInvocationTargetException cannot be 
> cast to class org.apache.geode.management.runtime.RuntimeInfo 
> (org.apache.geode.cache.execute.FunctionInvocationTargetException and 
> org.apache.geode.management.runtime.RuntimeInfo are in unnamed module of 
> loader 'app')
> java.lang.ClassCastException: class 
> org.apache.geode.cache.execute.FunctionInvocationTargetException cannot be 
> cast to class org.apache.geode.management.runtime.RuntimeInfo 
> (org.apache.geode.cache.execute.FunctionInvocationTargetException and 
> org.apache.geode.management.runtime.RuntimeInfo are in unnamed module of 
> loader 'app')
> at 
> org.apache.geode.management.internal.api.LocatorClusterManagementService.list(LocatorClusterManagementService.java:459)
> at 
> org.apache.geode.management.internal.api.LocatorClusterManagementService.get(LocatorClusterManagementService.java:476)
> at 
> org.apache.geode.management.internal.rest.controllers.MemberManagementController.getMember(MemberManagementController.java:50)
> at 
> org.apache.geode.management.internal.rest.controllers.MemberManagementController$$FastClassBySpringCGLIB$$3634e452.invoke()
> at org.springframework.cglib.proxy.MethodProxy.invoke(MethodProxy.java:218)
> at 
> org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.invokeJoinpoint(CglibAopProxy.java:771)
> at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:163)
> at 
> org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:749)
> at 
> org.springframework.security.access.intercept.aopalliance.MethodSecurityInterceptor.invoke(MethodSecurityInterceptor.java:61)
> at 
> org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:186)
> at 
> org.springframework.aop.framework.CglibAopProxy$CglibMethodInvocation.proceed(CglibAopProxy.java:749)
> at 
> org.springframework.aop.framework.CglibAopProxy$DynamicAdvisedInterceptor.intercept(CglibAopProxy.java:691)
> at 
> org.apache.geode.management.internal.rest.controllers.MemberManagementController$$EnhancerBySpringCGLIB$$ef2756b6.getMember()
> at jdk.internal.reflect.GeneratedMethodAccessor237.invoke(Unknown Source)
> at 
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at java.base/java.lang.reflect.Method.invoke(Method.java:566)



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8419) SSL/TLS protocol and cipher suite configuration is ignored

2020-10-05 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208396#comment-17208396
 ] 

ASF subversion and git services commented on GEODE-8419:


Commit 0eedeb1ee7f4cb28e83fd963d8f3c6fa3fbbe823 in geode's branch 
refs/heads/feature/GEODE-8419-backport-1-13 from Bill Burcham
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=0eedeb1 ]

GEODE-8419: straggler spA


> SSL/TLS protocol and cipher suite configuration is ignored
> --
>
> Key: GEODE-8419
> URL: https://issues.apache.org/jira/browse/GEODE-8419
> Project: Geode
>  Issue Type: Bug
>  Components: client/server, membership, security
>Affects Versions: 1.10.0, 1.11.0, 1.12.0, 1.13.0, 1.14.0
>Reporter: Jacob Barrett
>Assignee: Bruce J Schuchardt
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> Configuring {{ssl-protocols}} or {{ssl-ciphers}} properties, or per-component 
> ssl properties, have no effect. Configuring {{ssl-protocols}} may effect the 
> {{SSLContext}} selected and limit some of the protocols allowed but does not 
> restrict to just the set specified in the property. The {{ssl-ciphers}} 
> property does not limit cipher selection at all.
> The result is that all ciphers allowed under the match {{SSLContext}} are 
> allowed and negotiated. This can result in an unintended cipher being used in 
> SSL/TLS communication. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8419) SSL/TLS protocol and cipher suite configuration is ignored

2020-10-05 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208398#comment-17208398
 ] 

ASF subversion and git services commented on GEODE-8419:


Commit 1ab6c115cb43c58773efcca2ac6f36246c9f3faf in geode's branch 
refs/heads/feature/GEODE-8419-backport-1-13 from Bruce Schuchardt
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=1ab6c11 ]

GEODE-8419: SSL/TLS protocol and cipher suite configuration is ignored (#5465)

* GEODE-8419: SSL/TLS protocol and cipher suite configuration is ignored

Configure cipher suites when creating an SSLEngine

(cherry picked from commit 537721ff815cf40eff85fde65db9b5e787471c89)


> SSL/TLS protocol and cipher suite configuration is ignored
> --
>
> Key: GEODE-8419
> URL: https://issues.apache.org/jira/browse/GEODE-8419
> Project: Geode
>  Issue Type: Bug
>  Components: client/server, membership, security
>Affects Versions: 1.10.0, 1.11.0, 1.12.0, 1.13.0, 1.14.0
>Reporter: Jacob Barrett
>Assignee: Bruce J Schuchardt
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> Configuring {{ssl-protocols}} or {{ssl-ciphers}} properties, or per-component 
> ssl properties, have no effect. Configuring {{ssl-protocols}} may effect the 
> {{SSLContext}} selected and limit some of the protocols allowed but does not 
> restrict to just the set specified in the property. The {{ssl-ciphers}} 
> property does not limit cipher selection at all.
> The result is that all ciphers allowed under the match {{SSLContext}} are 
> allowed and negotiated. This can result in an unintended cipher being used in 
> SSL/TLS communication. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8419) SSL/TLS protocol and cipher suite configuration is ignored

2020-10-05 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208399#comment-17208399
 ] 

ASF subversion and git services commented on GEODE-8419:


Commit 1ab6c115cb43c58773efcca2ac6f36246c9f3faf in geode's branch 
refs/heads/feature/GEODE-8419-backport-1-13 from Bruce Schuchardt
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=1ab6c11 ]

GEODE-8419: SSL/TLS protocol and cipher suite configuration is ignored (#5465)

* GEODE-8419: SSL/TLS protocol and cipher suite configuration is ignored

Configure cipher suites when creating an SSLEngine

(cherry picked from commit 537721ff815cf40eff85fde65db9b5e787471c89)


> SSL/TLS protocol and cipher suite configuration is ignored
> --
>
> Key: GEODE-8419
> URL: https://issues.apache.org/jira/browse/GEODE-8419
> Project: Geode
>  Issue Type: Bug
>  Components: client/server, membership, security
>Affects Versions: 1.10.0, 1.11.0, 1.12.0, 1.13.0, 1.14.0
>Reporter: Jacob Barrett
>Assignee: Bruce J Schuchardt
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> Configuring {{ssl-protocols}} or {{ssl-ciphers}} properties, or per-component 
> ssl properties, have no effect. Configuring {{ssl-protocols}} may effect the 
> {{SSLContext}} selected and limit some of the protocols allowed but does not 
> restrict to just the set specified in the property. The {{ssl-ciphers}} 
> property does not limit cipher selection at all.
> The result is that all ciphers allowed under the match {{SSLContext}} are 
> allowed and negotiated. This can result in an unintended cipher being used in 
> SSL/TLS communication. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8419) SSL/TLS protocol and cipher suite configuration is ignored

2020-10-05 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208401#comment-17208401
 ] 

ASF subversion and git services commented on GEODE-8419:


Commit 1ab6c115cb43c58773efcca2ac6f36246c9f3faf in geode's branch 
refs/heads/feature/GEODE-8419-backport-1-13 from Bruce Schuchardt
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=1ab6c11 ]

GEODE-8419: SSL/TLS protocol and cipher suite configuration is ignored (#5465)

* GEODE-8419: SSL/TLS protocol and cipher suite configuration is ignored

Configure cipher suites when creating an SSLEngine

(cherry picked from commit 537721ff815cf40eff85fde65db9b5e787471c89)


> SSL/TLS protocol and cipher suite configuration is ignored
> --
>
> Key: GEODE-8419
> URL: https://issues.apache.org/jira/browse/GEODE-8419
> Project: Geode
>  Issue Type: Bug
>  Components: client/server, membership, security
>Affects Versions: 1.10.0, 1.11.0, 1.12.0, 1.13.0, 1.14.0
>Reporter: Jacob Barrett
>Assignee: Bruce J Schuchardt
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> Configuring {{ssl-protocols}} or {{ssl-ciphers}} properties, or per-component 
> ssl properties, have no effect. Configuring {{ssl-protocols}} may effect the 
> {{SSLContext}} selected and limit some of the protocols allowed but does not 
> restrict to just the set specified in the property. The {{ssl-ciphers}} 
> property does not limit cipher selection at all.
> The result is that all ciphers allowed under the match {{SSLContext}} are 
> allowed and negotiated. This can result in an unintended cipher being used in 
> SSL/TLS communication. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8419) SSL/TLS protocol and cipher suite configuration is ignored

2020-10-05 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8419?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208402#comment-17208402
 ] 

ASF subversion and git services commented on GEODE-8419:


Commit 1ab6c115cb43c58773efcca2ac6f36246c9f3faf in geode's branch 
refs/heads/feature/GEODE-8419-backport-1-13 from Bruce Schuchardt
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=1ab6c11 ]

GEODE-8419: SSL/TLS protocol and cipher suite configuration is ignored (#5465)

* GEODE-8419: SSL/TLS protocol and cipher suite configuration is ignored

Configure cipher suites when creating an SSLEngine

(cherry picked from commit 537721ff815cf40eff85fde65db9b5e787471c89)


> SSL/TLS protocol and cipher suite configuration is ignored
> --
>
> Key: GEODE-8419
> URL: https://issues.apache.org/jira/browse/GEODE-8419
> Project: Geode
>  Issue Type: Bug
>  Components: client/server, membership, security
>Affects Versions: 1.10.0, 1.11.0, 1.12.0, 1.13.0, 1.14.0
>Reporter: Jacob Barrett
>Assignee: Bruce J Schuchardt
>Priority: Major
>  Labels: pull-request-available
> Fix For: 1.14.0
>
>
> Configuring {{ssl-protocols}} or {{ssl-ciphers}} properties, or per-component 
> ssl properties, have no effect. Configuring {{ssl-protocols}} may effect the 
> {{SSLContext}} selected and limit some of the protocols allowed but does not 
> restrict to just the set specified in the property. The {{ssl-ciphers}} 
> property does not limit cipher selection at all.
> The result is that all ciphers allowed under the match {{SSLContext}} are 
> allowed and negotiated. This can result in an unintended cipher being used in 
> SSL/TLS communication. 



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8577) PubSubNativeRedisAcceptanceTest is flaky

2020-10-05 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208451#comment-17208451
 ] 

ASF GitHub Bot commented on GEODE-8577:
---

jdeppe-pivotal merged pull request #5593:
URL: https://github.com/apache/geode/pull/5593


   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> PubSubNativeRedisAcceptanceTest is flaky
> 
>
> Key: GEODE-8577
> URL: https://issues.apache.org/jira/browse/GEODE-8577
> Project: Geode
>  Issue Type: Test
>  Components: redis
>Reporter: Jens Deppe
>Priority: Major
>  Labels: pull-request-available
>
> Going to disable this one test and work on fixing that.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8577) PubSubNativeRedisAcceptanceTest is flaky

2020-10-05 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208449#comment-17208449
 ] 

ASF GitHub Bot commented on GEODE-8577:
---

jdeppe-pivotal commented on a change in pull request #5593:
URL: https://github.com/apache/geode/pull/5593#discussion_r499962902



##
File path: 
geode-redis/src/acceptanceTest/java/org/apache/geode/redis/internal/executor/pubsub/PubSubNativeRedisAcceptanceTest.java
##
@@ -16,9 +16,11 @@
 package org.apache.geode.redis.internal.executor.pubsub;
 
 import org.junit.ClassRule;
+import org.junit.Ignore;
 
 import org.apache.geode.NativeRedisTestRule;
 
+@Ignore

Review comment:
   Done.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> PubSubNativeRedisAcceptanceTest is flaky
> 
>
> Key: GEODE-8577
> URL: https://issues.apache.org/jira/browse/GEODE-8577
> Project: Geode
>  Issue Type: Test
>  Components: redis
>Reporter: Jens Deppe
>Priority: Major
>  Labels: pull-request-available
>
> Going to disable this one test and work on fixing that.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8577) PubSubNativeRedisAcceptanceTest is flaky

2020-10-05 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208450#comment-17208450
 ] 

ASF GitHub Bot commented on GEODE-8577:
---

jdeppe-pivotal commented on pull request #5593:
URL: https://github.com/apache/geode/pull/5593#issuecomment-703981470


   Failing test is unrelated to this PR.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> PubSubNativeRedisAcceptanceTest is flaky
> 
>
> Key: GEODE-8577
> URL: https://issues.apache.org/jira/browse/GEODE-8577
> Project: Geode
>  Issue Type: Test
>  Components: redis
>Reporter: Jens Deppe
>Priority: Major
>  Labels: pull-request-available
>
> Going to disable this one test and work on fixing that.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8577) PubSubNativeRedisAcceptanceTest is flaky

2020-10-05 Thread ASF subversion and git services (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208452#comment-17208452
 ] 

ASF subversion and git services commented on GEODE-8577:


Commit b8147bb7fdc339af36f3bcb465e7b34ae450a744 in geode's branch 
refs/heads/develop from Jens Deppe
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=b8147bb ]

GEODE-8577: PubSubNativeRedisAcceptanceTest is flaky (#5593)



> PubSubNativeRedisAcceptanceTest is flaky
> 
>
> Key: GEODE-8577
> URL: https://issues.apache.org/jira/browse/GEODE-8577
> Project: Geode
>  Issue Type: Test
>  Components: redis
>Reporter: Jens Deppe
>Priority: Major
>  Labels: pull-request-available
>
> Going to disable this one test and work on fixing that.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)


[jira] [Commented] (GEODE-8577) PubSubNativeRedisAcceptanceTest is flaky

2020-10-05 Thread ASF GitHub Bot (Jira)


[ 
https://issues.apache.org/jira/browse/GEODE-8577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208461#comment-17208461
 ] 

ASF GitHub Bot commented on GEODE-8577:
---

jdeppe-pivotal opened a new pull request #5597:
URL: https://github.com/apache/geode/pull/5597


   - Apparently we need more time between retrying for a new connection on
 docker.
   
   Authored-by: Jens Deppe 
   
   Thank you for submitting a contribution to Apache Geode.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in 
the commit message?
   
   - [ ] Has your PR been rebased against the latest commit within the target 
branch (typically `develop`)?
   
   - [ ] Is your initial contribution a single, squashed commit?
   
   - [ ] Does `gradlew build` run cleanly?
   
   - [ ] Have you written or updated unit tests to verify your changes?
   
   - [ ] If adding new dependencies to the code, are these dependencies 
licensed in a way that is compatible for inclusion under [ASF 
2.0](http://www.apache.org/legal/resolved.html#category-a)?
   
   ### Note:
   Please ensure that once the PR is submitted, check Concourse for build 
issues and
   submit an update to your PR as soon as possible. If you need help, please 
send an
   email to d...@geode.apache.org.
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> PubSubNativeRedisAcceptanceTest is flaky
> 
>
> Key: GEODE-8577
> URL: https://issues.apache.org/jira/browse/GEODE-8577
> Project: Geode
>  Issue Type: Test
>  Components: redis
>Reporter: Jens Deppe
>Priority: Major
>  Labels: pull-request-available
>
> Going to disable this one test and work on fixing that.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)