[jira] [Commented] (GEODE-8480) Add tx manager check in geode-native transaction example

Mon, 05 Oct 2020 15:13:16 -0700 


    [ 
https://issues.apache.org/jira/browse/GEODE-8480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17208368#comment-17208368
 ] 

ASF GitHub Bot commented on GEODE-8480:
---------------------------------------

codecov-commenter commented on pull request #648:
URL: https://github.com/apache/geode-native/pull/648#issuecomment-703916868


   # [Codecov](https://codecov.io/gh/apache/geode-native/pull/648?src=pr&el=h1) 
Report
   > Merging 
[#648](https://codecov.io/gh/apache/geode-native/pull/648?src=pr&el=desc) into 
[develop](https://codecov.io/gh/apache/geode-native/commit/4617f22a1fa91464e8f9a38b08eeff206c1677d4?el=desc)
 will **increase** coverage by `0.26%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree 
graph](https://codecov.io/gh/apache/geode-native/pull/648/graphs/tree.svg?width=650&height=150&src=pr&token=plpAqoqGag)](https://codecov.io/gh/apache/geode-native/pull/648?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff             @@
   ##           develop     #648      +/-   ##
   ===========================================
   + Coverage    73.95%   74.21%   +0.26%     
   ===========================================
     Files          644      644              
     Lines        51132    51132              
   ===========================================
   + Hits         37813    37948     +135     
   + Misses       13319    13184     -135     
   ```
   
   
   | [Impacted 
Files](https://codecov.io/gh/apache/geode-native/pull/648?src=pr&el=tree) | 
Coverage Δ | |
   |---|---|---|
   | 
[cppcache/src/ThinClientStickyManager.cpp](https://codecov.io/gh/apache/geode-native/pull/648/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRTdGlja3lNYW5hZ2VyLmNwcA==)
 | `77.88% <0.00%> (-10.58%)` | :arrow_down: |
   | 
[...test/testThinClientPoolExecuteHAFunctionPrSHOP.cpp](https://codecov.io/gh/apache/geode-native/pull/648/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvaW50ZWdyYXRpb24tdGVzdC90ZXN0VGhpbkNsaWVudFBvb2xFeGVjdXRlSEFGdW5jdGlvblByU0hPUC5jcHA=)
 | `91.20% <0.00%> (-3.71%)` | :arrow_down: |
   | 
[cppcache/src/ClientMetadataService.cpp](https://codecov.io/gh/apache/geode-native/pull/648/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL0NsaWVudE1ldGFkYXRhU2VydmljZS5jcHA=)
 | `64.98% <0.00%> (-0.92%)` | :arrow_down: |
   | 
[cppcache/src/ClientMetadata.cpp](https://codecov.io/gh/apache/geode-native/pull/648/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL0NsaWVudE1ldGFkYXRhLmNwcA==)
 | `65.16% <0.00%> (-0.57%)` | :arrow_down: |
   | 
[cppcache/src/ThinClientLocatorHelper.cpp](https://codecov.io/gh/apache/geode-native/pull/648/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRMb2NhdG9ySGVscGVyLmNwcA==)
 | `85.71% <0.00%> (-0.40%)` | :arrow_down: |
   | 
[cppcache/src/ExecutionImpl.cpp](https://codecov.io/gh/apache/geode-native/pull/648/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL0V4ZWN1dGlvbkltcGwuY3Bw)
 | `67.69% <0.00%> (-0.39%)` | :arrow_down: |
   | 
[cppcache/src/TcrConnection.cpp](https://codecov.io/gh/apache/geode-native/pull/648/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RjckNvbm5lY3Rpb24uY3Bw)
 | `72.48% <0.00%> (-0.32%)` | :arrow_down: |
   | 
[cppcache/src/ThinClientRedundancyManager.cpp](https://codecov.io/gh/apache/geode-native/pull/648/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRSZWR1bmRhbmN5TWFuYWdlci5jcHA=)
 | `75.62% <0.00%> (-0.32%)` | :arrow_down: |
   | 
[cppcache/src/TcrMessage.cpp](https://codecov.io/gh/apache/geode-native/pull/648/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1Rjck1lc3NhZ2UuY3Bw)
 | `85.62% <0.00%> (+0.31%)` | :arrow_up: |
   | 
[cppcache/src/ThinClientPoolDM.cpp](https://codecov.io/gh/apache/geode-native/pull/648/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRQb29sRE0uY3Bw)
 | `75.48% <0.00%> (+0.35%)` | :arrow_up: |
   | ... and [15 
more](https://codecov.io/gh/apache/geode-native/pull/648/diff?src=pr&el=tree-more)
 | |
   
   ------
   
   [Continue to review full report at 
Codecov](https://codecov.io/gh/apache/geode-native/pull/648?src=pr&el=continue).
   > **Legend** - [Click here to learn 
more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by 
[Codecov](https://codecov.io/gh/apache/geode-native/pull/648?src=pr&el=footer). 
Last update 
[4617f22...b824345](https://codecov.io/gh/apache/geode-native/pull/648?src=pr&el=lastupdated).
 Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


> Add tx manager check in geode-native transaction example
> --------------------------------------------------------
>
>                 Key: GEODE-8480
>                 URL: https://issues.apache.org/jira/browse/GEODE-8480
>             Project: Geode
>          Issue Type: Improvement
>          Components: docs, native client
>            Reporter: Alberto Bustamante Reyes
>            Assignee: Alberto Bustamante Reyes
>            Priority: Minor
>              Labels: pull-request-available
>
> Transactions documentation & example in the geode C++ client is not checking 
> if the transaction manager exists before calling to rollback, as it is done 
> in the transactions documentation and example in geode.
> I have seen that depending on the exception, the rollback can generate an 
> error so I think its something that should be added to the example.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to