[jira] [Commented] (GEODE-7670) Partitioned Region clear operations can occur during concurrent data operations
[
https://issues.apache.org/jira/browse/GEODE-7670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17158051#comment-17158051
]
ASF GitHub Bot commented on GEODE-7670:
---
jujoramos commented on a change in pull request #4848:
URL: https://github.com/apache/geode/pull/4848#discussion_r454950056
##
File path:
geode-core/src/distributedTest/java/org/apache/geode/internal/cache/PartitionedRegionClearWithConcurrentOperationsDUnitTest.java
##
@@ -0,0 +1,715 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express
+ * or implied. See the License for the specific language governing permissions
and limitations under
+ * the License.
+ */
+package org.apache.geode.internal.cache;
+
+import static org.apache.geode.internal.util.ArrayUtils.asList;
+import static org.apache.geode.test.awaitility.GeodeAwaitility.await;
+import static org.apache.geode.test.dunit.VM.getVM;
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
+
+import java.io.Serializable;
+import java.time.Instant;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.stream.IntStream;
+
+import junitparams.JUnitParamsRunner;
+import junitparams.Parameters;
+import junitparams.naming.TestCaseName;
+import org.junit.Before;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+
+import org.apache.geode.ForcedDisconnectException;
+import org.apache.geode.cache.Cache;
+import org.apache.geode.cache.CacheWriter;
+import org.apache.geode.cache.CacheWriterException;
+import org.apache.geode.cache.PartitionAttributes;
+import org.apache.geode.cache.PartitionAttributesFactory;
+import org.apache.geode.cache.PartitionedRegionPartialClearException;
+import org.apache.geode.cache.Region;
+import org.apache.geode.cache.RegionEvent;
+import org.apache.geode.cache.RegionShortcut;
+import org.apache.geode.cache.partition.PartitionRegionHelper;
+import org.apache.geode.cache.util.CacheWriterAdapter;
+import org.apache.geode.distributed.DistributedSystemDisconnectedException;
+import org.apache.geode.distributed.internal.DMStats;
+import org.apache.geode.distributed.internal.InternalDistributedSystem;
+import
org.apache.geode.distributed.internal.membership.api.MembershipManagerHelper;
+import org.apache.geode.internal.cache.versions.RegionVersionHolder;
+import org.apache.geode.internal.cache.versions.RegionVersionVector;
+import org.apache.geode.internal.cache.versions.VersionSource;
+import org.apache.geode.test.dunit.AsyncInvocation;
+import org.apache.geode.test.dunit.VM;
+import org.apache.geode.test.dunit.rules.CacheRule;
+import org.apache.geode.test.dunit.rules.DistributedRule;
+
+/**
+ * Tests to verify that {@link PartitionedRegion#clear()} operation can be
executed multiple times
+ * on the same region while other cache operations are being executed
concurrently and members are
+ * added or removed.
+ */
+@RunWith(JUnitParamsRunner.class)
+public class PartitionedRegionClearWithConcurrentOperationsDUnitTest
implements Serializable {
+ private static final Integer BUCKETS = 13;
+ private static final String REGION_NAME = "PartitionedRegion";
+ private static final String TEST_CASE_NAME =
+ "[{index}] {method}(Coordinator:{0}, RegionType:{1})";
+
+ @Rule
+ public DistributedRule distributedRule = new DistributedRule(3);
+
+ @Rule
+ public CacheRule cacheRule = CacheRule.builder().createCacheInAll().build();
+
+ private VM accessor, server1, server2;
+
+ private enum TestVM {
+ACCESSOR(0), SERVER1(1), SERVER2(2);
+
+final int vmNumber;
+
+TestVM(int vmNumber) {
+ this.vmNumber = vmNumber;
+}
+ }
+
+ @SuppressWarnings("unused")
+ static RegionShortcut[] regionTypes() {
+return new RegionShortcut[] {
+RegionShortcut.PARTITION, RegionShortcut.PARTITION_REDUNDANT
+};
+ }
+
+ @SuppressWarnings("unused")
+ static TestVM[] coordinators() {
+return new TestVM[] {
+TestVM.SERVER1, TestVM.ACCESSOR
+};
+ }
+
+ @SuppressWarnings("unused")
+ static Object[] coordinatorsAndRegionTypes() {
+ArrayList parameters = new Arr
[jira] [Commented] (GEODE-7670) Partitioned Region clear operations can occur during concurrent data operations
[
https://issues.apache.org/jira/browse/GEODE-7670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17158054#comment-17158054
]
ASF GitHub Bot commented on GEODE-7670:
---
jujoramos commented on a change in pull request #4848:
URL: https://github.com/apache/geode/pull/4848#discussion_r454950056
##
File path:
geode-core/src/distributedTest/java/org/apache/geode/internal/cache/PartitionedRegionClearWithConcurrentOperationsDUnitTest.java
##
@@ -0,0 +1,715 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
contributor license
+ * agreements. See the NOTICE file distributed with this work for additional
information regarding
+ * copyright ownership. The ASF licenses this file to You under the Apache
License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance with the
License. You may obtain a
+ * copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
distributed under the License
+ * is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express
+ * or implied. See the License for the specific language governing permissions
and limitations under
+ * the License.
+ */
+package org.apache.geode.internal.cache;
+
+import static org.apache.geode.internal.util.ArrayUtils.asList;
+import static org.apache.geode.test.awaitility.GeodeAwaitility.await;
+import static org.apache.geode.test.dunit.VM.getVM;
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
+
+import java.io.Serializable;
+import java.time.Instant;
+import java.util.ArrayList;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.Optional;
+import java.util.stream.IntStream;
+
+import junitparams.JUnitParamsRunner;
+import junitparams.Parameters;
+import junitparams.naming.TestCaseName;
+import org.junit.Before;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+
+import org.apache.geode.ForcedDisconnectException;
+import org.apache.geode.cache.Cache;
+import org.apache.geode.cache.CacheWriter;
+import org.apache.geode.cache.CacheWriterException;
+import org.apache.geode.cache.PartitionAttributes;
+import org.apache.geode.cache.PartitionAttributesFactory;
+import org.apache.geode.cache.PartitionedRegionPartialClearException;
+import org.apache.geode.cache.Region;
+import org.apache.geode.cache.RegionEvent;
+import org.apache.geode.cache.RegionShortcut;
+import org.apache.geode.cache.partition.PartitionRegionHelper;
+import org.apache.geode.cache.util.CacheWriterAdapter;
+import org.apache.geode.distributed.DistributedSystemDisconnectedException;
+import org.apache.geode.distributed.internal.DMStats;
+import org.apache.geode.distributed.internal.InternalDistributedSystem;
+import
org.apache.geode.distributed.internal.membership.api.MembershipManagerHelper;
+import org.apache.geode.internal.cache.versions.RegionVersionHolder;
+import org.apache.geode.internal.cache.versions.RegionVersionVector;
+import org.apache.geode.internal.cache.versions.VersionSource;
+import org.apache.geode.test.dunit.AsyncInvocation;
+import org.apache.geode.test.dunit.VM;
+import org.apache.geode.test.dunit.rules.CacheRule;
+import org.apache.geode.test.dunit.rules.DistributedRule;
+
+/**
+ * Tests to verify that {@link PartitionedRegion#clear()} operation can be
executed multiple times
+ * on the same region while other cache operations are being executed
concurrently and members are
+ * added or removed.
+ */
+@RunWith(JUnitParamsRunner.class)
+public class PartitionedRegionClearWithConcurrentOperationsDUnitTest
implements Serializable {
+ private static final Integer BUCKETS = 13;
+ private static final String REGION_NAME = "PartitionedRegion";
+ private static final String TEST_CASE_NAME =
+ "[{index}] {method}(Coordinator:{0}, RegionType:{1})";
+
+ @Rule
+ public DistributedRule distributedRule = new DistributedRule(3);
+
+ @Rule
+ public CacheRule cacheRule = CacheRule.builder().createCacheInAll().build();
+
+ private VM accessor, server1, server2;
+
+ private enum TestVM {
+ACCESSOR(0), SERVER1(1), SERVER2(2);
+
+final int vmNumber;
+
+TestVM(int vmNumber) {
+ this.vmNumber = vmNumber;
+}
+ }
+
+ @SuppressWarnings("unused")
+ static RegionShortcut[] regionTypes() {
+return new RegionShortcut[] {
+RegionShortcut.PARTITION, RegionShortcut.PARTITION_REDUNDANT
+};
+ }
+
+ @SuppressWarnings("unused")
+ static TestVM[] coordinators() {
+return new TestVM[] {
+TestVM.SERVER1, TestVM.ACCESSOR
+};
+ }
+
+ @SuppressWarnings("unused")
+ static Object[] coordinatorsAndRegionTypes() {
+ArrayList parameters = new Arr
[jira] [Reopened] (GEODE-8292) CQs do not send back the right CREATE event but a UPDATE event once entry updated
[ https://issues.apache.org/jira/browse/GEODE-8292?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mario Ivanac reopened GEODE-8292: - Assignee: Mario Ivanac (was: Mario Kevo) > CQs do not send back the right CREATE event but a UPDATE event once entry > updated > - > > Key: GEODE-8292 > URL: https://issues.apache.org/jira/browse/GEODE-8292 > Project: Geode > Issue Type: Bug > Components: cq >Reporter: Mario Kevo >Assignee: Mario Ivanac >Priority: Major > Fix For: 1.14.0 > > > When CQs are installed at Geode server, they dynamically analyzes incoming > updates/creates or deletion entries in the region. > If we have CQ something like "select * from /region i where i=1" and put some > values with i=0, and after that we change it to 1 and again to 0 several > times we got on listener some CREATE and some UPDATE when it fulfilling cq > condition. > The issue can be easily reproduced by geode-examples by modifying > geode-examples/cq/src/main/java/org/apache/geode_examples/cq/Example.java to > put some entries with transactions and then update it. > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8344) Deserialization error in multisite conf using CQs and C++ client
[ https://issues.apache.org/jira/browse/GEODE-8344?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17158084#comment-17158084 ] ASF GitHub Bot commented on GEODE-8344: --- alb3rtobr opened a new pull request #628: URL: https://github.com/apache/geode-native/pull/628 It was observed that when having two sites, with a client connected to each site, there were serialization errors in the clients when handling received events. The cause is that GatewaySenderEventCallbackArgument objects are sent as part of the events, but this class is not known by the C++ client. This PR allows the C++ clients to deserialize the class. Using the same setup with using two java clients, I have observed that the GatewaySenderEventCallbackArgument objects are received and deserialized correctly, but it seems they are not used. This is why this PR is not including any other code related with the GatewaySenderEventCallbackArgument in the C++ clients. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Deserialization error in multisite conf using CQs and C++ client > > > Key: GEODE-8344 > URL: https://issues.apache.org/jira/browse/GEODE-8344 > Project: Geode > Issue Type: Bug > Components: native client >Reporter: Alberto Bustamante Reyes >Assignee: Alberto Bustamante Reyes >Priority: Major > > Im creating this ticket after this conversation in the dev list, so there is > more information here: http://markmail.org/thread/u65gmb7zoxlpcqss > h3. Setup: > - Two sites > - CQs configured > - Using C++ client > h3. Problem: > It is observed that while CQ events from local site (the one that the client > is connected to) are received, the one originated in remote servers are > missing. > After debugging it was observed there is an error in the logs, trying to > deserialize fixedID = -135. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8361) Incorrect Bucket Count Warning Message Shown
[
https://issues.apache.org/jira/browse/GEODE-8361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Juan Ramos updated GEODE-8361:
--
Priority: Trivial (was: Major)
> Incorrect Bucket Count Warning Message Shown
>
>
> Key: GEODE-8361
> URL: https://issues.apache.org/jira/browse/GEODE-8361
> Project: Geode
> Issue Type: Sub-task
> Components: logging
>Reporter: Juan Ramos
>Priority: Trivial
>
> While analysing some failures related to GEODE-7670, I've noticed that
> sometimes we report an incorrect bucket count within the warning message
> logged when the clear didn't complete successfully that could confuse our
> users.
> For this test the partition region always has 13 buckets so, as I user, I
> would never expect to see a bucket count higher than 13 in my logs (no matter
> how many redundant copies I have).
> ---
> Below are some examples:
> {noformat}
> [vm1] [warn 2020/07/15 11:56:17.739 GMT Connection(5)-172.17.0.5> tid=0x5f] Unable to clear all the buckets from
> the partitioned region PartitionedRegion, either data (buckets) moved or
> member departed. expected to clear number of buckets: 13 actual cleared: 26
> [vm1] [warn 2020/07/15 11:57:48.403 GMT Connection(6)-172.17.0.9> tid=0x10f] Unable to clear all the buckets from
> the partitioned region PartitionedRegion, either data (buckets) moved or
> member departed. expected to clear number of buckets: 13 actual cleared: 14
> [vm0] [warn 2020/07/15 12:07:36.227 GMT Connection(32)-172.17.0.25> tid=0x1fe] Unable to clear all the buckets
> from the partitioned region PartitionedRegion, either data (buckets) moved or
> member departed. expected to clear number of buckets: 13 actual cleared: 19
> [vm0] [warn 2020/07/15 12:08:56.277 GMT Connection(37)-172.17.0.24> tid=0x2a2] Unable to clear all the buckets
> from the partitioned region PartitionedRegion, either data (buckets) moved or
> member departed. expected to clear number of buckets: 13 actual cleared: 16
> {noformat}
> The full set of artefacts and results:
> {noformat}
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> http://files.apachegeode-ci.info/builds/apache-develop-pr/geode-pr-4848/test-results/repeatTest/1594816968/
> =-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
> Test report artifacts from this job are available at:
> http://files.apachegeode-ci.info/builds/apache-develop-pr/geode-pr-4848/test-artifacts/1594816968/stressnewtestfiles-geode-pr-4848.tgz
> {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Created] (GEODE-8361) Incorrect Bucket Count Warning Message Shown
Juan Ramos created GEODE-8361:
-
Summary: Incorrect Bucket Count Warning Message Shown
Key: GEODE-8361
URL: https://issues.apache.org/jira/browse/GEODE-8361
Project: Geode
Issue Type: Sub-task
Components: logging
Reporter: Juan Ramos
While analysing some failures related to GEODE-7670, I've noticed that
sometimes we report an incorrect bucket count within the warning message logged
when the clear didn't complete successfully that could confuse our users.
For this test the partition region always has 13 buckets so, as I user, I would
never expect to see a bucket count higher than 13 in my logs (no matter how
many redundant copies I have).
---
Below are some examples:
{noformat}
[vm1] [warn 2020/07/15 11:56:17.739 GMT tid=0x5f] Unable to clear all the buckets from the
partitioned region PartitionedRegion, either data (buckets) moved or member
departed. expected to clear number of buckets: 13 actual cleared: 26
[vm1] [warn 2020/07/15 11:57:48.403 GMT tid=0x10f] Unable to clear all the buckets from
the partitioned region PartitionedRegion, either data (buckets) moved or member
departed. expected to clear number of buckets: 13 actual cleared: 14
[vm0] [warn 2020/07/15 12:07:36.227 GMT tid=0x1fe] Unable to clear all the buckets from
the partitioned region PartitionedRegion, either data (buckets) moved or member
departed. expected to clear number of buckets: 13 actual cleared: 19
[vm0] [warn 2020/07/15 12:08:56.277 GMT tid=0x2a2] Unable to clear all the buckets from
the partitioned region PartitionedRegion, either data (buckets) moved or member
departed. expected to clear number of buckets: 13 actual cleared: 16
{noformat}
The full set of artefacts and results:
{noformat}
=-=-=-=-=-=-=-=-=-=-=-=-=-=-= Test Results URI
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
http://files.apachegeode-ci.info/builds/apache-develop-pr/geode-pr-4848/test-results/repeatTest/1594816968/
=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=
Test report artifacts from this job are available at:
http://files.apachegeode-ci.info/builds/apache-develop-pr/geode-pr-4848/test-artifacts/1594816968/stressnewtestfiles-geode-pr-4848.tgz
{noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Assigned] (GEODE-8362) Add redis tests to ensure that commands can access binary data
[ https://issues.apache.org/jira/browse/GEODE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jens Deppe reassigned GEODE-8362: - Assignee: Jens Deppe > Add redis tests to ensure that commands can access binary data > -- > > Key: GEODE-8362 > URL: https://issues.apache.org/jira/browse/GEODE-8362 > Project: Geode > Issue Type: Test > Components: redis >Reporter: Jens Deppe >Assignee: Jens Deppe >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (GEODE-8362) Add redis tests to ensure that commands can access binary data
Jens Deppe created GEODE-8362: - Summary: Add redis tests to ensure that commands can access binary data Key: GEODE-8362 URL: https://issues.apache.org/jira/browse/GEODE-8362 Project: Geode Issue Type: Test Components: redis Reporter: Jens Deppe -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8298) member version comparison sense inconsistent when deciding on multicast
[
https://issues.apache.org/jira/browse/GEODE-8298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17158487#comment-17158487
]
ASF GitHub Bot commented on GEODE-8298:
---
Bill commented on a change in pull request #5370:
URL: https://github.com/apache/geode/pull/5370#discussion_r455147203
##
File path:
geode-membership/src/integrationTest/java/org/apache/geode/distributed/internal/membership/gms/GMSMembershipJUnitTest.java
##
@@ -328,4 +332,63 @@ public void noDispatchWhenSick() throws
MemberShunnedException, MemberStartupExc
assertThat(spy.getStartupEvents()).isEmpty();
}
+ @Test
+ public void testIsMulticastAllowedWithOldVersionSurpriseMember() {
+MembershipView view =
createMembershipView(Version.CURRENT);
+
manager.addSurpriseMember(createSurpriseMember(OLDER_THAN_CURRENT_VERSION));
+
+manager.processView(view);
+
+assertThat(manager.getGMSManager().isMulticastAllowed()).isFalse();
+ }
+
+ @Test
+ public void testIsMulticastAllowedWithCurrentVersionSurpriseMember() {
+MembershipView view =
createMembershipView(Version.CURRENT);
+manager.addSurpriseMember(createSurpriseMember(Version.CURRENT));
+
+manager.processView(view);
+
+assertThat(manager.getGMSManager().isMulticastAllowed()).isTrue();
+ }
+
+ @Test
+ public void testIsMulticastAllowedWithOldVersionViewMember() {
+MembershipView view =
createMembershipView(OLDER_THAN_CURRENT_VERSION);
+
+manager.processView(view);
+
+assertThat(manager.getGMSManager().isMulticastAllowed()).isFalse();
+ }
+
+ @Test
+ public void testMulticastAllowedWithCurrentVersionViewMember() {
+MembershipView view =
createMembershipView(Version.CURRENT);
+
+manager.processView(view);
+
+assertThat(manager.getGMSManager().isMulticastAllowed()).isTrue();
+ }
+
+ private MemberIdentifier createSurpriseMember(Version version) {
+MemberIdentifier surpriseMember = createMemberID(DEFAULT_PORT + 5);
+surpriseMember.setVmViewId(3);
+surpriseMember.setVersionObjectForTest(version);
+return surpriseMember;
+ }
+
+ private MembershipView createMembershipView(Version
version) {
+List viewMembers = createMemberIdentifiers(version);
+return new MembershipView<>(myMemberId, 2, viewMembers);
+ }
+
+ private List createMemberIdentifiers(Version
memberVersion) {
+List viewMembers = new ArrayList<>();
+for (int i = 0; i < 2; ++i) {
+ MemberIdentifier memberIdentifier = createMemberID(DEFAULT_PORT + 6 + i);
+ memberIdentifier.setVersionObjectForTest(memberVersion);
Review comment:
A small point: this routine will set _every_ member's version to
`memberVersion`. I think it would be a better test if only _one_ member's
version was set to `memberVersion` and the rest were set to `Version.CURRENT`.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> member version comparison sense inconsistent when deciding on multicast
> ---
>
> Key: GEODE-8298
> URL: https://issues.apache.org/jira/browse/GEODE-8298
> Project: Geode
> Issue Type: Bug
> Components: membership
>Reporter: Bill Burcham
>Assignee: Kamilla Aslami
>Priority: Major
> Labels: starter
>
> Since about 2014 when we introduced the {{Version}} class to replace use of
> {{short}} s all over the place for serialization versions, these two loops in
> {{GMSMembership.processView()}} have used comparisons that disagree in sense:
> {code}
> // We perform the update under a global lock so that other
> // incoming events will not be lost in terms of our global view.
> latestViewWriteLock.lock();
> try {
> // first determine the version for multicast message serialization
> VersionOrdinal version = Version.CURRENT;
> for (final Entry internalIDLongEntry : surpriseMembers
> .entrySet()) {
> ID mbr = internalIDLongEntry.getKey();
> final VersionOrdinal itsVersion = mbr.getVersionObject();
> if (itsVersion != null && version.compareTo(itsVersion) < 0) {
> version = itsVersion;
> }
> }
> for (ID mbr : newView.getMembers()) {
> final VersionOrdinal itsVersion = mbr.getVersionObject();
> if (itsVersion != null && itsVersion.compareTo(version) < 0) {
> version = mbr.getVersionObject();
> }
> }
> disableMulticastForRollingUpgrade = !version.equals(Version.CURRENT);
> {code}
> The goal here is to find the oldest version and if that ver
[jira] [Commented] (GEODE-8358) Run Geode Redis session tests against native Redis
[ https://issues.apache.org/jira/browse/GEODE-8358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17158510#comment-17158510 ] ASF GitHub Bot commented on GEODE-8358: --- sabbeyPivotal opened a new pull request #5373: URL: https://github.com/apache/geode/pull/5373 Ensure Spring Session works the same way with native Redis as it does with Redis API for Geode. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Run Geode Redis session tests against native Redis > -- > > Key: GEODE-8358 > URL: https://issues.apache.org/jira/browse/GEODE-8358 > Project: Geode > Issue Type: Test > Components: redis, tests >Reporter: Sarah Abbey >Priority: Major > > Ensure Spring Session works the same way with native Redis as it does with > Redis API for Geode. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8358) Run Geode Redis session tests against native Redis
[ https://issues.apache.org/jira/browse/GEODE-8358?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17158509#comment-17158509 ] ASF GitHub Bot commented on GEODE-8358: --- sabbeyPivotal closed pull request #5369: URL: https://github.com/apache/geode/pull/5369 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Run Geode Redis session tests against native Redis > -- > > Key: GEODE-8358 > URL: https://issues.apache.org/jira/browse/GEODE-8358 > Project: Geode > Issue Type: Test > Components: redis, tests >Reporter: Sarah Abbey >Priority: Major > > Ensure Spring Session works the same way with native Redis as it does with > Redis API for Geode. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8362) Add redis tests to ensure that commands can access binary data
[ https://issues.apache.org/jira/browse/GEODE-8362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17158514#comment-17158514 ] ASF GitHub Bot commented on GEODE-8362: --- jdeppe-pivotal opened a new pull request #5374: URL: https://github.com/apache/geode/pull/5374 Thank you for submitting a contribution to Apache Geode. In order to streamline the review of the contribution we ask you to ensure the following steps have been taken: ### For all changes: - [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message? - [ ] Has your PR been rebased against the latest commit within the target branch (typically `develop`)? - [ ] Is your initial contribution a single, squashed commit? - [ ] Does `gradlew build` run cleanly? - [ ] Have you written or updated unit tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? ### Note: Please ensure that once the PR is submitted, check Concourse for build issues and submit an update to your PR as soon as possible. If you need help, please send an email to d...@geode.apache.org. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > Add redis tests to ensure that commands can access binary data > -- > > Key: GEODE-8362 > URL: https://issues.apache.org/jira/browse/GEODE-8362 > Project: Geode > Issue Type: Test > Components: redis >Reporter: Jens Deppe >Assignee: Jens Deppe >Priority: Major > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8359) Server logs NPE as a warning while processing RegisterInterestList requests from clients during (server) shutdown
[
https://issues.apache.org/jira/browse/GEODE-8359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17158592#comment-17158592
]
ASF GitHub Bot commented on GEODE-8359:
---
agingade commented on a change in pull request #5371:
URL: https://github.com/apache/geode/pull/5371#discussion_r455242606
##
File path:
geode-core/src/main/java/org/apache/geode/internal/cache/tier/sockets/command/RegisterInterestList66.java
##
@@ -163,29 +162,40 @@ public void cmdExecute(final Message clientMessage, final
ServerConnection serve
}
try {
securityService.authorize(Resource.DATA, Operation.READ, regionName);
- AuthorizeRequest authzRequest = serverConnection.getAuthzRequest();
- if (authzRequest != null) {
+ AuthorizeRequest authorizeRequest = serverConnection.getAuthzRequest();
+ if (authorizeRequest != null) {
if (!DynamicRegionFactory.regionIsDynamicRegionList(regionName)) {
RegisterInterestOperationContext registerContext =
- authzRequest.registerInterestListAuthorize(regionName, keys,
policy);
- keys = (List) registerContext.getKey();
+ authorizeRequest.registerInterestListAuthorize(regionName, keys,
policy);
+ keys = (List) registerContext.getKey();
}
}
// Register interest
serverConnection.getAcceptor().getCacheClientNotifier().registerClientInterest(regionName,
keys, serverConnection.getProxyID(), isDurable,
sendUpdatesAsInvalidates, true,
regionDataPolicyPartBytes[0], true);
-} catch (Exception ex) {
+} catch (Exception e) {
// If an interrupted exception is thrown , rethrow it
- checkForInterrupt(serverConnection, ex);
+ checkForInterrupt(serverConnection, e);
// Otherwise, write an exception message and continue
- writeChunkedException(clientMessage, ex, serverConnection);
+ writeChunkedException(clientMessage, e, serverConnection);
serverConnection.setAsTrue(RESPONDED);
return;
}
-boolean isPrimary = serverConnection.getAcceptor().getCacheClientNotifier()
-.getClientProxy(serverConnection.getProxyID()).isPrimary();
+CacheClientProxy ccp =
serverConnection.getAcceptor().getCacheClientNotifier()
+.getClientProxy(serverConnection.getProxyID());
+
+if (ccp == null) {
+ IOException ioException = new IOException(
+ "CacheClientProxy for this client is no longer on the server , so
registerInterest operation is unsuccessful");
Review comment:
We could change the messaging part...
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Server logs NPE as a warning while processing RegisterInterestList requests
> from clients during (server) shutdown
> -
>
> Key: GEODE-8359
> URL: https://issues.apache.org/jira/browse/GEODE-8359
> Project: Geode
> Issue Type: Bug
> Components: client/server
>Reporter: Mark Hanson
>Priority: Major
> Fix For: 1.14.0
>
>
> Getting a null pointer exception when RegisterinterestList is called during
> shutdown.
> {noformat}
> at
> org.apache.geode.internal.cache.tier.sockets.command.RegisterInterestList66.cmdExecute(RegisterInterestList66.java:188)
> at
> org.apache.geode.internal.cache.tier.sockets.BaseCommand.execute(BaseCommand.java:183)
> at
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.doNormalMessage(ServerConnection.java:848)
> at
> org.apache.geode.internal.cache.tier.sockets.OriginalServerConnection.doOneMessage(OriginalServerConnection.java:72)
> at
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1181)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl.lambda$initializeServerConnectionThreadPool$3(AcceptorImpl.java:676)
> at
> org.apache.geode.logging.internal.executors.LoggingThreadFactory.lambda$newThread$0(LoggingThreadFactory.java:119)
> at java.lang.Thread.run(Thread.java:748) {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (GEODE-8359) Server logs NPE as a warning while processing RegisterInterestList requests from clients during (server) shutdown
[
https://issues.apache.org/jira/browse/GEODE-8359?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
ASF GitHub Bot updated GEODE-8359:
--
Labels: pull-request-available (was: )
> Server logs NPE as a warning while processing RegisterInterestList requests
> from clients during (server) shutdown
> -
>
> Key: GEODE-8359
> URL: https://issues.apache.org/jira/browse/GEODE-8359
> Project: Geode
> Issue Type: Bug
> Components: client/server
>Reporter: Mark Hanson
>Priority: Major
> Labels: pull-request-available
> Fix For: 1.14.0
>
>
> Getting a null pointer exception when RegisterinterestList is called during
> shutdown.
> {noformat}
> at
> org.apache.geode.internal.cache.tier.sockets.command.RegisterInterestList66.cmdExecute(RegisterInterestList66.java:188)
> at
> org.apache.geode.internal.cache.tier.sockets.BaseCommand.execute(BaseCommand.java:183)
> at
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.doNormalMessage(ServerConnection.java:848)
> at
> org.apache.geode.internal.cache.tier.sockets.OriginalServerConnection.doOneMessage(OriginalServerConnection.java:72)
> at
> org.apache.geode.internal.cache.tier.sockets.ServerConnection.run(ServerConnection.java:1181)
> at
> java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> at
> java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
> at
> org.apache.geode.internal.cache.tier.sockets.AcceptorImpl.lambda$initializeServerConnectionThreadPool$3(AcceptorImpl.java:676)
> at
> org.apache.geode.logging.internal.executors.LoggingThreadFactory.lambda$newThread$0(LoggingThreadFactory.java:119)
> at java.lang.Thread.run(Thread.java:748) {noformat}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Commented] (GEODE-8348) CI does not build benchmarks image
[
https://issues.apache.org/jira/browse/GEODE-8348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17158741#comment-17158741
]
ASF GitHub Bot commented on GEODE-8348:
---
pivotal-jbarrett commented on a change in pull request #131:
URL: https://github.com/apache/geode-benchmarks/pull/131#discussion_r455391423
##
File path: infrastructure/scripts/aws/launch_cluster.sh
##
@@ -76,6 +86,10 @@ if [ -z "${CI}" ]; then
CI=0
fi
+if [ -z "${PURPOSE}" ]; then
Review comment:
Bashmagic:
`PURPOSE=${PURPOSE:-"geode-benchmarks"}`
##
File path:
infrastructure/src/main/java/org/apache/geode/infrastructure/aws/LaunchCluster.java
##
@@ -397,11 +397,17 @@ private static Image getNewestImage() {
DateTimeFormatter inputFormatter =
DateTimeFormatter.ofPattern("-MM-dd'T'HH:mm:ss.SSS'Z'",
Locale.ENGLISH);
+String purpose = System.getProperty("PURPOSE");
Review comment:
Properties also supports a default value. So you can drop the empty
check and do this.
`String purpose = System.getProperty("PURPOSE", "geode-benchmarks")`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> CI does not build benchmarks image
> --
>
> Key: GEODE-8348
> URL: https://issues.apache.org/jira/browse/GEODE-8348
> Project: Geode
> Issue Type: Bug
> Components: ci
>Reporter: Sean Goller
>Priority: Major
>
> The CI infrastructure relies on the existence of a google compute image in
> order to function. Currently that image is not build anywhere in CI.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
[jira] [Updated] (GEODE-8348) CI does not build benchmarks image
[ https://issues.apache.org/jira/browse/GEODE-8348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-8348: -- Labels: pull-request-available (was: ) > CI does not build benchmarks image > -- > > Key: GEODE-8348 > URL: https://issues.apache.org/jira/browse/GEODE-8348 > Project: Geode > Issue Type: Bug > Components: ci >Reporter: Sean Goller >Priority: Major > Labels: pull-request-available > > The CI infrastructure relies on the existence of a google compute image in > order to function. Currently that image is not build anywhere in CI. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8331) allow GFSH to connect to newer and older locator/server.
[ https://issues.apache.org/jira/browse/GEODE-8331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17158742#comment-17158742 ] ASF GitHub Bot commented on GEODE-8331: --- jinmeiliao opened a new pull request #5375: URL: https://github.com/apache/geode/pull/5375 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > allow GFSH to connect to newer and older locator/server. > > > Key: GEODE-8331 > URL: https://issues.apache.org/jira/browse/GEODE-8331 > Project: Geode > Issue Type: Bug > Components: gfsh >Reporter: Jinmei Liao >Priority: Major > Labels: GeodeOperationAPI > > When using an older or newer gfsh to connect to an older or newer distributed > system gfsh will throw a warning error and not connect. > Example warning message Cannot use a 9.8.5 gfsh client to connect to a 9.9.0 > cluster.. > The desired behavior is to allow gfsh connect and only if there is an issue > with an updated /unknown command parsing should the system throw an error and > provide the extra guidance of what version the servers are at and the version > of the current gfsh cli. > Initially add these capability into the newer product version > Later based on the feasibility of adding this to older version, this will be > ported into the older version. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Updated] (GEODE-8331) allow GFSH to connect to newer and older locator/server.
[ https://issues.apache.org/jira/browse/GEODE-8331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated GEODE-8331: -- Labels: GeodeOperationAPI pull-request-available (was: GeodeOperationAPI) > allow GFSH to connect to newer and older locator/server. > > > Key: GEODE-8331 > URL: https://issues.apache.org/jira/browse/GEODE-8331 > Project: Geode > Issue Type: Bug > Components: gfsh >Reporter: Jinmei Liao >Priority: Major > Labels: GeodeOperationAPI, pull-request-available > > When using an older or newer gfsh to connect to an older or newer distributed > system gfsh will throw a warning error and not connect. > Example warning message Cannot use a 9.8.5 gfsh client to connect to a 9.9.0 > cluster.. > The desired behavior is to allow gfsh connect and only if there is an issue > with an updated /unknown command parsing should the system throw an error and > provide the extra guidance of what version the servers are at and the version > of the current gfsh cli. > Initially add these capability into the newer product version > Later based on the feasibility of adding this to older version, this will be > ported into the older version. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Created] (GEODE-8363) Make docs clear that Micrometer API is experimental
Karen Smoler Miller created GEODE-8363: -- Summary: Make docs clear that Micrometer API is experimental Key: GEODE-8363 URL: https://issues.apache.org/jira/browse/GEODE-8363 Project: Geode Issue Type: Improvement Components: docs Reporter: Karen Smoler Miller The MetricsSession and MetricsPublishingService interfaces are marked as experimental. The docs do not make this clear. There is a note at the end of a subsection to that effect, but it is definitely not prominent. Make the docs clear that the Micrometer API is experimental by putting a note in a more prominent place, such as at the beginning of the section. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (GEODE-8363) Make docs clear that Micrometer API is experimental
[ https://issues.apache.org/jira/browse/GEODE-8363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Karen Smoler Miller reassigned GEODE-8363: -- Assignee: Karen Smoler Miller > Make docs clear that Micrometer API is experimental > --- > > Key: GEODE-8363 > URL: https://issues.apache.org/jira/browse/GEODE-8363 > Project: Geode > Issue Type: Improvement > Components: docs >Reporter: Karen Smoler Miller >Assignee: Karen Smoler Miller >Priority: Major > > The MetricsSession and MetricsPublishingService interfaces are marked as > experimental. The docs do not make this clear. There is a note at the end of > a subsection to that effect, but it is definitely not prominent. > Make the docs clear that the Micrometer API is experimental by putting a note > in a more prominent place, such as at the beginning of the section. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8348) CI does not build benchmarks image
[ https://issues.apache.org/jira/browse/GEODE-8348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17158753#comment-17158753 ] ASF GitHub Bot commented on GEODE-8348: --- smgoller merged pull request #131: URL: https://github.com/apache/geode-benchmarks/pull/131 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > CI does not build benchmarks image > -- > > Key: GEODE-8348 > URL: https://issues.apache.org/jira/browse/GEODE-8348 > Project: Geode > Issue Type: Bug > Components: ci >Reporter: Sean Goller >Priority: Major > Labels: pull-request-available > > The CI infrastructure relies on the existence of a google compute image in > order to function. Currently that image is not build anywhere in CI. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8348) CI does not build benchmarks image
[ https://issues.apache.org/jira/browse/GEODE-8348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17158752#comment-17158752 ] ASF subversion and git services commented on GEODE-8348: Commit 9819b5f39c3f7dbbd25e467a9af9f60db368d949 in geode-benchmarks's branch refs/heads/develop from Sean Goller [ https://gitbox.apache.org/repos/asf?p=geode-benchmarks.git;h=9819b5f ] GEODE-8348: Add support for customizable purpose tag. (#131) * GEODE-8348: Add support for customizable purpose tag. * GEODE-8348: purpose value fixes. > CI does not build benchmarks image > -- > > Key: GEODE-8348 > URL: https://issues.apache.org/jira/browse/GEODE-8348 > Project: Geode > Issue Type: Bug > Components: ci >Reporter: Sean Goller >Priority: Major > Labels: pull-request-available > > The CI infrastructure relies on the existence of a google compute image in > order to function. Currently that image is not build anywhere in CI. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8348) CI does not build benchmarks image
[ https://issues.apache.org/jira/browse/GEODE-8348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17158750#comment-17158750 ] ASF subversion and git services commented on GEODE-8348: Commit 9819b5f39c3f7dbbd25e467a9af9f60db368d949 in geode-benchmarks's branch refs/heads/develop from Sean Goller [ https://gitbox.apache.org/repos/asf?p=geode-benchmarks.git;h=9819b5f ] GEODE-8348: Add support for customizable purpose tag. (#131) * GEODE-8348: Add support for customizable purpose tag. * GEODE-8348: purpose value fixes. > CI does not build benchmarks image > -- > > Key: GEODE-8348 > URL: https://issues.apache.org/jira/browse/GEODE-8348 > Project: Geode > Issue Type: Bug > Components: ci >Reporter: Sean Goller >Priority: Major > Labels: pull-request-available > > The CI infrastructure relies on the existence of a google compute image in > order to function. Currently that image is not build anywhere in CI. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8348) CI does not build benchmarks image
[ https://issues.apache.org/jira/browse/GEODE-8348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17158751#comment-17158751 ] ASF subversion and git services commented on GEODE-8348: Commit 9819b5f39c3f7dbbd25e467a9af9f60db368d949 in geode-benchmarks's branch refs/heads/develop from Sean Goller [ https://gitbox.apache.org/repos/asf?p=geode-benchmarks.git;h=9819b5f ] GEODE-8348: Add support for customizable purpose tag. (#131) * GEODE-8348: Add support for customizable purpose tag. * GEODE-8348: purpose value fixes. > CI does not build benchmarks image > -- > > Key: GEODE-8348 > URL: https://issues.apache.org/jira/browse/GEODE-8348 > Project: Geode > Issue Type: Bug > Components: ci >Reporter: Sean Goller >Priority: Major > Labels: pull-request-available > > The CI infrastructure relies on the existence of a google compute image in > order to function. Currently that image is not build anywhere in CI. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8348) CI does not build benchmarks image
[ https://issues.apache.org/jira/browse/GEODE-8348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17158754#comment-17158754 ] ASF GitHub Bot commented on GEODE-8348: --- smgoller merged pull request #5367: URL: https://github.com/apache/geode/pull/5367 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > CI does not build benchmarks image > -- > > Key: GEODE-8348 > URL: https://issues.apache.org/jira/browse/GEODE-8348 > Project: Geode > Issue Type: Bug > Components: ci >Reporter: Sean Goller >Priority: Major > Labels: pull-request-available > > The CI infrastructure relies on the existence of a google compute image in > order to function. Currently that image is not build anywhere in CI. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Resolved] (GEODE-8348) CI does not build benchmarks image
[ https://issues.apache.org/jira/browse/GEODE-8348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Goller resolved GEODE-8348. Resolution: Fixed > CI does not build benchmarks image > -- > > Key: GEODE-8348 > URL: https://issues.apache.org/jira/browse/GEODE-8348 > Project: Geode > Issue Type: Bug > Components: ci >Reporter: Sean Goller >Assignee: Sean Goller >Priority: Major > Labels: pull-request-available > > The CI infrastructure relies on the existence of a google compute image in > order to function. Currently that image is not build anywhere in CI. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Assigned] (GEODE-8348) CI does not build benchmarks image
[ https://issues.apache.org/jira/browse/GEODE-8348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sean Goller reassigned GEODE-8348: -- Assignee: Sean Goller > CI does not build benchmarks image > -- > > Key: GEODE-8348 > URL: https://issues.apache.org/jira/browse/GEODE-8348 > Project: Geode > Issue Type: Bug > Components: ci >Reporter: Sean Goller >Assignee: Sean Goller >Priority: Major > Labels: pull-request-available > > The CI infrastructure relies on the existence of a google compute image in > order to function. Currently that image is not build anywhere in CI. -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Commented] (GEODE-8348) CI does not build benchmarks image
[ https://issues.apache.org/jira/browse/GEODE-8348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17158757#comment-17158757 ] ASF subversion and git services commented on GEODE-8348: Commit 0a5a629b13b80d375f34036610a68a705d46bafd in geode's branch refs/heads/develop from Sean Goller [ https://gitbox.apache.org/repos/asf?p=geode.git;h=0a5a629 ] GEODE-8348: Add benchmarks EC2 image builder job. (#5367) * Add EC2 builder job to images. * Benchmarks job uses branch-specific image. * Change benchmarks source repository location to the deployed fork's repo instead of forcing apache. * download our own copy of fly to use when deploying pipelines via deploy_meta.sh. > CI does not build benchmarks image > -- > > Key: GEODE-8348 > URL: https://issues.apache.org/jira/browse/GEODE-8348 > Project: Geode > Issue Type: Bug > Components: ci >Reporter: Sean Goller >Priority: Major > Labels: pull-request-available > > The CI infrastructure relies on the existence of a google compute image in > order to function. Currently that image is not build anywhere in CI. -- This message was sent by Atlassian Jira (v8.3.4#803005)
