[
https://issues.apache.org/jira/browse/GEODE-8348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17158741#comment-17158741
]
ASF GitHub Bot commented on GEODE-8348:
---------------------------------------
pivotal-jbarrett commented on a change in pull request #131:
URL: https://github.com/apache/geode-benchmarks/pull/131#discussion_r455391423
##########
File path: infrastructure/scripts/aws/launch_cluster.sh
##########
@@ -76,6 +86,10 @@ if [ -z "${CI}" ]; then
CI=0
fi
+if [ -z "${PURPOSE}" ]; then
Review comment:
Bashmagic:
`PURPOSE=${PURPOSE:-"geode-benchmarks"}`
##########
File path:
infrastructure/src/main/java/org/apache/geode/infrastructure/aws/LaunchCluster.java
##########
@@ -397,11 +397,17 @@ private static Image getNewestImage() {
DateTimeFormatter inputFormatter =
DateTimeFormatter.ofPattern("yyyy-MM-dd'T'HH:mm:ss.SSS'Z'",
Locale.ENGLISH);
+ String purpose = System.getProperty("PURPOSE");
Review comment:
Properties also supports a default value. So you can drop the empty
check and do this.
`String purpose = System.getProperty("PURPOSE", "geode-benchmarks")`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> CI does not build benchmarks image
> ----------------------------------
>
> Key: GEODE-8348
> URL: https://issues.apache.org/jira/browse/GEODE-8348
> Project: Geode
> Issue Type: Bug
> Components: ci
> Reporter: Sean Goller
> Priority: Major
>
> The CI infrastructure relies on the existence of a google compute image in
> order to function. Currently that image is not build anywhere in CI.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
