Re: Rust front-end
Hi David We made a table to try and track this a bit better: | Patch | Reviewed | Accepted | |-+--+--| | 0001-Use-DW_ATE_UTF-for-the-Rust-char-type.patch| x | x| | 0002-gccrs-Add-nessecary-hooks-for-a-Rust-front-end-tests.patch | x | x| | 0003-gccrs-Add-Debug-info-testsuite.patch | | | | 0004-gccrs-Add-link-cases-testsuite.patch | | | | 0005-gccrs-Add-general-compilation-test-cases.patch | | | | 0006-gccrs-Add-execution-test-cases.patch | | | | 0007-gccrs-Add-gcc-check-target-check-rust.patch| x | | | 0008-gccrs-Add-the-Rust-front-end-AST-data-structures.patch | | | | 0009-gccrs-Add-Lexer-for-Rust-front-end.patch | x | | | 0010-gccrs-Add-Parser-for-Rust-front-end.patch | | | | 0011-gccrs-Add-expansion-pass-for-the-Rust-front-end.patch | | | | 0012-gccrs-Add-name-resolution-pass-to-the-Rust-front-end.patch | | | | 0013-gccrs-Add-second-intermedite-representation-called-H.patch | | | | 0014-gccrs-Add-AST-to-HIR-lowering-pass.patch | | | | 0015-gccrs-Add-wrapper-for-make_unique.patch| | | | 0016-gccrs-Add-port-of-FNV-hash-used-during-legacy-symbol.patch | | | | 0017-gccrs-Add-Rust-ABI-enum-helpers.patch | | | | 0018-gccrs-Add-Base62-implementation.patch | | | | 0019-gccrs-Add-implementation-of-Optional.patch | | | | 0020-gccrs-Add-attributes-checker.patch | | | | 0021-gccrs-Add-helpers-mappings-canonical-path-and-lang-i.patch | | | | 0022-gccrs-Add-type-resolution-and-trait-solving-pass.patch | | | | 0023-gccrs-Add-unsafe-checks-for-Rust.patch | | | | 0024-gccrs-Add-const-checker.patch | | | | 0025-gccrs-Add-privacy-checks.patch | | | | 0026-gccrs-Add-dead-code-scan-on-HIR.patch | | | | 0027-gccrs-Add-unused-variable-scan.patch | | | | 0028-gccrs-Add-metadata-ouptput-pass.patch | | | | 0029-gccrs-HIR-to-GCC-GENERIC-lowering.patch| | | | 0030-gccrs-These-are-wrappers-ported-from-reusing-gccgo.patch | | | | 0031-gccrs-Add-GCC-Rust-front-end-Make-lang.in.patch| x | | | 0032-gccrs-Add-config-lang.in.patch | x | x| | 0033-gccrs-add-lang-spec.h.patch| | | | 0034-gccrs-add-lang.opt.patch | x | | | 0035-gccrs-add-compiler-driver.patch| | | | 0036-gccrs-compiler-proper-interface-kicks-off-the-pipeli.patch | | | | 0037-gccrs-Add-README-CONTRIBUTING-and-compiler-logo.patch | | | I think the formatting from org-mode didn't come through 100%, but it looks readable enough. The patches which are reviewed but not accepted have issues which we have fixed locally in preparation for sending version 3 of the patches. I also found using this link made it much easier to see which patches have had reviews and which have not: https://inbox.sourceware.org/gcc-patches/20220824115956.737931-9-philip.her...@embecosm.com/T/#rbff0bb3df2780fecd9ee3d2baa864d9140d24b54 You can easily see the thread of patches and those which have responses and which have not. Thanks --Phil On Tue, 4 Oct 2022 at 13:43, David Malcolm wrote: > > On Tue, 2022-10-04 at 13:29 +0100, Philip Herron wrote: > > Hi everyone, > > > > As the cut-off for merging is coming up in November, quite a few of > > our patches have not been reviewed yet. > > > > There are a few main issues that have been raised so far, and we are > > fixing those at the moment in preparation for version 3 of the > > patches. Is there anything else we can do to make reviewing the rest > > of the patches easier? > > Do you have a list of which patches need reviewing? > e.g. perhaps a page showing: > - which patches are waiting for a reviewer, as opposed to > - which patches are already approved > - which patches have issues identified in review > - ...where no-one is yet working on addressing them > - ...where someone is working on addressing them > etc > > to make it clearer what the next action is for each patch, and who is > meant to be t
Re: Rust front-end
Hi Jakub, Thanks for this, as I mentioned in my response to David we have made a table and use this link to try and see what's going on https://inbox.sourceware.org/gcc-patches/20220824115956.737931-9-philip.her...@embecosm.com/T/#rbff0bb3df2780fecd9ee3d2baa864d9140d24b54 Do you think I should send a PING email to each patch which we are waiting on review for? Thanks --Phil On Tue, 4 Oct 2022 at 14:04, Jakub Jelinek wrote: > > On Tue, Oct 04, 2022 at 08:42:58AM -0400, David Malcolm via Gcc wrote: > > On Tue, 2022-10-04 at 13:29 +0100, Philip Herron wrote: > > > Hi everyone, > > > > > > As the cut-off for merging is coming up in November, quite a few of > > > our patches have not been reviewed yet. > > > > > > There are a few main issues that have been raised so far, and we are > > > fixing those at the moment in preparation for version 3 of the > > > patches. Is there anything else we can do to make reviewing the rest > > > of the patches easier? > > > > Do you have a list of which patches need reviewing? > > e.g. perhaps a page showing: > > - which patches are waiting for a reviewer, as opposed to > > - which patches are already approved > > - which patches have issues identified in review > > - ...where no-one is yet working on addressing them > > - ...where someone is working on addressing them > > etc > > > > to make it clearer what the next action is for each patch, and who is > > meant to be taking it. > > > > (within Red Hat, we used to call this "who has the ball?") > > Yeah, our policy in https://gcc.gnu.org/contribute.html states that > "Pinging patches, Getting patches applied > > If you do not receive a response to a patch that you have submitted within > two weeks or so, it may be a good idea to chase it by sending a follow-up > e-mail to the same list(s). Patches can occasionally fall through the > cracks. Please be sure to include a brief summary of the patch and the URL > of the entry in the mailing list archive of the original submission." > > If some patches have been already reviewed, others partly, others in the > works and others need review, sending a mail with those details > so that it is easy to find out what is still pending is appreciated even > more. > > Jakub > -- Gcc-rust mailing list Gcc-rust@gcc.gnu.org https://gcc.gnu.org/mailman/listinfo/gcc-rust
Invitation: GCC Rust Community Call October @ Fri 7 Oct 2022 10am - 10:30am (BST) (gcc-rust@gcc.gnu.org)
BEGIN:VCALENDAR PRODID:-//Google Inc//Google Calendar 70.9054//EN VERSION:2.0 CALSCALE:GREGORIAN METHOD:REQUEST BEGIN:VEVENT DTSTART:20221007T09Z DTEND:20221007T093000Z DTSTAMP:20221005T094748Z ORGANIZER;CN=philip.her...@embecosm.com:mailto:philip.her...@embecosm.com UID:0qcn29obl0m2n9imlh6eonk...@google.com ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=ACCEPTED;RSVP=TRUE ;CN=philip.her...@embecosm.com;X-NUM-GUESTS=0:mailto:philip.herron@embecosm .com ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP= TRUE;CN=tho...@codesourcery.com;X-NUM-GUESTS=0:mailto:thomas@codesourcery.c om ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP= TRUE;CN=gcc-rust@gcc.gnu.org;X-NUM-GUESTS=0:mailto:gcc-rust@gcc.gnu.org ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP= TRUE;CN=m...@klomp.org;X-NUM-GUESTS=0:mailto:m...@klomp.org ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP= TRUE;CN=phil...@recogni.com;X-NUM-GUESTS=0:mailto:phil...@recogni.com ATTENDEE;CUTYPE=INDIVIDUAL;ROLE=REQ-PARTICIPANT;PARTSTAT=NEEDS-ACTION;RSVP= TRUE;CN=arthur.co...@embecosm.com;X-NUM-GUESTS=0:mailto:arthur.cohen@embeco sm.com X-MICROSOFT-CDO-OWNERAPPTID:219226479 CREATED:20221005T094746Z DESCRIPTION:Hi everyone\,It's been two months since our last commun ity call in August. Let us get the ball rolling again with one this Friday: Date/Time: 7th October 2022 at: 09h00 UTC \;Fri\, Oct 7 2022\, 10:00Mailing list: https://gcc.gnu.org/mailman/listinfo/gcc-r ust">https://gcc.gnu.org/mailman/listinfo/gcc-rustZulip: https://gcc-rust.zulipchat.com/IRC: irc.oftc.net #gccrustVideo Link: https://meet.jit.si/gccrs-co mmunity-call-october">https://meet.jit.si/gccrs-community-call-october< br>Agenda: https://hackmd.io/ULvMyAraR0C8jIVOfTPJcg";>https://hackm d.io/ULvMyAraR0C8jIVOfTPJcgIf this time does not suit\, we can try again next week. Thanks--Phil LAST-MODIFIED:20221005T094746Z LOCATION:https://meet.jit.si/gccrs-community-call-october SEQUENCE:0 STATUS:CONFIRMED SUMMARY:GCC Rust Community Call October TRANSP:OPAQUE END:VEVENT END:VCALENDAR invite.ics Description: application/ics -- Gcc-rust mailing list Gcc-rust@gcc.gnu.org https://gcc.gnu.org/mailman/listinfo/gcc-rust
