Re: [google/4.7]mark expected failures for ppc64 (issue 6932046)

2012-12-11 Thread jingyu 

As suggested by Doug, this patch is aimed to google/integration,
google/main, and google/gcc-4_7.

https://codereview.appspot.com/6932046/

Re: [google/google-main] Fix regression - SUBTARGET_EXTRA_SPECS overridden by LINUX_GRTE_EXTRA_SPECS (issue 6016047)

2012-05-15 Thread jingyu 

I suspect this patch would change specs of non-i386 platform. For
example, LINUX_GRTE_EXTRA_SPECS is not part of SUBTARGET_EXTRA_SPECS for
darwin.

Can you tell where SUBTARGET_EXTRA_SPECS is firstly defined for chromeos
toolchain?



On 2012/05/14 18:32:17, shenhan wrote:

On 2012/04/12 21:14:29, shenhan wrote:
> Hi, the newest chrome gcc (from google-main) fails to linking

anything, by

> looking into specs file, it seems that 'link_emulation' section is

missing in

> specs.
>
> The problem I found is that SUBTARGET_EXTRA_SPECS, which is not

empty for

> chromeos, is overridden by "LINUX_GRTE_EXTRA_SPECS".
>
> Please review the proposed a patch. (Tested by buildit bootstrap).
>
> -Han



Hi Jing and Rong, could you take a look at this?



Thanks,
-Han




http://codereview.appspot.com/6016047/

Re: [google/gcc-4_6_3-mobile] Port r187569 from google/gcc-4_6 branch (issue 6210060)

2012-05-16 Thread jingyu 

In my opinion, gcc/ChangeLog is for upstream commits only.
It is fine that you want to port upstream gcc/ChangeLog as well. Just
remove your identities
+2012-05-11  Han Shen  
+
+   Backported r187569 from branches/google/gcc-4_6.

LGTM
On 2012/05/16 22:54:19, asharif1 wrote:

On 2012/05/16 22:11:08, shenhan wrote:
> On 2012/05/16 17:27:59, asharif1 wrote:
> > On 2012/05/16 01:02:26, shenhan wrote:
> > > Hi Amhad and Jing, could you take a look at this CL at
> > > http://codereview.appspot.com/6210060/
> > >
> > > Thanks,
> > > -Han
> >
> > Shouldn't this have a corresponding ChangeLog entry and a
> > ChangeLog.google-gcc-4_6 entry?
>
> Hi Ahmad, thanks!
>
> Done recreating the patch from "svn merge -c".
>
> Regards,
> -Han



Thanks a lot, shenhan.



lgtm.



http://codereview.appspot.com/6210060/

Re: [google/gcc-4_6] Added dejagnu base line for x86_64-cros-linux-gnu. (issue 5990044)

2012-04-06 Thread jingyu 

On 2012/04/06 00:35:12, asharif1 wrote:

On 2012/04/05 17:25:44, shenhan wrote:
> Hi Jing and Ahmad,
>
> This adds a new test base line for x86_64-cros-linux-gnu. Please

take a look.

>
> Thanks,
> Han



lgtm.


ok

http://codereview.appspot.com/5990044/

Re: [google] Backport r171347 and r181549 from trunk (strict volatile bitfield) (issue 5453050)

2011-12-05 Thread jingyu 

http://codereview.appspot.com/5453050/

Re: Merged r182417 from branches/google/gcc-4_6. (issue 5491078)

2011-12-19 Thread jingyu 

On 2011/12/19 22:09:18, asharif1 wrote:

This merges xur's patch to our mobile release branch. LGTM and I will

submit it.

OK

http://codereview.appspot.com/5491078/

Re: [google]Skip target-libiberty for arm*-*-linux-androideabi (issue4564050)

2011-06-06 Thread jingyu 

The trunk version has been approved and committed as r174710. Backport
it to google/main. The google/main version has the same logic but is
slightly different since trunk has a different code structure here. OK
for google/main?

2011-06-06  Jing Yu  

Backport trunk r174710:

* configure.ac: Skip target-libiberty for arm*-*-linux-androideabi.
* configure: Regenerated.

http://codereview.appspot.com/4564050/

Re: [google] Backport r175347 from trunk to google/gcc-4_6 (issue4835041)

2011-08-01 Thread jingyu 

ok

http://codereview.appspot.com/4835041/