In my opinion, gcc/ChangeLog is for upstream commits only. It is fine that you want to port upstream gcc/ChangeLog as well. Just remove your identities +2012-05-11 Han Shen <shen...@google.com> + + Backported r187569 from branches/google/gcc-4_6.
LGTM On 2012/05/16 22:54:19, asharif1 wrote:
On 2012/05/16 22:11:08, shenhan wrote: > On 2012/05/16 17:27:59, asharif1 wrote: > > On 2012/05/16 01:02:26, shenhan wrote: > > > Hi Amhad and Jing, could you take a look at this CL at > > > http://codereview.appspot.com/6210060/ > > > > > > Thanks, > > > -Han > > > > Shouldn't this have a corresponding ChangeLog entry and a > > ChangeLog.google-gcc-4_6 entry? > > Hi Ahmad, thanks! > > Done recreating the patch from "svn merge -c". > > Regards, > -Han
Thanks a lot, shenhan.
lgtm.
http://codereview.appspot.com/6210060/
