Hello,
As for the rpm/Makefile.am stuff, I think that was a temporary fix for
an odd error
I got while testing. I just forgot to remove it and see if it would
break again. It has
been removed and makes now.
As for the 'base' idea, I gave it some thought and believe this is the
best solution
and I have implemented it.
> And then add a unique base to each get_port call (8000, 8100, 8200,
> ...). We would to be careful to never assign the same unique range to
> each test though. Which requires the programmer to check all other
> tests. But maybe that isn't such a big deal? git grep ^get_port tests
> would give you all the currently used port ranges...
>
> Ideas?
>
Agreed, implemented.
The patch also includes x-forwarded
-Noah Sanci
From 0583d98836cd7492f88579e5aa154699069e97b8 Mon Sep 17 00:00:00 2001
From: Noah Sanci
Date: Tue, 10 Aug 2021 11:21:35 -0400
Subject: [PATCH] debuginfod: Fracture tests/run-debuginfod-find.sh into
specific tests
tests/run-debuginfod-find.sh was a massive test script with many broadly
varying tests. This caused the test script to fail when any number of
things went wrong and because of its intertwined nature, detecting the
source of a failure could be difficult. The size of the test script
also meant many unrelated tests were run making the testing process
unnecessarily lengthy.
This patch fractures tests/run-debuginfod-find.sh into smaller, more
manageable individual test script files. This ensures that when failure
occurs, a programmer can easily determine where their patch went
wrong. It also allows programmers to specify exactly which tests to
run, making testing more efficient. Redundancies are also reduced by
placing code in tests/test-subr.sh.
Signed-off-by: Noah Sanci
---
tests/ChangeLog| 29 +++
tests/Makefile.am | 46 -
tests/run-debuginfod-000-permission.sh | 85
tests/run-debuginfod-X-FORWARDED.sh| 60 ++
tests/run-debuginfod-archive-groom.sh | 153 +++
tests/run-debuginfod-archive-rename.sh | 95 +
tests/run-debuginfod-archive-test.sh | 83
tests/run-debuginfod-artifact-running.sh | 122
tests/run-debuginfod-dlopen.sh | 84
tests/run-debuginfod-duplicate-urls.sh | 51 +
tests/run-debuginfod-extraction.sh | 101 ++
tests/run-debuginfod-fd-prefetch-caches.sh | 57 ++
tests/run-debuginfod-federation-link.sh| 161
tests/run-debuginfod-federation-metrics.sh | 213 +
tests/run-debuginfod-federation-sqlite.sh | 201 +++
tests/run-debuginfod-file.sh | 39
tests/run-debuginfod-malformed.sh | 110 +++
tests/run-debuginfod-no-urls.sh| 41
tests/run-debuginfod-query-retry.sh| 34
tests/run-debuginfod-regex.sh | 97 ++
tests/run-debuginfod-response-headers.sh | 118
tests/run-debuginfod-sizetime.sh | 77
tests/run-debuginfod-tmp-home.sh | 124
tests/run-debuginfod-writable.sh | 84
tests/run-debuginfod-x-forwarded-for.sh| 62 ++
tests/test-subr.sh | 124 +++-
26 files changed, 2448 insertions(+), 3 deletions(-)
create mode 100755 tests/run-debuginfod-000-permission.sh
create mode 100644 tests/run-debuginfod-X-FORWARDED.sh
create mode 100755 tests/run-debuginfod-archive-groom.sh
create mode 100755 tests/run-debuginfod-archive-rename.sh
create mode 100755 tests/run-debuginfod-archive-test.sh
create mode 100755 tests/run-debuginfod-artifact-running.sh
create mode 100755 tests/run-debuginfod-dlopen.sh
create mode 100755 tests/run-debuginfod-duplicate-urls.sh
create mode 100755 tests/run-debuginfod-extraction.sh
create mode 100755 tests/run-debuginfod-fd-prefetch-caches.sh
create mode 100755 tests/run-debuginfod-federation-link.sh
create mode 100755 tests/run-debuginfod-federation-metrics.sh
create mode 100755 tests/run-debuginfod-federation-sqlite.sh
create mode 100755 tests/run-debuginfod-file.sh
create mode 100755 tests/run-debuginfod-malformed.sh
create mode 100755 tests/run-debuginfod-no-urls.sh
create mode 100755 tests/run-debuginfod-query-retry.sh
create mode 100755 tests/run-debuginfod-regex.sh
create mode 100755 tests/run-debuginfod-response-headers.sh
create mode 100755 tests/run-debuginfod-sizetime.sh
create mode 100755 tests/run-debuginfod-tmp-home.sh
create mode 100755 tests/run-debuginfod-writable.sh
create mode 100755 tests/run-debuginfod-x-forwarded-for.sh
diff --git a/tests/ChangeLog b/tests/ChangeLog
index 3fa7c2e4..db5b25d1 100644
--- a/tests/ChangeLog
+++ b/tests/ChangeLog
@@ -12,6 +12,35 @@
* run-debuginfod-find.sh: Add test for X-Forwarded-For hops limit.
+2021-08-20 Noah Sanci
+
+ * debuginfod-find.sh: Separated file into
+ run-debuginfod-000-permission.sh,
+
