Hi Noah,

I am excited about this patch, but wondering about this part:

> diff --git a/ChangeLog b/ChangeLog
> index 12b8f403..0aeac175 100644
> --- a/ChangeLog
> +++ b/ChangeLog
> @@ -1,3 +1,6 @@
> +2021-08-23  Noah Sanci  <nsa...@redhat.com
> +     * ChangeLog: removed --sign flag on rpmbuild
> +
>  2021-07-28  Mark Wielaard  <m...@klomp.org>
>  
>       * configure.ac (AC_CHECK_DECLS): Add reallocarray check.
> diff --git a/Makefile.am b/Makefile.am
> index 9c47afa9..3dfefa9f 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -45,7 +45,7 @@ distcheck-hook:
>       chmod -R u+w $(distdir)
>  
>  rpm: dist
> -     rpmbuild -ts --sign elfutils-@PACKAGE_VERSION@.tar.bz2
> +     rpmbuild -ts elfutils-@PACKAGE_VERSION@.tar.bz2
>  
>  if GCOV

This might be a ok thing to do. I am not sure who is actually using the
rpm target (we release src.tar.bz files, not srpms). But it seems
unrelated to the rest of the patch.

Cheers,

Mark

Reply via email to