Re: [PATCH 2/2] run-strip-reloc.sh: Skip debug file check for riscv

[Andreas Schwab]

On Jul 17 2018, Mark Wielaard  wrote:

> On Mon, Jul 16, 2018 at 12:02:17PM +0200, Ulf Hermann wrote:
>> strip does not produce debug files for riscv binaries. If this is a bug
>> it needs to be fixed in strip, but for now, we disable the tests.
>
> The issue is that hello_riscv64.ko doesn't contain any debug sections.
> So strip doesn't produce a separate debug file.
>
> Andreas, could you provide an updated hello_riscv64.ko that is compiled
> with -g and does contain debuginfo?

What is the issue?  The test worksforme.

Andreas.

-- 
Andreas Schwab, SUSE Labs, sch...@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

Re: [PATCH 2/2] run-strip-reloc.sh: Skip debug file check for riscv

[Mark Wielaard]

On Tue, 2018-07-17 at 11:29 +0200, Andreas Schwab wrote:
> On Jul 17 2018, Mark Wielaard  wrote:
> > The issue is that hello_riscv64.ko doesn't contain any debug
> > sections.
> > So strip doesn't produce a separate debug file.
> > 
> > Andreas, could you provide an updated hello_riscv64.ko that is
> > compiled
> > with -g and does contain debuginfo?
> 
> What is the issue?  The test worksforme.

The problem is that the test is designed to see that strip works to
properly to remove the .debug sections and remove relocations against
.debug sections for a .ko file. But the hello_riscv64.ko file doesn't
contain any .debug sections so it trivially succeeds. Ulf fixed the
test to make sure strip actually does any work by removing the old
debug files. This shows the current hello_riscv64.ko failing.

If you could regenerate the file with -g so that it does contain .debug
sections that would help us fix the testcase.

Thanks,

Mark

Re: [PATCH 2/2] run-strip-reloc.sh: Skip debug file check for riscv

[Andreas Schwab]

On Jul 17 2018, Ulf Hermann  wrote:

> My first patch removes all temporary files at the beginning of runtest()
> which exposes this.

Thanks, I see the failure now.  Here is the updated module:



hello_riscv64.ko.bz2
Description: BZip2 compressed data

Andreas.

-- 
Andreas Schwab, SUSE Labs, sch...@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

Re: [PATCH 2/2] run-strip-reloc.sh: Skip debug file check for riscv

[Andreas Schwab]

On Jul 17 2018, Mark Wielaard  wrote:

> If you could regenerate the file with -g so that it does contain .debug
> sections that would help us fix the testcase.

It would probably help to update the build instructions to force debug
builds by adding CONFIG_DEBUG_INFO=y.

Andreas.

-- 
Andreas Schwab, SUSE Labs, sch...@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

Re: [PATCH 2/2] run-strip-reloc.sh: Skip debug file check for riscv

[Mark Wielaard]

On Tue, 2018-07-17 at 12:09 +0200, Andreas Schwab wrote:
> It would probably help to update the build instructions to force
> debug
> builds by adding CONFIG_DEBUG_INFO=y.

Yes, good idea, added that and updated the test file.

Thanks,

MarkFrom c1d7a08c990a13472b64281dbf79b13fb74f9e5a Mon Sep 17 00:00:00 2001
From: Mark Wielaard 
Date: Tue, 17 Jul 2018 12:27:51 +0200
Subject: [PATCH] tests: Update hello_riscv64.ko test file with debuginfo.

Also document CONFIG_DEBUG_INFO=y.

Updated test file provided by Andreas Schwab .

Signed-off-by: Mark Wielaard 
---
 tests/ChangeLog|   5 +
 tests/hello_riscv64.ko.bz2 | Bin 1166 -> 39548 bytes
 tests/run-strip-reloc.sh   |   4 +++-
 3 files changed, 8 insertions(+), 1 deletion(-)

diff --git a/tests/ChangeLog b/tests/ChangeLog
index 0677b9f..5a9dc33 100644
--- a/tests/ChangeLog
+++ b/tests/ChangeLog
@@ -1,3 +1,8 @@
+2018-07-17  Mark Wielaard  
+
+	* hello_riscv64.ko.bz2: Updated with debuginfo.
+	* run-strip-reloc.sh: Add documentation on CONFIG_DEBUG_INFO=y.
+
 2018-07-05  Mark Wielaard  
 
 	* next_cfi.c (handle_section): Take a new argument name. Check
diff --git a/tests/hello_riscv64.ko.bz2 b/tests/hello_riscv64.ko.bz2
index 355a51226195d15ff0d7b3636efbd5bccf4f1be9..a086c38095b76bc3f1570f4df0e2142d01c2ef94 100644
GIT binary patch
literal 39548
zcmagFV|--K6E8fmZSEwQIN6PD+qP|U!;Nj*wrx8bW3#cX4W9h|_jz^S+&XjmRDZjw
zx*GH8n$tZ(S{9s)f|?Y{nk^*Hy`skHC_003a?aLX%wUkpHBUdI9x
z01va`&qwu@MG1INK3BAbE(R|H6HK%=s!}W&j|dVdW*hMj1QSvuN25tnfY=3Go>G;c
zGknPd0f28VFkIK1H06g7+fS-q5L?~^?s+_3mk=o4-hJGI%U6UC9iDS2HdprQ49@1=
z%-!}L+AAw_hsHKq1HYlFu2
zH+QVJp1dBtn_6DoZO@-tYwa#J+*aJ4?7Gj~y|yb_Y;CueY3wdlbu%h1TDDrY@DFS@
ztRjkO`Tzj9LV!dZeBOK>0P@^yDghuZ=1&BnItO6`0pw-?6Y__G2Y@ik7uBr*M>Z1*
zsx4G#Yz(TZRMemG$zbVA|LPi+fihM3J_-sM5^xIuxWN!bI!oUi85pKaXc=@!
zG#*c^PG1ejz6(>0Nn=N2cU{0XPO=LG=F`
zAOKh*DgfGl4vrNaQWh?5$yl;zgiNwf7LlA`yTDLh@`P6=8VROEfh{A0<$eKxPn?Gb
zohdQ*0I=W{%Rov%k+ArW0YC__eAyC-3$#Fm1!oxpH)ImBJSp%*QDF;ad0=5>8M;=u
zm!B6rDal)82{^$k8uF6;QsZR_NEE;az!V|MvRDA{k;*I!tt=Lo;7EZPU@UWxi>QD!
z=n#L@A<9IV3?!LFfu+7QKw3tQWEzFASXyaGR3ei}KaWm^_7%
zk;ObK(34NIJzqjATbmnOAyhCD#U%cQI5Ayhe+cU??2)6>6
z5T}Tm8G~t#9Oww9f>aRld`}bNIaqMYTgg!}YAnmXizn_!A19!)!H|cByaZ7sz`C&v
z<7trCM>rHRW@2QO1A&Q%YLstaK(8)vusevzfSW2~Vk1jo6MS$U#AuZci&W?=CZ)`^9pR&YY*sz7FUeL^_;bNMiRDd?Di6OglO|>H1?-3r^^1gaWnBu$`%gM
zK!d{EHK<~wZ0r5^`y@COsz5^md&DEm3O)h*HiOghmyzf3z|EiteM?p}5;7T2EPFN0
zyjU0+Jj(a7VPy-tB~?W&xvt~F!l+$O$WE#XPCA5oQ4VYe^x%C2DqhWWs(MI4sssgs
z2r33eAr1d#5KYIorz`!pcHyLAOvq
z(Pg!OhYdeuU_c^R6g0({ca5q;h8AZ;ks_H*TPY!#Vca~aSc{F5#w1ltZ6lG)04x)+
z!JA_jQNl)LNTZG=TW=&p(3z%M#nWR8PQRQ54H-}XV6(i3I&QZ=RtsGd?tMe
z02FFOwF=1oG=>cM5E*3ta#|t48Zzk|bg5EN3zl%L83kTuPGhD+iQu^+e{alZ!6;N%
zV`)G#fOMZa2BR7}!;k`!wg|IKa}W+aC|yz^2)s#93zaDgiCGFRlP)sON@5`iw3i?x
zsXB_Mu*zbVBqvpzL7P2mK^iK936CL1Ehjpn0Wu3yXatA`*JlU$VBryXG=>e~Z<5xB
z3L@qwTiFzQjJc7Tp$Z~I6!=Foi$j4JaSuUt)M~;=_DaE$WH?wTpo`#y3DXgWve>LS
zuz`7MComL2WMzSTZOZrr9_ASpS?;i+p<2ZlP9usjC6NKE2@-~RTCpL-Ni@`vywU`a
z2<9OZxl%gw0c;66SlW2nDx@V3Hna>BsK#WNgH)BmV9cc7RwqBZXcp-9gCl<{(y^;u9ni{o?&f|LGf6e9Z!YGD*efgqO=
z1SyvQQI1THqKN_ODW)PS1(>n@s&crv>-GpxwYDr>l+*!Ygh-%d0SBi81G%v%iIOl+
zw9xPQngCR@WJrT}2Dx||r($@#W94GUF%Jb8a+s{rs1mw>0JX!GpgA=wYABn1k=sCJ|JdwnEnUVWbyQ(e3BxE1Vg^QeE+`PWg(@p7
zcqr)rIvy&^T=1+;sSKtj6hjeYA@}+kq@)Pg)OFu6B49Y~Z@eJ*7?y-%c0Mh7_?|+F
z!rY$JZ!uUBgAssqas?2Q9V*IX8oxMlo^uu$RX}dfG)x;j7)Y*Q@RFA=mD+^l8P)(w
zfV!zt8|0_;eqekUoB
z7e$E~P}9cm7YM{aM3`a_3sFFTsVVX-Bsd3pia3mE5*mTZAY+1*aVyN~m1RbFAk(2;
zu0Mt)&|yHuO~beuJVmak@*MH+o*5=CX)kI;-UFU9vSD9%9
zL~t`r@-hW>f&ap~;LV>6$}3V71(85tvufB==>}d^GI)o!DXjA5no9>%iY&PcTY>0G
zGTkS}l!fwSLSk{#|AD&j(l|W=SeRgS{0D^@dnaqtVSskNg5p!a9mnqbcV&pFeRRCS
zwlLlj_&ro)W9R`6Sm4`SAU2R8peuix^cK&8#NXOB2#f`o;20>4iVnBLeAE!Gl`K_(
zKA?*Sl|)KPikekf$NoDhi$(O0g!Vtg!*zuXRCJQwXOSqejj%mf8I8fd}nrs
z{_-yL;P*P;n*l`MzTd3YOYK%(n?29sXWh0SNg?1sm1?Uq6X2CL{&XH<9TR3IK^(zW
zEh3*CWR4?DqClKQ>iGMTRjXgGjB?=2%vc8iAol?v=5wK1HeSzdTL!xN0C^~IEj!h-
z<7^v`2A%@{3mCT8-bZ{*5_x-w1;8$}ZCm~WiR%Cmo6nw$%zw>@r@ypO0laB2%l-hE
zqc0tZHUQwU?<*1nf$jg>@dG7zeSSAHGc)+o`v%ssVP1za6`Jvl)Dx-albNvvEV@;;
zaUa|tqVuiWJvZi_NcVrFH{P;g0Py7xP0va3+|K4QGxv>ddE-k2CAeRep_K8Z_fq$w
zFt&Vf+dh5VZQY+Nmda&w|K6}|`TBecY}j>OepP8~^HnFrQjP=wOyG+H0Ng1Tdjsx!
zQM#W$zcv0x9cSD}XPLI49Vm7H7{56H^2qy)nVIJflg!lA|1`dmr;mWwx2c&sT;l8h
zAe3AbBLKi-_p3D~0G~EEP`vKyfB1g{6SZOcV(`^J-L10EFMnG$kRMvM8Cy0U^vSp{
zx&0DeYI^>o_Lr6oyRQxl^V5Q&Uq0U{_yF{tE2&{lC<_cL5Nm1h%cO81?Uw
zKX2-Izg#o;!v8Pw-hKHbJ2A?UIeXo{TVF9c{h|{AABqk8|0Wb)am&UH0EG?!?$5{I
zjlHw>UyD&(Hf-y@3XxZNQ2zk|C=oCb{|5j-?0vytH#~kh33C5R<*q7=5=ZXLTTYmH
z5zZcLTV9QATZj)@-ZrOf>mW|MCIA4g4cpf3*7IJx+Xk7O%+kV|^h2p9T?#W}o>+pT
zPUX3;`BQk3TQKt9KzcR-JiBYtUvtj7YGc>d)^0lOHd-#aN6c-Rm&ch2o=0;pet_L>
zxO{o|HM#Zy5M8z{|LK99^zj^jJ-v3h{U-bY#A~l~uUEC+`O>F}J*7}_F
zHHs(#8@5jdp0ZzG9kvZ$8;Apf7oXEv{@C7;Pm=VU$O=hjo+=(7INOE|00rjvJ7R()
zpfkg=B*U^eMK9fnE5|zdkc{Z^^Ttf%%z0l?L?IS0hC?OpKq?dr85Q3?v5=}{Bh^pw
z7H>%jNHUCGN9zzV8M$Eve3WhP9(0La8D7dRt?!mPxMIA1okEf)D;?97%```*45Q$3togY#vRhJkJ+_)F(=wQ!WGvV*@{}k!h?~D
z+c$8Ka4I5Mn(=3nS40prFWsO#@uM)LVHkxhGMzw7C_tt&ciW+n^V$x4rWuO1*IvdwStynkU0z=PecFDQpuN}H(Ye08)v;SD7NJt

Re: [PATCH 1/2] Remove previous test files before running the next round

[Mark Wielaard]

On Mon, 2018-07-16 at 23:57 +0200, Mark Wielaard wrote:
> On Mon, Jul 16, 2018 at 12:01:21PM +0200, Ulf Hermann wrote:
> > strip explicitly creates the new files. This will not work on
> > windows if
> > the files already exist.
> > 
> > Also, if strip fails to create the files for any reason, we would
> > check
> > the previous run's files and succeed. However, the test should fail
> > then.
> 
> This makes sense and does uncover a bug as your second patch shows.
> I want to fix that first and only then commit this fix. That way we
> don't have the testsuite failing between commits.

Pushed now that we have an updated hello_riscv64.ko test file.

Thanks,

Mark

[PATCH] backends: add core_note callback for RISC-V

[Andreas Schwab]

Signed-off-by: Andreas Schwab 
---
 backends/ChangeLog|  6 
 backends/Makefile.am  |  2 +-
 backends/riscv_corenote.c | 60 +++
 backends/riscv_init.c |  1 +
 4 files changed, 68 insertions(+), 1 deletion(-)
 create mode 100644 backends/riscv_corenote.c

diff --git a/backends/ChangeLog b/backends/ChangeLog
index 0532760046..bf31072e3a 100644
--- a/backends/ChangeLog
+++ b/backends/ChangeLog
@@ -1,3 +1,9 @@
+2018-07-17  Andreas Schwab  
+
+   * Makefile.am (riscv_SRCS): Add riscv_corenote.c.
+   * riscv_corenote.c: New file.
+   * riscv_init.c (riscv_init): Hook core_note.
+
 2018-07-11  Andreas Schwab  
 
* Makefile.am (riscv_SRCS): Add riscv_initreg.c.
diff --git a/backends/Makefile.am b/backends/Makefile.am
index f782e8828b..50507c7966 100644
--- a/backends/Makefile.am
+++ b/backends/Makefile.am
@@ -132,7 +132,7 @@ libebl_bpf_pic_a_SOURCES = $(bpf_SRCS)
 am_libebl_bpf_pic_a_OBJECTS = $(bpf_SRCS:.c=.os)
 
 riscv_SRCS = riscv_init.c riscv_symbol.c riscv_cfi.c riscv_regs.c \
-riscv_initreg.c
+riscv_initreg.c riscv_corenote.c
 libebl_riscv_pic_a_SOURCES = $(riscv_SRCS)
 am_libebl_riscv_pic_a_OBJECTS = $(riscv_SRCS:.c=.os)
 
diff --git a/backends/riscv_corenote.c b/backends/riscv_corenote.c
new file mode 100644
index 00..37cce7e3d3
--- /dev/null
+++ b/backends/riscv_corenote.c
@@ -0,0 +1,60 @@
+/* RISC-V specific core note handling.
+   This file is part of elfutils.
+
+   This file is free software; you can redistribute it and/or modify
+   it under the terms of either
+
+ * the GNU Lesser General Public License as published by the Free
+   Software Foundation; either version 3 of the License, or (at
+   your option) any later version
+
+   or
+
+ * the GNU General Public License as published by the Free
+   Software Foundation; either version 2 of the License, or (at
+   your option) any later version
+
+   or both in parallel, as here.
+
+   elfutils is distributed in the hope that it will be useful, but
+   WITHOUT ANY WARRANTY; without even the implied warranty of
+   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+   General Public License for more details.
+
+   You should have received copies of the GNU General Public License and
+   the GNU Lesser General Public License along with this program.  If
+   not, see .  */
+
+#ifdef HAVE_CONFIG_H
+# include 
+#endif
+
+#include 
+#include 
+#include 
+#include 
+#include 
+
+#define BACKENDriscv_
+#include "libebl_CPU.h"
+
+#defineULONG   uint64_t
+#define PID_T  int32_t
+#defineUID_T   uint32_t
+#defineGID_T   uint32_t
+#define ALIGN_ULONG8
+#define ALIGN_PID_T4
+#define ALIGN_UID_T4
+#define ALIGN_GID_T4
+#define TYPE_ULONG ELF_T_XWORD
+#define TYPE_PID_T ELF_T_SWORD
+#define TYPE_UID_T ELF_T_WORD
+#define TYPE_GID_T ELF_T_WORD
+
+static const Ebl_Register_Location prstatus_regs[] =
+  {
+{ .offset = 1, .regno = 1, .count = 31, .bits = 64 } /* x1..x31 */
+  };
+#define PRSTATUS_REGS_SIZE (32 * 8)
+
+#include "linux-core-note.c"
diff --git a/backends/riscv_init.c b/backends/riscv_init.c
index c74c6af50f..8b7ce8b5d9 100644
--- a/backends/riscv_init.c
+++ b/backends/riscv_init.c
@@ -58,6 +58,7 @@ riscv_init (Elf *elf __attribute__ ((unused)),
   HOOK (eh, check_special_symbol);
   HOOK (eh, machine_flag_check);
   HOOK (eh, set_initial_registers_tid);
+  HOOK (eh, core_note);
 
   return MODVERSION;
 }
-- 
2.18.0


-- 
Andreas Schwab, SUSE Labs, sch...@suse.de
GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
"And now for something completely different."

Re: [PATCH] backends: add core_note callback for RISC-V

[Mark Wielaard]

Looks good as far as I can tell.
Pushed to master. But it would be really nice to have a testcase.
Could you look at tests/run-readelf-mixed-corenote.sh and add something
similar for RISC-V?

Thanks,

Mark

Re: [PATCH] Don't include sys/uio.h if we don't need it

[Mark Wielaard]

On Tue, Jul 17, 2018 at 01:40:26PM +0200, Ulf Hermann wrote:
> 
> The PID attaching only works on linux.
> 
> Change-Id: I00428a711b64cb490429363ef28a867b1347956e

Thanks applied to master.
I did remove the Change-Id tag.
And normally we do require a Signed-off-by line.

Cheers,

Mark