Re: [dev-servo] custom derive for Deref/DerefMut

2017-07-15 Thread Jim Blandy
A macro_rules macro wouldn't serve here?

On Fri, Jul 14, 2017 at 5:26 PM, Bobby Holley  wrote:

> On Fri, Jul 14, 2017 at 2:24 AM, Anthony Ramine  wrote:
>
> >
> > > Le 14 juil. 2017 à 02:13, Bobby Holley  a
> écrit :
> > >
> > > There's a lot of boilerplate involved just to make a newtype [1]. Is
> this
> > > something we could add a custom derive for?
> >
> > We don't use that many newtypes to justify writing a custom derive for
> > that IMO. Often we don't even bother and just do wrapper.0.
> >
>
> Well, we all do that because writing 10 lines of boilerplate is usually
> worse than scattering some .0s around. If there were a 1-line derive we
> might use it more.
>
>
> > Remove all the unneeded where clauses for E on the type definition, and
> on
> > the Deref* impls and you have only ~10 lines of boilerplate.
> >
> > ___
> > dev-servo mailing list
> > dev-servo@lists.mozilla.org
> > https://lists.mozilla.org/listinfo/dev-servo
> >
> ___
> dev-servo mailing list
> dev-servo@lists.mozilla.org
> https://lists.mozilla.org/listinfo/dev-servo
>
___
dev-servo mailing list
dev-servo@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-servo


Re: [dev-servo] custom derive for Deref/DerefMut

2017-07-15 Thread Alex Webster
Unsubscribe

On Jul 13, 2017 8:20 PM, "Bobby Holley"  wrote:

Sorry, wrong link. I meant:
https://reviewboard.mozilla.org/r/157064/diff/3#index_header

On Thu, Jul 13, 2017 at 5:13 PM, Bobby Holley  wrote:

> There's a lot of boilerplate involved just to make a newtype [1]. Is this
> something we could add a custom derive for?
>
> [1] https://treeherder.mozilla.org/#/jobs?repo=try&revision=
> 9adf7a220ac8fa870f30a25a1ff8c71da65873fa
>
___
dev-servo mailing list
dev-servo@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-servo
___
dev-servo mailing list
dev-servo@lists.mozilla.org
https://lists.mozilla.org/listinfo/dev-servo