[dev-servo] PSA: import blocks are now sorted
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi all, Consecutive lines of imports are now sorted, thanks to Johann Tuffe. test-tidy will complain about any violations. This does have the unfortunate consequence that most PRs will have been bitrotted; apologies for the inconvenience. Ms2ger -BEGIN PGP SIGNATURE- iQEcBAEBAgAGBQJV1eozAAoJEOXgvIL+s8n21CEIAJ6/f74291AS8AKzLU8ybQA8 z+VVF81ggOWCwYVVC4dezR8My9TaO/9EVf6ZDuGj22Ag1n54S+aVALyN24GQt57/ bdrGjQGp7I0mPRjvJtkJffAlGIkDcgh3IyN4vMjYq8PlkLVz9aB3+qDPSQxr+qqU jVi8wZPXnuTk5t4boQ2qnOHNUg96Ax7Jl4Ce/V5Ad9D9bBOgLFGp3aP0+l+dc4as 0eu0lTqUoLMp2QSwuP7ucjifQ887qqZe/RqYb7ljiDFUkOzIBj+WfjtfYa+KeRVL tuoKc7NFH/lXnGQAh8v7M8artIoy6kXPeUbobEI9sjmgefgQ+ACdbo1bc+ThsgU= =ZkMl -END PGP SIGNATURE- ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo
[dev-servo] Travis, Rust Nightlies & Aster
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Hi all, Recently, homu has regularly rejected PRs to rust-layers because of a mismatch between the latest Rust nightly (which Travis uses by default), and Aster (which it depends on through euclid and serde_macros). This has been solved by locking the Rust nightly to a version that works with the latest version of Aster (at that point). However, when Aster is updated for the breaking changes in Rust, the build breaks again. Does anyone have ideas on how to avoid this issue in the future? TIA Ms2ger -BEGIN PGP SIGNATURE- iQEcBAEBAgAGBQJV1fdKAAoJEOXgvIL+s8n2lyAH/joGJ/svxtQPxAfmSfCGms0j CR8AF0kzspJjzk1+7ebTEgYWTx2o2u+FpWQYblM39cJo0eJHYq6aW95MWIoia3h+ lPcMDCl+rI25DODG9GcscfrDk6o5B1T+UzsZeh8FcdythzbzVZjPAbzCxh0cGWuI lJIoOA4AbcAvk76Qwwesm+FW9VZexmlVC2ciKyA3Wz7SgzP57+Ss/rounis975fj H/RPTum6TL2Il8DefPvzQtfyHIh/vLJHAJjlbWU+ZpSwNpsmY2ZgkWWm6sHhJya/ nReBdfEPtE82d9mQb19sK8+a1S6ZhG3FGaK/dumUQDox7KCG5OWGIe5TBtwf1Xc= =joT8 -END PGP SIGNATURE- ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo
Re: [dev-servo] Travis, Rust Nightlies & Aster
On 08/20/2015 08:50 AM, Ms2ger wrote: > Hi all, > > Recently, homu has regularly rejected PRs to rust-layers because of a > mismatch between the latest Rust nightly (which Travis uses by > default), and Aster (which it depends on through euclid and > serde_macros). This has been solved by locking the Rust nightly to a > version that works with the latest version of Aster (at that point). > However, when Aster is updated for the breaking changes in Rust, the > build breaks again. > > Does anyone have ideas on how to avoid this issue in the future? One possible solution is to ensure that serde requires a specific version of aster in its Cargo.toml, and that euclid, in turn, requires a specific version of serde in its Cargo.toml. Then we need to pin the rust nightly version in all of the packages that depend on euclid. Another option that we discussed via IRC is to have travis update to a precise version of aster in all crates that depend on euclid. We would also need to pin the rust nightly for this to work as well. It seems that no matter what we do, we will end up pinning the rust nightly in all crates. Even without this issue with aster, the rust nightly can break create compilation. This is one of the issues I try to fix with the current work-around PR: https://github.com/servo/rust-layers/pull/203 If anyone has a moment to review it, I would really appreciate it, by the way! :) --Martin ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo
Re: [dev-servo] Travis, Rust Nightlies & Aster
On 20/08/15 17:50, Ms2ger wrote: Hi all, Recently, homu has regularly rejected PRs to rust-layers because of a mismatch between the latest Rust nightly (which Travis uses by default), and Aster (which it depends on through euclid and serde_macros). This has been solved by locking the Rust nightly to a version that works with the latest version of Aster (at that point). However, when Aster is updated for the breaking changes in Rust, the build breaks again. Does anyone have ideas on how to avoid this issue in the future? If https://nightli.es/ or something like it is set up on aster and serde to notify of breaking changes in Rust Nightly and they are kept up-to-date then the problem is solved, isn’t it? Erickt has offered to give push access to some of us to help make this happen. I don’t mind doing it if nobody else wants to. -- Simon Sapin ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo
Re: [dev-servo] Travis, Rust Nightlies & Aster
That sounds doable. I'm open to helping maintain aster's nightlyness. -Manish Goregaokar On Thu, Aug 20, 2015 at 9:47 PM, Simon Sapin wrote: > On 20/08/15 17:50, Ms2ger wrote: > >> Hi all, >> >> Recently, homu has regularly rejected PRs to rust-layers because of a >> mismatch between the latest Rust nightly (which Travis uses by >> default), and Aster (which it depends on through euclid and >> serde_macros). This has been solved by locking the Rust nightly to a >> version that works with the latest version of Aster (at that point). >> However, when Aster is updated for the breaking changes in Rust, the >> build breaks again. >> >> Does anyone have ideas on how to avoid this issue in the future? >> > > If https://nightli.es/ or something like it is set up on aster and serde > to notify of breaking changes in Rust Nightly and they are kept up-to-date > then the problem is solved, isn’t it? > > Erickt has offered to give push access to some of us to help make this > happen. I don’t mind doing it if nobody else wants to. > > -- > Simon Sapin > > ___ > dev-servo mailing list > dev-servo@lists.mozilla.org > https://lists.mozilla.org/listinfo/dev-servo > ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo
Re: [dev-servo] PSA: import blocks are now sorted
On Thu, Aug 20, 2015 at 7:54 AM, Ms2ger wrote: > > Consecutive lines of imports are now sorted, thanks to Johann Tuffe. > test-tidy will complain about any violations. You're talking about `use` items, right? It looks like they're sorted within each group, but you can still have separate groups. (Where the boundary between a group is a blank line.) Is that right? Nick ___ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo
