On 08/20/2015 08:50 AM, Ms2ger wrote: > Hi all, > > Recently, homu has regularly rejected PRs to rust-layers because of a > mismatch between the latest Rust nightly (which Travis uses by > default), and Aster (which it depends on through euclid and > serde_macros). This has been solved by locking the Rust nightly to a > version that works with the latest version of Aster (at that point). > However, when Aster is updated for the breaking changes in Rust, the > build breaks again. > > Does anyone have ideas on how to avoid this issue in the future?
One possible solution is to ensure that serde requires a specific version of aster in its Cargo.toml, and that euclid, in turn, requires a specific version of serde in its Cargo.toml. Then we need to pin the rust nightly version in all of the packages that depend on euclid. Another option that we discussed via IRC is to have travis update to a precise version of aster in all crates that depend on euclid. We would also need to pin the rust nightly for this to work as well. It seems that no matter what we do, we will end up pinning the rust nightly in all crates. Even without this issue with aster, the rust nightly can break create compilation. This is one of the issues I try to fix with the current work-around PR: https://github.com/servo/rust-layers/pull/203 If anyone has a moment to review it, I would really appreciate it, by the way! :) --Martin _______________________________________________ dev-servo mailing list dev-servo@lists.mozilla.org https://lists.mozilla.org/listinfo/dev-servo
