Re: [apache/tvm] [VOTE] Release Apache TVM v0.9.0.rc0 (Issue #12103)
+1 -- Reply to this email directly or view it on GitHub: https://github.com/apache/tvm/issues/12103#issuecomment-1185493250 You are receiving this because you are subscribed to this thread. Message ID:
Re: [apache/tvm-rfcs] Add Target Pre-processing RFC (PR #71)
Actually, the target JSON only shows the name of the kind, so the target parser (if it operates on the JSON) won't see the details of the kind, unless they are included in the JSON. I think that expanding the contents of the target JSON to contain the kind specifics as well is critical for this feature to make sense. Please clarify of that's a part of the plan. -- Reply to this email directly or view it on GitHub: https://github.com/apache/tvm-rfcs/pull/71#issuecomment-1185647795 You are receiving this because you are subscribed to this thread. Message ID:
Re: [apache/tvm-rfcs] Add Target Features RFC (PR #78)
If we add another member to `Target`, how will this interact with the [target parser proposal](https://github.com/apache/tvm-rfcs/pull/71)? -- Reply to this email directly or view it on GitHub: https://github.com/apache/tvm-rfcs/pull/78#issuecomment-1185653525 You are receiving this because you are subscribed to this thread. Message ID:
Re: [apache/tvm-rfcs] Add Target Pre-processing RFC (PR #71)
> Actually, the target JSON only shows the name of the kind, so the target > parser (if it operates on the JSON) won't see the details of the kind, unless > they are included in the JSON. I think that expanding the contents of the > target JSON to contain the kind specifics as well is critical for this > feature to make sense. Please clarify of that's a part of the plan. Hi @kparzysz-quic, can you expand on what's missing here? According to https://discuss.tvm.apache.org/t/rfc-tvm-target-specification/6844, the Target JSON includes the `kind`, `attrs` and `keys`. -- Reply to this email directly or view it on GitHub: https://github.com/apache/tvm-rfcs/pull/71#issuecomment-1185688020 You are receiving this because you are subscribed to this thread. Message ID:
Re: [apache/tvm-rfcs] Add Target Features RFC (PR #78)
> If we add another member to `Target`, how will this interact with the [target
> parser proposal](https://github.com/apache/tvm-rfcs/pull/71)?
The hope is to use the target parser to parse out the features as it'd just be
an additional field we can set:
```c++
target_json.Set("features", features_map);
```
--
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/78#issuecomment-1185690255
You are receiving this because you are subscribed to this thread.
Message ID:
Re: [apache/tvm-rfcs] Add Target Pre-processing RFC (PR #71)
```C++
Map TargetNode::Export() const {
Map result = {
{"kind", this->kind->name},<
{"tag", this->tag},
{"keys", this->keys},
};
if (this->host.defined()) {
result.Set("host", this->GetHost().value_or(Target())->Export());
}
for (const auto& kv : attrs) {
result.Set(kv.first, kv.second);
}
return result;
}
```
--
Reply to this email directly or view it on GitHub:
https://github.com/apache/tvm-rfcs/pull/71#issuecomment-1185696517
You are receiving this because you are subscribed to this thread.
Message ID:
Re: [apache/tvm-rfcs] Add Target Pre-processing RFC (PR #71)
@kparzysz-quic, sorry, I'm still not understanding here - the name of the kind is enough to look it up in the kind registry and gather any kind-specific information. What further details are missing? -- Reply to this email directly or view it on GitHub: https://github.com/apache/tvm-rfcs/pull/71#issuecomment-1185744822 You are receiving this because you are subscribed to this thread. Message ID:
Re: [apache/tvm-rfcs] Add Target Pre-processing RFC (PR #71)
> @kparzysz-quic, sorry, I'm still not understanding here - the name of the > kind is enough to look it up in the kind registry and gather any > kind-specific information. What further details are missing? I thought the attrs were stored in the kind, but they are in the target itself. Nevermind. -- Reply to this email directly or view it on GitHub: https://github.com/apache/tvm-rfcs/pull/71#issuecomment-1185758537 You are receiving this because you are subscribed to this thread. Message ID:
Re: [apache/tvm-rfcs] [RFC] Create LLVM scope class for use with LLVM libraries (PR #83)
Should we still wait for review from Junru? -- Reply to this email directly or view it on GitHub: https://github.com/apache/tvm-rfcs/pull/83#issuecomment-1185759039 You are receiving this because you are subscribed to this thread. Message ID:
Re: [apache/tvm-rfcs] [RFC] Create LLVM scope class for use with LLVM libraries (PR #83)
I think we can go ahead and merge -- Reply to this email directly or view it on GitHub: https://github.com/apache/tvm-rfcs/pull/83#issuecomment-1185770803 You are receiving this because you are subscribed to this thread. Message ID:
Re: [apache/tvm-rfcs] [RFC] Create LLVM scope class for use with LLVM libraries (PR #83)
Merged #83 into main. -- Reply to this email directly or view it on GitHub: https://github.com/apache/tvm-rfcs/pull/83#event-7003735230 You are receiving this because you are subscribed to this thread. Message ID:
Re: [apache/tvm-rfcs] [RFC] Buffer Layout Padding (PR #77)
Merged #77 into main. -- Reply to this email directly or view it on GitHub: https://github.com/apache/tvm-rfcs/pull/77#event-7004931146 You are receiving this because you are subscribed to this thread. Message ID:
