Re: Offline generation of effective web.xml

[Violeta Georgieva]

Hi,

I've prepared the initial change for offline generation of effective
web.xml.
The change is in github:
https://github.com/violetagg/apache-tomcat-8.0/commits/master.
I have a few minor changes that I plan to do but before then I prefer to
get your opinion about the refactoring that I made and the change as a
whole.

Here is the list with the major changes that I did:
- The java objects that represent data structures for web.xml were moved
from o.a.catalina.deploy to o.a.tomcat.util.xml package.
- The web.xml parser functionality was moved to a new package -
o.a.tomcat.util.xml.parse
- The functionality that scans for web fragments was moved to a new package
- o.a.tomcat.util.xml.scanner
- The functionality that scans for annotations was moved to a new package -
o.a.tomcat.util.xml.processor
- Added functionality for offline generation of effective web.xml

I'm looking forward to your comments.

Regards
Violeta Georgieva

2012/9/11 Mark Thomas 

>
>
> Violeta Georgieva  wrote:
>
> >It would be very useful if I can provide this as part of the build
> >infrastructure for example.
> >If you can give me a hint from where to start I may try to provide a
> >patch
> >for 8.0.x? Wdyt?
>
> There is going to need to be a lot of refactoring for this. I'm not sure
> if a patch is the right way to go. Neither am I sure what the best way is.
> Maybe a git branch (e.g. on github) with a series of patches? I don't have
> enough experience with the git-svn integration to know if that would be
> easier or harder to deal with.
>
> In terms of what needs to be done:
> - the end result needs to be useable by both Jasper and Catalina - that
> pretty much means a new package and JAR under o.a.tomcat
> - Jasper cannot depend on Catalina (hence why everything needs to move
> packages)
> - the things that need to move to this new package
>- the web.xml parsing (i.e.the digester)
>- the annotation scanning
>- the SCI scanning
>- the merging
>- the object representation of web.xml
> - switch everything over to the new implementation
>
> This is a big change but most of it is just moving stuff around. It isn't
> changing functionality (well it is - JspC would process fragments which it
> doesn't currently for example but all the functional changes would be
> improvements of this nature)
>
> I suggest making a proposal to the dev list. If that gets support, I'd be
> happy to help with this. I suspect in that case a series of svn moves and
> patches would follow.
>
> Mark
>
> -
> To unsubscribe, e-mail: users-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: users-h...@tomcat.apache.org
>
>

Re: Offline generation of effective web.xml

[Violeta Georgieva]

Hi Mark,

> OK. First question. How did you create your git repo? I am trying to add
> your repo as a remote repo to my own but there are no common ancestors.
> I think I can hack around this but I'd like to understand how it
> happened in the first place.
>

I'm using "git svn".
The last rebase that I made was 11 days ago. Commit id
8f6de1068cd1299f34ae4171e941998b9752c07a

Fix

https://issues.apache.org/bugzilla/show_bug.cgi?id=54170… 

Ensure correct registration of Filters and Servlets in the JMX
registry if the Filter or Servlet name includes a character that must
be quoted if used in an ObjectName value.

git-svn-id: http://svn.apache.org/repos/asf/tomcat/trunk@1412575
13f79535-47bb-0310-9956-ffa450edef68


This migth be the problem - if your repo contains the newest commits.
Isn't it easier to clone the repo?
I also can update it to the latest revision.

Thanks and Regards
Violeta

Re: Offline generation of effective web.xml

[Violeta Georgieva]

>
> From which git repository? I couldn't find that commit ID in the ASF git
> repo for Tomcat trunk nor the GitHub mirror.


Ok I understood where the missunderstanding is.
That repo (in my github profile) is my own git-to-svn repo and is not a
fork from the one available in github.
Having my own git-to-svn repo I can control when I can do a rebase from svn.


> I have already fixed it on my local machine with git replace to graft
> your changes onto my local fork of the ASF git repo for Tomcat trunk. It
> should be easy to merge in your changes from there.
>

In order to escape such problems in the future I forked the official Tomcat
git repo in github and applied my changes there.
Here is the new link: https://github.com/violetagg/tomcat.git
Hope this time it will work without issues.


Unfortunately not all tests are passing now on this repo. I have

java.lang.NullPointerException
 at
org.apache.tomcat.websocket.ServerContainerImpl.addWsServletMapping(ServerContainerImpl.java:162)
 at
org.apache.tomcat.websocket.ServerContainerImpl.publishServer(ServerContainerImpl.java:119)
 at
websocket.echo.WsConfigListener.contextInitialized(WsConfigListener.java:33)
...

I don't know whether we should discuss it here or to start a new thread
because I think that in

org.apache.tomcat.websocket.ServerContainerImpl.publishServer(Class clazz)

We should have the same check for ServletContext availability as in

org.apache.tomcat.websocket.ServerContainerImpl.publishServer(Class
pojo, ServletContext ctxt, String path)

Regards
Violeta

Re: [VOTE] Release Apache Tomcat 8.0.27

[Violeta Georgieva]

Hi,

2015-09-28 14:26 GMT+03:00 Mark Thomas :
>
> The proposed Apache Tomcat 8.0.27 release is now available for voting.
>
> The main changes since 8.0.26 are:
>
> - Correctly handle \${ vs \$ escaping in JSP and EL
>
> - Fix for issues with NIO + SSL + sendfile
>
> - Various TLD parsing fixes
>
> - Fix multiple (mostly rare and/or zero impact) concurrency issues
>
>
> Note: Due to an issues with the Symantec code signing service (the
>   certificates used to access the web-based admin GUI have all
>   expired and infra is having to jump through some hoops to get
>   new ones issues) the Windows Installer package has NOT been
>   signed for this release.
>
> There is the usual collection of bug fixes, new features and
> performance improvements. For full details, see the changelog:
>
http://svn.us.apache.org/repos/asf/tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.27/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1051/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_27/
>
> The proposed 8.0.27 release is:
> [ ] Broken - do not release
> [ ] Stable - go ahead and release as 8.0.27

I have the following use case [1]. It used to be working with the previous
version (8.0.26).

Now it fails with the following [2].

I didn't find in the spec whether this is allowed or not :( however the
exception is bad.

Regards,
Violeta

[1]

Index: org/apache/el/TestELInJsp.java
===
--- org/apache/el/TestELInJsp.java (revision 1705912)
+++ org/apache/el/TestELInJsp.java (working copy)
@@ -318,6 +318,7 @@
 assertEcho(result, "20-4");
 assertEcho(result, "21-[{value=11}, {value=12}, {value=13},
{value=14}]");
 assertEcho(result, "22-[{value=11}, {value=12}, {value=13},
{value=14}]");
+assertEcho(result, "23-\\\"foo\\\"");
 }

 @Test
Index: webapp/el-misc.jsp
===
--- webapp/el-misc.jsp (revision 1705912)
+++ webapp/el-misc.jsp (working copy)
@@ -41,4 +41,5 @@
 20-${{1,2,3,4}.stream().max().orElse(-1)}
 

 22-${{1,2,3,4}.stream().sorted().map(u->{"value":u+10}).toList()}
 
+
 
\ No newline at end of file

[2]

 org.apache.catalina.core.StandardWrapperValve.invoke Servlet.service() for
servlet [jsp] in context with path [/test] threw exception [/el-misc.jsp
(line: 44, column: 21) attribute for " is not properly terminated] with
root cause
 org.apache.jasper.JasperException: /el-misc.jsp (line: 44, column: 21)
attribute for " is not properly terminated
at
org.apache.jasper.compiler.DefaultErrorHandler.jspError(DefaultErrorHandler.java:41)
at
org.apache.jasper.compiler.ErrorDispatcher.dispatch(ErrorDispatcher.java:275)
at
org.apache.jasper.compiler.ErrorDispatcher.jspError(ErrorDispatcher.java:91)
at org.apache.jasper.compiler.Parser.parseAttributeValue(Parser.java:270)
at org.apache.jasper.compiler.Parser.parseAttribute(Parser.java:235)
at org.apache.jasper.compiler.Parser.parseAttributes(Parser.java:163)
at org.apache.jasper.compiler.Parser.parseAttributes(Parser.java:154)
at org.apache.jasper.compiler.Parser.parseCustomTag(Parser.java:1236)
at org.apache.jasper.compiler.Parser.parseElements(Parser.java:1455)
at org.apache.jasper.compiler.Parser.parse(Parser.java:139)
at
org.apache.jasper.compiler.ParserController.doParse(ParserController.java:227)


> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

Re: [VOTE] Release Apache Tomcat 8.0.27

[Violeta Georgieva]

2015-09-29 22:48 GMT+03:00 Mark Thomas :
>
> On 29/09/2015 20:37, Violeta Georgieva wrote:
> > 2015-09-28 14:26 GMT+03:00 Mark Thomas :
>
> 
>
> >> The proposed 8.0.27 release is:
> >> [ ] Broken - do not release
> >> [ ] Stable - go ahead and release as 8.0.27
> >
> > I have the following use case [1]. It used to be working with the
previous
> > version (8.0.26).
> >
> > Now it fails with the following [2].
>
> This looks to be caused by the changes for BZ 57316.
>
> > I didn't find in the spec whether this is allowed or not :( however the
> > exception is bad.
>
> In what way? The JSP isn't valid so you are getting an exception.
>
> More comments in-line.
>
> >
> > Regards,
> > Violeta
> >
> > [1]
> >
> > Index: org/apache/el/TestELInJsp.java
> > ===
> > --- org/apache/el/TestELInJsp.java (revision 1705912)
> > +++ org/apache/el/TestELInJsp.java (working copy)
> > @@ -318,6 +318,7 @@
> >  assertEcho(result, "20-4");
> >  assertEcho(result, "21-[{value=11}, {value=12}, {value=13},
> > {value=14}]");
> >  assertEcho(result, "22-[{value=11}, {value=12}, {value=13},
> > {value=14}]");
> > +assertEcho(result, "23-\\\"foo\\\"");
> >  }
> >
> >  @Test
> > Index: webapp/el-misc.jsp
> > ===
> > --- webapp/el-misc.jsp (revision 1705912)
> > +++ webapp/el-misc.jsp (working copy)
> > @@ -41,4 +41,5 @@
> >  20-${{1,2,3,4}.stream().max().orElse(-1)}
> >   >
echo='21-${{1,2,3,4}.stream().sorted().map(u->{"value":u+10}).toList()}' />
> >
> >
 22-${{1,2,3,4}.stream().sorted().map(u->{"value":u+10}).toList()}
> >  
> > +
>
> This is a good example of where things get interesting. The above line
> is parsed as follows:
>
>
> which is parsed with the EL spec and then
>
> }" />
>
> is parsed with the JSP spec again.
>
> The problem is in the EL section. You are trying to define a literal so
> you do not want to escape the initial and final " characters. By
> escaping them you are making them part of the String literal which means
> you have an EL expression containing just a literal which is missing the
> mandatory quotes.
>
>
> >  
> > \ No newline at end of file
> >
> > [2]
> >
> >  org.apache.catalina.core.StandardWrapperValve.invoke Servlet.service()
for
> > servlet [jsp] in context with path [/test] threw exception [/el-misc.jsp
> > (line: 44, column: 21) attribute for " is not properly terminated] with
> > root cause
> >  org.apache.jasper.JasperException: /el-misc.jsp (line: 44, column: 21)
> > attribute for " is not properly terminated
>
> Ah. When you say the exception is bad do you mean it should report
> [echo] rather than ["] in the error message above? That does seem like a
> reasonable requirement.

Yep the exception should give more information

> So far, I haven't seen anything that I think is serious enough to stop
> the 8.0.27 release.

Agree. As I wrote I didn't find anything in the spec, but I was not sure
whether I miss something or not.
Now as you also pointed that this is wrong I think that the exception
message can be changed in the next release and we can continue with voting.

Here is my +1

> Mark
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

Time for 7.0.65

[Violeta Georgieva]

Hi,

I'm planning to start preparation for 7.0.65.
If you need to add something please reply here.

Regards,
Violeta

Re: [VOTE] Release Apache Tomcat 8.0.28

[Violeta Georgieva]

Hi,

2015-10-07 22:13 GMT+03:00 Mark Thomas :
>
> The proposed Apache Tomcat 8.0.28 release is now available for voting.
>
> The main changes since 8.0.27 are:
>
> - Allow file based configuration resources (e.g. key stores) to be
>   configured using URLs
>
> - Restore code signing to the Windows installer an uninstaller
>
> There is a smaller that usual collection of bug fixes, new features and
> performance improvements. For full details, see the changelog:
>
http://svn.us.apache.org/repos/asf/tomcat/tc8.0.x/trunk/webapps/docs/changelog.xml
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.28/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1052/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_28/
>
> The proposed 8.0.28 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 8.0.28

Checked with applications that use the new specifications features -
successful.
Tested Tomcat in OSGi environment - successful.

Regards,
Violeta

> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

[VOTE] Release Apache Tomcat 7.0.65

[Violeta Georgieva]

The proposed Apache Tomcat 7.0.65 release is now available for voting.

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.65/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1053/
The svn tag is:
http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_65/

The proposed 7.0.65 release is:
[ ] Broken - do not release
[ ] Stable - go ahead and release as 7.0.65 Stable

Regards,
Violeta

Re: [VOTE] Release Apache Tomcat 7.0.65

[Violeta Georgieva]

2015-10-09 14:04 GMT+03:00 Violeta Georgieva :
>
> The proposed Apache Tomcat 7.0.65 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.65/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1053/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_65/
>
> The proposed 7.0.65 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 7.0.65 Stable

Tested Tomcat in OSGi environment - successful.
Basic performance tests - successful.

> Regards,
> Violeta

CSRF prevention filter for REST

[Violeta Georgieva]

Hi,

I would like to provide such a filter as part of the default Tomcat filters
[1].
My plan is to extract the common functionality from the current
CsrfPreventionFIlter in a base class and then to use this functionality in
both CsrfPreventionFilter and the new filter which will be for REST.
I will provide the functionality in trunk so that you will be able to
review it and give me a feedback.

Regards,
Violeta

[1] http://marc.info/?t=13482586931&r=1&w=2

Re: [GUMP@vmgump]: Project tomcat-trunk-test-apr (in module tomcat-trunk) failed

[Violeta Georgieva]

Hi,

2015-10-19 15:55 GMT+03:00 Mark Thomas :
>
> On 19/10/2015 13:43, Konstantin Kolinko wrote:
> > 2015-10-19 14:16 GMT+03:00 Mark Thomas :
> >> On 17/10/2015 15:54, Konstantin Kolinko wrote:
> >>> 2015-10-17 10:48 GMT+03:00 Bill Barker :
>  To whom it may engage...
> 
>  This is an automated request, but not an unsolicited one. For
>  more information please visit http://gump.apache.org/nagged.html,
>  and/or contact the folk at gene...@gump.apache.org.
> 
>  Project tomcat-trunk-test-apr has an issue affecting its community
integration.
>  This issue affects 1 projects,
>   and has been outstanding for 23 runs.
>  The current state of this project is 'Failed', with reason 'Build
Timed Out'.
>  For reference only, the following projects are affected by this:
>  - tomcat-trunk-test-apr :  Tomcat 9.x, a web server implementing
the Java Servlet 4.0,
>  ...
> 
> 
>  Full details are available at:
> 
http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-apr/index.html
> 
>  That said, some information snippets are provided here.
> 
>  The following annotations (debug/informational/warning/error
messages) were provided:
>   -DEBUG- Dependency on commons-daemon exists, no need to add for
property commons-daemon.native.src.tgz.
>   -DEBUG- Dependency on commons-daemon exists, no need to add for
property tomcat-native.tar.gz.
>   -INFO- Failed with reason build timed out
>   -INFO- Project Reports in:
/srv/gump/public/workspace/tomcat-trunk/output/logs-APR
>   -INFO- Project Reports in:
/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-APR/logs
>   -WARNING- No directory
[/srv/gump/public/workspace/tomcat-trunk/output/test-tmp-APR/logs]
> 
> 
> 
>  The following work was performed:
> 
http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-test-apr/gump_work/build_tomcat-trunk_tomcat-trunk-test-apr.html
>  Work Name: build_tomcat-trunk_tomcat-trunk-test-apr (Type: Build)
>  Work ended in a state of : Failed
>  Elapsed: 1 hour 1 sec
> >>>
> >>> From stdout output, testing started at 06:49
> >>> The tail of stdout is cited below. The times are around 07:11. The
> >>> last test name mentioned is
> >>>
> >>> Running org.apache.coyote.http11.filters.TestChunkedInputFilter
> >>> ...
> >>> org.apache.catalina.startup.LoggingBaseTest.setUp Starting test case
> >>> [testChunkSizeLong]
> >>>
> >>> Apparently it hung after that and was killed 35 minutes later.
> >>
> >> The last few runs have consistently failed at the same place.
> >>
> >> Can anyone reproduce this locally? (I haven't tried yet.)
> >
> >
> > An idea: maybe add  a StuckThreadDetectionValve into configuration of
that test?
> > My expectation is that it will print a stacktrace of the hanging
> > thread so that we have a clue where the hang is.
>
> No need. I can repeat this locally (OSX, APR 1.6.0, OpenSSL 1.0.2d,
> native 1.2.0-dev).
>
> The problem is occurring when trying to swallow the input that isn't
> there. I want to go back through the mail archives to see if I can find
> when this started to fail. Hopefully that will point me in the direction
> of the change that triggered this.
>
> > Trunk/Nio2 today failed at
> >
> >[concat] Testsuites with failed tests:
> >[concat] TEST-org.apache.coyote.http2.TestHttp2Section_5_3.NIO2.txt
> >[concat]
TEST-org.apache.tomcat.websocket.TestWebSocketFrameClientSSL.NIO2.txt
> >
> >
> > In TEST-org.apache.coyote.http2.TestHttp2Section_5_3.NIO2:
> >
> > Testcase: testWeighting took 10.618 sec
> > FAILED
> > Larger than expected body: [21-Body-5
>
> OK. I think that is a problem with the test. I probably have some more
> work to do on that one.
>
>
> > In TEST-org.apache.tomcat.websocket.TestWebSocketFrameClientSSL.NIO2:
>
> That isn't particularly new is it? I think we have been seeing failures
> with that on and off for a while.

On my side I have the following failures:

[concat] Testsuites with failed tests:
[concat] TEST-org.apache.coyote.http11.TestHttp11InputBuffer.NIO2.txt
[concat] TEST-org.apache.coyote.http11.filters.APR.txt
[concat] TEST-org.apache.coyote.http11.filters.NIO.txt
[concat] TEST-org.apache.coyote.http11.filters.NIO2.txt
[concat] TEST-org.apache.tomcat.websocket.TestWebSocketFrameClient.APR.txt

Windows 8, jdk1.8.0_45

Regards,
Violeta

> Mark
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

Re: [RESULT][VOTE] Release Apache Tomcat 7.0.65

[Violeta Georgieva]

Hi,

2015-10-09 14:04 GMT+03:00 Violeta Georgieva :
>
> The proposed Apache Tomcat 7.0.65 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.65/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1053/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_65/
>
> The proposed 7.0.65 release is:
> [ ] Broken - do not release
> [ ] Stable - go ahead and release as 7.0.65 Stable

+1 (binding):   rjung, violetagg, keith
+1 (non-binding):   fschumacher, Martin Grigorov

No other voters were cast.

The vote has passed.

I'll do the release shortly and announce it once the mirrors catch up.

> Regards,
> Violeta

[ANN] Apache Tomcat 7.0.65 released

[Violeta Georgieva]

The Apache Tomcat team announces the immediate availability of Apache
Tomcat 7.0.65.

Apache Tomcat is an open source software implementation of the Java
Servlet, JavaServer Pages, Java Expression Language and Java
WebSocket technologies.

This release contains a number of bug fixes and improvements compared to
version 7.0.64. The notable changes since 7.0.64 include:


- Add a web application class loader implementation that supports the
parallel
  loading of web application classes. Use of this feature requires a Java 7
or
  later JRE


Please refer to the change log for the complete list of changes:
http://tomcat.apache.org/tomcat-7.0-doc/changelog.html

Note: This version has 4 zip binaries: a generic one and
  three bundled with Tomcat native binaries for Windows operating
  systems running on different CPU architectures.

Note: Use of the Java WebSocket 1.1 implementation requires Java 7.

Note: If you use the APR/native AJP or HTTP connector you *must* upgrade
  to version 1.1.33 or later of the APR/native library.

Downloads:
http://tomcat.apache.org/download-70.cgi

Migration guides from Apache Tomcat 5.5.x and 6.0.x:
http://tomcat.apache.org/migration.html

Enjoy

The Apache Tomcat team

Re: [GUMP@vmgump]: Project tomcat-trunk-validate (in module tomcat-trunk) failed

[Violeta Georgieva]

2015-10-22 6:25 GMT+03:00 Bill Barker :
>
> To whom it may engage...
>
> This is an automated request, but not an unsolicited one. For
> more information please visit http://gump.apache.org/nagged.html,
> and/or contact the folk at gene...@gump.apache.org.
>
> Project tomcat-trunk-validate has an issue affecting its community
integration.
> This issue affects 1 projects,
>  and has been outstanding for 2 runs.
> The current state of this project is 'Failed', with reason 'Build Failed'.
> For reference only, the following projects are affected by this:
> - tomcat-trunk-validate :  Tomcat 9.x, a web server implementing the
Java Servlet 4.0,
> ...
>
>
> Full details are available at:
>
http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/index.html
>
> That said, some information snippets are provided here.
>
> The following annotations (debug/informational/warning/error messages)
were provided:
>  -DEBUG- Dependency on checkstyle exists, no need to add for property
checkstyle.jar.
>  -INFO- Failed with reason build failed
>
>
>
> The following work was performed:
>
http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/gump_work/build_tomcat-trunk_tomcat-trunk-validate.html
> Work Name: build_tomcat-trunk_tomcat-trunk-validate (Type: Build)
> Work ended in a state of : Failed
> Elapsed: 1 min 47 secs
> Command Line: /usr/lib/jvm/java-8-oracle/bin/java
-Djava.awt.headless=true -Dbuild.sysclasspath=only
org.apache.tools.ant.Main -Dgump.merge=/srv/gump/public/gump/work/merge.xml
-Dcheckstyle.jar=/srv/gump/public/workspace/checkstyle/target/checkstyle-6.12-SNAPSHOT.jar
-Dexecute.validate=true validate
> [Working Directory: /srv/gump/public/workspace/tomcat-trunk]
> CLASSPATH:
/usr/lib/jvm/java-8-oracle/lib/tools.jar:/srv/gump/public/workspace/ant/dist/lib/ant.jar:/srv/gump/public/workspace/ant/dist/lib/ant-launcher.jar:/srv/gump/public/workspace/ant/dist/lib/ant-jmf.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit.jar:/srv/gump/public/workspace/ant/dist/lib/ant-junit4.jar:/srv/gump/public/workspace/ant/dist/lib/ant-swing.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-resolver.jar:/srv/gump/public/workspace/ant/dist/lib/ant-apache-xalan2.jar:/srv/gump/public/workspace/xml-commons/java/build/resolver.jar:/srv/gump/public/workspace/checkstyle/target/checkstyle-6.12-SNAPSHOT.jar:/srv/gump/packages/antlr/antlr-3.1.3.jar:/srv/gump/public/workspace/apache-commons/beanutils/dist/commons-beanutils-20151022.jar:/srv/gump/packages/commons-collections3/commons-collections-3.2.1.jar:/srv/gump/public/workspace/apache-commons/cli/target/commons-cli-1.4-SNAPSHOT.jar:/srv/gump/public/workspace/commons-lang-trunk/target/commons-lang3-3.5-SNAPSHOT.ja
>
 
r:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-20151022.jar:/srv/gump/public/workspace/apache-commons/logging/target/commons-logging-api-20151022.jar:/srv/gump/packages/guava/guava-18.0.jar
> -
> Buildfile: /srv/gump/public/workspace/tomcat-trunk/build.xml
>
> build-prepare:
>[delete] Deleting directory
/srv/gump/public/workspace/tomcat-trunk/output/build/temp
> [mkdir] Created dir:
/srv/gump/public/workspace/tomcat-trunk/output/build/temp
>
> compile-prepare:
>
> download-validate:
>
> testexist:
>  [echo] Testing  for
/srv/gump/public/workspace/checkstyle/target/checkstyle-6.12-SNAPSHOT.jar
>
> setproxy:
>
> downloadfile:
>
> validate:
> [mkdir] Created dir:
/srv/gump/public/workspace/tomcat-trunk/output/res/checkstyle
> [checkstyle] Running Checkstyle 6.12-SNAPSHOT on 3067 files
> [checkstyle]
/srv/gump/public/workspace/tomcat-trunk/webapps/docs/config/filter.xml:368:
error: Line matches the illegal pattern '\s+#39;.
> [checkstyle]
/srv/gump/public/workspace/tomcat-trunk/webapps/docs/config/filter.xml:411:
error: Line matches the illegal pattern '\s+#39;.
>

That was me ...
I'll fix it in a minute

Regards,
Violeta

> BUILD FAILED
> /srv/gump/public/workspace/tomcat-trunk/build.xml:549: Got 2 errors and 0
warnings.
>
> Total time: 1 minute 46 seconds
> -
>
> To subscribe to this information via syndicated feeds:
> - RSS:
http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/rss.xml
> - Atom:
http://vmgump.apache.org/gump/public/tomcat-trunk/tomcat-trunk-validate/atom.xml
>
> == Gump Tracking Only ===
> Produced by Apache Gump(TM) version 2.3.
> Gump Run 2015102208, vmgump.apache.org:vmgump:2015102208
> Gump E-mail Identifier (unique within run) #10.
>
> --
> Apache Gump
> http://gump.apache.org/ [Instance: vmgump]
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

Re: [ANN] New committer: Ognjen Blagojevic

[Violeta Georgieva]

2015-10-24 16:58 GMT+03:00 Mark Thomas :
>
> On behalf of the Tomcat committers I am pleased to announce that
> Ognjen Blagojevic (ognjen) has been voted in as a new Tomcat committer.
>
> Please join me in welcoming him.

Welcome!

Regards,
Violeta

> Regards,
>
> Mark
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

Re: svn commit: r1710445 - /tomcat/trunk/java/org/apache/tomcat/util/file/ConfigFileLoader.java

[Violeta Georgieva]

2015-10-25 16:09 GMT+02:00 Konstantin Kolinko :
>
> 2015-10-25 16:40 GMT+03:00  :
> > Author: markt
> > Date: Sun Oct 25 13:40:52 2015
> > New Revision: 1710445
> >
> > URL: http://svn.apache.org/viewvc?rev=1710445&view=rev
> > Log:
> > https://bz.apache.org/bugzilla/show_bug.cgi?id=58518
> > Fix a regression in BZ 56777 (that added support for URIs in config file
> > locations)
> > File paths on Windows could previously be specified with \ or / as the
> > separator. BZ 56777 broke that. This commit restores that behaviour.
> >
> > Modified:
> > tomcat/trunk/java/org/apache/tomcat/util/file/ConfigFileLoader.java
> >
> > Modified:
tomcat/trunk/java/org/apache/tomcat/util/file/ConfigFileLoader.java
> > URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/file/ConfigFileLoader.java?rev=1710445&r1=1710444&r2=1710445&view=diff
> >
==
> > --- tomcat/trunk/java/org/apache/tomcat/util/file/ConfigFileLoader.java
(original)
> > +++ tomcat/trunk/java/org/apache/tomcat/util/file/ConfigFileLoader.java
Sun Oct 25 13:40:52 2015
> > @@ -30,11 +30,12 @@ import java.net.URL;
> >   */
> >  public class ConfigFileLoader {
> >
> > +private static final File CATALINA_BASE_FILE;
> >  private static final URI CATALINA_BASE_URI;
> >
> >  static {
> > -File catalinaBase = new
File(System.getProperty("catalina.base"));
> > -CATALINA_BASE_URI = catalinaBase.toURI();
> > +CATALINA_BASE_FILE = new
File(System.getProperty("catalina.base"));
> > +CATALINA_BASE_URI = CATALINA_BASE_FILE.toURI();
> >  }
> >
> >  private ConfigFileLoader() {
> > @@ -59,17 +60,30 @@ public class ConfigFileLoader {
> >  // Absolute URIs will be left alone
> >  // Relative files will be resolved relative to catalina base
> >  // Absolute files will be converted to URIs
> > -URI uri;
> > -if (location != null &&
> > -(location.length() > 2 &&
":\\".equals(location.substring(1, 3)) ||
> > -location.startsWith(""))) {
> > -// This is an absolute file path in Windows or a UNC path
> > -File f = new File(location);
> > -uri =f.getAbsoluteFile().toURI();
> > -} else {
> > -// URL, relative path or an absolute path on a non-Windows
platforms
> > +
> > +URI uri = null;
> > +
> > +// Location was originally always a file before URI support
was added so
> > +// try file first.
> > +
> > +// First guess, an absolute file path
> > +File f = new File(location);
> > +if (!f.isFile()) {
> > +// Second guess, a file path relative to CATALINA_BASE
> > +if (!f.isAbsolute()) {
> > +f = new File(CATALINA_BASE_FILE, location);
> > +}
> > +}
> > +if (f.isFile()) {
> > +uri = f.getAbsoluteFile().toURI();
> > +}
> > +
> > +if (uri == null) {
> > +// Third and final guess, a URI
> >  uri = CATALINA_BASE_URI.resolve(location);
> >  }
> > +
> > +// Obtain the input stream we need
> >  URL url = uri.toURL();
> >  return url.openConnection().getInputStream();
> >  }
>
>
> This implementation is OK, but performs a bit more work than necessary.
>
> 1) Calling isFile() twice -> accessing hard drive twice
> 2) Conversion File -> URI -> URL -> parsing a file: URL -> ...  just
> to open an InputStream for a known File.

I also have problems with spaces in the path
java.lang.IllegalArgumentException: Illegal character in path at index 12:
c:/...
at java.net.URI.create(URI.java:859)
at java.net.URI.resolve(URI.java:1043)
at
org.apache.tomcat.util.file.ConfigFileLoader.getInputStream(ConfigFileLoader.java:83)

> Maybe add some debug logging to print out what location for the config
> file was actually used.
>
> Best regards,
> Konstantin Kolinko
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

Re: CSRF prevention filter for REST

[Violeta Georgieva]

Hi,

2015-10-14 21:39 GMT+03:00 Violeta Georgieva :
>
> Hi,
>
> I would like to provide such a filter as part of the default Tomcat
filters [1].
> My plan is to extract the common functionality from the current
CsrfPreventionFIlter in a base class and then to use this functionality in
both CsrfPreventionFilter and the new filter which will be for REST.
> I will provide the functionality in trunk so that you will be able to
review it and give me a feedback.

I plan to back-port this feature in Tomcat 7/8.

Regards,
Violeta
>
> [1] http://marc.info/?t=13482586931&r=1&w=2

Re: [VOTE] Release Apache Tomcat Native 1.2.0

[Violeta Georgieva]

2015-10-22 13:47 GMT+03:00 Mark Thomas :
>
> Version 1.2.0 includes the following changes:
> - Windows binaries built with APR 1.5.1 and OpenSSL 1.0.2d
> - ALPN support
>
> The proposed release artefacts can be found at [1],
> and the build was done using tag [2].
>
> The Apache Tomcat Native 1.2.0 is
>  [X] Stable, go ahead and release
>  [ ] Broken because of ...

+1

Regards,
Violeta

>  [1]
>
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-connectors/native/1.2.0/
>  [2]
> https://svn.apache.org/repos/asf/tomcat/native/tags/TOMCAT_NATIVE_1_2_0
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

Re: [VOTE] Switch 6.0.x from RTC to CTR

[Violeta Georgieva]

2015-10-29 0:42 GMT+02:00 Mark Thomas :
>
> All,
>
> Many years ago, we switched all release branches to RTC primarily to
> address a community problem where we could not agree on the best way
> forward for some parts of the code.
>
> RTC served us well. The disagreements ceased pretty much instantly.
> However, RTC also slowed us down.
>
> The development of 7.0.x started as CTR with a possibility of switching
> to RTC if necessary. It never was. We chose not to switch 7.0.x to RTC
> because the community issues that made RTC necessary had been solved and
> RTC added unnecessary overhead and delay. 8.0.x and now 9.0.x progressed
> the same way. Today, only 6.0.x is RTC.
>
> I believe the use of RTC for 6.0.x is causing more harm than good. There
> are fixes I don't propose for backport to 6.0.x because of the extra
> hassle RTC introduces. I suspect others take a similar approach judging
> on the number of fixes that don't make it back to 6.0.x.
>
> I would therefore like to propose that we switch the 6.0.x release
> branch from RTC to CTR and am therefore calling a VOTE to make this
change.
>
> [ ] Continue to use RTC for 6.0.x
> [X] Switch 6.0.x to CTR

Regards,
Violeta

> Thanks,
>
> Mark
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

Re: [VOTE] Release Apache Tomcat Native 1.2.1

[Violeta Georgieva]

2015-11-03 15:05 GMT+02:00 Mark Thomas :
>
> On 03/11/2015 12:31, Konstantin Kolinko wrote:
>
> > Interim results.  Testing 7.0.x (@r1712220) with Java 8u66 (32-bit)
> >
> >[concat] Testsuites with failed tests:
> >[concat]
TEST-org.apache.catalina.authenticator.TestNonLoginAndBasicAuthenticator.APR.txt
> >[concat]
TEST-org.apache.catalina.authenticator.TestSSOnonLoginAndBasicAuthenticator.APR.txt
> >[concat]
TEST-org.apache.catalina.authenticator.TestSSOnonLoginAndDigestAuthenticator.APR.txt
> >[concat]
TEST-org.apache.tomcat.websocket.TestWebSocketFrameClientSSL.APR.txt
> >[concat]
TEST-org.apache.tomcat.websocket.TestWsWebSocketContainer.APR.txt
> >
> > 1) All 3 authenticator tests are failing in an odd way:
>
> I can't repeat this.

This was reported also during 7.0.65 voting [1]

Unfortunately I also cannot reproduce it.

Windows 8, x64, jdk 1.8.0_45
Loaded APR based Apache Tomcat Native library 1.2.1 using APR version 1.5.1.
OpenSSL successfully initialized (OpenSSL 1.0.2d 9 Jul 2015)

[1] http://marc.info/?l=tomcat-dev&m=144554705426625&w=2


>
> > 2) org.apache.tomcat.websocket.TestWebSocketFrameClientSSL
> >
> > An odd "SKIPPED" line and a failed test.
>
> Fixed as you suggested.
>
> > Testcase: testConnectToServerEndpointSSL took 63,823 sec
> > FAILED
> > expected:<10> but was:<0>
> > junit.framework.AssertionFailedError: expected:<10> but was:<0>
> > at
org.apache.tomcat.websocket.TestWebSocketFrameClientSSL.testConnectToServerEndpointSSL(TestWebSocketFrameClientSSL.java:92)
>
> I see this error. I'll take a look.
>
> > 3) org.apache.tomcat.websocket.TestWsWebSocketContainer
> >
> > Testcase: testConnectToServerEndpointSSL took 10,852 sec
> > FAILED
> > null
> > junit.framework.AssertionFailedError
> > at
org.apache.tomcat.websocket.TestWsWebSocketContainer.testConnectToServerEndpointSSL(TestWsWebSocketContainer.java:815)
>
> I see this error too.
>
> Mark
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

Re: [VOTE] Release Apache Tomcat Native 1.2.2

[Violeta Georgieva]

Hi,

2015-11-04 22:15 GMT+02:00 Mark Thomas :
>
> OK. Here we go again :)
>
> Thanks to everyone who has helped test 1.2.x so far. I'm hopeful that
> this one will be good enough for the 9.0.0 RCs and - fingers crossed -
> to replace 1.1.x as well.
>
> Version 1.2.2 includes the following changes:
> - Forward port some OpenSSL I/O changes from 1.1.x that fixed a
>   number of unit tests failures
>
> The proposed release artefacts can be found at [1],
> and the build was done using tag [2].
>
> The Apache Tomcat Native 1.2.2 is
>  [ ] Stable, go ahead and release
>  [ ] Broken because of ...

Websocket examples are not working:
https://localhost:8443/examples/websocket/index.xhtml

Stockticker never ends
https://localhost:8443/examples/async/stockticker

If I access them through *http* everything is OK.

Windows 8, jdk 1.8.0_66, Tomcat 9 trunk
Loaded APR based Apache Tomcat Native library 1.2.2 using APR version 1.5.1.
OpenSSL successfully initialized (OpenSSL 1.0.2d 9 Jul 2015)








localhost-key.pem, localhost-cert.pem copied from tests.


Also I experience the exceptions below while testing examples.

06-Nov-2015 14:55:57.469 SEVERE [https-apr-8443-exec-2]
org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process Error
reading request, ignored
 java.lang.IllegalStateException
at
org.apache.coyote.http2.Http2UpgradeHandler.fill(Http2UpgradeHandler.java:1064)
at
org.apache.coyote.http2.Http2Parser$Input.fill(Http2Parser.java:565)
at
org.apache.coyote.http2.Http2Parser.readConnectionPreface(Http2Parser.java:519)
at
org.apache.coyote.http2.Http2UpgradeHandler.init(Http2UpgradeHandler.java:233)
at
org.apache.coyote.http2.Http2UpgradeHandler.upgradeDispatch(Http2UpgradeHandler.java:281)
at
org.apache.coyote.http11.upgrade.UpgradeProcessorInternal.dispatch(UpgradeProcessorInternal.java:55)
at
org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:56)
at
org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:738)
at
org.apache.tomcat.util.net.AprEndpoint$SocketProcessor.run(AprEndpoint.java:2296)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
at
org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
at java.lang.Thread.run(Thread.java:745)

06-Nov-2015 15:00:47.252 INFO [Ticker Thread]
org.apache.coyote.AbstractProcessor.setErrorState An error occurred in
processing while on a non-container thread.
 The connection will be closed immediately
 java.io.IOException: Connection [1], Stream [51], This stream is not
writable
at
org.apache.coyote.http2.Http2UpgradeHandler.reserveWindowSize(Http2UpgradeHandler.java:669)
at
org.apache.coyote.http2.Stream$StreamOutputBuffer.flush(Stream.java:495)
at
org.apache.coyote.http2.Stream$StreamOutputBuffer.flush(Stream.java:462)
at org.apache.coyote.http2.Stream.flushData(Stream.java:266)
at
org.apache.coyote.http2.StreamProcessor.action(StreamProcessor.java:131)
at org.apache.coyote.Response.action(Response.java:167)
at
org.apache.catalina.connector.OutputBuffer.doFlush(OutputBuffer.java:334)
at
org.apache.catalina.connector.OutputBuffer.flush(OutputBuffer.java:302)
at
org.apache.catalina.connector.CoyoteWriter.flush(CoyoteWriter.java:94)
at async.AsyncStockServlet.writeStock(AsyncStockServlet.java:96)
at async.AsyncStockServlet.tick(AsyncStockServlet.java:76)
at async.Stockticker.run(Stockticker.java:84)
at java.lang.Thread.run(Thread.java:745)

06-Nov-2015 15:00:49.152 SEVERE [https-apr-8443-exec-4]
org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process Error
reading request, ignored
 java.lang.IllegalStateException
at
org.apache.coyote.http2.Http2UpgradeHandler.fill(Http2UpgradeHandler.java:1064)
at
org.apache.coyote.http2.Http2Parser$Input.fill(Http2Parser.java:565)
at
org.apache.coyote.http2.Http2Parser.readConnectionPreface(Http2Parser.java:519)
at
org.apache.coyote.http2.Http2UpgradeHandler.init(Http2UpgradeHandler.java:233)
at
org.apache.coyote.http2.Http2UpgradeHandler.upgradeDispatch(Http2UpgradeHandler.java:281)
at
org.apache.coyote.http11.upgrade.UpgradeProcessorInternal.dispatch(UpgradeProcessorInternal.java:55)
at
org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:56)
at
org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:738)
at
org.apache.tomcat.util.net.AprEndpoint$SocketProcessor.run(AprEndpoint.java:2296)
at
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
at
java.util.concurrent.ThreadPoolExecutor$Worker

Re: [VOTE] Release Apache Tomcat Native 1.2.2

[Violeta Georgieva]

2015-11-06 16:11 GMT+02:00 Mark Thomas :
>
> On 06/11/2015 13:09, Violeta Georgieva wrote:
> > Hi,
> >
> > 2015-11-04 22:15 GMT+02:00 Mark Thomas :
> >>
> >> OK. Here we go again :)
> >>
> >> Thanks to everyone who has helped test 1.2.x so far. I'm hopeful that
> >> this one will be good enough for the 9.0.0 RCs and - fingers crossed -
> >> to replace 1.1.x as well.
> >>
> >> Version 1.2.2 includes the following changes:
> >> - Forward port some OpenSSL I/O changes from 1.1.x that fixed a
> >>   number of unit tests failures
> >>
> >> The proposed release artefacts can be found at [1],
> >> and the build was done using tag [2].
> >>
> >> The Apache Tomcat Native 1.2.2 is
> >>  [ ] Stable, go ahead and release
> >>  [ ] Broken because of ...
> >
> > Websocket examples are not working:
> > https://localhost:8443/examples/websocket/index.xhtml
> >
> > Stockticker never ends
> > https://localhost:8443/examples/async/stockticker
> >
> > If I access them through *http* everything is OK.
> >
> > Windows 8, jdk 1.8.0_66, Tomcat 9 trunk
>
> Hmm. I've just run the 8.0.x unit test on Windows with native 1.2.2 and
> they all passed.
>
> If you disable HTTP/2 do the above examples work?
>
> Looking at the strak traces below these look more like issues with
> HTTP/2 than with native 1.2.2.
>

I disabled  HTTP/2 and everything is OK

So +1

Regards,
Violeta

> Mark
>
>
> > Loaded APR based Apache Tomcat Native library 1.2.2 using APR version
1.5.1.
> > OpenSSL successfully initialized (OpenSSL 1.0.2d 9 Jul 2015)
> >
> >  > protocol="org.apache.coyote.http11.Http11AprProtocol"
> >maxThreads="150" SSLEnabled="true" >
> >  > />
> > 
> >  >  certificateFile="conf/localhost-cert.pem"
> >  type="RSA" />
> > 
> > 
> >
> > localhost-key.pem, localhost-cert.pem copied from tests.
> >
> >
> > Also I experience the exceptions below while testing examples.
> >
> > 06-Nov-2015 14:55:57.469 SEVERE [https-apr-8443-exec-2]
> > org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process
Error
> > reading request, ignored
> >  java.lang.IllegalStateException
> > at
> >
org.apache.coyote.http2.Http2UpgradeHandler.fill(Http2UpgradeHandler.java:1064)
> > at
> > org.apache.coyote.http2.Http2Parser$Input.fill(Http2Parser.java:565)
> > at
> >
org.apache.coyote.http2.Http2Parser.readConnectionPreface(Http2Parser.java:519)
> > at
> >
org.apache.coyote.http2.Http2UpgradeHandler.init(Http2UpgradeHandler.java:233)
> > at
> >
org.apache.coyote.http2.Http2UpgradeHandler.upgradeDispatch(Http2UpgradeHandler.java:281)
> > at
> >
org.apache.coyote.http11.upgrade.UpgradeProcessorInternal.dispatch(UpgradeProcessorInternal.java:55)
> > at
> >
org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:56)
> > at
> >
org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:738)
> > at
> >
org.apache.tomcat.util.net.AprEndpoint$SocketProcessor.run(AprEndpoint.java:2296)
> > at
> >
java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
> > at
> >
java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
> > at
> >
org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
> > at java.lang.Thread.run(Thread.java:745)
> >
> > 06-Nov-2015 15:00:47.252 INFO [Ticker Thread]
> > org.apache.coyote.AbstractProcessor.setErrorState An error occurred in
> > processing while on a non-container thread.
> >  The connection will be closed immediately
> >  java.io.IOException: Connection [1], Stream [51], This stream is not
> > writable
> > at
> >
org.apache.coyote.http2.Http2UpgradeHandler.reserveWindowSize(Http2UpgradeHandler.java:669)
> > at
> > org.apache.coyote.http2.Stream$StreamOutputBuffer.flush(Stream.java:495)
> > at
> > org.apache.coyote.http2.Stream$StreamOutputBuffer.flush(Stream.java:462)
> > at org.apache.coyote.http2.Stream.flushData(Stream.java:266)
> > at
> > org.apache.coyote.http2.StreamProcessor.action(StreamProcessor.java:131)
> > at org.apache.coyote.R

Re: [VOTE] Release Apache Tomcat Native 1.2.2

[Violeta Georgieva]

2015-11-06 16:24 GMT+02:00 Mark Thomas :
>
> On 06/11/2015 14:20, Violeta Georgieva wrote:
> > 2015-11-06 16:11 GMT+02:00 Mark Thomas :
> >>
> >> On 06/11/2015 13:09, Violeta Georgieva wrote:
> >>> Hi,
> >>>
> >>> 2015-11-04 22:15 GMT+02:00 Mark Thomas :
> >>>>
> >>>> OK. Here we go again :)
> >>>>
> >>>> Thanks to everyone who has helped test 1.2.x so far. I'm hopeful that
> >>>> this one will be good enough for the 9.0.0 RCs and - fingers crossed
-
> >>>> to replace 1.1.x as well.
> >>>>
> >>>> Version 1.2.2 includes the following changes:
> >>>> - Forward port some OpenSSL I/O changes from 1.1.x that fixed a
> >>>>   number of unit tests failures
> >>>>
> >>>> The proposed release artefacts can be found at [1],
> >>>> and the build was done using tag [2].
> >>>>
> >>>> The Apache Tomcat Native 1.2.2 is
> >>>>  [ ] Stable, go ahead and release
> >>>>  [ ] Broken because of ...
> >>>
> >>> Websocket examples are not working:
> >>> https://localhost:8443/examples/websocket/index.xhtml
> >>>
> >>> Stockticker never ends
> >>> https://localhost:8443/examples/async/stockticker
> >>>
> >>> If I access them through *http* everything is OK.
> >>>
> >>> Windows 8, jdk 1.8.0_66, Tomcat 9 trunk
> >>
> >> Hmm. I've just run the 8.0.x unit test on Windows with native 1.2.2 and
> >> they all passed.
> >>
> >> If you disable HTTP/2 do the above examples work?
> >>
> >> Looking at the strak traces below these look more like issues with
> >> HTTP/2 than with native 1.2.2.
> >>
> >
> > I disabled  HTTP/2 and everything is OK
> >
> > So +1
>
> Great. Thanks for checking that.
>
> I'll take a look at HTTP/2 on Windows while I wait for the 1.2.2 native
> vote to complete.

Some more info
The above results were with Chrome Version 46.0.2490.80 m
With Firefox v. 42.0 only stockticker has problem, websockets are OK

>
> Mark
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

Re: svn commit: r1714185 - in /tomcat/tc7.0.x/trunk: ./ java/org/apache/catalina/startup/Tomcat.java

[Violeta Georgieva]

Hi,

2015-11-14 6:41 GMT+02:00 Konstantin Kolinko :
>
> 2015-11-13 14:02 GMT+03:00  :
> > Author: violetagg
> > Date: Fri Nov 13 11:02:12 2015
> > New Revision: 1714185
> >
> > URL: http://svn.apache.org/viewvc?rev=1714185&view=rev
> > Log:
> > Merged revision 1659184 from tomcat/trunk:
> > Fix FindBugs warnings re possible Logger configuration loss
> >
> > Modified:
> > tomcat/tc7.0.x/trunk/   (props changed)
> > tomcat/tc7.0.x/trunk/java/org/apache/catalina/startup/Tomcat.java
>
> > Modified:
tomcat/tc7.0.x/trunk/java/org/apache/catalina/startup/Tomcat.java
> > URL:
http://svn.apache.org/viewvc/tomcat/tc7.0.x/trunk/java/org/apache/catalina/startup/Tomcat.java?rev=1714185&r1=1714184&r2=1714185&view=diff
> >
==
> > --- tomcat/tc7.0.x/trunk/java/org/apache/catalina/startup/Tomcat.java
(original)
> > +++ tomcat/tc7.0.x/trunk/java/org/apache/catalina/startup/Tomcat.java
Fri Nov 13 11:02:12 2015
> > @@ -24,8 +24,10 @@ import java.net.URL;
> >  import java.security.Principal;
> >  import java.util.ArrayList;
> >  import java.util.HashMap;
> > +import java.util.HashSet;
> >  import java.util.List;
> >  import java.util.Map;
> > +import java.util.Set;
> >  import java.util.Stack;
> >  import java.util.jar.JarEntry;
> >  import java.util.jar.JarFile;
> > @@ -125,6 +127,13 @@ import org.apache.catalina.realm.RealmBa
> >   * @author Costin Manolache
> >   */
> >  public class Tomcat {
> > +// Some logging implementations use weak references for loggers so
there is
> > +// the possibility that logging configuration could be lost if GC
runs just
> > +// after Loggers are configured but before they are used. The
purpose of
> > +// this Sety is to retain strong references to explicitly
configured loggers
> > +// so that configuration is not lost.
> > +private final Set pinnedLoggers = new HashSet();
> > +
> >  // Single engine, service, server, connector - few cases need more,
> >  // they can use server.xml
> >  protected Server server;
> > @@ -679,16 +688,20 @@ public class Tomcat {
> >   */
> >  public void setSilent(boolean silent) {
> >  for (String s : silences) {
> > +Logger logger = Logger.getLogger(s);
> > +pinnedLoggers.add(logger);
> >  if (silent) {
> > -Logger.getLogger(s).setLevel(Level.WARNING);
> > +logger.setLevel(Level.WARNING);
> >  } else {
> > -Logger.getLogger(s).setLevel(Level.INFO);
> > +logger.setLevel(Level.INFO);
> >  }
> >  }
> >  }
> >
> >  private void silence(Host host, String ctx) {
> > -Logger.getLogger(getLoggerName(host,
ctx)).setLevel(Level.WARNING);
> > +Logger logger = Logger.getLogger(getLoggerName(host, ctx));
> > +pinnedLoggers.add(logger);
> > +logger.setLevel(Level.WARNING);
> >  }
> >
> >  private String getLoggerName(Host host, String ctx) {
>
>
> I think it would be better for "pinnedLoggers" to be a Map.
>
> My concern is that Logger.equals() is essentially Object.equals(). As
> such, there is no easy way to remove/replace a logger once it has been
> added to that set.
>
> On another hand, loggers are keyed by a string name, so I think that
> name can be used as a key.

Thanks for the review. I changes the structure to Map.

Regards,
Violeta

> Best regards,
> Konstantin Kolinko
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

Re: [VOTE] Release Apache Tomcat 8.0.29

[Violeta Georgieva]

Hi,

2015-11-20 12:00 GMT+02:00 Mark Thomas :
>
> The proposed Apache Tomcat 8.0.29 release is now available for voting.
>
> The main changes since 8.0.28 are:
>
> - Add an option to control (per context) quoting of EL expressions in
>   JSP attributes
>
> - Correct a regression in the fix for 56777 that added support for
>   URIs in config file locations
>
> - Add a new RestCsrfPreventionFilter that provides basic CSRF
>   protection for REST APIs
>
> -  Use instance manager for WebSocket server endpoint instances
>
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.29/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1055/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_29/
>
> The proposed 8.0.29 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 8.0.29

Checked with applications that use the new specifications features -
successful.
Tested Tomcat in OSGi environment - successful.

Regards,
Violeta

> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

Time for Tomcat 7.0.66

[Violeta Georgieva]

Hi,

Tomorrow morning I plan to prepare Tomcat 7.0.66 for voting.
If you want to add something to this release, please reply here.

Regards,
Violeta

Re: Time for Tomcat 7.0.66

[Violeta Georgieva]

2015-11-25 9:32 GMT+02:00 Konstantin Kolinko :
>
> 2015-11-24 22:38 GMT+03:00 Violeta Georgieva :
> > Hi,
> >
> > Tomorrow morning I plan to prepare Tomcat 7.0.66 for voting.
> > If you want to add something to this release, please reply here.
>
> 1. The fix implementing configuration option for EL quoting (BZ 57136,
> r1712859) has not been ported to Tomcat 7 yet.
>
> I also plan to restore the old behaviour by default, for the reasons I
> explained in thread "On escaping of EL in attributes (BZ 57136)" on
> dev@.
>
> I am working on it. Estimation is ~2 hours.
>

Ok

>
> 2. I have a question on recent tribes commit that has been committed
> to Tomcat 7 as well (see Re: r1716305).
>
> I guess a fix there is to simply add the following lines, falling back
> to old behaviour.
>
> if (mapMember == null) {
> mapMember = member;
> }

I saw this.

I'll wait for these changes.

Regards,
Violeta

> Best regards,
> Konstantin Kolinko
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

Re: Time for Tomcat 7.0.66

[Violeta Georgieva]

2015-11-25 15:51 GMT+02:00 Konstantin Kolinko :
>
> 2015-11-25 10:32 GMT+03:00 Konstantin Kolinko :
> > 2015-11-24 22:38 GMT+03:00 Violeta Georgieva :
> >> Hi,
> >>
> >> Tomorrow morning I plan to prepare Tomcat 7.0.66 for voting.
> >> If you want to add something to this release, please reply here.
> >
> > 1. The fix implementing configuration option for EL quoting (BZ 57136,
> > r1712859) has not been ported to Tomcat 7 yet.
> >
> > I also plan to restore the old behaviour by default, for the reasons I
> > explained in thread "On escaping of EL in attributes (BZ 57136)" on
> > dev@.
> >
> > I am working on it. Estimation is ~2 hours.
> >
>
> Done.
>
> I think we are OK to go.
>
> I did run the test with Nio +  Java 7 + explicitly set
> compile.source=1.7 and compile.target=1.7.  All tests passed.
>
>

Ok thanks

> (I have to run now. I'll be offline for next ~5 hours).
>
> Best regards,
> Konstantin Kolinko
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

[VOTE] Release Apache Tomcat 7.0.66

[Violeta Georgieva]

The proposed Apache Tomcat 7.0.66 release is now available for voting.

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.66/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1056/
The svn tag is:
http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_66/

The proposed 7.0.66 release is:
[ ] Broken - do not release
[ ] Stable - go ahead and release as 7.0.66 Stable

Regards,
Violeta

Re: [CANCEL][VOTE] Release Apache Tomcat 7.0.66

[Violeta Georgieva]

2015-11-27 12:09 GMT+02:00 Konstantin Kolinko :
>
> 2015-11-26 0:25 GMT+03:00 Violeta Georgieva :
> > The proposed Apache Tomcat 7.0.66 release is now available for voting.
> >
> > It can be obtained from:
> > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.66/
> > The Maven staging repo is:
> > https://repository.apache.org/content/repositories/orgapachetomcat-1056/
> > The svn tag is:
> > http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_66/
> >
> > The proposed 7.0.66 release is:
> > [x] Broken - do not release
> > [ ] Stable - go ahead and release as 7.0.66 Stable
>
> 1) There are two regressions
> https://bz.apache.org/bugzilla/show_bug.cgi?id=58658
> https://bz.apache.org/bugzilla/show_bug.cgi?id=58660
>
> The second one is a showstopper, as there is no simple workaround
> (configuration option is broken).
>
> 2) Testsuite - all OK.
> Tested all connectors (BIO, NIO, APR) x JDK 6u45/7u80/8u66 32-bit on
Windows 7.

I'm canceling the vote

Regards,
Violeta

> Best regards,
> Konstantin Kolinko
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

Re: [VOTE] Release Apache Tomcat 8.0.30

[Violeta Georgieva]

2015-12-02 1:02 GMT+02:00 Mark Thomas :
>
> The proposed Apache Tomcat 8.0.30 release is now available for voting.
>
> The main changes since 8.0.29 are:
>
> - Location headers for redirects now use relative URIs. This can
>   be controlled by Context with the useRelativeRedirects attribute.
>
> - Correct a regression in 8.0.29 that broke redirects for context
>   roots.
>
> - Restore the default setting of quoteAttributeEL in Jasper to true
>   to align with 8.0.26/7.0.64 and earlier as well as other JSP
>   implementations.
>
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.30/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1057/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_30/
>
> The proposed 8.0.30 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 8.0.30

Regards,
Violeta

> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

Time for Tomcat 7.0.67

[Violeta Georgieva]

Hi,

I'm planning to start preparation for Tomcat 7.0.67 release.

Regards,
Violeta

Re: buildbot exception in ASF Buildbot on tomcat-trunk

[Violeta Georgieva]

Hi,

2015-12-07 14:39 GMT+02:00 Konstantin Kolinko :
>
> 2015-12-07 14:24 GMT+03:00  :
> > The Buildbot has detected a build exception on builder tomcat-trunk
while building ASF Buildbot. Full details are available at:
> > http://ci.apache.org/builders/tomcat-trunk/builds/723
> >
> > Buildbot URL: http://ci.apache.org/
> >
> > Buildslave for this Build: silvanus_ubuntu
> >
> > Build Reason: The AnyBranchScheduler scheduler named 'on-tomcat-commit'
triggered this build
> > Build Source Stamp: [branch tomcat/trunk] 1718308
> > Blamelist: violetagg
> >
> > BUILD FAILED: exception upload_2
>
>
> Updating '.':
> svn: E175002: Unexpected HTTP status 500 'Internal Server Error' on
> '/repos/asf/!svn/rvr/1718308/tomcat/trunk'
>
> svn: E160006: Additional errors:
> svn: E160006: No such revision 1718308
>
>
> I guess that this build slave is in Europe.
> Apparently the build was triggered earlier than EU svn mirror caught
> up with master.

I also think so.
There were about 20 minutes I was not able to merge from trunk to Tomcat 8
trunk.

Regards,
Violeta

> Best regards,
> Konstantin Kolinko
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

[VOTE] Release Apache Tomcat 7.0.67

[Violeta Georgieva]

The proposed Apache Tomcat 7.0.67 release is now available for voting.

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.67/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1058/
The svn tag is:
http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_67/

The proposed 7.0.67 release is:
[ ] Broken - do not release
[ ] Stable - go ahead and release as 7.0.67 Stable

Regards,
Violeta

Re: svn commit: r1718302 - in /tomcat/site/trunk: ./ docs/ xdocs/

[Violeta Georgieva]

2015-12-08 4:13 GMT+02:00 Huxing Zhang :
>
> Hi,
>
> There is a typo in commit message.
>
> Log:
> Updates (excluding docs) for 8.0.309 release
>
> should be 8.0.30?

I fixed that.

Thanks,
Violeta

> --
> From:markt 
> Time:2015 Dec 7 (Mon) 19:18
> To:dev 
> Subject:svn commit: r1718302 - in /tomcat/site/trunk: ./ docs/ xdocs/
>
>
> Author: markt
> Date: Mon Dec  7 11:13:34 2015
> New Revision: 1718302
>
> URL: http://svn.apache.org/viewvc?rev=1718302&view=rev
> Log:
> Updates (excluding docs) for 8.0.309 release
>
> Modified:
> tomcat/site/trunk/build.properties.default
> tomcat/site/trunk/docs/download-80.html
> tomcat/site/trunk/docs/index.html
> tomcat/site/trunk/docs/migration-8.html
> tomcat/site/trunk/docs/oldnews.html
> tomcat/site/trunk/docs/whichversion.html
> tomcat/site/trunk/xdocs/download-80.xml
> tomcat/site/trunk/xdocs/index.xml
> tomcat/site/trunk/xdocs/migration-8.xml
> tomcat/site/trunk/xdocs/oldnews.xml
> tomcat/site/trunk/xdocs/whichversion.xml
>
> Modified: tomcat/site/trunk/build.properties.default
> URL:
http://svn.apache.org/viewvc/tomcat/site/trunk/build.properties.default?rev=1718302&r1=1718301&r2=1718302&view=diff
>
==
> --- tomcat/site/trunk/build.properties.default (original)
> +++ tomcat/site/trunk/build.properties.default Mon Dec  7 11:13:34 2015
> @@ -38,7 +38,7 @@ tomcat.loc=http://www.apache.org/dist/to
>  # - Tomcat versions -
>  tomcat60=6.0.43
>  tomcat70=7.0.65
> -tomcat80=8.0.29
> +tomcat80=8.0.30
>  tomcat90=9.0.0.M1
>
>  # - Download destination -
>
> Modified: tomcat/site/trunk/docs/download-80.html
> URL:
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/download-80.html?rev=1718302&r1=1718301&r2=1718302&view=diff
>
==
> --- tomcat/site/trunk/docs/download-80.html (original)
> +++ tomcat/site/trunk/docs/download-80.html Mon Dec  7 11:13:34 2015
> @@ -215,7 +215,7 @@
>  Quick Navigation
>  
>
> -[define v]8.0.29[end]
> +[define v]8.0.30[end]
>  https://www.apache.org/dist/tomcat/tomcat-8/KEYS";>KEYS
|
>  [v] |
>  Browse |
>
> Modified: tomcat/site/trunk/docs/index.html
> URL:
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/index.html?rev=1718302&r1=1718301&r2=1718302&view=diff
>
==
> --- tomcat/site/trunk/docs/index.html (original)
> +++ tomcat/site/trunk/docs/index.html Mon Dec  7 11:13:34 2015
> @@ -237,39 +237,32 @@ project logo are trademarks of the Apach
>
>
>  
> -
> -2015-11-24 Tomcat 8.0.29 Released
> +
> +2015-12-06 Tomcat 8.0.30 Released
>  
>
>  
> -The Apache Tomcat Project is proud to announce the release of version
8.0.29
> -of Apache Tomcat. Apache Tomcat 8.0.29 includes fixes for issues
identified in
> -8.0.28 as well as other enhancements and changes. The notable changes
since
> -8.0.28 include:
> +The Apache Tomcat Project is proud to announce the release of version
8.0.30
> +of Apache Tomcat. Apache Tomcat 8.0.30 includes fixes for issues
identified in
> +8.0.29 as well as other enhancements and changes. The notable changes
since
> +8.0.29 include:
>
>  
>
> -Add an option to control (per context) quoting of EL expressions in
JSP
> -attributes.
> +Location headers for redirects now use relative URIs. This can be
controlled
> +per Context with the useRelativeRedirects attribute.
>
> -Correct a regression in the fix for 56777 that added support for
URIs in
> -config file locations.
> +Correct a regression in 8.0.29 that broke redirects for context
roots.
>
> -Add a new RestCsrfPreventionFilter that provides basic CSRF
protection for
> -REST APIs.
> -
> -Use instance manager for WebSocket server endpoint instances.
> +Restore the default setting of quoteAttributeEL in Jasper to true to
align
> +with 8.0.26/7.0.64 and earlier as well as other JSP
implementations.
>
>  
>
>
> -Note: Due to issues with the code signing service, the Windows
Installer has
> -not been signed for this release.
> -
> -
>  
>  Full details of these changes, and all the other changes, are available
in the
> -Tomcat 8
> +Tomcat 8
>  changelog.
>  
>
>
> Modified: tomcat/site/trunk/docs/migration-8.html
> URL:
http://svn.apache.org/viewvc/tomcat/site/trunk/docs/migration-8.html?rev=1718302&r1=1718301&r2=1718302&view=diff
>
==
> --- tomcat/site/trunk/docs/migration-8.html (original)
> +++ tomcat/site/trunk/docs/migration-8.html Mon Dec  7 11:13:34 2015
> @@ -732,7 +732,8 @@ of Apache Tomcat.
>"8.0.26":"1696400",
>"8.0.27":"1704937",
>"8.0.28":"1707356",
> -  "8.0.29":"1715254"
> +  "8.0.29":"1715254",
> +  "8.0.30":"1717548"
>  };
>
>   

Re: [VOTE] Release Apache Tomcat 7.0.67

[Violeta Georgieva]

2015-12-07 17:15 GMT+02:00 Violeta Georgieva :
>
> The proposed Apache Tomcat 7.0.67 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.67/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1058/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_67/
>
> The proposed 7.0.67 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 7.0.67 Stable

Tested Tomcat in OSGi environment - successful.
Basic performance tests - successful.

> Regards,
> Violeta

Re: [RESULT][VOTE] Release Apache Tomcat 7.0.67

[Violeta Georgieva]

Hi,

2015-12-07 17:15 GMT+02:00 Violeta Georgieva :
>
> The proposed Apache Tomcat 7.0.67 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.67/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1058/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_67/
>
> The proposed 7.0.67 release is:
> [ ] Broken - do not release
> [ ] Stable - go ahead and release as 7.0.67 Stable

+1 (binding):   remm, violetagg, fschumacher, kkolinko, schultz
+1 (non-binding):   Huxing Zhang

No other voters were cast.

The vote has passed.

I'll do the release shortly and announce it once the mirrors catch up.

> Regards,
> Violeta

[ANN] Apache Tomcat 7.0.67 released

[Violeta Georgieva]

The Apache Tomcat team announces the immediate availability of Apache
Tomcat 7.0.67.

Apache Tomcat is an open source software implementation of the Java
Servlet, JavaServer Pages, Java Expression Language and Java
WebSocket technologies.

This release contains a number of bug fixes and improvements compared to
version 7.0.65. The notable changes since 7.0.65 include:


- Allow file based configuration resources (e.g. key stores) to be
configured
  using URLs.

- Add an option to control (per context) quoting of EL expressions in JSP
  attributes. Restore the default behavior in Jasper to align with 7.0.64
and
  earlier as well as other JSP implementations.

- Add a new RestCsrfPreventionFilter that provides basic CSRF protection for
  REST APIs.

- Use instance manager for WebSocket server endpoint instances.

- Location headers for redirects now use relative URIs. This can be
controlled
  per Context with the useRelativeRedirects attribute.


Please refer to the change log for the complete list of changes:
http://tomcat.apache.org/tomcat-7.0-doc/changelog.html

Note: This version has 4 zip binaries: a generic one and
  three bundled with Tomcat native binaries for Windows operating
  systems running on different CPU architectures.

Note: Use of the Java WebSocket 1.1 implementation requires Java 7.

Note: If you use the APR/native AJP or HTTP connector you *must* upgrade
  to version 1.1.33 or later of the APR/native library.

Downloads:
http://tomcat.apache.org/download-70.cgi

Migration guides from Apache Tomcat 5.5.x and 6.0.x:
http://tomcat.apache.org/migration.html

Enjoy

The Apache Tomcat team

Re: svn commit: r1720759 - /tomcat/trunk/java/org/apache/catalina/manager/JMXProxyServlet.java

[Violeta Georgieva]

Hi,

2015-12-18 13:46 GMT+02:00 Mark Thomas :
>
> On 18/12/2015 11:42, ma...@apache.org wrote:
> > Author: markt
> > Date: Fri Dec 18 11:42:18 2015
> > New Revision: 1720759
> >
> > URL: http://svn.apache.org/viewvc?rev=1720759&view=rev
> > Log:
> > Formatting. No functional change.
>
> I'm looking into some issues reported by Coverity in this class so I
> wanted to clean up the formatting first. I used Eclipse's built-in code
> formatter with some custom settings so I'd be interested in what folks
> think of the result.
> I'm not planning on applying the formatter across the whole code base,
> rather I'm considering using it as a quick fix to get the format 95%
> right when there is a large amount of format clean-up required.
>
> Mark
>
> >
> > Modified:
> > tomcat/trunk/java/org/apache/catalina/manager/JMXProxyServlet.java
> >
> > Modified:
tomcat/trunk/java/org/apache/catalina/manager/JMXProxyServlet.java
> > URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/manager/JMXProxyServlet.java?rev=1720759&r1=1720758&r2=1720759&view=diff
> >
==
> > --- tomcat/trunk/java/org/apache/catalina/manager/JMXProxyServlet.java
(original)
> > +++ tomcat/trunk/java/org/apache/catalina/manager/JMXProxyServlet.java
Fri Dec 18 11:42:18 2015
> > @@ -38,12 +38,12 @@ import org.apache.catalina.mbeans.MBeanD
> >  import org.apache.tomcat.util.modeler.Registry;
> >
> >  /**
> > - * This servlet will dump JMX attributes in a simple format
> > - * and implement proxy services for modeler.
> > + * This servlet will dump JMX attributes in a simple format and
implement proxy
> > + * services for modeler.
> >   *
> >   * @author Costin Manolache
> >   */
> > -public class JMXProxyServlet extends HttpServlet  {
> > +public class JMXProxyServlet extends HttpServlet {
> >
> >  private static final long serialVersionUID = 1L;
> >
> > @@ -58,6 +58,7 @@ public class JMXProxyServlet extends Htt
> >  protected transient MBeanServer mBeanServer = null;
> >  protected transient Registry registry;
> >
> > +
> >  // -
Public Methods
> >  /**
> >   * Initialize this servlet.
> > @@ -80,55 +81,54 @@ public class JMXProxyServlet extends Htt
> >   * @exception ServletException if a servlet-specified error occurs
> >   */
> >  @Override
> > -public void doGet(HttpServletRequest request,
> > -  HttpServletResponse response)
> > -throws IOException, ServletException
> > -{
> > +public void doGet(HttpServletRequest request, HttpServletResponse
response)
> > +throws IOException, ServletException {

Are you using the default line width which is 80?
Or there is special handling of the format for Exceptions that can be
thrown by the method.

Regards,
Violeta

> >  response.setContentType("text/plain");
> >
> >  PrintWriter writer = response.getWriter();
> >
> > -if( mBeanServer==null ) {
> > +if (mBeanServer == null) {
> >  writer.println("Error - No mbean server");
> >  return;
> >  }
> >
> > -String qry=request.getParameter("set");
> > -if( qry!= null ) {
> > -String name=request.getParameter("att");
> > -String val=request.getParameter("val");
> > +String qry = request.getParameter("set");
> > +if (qry != null) {
> > +String name = request.getParameter("att");
> > +String val = request.getParameter("val");
> >
> > -setAttribute( writer, qry, name, val );
> > +setAttribute(writer, qry, name, val);
> >  return;
> >  }
> > -qry=request.getParameter("get");
> > -if( qry!= null ) {
> > -String name=request.getParameter("att");
> > -getAttribute( writer, qry, name,
request.getParameter("key") );
> > +qry = request.getParameter("get");
> > +if (qry != null) {
> > +String name = request.getParameter("att");
> > +getAttribute(writer, qry, name,
request.getParameter("key"));
> >  return;
> >  }
> >  qry = request.getParameter("invoke");
> > -if(qry != null) {
> > -String opName=request.getParameter("op");
> > +if (qry != null) {
> > +String opName = request.getParameter("op");
> >  String[] params =
getInvokeParameters(request.getParameter("ps"));
> >  invokeOperation(writer, qry, opName, params);
> >  return;
> >  }
> > -qry=request.getParameter("qry");
> > -if( qry == null ) {
> > +qry = request.getParameter("qry");
> > +if (qry == null) {
> >  qry = "*:*";
> >  }
> >
> > -listBeans( writer, qry );
> > +listBeans(writer, qry);
> >  }
> >
> > +
> >  public void getAttribute(Pr

Re: svn commit: r1721817 - /tomcat/trunk/webapps/docs/changelog.xml

[Violeta Georgieva]

2015-12-27 18:14 GMT+02:00 :
>
> Author: kkolinko
> Date: Sun Dec 27 16:14:31 2015
> New Revision: 1721817
>
> URL: http://svn.apache.org/viewvc?rev=1721817&view=rev
> Log:
> Add changelog entry for r1721528/r1721530/r1721532
> I think it is a fix for an issue that can be visible by users, thus I am
adding a changelog entry.
>

Thanks
Violeta

> Modified:
> tomcat/trunk/webapps/docs/changelog.xml
>
> Modified: tomcat/trunk/webapps/docs/changelog.xml
> URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1721817&r1=1721816&r2=1721817&view=diff
>
==
> --- tomcat/trunk/webapps/docs/changelog.xml (original)
> +++ tomcat/trunk/webapps/docs/changelog.xml Sun Dec 27 16:14:31 2015
> @@ -197,6 +197,10 @@
>  of Tomcat. Add command line option
-no-quoteAttributeEL in
>  JspC. (kkolinko)
>
> +  
> +Fix handling of missing messages in
> +org.apache.el.util.MessageFactory. (violetagg)
> +  
>  
>
>
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

Tag Tomcat 7/8.0

[Violeta Georgieva]

Hi,

I'm planning to tag Tomcat 7/8.0 tomorrow.
If you want to include something please reply here.
Please note that this will be the last Tomcat 8.0 release.

Regards,
Violeta

Re: Tag Tomcat 7/8.0

[Violeta Georgieva]

Hi,

2018-06-26 21:16 GMT+03:00 Violeta Georgieva :
>
> Hi,
>
> I'm planning to tag Tomcat 7/8.0 tomorrow.
> If you want to include something please reply here.
> Please note that this will be the last Tomcat 8.0 release.

I'm currently not able to build Tomcat 7/8.0 when there are no dependencies.

BUILD FAILED
C:\TOMCAT_7_0_89\build.xml:2761: The following error occurred while
executing th
is line:
C:\TOMCAT_7_0_89\build.xml:3088: Failed to download
[C:/temp/libs/tomcat-native-
1.2.17/tomcat-native.tar.gz]. All download sources are unavailable.


Ant installation is 1.9.12.
I am able to download from the browser.

Do I miss something from the latest changes in the Tomcat's build?

Regards,
Violeta

[VOTE] Release Apache Tomcat 7.0.89

[Violeta Georgieva]

The proposed Apache Tomcat 7.0.89 release is now available for voting.

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.89/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1188/
The svn tag is:
http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_89/

The proposed 7.0.89 release is:
[ ] Broken - do not release
[ ] Stable - go ahead and release as 7.0.89 Stable

Regards,
Violeta

Re: Tag Tomcat 7/8.0

[Violeta Georgieva]

Hi Konstantin,

2018-06-29 13:48 GMT+03:00 Konstantin Kolinko :
>
> 2018-06-28 23:54 GMT+03:00 Konstantin Kolinko :
> > 2018-06-28 23:11 GMT+03:00 Violeta Georgieva :
> >> Hi,
> >>
> >> 2018-06-26 21:16 GMT+03:00 Violeta Georgieva :
> >>>
> >>> Hi,
> >>>
> >>> I'm planning to tag Tomcat 7/8.0 tomorrow.
> >>> If you want to include something please reply here.
> >>> Please note that this will be the last Tomcat 8.0 release.
> >>
> >> I'm currently not able to build Tomcat 7/8.0 when there are no
dependencies.
> >>
> >> BUILD FAILED
> >> C:\TOMCAT_7_0_89\build.xml:2761: The following error occurred while
> >> executing th
> >> is line:
> >> C:\TOMCAT_7_0_89\build.xml:3088: Failed to download
> >> [C:/temp/libs/tomcat-native-
> >> 1.2.17/tomcat-native.tar.gz]. All download sources are unavailable.
> >>
> >>
> >> Ant installation is 1.9.12.
> >> I am able to download from the browser.
> >>
> >> Do I miss something from the latest changes in the Tomcat's build?
> >
> > See
> > https://bz.apache.org/bugzilla/show_bug.cgi?id=62164
> >
> > It is not possible to download dependencies when your preferred ASF
> > mirror (as auto-selected by closer.lua page) uses HTTP.
> >
> > This is solved by setting the property "base-apache.loc.1" in
> > build.properties to the root address of your preferred mirror.
> >
> > In my case (see error message in comment 6 in that bug) such value is:
> > base-apache.loc.1=http://apache-mirror.rbc.ru/pub/apache
> >
> >
> > It may be that similar setting will be necessary for SourceForce, the
> > property "base-sf.loc".
> >
> > I recently added checksum checks for downloaded files, so downloading
> > over http: should be OK.
>
> One more: the version of Java 6 that I am using is not able to
> download anything over HTTPS from modern sites, due to outdated
> ciphers. I have to download everything using Java 8 as a separate step
> before stating a build.
>
> For Tomcat 7.0 the command is:
> ant -Dno.build.dbcp=true -Dtest.cobertura=true -Dexecute.validate=true
>
download-compile,download-test-compile,download-dist,download-validate,download-cobertura,extras-commons-logging-prepare,extras-webservices-prepare
>
> For Tomcat 8.0 the command is:
> ant -Dtest.cobertura=true -Dexecute.validate=true
> -Dexecute.findbugs=true
>
download-compile,download-test-compile,download-dist,download-validate,download-cobertura,download-findbugs,extras-commons-logging-prepare,extras-webservices-prepare
>
> For Tomcat 8.5:
> ant -Dtest.cobertura=true -Dexecute.validate=true
> -Dexecute.findbugs=true
>
download-compile,download-test-compile,download-dist,download-validate,download-cobertura,download-findbugs,extras-webservices-prepare
>
> For Tomcat 9.0:
> ant -Dtest.cobertura=true -Dexecute.validate=true
> -Dexecute.findbugs=true
>
download-compile,download-test-compile,download-dist,download-validate,download-cobertura,download-findbugs,extras-webservices-prepare,download-bnd


Thanks a lot,
Violeta

>
> Best regards,
> Konstantin Kolinko
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

[VOTE] Release Apache Tomcat 8.0.53

[Violeta Georgieva]

The proposed Apache Tomcat 8.0.53 release is now available for voting.

NOTE: This is the last release!

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.53/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1189/
The svn tag is:
http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_53/

The proposed 8.0.53 release is:
[ ] Broken - do not release
[ ] Stable - go ahead and release as 8.0.53

Regards,
Violeta

Re: Slides for ApacheCon EU Roadshow 2018

[Violeta Georgieva]

Hi,

2018-06-27 2:40 GMT+03:00 Huxing Zhang :
>
> Hi All,
>
> I have check the presentation page[1] but could only find slide of
> Mark's "State of the Cat" topic.
>
> Do we have slides/recordings for the other topics?
>
> [1] http://tomcat.apache.org/presentations.html

I added my presentation to the Tomcat website.
As there was a demo, I added a link to GitHub in the presentation.

Regards,
Violeta


> --
> Best Regards！
> Huxing
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

Re: [VOTE] Release Apache Tomcat 7.0.89

[Violeta Georgieva]

Hi,

2018-07-02 18:35 GMT+03:00 Mark Thomas :
>
> On 29/06/18 14:24, Violeta Georgieva wrote:
> > The proposed Apache Tomcat 7.0.89 release is now available for voting.
> >
> > It can be obtained from:
> > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.89/
> > The Maven staging repo is:
> > https://repository.apache.org/content/repositories/orgapachetomcat-1188/
> > The svn tag is:
> > http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_89/
> >
> > The proposed 7.0.89 release is:
> > [X] Broken - do not release
> > [ ] Stable - go ahead and release as 7.0.89 Stable
>
> Fails to start with a security manager.
>
> Sorry. Looks like one of my changes failed to update SecurityClassLoad.

Is this applicable also for 8.0.53?

Regards,
Violeta

> Mark
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

Re: [VOTE] Release Apache Tomcat 7.0.89

[Violeta Georgieva]

2018-07-02 18:47 GMT+03:00 Mark Thomas :
>
> On 02/07/18 16:38, Violeta Georgieva wrote:
> > Hi,
> >
> > 2018-07-02 18:35 GMT+03:00 Mark Thomas :
> >>
> >> On 29/06/18 14:24, Violeta Georgieva wrote:
> >>> The proposed Apache Tomcat 7.0.89 release is now available for voting.
> >>>
> >>> It can be obtained from:
> >>> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.89/
> >>> The Maven staging repo is:
> >>>
https://repository.apache.org/content/repositories/orgapachetomcat-1188/
> >>> The svn tag is:
> >>> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_89/
> >>>
> >>> The proposed 7.0.89 release is:
> >>> [X] Broken - do not release
> >>> [ ] Stable - go ahead and release as 7.0.89 Stable
> >>
> >> Fails to start with a security manager.
> >>
> >> Sorry. Looks like one of my changes failed to update SecurityClassLoad.
> >
> > Is this applicable also for 8.0.53?
>
> No. 8.0.53 was OK.

OK
Thanks a lot

>
> Mark
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

Re: [CANCEL][VOTE] Release Apache Tomcat 7.0.89

[Violeta Georgieva]

Hi,

2018-06-29 16:24 GMT+03:00 Violeta Georgieva :
>
> The proposed Apache Tomcat 7.0.89 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.89/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1188/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_89/
>
> The proposed 7.0.89 release is:
> [ ] Broken - do not release
> [ ] Stable - go ahead and release as 7.0.89 Stable

I'm canceling the vote because of the issue reported by Mark.
I'll start preparing Tomcat 7.0.90 shortly.

Regards,
Violeta

[VOTE] Release Apache Tomcat 7.0.90

[Violeta Georgieva]

The proposed Apache Tomcat 7.0.90 release is now available for voting.

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.90/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1190/
The svn tag is:
http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_90/

The proposed 7.0.90 release is:
[ ] Broken - do not release
[ ] Stable - go ahead and release as 7.0.90 Stable

Regards,
Violeta

Re: EOL of Tomcat 7

[Violeta Georgieva]

Hi,

2018-07-03 7:54 GMT+03:00 Silambarasan Madhappan :
>
>  Hi Team,
>
> Please let us know by when Tomcat 7 will reach end of life .

There is no EOL decision for Tomcat 7.

http://tomcat.10.x6.nabble.com/Please-help-EOL-TOMCAT-7-and-8-5-td5073688.html
http://tomcat.10.x6.nabble.com/Tomcat7-EOL-UNCLASSIFIED-td5069049.html

Regards,
Violeta

> Thanks and Regards,
> Silambarasan M

Re: File Permissions in SVN/Git

[Violeta Georgieva]

Hi,

2018-07-03 7:24 GMT+03:00 Igal Sapir :
>
> The new files bin/makebase.bat and makebase.sh do not have the same
> permissions as the other files in bin, possibly because I committed them
> from a Windows machine.
>
> Specifically, the file bin/makebase.sh is missing the eXecute permission.
>

You need "svn:executable" property.
https://www.apache.org/dev/version-control.html#https-svn-config

Regards,
Violeta

> Any idea how to fix that?
>
> drwxrwxr-x.  2 ux ux  4096 Jul  2 21:17 .
> drwxrwxr-x. 10 ux ux  4096 Jul  2 21:17 ..
> -rwxrwxr-x.  1 ux ux 15528 Jul  2 21:17 catalina.bat
> -rwxrwxr-x.  1 ux ux 23463 Jul  2 21:17 catalina.sh
> -rw-rw-r--.  1 ux ux  1664 Jul  2 21:17 catalina-tasks.xml
> -rwxrwxr-x.  1 ux ux  2065 Jul  2 21:17 ciphers.bat
> -rwxrwxr-x.  1 ux ux  1997 Jul  2 21:17 ciphers.sh
> -rwxrwxr-x.  1 ux ux  1982 Jul  2 21:17 configtest.bat
> -rwxrwxr-x.  1 ux ux  1922 Jul  2 21:17 configtest.sh
> -rwxrwxr-x.  1 ux ux  8509 Jul  2 21:17 daemon.sh
> -rwxrwxr-x.  1 ux ux  2033 Jul  2 21:17 digest.bat
> -rwxrwxr-x.  1 ux ux  1965 Jul  2 21:17 digest.sh
> -rw-rw-r--.  1 ux ux  2381 Jul  2 21:17 makebase.bat <--- missing x
> -rw-rw-r--.  1 ux ux  2350 Jul  2 21:17 makebase.sh  <--- missing x
> -rwxrwxr-x.  1 ux ux  7145 Jul  2 21:17 service.bat
> -rwxrwxr-x.  1 ux ux  3366 Jul  2 21:17 setclasspath.bat
> -rwxrwxr-x.  1 ux ux  3680 Jul  2 21:17 setclasspath.sh
> -rwxrwxr-x.  1 ux ux  1962 Jul  2 21:17 shutdown.bat
> -rwxrwxr-x.  1 ux ux  1902 Jul  2 21:17 shutdown.sh
> -rwxrwxr-x.  1 ux ux  1964 Jul  2 21:17 startup.bat
> -rwxrwxr-x.  1 ux ux  1904 Jul  2 21:17 startup.sh
> -rwxrwxr-x.  1 ux ux  4464 Jul  2 21:17 tool-wrapper.bat
> -rwxrwxr-x.  1 ux ux  5483 Jul  2 21:17 tool-wrapper.sh
> -rwxrwxr-x.  1 ux ux  1968 Jul  2 21:17 version.bat
> -rwxrwxr-x.  1 ux ux  1908 Jul  2 21:17 version.sh
>
> Thanks,
>
> Igal

Re: svn commit: r1834989 - in /tomcat/trunk/bin: makebase.bat makebase.sh

[Violeta Georgieva]

На вт, 3.07.2018 г. в 21:02 ч. Michael Osipov  написа:
>
> Am 2018-07-03 um 17:31 schrieb ma...@apache.org:
> > Author: markt
> > Date: Tue Jul  3 15:31:37 2018
> > New Revision: 1834989
> >
> > URL: http://svn.apache.org/viewvc?rev=1834989&view=rev
> > Log:
> > Fix line-endings
> >
> > Modified:
> >  tomcat/trunk/bin/makebase.bat   (props changed)
> >  tomcat/trunk/bin/makebase.sh   (props changed)
> >
> > Propchange: tomcat/trunk/bin/makebase.bat
> >
--
> >  svn:eol-style = native
>
> That should be CRLF.
>
>
> > Propchange: tomcat/trunk/bin/makebase.sh
> >
--
> >  svn:eol-style = native
>
> Here LF only.

This is fixed later with
https://github.com/apache/tomcat/blob/trunk/build.xml#L1800

Regards,
Violeta

Re: [VOTE] Release Apache Tomcat 8.0.53

[Violeta Georgieva]

На пт, 29.06.2018 г. в 19:42 ч. Violeta Georgieva 
написа:
>
> The proposed Apache Tomcat 8.0.53 release is now available for voting.
>
> NOTE: This is the last release!
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.53/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1189/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_53/
>
> The proposed 8.0.53 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 8.0.53

+1

Regards,
Violeta

Re: [RESULT][VOTE] Release Apache Tomcat 8.0.53

[Violeta Georgieva]

Hi,

На пт, 29.06.2018 г. в 19:42 ч. Violeta Georgieva 
написа:
>
> The proposed Apache Tomcat 8.0.53 release is now available for voting.
>
> NOTE: This is the last release!
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.53/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1189/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_53/
>
> The proposed 8.0.53 release is:
> [ ] Broken - do not release
> [ ] Stable - go ahead and release as 8.0.53


+1 (binding):markt, remm, csutherl, violetagg

No other voters were cast.

The vote has passed.

I'll do the release shortly and announce it once the mirrors catch up.

Regards,
Violeta

Re: [VOTE] Release Apache Tomcat 7.0.90

[Violeta Georgieva]

На пн, 2.07.2018 г. в 20:36 ч. Violeta Georgieva 
написа:
>
> The proposed Apache Tomcat 7.0.90 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.90/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1190/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_90/
>
> The proposed 7.0.90 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 7.0.90 Stable

+1

Regards,
Violeta

Re: [RESULT][VOTE] Release Apache Tomcat 7.0.90

[Violeta Georgieva]

Hi,

На пн, 2.07.2018 г. в 20:36 ч. Violeta Georgieva 
написа:
>
> The proposed Apache Tomcat 7.0.90 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.90/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1190/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_90/
>
> The proposed 7.0.90 release is:
> [ ] Broken - do not release
> [ ] Stable - go ahead and release as 7.0.90 Stable

+1 (binding):huxing, markt, remm, kkolinko, violetagg

No other voters were cast.

The vote has passed.

I'll do the release shortly and announce it once the mirrors catch up.

Regards,
Violeta

[ANN] Apache Tomcat 8.0.53 released

[Violeta Georgieva]

The Apache Tomcat team announces the immediate availability of Apache
Tomcat 8.0.53.


Please note that Apache Tomcat 8.0.x has reached end of life!


Apache Tomcat 8.0 is an open source software implementation of the Java
Servlet, JavaServer Pages, Java Unified Expression Language and Java
WebSocket technologies.

Apache Tomcat 8.0.53 includes fixes for issues identified in 8.0.52 as
well as other enhancements and changes. The notable changes since
8.0.52 include:


- Update the packaged version of the Tomcat Native Library to 1.2.17 to
  pick up the latest Windows binaries built with APR 1.6.3 and OpenSSL
  1.0.2o.


Please refer to the change log for the complete list of changes:
http://tomcat.apache.org/tomcat-8.0-doc/changelog.html

Apache Tomcat website:
http://tomcat.apache.org

Downloads:
http://tomcat.apache.org/download-80.cgi

Migration guides from Apache Tomcat 5.5.x, 6.0.x and 7.0.x:
http://tomcat.apache.org/migration.html

Enjoy

The Apache Tomcat team

[ANN] Apache Tomcat 7.0.90 released

[Violeta Georgieva]

The Apache Tomcat team announces the immediate availability of Apache
Tomcat 7.0.90.

Apache Tomcat is an open source software implementation of the Java
Servlet, JavaServer Pages, Java Expression Language and Java
WebSocket technologies.

This release contains a number of bug fixes and improvements compared to
version 7.0.88. The notable changes since 7.0.88 include:


- Add the RemoteCIDRFilter and RemoteCIDRValve that can be used to
  allow/deny requests based on IPv4 and/or IPv6 client address where the
  IP ranges are defined using CIDR notation.
  Based on a patch by Francis Galiegue.

- Update the packaged version of the Tomcat Native Library to 1.2.17 to
  pick up the latest Windows binaries built with APR 1.6.3 and OpenSSL
  1.0.2o.


Please refer to the change log for the complete list of changes:
http://tomcat.apache.org/tomcat-7.0-doc/changelog.html

Apache Tomcat website:
http://tomcat.apache.org

Downloads:
http://tomcat.apache.org/download-70.cgi

Migration guides from Apache Tomcat 5.5.x and 6.0.x:
http://tomcat.apache.org/migration.html

Enjoy

The Apache Tomcat team

Re: [VOTE] Release Apache Tomcat 9.0.11

[Violeta Georgieva]

Hi,

На сб, 11.08.2018 г. в 23:32 ч. Mark Thomas  написа:
>
> The proposed Apache Tomcat 9.0.11 release is now available for voting.
>
> The major changes compared to the 9.0.10 release are:
>
> - Fix issues with Servlet asynchronous listeners when using the
>   asynchronous Servlet API in conjunction with HTTP/2.
>
> - Add a default location for the native library: ${catalina.home}/bin
>
> - Make the Jasper (JSP Engine) Java file generation process
>   multi-threaded. By default, one thread will be used per core.
>   Based on a patch by Dan Fabulich.
>
>
> Along with lots of other bug fixes and improvements.
>
> For full details, see the changelog:
> http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.11/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1191/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_11/
>
> The proposed 9.0.11 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 9.0.11

+1

Regards,
Violeta

Re: [VOTE] Release Apache Tomcat 8.5.33

[Violeta Georgieva]

Hi,

На нд, 12.08.2018 г. в 11:43 ч. Mark Thomas  написа:
>
> The proposed Apache Tomcat 8.5.33 release is now available for voting.
>
> The major changes compared to the 8.5.32 release are:
>
> - Fix issues with Servlet asynchronous listeners when using the
>   asynchronous Servlet API in conjunction with HTTP/2.
>
> - When pre-compiling with JspC, report all compilation errors rather
>   than stopping after the first error. A new option -failFast can be
>   used to restore the previous behaviour of stopping after the first
>   error.
>   Based on a patch provided by Marc Pompl.
>
> - Make the Jasper (JSP Engine) Java file generation process
>   multi-threaded. By default, one thread will be used per core.
>   Based on a patch by Dan Fabulich.
>
> Along with lots of other bug fixes and improvements.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.33/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1192/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_33/
>
> The proposed 8.5.33 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 8.5.33

+1

Regards,
Violeta

Re: Tomcat 7.0.x?

[Violeta Georgieva]

Yep I’ll do it
I’ll start later today

Regards,
Violeta

On Thu, 13 Sep 2018 at 11:24, Mark Thomas  wrote:

> It has been a while since we had a 7.0.x release. It would be good to
> get one completed before ApacheCon.
>
> Violeta, do you have the time available to do this? If not, I should be
> able to.
>
> Mark
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: Tomcat 7.0.x?

[Violeta Georgieva]

На чт, 13.09.2018 г. в 12:35 ч. Mark Thomas  написа:
>
> On 13/09/18 09:54, Violeta Georgieva wrote:
> > Yep I’ll do it
> > I’ll start later today
>
> Great.
>
> I've just checked the new issue in BZ and that was invalid so I don't
> have anything I want to commit before you tag.

Thanks
Violeta

Re: svn commit: r1840845 - /tomcat/tc7.0.x/trunk/java/org/apache/catalina/servlets/CGIServlet.java

[Violeta Georgieva]

Mark

На чт, 13.09.2018 г. в 21:00 ч.  написа:
>
> Author: markt
> Date: Thu Sep 13 18:00:44 2018
> New Revision: 1840845
>
> URL: http://svn.apache.org/viewvc?rev=1840845&view=rev
> Log:
> Java 6
>
> Modified:
> tomcat/tc7.0.x/trunk/java/org/apache/catalina/servlets/CGIServlet.java

I just wanted to fix that and you did it ;)

[VOTE] Release Apache Tomcat 7.0.91

[Violeta Georgieva]

The proposed Apache Tomcat 7.0.91 release is now available for voting.

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.91/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1195/
The svn tag is:
http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_91/

The proposed 7.0.91 release is:
[ ] Broken - do not release
[ ] Stable - go ahead and release as 7.0.91 Stable

Regards,
Violeta

Re: [VOTE] Release Apache Tomcat 7.0.91

[Violeta Georgieva]

На чт, 13.09.2018 г. в 23:28 ч. Violeta Georgieva 
написа:
>
> The proposed Apache Tomcat 7.0.91 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.91/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1195/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_91/
>
> The proposed 7.0.91 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 7.0.91 Stable

Regards,
Violeta

Re: [RESULT][VOTE] Release Apache Tomcat 7.0.91

[Violeta Georgieva]

Hi,

На чт, 13.09.2018 г. в 23:28 ч. Violeta Georgieva 
написа:
>
> The proposed Apache Tomcat 7.0.91 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.91/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1195/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_91/
>
> The proposed 7.0.91 release is:
> [ ] Broken - do not release
> [ ] Stable - go ahead and release as 7.0.91 Stable

+1 (binding):fschumacher, markt, huxing, remm, violetagg

No other voters were cast.

The vote has passed.

I'll do the release shortly and announce it once the mirrors catch up.

Regards,
Violeta

[ANN] Apache Tomcat 7.0.91 released

[Violeta Georgieva]

The Apache Tomcat team announces the immediate availability of Apache
Tomcat 7.0.91.

Apache Tomcat is an open source software implementation of the Java
Servlet, JavaServer Pages, Java Expression Language and Java
WebSocket technologies.

This release contains a number of bug fixes and improvements compared to
version 7.0.90.

Please refer to the change log for the complete list of changes:
http://tomcat.apache.org/tomcat-7.0-doc/changelog.html

Apache Tomcat website:
http://tomcat.apache.org

Downloads:
http://tomcat.apache.org/download-70.cgi

Migration guides from Apache Tomcat 5.5.x and 6.0.x:
http://tomcat.apache.org/migration.html

Enjoy

The Apache Tomcat team

Re: svn commit: r1734150 - in /tomcat/trunk: java/org/apache/catalina/servlets/DefaultServlet.java test/org/apache/catalina/servlets/TestDefaultServlet.java webapps/docs/changelog.xml webapps/docs/def

[Violeta Georgieva]

2016-03-11 19:53 GMT+02:00 Mark Thomas :
>
> On 11/03/2016 11:50, Violeta Georgieva wrote:
> > 2016-03-11 13:49 GMT+02:00 Mark Thomas :
> >>
> >> On 11/03/2016 11:31, Violeta Georgieva wrote:
> >>> Hi,
> >>>
> >>> 2016-03-08 22:45 GMT+02:00 :
> >>>>
> >>>> Author: markt
> >>>> Date: Tue Mar  8 20:45:57 2016
> >>>> New Revision: 1734150
> >>>>
> >>>> URL: http://svn.apache.org/viewvc?rev=1734150&view=rev
> >>>> Log:
> >>>> Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=59017
> >>>> Make the pre-compressed file support in the Default Servlet generic
so
> >>> any compression may be used rather than just gzip.
> >>>> Patch provided by Mikko Tiihonen.
> >>>> This closes #28
> >>
> >> 
> >>
> >>> I think that CompressionFormat should implement also Serializable.
> >>>
> >>> What do you think?
> >>
> >> Why? JMX? Or am I missing something?
> >>
> >
> > mhm JMX
>
> I took a look but couldn't see anywhere this was exposed in JMX. Where
> were you looking?

You are right. Please ignore it.

Regards,
Violeta

> Mark
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

Re: [VOTE] Release Apache Tomcat 9.0.0.M4

[Violeta Georgieva]

Hi Mark,

2016-03-12 15:58 GMT+02:00 Mark Thomas :
>
> The proposed Apache Tomcat 9.0.0.M4 release is now available for voting.
>
> This is a milestone release for the 9.0.x branch. It should be
> noted that, as a milestone release:
> - Servlet 4.0 is not finalised
> - The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket 1.2/2.0
>
> The major changes compared to the 9.0.0.M3 branch are:
> - Added JASPIC support
> - Switch to the ParallelWebappClassLoader by default
> - Reduce runtime memory footprint
> - Lots of bug fixes
>
> For full details, see the changelog:
> http://svn.us.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M4/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1065/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_0_M4/
>
> The proposed 9.0.0.M4 release is:
> [ ] Broken - do not release
> [ ] Alpha - go ahead and release as 9.0.0.M4
>

I have issues with javax.websocket.Session.setMaxIdleTimeout(long)

I can send messages after the max idle timeout.

I have a test. I can send it here as a patch, or I can commit it to the
repo and mark it as non-executable.

Regards,
Violeta

>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

Re: [VOTE] Release Apache Tomcat 8.5.0

[Violeta Georgieva]

Hi,

2016-03-17 22:00 GMT+02:00 Mark Thomas :
>
> The proposed Apache Tomcat 8.5.0 release is now available for voting.
>
> This is the first release of the 8.5.x branch. The release is, in essence:
> - Based on a copy of the 9.0.0.M4 tag
> - All 9.0.x changes to the specification APIs have been reverted. The
>   specification APIs should match 8.0.x exactly
> - Java 8 specific code has been re-written for Java 7
> - Tomcat and specification versions have been set
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.0/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1066/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_0/
>
> The proposed 8.5.0 release is:
> [ ] Broken - do not release
> [ ] Alpha  - go ahead and release as 8.5.0
> [X] Beta   - go ahead and release as 8.5.0
> [ ] Stable - go ahead and release as 8.5.0

There were Java EE 8 XSDs descriptions in NOTICE - fix with r1735558
There was JRE 8 specified in RUNNING.txt - fixed with r1735559

My tests all passed.



In Tomcat 8.0.32, RELEASE-NOTES

The public interfaces for the following classes may be added to in order to
resolve bugs and/or add new features. No existing interface method will be
removed or changed although it may be deprecated.
->>- org.apache.catalina.* (excluding sub-packages)

In Tomcat 8.5.0, RELEASE-NOTES

The public interfaces for the following classes may be added to in order to
resolve bugs and/or add new features. No existing interface method will be
removed or changed although it may be deprecated.
->>- None

Is that expected?

Regards,
Violeta

> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

Re: [VOTE] Release Apache Tomcat 9.0.0.M4

[Violeta Georgieva]

Hi,

2016-03-17 21:34 GMT+02:00 Mark Thomas :
>
> On 16/03/2016 12:04, Violeta Georgieva wrote:
> > 2016-03-16 11:59 GMT+02:00 Mark Thomas :
> >>
> >> On 16/03/2016 09:34, Violeta Georgieva wrote:
> >>> Hi Mark,
> >>>
> >>> 2016-03-12 15:58 GMT+02:00 Mark Thomas :
> >>>>
> >>>> The proposed Apache Tomcat 9.0.0.M4 release is now available for
> > voting.
> >>>>
> >>>> This is a milestone release for the 9.0.x branch. It should be
> >>>> noted that, as a milestone release:
> >>>> - Servlet 4.0 is not finalised
> >>>> - The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket
1.2/2.0
> >>>>
> >>>> The major changes compared to the 9.0.0.M3 branch are:
> >>>> - Added JASPIC support
> >>>> - Switch to the ParallelWebappClassLoader by default
> >>>> - Reduce runtime memory footprint
> >>>> - Lots of bug fixes
> >>>>
> >>>> For full details, see the changelog:
> >>>>
> >
http://svn.us.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml
> >>>>
> >>>> It can be obtained from:
> >>>> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M4/
> >>>> The Maven staging repo is:
> >>>>
> > https://repository.apache.org/content/repositories/orgapachetomcat-1065/
> >>>> The svn tag is:
> >>>> http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_0_M4/
> >>>>
> >>>> The proposed 9.0.0.M4 release is:
> >>>> [ ] Broken - do not release
> >>>> [ ] Alpha - go ahead and release as 9.0.0.M4
> >>>>
> >>>
> >>> I have issues with javax.websocket.Session.setMaxIdleTimeout(long)
> >>>
> >>> I can send messages after the max idle timeout.
> >>>
> >>> I have a test. I can send it here as a patch, or I can commit it to
the
> >>> repo and mark it as non-executable.
> >>
> >> Commit it and mark it as ignored
> >>
> >
> > I committed it. My expectation is that "After sleep..." message will
not be
> > received. Is that correct?
>
> The test has a bug.
>
> The key points are:
> - messages are processed serially on the server side
> - the client session isn't closed until the server sends the response
>   to the close message from the client
>
> The sequence of events is
>
> Seq Client  Server
> 1   Send msgSend timeout msg
> 2   Sleep()
> 3   Send close  (still sleeping)
> 4   Send after sleep msg
> 5   Rx after sleep
> 6   Rx close msg
> 7   Send close msg
> 8   Rx close msg
> 9   Close session
>
> The server needs to send the 'After sleep' msg on on a different thread
> and then it should fail server side.
>

Ok
I was reading the javadoc and had a wrong expectation
"Set the non-zero number of milliseconds before this session will be closed
by the container if it is inactive, ie no messages are *either sent or
received*..."

I'll remove the wrong test.

Thanks,
Violeta

> Mark
>
>
> >
> >> Mark
> >>
> >>
> >> -
> >> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> >> For additional commands, e-mail: dev-h...@tomcat.apache.org
> >>
> >
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

Re: [VOTE] Release Apache Tomcat 9.0.0.M4

[Violeta Georgieva]

2016-03-16 11:59 GMT+02:00 Mark Thomas :
>
> On 16/03/2016 09:34, Violeta Georgieva wrote:
> > Hi Mark,
> >
> > 2016-03-12 15:58 GMT+02:00 Mark Thomas :
> >>
> >> The proposed Apache Tomcat 9.0.0.M4 release is now available for
voting.
> >>
> >> This is a milestone release for the 9.0.x branch. It should be
> >> noted that, as a milestone release:
> >> - Servlet 4.0 is not finalised
> >> - The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket 1.2/2.0
> >>
> >> The major changes compared to the 9.0.0.M3 branch are:
> >> - Added JASPIC support
> >> - Switch to the ParallelWebappClassLoader by default
> >> - Reduce runtime memory footprint
> >> - Lots of bug fixes
> >>
> >> For full details, see the changelog:
> >>
http://svn.us.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml
> >>
> >> It can be obtained from:
> >> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M4/
> >> The Maven staging repo is:
> >>
https://repository.apache.org/content/repositories/orgapachetomcat-1065/
> >> The svn tag is:
> >> http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_0_M4/
> >>
> >> The proposed 9.0.0.M4 release is:
> >> [ ] Broken - do not release
> >> [ ] Alpha - go ahead and release as 9.0.0.M4
> >>
> >
> > I have issues with javax.websocket.Session.setMaxIdleTimeout(long)
> >
> > I can send messages after the max idle timeout.
> >
> > I have a test. I can send it here as a patch, or I can commit it to the
> > repo and mark it as non-executable.
>
> Commit it and mark it as ignored
>

I committed it. My expectation is that "After sleep..." message will not be
received. Is that correct?

> Mark
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

Re: Found 6.0.45 and 6.0.44 release announcement in tomcat.apache.org

[Violeta Georgieva]

Hi,

2016-03-21 10:50 GMT+02:00 Huxing Zhang :
>
> Hi All,
>
> I found that there are two release announcement, 6.0.45(2016-02-11) and
6.0.44(2015-05-12) in the following url:
> http://tomcat.apache.org/
>
> Is that expected?

I moved the announcement for 6.0.44 to the old news.

Thanks for reporting this.
Violeta

> Thanks,
> Huxing
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

Re: [VOTE] Release Apache Tomcat 8.0.33

[Violeta Georgieva]

Hi,

2016-03-18 22:55 GMT+02:00 Mark Thomas :
>
> The proposed Apache Tomcat 8.0.33 release is now available for voting.
>
> The main changes since 8.0.32 are:
>
> - Correct a false positive warning for ThreadLocal related memory
>   leaks when the key class but not the value class has been loaded
>   by the web application class loader.
>
> - Improve the performance of
>   javax.servlet.jsp.el.ScopedAttributeELResolver when resolving
>   attributes that do not exist.
>
> - Update the packaged version of the Tomcat Native Library to 1.2.5
>   to pick up the Windows binaries that are based on OpenSSL 1.0.2g
>   and APR 1.5.1.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.0.33/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1067/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.0.x/tags/TOMCAT_8_0_33/
>
> The proposed 8.0.33 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 8.0.33

Checked with applications that use the specifications' features -
successful.

Regards,
Violeta

> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

Re: [VOTE] Release Apache Tomcat 8.5.0

[Violeta Georgieva]

Hi,

2016-03-22 9:25 GMT+02:00 Huxing Zhang :
>
> Hi,
>
> I have following observations:
>
> 0. in NOTICE it sill mentions the following XML schemas, which I think
should be removed.
>  - javaee_8.xsd
>  - web-app_4_0.xsd
>  - web-common_4_0.xsd
>  - web-fragment_4_0.xsd
>

This is fixed with r1735558


> 1. When uncomment the SSL/TLS HTTP/1.1 Connector on port 8443 with HTTP/2
and start tomcat, there is NoSuchMethodException in catalina.out
> details are described in:
> https://bz.apache.org/bugzilla/show_bug.cgi?id=59209
>

This is fixed with r1736147

Regards,
Violeta

> 2. Server push examples failed, details are described in:
> https://bz.apache.org/bugzilla/show_bug.cgi?id=59210
>
> 3. The following test case is constantly failing in my environment (RHEL
6.2 and Mac OS X).
> I have checked with tomcat 9.0.0.M3 and there is no such problem.
>
> in TEST-org.apache.coyote.http11.TestHttp11Processor.NIO.txt:
>
> Testcase: testNon2xxResponseWithExpectation took 3.082 sec
> Caused an ERROR
> Unexpected end of file from server
> java.net.SocketException: Unexpected end of file from server
> at
sun.net.www.http.HttpClient.parseHTTPHeader(HttpClient.java:772)
> at sun.net.www.http.HttpClient.parseHTTP(HttpClient.java:633)
> at
sun.net.www.protocol.http.HttpURLConnection.expect100Continue(HttpURLConnection.java:1020)
> at
sun.net.www.protocol.http.HttpURLConnection.getOutputStream(HttpURLConnection.java:1105)
> at
org.apache.catalina.startup.TomcatBaseTest.postUrl(TomcatBaseTest.java:759)
> at
org.apache.catalina.startup.TomcatBaseTest.postUrl(TomcatBaseTest.java:722)
> at
org.apache.coyote.http11.TestHttp11Processor.doTestNon2xxResponseAndExpectation(TestHttp11Processor.java:584)
> at
org.apache.coyote.http11.TestHttp11Processor.testNon2xxResponseWithExpectation(TestHttp11Processor.java:548)
>
> Any ideas?
>
> Other test cases are all passed with openssl 1.0.2g and tcnative 1.2.5
under RHEL 6.2  / Mac OS X
> Other examples are all OK.
>
> --
> From:Mark Thomas 
> Time:2016 Mar 18 (Fri) 04:00
> To:dev@tomcat.apache.org 
> Subject:[VOTE] Release Apache Tomcat 8.5.0
>
>
> The proposed Apache Tomcat 8.5.0 release is now available for voting.
>
> This is the first release of the 8.5.x branch. The release is, in essence:
> - Based on a copy of the 9.0.0.M4 tag
> - All 9.0.x changes to the specification APIs have been reverted. The
>   specification APIs should match 8.0.x exactly
> - Java 8 specific code has been re-written for Java 7
> - Tomcat and specification versions have been set
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.0/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1066/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_0/
>
> The proposed 8.5.0 release is:
> [ ] Broken - do not release
> [ ] Alpha  - go ahead and release as 8.5.0
> [ ] Beta   - go ahead and release as 8.5.0
> [ ] Stable - go ahead and release as 8.5.0
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

Re: [VOTE] Release Apache Tomcat 8.5.0

[Violeta Georgieva]

Hi,

2016-03-22 9:25 GMT+02:00 Huxing Zhang :
>
> Hi,
>
> I have following observations:
>
> 0. in NOTICE it sill mentions the following XML schemas, which I think
should be removed.
>  - javaee_8.xsd
>  - web-app_4_0.xsd
>  - web-common_4_0.xsd
>  - web-fragment_4_0.xsd
>
> 1. When uncomment the SSL/TLS HTTP/1.1 Connector on port 8443 with HTTP/2
and start tomcat, there is NoSuchMethodException in catalina.out
> details are described in:
> https://bz.apache.org/bugzilla/show_bug.cgi?id=59209
>
> 2. Server push examples failed, details are described in:
> https://bz.apache.org/bugzilla/show_bug.cgi?id=59210
>
> 3. The following test case is constantly failing in my environment (RHEL
6.2 and Mac OS X).
> I have checked with tomcat 9.0.0.M3 and there is no such problem.

This is fixed with r1736178

> in TEST-org.apache.coyote.http11.TestHttp11Processor.NIO.txt:
>
> Testcase: testNon2xxResponseWithExpectation took 3.082 sec
> Caused an ERROR
> Unexpected end of file from server
> java.net.SocketException: Unexpected end of file from server
> at
sun.net.www.http.HttpClient.parseHTTPHeader(HttpClient.java:772)
> at sun.net.www.http.HttpClient.parseHTTP(HttpClient.java:633)
> at
sun.net.www.protocol.http.HttpURLConnection.expect100Continue(HttpURLConnection.java:1020)
> at
sun.net.www.protocol.http.HttpURLConnection.getOutputStream(HttpURLConnection.java:1105)
> at
org.apache.catalina.startup.TomcatBaseTest.postUrl(TomcatBaseTest.java:759)
> at
org.apache.catalina.startup.TomcatBaseTest.postUrl(TomcatBaseTest.java:722)
> at
org.apache.coyote.http11.TestHttp11Processor.doTestNon2xxResponseAndExpectation(TestHttp11Processor.java:584)
> at
org.apache.coyote.http11.TestHttp11Processor.testNon2xxResponseWithExpectation(TestHttp11Processor.java:548)
>
> Any ideas?
>

I cannot reproduce this with Windows 7 and jdk1.7.0_80

Can you specify the concrete JDK version that you are using?

Regards,
Violeta

> Other test cases are all passed with openssl 1.0.2g and tcnative 1.2.5
under RHEL 6.2  / Mac OS X
> Other examples are all OK.
>
> --
> From:Mark Thomas 
> Time:2016 Mar 18 (Fri) 04:00
> To:dev@tomcat.apache.org 
> Subject:[VOTE] Release Apache Tomcat 8.5.0
>
>
> The proposed Apache Tomcat 8.5.0 release is now available for voting.
>
> This is the first release of the 8.5.x branch. The release is, in essence:
> - Based on a copy of the 9.0.0.M4 tag
> - All 9.0.x changes to the specification APIs have been reverted. The
>   specification APIs should match 8.0.x exactly
> - Java 8 specific code has been re-written for Java 7
> - Tomcat and specification versions have been set
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.0/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1066/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_0/
>
> The proposed 8.5.0 release is:
> [ ] Broken - do not release
> [ ] Alpha  - go ahead and release as 8.5.0
> [ ] Beta   - go ahead and release as 8.5.0
> [ ] Stable - go ahead and release as 8.5.0
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

Re: [VOTE] Release Apache Tomcat 8.5.0

[Violeta Georgieva]

2016-03-22 13:31 GMT+02:00 Violeta Georgieva :
>
> Hi,
>
> 2016-03-22 9:25 GMT+02:00 Huxing Zhang :
> >
> > Hi,
> >
> > I have following observations:
> >
> > 0. in NOTICE it sill mentions the following XML schemas, which I think
should be removed.
> >  - javaee_8.xsd
> >  - web-app_4_0.xsd
> >  - web-common_4_0.xsd
> >  - web-fragment_4_0.xsd
> >
> > 1. When uncomment the SSL/TLS HTTP/1.1 Connector on port 8443 with
HTTP/2 and start tomcat, there is NoSuchMethodException in catalina.out
> > details are described in:
> > https://bz.apache.org/bugzilla/show_bug.cgi?id=59209
> >
> > 2. Server push examples failed, details are described in:
> > https://bz.apache.org/bugzilla/show_bug.cgi?id=59210
> >
> > 3. The following test case is constantly failing in my environment
(RHEL 6.2 and Mac OS X).
> > I have checked with tomcat 9.0.0.M3 and there is no such problem.
>
> This is fixed with r1736178

I meant the problem with the server push, not the test.

>
> > in TEST-org.apache.coyote.http11.TestHttp11Processor.NIO.txt:
> >
> > Testcase: testNon2xxResponseWithExpectation took 3.082 sec
> > Caused an ERROR
> > Unexpected end of file from server
> > java.net.SocketException: Unexpected end of file from server
> > at
sun.net.www.http.HttpClient.parseHTTPHeader(HttpClient.java:772)
> > at sun.net.www.http.HttpClient.parseHTTP(HttpClient.java:633)
> > at
sun.net.www.protocol.http.HttpURLConnection.expect100Continue(HttpURLConnection.java:1020)
> > at
sun.net.www.protocol.http.HttpURLConnection.getOutputStream(HttpURLConnection.java:1105)
> > at
org.apache.catalina.startup.TomcatBaseTest.postUrl(TomcatBaseTest.java:759)
> > at
org.apache.catalina.startup.TomcatBaseTest.postUrl(TomcatBaseTest.java:722)
> > at
org.apache.coyote.http11.TestHttp11Processor.doTestNon2xxResponseAndExpectation(TestHttp11Processor.java:584)
> > at
org.apache.coyote.http11.TestHttp11Processor.testNon2xxResponseWithExpectation(TestHttp11Processor.java:548)
> >
> > Any ideas?
> >
>
> I cannot reproduce this with Windows 7 and jdk1.7.0_80
>
> Can you specify the concrete JDK version that you are using?
>
> Regards,
> Violeta
>
> > Other test cases are all passed with openssl 1.0.2g and tcnative 1.2.5
under RHEL 6.2  / Mac OS X
> > Other examples are all OK.
> >
> > --
> > From:Mark Thomas 
> > Time:2016 Mar 18 (Fri) 04:00
> > To:dev@tomcat.apache.org 
> > Subject:[VOTE] Release Apache Tomcat 8.5.0
> >
> >
> > The proposed Apache Tomcat 8.5.0 release is now available for voting.
> >
> > This is the first release of the 8.5.x branch. The release is, in
essence:
> > - Based on a copy of the 9.0.0.M4 tag
> > - All 9.0.x changes to the specification APIs have been reverted. The
> >   specification APIs should match 8.0.x exactly
> > - Java 8 specific code has been re-written for Java 7
> > - Tomcat and specification versions have been set
> >
> > It can be obtained from:
> > https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.0/
> > The Maven staging repo is:
> > https://repository.apache.org/content/repositories/orgapachetomcat-1066/
> > The svn tag is:
> > http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_0/
> >
> > The proposed 8.5.0 release is:
> > [ ] Broken - do not release
> > [ ] Alpha  - go ahead and release as 8.5.0
> > [ ] Beta   - go ahead and release as 8.5.0
> > [ ] Stable - go ahead and release as 8.5.0
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> > For additional commands, e-mail: dev-h...@tomcat.apache.org
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> > For additional commands, e-mail: dev-h...@tomcat.apache.org
> >

Re: svn commit: r1736145 - in /tomcat/trunk: conf/server.xml webapps/docs/changelog.xml

[Violeta Georgieva]

Hi,

2016-03-22 18:04 GMT+02:00 Mark Thomas :
>
> On 22/03/2016 07:37, violet...@apache.org wrote:
> > Author: violetagg
> > Date: Tue Mar 22 07:37:21 2016
> > New Revision: 1736145
> >
> > URL: http://svn.apache.org/viewvc?rev=1736145&view=rev
> > Log:
> > Remove honorCipherOrder="false" from the server.xml.
> > When the block is uncommented the implementation will use the default
which is honorCipherOrder="true"
> > Patch provided by Huxing Zhang
>
> I'm not sure this is entirely the right approach.
>
> honorCipherOrder was more necessary a few years ago when servers
> supported weak ciphers and clients asked for them early in the priority
> list. The TLS landscape has changed a lot since then.
>
> I think we can make the default for honorCipherOrder false.

I reverted this in Tomcat 9.0.0

Regards,
Violeta

> Mark
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

Re: bug in 8.5.0?

[Violeta Georgieva]

Hi,

2016-03-24 21:01 GMT+02:00 Romain Manni-Bucau :
>
> Hi guys,
>
> if I'm not mistaken
> org.apache.catalina.loader.WebappClassLoaderBase#getResourceAsStream
> can throw a NPE:
>
> 1090. URL url = super.findResource(name);
> 1091. stream = url.openStream(); // url can be null
>

Thanks for the report.
The fix will be in 8.5.1

Regards,
Violeta

>
> Romain Manni-Bucau
> @rmannibucau |  Blog | Github | LinkedIn | Tomitriber
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

Re: [VOTE] Release Apache Tomcat 8.0.33

[Violeta Georgieva]

Hi,

2016-03-25 1:34 GMT+02:00 Anthony Biacco :
>
> On Fri, Mar 18, 2016 at 2:55 PM, Mark Thomas  wrote:
>
> > The proposed Apache Tomcat 8.0.33 release is now available for voting.
> >
> > The main changes since 8.0.32 are:
> >
> > - Correct a false positive warning for ThreadLocal related memory
> >   leaks when the key class but not the value class has been loaded
> >   by the web application class loader.
> >
> > - Improve the performance of
> >   javax.servlet.jsp.el.ScopedAttributeELResolver when resolving
> >   attributes that do not exist.
> >
> > - Update the packaged version of the Tomcat Native Library to 1.2.5
> >   to pick up the Windows binaries that are based on OpenSSL 1.0.2g
> >   and APR 1.5.1.
> >
> >
> this included the memory fix relating to the "Cannot upgrade past Tomcat 6
> due to massive memory increase" thread on the users list, yeah?
>

Yes

Regards,
Violeta

> -Tony

Re: svn commit: r1736607 - in /tomcat/trunk: java/org/apache/catalina/core/AsyncContextImpl.java webapps/docs/changelog.xml

[Violeta Georgieva]

Hi,

2016-03-25 18:24 GMT+02:00 :
>
> Author: remm
> Date: Fri Mar 25 16:24:07 2016
> New Revision: 1736607
>
> URL: http://svn.apache.org/viewvc?rev=1736607&view=rev
> Log:
> 59213: Async dispatches should use a wrapped request rather than the base
one.
>
> Modified:
> tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java
> tomcat/trunk/webapps/docs/changelog.xml
>
> Modified: tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java
> URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java?rev=1736607&r1=1736606&r2=1736607&view=diff
>
==
> --- tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java
(original)
> +++ tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java Fri
Mar 25 16:24:07 2016
> @@ -191,7 +191,7 @@ public class AsyncContextImpl implements
>  @Override
>  public void dispatch(String path) {
>  check();
> -dispatch(request.getServletContext(),path);
> +dispatch(getRequest().getServletContext(), path);

I was thinking about this.

In javadoc it is specified
"void *dispatch*(java.lang.String path)
...within the scope of the ServletContext from which this AsyncContext was
initialized"

When we initialize the AsyncContext we use the Context from the "base"
Request.
When we invoke context.bind/unbind we will use that context and not the one
provided by the "wrapped" Request.

Is that correct?
Why don't we initialize the AsyncContext with the context of the "wrapped"
Request?

Regards,
Violeta


>  }
>
>  @Override
>
> Modified: tomcat/trunk/webapps/docs/changelog.xml
> URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1736607&r1=1736606&r2=1736607&view=diff
>
==
> --- tomcat/trunk/webapps/docs/changelog.xml (original)
> +++ tomcat/trunk/webapps/docs/changelog.xml Fri Mar 25 16:24:07 2016
> @@ -67,6 +67,10 @@
>
 o.a.catalina.loader.WebappClassLoaderBase.getResourceAsStream
>  (violetagg)
>
> +  
> +59213: Async dispatches should be based off a wrapped
request.
> +(remm)
> +  
>  
>
>
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

Re: [VOTE] Release Apache Tomcat 8.5.0

[Violeta Georgieva]

2016-03-22 18:10 GMT+02:00 Mark Thomas :
>
> On 22/03/2016 15:14, Rossen Stoyanchev wrote:
> > hi,
> >
> > A public  API for initiating an upgrade at runtime was removed [1] which
> > breaks WebSocket support in the Spring Framework. This API was
previously
> > added to make up for a limitation in JSR-356. The hope was for it to be
> > picked up in a spec update but unfortunately there has been no movement
> > whatsoever on that front. For what it's worth an identical API has been
> > added to several other Servlet containers.
>
> It looks like that was removed in error as part of the clean-up to
> remove Servlet 4.0 features. It will be added back for 8.5.1.
>

The method is restored with r1736761

Regards,
Violeta

> Mark
>
> >
> > Rossen
> >
> > [1]
> >
https://github.com/apache/tomcat/commit/fe72ea5deb57d7eedf00387c1d79049ca64681ee
> > [2] https://java.net/jira/browse/WEBSOCKET_SPEC-211
> >
> > On Thu, Mar 17, 2016 at 4:00 PM, Mark Thomas  wrote:
> >
> >> The proposed Apache Tomcat 8.5.0 release is now available for voting.
> >>
> >> This is the first release of the 8.5.x branch. The release is, in
essence:
> >> - Based on a copy of the 9.0.0.M4 tag
> >> - All 9.0.x changes to the specification APIs have been reverted. The
> >>   specification APIs should match 8.0.x exactly
> >> - Java 8 specific code has been re-written for Java 7
> >> - Tomcat and specification versions have been set
> >>
> >> It can be obtained from:
> >> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.0/
> >> The Maven staging repo is:
> >>
https://repository.apache.org/content/repositories/orgapachetomcat-1066/
> >> The svn tag is:
> >> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_0/
> >>
> >> The proposed 8.5.0 release is:
> >> [ ] Broken - do not release
> >> [ ] Alpha  - go ahead and release as 8.5.0
> >> [ ] Beta   - go ahead and release as 8.5.0
> >> [ ] Stable - go ahead and release as 8.5.0
> >>
> >> -
> >> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> >> For additional commands, e-mail: dev-h...@tomcat.apache.org
> >>
> >>
> >
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

Re: Maven snapshot builds

[Violeta Georgieva]

Hi,

2016-04-02 10:27 GMT+03:00 Mark Thomas :
>
> On 1 April 2016 21:07:37 BST, Martin Grigorov 
wrote:
> >Hi,
> >
> >Does anyone know what is the reason for the missing -SNAPSHOT builds at
> >
https://repository.apache.org/content/repositories/snapshots/org/apache/tomcat/tomcat-catalina/
> >(RAO) ?
>
> Snapshots aren't automated. They need to be triggered manually by a
committer.
>
> >https://tomcat.apache.org/tomcat-8.5-doc/maven-jars.html says that the
> >snapshots should be at
> >http://people.apache.org/repo/m2-snapshot-repository/org/apache/tomcat/
> >but
> >this gives 404.
>
> That doc needs to be updated to reflect that snapshots moved to
repository.apache.org
>

I updated the docs.

Regards,
Violeta

> >The last 8.0-SNAPSHOT at RAO is from Feb 23th.
> >I actually need 8.5-SNAPSHOT with the fix for ClassCastException when
> >trying to get the ApplicationPushBuilder.
> >
> >Another option for me is to build and install the Maven jars locally.
> >Any
> >hints for the Ant commands to do this ?
>
> README in res/maven
>
> Mark
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

Time for Tomcat 7.0.69

[Violeta Georgieva]

Hi,

I'm going to start the preparation for Tomcat 7.0.69.

If you need something in addition to this release please reply here.

Regards,
Violeta

Re: Time for Tomcat 7.0.69

[Violeta Georgieva]

Hi,

2016-04-06 13:48 GMT+03:00 Konstantin Kolinko :
>
> 2016-04-06 11:09 GMT+03:00 Violeta Georgieva :
> > Hi,
> >
> > I'm going to start the preparation for Tomcat 7.0.69.
> >
> > If you need something in addition to this release please reply here.
>
>
> For me two pending issues are
>
> 1. Update to NSIS 2.51.
>
> I'll do this shortly.
>
>
> 2. The catalina.policy change for BZ 59247 has to be reverted and
> alternative fix to be applied.
>
> https://bz.apache.org/bugzilla/show_bug.cgi?id=59247#c8
>
> BTW, there is no report that the issue affects Tomcat 7 at all (the
> user reported the issue for Tomcat 8 and 9).
>

I can see the both changes are in already.
Do we need anything else?

Thanks,
Violeta

>
> Best regards,
> Konstantin Kolinko
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

Re: Time for Tomcat 7.0.69

[Violeta Georgieva]

2016-04-08 16:30 GMT+03:00 Konstantin Kolinko :
>
> 2016-04-08 9:49 GMT+03:00 Violeta Georgieva :
> > Hi,
> >
> > 2016-04-06 13:48 GMT+03:00 Konstantin Kolinko :
> >>
> >> 2016-04-06 11:09 GMT+03:00 Violeta Georgieva :
> >> > Hi,
> >> >
> >> > I'm going to start the preparation for Tomcat 7.0.69.
> >> >
> >> > If you need something in addition to this release please reply here.
> >>
> >>
> >> For me two pending issues are
> >>
> >> 1. Update to NSIS 2.51.
> >>
> >> I'll do this shortly.
> >>
> >>
> >> 2. The catalina.policy change for BZ 59247 has to be reverted and
> >> alternative fix to be applied.
> >>
> >> https://bz.apache.org/bugzilla/show_bug.cgi?id=59247#c8
> >>
> >> BTW, there is no report that the issue affects Tomcat 7 at all (the
> >> user reported the issue for Tomcat 8 and 9).
> >>
> >
> > I can see the both changes are in already.
> > Do we need anything else?
> >
>
> OK to go. There may be further improvements, but there are no
showstoppers.
>

Thanks

> Best regards,
> Konstantin Kolinko
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

Re: Time for Tomcat 7.0.69

[Violeta Georgieva]

Hi,

2016-04-06 11:09 GMT+03:00 Violeta Georgieva :
>
> Hi,
>
> I'm going to start the preparation for Tomcat 7.0.69.
>
> If you need something in addition to this release please reply here.
>

Tomcat native library 1.1.33 is no more available on download area.
Update to 1.1.34 drops the Itanium support.

Should we introduce this in Tomcat 7?

Also

Commons Pool 1.5.7 is no more available on download area.
Should we update to 1.6?

Thanks,
Violeta

> Regards,
> Violeta

Re: Time for Tomcat 7.0.69

[Violeta Georgieva]

Hi,

2016-04-08 17:59 GMT+03:00 Violeta Georgieva :
>
> Hi,
>
> 2016-04-06 11:09 GMT+03:00 Violeta Georgieva :
> >
> > Hi,
> >
> > I'm going to start the preparation for Tomcat 7.0.69.
> >
> > If you need something in addition to this release please reply here.
> >
>
> Tomcat native library 1.1.33 is no more available on download area.
> Update to 1.1.34 drops the Itanium support.
>
> Should we introduce this in Tomcat 7?
>
> Also
>
> Commons Pool 1.5.7 is no more available on download area.
> Should we update to 1.6?

Archives were not available on Friday so that was the cause for missing
libraries.

I'll leave the versions untouched for Tomcat 7.0.69.

We can continue discussion for versions update for next Tomcat 7.0.x
version.

Regards,
Violeta

> Thanks,
> Violeta
>
> > Regards,
> > Violeta

[VOTE] Release Apache Tomcat 7.0.69

[Violeta Georgieva]

The proposed Apache Tomcat 7.0.69 release is now available for voting.

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.69/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1074/
The svn tag is:
http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_69/

The proposed 7.0.69 release is:
[ ] Broken - do not release
[ ] Stable - go ahead and release as 7.0.69 Stable

Regards,
Violeta

Re: [VOTE] Release Apache Tomcat 7.0.69

[Violeta Georgieva]

2016-04-11 13:55 GMT+03:00 Violeta Georgieva :
>
> The proposed Apache Tomcat 7.0.69 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.69/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1074/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_69/
>
> The proposed 7.0.69 release is:
> [ ] Broken - do not release
> [X] Stable - go ahead and release as 7.0.69 Stable

Tested Tomcat in OSGi environment - successful.
Basic performance tests - successful.

> Regards,
> Violeta

Re: svn commit: r1738850 - in /tomcat/trunk: java/org/apache/catalina/startup/ContextConfig.java webapps/docs/changelog.xml

[Violeta Georgieva]

Hi Mark,

2016-04-12 21:58 GMT+03:00 :
>
> Author: markt
> Date: Tue Apr 12 18:58:24 2016
> New Revision: 1738850
>
> URL: http://svn.apache.org/viewvc?rev=1738850&view=rev
> Log:
> Correctly configure the base path for a resources directory provided by
an expanded JAR file.
> Patch provided by hengyunabc.
> This closes #31

With this change a META-INF/resources folder placed in WEB-INF/classes will
also be able to supply static resources.
Currently GUMP is failing because of this.

Regards,
Violeta

> Modified:
> tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java
> tomcat/trunk/webapps/docs/changelog.xml
>
> Modified: tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java
> URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java?rev=1738850&r1=1738849&r2=1738850&view=diff
>
==
> --- tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java
(original)
> +++ tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java Tue
Apr 12 18:58:24 2016
> @@ -1693,7 +1693,7 @@ public class ContextConfig implements Li
>  if (resources.isDirectory()) {
>  context.getResources().createWebResourceSet(
>
 WebResourceRoot.ResourceSetType.RESOURCE_JAR,
> -"/", file.getAbsolutePath(), null, "/");
> +"/", resources.getAbsolutePath(), null,
"/");
>  }
>  }
>  } catch (IOException ioe) {
>
> Modified: tomcat/trunk/webapps/docs/changelog.xml
> URL:
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1738850&r1=1738849&r2=1738850&view=diff
>
==
> --- tomcat/trunk/webapps/docs/changelog.xml (original)
> +++ tomcat/trunk/webapps/docs/changelog.xml Tue Apr 12 18:58:24 2016
> @@ -124,6 +124,10 @@
>  mapping type information for the current request to reflect
discussions
>  within the EG. (markt)
>
> +  
> +Correctly configure the base path for a resources directory
provided by
> +an expanded JAR file. Patch provided by hengyunabc. (markt)
> +  
>  
>
>
>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

Re: svn commit: r1738850 - in /tomcat/trunk: java/org/apache/catalina/startup/ContextConfig.java webapps/docs/changelog.xml

[Violeta Georgieva]

2016-04-13 13:37 GMT+03:00 Mark Thomas :
>
> On 13/04/2016 10:26, Violeta Georgieva wrote:
> > Hi Mark,
> >
> > 2016-04-12 21:58 GMT+03:00 :
> >>
> >> Author: markt
> >> Date: Tue Apr 12 18:58:24 2016
> >> New Revision: 1738850
> >>
> >> URL: http://svn.apache.org/viewvc?rev=1738850&view=rev
> >> Log:
> >> Correctly configure the base path for a resources directory provided by
> > an expanded JAR file.
> >> Patch provided by hengyunabc.
> >> This closes #31
> >
> > With this change a META-INF/resources folder placed in WEB-INF/classes
will
> > also be able to supply static resources.
> > Currently GUMP is failing because of this.
>
> Thanks for the heads up. I'll take another look at this.
>
> Mark
>

I had to be more specific.
The problem is with Tomcat 8.0.x when addWebinfClassesResources=false.

However I think that the problem here is because of a missing fix that is
available in Tomcat 9/8.5 only

Revision: 1728664
Author: markt
Date: Friday, February 5, 2016 3:39:13 PM
Message:
Ensure that /WEB-INF/classes is never processed as a web fragment.

Modified :
/tomcat/trunk/java/org/apache/tomcat/util/descriptor/web/FragmentJarScannerCallback.java
Modified : /tomcat/trunk/java/org/apache/tomcat/util/scan/Constants.java
Modified :
/tomcat/trunk/java/org/apache/tomcat/util/scan/StandardJarScanner.java
Modified : /tomcat/trunk/webapps/docs/changelog.xml


Regards,
Violeta

>
> >
> > Regards,
> > Violeta
> >
> >> Modified:
> >> tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java
> >> tomcat/trunk/webapps/docs/changelog.xml
> >>
> >> Modified:
tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java
> >> URL:
> >
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java?rev=1738850&r1=1738849&r2=1738850&view=diff
> >>
> >
==
> >> --- tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java
> > (original)
> >> +++ tomcat/trunk/java/org/apache/catalina/startup/ContextConfig.java
Tue
> > Apr 12 18:58:24 2016
> >> @@ -1693,7 +1693,7 @@ public class ContextConfig implements Li
> >>  if (resources.isDirectory()) {
> >>  context.getResources().createWebResourceSet(
> >>
> >  WebResourceRoot.ResourceSetType.RESOURCE_JAR,
> >> -"/", file.getAbsolutePath(), null,
"/");
> >> +"/", resources.getAbsolutePath(),
null,
> > "/");
> >>  }
> >>  }
> >>  } catch (IOException ioe) {
> >>
> >> Modified: tomcat/trunk/webapps/docs/changelog.xml
> >> URL:
> >
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1738850&r1=1738849&r2=1738850&view=diff
> >>
> >
==
> >> --- tomcat/trunk/webapps/docs/changelog.xml (original)
> >> +++ tomcat/trunk/webapps/docs/changelog.xml Tue Apr 12 18:58:24 2016
> >> @@ -124,6 +124,10 @@
> >>  mapping type information for the current request to reflect
> > discussions
> >>  within the EG. (markt)
> >>
> >> +  
> >> +Correctly configure the base path for a resources directory
> > provided by
> >> +an expanded JAR file. Patch provided by hengyunabc. (markt)
> >> +  
> >>  
> >>
> >>
> >>
> >>
> >>
> >> -
> >> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> >> For additional commands, e-mail: dev-h...@tomcat.apache.org
> >>
> >
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

Update Tomcat 7 to use Tomcat Native lib 1.2.x (was: Time for Tomcat 7.0.69)

[Violeta Georgieva]

Hi,

2016-04-11 10:42 GMT+03:00 Konstantin Kolinko :
>
> 2016-04-11 10:30 GMT+03:00 Violeta Georgieva :
> > Hi,
> >
> > 2016-04-08 17:59 GMT+03:00 Violeta Georgieva :
> >>
> >> Hi,
> >>
> >> 2016-04-06 11:09 GMT+03:00 Violeta Georgieva :
> >> >
> >> > Hi,
> >> >
> >> > I'm going to start the preparation for Tomcat 7.0.69.
> >> >
> >> > If you need something in addition to this release please reply here.
> >> >
> >>
> >> Tomcat native library 1.1.33 is no more available on download area.
> >> Update to 1.1.34 drops the Itanium support.
> >>
> >> Should we introduce this in Tomcat 7?
>
> +1. We already did so for Tomcat 6.
>
> IIRC there were two commits for that.
>  a) res/tomcat.nsi  (the installer script)
>  b) res/welcome.bin.html  (the readme file for download area)
>
> I think that Tomcat 7 shall actually use Native 1.2.5, as it will be
> supported for several years, and so it should switch to 1.2 at some
> point in time, so why not switch to 1.2.5 now?

+1
to update to Tomcat Native lib 1.2.x and to drop Itanium support

Regards,
Violeta

> >> Also
> >>
> >> Commons Pool 1.5.7 is no more available on download area.
> >> Should we update to 1.6?
>
> I cannot comment here at the moment. I do not follow Commons Pool
> development.  I wonder if their Java version requirements are the
> same.
>
>
> > Archives were not available on Friday so that was the cause for missing
> > libraries.
> >
> > I'll leave the versions untouched for Tomcat 7.0.69.
> >
> > We can continue discussion for versions update for next Tomcat 7.0.x
> > version.
>
>
> Best regards,
> Konstantin Kolinko
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

Re: [RESULT][VOTE] Release Apache Tomcat 7.0.69

[Violeta Georgieva]

Hi,

2016-04-11 13:55 GMT+03:00 Violeta Georgieva :
>
> The proposed Apache Tomcat 7.0.69 release is now available for voting.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-7/v7.0.69/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1074/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc7.0.x/tags/TOMCAT_7_0_69/
>
> The proposed 7.0.69 release is:
> [ ] Broken - do not release
> [ ] Stable - go ahead and release as 7.0.69 Stable

+1 (binding):   violetagg, mgrigorov, kfujino, remm, fschumacher
+1 (non-binding):   Huxing Zhang

No other voters were cast.

The vote has passed.

I'll do the release shortly and announce it once the mirrors catch up.

> Regards,
> Violeta

[ANN] Apache Tomcat 7.0.69 released

[Violeta Georgieva]

The Apache Tomcat team announces the immediate availability of Apache
Tomcat 7.0.69.

Apache Tomcat is an open source software implementation of the Java
Servlet, JavaServer Pages, Java Expression Language and Java
WebSocket technologies.

This release contains a number of bug fixes and improvements compared to
version 7.0.68. The notable changes since 7.0.68 include:


- Correct a false positive warning for ThreadLocal related memory leaks
  when the key class but not the value class has been loaded by the web
  application class loader.


Please refer to the change log for the complete list of changes:
http://tomcat.apache.org/tomcat-7.0-doc/changelog.html

Note: This version has 4 zip binaries: a generic one and
  three bundled with Tomcat native binaries for Windows operating
  systems running on different CPU architectures.

Note: Use of the Java WebSocket 1.1 implementation requires Java 7.

Note: If you use the APR/native AJP or HTTP connector you *must* upgrade
  to version 1.1.33 or later of the APR/native library.

Downloads:
http://tomcat.apache.org/download-70.cgi

Migration guides from Apache Tomcat 5.5.x and 6.0.x:
http://tomcat.apache.org/migration.html

Enjoy

The Apache Tomcat team

Difference in the behaviour of WebappClassLoaderBase.getResource for jar resources

[Violeta Georgieva]

Hi,

I have a question about difference in the behaviour of
org.apache.catalina.loader.WebappClassLoaderBase.getResource(String).
I'm investigating the issue reported here [1].

In Tomcat 8+ when WebappClassLoaderBase.getResource is invoked with a path
that represents a jar resource and starts with a slash
(classpath:/schema/shibboleth-2.0-services.xsd) this resource will be
served.
In
org.apache.catalina.webresources.AbstractArchiveResourceSet.getResource(String)
it is clearly stated that when the path starts with a slash then this
leading slash will be removed.

In Tomcat 7 WebappClassLoaderBase.getResource, such resource will not be
found. If I remove the leading slash everything is OK.

Is that difference intentional or I can apply a change for removing the
leading slash in Tomcat 7 WebappClassLoaderBase?

Thanks a lot,
Violeta

[1] http://marc.info/?t=14617003511&r=1&w=2

Re: Difference in the behaviour of WebappClassLoaderBase.getResource for jar resources

[Violeta Georgieva]

2016-04-27 14:25 GMT+03:00 Mark Thomas :
>
> On 27/04/2016 12:00, Violeta Georgieva wrote:
> > Hi,
> >
> > I have a question about difference in the behaviour of
> > org.apache.catalina.loader.WebappClassLoaderBase.getResource(String).
> > I'm investigating the issue reported here [1].
> >
> > In Tomcat 8+ when WebappClassLoaderBase.getResource is invoked with a
path
> > that represents a jar resource and starts with a slash
> > (classpath:/schema/shibboleth-2.0-services.xsd) this resource will be
> > served.
> > In
> >
org.apache.catalina.webresources.AbstractArchiveResourceSet.getResource(String)
> > it is clearly stated that when the path starts with a slash then this
> > leading slash will be removed.
> >
> > In Tomcat 7 WebappClassLoaderBase.getResource, such resource will not be
> > found. If I remove the leading slash everything is OK.
> >
> > Is that difference intentional or I can apply a change for removing the
> > leading slash in Tomcat 7 WebappClassLoaderBase?
>
> The difference isn't intentional but I suspect the fix for 7.0.x will
> require a more complex patch. I'd expect the fix to be based around the
> DirContext.

I'll think about this.

Thanks,
Violeta

> Mark
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

Re: Difference in the behaviour of WebappClassLoaderBase.getResource for jar resources

[Violeta Georgieva]

Hi,

2016-04-27 14:27 GMT+03:00 Konstantin Kolinko :
>
> 2016-04-27 14:00 GMT+03:00 Violeta Georgieva :
> > Hi,
> >
> > I have a question about difference in the behaviour of
> > org.apache.catalina.loader.WebappClassLoaderBase.getResource(String).
> > I'm investigating the issue reported here [1].
> >
> > In Tomcat 8+ when WebappClassLoaderBase.getResource is invoked with a
path
> > that represents a jar resource and starts with a slash
> > (classpath:/schema/shibboleth-2.0-services.xsd) this resource will be
> > served.
> > In
> >
org.apache.catalina.webresources.AbstractArchiveResourceSet.getResource(String)
> > it is clearly stated that when the path starts with a slash then this
> > leading slash will be removed.
> >
> > In Tomcat 7 WebappClassLoaderBase.getResource, such resource will not be
> > found. If I remove the leading slash everything is OK.
> >
> > Is that difference intentional or I can apply a change for removing the
> > leading slash in Tomcat 7 WebappClassLoaderBase?
> >
> > Thanks a lot,
> > Violeta
> >
> > [1] http://marc.info/?t=14617003511&r=1&w=2
>
>
> 1.) webresources API is a one thing. It should perform consistently
> across all webresource implementation.
>
> (IIRC in Tomcat 7 JNDI resources API  was too forgiving of leading
> slashes, leading to some inconsistencies such as duplicate entries in
> resource cache.  I think that that has already been fixed in TC7 by
> doing normalization before looking up into file system & caching.  A
> discussion was ~2 years ago)
>
> 2.) webresources API is also used by Servet API calls. Here we have
> org.apache.catalina.core.ApplicationContext GET_RESOURCE_REQUIRE_SLASH
>
>
http://tomcat.apache.org/tomcat-7.0-doc/config/systemprops.html#Specification
>
http://tomcat.apache.org/tomcat-8.0-doc/config/systemprops.html#Specification
>
> 3.) WebappClassLoader.getResource() shall be consistent with Java API
> of java.lang.ClassLoader.getResource()
>
>
http://docs.oracle.com/javase/8/docs/api/java/lang/ClassLoader.html#getResource-java.lang.String-
>
> It just says:
> [q]
> The name of a resource is a '/'-separated path name that identifies
> the resource.
> [/q]
>
> Unfortunately, this is unclear about leading slashes. (Maybe some
> experimenting with classloaders provided by JRE,  or reading the Java
> Lang Spec clarifies this.)  This likely was also discussed 2-3 years
> ago.
>
> 4. Beware of similar-named method Class.getResource()
>
>
http://docs.oracle.com/javase/7/docs/api/java/lang/Class.html#getResource%28java.lang.String%29
>
> This method differentiates names starting with '/' or without it as
> absolute vs relative resource names.
>
> [q]
> If the name begins with a '/' ('\u002f'), then the absolute name of
> the resource is the portion of the name following the '/'.
> [/q]
>
> I think that the above fragment hints that the resource name in
> ClassLoader,getResource() should not start with '/'.
>
>
> I think that changing WebappClassLoader.getResource() to accept
> resource names starting with '/' might be wrong.
>

Thanks for the input. I'll take it into account.

However the problem is not a generic one but related to resources placed
into jar files.
With the current implementation:

org.apache.catalina.loader.WebappClassLoaderBase.findResourceInternal(String,
String, boolean)

row 3309 synchronized (jarFiles) {
row 3310
row 3311try {
row 3312if (!openJARs()) {
row 3313return null;
row 3314}
row 3315for (i = 0; (entry == null) && (i <
jarFilesLength); i++) {
row 3316
row 3317jarEntry = jarFiles[i].getJarEntry(path);
.

The entry will never be found if it starts with "/" because of the
implementation of java.util.jar.JarFile.getJarEntry(String)



Regards,
Violeta

>
> Best regards,
> Konstantin Kolinko
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

Re: Difference in the behaviour of WebappClassLoaderBase.getResource for jar resources

[Violeta Georgieva]

2016-05-03 17:56 GMT+03:00 Konstantin Kolinko :
>
> 2016-05-03 17:07 GMT+03:00 Violeta Georgieva :
> > Hi,
> >
> > 2016-04-27 14:27 GMT+03:00 Konstantin Kolinko :
> >>
> >> 2016-04-27 14:00 GMT+03:00 Violeta Georgieva :
> >> > Hi,
> >> >
> >> > I have a question about difference in the behaviour of
> >> > org.apache.catalina.loader.WebappClassLoaderBase.getResource(String).
> >> > I'm investigating the issue reported here [1].
> >> >
> >> > In Tomcat 8+ when WebappClassLoaderBase.getResource is invoked with a
> > path
> >> > that represents a jar resource and starts with a slash
> >> > (classpath:/schema/shibboleth-2.0-services.xsd) this resource will be
> >> > served.
> >> > In
> >> >
> >
org.apache.catalina.webresources.AbstractArchiveResourceSet.getResource(String)
> >> > it is clearly stated that when the path starts with a slash then this
> >> > leading slash will be removed.
> >> >
> >> > In Tomcat 7 WebappClassLoaderBase.getResource, such resource will
not be
> >> > found. If I remove the leading slash everything is OK.
> >> >
> >> > Is that difference intentional or I can apply a change for removing
the
> >> > leading slash in Tomcat 7 WebappClassLoaderBase?
> >> >
> >> > Thanks a lot,
> >> > Violeta
> >> >
> >> > [1] http://marc.info/?t=14617003511&r=1&w=2
> >>
> >>
> >> 1.) webresources API is a one thing. It should perform consistently
> >> across all webresource implementation.
> >>
> >> (IIRC in Tomcat 7 JNDI resources API  was too forgiving of leading
> >> slashes, leading to some inconsistencies such as duplicate entries in
> >> resource cache.  I think that that has already been fixed in TC7 by
> >> doing normalization before looking up into file system & caching.  A
> >> discussion was ~2 years ago)
> >>
> >> 2.) webresources API is also used by Servet API calls. Here we have
> >> org.apache.catalina.core.ApplicationContext GET_RESOURCE_REQUIRE_SLASH
> >>
> >>
> >
http://tomcat.apache.org/tomcat-7.0-doc/config/systemprops.html#Specification
> >>
> >
http://tomcat.apache.org/tomcat-8.0-doc/config/systemprops.html#Specification
> >>
> >> 3.) WebappClassLoader.getResource() shall be consistent with Java API
> >> of java.lang.ClassLoader.getResource()
> >>
> >>
> >
http://docs.oracle.com/javase/8/docs/api/java/lang/ClassLoader.html#getResource-java.lang.String-
> >>
> >> It just says:
> >> [q]
> >> The name of a resource is a '/'-separated path name that identifies
> >> the resource.
> >> [/q]
> >>
> >> Unfortunately, this is unclear about leading slashes. (Maybe some
> >> experimenting with classloaders provided by JRE,  or reading the Java
> >> Lang Spec clarifies this.)  This likely was also discussed 2-3 years
> >> ago.
> >>
> >> 4. Beware of similar-named method Class.getResource()
> >>
> >>
> >
http://docs.oracle.com/javase/7/docs/api/java/lang/Class.html#getResource%28java.lang.String%29
> >>
> >> This method differentiates names starting with '/' or without it as
> >> absolute vs relative resource names.
> >>
> >> [q]
> >> If the name begins with a '/' ('\u002f'), then the absolute name of
> >> the resource is the portion of the name following the '/'.
> >> [/q]
> >>
> >> I think that the above fragment hints that the resource name in
> >> ClassLoader,getResource() should not start with '/'.
> >>
> >>
> >> I think that changing WebappClassLoader.getResource() to accept
> >> resource names starting with '/' might be wrong.
> >>
> >
> > Thanks for the input. I'll take it into account.
> >
> > However the problem is not a generic one but related to resources placed
> > into jar files.
> > With the current implementation:
> >
> >
org.apache.catalina.loader.WebappClassLoaderBase.findResourceInternal(String,
> > String, boolean)
> >
> > row 3309 synchronized (jarFiles) {
> > row 3310
> > row 3311try {
> > row 3312if (!openJARs()) {
> > row 3313return null;
> > row 3314}
> > row 33