Hi, 2016-03-25 18:24 GMT+02:00 <r...@apache.org>: > > Author: remm > Date: Fri Mar 25 16:24:07 2016 > New Revision: 1736607 > > URL: http://svn.apache.org/viewvc?rev=1736607&view=rev > Log: > 59213: Async dispatches should use a wrapped request rather than the base one. > > Modified: > tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java > tomcat/trunk/webapps/docs/changelog.xml > > Modified: tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java > URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java?rev=1736607&r1=1736606&r2=1736607&view=diff > ============================================================================== > --- tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java (original) > +++ tomcat/trunk/java/org/apache/catalina/core/AsyncContextImpl.java Fri Mar 25 16:24:07 2016 > @@ -191,7 +191,7 @@ public class AsyncContextImpl implements > @Override > public void dispatch(String path) { > check(); > - dispatch(request.getServletContext(),path); > + dispatch(getRequest().getServletContext(), path);
I was thinking about this. In javadoc it is specified "void *dispatch*(java.lang.String path) ...within the scope of the ServletContext from which this AsyncContext was initialized...." When we initialize the AsyncContext we use the Context from the "base" Request. When we invoke context.bind/unbind we will use that context and not the one provided by the "wrapped" Request. Is that correct? Why don't we initialize the AsyncContext with the context of the "wrapped" Request? Regards, Violeta > } > > @Override > > Modified: tomcat/trunk/webapps/docs/changelog.xml > URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1736607&r1=1736606&r2=1736607&view=diff > ============================================================================== > --- tomcat/trunk/webapps/docs/changelog.xml (original) > +++ tomcat/trunk/webapps/docs/changelog.xml Fri Mar 25 16:24:07 2016 > @@ -67,6 +67,10 @@ > <code>o.a.catalina.loader.WebappClassLoaderBase.getResourceAsStream</code> > (violetagg) > </fix> > + <fix> > + <bug>59213</bug>: Async dispatches should be based off a wrapped request. > + (remm) > + </fix> > </changelog> > </subsection> > <subsection name="Coyote"> > > > > --------------------------------------------------------------------- > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org > For additional commands, e-mail: dev-h...@tomcat.apache.org >
