[Bug 66619] Cannot upload an image file from a deployed JSP page in Tomcat 10 (10.1.8)

2023-05-29 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66619

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID
 OS||All

--- Comment #1 from Mark Thomas  ---
Bugzilla is not a support forum. Please use the users mailing list:

https://tomcat.apache.org/lists.html

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[tomcat] branch main updated: Fix import order

2023-05-29 Thread markt
This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/main by this push:
 new 92022535f1 Fix import order
92022535f1 is described below

commit 92022535f1d27937d81f6b1df66e2e1488bb3187
Author: Mark Thomas 
AuthorDate: Mon May 29 08:12:09 2023 +0100

Fix import order
---
 test/org/apache/catalina/filters/TestRateLimitFilter.java  | 12 +++-
 test/org/apache/catalina/filters/TestRemoteCIDRFilter.java |  6 --
 2 files changed, 11 insertions(+), 7 deletions(-)

diff --git a/test/org/apache/catalina/filters/TestRateLimitFilter.java 
b/test/org/apache/catalina/filters/TestRateLimitFilter.java
index d754b0cc72..f4a35da6dc 100644
--- a/test/org/apache/catalina/filters/TestRateLimitFilter.java
+++ b/test/org/apache/catalina/filters/TestRateLimitFilter.java
@@ -17,9 +17,16 @@
 
 package org.apache.catalina.filters;
 
+import java.io.IOException;
+import java.time.Instant;
+
 import jakarta.servlet.FilterChain;
 import jakarta.servlet.FilterConfig;
 import jakarta.servlet.ServletException;
+
+import org.junit.Assert;
+import org.junit.Test;
+
 import org.apache.catalina.Context;
 import org.apache.catalina.filters.TestRemoteIpFilter.MockFilterChain;
 import org.apache.catalina.filters.TestRemoteIpFilter.MockHttpServletRequest;
@@ -28,11 +35,6 @@ import org.apache.catalina.startup.TomcatBaseTest;
 import org.apache.tomcat.unittest.TesterResponse;
 import org.apache.tomcat.util.descriptor.web.FilterDef;
 import org.apache.tomcat.util.descriptor.web.FilterMap;
-import org.junit.Assert;
-import org.junit.Test;
-
-import java.io.IOException;
-import java.time.Instant;
 
 public class TestRateLimitFilter extends TomcatBaseTest {
 
diff --git a/test/org/apache/catalina/filters/TestRemoteCIDRFilter.java 
b/test/org/apache/catalina/filters/TestRemoteCIDRFilter.java
index ffac84a7b9..904751792c 100644
--- a/test/org/apache/catalina/filters/TestRemoteCIDRFilter.java
+++ b/test/org/apache/catalina/filters/TestRemoteCIDRFilter.java
@@ -21,6 +21,10 @@ import jakarta.servlet.Filter;
 import jakarta.servlet.FilterConfig;
 import jakarta.servlet.ServletException;
 import jakarta.servlet.http.HttpServletResponse;
+
+import org.junit.Assert;
+import org.junit.Test;
+
 import org.apache.catalina.Context;
 import org.apache.catalina.connector.Request;
 import org.apache.catalina.startup.Tomcat;
@@ -28,8 +32,6 @@ import org.apache.catalina.startup.TomcatBaseTest;
 import org.apache.tomcat.unittest.TesterResponse;
 import org.apache.tomcat.util.descriptor.web.FilterDef;
 import org.apache.tomcat.util.descriptor.web.FilterMap;
-import org.junit.Assert;
-import org.junit.Test;
 
 public class TestRemoteCIDRFilter extends TomcatBaseTest {
 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 66617] Developing wiki page: "How do I configure Tomcat to support remote debugging?" does not cover distributed shell scripts

2023-05-29 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66617

Mark Thomas  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|NEW |RESOLVED

--- Comment #1 from Mark Thomas  ---
Those instructions apply to both custom scripts that call catalina.[sh|bat] and
using the standard catalina.[sh|bat] script directly.

The catalina.[sh|bat] scripts both document in the initial comment block how to
customise the start-up without editing the standard Tomcat scripts.

If you need help customising your Tomcat start scripts then the users mailing
list is the place to seek help:

https://tomcat.apache.org/lists.html

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 66616] French: Misleading HTTP 401 error description ("La requête nécessite une authentification HTTP.")

2023-05-29 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66616

Mark Thomas  changed:

   What|Removed |Added

 Resolution|--- |MOVED
 Status|NEW |RESOLVED

--- Comment #1 from Mark Thomas  ---
The English text has been taken directly from RFC 9110. While I agree the
language is a little odd, I prefer keeping the message aligned with the RFC.

Translations do not have to be literal. It is the sense that is important so
the French can be changed if a different translation is a better translation of
the sense of the message then it can be changed.

Translations of Tomcat messages are managed via POEditor. Anyone can create an
account and submit an updated translation. Links for POEditor and a description
of how we keep the translations in sync is on the wiki:

https://cwiki.apache.org/confluence/display/TOMCAT/Managing+translations

Closing as MOVED as that is the closest state we have to "You can fix this
yourself at POEditor".

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: PersistentValve removal ?

2023-05-29 Thread Mark Thomas

On 26/05/2023 09:56, Rémy Maucherat wrote:

Hi,

After looking at BZ 66513, reading things online, the javadoc with its
heavy handed usage warnings, code of PersistentValve and tracing back
all the calls in the PersistentManager itself, my conclusion is that
the functionality provided by that valve is probably not doable
without significant compromises that would likely break most of its
usefulness. This seems to be a core design issue basically, or at
least this is a far more complex problem than what can be achieved
using a quick hack.


I'd like to see if we can find an acceptable hack to enforce the no more 
than one concurrent request per session rule. I have some ideas but need 
to think them through to find all the edge cases I have missed.



As a result, I would be inclined to propose dropping PersistentValve
in Tomcat 11, and deprecating it in the other branches.


Given bug 66513 it seems that some folks do find it useful. If there is 
a set of users for which the Valve is useful then I'd prefer to keep it 
if we can (with clearly documented constraints).


If t just isn't possible then removal / deprecation seems reasonable.

Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[tomcat] branch 10.1.x updated: Fix import order

2023-05-29 Thread markt
This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch 10.1.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/10.1.x by this push:
 new a397e3949e Fix import order
a397e3949e is described below

commit a397e3949e68921db980a84be7cda4cf3b086a0a
Author: Mark Thomas 
AuthorDate: Mon May 29 08:12:09 2023 +0100

Fix import order
---
 test/org/apache/catalina/filters/TestRateLimitFilter.java  | 12 +++-
 test/org/apache/catalina/filters/TestRemoteCIDRFilter.java |  6 --
 2 files changed, 11 insertions(+), 7 deletions(-)

diff --git a/test/org/apache/catalina/filters/TestRateLimitFilter.java 
b/test/org/apache/catalina/filters/TestRateLimitFilter.java
index d754b0cc72..f4a35da6dc 100644
--- a/test/org/apache/catalina/filters/TestRateLimitFilter.java
+++ b/test/org/apache/catalina/filters/TestRateLimitFilter.java
@@ -17,9 +17,16 @@
 
 package org.apache.catalina.filters;
 
+import java.io.IOException;
+import java.time.Instant;
+
 import jakarta.servlet.FilterChain;
 import jakarta.servlet.FilterConfig;
 import jakarta.servlet.ServletException;
+
+import org.junit.Assert;
+import org.junit.Test;
+
 import org.apache.catalina.Context;
 import org.apache.catalina.filters.TestRemoteIpFilter.MockFilterChain;
 import org.apache.catalina.filters.TestRemoteIpFilter.MockHttpServletRequest;
@@ -28,11 +35,6 @@ import org.apache.catalina.startup.TomcatBaseTest;
 import org.apache.tomcat.unittest.TesterResponse;
 import org.apache.tomcat.util.descriptor.web.FilterDef;
 import org.apache.tomcat.util.descriptor.web.FilterMap;
-import org.junit.Assert;
-import org.junit.Test;
-
-import java.io.IOException;
-import java.time.Instant;
 
 public class TestRateLimitFilter extends TomcatBaseTest {
 
diff --git a/test/org/apache/catalina/filters/TestRemoteCIDRFilter.java 
b/test/org/apache/catalina/filters/TestRemoteCIDRFilter.java
index ffac84a7b9..904751792c 100644
--- a/test/org/apache/catalina/filters/TestRemoteCIDRFilter.java
+++ b/test/org/apache/catalina/filters/TestRemoteCIDRFilter.java
@@ -21,6 +21,10 @@ import jakarta.servlet.Filter;
 import jakarta.servlet.FilterConfig;
 import jakarta.servlet.ServletException;
 import jakarta.servlet.http.HttpServletResponse;
+
+import org.junit.Assert;
+import org.junit.Test;
+
 import org.apache.catalina.Context;
 import org.apache.catalina.connector.Request;
 import org.apache.catalina.startup.Tomcat;
@@ -28,8 +32,6 @@ import org.apache.catalina.startup.TomcatBaseTest;
 import org.apache.tomcat.unittest.TesterResponse;
 import org.apache.tomcat.util.descriptor.web.FilterDef;
 import org.apache.tomcat.util.descriptor.web.FilterMap;
-import org.junit.Assert;
-import org.junit.Test;
 
 public class TestRemoteCIDRFilter extends TomcatBaseTest {
 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 66617] Developing wiki page: "How do I configure Tomcat to support remote debugging?" does not cover distributed shell scripts

2023-05-29 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66617

Philippe Cloutier  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|INVALID |---

--- Comment #2 from Philippe Cloutier  ---
Thanks Mark,
The initial comment block in catalina.[sh|bat] scripts unfortunately only
covers environment variables, not modifying the startup command. You are
however right that fully treating this in catalina.[sh|bat] scripts too would
be even better.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 66617] Developing wiki page: "How do I configure Tomcat to support remote debugging?" does not cover distributed shell scripts

2023-05-29 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66617

Mark Thomas  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|REOPENED|RESOLVED

--- Comment #3 from Mark Thomas  ---
setenv.[sh|bat] can also be used to configure debugging.

Again, the users list is the place to seek help with this, not Bugzilla.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 66617] Developing wiki page: "How do I configure Tomcat to support remote debugging?" does not cover distributed shell scripts

2023-05-29 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=66617

Philippe Cloutier  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|INVALID |---

--- Comment #4 from Philippe Cloutier  ---
Mark, this is a bug report combined with an enhancement request, not a support
request. If the point you're trying to make is that debugging can be enabled
using setenv.sh, you may be the right, but the issue(s) tracked here remain.
setenv is *not* designed to start Tomcat with catalina jpda start. We cannot
expect users to ask for advice to do such a basic thing, and then follow advice
which goes against documentation.

Also, thank you for waiting until resolution before marking issues as resolved.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org