date:20230504

[tomcat] branch main updated: Add JRE fix detail to workaround so it can be removed later.

2023-05-04 Thread markt

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/main by this push:
 new 43643fe02c Add JRE fix detail to workaround so it can be removed later.
43643fe02c is described below

commit 43643fe02c522a0ccc4963dd1f640d9c3ab63d56
Author: Mark Thomas 
AuthorDate: Thu May 4 08:21:59 2023 +0100

Add JRE fix detail to workaround so it can be removed later.
---
 java/jakarta/el/BeanSupportFull.java | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/java/jakarta/el/BeanSupportFull.java 
b/java/jakarta/el/BeanSupportFull.java
index 03770b56ab..eea3e189e9 100644
--- a/java/jakarta/el/BeanSupportFull.java
+++ b/java/jakarta/el/BeanSupportFull.java
@@ -43,6 +43,9 @@ class BeanSupportFull extends BeanSupport {
 this.properties.put(pd.getName(), new 
BeanPropertyFull(type, pd));
 }
 /*
+ * https://bugs.openjdk.org/browse/JDK-8071693 - Introspector 
ignores default interface methods.
+ *
+ * This bug is fixed in Java 21 b21. This workaround can be 
removed once the minimum Java version is 21.
  * Populating from any interfaces causes default methods to be 
included.
  */
 populateFromInterfaces(type);


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Workaround for misbehaving ClassLoader

2023-05-04 Thread Mark Thomas


On 03/05/2023 20:02, Christopher Schultz wrote:



But my question is whether or not this is something that Tomcat should 
be working-around. IMO the parent ClassLoader is buggy and should be 
fixed, but it may be difficult or impossible to fix the parent, so it 
may be worth it.


We could even log it including the class name of the offending ClassLoader.

WDYT?


The general approach we have taken is that we don't work-around bugs in 
third-party products unless:

- the third-party vendor is (known to be) slow to respond to bugs
- there is no other viable workaround (including switching vendors)
- the bug impacts a reasonable proportion of Tomcat users

The complexity of the workaround in Tomcat vs the severity of the issue 
is also a consideration.


We also want to encourage adherence to the relevant specifications.

All of the above is subjective.

For commercial software, the general idea is to encourage users to put 
pressure on vendors to fix the bugs rather than expect us to - just 
because we are more responsive. This is especially true for commercial 
organizations using commercial software where there should be a support 
contract in place.


For open source software, the general idea is to encourage users to 
engage with the project concerned. Open a bug, provide a PR, contribute 
and support that project.


The GitHub project in question hasn't had any activity since 2017 and 
the GitHub organization hasn't had any activity since 2019. There are no 
forks of the project.


It looks like the code has never been released so I am assuming the OP 
has compiled it locally.


The fix in Tomcat is simple, but so is the fix in the problematic library.

I think the initial position is that the OP needs to try and get this 
fixed. Whether that means creating a fork (it is ALv2 so that is easy),
seeing if the CodeGerm team can be persuaded to accept a PR, finding an 
alternative library or something else is up to the OP.


Given the options the OP has for addressing this - including a (private) 
fork, I don't think this is something that should be fixed in Tomcat.


Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[junit] WARNING: Using incubator modules: jdk.incubator.foreign

2023-05-04 Thread Rainer Jung


Hi there,

when testing TC 10.1 and 11 I get lots of

[junit] WARNING: Using incubator modules: jdk.incubator.foreign

lines in the output. This happens when testing with Java 17. Not with 11 
and not with 20 or 21. Don't know about 12-16 and 18-19.


We do have a block in build.xml that adds an --add-modules and the 
running java processes during the unit tests do have the following flags 
set:


--add-opens=java.base/java.lang=ALL-UNNAMED
--add-opens=java.base/java.io=ALL-UNNAMED
--add-opens=java.rmi/sun.rmi.transport=ALL-UNNAMED
--add-opens=java.base/java.util=ALL-UNNAMED
--add-opens=java.base/java.util.concurrent=ALL-UNNAMED
--enable-native-access=ALL-UNNAMED
--add-modules jdk.incubator.foreign

Only the java launcher process, that is the parent of those two does not 
have these flags set.


The count of such lines is two more than the number of test classes run.

Best regards,

Rainer

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [junit] WARNING: Using incubator modules: jdk.incubator.foreign

2023-05-04 Thread Rainer Jung


Replying to self: it seems that warning is part of the incubator JEP

https://openjdk.org/jeps/11

and can not be suppressed. The "--add-modules" makes the API available, 
but since incubator APIs are supposed to be non-final there is a 
mandatory warning that an applications uses them whenever an incubator 
module is resolved.


I guess we cań live with that.

Sorry for the noise,

Rainer

Am 04.05.23 um 12:40 schrieb Rainer Jung:

Hi there,

when testing TC 10.1 and 11 I get lots of

[junit] WARNING: Using incubator modules: jdk.incubator.foreign

lines in the output. This happens when testing with Java 17. Not with 11 
and not with 20 or 21. Don't know about 12-16 and 18-19.


We do have a block in build.xml that adds an --add-modules and the 
running java processes during the unit tests do have the following flags 
set:


--add-opens=java.base/java.lang=ALL-UNNAMED
--add-opens=java.base/java.io=ALL-UNNAMED
--add-opens=java.rmi/sun.rmi.transport=ALL-UNNAMED
--add-opens=java.base/java.util=ALL-UNNAMED
--add-opens=java.base/java.util.concurrent=ALL-UNNAMED
--enable-native-access=ALL-UNNAMED
--add-modules jdk.incubator.foreign

Only the java launcher process, that is the parent of those two does not 
have these flags set.


The count of such lines is two more than the number of test classes run.

Best regards,

Rainer


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 66592] New: Support for HTTPS proxy in websocket client

2023-05-04 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=66592

Bug ID: 66592
   Summary: Support for HTTPS proxy in websocket client
   Product: Tomcat 9
   Version: 9.0.74
  Hardware: All
OS: All
Status: NEW
  Severity: normal
  Priority: P2
 Component: Catalina
  Assignee: dev@tomcat.apache.org
  Reporter: radhika.j...@veritas.com
  Target Milestone: -

Websocket client library in Apache Tomcat 9.x or all releases is supporting
only HTTP proxy server.

WsWebSocketContainer.java has following check:

   Proxy selectedProxy = null;
for (Proxy proxy : proxies) {
if (proxy.type().equals(Proxy.Type.HTTP)) {
sa = proxy.address();
if (sa instanceof InetSocketAddress) {
InetSocketAddress inet = (InetSocketAddress) sa;
if (inet.isUnresolved()) {
sa = new InetSocketAddress(inet.getHostName(),
inet.getPort());
}
}
selectedProxy = proxy;
break;
}
}

This request is to enhance the clientlibrary to support HTTPS proxy servers.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 66592] Support for HTTPS proxy in websocket client

2023-05-04 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=66592

Mark Thomas  changed:

   What|Removed |Added

   Severity|normal  |enhancement

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Java 21 and virtual threads

2023-05-04 Thread Mark Thomas


Hi all,

The latest Java 21 EA build has moved virtual threads (from project 
Loom) out of preview. How do we want to handle this in Tomcat 11? Recall 
that Jakarta EE 11 has set Java 21 as the minimum version.


I think we have the following options:

1. Stick with Java 17 as the minimum version and don't provide virtual 
thread functionality.


2. Stick with Java 17 as the minimum version and provide virtual thread 
functionality via the JreCompat module.


3. Increase minimum Java version to Java 21 for Tomcat 11 and provide 
virtual thread functionality.


I am currently leaning towards 3 but could live with 2.

Thoughts? Other options?

Mark

PS Option 3 will require updates to the CI systems - I am happy to take 
care of those.


PPS I don't think all of the current Loom module will make it into 
Tomcat 11. I am currently thinking to pull in the Executor and then 
provide a boolean option for the existing endpoints to switch the 
internal executor to Loom.


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] 01/02: Improve locking of utility executor

2023-05-04 Thread markt

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git

commit 71032f7b2906ef85b6402b986483d9715bd65e63
Author: Mark Thomas 
AuthorDate: Thu May 4 11:41:57 2023 +0100

Improve locking of utility executor

Fixes some edge cases around calling setUtilityThreads() during stop
---
 java/org/apache/catalina/core/StandardServer.java | 51 +--
 1 file changed, 29 insertions(+), 22 deletions(-)

diff --git a/java/org/apache/catalina/core/StandardServer.java 
b/java/org/apache/catalina/core/StandardServer.java
index 09a223fa80..80b5026fed 100644
--- a/java/org/apache/catalina/core/StandardServer.java
+++ b/java/org/apache/catalina/core/StandardServer.java
@@ -424,27 +424,30 @@ public final class StandardServer extends 
LifecycleMBeanBase implements Server {
 return;
 }
 this.utilityThreads = utilityThreads;
-if (oldUtilityThreads != utilityThreads && utilityExecutor != null) {
-
reconfigureUtilityExecutor(getUtilityThreadsInternal(utilityThreads));
+synchronized (utilityExecutorLock) {
+if (oldUtilityThreads != utilityThreads && utilityExecutor != 
null) {
+
reconfigureUtilityExecutor(getUtilityThreadsInternal(utilityThreads));
+}
 }
 }
 
 
+/*
+ * Callers must be holding utilityExecutorLock
+ */
 private void reconfigureUtilityExecutor(int threads) {
-synchronized (utilityExecutorLock) {
-// The ScheduledThreadPoolExecutor doesn't use MaximumPoolSize, 
only CorePoolSize is available
-if (utilityExecutor != null) {
-utilityExecutor.setCorePoolSize(threads);
-} else {
-ScheduledThreadPoolExecutor scheduledThreadPoolExecutor = new 
ScheduledThreadPoolExecutor(threads,
-new TaskThreadFactory("Catalina-utility-", 
utilityThreadsAsDaemon, Thread.MIN_PRIORITY));
-scheduledThreadPoolExecutor.setKeepAliveTime(10, 
TimeUnit.SECONDS);
-scheduledThreadPoolExecutor.setRemoveOnCancelPolicy(true);
-
scheduledThreadPoolExecutor.setExecuteExistingDelayedTasksAfterShutdownPolicy(false);
-utilityExecutor = scheduledThreadPoolExecutor;
-utilityExecutorWrapper = new 
org.apache.tomcat.util.threads.ScheduledThreadPoolExecutor(
-utilityExecutor);
-}
+// The ScheduledThreadPoolExecutor doesn't use MaximumPoolSize, only 
CorePoolSize is available
+if (utilityExecutor != null) {
+utilityExecutor.setCorePoolSize(threads);
+} else {
+ScheduledThreadPoolExecutor scheduledThreadPoolExecutor = new 
ScheduledThreadPoolExecutor(threads,
+new TaskThreadFactory("Catalina-utility-", 
utilityThreadsAsDaemon, Thread.MIN_PRIORITY));
+scheduledThreadPoolExecutor.setKeepAliveTime(10, TimeUnit.SECONDS);
+scheduledThreadPoolExecutor.setRemoveOnCancelPolicy(true);
+
scheduledThreadPoolExecutor.setExecuteExistingDelayedTasksAfterShutdownPolicy(false);
+utilityExecutor = scheduledThreadPoolExecutor;
+utilityExecutorWrapper = new 
org.apache.tomcat.util.threads.ScheduledThreadPoolExecutor(
+utilityExecutor);
 }
 }
 
@@ -973,8 +976,10 @@ public final class StandardServer extends 
LifecycleMBeanBase implements Server {
 super.initInternal();
 
 // Initialize utility executor
-reconfigureUtilityExecutor(getUtilityThreadsInternal(utilityThreads));
-register(utilityExecutor, "type=UtilityExecutor");
+synchronized (utilityExecutorLock) {
+
reconfigureUtilityExecutor(getUtilityThreadsInternal(utilityThreads));
+register(utilityExecutor, "type=UtilityExecutor");
+}
 
 // Register global String cache
 // Note although the cache is global, if there are multiple Servers
@@ -1009,10 +1014,12 @@ public final class StandardServer extends 
LifecycleMBeanBase implements Server {
 
 unregister(onameStringCache);
 
-if (utilityExecutor != null) {
-utilityExecutor.shutdownNow();
-unregister("type=UtilityExecutor");
-utilityExecutor = null;
+synchronized (utilityExecutorLock) {
+if (utilityExecutor != null) {
+utilityExecutor.shutdownNow();
+unregister("type=UtilityExecutor");
+utilityExecutor = null;
+}
 }
 
 super.destroyInternal();


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] 02/02: Move management of utility executor from init/destroy to start/stop

2023-05-04 Thread markt

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git

commit 4b097bf2e9075e9e2949ec5aa410cba3c2b85374
Author: Mark Thomas 
AuthorDate: Thu May 4 14:41:01 2023 +0100

Move management of utility executor from init/destroy to start/stop
---
 java/org/apache/catalina/connector/Connector.java  | 13 +++---
 java/org/apache/catalina/core/ContainerBase.java   | 20 +++-
 java/org/apache/catalina/core/StandardServer.java  | 28 +++---
 .../apache/catalina/ha/tcp/SimpleTcpCluster.java   |  5 +++-
 webapps/docs/changelog.xml |  5 
 5 files changed, 41 insertions(+), 30 deletions(-)

diff --git a/java/org/apache/catalina/connector/Connector.java 
b/java/org/apache/catalina/connector/Connector.java
index c9200e20ca..dac7fdd642 100644
--- a/java/org/apache/catalina/connector/Connector.java
+++ b/java/org/apache/catalina/connector/Connector.java
@@ -992,9 +992,6 @@ public class Connector extends LifecycleMBeanBase {
 // Initialize adapter
 adapter = new CoyoteAdapter(this);
 protocolHandler.setAdapter(adapter);
-if (service != null) {
-
protocolHandler.setUtilityExecutor(service.getServer().getUtilityExecutor());
-}
 
 // Make sure parseBodyMethodsSet has a default
 if (null == parseBodyMethodsSet) {
@@ -1035,6 +1032,11 @@ public class Connector extends LifecycleMBeanBase {
 
 setState(LifecycleState.STARTING);
 
+// Configure the utility executor before starting the protocol handler
+if (service != null) {
+
protocolHandler.setUtilityExecutor(service.getServer().getUtilityExecutor());
+}
+
 try {
 protocolHandler.start();
 } catch (Exception e) {
@@ -1060,6 +1062,11 @@ public class Connector extends LifecycleMBeanBase {
 } catch (Exception e) {
 throw new 
LifecycleException(sm.getString("coyoteConnector.protocolHandlerStopFailed"), 
e);
 }
+
+// Remove the utility executor once the protocol handler has been 
stopped
+if (service != null) {
+protocolHandler.setUtilityExecutor(null);
+}
 }
 
 
diff --git a/java/org/apache/catalina/core/ContainerBase.java 
b/java/org/apache/catalina/core/ContainerBase.java
index 784c9032ef..a7e7c69a4a 100644
--- a/java/org/apache/catalina/core/ContainerBase.java
+++ b/java/org/apache/catalina/core/ContainerBase.java
@@ -787,13 +787,6 @@ public abstract class ContainerBase extends 
LifecycleMBeanBase implements Contai
 }
 
 
-@Override
-protected void initInternal() throws LifecycleException {
-reconfigureStartStopExecutor(getStartStopThreads());
-super.initInternal();
-}
-
-
 private void reconfigureStartStopExecutor(int threads) {
 if (threads == 1) {
 // Use a fake executor
@@ -819,6 +812,8 @@ public abstract class ContainerBase extends 
LifecycleMBeanBase implements Contai
 @Override
 protected synchronized void startInternal() throws LifecycleException {
 
+reconfigureStartStopExecutor(getStartStopThreads());
+
 // Start our subordinate components, if any
 logger = null;
 getLogger();
@@ -925,6 +920,12 @@ public abstract class ContainerBase extends 
LifecycleMBeanBase implements Contai
 if (cluster instanceof Lifecycle) {
 ((Lifecycle) cluster).stop();
 }
+
+// If init fails, this may be null
+if (startStopExecutor != null) {
+startStopExecutor.shutdownNow();
+startStopExecutor = null;
+}
 }
 
 @Override
@@ -954,11 +955,6 @@ public abstract class ContainerBase extends 
LifecycleMBeanBase implements Contai
 parent.removeChild(this);
 }
 
-// If init fails, this may be null
-if (startStopExecutor != null) {
-startStopExecutor.shutdownNow();
-}
-
 super.destroyInternal();
 }
 
diff --git a/java/org/apache/catalina/core/StandardServer.java 
b/java/org/apache/catalina/core/StandardServer.java
index 80b5026fed..a4383f2503 100644
--- a/java/org/apache/catalina/core/StandardServer.java
+++ b/java/org/apache/catalina/core/StandardServer.java
@@ -901,6 +901,12 @@ public final class StandardServer extends 
LifecycleMBeanBase implements Server {
 fireLifecycleEvent(CONFIGURE_START_EVENT, null);
 setState(LifecycleState.STARTING);
 
+// Initialize utility executor
+synchronized (utilityExecutorLock) {
+
reconfigureUtilityExecutor(getUtilityThreadsInternal(utilityThreads));
+register(utilityExecutor, "type=UtilityExecutor");
+}
+
 globalNamingResources.start();
 
 // Start our defined Services
@@ -961,6 +967,14 @@ public final class StandardServer extends 
LifecycleMBeanBase implements Server {

[tomcat] branch main updated (43643fe02c -> 4b097bf2e9)

2023-05-04 Thread markt

This is an automated email from the ASF dual-hosted git repository.

markt pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git


from 43643fe02c Add JRE fix detail to workaround so it can be removed later.
 new 71032f7b29 Improve locking of utility executor
 new 4b097bf2e9 Move management of utility executor from init/destroy to 
start/stop

The 2 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 java/org/apache/catalina/connector/Connector.java  | 13 +++--
 java/org/apache/catalina/core/ContainerBase.java   | 20 +++-
 java/org/apache/catalina/core/StandardServer.java  | 59 --
 .../apache/catalina/ha/tcp/SimpleTcpCluster.java   |  5 +-
 webapps/docs/changelog.xml |  5 ++
 5 files changed, 60 insertions(+), 42 deletions(-)


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch main updated (4b097bf2e9 -> c0f2c6a522)

2023-05-04 Thread markt

This is an automated email from the ASF dual-hosted git repository.

markt pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git


from 4b097bf2e9 Move management of utility executor from init/destroy to 
start/stop
 add c0f2c6a522 Prep for next dev cycle

No new revisions were added by this update.

Summary of changes:
 build.properties.default | 2 +-
 res/maven/mvn.properties.default | 2 +-
 webapps/docs/changelog.xml   | 4 +++-
 3 files changed, 5 insertions(+), 3 deletions(-)


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch main updated (c0f2c6a522 -> 5299e434ae)

2023-05-04 Thread markt

This is an automated email from the ASF dual-hosted git repository.

markt pushed a change to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git


from c0f2c6a522 Prep for next dev cycle
 add 5299e434ae Move entry to correct version

No new revisions were added by this update.

Summary of changes:
 webapps/docs/changelog.xml | 14 +-
 1 file changed, 9 insertions(+), 5 deletions(-)


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [tomcat] 02/02: Move management of utility executor from init/destroy to start/stop

2023-05-04 Thread Mark Thomas


On 04/05/2023 14:41, ma...@apache.org wrote:

This is an automated email from the ASF dual-hosted git repository.

markt pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/tomcat.git

commit 4b097bf2e9075e9e2949ec5aa410cba3c2b85374
Author: Mark Thomas 
AuthorDate: Thu May 4 14:41:01 2023 +0100

 Move management of utility executor from init/destroy to start/stop


My plan is to back-port this to earlier versions once the May releases 
have been tagged.


Mark

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] tag 9.0.75 created (now 2f528c02a9)

2023-05-04 Thread remm

This is an automated email from the ASF dual-hosted git repository.

remm pushed a change to tag 9.0.75
in repository https://gitbox.apache.org/repos/asf/tomcat.git


  at 2f528c02a9 (commit)
This tag includes the following new commits:

 new 2f528c02a9 Tag 9.0.75

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] 01/01: Tag 9.0.75

2023-05-04 Thread remm

This is an automated email from the ASF dual-hosted git repository.

remm pushed a commit to tag 9.0.75
in repository https://gitbox.apache.org/repos/asf/tomcat.git

commit 2f528c02a9b54cc210897f75492a2bb6eac326b5
Author: remm 
AuthorDate: Thu May 4 15:57:25 2023 +0200

Tag 9.0.75
---
 build.properties.release |  52 +++
 res/install-win/Uninstall.exe.sig| Bin 0 -> 10247 bytes
 res/install-win/tomcat-installer.exe.sig | Bin 0 -> 10247 bytes
 res/maven/mvn.properties.release |  27 
 webapps/docs/changelog.xml   |   2 +-
 5 files changed, 80 insertions(+), 1 deletion(-)

diff --git a/build.properties.release b/build.properties.release
new file mode 100644
index 00..c01ef5aa4e
--- /dev/null
+++ b/build.properties.release
@@ -0,0 +1,52 @@
+# -
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+# -
+
+# This file was auto-generated by the pre-release Ant target.
+
+# Any unwanted settings may be over-ridden in a build.properties file located
+# in the same directory as this file.
+
+# Set the version-dev to "" (empty string) as this is not a development 
release.
+version.dev=
+
+# Ensure consistent timestamps for reproducible builds.
+ant.tstamp.now.iso=2023-05-04T13:04:05Z
+
+# Enable insertion of detached signatures into the Windows installer.
+do.codesigning=true
+
+# Re-use the same GPG executable.
+gpg.exec=/usr/bin/gpg
+
+# Reproducible builds require the use of the build tools defined below. The
+# vendors (where appropriate) and versions must match exactly for a 
reproducible
+# build since this data is embedded in various files, particularly JAR file
+# manifests, as part of the build process.
+#
+# Apache Ant:  Apache Ant(TM) version 1.10.12 compiled on July 20 2022
+#
+# Java Name:   OpenJDK 64-Bit Server VM
+# Java Vendor: Eclipse Adoptium
+# Java Version:11.0.18+10
+
+# The following is provided for information only. Builds will be repeatable
+# whether or not the build environment in consistent with this information.
+#
+# OS:  amd64 Linux 6.2.13-200.fc37.x86_64
+# File encoding:   UTF-8
+#
+# Release Manager: remm
diff --git a/res/install-win/Uninstall.exe.sig 
b/res/install-win/Uninstall.exe.sig
new file mode 100644
index 00..db5d332cee
Binary files /dev/null and b/res/install-win/Uninstall.exe.sig differ
diff --git a/res/install-win/tomcat-installer.exe.sig 
b/res/install-win/tomcat-installer.exe.sig
new file mode 100644
index 00..be3b65078a
Binary files /dev/null and b/res/install-win/tomcat-installer.exe.sig differ
diff --git a/res/maven/mvn.properties.release b/res/maven/mvn.properties.release
new file mode 100644
index 00..b94a1eb7fe
--- /dev/null
+++ b/res/maven/mvn.properties.release
@@ -0,0 +1,27 @@
+# -
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+# -
+
+# This file was auto-generated by the pre-release Ant target.
+
+# Remove "-dev" from the version since this is not a development release.
+maven.asf.release.deploy.version=9.0.75
+
+# Re-use the same GPG executable.
+gpg.exec=/usr/bin/gpg
+
+# Set the user name to use to upload the artefacts to Nexus.
+asf.ldap.username=r

svn commit: r61629 - in /dev/tomcat/tomcat-9/v9.0.75: ./ bin/ bin/embed/ src/

2023-05-04 Thread remm

Author: remm
Date: Thu May  4 14:02:21 2023
New Revision: 61629

Log:
Upload 9.0.75 for voting

Added:
dev/tomcat/tomcat-9/v9.0.75/
dev/tomcat/tomcat-9/v9.0.75/KEYS
dev/tomcat/tomcat-9/v9.0.75/README.html
dev/tomcat/tomcat-9/v9.0.75/RELEASE-NOTES
dev/tomcat/tomcat-9/v9.0.75/bin/
dev/tomcat/tomcat-9/v9.0.75/bin/README.html
dev/tomcat/tomcat-9/v9.0.75/bin/apache-tomcat-9.0.75-deployer.tar.gz   
(with props)
dev/tomcat/tomcat-9/v9.0.75/bin/apache-tomcat-9.0.75-deployer.tar.gz.asc   
(with props)
dev/tomcat/tomcat-9/v9.0.75/bin/apache-tomcat-9.0.75-deployer.tar.gz.sha512
dev/tomcat/tomcat-9/v9.0.75/bin/apache-tomcat-9.0.75-deployer.zip   (with 
props)
dev/tomcat/tomcat-9/v9.0.75/bin/apache-tomcat-9.0.75-deployer.zip.asc   
(with props)
dev/tomcat/tomcat-9/v9.0.75/bin/apache-tomcat-9.0.75-deployer.zip.sha512
dev/tomcat/tomcat-9/v9.0.75/bin/apache-tomcat-9.0.75-fulldocs.tar.gz   
(with props)
dev/tomcat/tomcat-9/v9.0.75/bin/apache-tomcat-9.0.75-fulldocs.tar.gz.asc   
(with props)
dev/tomcat/tomcat-9/v9.0.75/bin/apache-tomcat-9.0.75-fulldocs.tar.gz.sha512
dev/tomcat/tomcat-9/v9.0.75/bin/apache-tomcat-9.0.75-windows-x64.zip   
(with props)
dev/tomcat/tomcat-9/v9.0.75/bin/apache-tomcat-9.0.75-windows-x64.zip.asc   
(with props)
dev/tomcat/tomcat-9/v9.0.75/bin/apache-tomcat-9.0.75-windows-x64.zip.sha512
dev/tomcat/tomcat-9/v9.0.75/bin/apache-tomcat-9.0.75-windows-x86.zip   
(with props)
dev/tomcat/tomcat-9/v9.0.75/bin/apache-tomcat-9.0.75-windows-x86.zip.asc   
(with props)
dev/tomcat/tomcat-9/v9.0.75/bin/apache-tomcat-9.0.75-windows-x86.zip.sha512
dev/tomcat/tomcat-9/v9.0.75/bin/apache-tomcat-9.0.75.exe   (with props)
dev/tomcat/tomcat-9/v9.0.75/bin/apache-tomcat-9.0.75.exe.asc   (with props)
dev/tomcat/tomcat-9/v9.0.75/bin/apache-tomcat-9.0.75.exe.sha512
dev/tomcat/tomcat-9/v9.0.75/bin/apache-tomcat-9.0.75.tar.gz   (with props)
dev/tomcat/tomcat-9/v9.0.75/bin/apache-tomcat-9.0.75.tar.gz.asc   (with 
props)
dev/tomcat/tomcat-9/v9.0.75/bin/apache-tomcat-9.0.75.tar.gz.sha512
dev/tomcat/tomcat-9/v9.0.75/bin/apache-tomcat-9.0.75.zip   (with props)
dev/tomcat/tomcat-9/v9.0.75/bin/apache-tomcat-9.0.75.zip.asc   (with props)
dev/tomcat/tomcat-9/v9.0.75/bin/apache-tomcat-9.0.75.zip.sha512
dev/tomcat/tomcat-9/v9.0.75/bin/embed/
dev/tomcat/tomcat-9/v9.0.75/bin/embed/apache-tomcat-9.0.75-embed.tar.gz   
(with props)
dev/tomcat/tomcat-9/v9.0.75/bin/embed/apache-tomcat-9.0.75-embed.tar.gz.asc 
  (with props)

dev/tomcat/tomcat-9/v9.0.75/bin/embed/apache-tomcat-9.0.75-embed.tar.gz.sha512
dev/tomcat/tomcat-9/v9.0.75/bin/embed/apache-tomcat-9.0.75-embed.zip   
(with props)
dev/tomcat/tomcat-9/v9.0.75/bin/embed/apache-tomcat-9.0.75-embed.zip.asc   
(with props)
dev/tomcat/tomcat-9/v9.0.75/bin/embed/apache-tomcat-9.0.75-embed.zip.sha512
dev/tomcat/tomcat-9/v9.0.75/src/
dev/tomcat/tomcat-9/v9.0.75/src/apache-tomcat-9.0.75-src.tar.gz   (with 
props)
dev/tomcat/tomcat-9/v9.0.75/src/apache-tomcat-9.0.75-src.tar.gz.asc   (with 
props)
dev/tomcat/tomcat-9/v9.0.75/src/apache-tomcat-9.0.75-src.tar.gz.sha512
dev/tomcat/tomcat-9/v9.0.75/src/apache-tomcat-9.0.75-src.zip   (with props)
dev/tomcat/tomcat-9/v9.0.75/src/apache-tomcat-9.0.75-src.zip.asc   (with 
props)
dev/tomcat/tomcat-9/v9.0.75/src/apache-tomcat-9.0.75-src.zip.sha512

Added: dev/tomcat/tomcat-9/v9.0.75/KEYS
==
--- dev/tomcat/tomcat-9/v9.0.75/KEYS (added)
+++ dev/tomcat/tomcat-9/v9.0.75/KEYS Thu May  4 14:02:21 2023
@@ -0,0 +1,237 @@
+This file contains the PGP&GPG keys of various Apache developers.
+Please don't use them for email unless you have to. Their main
+purpose is code signing.
+
+Apache users: pgp < KEYS
+Apache developers:
+(pgpk -ll  && pgpk -xa ) >> this file.
+  or
+(gpg --fingerprint --list-sigs 
+ && gpg --armor --export ) >> this file.
+
+Apache developers: please ensure that your key is also available via the
+PGP keyservers (such as pgpkeys.mit.edu).
+
+
+pub   1024D/33C60243 2004-09-12
+  Key fingerprint = DCFD 35E0 BF8C A734 4752  DE8B 6FB2 1E89 33C6 0243
+uid  Mark E D Thomas 
+uid  Mark E D Thomas 
+uid  Mark E D Thomas 
+sub   2048g/0BECE548 2004-09-12
+
+pub   4096R/2F6059E7 2009-09-18
+  Key fingerprint = A9C5 DF4D 22E9 9998 D987  5A51 10C0 1C5A 2F60 59E7
+uid  Mark E D Thomas 
+sub   4096R/5E763BEC 2009-09-18
+
+-BEGIN PGP PUBLIC KEY BLOCK-
+Version: GnuPG v1.4.9 (MingW32)
+
+mQGiBEFEjegRBADocGttfROvtLGrTOW3xRqZHmFWybmEaI6jmnRdN/1gGXmb3wQL
+rHsS3fLFIIOYLPph0Kov9q4qNq36LekShIvjMBDFoj2/wRxaUtFq81asaRZg8Mcw
+4kVeIoe8OIOuWmvYhU8SH2jJNUnVVrpTPAa6QWquTmseNi6UJMjLxuL7DwCg//9u
+k2yj0vk6e4WSO6Fe5+EkQDED/AjQsy0kj9TpNHkKSSUR2evRlWPYA0YtxBSbsgON
+tT0cYipAp5IcYt6Zq5QzHiZreyQXLAjItDS2oGCIXfNbTYJ3kxxJTCU/3wlefV

[tomcat] branch 9.0.x updated: Next is 9.0.76

2023-05-04 Thread remm

This is an automated email from the ASF dual-hosted git repository.

remm pushed a commit to branch 9.0.x
in repository https://gitbox.apache.org/repos/asf/tomcat.git


The following commit(s) were added to refs/heads/9.0.x by this push:
 new ee0f9fe5cd Next is 9.0.76
ee0f9fe5cd is described below

commit ee0f9fe5cd011652f47e8f4ae2c6810d264bfa7c
Author: remm 
AuthorDate: Thu May 4 16:04:39 2023 +0200

Next is 9.0.76
---
 build.properties.default | 2 +-
 res/maven/mvn.properties.default | 2 +-
 webapps/docs/changelog.xml   | 4 +++-
 3 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/build.properties.default b/build.properties.default
index 7481ed15ae..307c338400 100644
--- a/build.properties.default
+++ b/build.properties.default
@@ -31,7 +31,7 @@
 # - Version Control Flags -
 version.major=9
 version.minor=0
-version.build=75
+version.build=76
 version.patch=0
 version.suffix=
 version.dev=-dev
diff --git a/res/maven/mvn.properties.default b/res/maven/mvn.properties.default
index fc59aa9fdd..ba78fda46d 100644
--- a/res/maven/mvn.properties.default
+++ b/res/maven/mvn.properties.default
@@ -39,7 +39,7 @@ 
maven.asf.release.repo.url=https://repository.apache.org/service/local/staging/d
 maven.asf.release.repo.repositoryId=apache.releases.https
 
 # Release version info
-maven.asf.release.deploy.version=9.0.75
+maven.asf.release.deploy.version=9.0.76
 
 #Where do we load the libraries from
 tomcat.lib.path=../../output/build/lib
diff --git a/webapps/docs/changelog.xml b/webapps/docs/changelog.xml
index 0898219add..5018ed8d54 100644
--- a/webapps/docs/changelog.xml
+++ b/webapps/docs/changelog.xml
@@ -104,7 +104,9 @@
   They eventually become mixed with the numbered issues (i.e., numbered
   issues do not "pop up" wrt. others).
 -->
-
+
+
+
   
 
   


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [tomcat] 02/02: Move management of utility executor from init/destroy to start/stop

2023-05-04 Thread Rémy Maucherat

On Thu, May 4, 2023 at 3:46 PM Mark Thomas  wrote:
>
> On 04/05/2023 14:41, ma...@apache.org wrote:
> > This is an automated email from the ASF dual-hosted git repository.
> >
> > markt pushed a commit to branch main
> > in repository https://gitbox.apache.org/repos/asf/tomcat.git
> >
> > commit 4b097bf2e9075e9e2949ec5aa410cba3c2b85374
> > Author: Mark Thomas 
> > AuthorDate: Thu May 4 14:41:01 2023 +0100
> >
> >  Move management of utility executor from init/destroy to start/stop
>
> My plan is to back-port this to earlier versions once the May releases
> have been tagged.

Thanks ;)

Rémy

> Mark
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Java 21 and virtual threads

2023-05-04 Thread Rémy Maucherat

On Thu, May 4, 2023 at 2:37 PM Mark Thomas  wrote:
>
> Hi all,
>
> The latest Java 21 EA build has moved virtual threads (from project
> Loom) out of preview. How do we want to handle this in Tomcat 11? Recall
> that Jakarta EE 11 has set Java 21 as the minimum version.
>
> I think we have the following options:
>
> 1. Stick with Java 17 as the minimum version and don't provide virtual
> thread functionality.
>
> 2. Stick with Java 17 as the minimum version and provide virtual thread
> functionality via the JreCompat module.
>
> 3. Increase minimum Java version to Java 21 for Tomcat 11 and provide
> virtual thread functionality.
>
> I am currently leaning towards 3 but could live with 2.
>
> Thoughts? Other options?

I'm ok with 3) personally. I'm not sure about Panama moving out of
preview at the moment though.

Rémy

> Mark
>
> PS Option 3 will require updates to the CI systems - I am happy to take
> care of those.
>
> PPS I don't think all of the current Loom module will make it into
> Tomcat 11. I am currently thinking to pull in the Executor and then
> provide a boolean option for the existing endpoints to switch the
> internal executor to Loom.
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[VOTE] Release Apache Tomcat 9.0.75

2023-05-04 Thread Rémy Maucherat

The proposed Apache Tomcat 9.0.75 release is now available for voting.

The notable changes compared to 9.0.74 are:

- Many improvements to the json access log valve.

- Deprecate support for the HTTP Connector settings rejectIllegalHeader and
   allowHostHeaderMismatch.

Along with lots of other bug fixes and improvements.

For full details, see the changelog:
https://nightlies.apache.org/tomcat/tomcat-9.0.x/docs/changelog.html

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.75/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1433
The tag is:
https://github.com/apache/tomcat/tree/9.0.75
2f528c02a9b54cc210897f75492a2bb6eac326b5

The proposed 9.0.75 release is:
[ ] -1, Broken - do not release
[ ] +1, Stable - go ahead and release as 9.0.75

Rémy

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 11.0.0-M6

2023-05-04 Thread Dimitris Soumis

I am getting the following error (multiple times) when running the tests:

[junit] Running org.apache.catalina.connector.TestRequest
[junit] 04-May-2023 17:04:29.019 INFO [main]
org.apache.catalina.startup.LoggingBaseTest.setUp Starting test case
[testGetReaderValidEncoding]
[junit] 04-May-2023 17:04:29.229 INFO [main]
org.apache.coyote.AbstractProtocol.init Initializing ProtocolHandler
["http-nio-127.0.0.1-auto-1"]
[junit] 04-May-2023 17:04:29.241 INFO [main]
org.apache.catalina.core.StandardService.startInternal Starting service
[Tomcat]
[junit] 04-May-2023 17:04:29.241 INFO [main]
org.apache.catalina.core.StandardEngine.startInternal Starting Servlet
engine: [Apache Tomcat/11.0.0-M6]
[junit] 04-May-2023 17:04:29.285 INFO [main]
org.apache.coyote.AbstractProtocol.start Starting ProtocolHandler
["http-nio-127.0.0.1-auto-1-33153"]
[junit] 04-May-2023 17:04:29.314 SEVERE
[http-nio-127.0.0.1-auto-1-exec-1]
org.apache.coyote.AbstractProtocol$ConnectionHandler.process Error reading
request, ignored
[junit] java.lang.NoClassDefFoundError:
org/apache/tomcat/util/http/ValuesEnumerator
[junit] at
org.apache.tomcat.util.http.MimeHeaders.values(MimeHeaders.java:253)
[junit] at
org.apache.coyote.http11.Http11Processor.isConnectionToken(Http11Processor.java:1082)
[junit] at
org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:324)
[junit] at
org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:63)
[junit] at
org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:894)
[junit] at
org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1742)
[junit] at
org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:52)
[junit] at
org.apache.tomcat.util.threads.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
[junit] at
org.apache.tomcat.util.threads.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:636)
[junit] at
org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
[junit] at java.base/java.lang.Thread.run(Thread.java:833)
[junit] Caused by: java.lang.ClassNotFoundException:
org.apache.tomcat.util.http.ValuesEnumerator
[junit] at
java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:641)
[junit] at
java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188)
[junit] at
java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:520)
[junit] ... 11 more

On Wed, May 3, 2023 at 9:46 PM Mark Thomas  wrote:

> The proposed Apache Tomcat 11.0.0-M6 release is now available for
> voting.
>
> Apache Tomcat 11.0.0-M6 is a milestone release of the 11.0.x branch and
> has been made to provide users with early access to the new features in
> Apache Tomcat 11.0.x so that they may provide feedback. The notable
> changes compared to the previous milestone include:
>
> - Various improvements to access logging.
>
> - Remove support for the HTTP Connector settings rejectIllegalHeader and
>allowHostHeaderMismatch. These are now hard-coded to the previous
>defaults.
>
> - Update the packaged version of the Tomcat Migration Tool for Jakarta
>EE to 1.0.7.
>
>
> For full details, see the change log:
> https://nightlies.apache.org/tomcat/tomcat-11.0.x/docs/changelog.html
>
> Applications that run on Tomcat 9 and earlier will not run on Tomcat 11
> without changes. Java EE applications designed for Tomcat 9 and earlier
> may be placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat
> will automatically convert them to Jakarta EE and copy them to the
> webapps directory. Applications using deprecated APIs may require
> further changes.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-11/v11.0.0-M6/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1432
>
> The tag is:
> https://github.com/apache/tomcat/tree/11.0.0-M6
> 9ce010463a93138d596c54c67b11cdb35fc8244a
>
>
> The proposed 11.0.0-M6 release is:
> [ ] Broken - do not release
> [ ] Alpha  - go ahead and release as 11.0.0-M6
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: [VOTE] Release Apache Tomcat 11.0.0-M6

2023-05-04 Thread Mark Thomas


On 04/05/2023 19:16, Dimitris Soumis wrote:

I am getting the following error (multiple times) when running the tests:


Platform?

Java version?

build.properties settings?

Mark




[junit] Running org.apache.catalina.connector.TestRequest
 [junit] 04-May-2023 17:04:29.019 INFO [main]
org.apache.catalina.startup.LoggingBaseTest.setUp Starting test case
[testGetReaderValidEncoding]
 [junit] 04-May-2023 17:04:29.229 INFO [main]
org.apache.coyote.AbstractProtocol.init Initializing ProtocolHandler
["http-nio-127.0.0.1-auto-1"]
 [junit] 04-May-2023 17:04:29.241 INFO [main]
org.apache.catalina.core.StandardService.startInternal Starting service
[Tomcat]
 [junit] 04-May-2023 17:04:29.241 INFO [main]
org.apache.catalina.core.StandardEngine.startInternal Starting Servlet
engine: [Apache Tomcat/11.0.0-M6]
 [junit] 04-May-2023 17:04:29.285 INFO [main]
org.apache.coyote.AbstractProtocol.start Starting ProtocolHandler
["http-nio-127.0.0.1-auto-1-33153"]
 [junit] 04-May-2023 17:04:29.314 SEVERE
[http-nio-127.0.0.1-auto-1-exec-1]
org.apache.coyote.AbstractProtocol$ConnectionHandler.process Error reading
request, ignored
 [junit] java.lang.NoClassDefFoundError:
org/apache/tomcat/util/http/ValuesEnumerator
 [junit] at
org.apache.tomcat.util.http.MimeHeaders.values(MimeHeaders.java:253)
 [junit] at
org.apache.coyote.http11.Http11Processor.isConnectionToken(Http11Processor.java:1082)
 [junit] at
org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:324)
 [junit] at
org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:63)
 [junit] at
org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:894)
 [junit] at
org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1742)
 [junit] at
org.apache.tomcat.util.net.SocketProcessorBase.run(SocketProcessorBase.java:52)
 [junit] at
org.apache.tomcat.util.threads.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
 [junit] at
org.apache.tomcat.util.threads.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:636)
 [junit] at
org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
 [junit] at java.base/java.lang.Thread.run(Thread.java:833)
 [junit] Caused by: java.lang.ClassNotFoundException:
org.apache.tomcat.util.http.ValuesEnumerator
 [junit] at
java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:641)
 [junit] at
java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188)
 [junit] at
java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:520)
 [junit] ... 11 more


On Wed, May 3, 2023 at 9:46 PM Mark Thomas  wrote:


The proposed Apache Tomcat 11.0.0-M6 release is now available for
voting.

Apache Tomcat 11.0.0-M6 is a milestone release of the 11.0.x branch and
has been made to provide users with early access to the new features in
Apache Tomcat 11.0.x so that they may provide feedback. The notable
changes compared to the previous milestone include:

- Various improvements to access logging.

- Remove support for the HTTP Connector settings rejectIllegalHeader and
allowHostHeaderMismatch. These are now hard-coded to the previous
defaults.

- Update the packaged version of the Tomcat Migration Tool for Jakarta
EE to 1.0.7.


For full details, see the change log:
https://nightlies.apache.org/tomcat/tomcat-11.0.x/docs/changelog.html

Applications that run on Tomcat 9 and earlier will not run on Tomcat 11
without changes. Java EE applications designed for Tomcat 9 and earlier
may be placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat
will automatically convert them to Jakarta EE and copy them to the
webapps directory. Applications using deprecated APIs may require
further changes.

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-11/v11.0.0-M6/

The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1432

The tag is:
https://github.com/apache/tomcat/tree/11.0.0-M6
9ce010463a93138d596c54c67b11cdb35fc8244a


The proposed 11.0.0-M6 release is:
[ ] Broken - do not release
[ ] Alpha  - go ahead and release as 11.0.0-M6

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org






-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [VOTE] Release Apache Tomcat 11.0.0-M6

2023-05-04 Thread Dimitris Soumis

My sincere apologies, I had a misconfigured Java.

+1
Tests pass on Linux.


On Thu, May 4, 2023 at 9:31 PM Mark Thomas  wrote:

> On 04/05/2023 19:16, Dimitris Soumis wrote:
> > I am getting the following error (multiple times) when running the tests:
>
> Platform?
>
> Java version?
>
> build.properties settings?
>
> Mark
>
> >
> >
> > [junit] Running org.apache.catalina.connector.TestRequest
> >  [junit] 04-May-2023 17:04:29.019 INFO [main]
> > org.apache.catalina.startup.LoggingBaseTest.setUp Starting test case
> > [testGetReaderValidEncoding]
> >  [junit] 04-May-2023 17:04:29.229 INFO [main]
> > org.apache.coyote.AbstractProtocol.init Initializing ProtocolHandler
> > ["http-nio-127.0.0.1-auto-1"]
> >  [junit] 04-May-2023 17:04:29.241 INFO [main]
> > org.apache.catalina.core.StandardService.startInternal Starting service
> > [Tomcat]
> >  [junit] 04-May-2023 17:04:29.241 INFO [main]
> > org.apache.catalina.core.StandardEngine.startInternal Starting Servlet
> > engine: [Apache Tomcat/11.0.0-M6]
> >  [junit] 04-May-2023 17:04:29.285 INFO [main]
> > org.apache.coyote.AbstractProtocol.start Starting ProtocolHandler
> > ["http-nio-127.0.0.1-auto-1-33153"]
> >  [junit] 04-May-2023 17:04:29.314 SEVERE
> > [http-nio-127.0.0.1-auto-1-exec-1]
> > org.apache.coyote.AbstractProtocol$ConnectionHandler.process Error
> reading
> > request, ignored
> >  [junit] java.lang.NoClassDefFoundError:
> > org/apache/tomcat/util/http/ValuesEnumerator
> >  [junit] at
> > org.apache.tomcat.util.http.MimeHeaders.values(MimeHeaders.java:253)
> >  [junit] at
> >
> org.apache.coyote.http11.Http11Processor.isConnectionToken(Http11Processor.java:1082)
> >  [junit] at
> >
> org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:324)
> >  [junit] at
> >
> org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:63)
> >  [junit] at
> >
> org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:894)
> >  [junit] at
> > org.apache.tomcat.util.net
> .NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1742)
> >  [junit] at
> > org.apache.tomcat.util.net
> .SocketProcessorBase.run(SocketProcessorBase.java:52)
> >  [junit] at
> >
> org.apache.tomcat.util.threads.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
> >  [junit] at
> >
> org.apache.tomcat.util.threads.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:636)
> >  [junit] at
> >
> org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)
> >  [junit] at java.base/java.lang.Thread.run(Thread.java:833)
> >  [junit] Caused by: java.lang.ClassNotFoundException:
> > org.apache.tomcat.util.http.ValuesEnumerator
> >  [junit] at
> >
> java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:641)
> >  [junit] at
> >
> java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188)
> >  [junit] at
> > java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:520)
> >  [junit] ... 11 more
> >
> >
> > On Wed, May 3, 2023 at 9:46 PM Mark Thomas  wrote:
> >
> >> The proposed Apache Tomcat 11.0.0-M6 release is now available for
> >> voting.
> >>
> >> Apache Tomcat 11.0.0-M6 is a milestone release of the 11.0.x branch and
> >> has been made to provide users with early access to the new features in
> >> Apache Tomcat 11.0.x so that they may provide feedback. The notable
> >> changes compared to the previous milestone include:
> >>
> >> - Various improvements to access logging.
> >>
> >> - Remove support for the HTTP Connector settings rejectIllegalHeader and
> >> allowHostHeaderMismatch. These are now hard-coded to the previous
> >> defaults.
> >>
> >> - Update the packaged version of the Tomcat Migration Tool for Jakarta
> >> EE to 1.0.7.
> >>
> >>
> >> For full details, see the change log:
> >> https://nightlies.apache.org/tomcat/tomcat-11.0.x/docs/changelog.html
> >>
> >> Applications that run on Tomcat 9 and earlier will not run on Tomcat 11
> >> without changes. Java EE applications designed for Tomcat 9 and earlier
> >> may be placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat
> >> will automatically convert them to Jakarta EE and copy them to the
> >> webapps directory. Applications using deprecated APIs may require
> >> further changes.
> >>
> >> It can be obtained from:
> >> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-11/v11.0.0-M6/
> >>
> >> The Maven staging repo is:
> >> https://repository.apache.org/content/repositories/orgapachetomcat-1432
> >>
> >> The tag is:
> >> https://github.com/apache/tomcat/tree/11.0.0-M6
> >> 9ce010463a93138d596c54c67b11cdb35fc8244a
> >>
> >>
> >> The proposed 11.0.0-M6 release is:
> >> [ ] Broken - do not release
> >> [X] Alpha  - go ahead and release as 11.0.0-M6
> >>
> >> -
> >> To unsubscribe, e-mail: dev-unsubscr...@to

[Bug 66593] New: Connector attribute allowHostHeaderMismatch=false fails to reject host header injection attacks

2023-05-04 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=66593

Bug ID: 66593
   Summary: Connector attribute allowHostHeaderMismatch=false
fails to reject host header injection attacks
   Product: Tomcat 9
   Version: 9.0.73
  Hardware: PC
OS: All
Status: NEW
  Severity: critical
  Priority: P2
 Component: Connectors
  Assignee: dev@tomcat.apache.org
  Reporter: alvaro.ga...@ibm.com
  Target Milestone: -

Hi,

It appears Tomcat Connector layer is not protecting the API from host header
injection attack. 

For instance, Tomcat will allow the following requests to continue when
allowHostHeaderMismatch="false"

// new hostname and default port number in host header
curl --request 'POST' \
 --url 'http://myhostname.com:8143/api/v1/endpoint' \
 --header 'Host: facebook.com'

// new hostname and new port number in host header
curl --request 'POST' \
 --url 'http://myhostname.com:8143/api/v1/endpoint' \
 --header 'Host: facebook.com:8000'


So, the API will get the injected Host header values during
httpRequest.getServerName() or httpRequest.getServerPort() methods where
httpRequest is an object from HttpServletRequest.

Could you please clarify if I am miss-understanding something? I did read that
telnet makes it work. However, I am puzzled that with the curl command it is
not.

Thanks,
Alvaro

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Java 21 and virtual threads

2023-05-04 Thread Han Li




> On May 4, 2023, at 20:37, Mark Thomas  wrote:
> 
> Hi all,
> 
> The latest Java 21 EA build has moved virtual threads (from project Loom) out 
> of preview. How do we want to handle this in Tomcat 11? Recall that Jakarta 
> EE 11 has set Java 21 as the minimum version.
> 
> I think we have the following options:
> 
> 1. Stick with Java 17 as the minimum version and don't provide virtual thread 
> functionality.
> 
> 2. Stick with Java 17 as the minimum version and provide virtual thread 
> functionality via the JreCompat module.
> 
> 3. Increase minimum Java version to Java 21 for Tomcat 11 and provide virtual 
> thread functionality.
+1

The impact of switching 17 to 21 will not be very wide I think as Tomcat 11 is 
Alpha version now, so let’s be straightforward. :)

Han

> 
> I am currently leaning towards 3 but could live with 2.
> 
> Thoughts? Other options?
> 
> Mark
> 
> PS Option 3 will require updates to the CI systems - I am happy to take care 
> of those.
> 
> PPS I don't think all of the current Loom module will make it into Tomcat 11. 
> I am currently thinking to pull in the Executor and then provide a boolean 
> option for the existing endpoints to switch the internal executor to Loom.
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 66593] Connector attribute allowHostHeaderMismatch=false fails to reject host header injection attacks

2023-05-04 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=66593

--- Comment #1 from Han Li  ---
> Could you please clarify if I am miss-understanding something? 
Sure, If you read doc carefully, you will find which compare one host in
`request line
> I did read that telnet makes it work. However, I am puzzled that with the 
> curl command
> it is not.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[Bug 66593] Connector attribute allowHostHeaderMismatch=false fails to reject host header injection attacks

2023-05-04 Thread bugzilla

https://bz.apache.org/bugzilla/show_bug.cgi?id=66593

Han Li  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|NEW |RESOLVED

--- Comment #2 from Han Li  ---
> Could you please clarify if I am miss-understanding something? 

Sure, If you read doc carefully, you will find which describe that compare the
host in `request line` with the host in host header.

You can look at detail of request by using -v of curl command

* Connected to myhostname (127.0.0.1) port 8143 (#0)
> POST /api/v1/endpoint HTTP/1.1.   < request line
> Host: facebook.com
> User-Agent: curl/7.79.1
> Accept: */*

PS: Bugzilla is not a support forum, if you have any question, you should post
content to user mailing list.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: [tomcat] 02/02: Move management of utility executor from init/destroy to start/stop

2023-05-04 Thread Han Li




> On May 4, 2023, at 21:41, ma...@apache.org wrote:
> 
> This is an automated email from the ASF dual-hosted git repository.
> 
> markt pushed a commit to branch main
> in repository https://gitbox.apache.org/repos/asf/tomcat.git
> 
> commit 4b097bf2e9075e9e2949ec5aa410cba3c2b85374
> Author: Mark Thomas 
> AuthorDate: Thu May 4 14:41:01 2023 +0100
> 
>Move management of utility executor from init/destroy to start/stop
> ---
> java/org/apache/catalina/connector/Connector.java  | 13 +++---
> java/org/apache/catalina/core/ContainerBase.java   | 20 +++-
> java/org/apache/catalina/core/StandardServer.java  | 28 +++---
> .../apache/catalina/ha/tcp/SimpleTcpCluster.java   |  5 +++-
> webapps/docs/changelog.xml |  5 
> 5 files changed, 41 insertions(+), 30 deletions(-)
> 
> diff --git a/java/org/apache/catalina/connector/Connector.java 
> b/java/org/apache/catalina/connector/Connector.java
> index c9200e20ca..dac7fdd642 100644
> --- a/java/org/apache/catalina/connector/Connector.java
> +++ b/java/org/apache/catalina/connector/Connector.java
> @@ -992,9 +992,6 @@ public class Connector extends LifecycleMBeanBase {
> // Initialize adapter
> adapter = new CoyoteAdapter(this);
> protocolHandler.setAdapter(adapter);
> -if (service != null) {
> -
> protocolHandler.setUtilityExecutor(service.getServer().getUtilityExecutor());
> -}
> 
> // Make sure parseBodyMethodsSet has a default
> if (null == parseBodyMethodsSet) {
> @@ -1035,6 +1032,11 @@ public class Connector extends LifecycleMBeanBase {
> 
> setState(LifecycleState.STARTING);
> 
> +// Configure the utility executor before starting the protocol 
> handler
> +if (service != null) {
> +
> protocolHandler.setUtilityExecutor(service.getServer().getUtilityExecutor());

According to check logic at line 1027,  the protocalHandler may be null, so 
need NPE check.
> +}
> +
> try {
> protocolHandler.start();
> } catch (Exception e) {
> @@ -1060,6 +1062,11 @@ public class Connector extends LifecycleMBeanBase {
> } catch (Exception e) {
> throw new 
> LifecycleException(sm.getString("coyoteConnector.protocolHandlerStopFailed"), 
> e);
> }
> +
> +// Remove the utility executor once the protocol handler has been 
> stopped
> +if (service != null) {
> +protocolHandler.setUtilityExecutor(null);
Same as above.

Han
> +}
> }
> 
> 
> diff --git a/java/org/apache/catalina/core/ContainerBase.java 
> b/java/org/apache/catalina/core/ContainerBase.java
> index 784c9032ef..a7e7c69a4a 100644
> --- a/java/org/apache/catalina/core/ContainerBase.java
> +++ b/java/org/apache/catalina/core/ContainerBase.java
> @@ -787,13 +787,6 @@ public abstract class ContainerBase extends 
> LifecycleMBeanBase implements Contai
> }
> 
> 
> -@Override
> -protected void initInternal() throws LifecycleException {
> -reconfigureStartStopExecutor(getStartStopThreads());
> -super.initInternal();
> -}
> -
> -
> private void reconfigureStartStopExecutor(int threads) {
> if (threads == 1) {
> // Use a fake executor
> @@ -819,6 +812,8 @@ public abstract class ContainerBase extends 
> LifecycleMBeanBase implements Contai
> @Override
> protected synchronized void startInternal() throws LifecycleException {
> 
> +reconfigureStartStopExecutor(getStartStopThreads());
> +
> // Start our subordinate components, if any
> logger = null;
> getLogger();
> @@ -925,6 +920,12 @@ public abstract class ContainerBase extends 
> LifecycleMBeanBase implements Contai
> if (cluster instanceof Lifecycle) {
> ((Lifecycle) cluster).stop();
> }
> +
> +// If init fails, this may be null
> +if (startStopExecutor != null) {
> +startStopExecutor.shutdownNow();
> +startStopExecutor = null;
> +}
> }
> 
> @Override
> @@ -954,11 +955,6 @@ public abstract class ContainerBase extends 
> LifecycleMBeanBase implements Contai
> parent.removeChild(this);
> }
> 
> -// If init fails, this may be null
> -if (startStopExecutor != null) {
> -startStopExecutor.shutdownNow();
> -}
> -
> super.destroyInternal();
> }
> 
> diff --git a/java/org/apache/catalina/core/StandardServer.java 
> b/java/org/apache/catalina/core/StandardServer.java
> index 80b5026fed..a4383f2503 100644
> --- a/java/org/apache/catalina/core/StandardServer.java
> +++ b/java/org/apache/catalina/core/StandardServer.java
> @@ -901,6 +901,12 @@ public final class StandardServer extends 
> LifecycleMBeanBase implements Server {
> fireLifecycleEvent(CONFIGURE_START_EVENT, null);
> setState(LifecycleState.STARTING);
> 
> +// Initialize utility executor
> +syn

Re: [VOTE] Release Apache Tomcat 9.0.75

2023-05-04 Thread Han Li




> On May 4, 2023, at 22:20, Rémy Maucherat  wrote:
> 
> The proposed Apache Tomcat 9.0.75 release is now available for voting.
> 
> The notable changes compared to 9.0.74 are:
> 
> - Many improvements to the json access log valve.
> 
> - Deprecate support for the HTTP Connector settings rejectIllegalHeader and
>   allowHostHeaderMismatch.
> 
> Along with lots of other bug fixes and improvements.
> 
> For full details, see the changelog:
> https://nightlies.apache.org/tomcat/tomcat-9.0.x/docs/changelog.html
> 
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.75/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1433
> The tag is:
> https://github.com/apache/tomcat/tree/9.0.75
> 2f528c02a9b54cc210897f75492a2bb6eac326b5
> 
> The proposed 9.0.75 release is:
> [ ] -1, Broken - do not release
> [X ] +1, Stable - go ahead and release as 9.0.75

Test pass with tc-natvie 1.2.36 and OpenSSL 3.0.7 on macOS 12.3.1

Han
> 
> Rémy
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

Re: Java 21 and virtual threads

2023-05-04 Thread Romain Manni-Bucau

+1 for java 21, since tomcat 11 is still in the "dont use" area I think it
can start with 21 and thanks to the backport policy if java 17 is needed
later, work will not be crazy IMHO.

Romain Manni-Bucau
@rmannibucau  |  Blog
 | Old Blog
 | Github  |
LinkedIn  | Book



Le ven. 5 mai 2023 à 03:53, Han Li  a écrit :

>
>
> > On May 4, 2023, at 20:37, Mark Thomas  wrote:
> >
> > Hi all,
> >
> > The latest Java 21 EA build has moved virtual threads (from project
> Loom) out of preview. How do we want to handle this in Tomcat 11? Recall
> that Jakarta EE 11 has set Java 21 as the minimum version.
> >
> > I think we have the following options:
> >
> > 1. Stick with Java 17 as the minimum version and don't provide virtual
> thread functionality.
> >
> > 2. Stick with Java 17 as the minimum version and provide virtual thread
> functionality via the JreCompat module.
> >
> > 3. Increase minimum Java version to Java 21 for Tomcat 11 and provide
> virtual thread functionality.
> +1
>
> The impact of switching 17 to 21 will not be very wide I think as Tomcat
> 11 is Alpha version now, so let’s be straightforward. :)
>
> Han
>
> >
> > I am currently leaning towards 3 but could live with 2.
> >
> > Thoughts? Other options?
> >
> > Mark
> >
> > PS Option 3 will require updates to the CI systems - I am happy to take
> care of those.
> >
> > PPS I don't think all of the current Loom module will make it into
> Tomcat 11. I am currently thinking to pull in the Executor and then provide
> a boolean option for the existing endpoints to switch the internal executor
> to Loom.
> >
> > -
> > To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> > For additional commands, e-mail: dev-h...@tomcat.apache.org
> >
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>
>

Re: [VOTE] Release Apache Tomcat 11.0.0-M6

2023-05-04 Thread Mark Thomas


On 04/05/2023 21:41, Dimitris Soumis wrote:

My sincere apologies, I had a misconfigured Java.


No worries - easily done.


+1
Tests pass on Linux.


Thanks for the update.

Mark





On Thu, May 4, 2023 at 9:31 PM Mark Thomas  wrote:


On 04/05/2023 19:16, Dimitris Soumis wrote:

I am getting the following error (multiple times) when running the tests:


Platform?

Java version?

build.properties settings?

Mark




[junit] Running org.apache.catalina.connector.TestRequest
  [junit] 04-May-2023 17:04:29.019 INFO [main]
org.apache.catalina.startup.LoggingBaseTest.setUp Starting test case
[testGetReaderValidEncoding]
  [junit] 04-May-2023 17:04:29.229 INFO [main]
org.apache.coyote.AbstractProtocol.init Initializing ProtocolHandler
["http-nio-127.0.0.1-auto-1"]
  [junit] 04-May-2023 17:04:29.241 INFO [main]
org.apache.catalina.core.StandardService.startInternal Starting service
[Tomcat]
  [junit] 04-May-2023 17:04:29.241 INFO [main]
org.apache.catalina.core.StandardEngine.startInternal Starting Servlet
engine: [Apache Tomcat/11.0.0-M6]
  [junit] 04-May-2023 17:04:29.285 INFO [main]
org.apache.coyote.AbstractProtocol.start Starting ProtocolHandler
["http-nio-127.0.0.1-auto-1-33153"]
  [junit] 04-May-2023 17:04:29.314 SEVERE
[http-nio-127.0.0.1-auto-1-exec-1]
org.apache.coyote.AbstractProtocol$ConnectionHandler.process Error

reading

request, ignored
  [junit] java.lang.NoClassDefFoundError:
org/apache/tomcat/util/http/ValuesEnumerator
  [junit] at
org.apache.tomcat.util.http.MimeHeaders.values(MimeHeaders.java:253)
  [junit] at


org.apache.coyote.http11.Http11Processor.isConnectionToken(Http11Processor.java:1082)

  [junit] at


org.apache.coyote.http11.Http11Processor.service(Http11Processor.java:324)

  [junit] at


org.apache.coyote.AbstractProcessorLight.process(AbstractProcessorLight.java:63)

  [junit] at


org.apache.coyote.AbstractProtocol$ConnectionHandler.process(AbstractProtocol.java:894)

  [junit] at
org.apache.tomcat.util.net

.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1742)

  [junit] at
org.apache.tomcat.util.net

.SocketProcessorBase.run(SocketProcessorBase.java:52)

  [junit] at


org.apache.tomcat.util.threads.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)

  [junit] at


org.apache.tomcat.util.threads.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:636)

  [junit] at


org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)

  [junit] at java.base/java.lang.Thread.run(Thread.java:833)
  [junit] Caused by: java.lang.ClassNotFoundException:
org.apache.tomcat.util.http.ValuesEnumerator
  [junit] at


java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:641)

  [junit] at


java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:188)

  [junit] at
java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:520)
  [junit] ... 11 more


On Wed, May 3, 2023 at 9:46 PM Mark Thomas  wrote:


The proposed Apache Tomcat 11.0.0-M6 release is now available for
voting.

Apache Tomcat 11.0.0-M6 is a milestone release of the 11.0.x branch and
has been made to provide users with early access to the new features in
Apache Tomcat 11.0.x so that they may provide feedback. The notable
changes compared to the previous milestone include:

- Various improvements to access logging.

- Remove support for the HTTP Connector settings rejectIllegalHeader and
 allowHostHeaderMismatch. These are now hard-coded to the previous
 defaults.

- Update the packaged version of the Tomcat Migration Tool for Jakarta
 EE to 1.0.7.


For full details, see the change log:
https://nightlies.apache.org/tomcat/tomcat-11.0.x/docs/changelog.html

Applications that run on Tomcat 9 and earlier will not run on Tomcat 11
without changes. Java EE applications designed for Tomcat 9 and earlier
may be placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat
will automatically convert them to Jakarta EE and copy them to the
webapps directory. Applications using deprecated APIs may require
further changes.

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-11/v11.0.0-M6/

The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1432

The tag is:
https://github.com/apache/tomcat/tree/11.0.0-M6
9ce010463a93138d596c54c67b11cdb35fc8244a


The proposed 11.0.0-M6 release is:
[ ] Broken - do not release
[X] Alpha  - go ahead and release as 11.0.0-M6

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org






-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org






-

Re: [VOTE] Release Apache Tomcat 11.0.0-M6

2023-05-04 Thread Rémy Maucherat

On Wed, May 3, 2023 at 8:38 PM Mark Thomas  wrote:
>
> The proposed Apache Tomcat 11.0.0-M6 release is now available for
> voting.
>
> Apache Tomcat 11.0.0-M6 is a milestone release of the 11.0.x branch and
> has been made to provide users with early access to the new features in
> Apache Tomcat 11.0.x so that they may provide feedback. The notable
> changes compared to the previous milestone include:
>
> - Various improvements to access logging.
>
> - Remove support for the HTTP Connector settings rejectIllegalHeader and
>allowHostHeaderMismatch. These are now hard-coded to the previous
>defaults.
>
> - Update the packaged version of the Tomcat Migration Tool for Jakarta
>EE to 1.0.7.
>
>
> For full details, see the change log:
> https://nightlies.apache.org/tomcat/tomcat-11.0.x/docs/changelog.html
>
> Applications that run on Tomcat 9 and earlier will not run on Tomcat 11
> without changes. Java EE applications designed for Tomcat 9 and earlier
> may be placed in the $CATALINA_BASE/webapps-javaee directory and Tomcat
> will automatically convert them to Jakarta EE and copy them to the
> webapps directory. Applications using deprecated APIs may require
> further changes.
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-11/v11.0.0-M6/
>
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1432
>
> The tag is:
> https://github.com/apache/tomcat/tree/11.0.0-M6
> 9ce010463a93138d596c54c67b11cdb35fc8244a
>
>
> The proposed 11.0.0-M6 release is:
> [ ] Broken - do not release
> [X] Alpha  - go ahead and release as 11.0.0-M6

Rémy

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org

[tomcat] branch main updated: Add JRE fix detail to workaround so it can be removed later.

Re: Workaround for misbehaving ClassLoader

[junit] WARNING: Using incubator modules: jdk.incubator.foreign

Re: [junit] WARNING: Using incubator modules: jdk.incubator.foreign

[Bug 66592] New: Support for HTTPS proxy in websocket client

[Bug 66592] Support for HTTPS proxy in websocket client

Java 21 and virtual threads

[tomcat] 01/02: Improve locking of utility executor

[tomcat] 02/02: Move management of utility executor from init/destroy to start/stop

[tomcat] branch main updated (43643fe02c -> 4b097bf2e9)

[tomcat] branch main updated (4b097bf2e9 -> c0f2c6a522)

[tomcat] branch main updated (c0f2c6a522 -> 5299e434ae)

Re: [tomcat] 02/02: Move management of utility executor from init/destroy to start/stop

[tomcat] tag 9.0.75 created (now 2f528c02a9)

[tomcat] 01/01: Tag 9.0.75

svn commit: r61629 - in /dev/tomcat/tomcat-9/v9.0.75: ./ bin/ bin/embed/ src/

[tomcat] branch 9.0.x updated: Next is 9.0.76

Re: [tomcat] 02/02: Move management of utility executor from init/destroy to start/stop

Re: Java 21 and virtual threads

[VOTE] Release Apache Tomcat 9.0.75

Re: [VOTE] Release Apache Tomcat 11.0.0-M6

Re: [VOTE] Release Apache Tomcat 11.0.0-M6

Re: [VOTE] Release Apache Tomcat 11.0.0-M6

[Bug 66593] New: Connector attribute allowHostHeaderMismatch=false fails to reject host header injection attacks

Re: Java 21 and virtual threads

[Bug 66593] Connector attribute allowHostHeaderMismatch=false fails to reject host header injection attacks

[Bug 66593] Connector attribute allowHostHeaderMismatch=false fails to reject host header injection attacks

Re: [tomcat] 02/02: Move management of utility executor from init/destroy to start/stop

Re: [VOTE] Release Apache Tomcat 9.0.75

Re: Java 21 and virtual threads

Re: [VOTE] Release Apache Tomcat 11.0.0-M6

Re: [VOTE] Release Apache Tomcat 11.0.0-M6

32 matches

Site Navigation

Mail list logo

Footer information