[Bug 59897] Buffer Overflow in FD_SET in nb_connect (jk_connect.c) leading to apache2 crash

2016-11-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=59897

Koen Wilde  changed:

   What|Removed |Added

 CC||kwi...@bol.com

--- Comment #2 from Koen Wilde  ---
Created attachment 34417
  --> https://bz.apache.org/bugzilla/attachment.cgi?id=34417&action=edit
[PATCH] Use poll(2) in posix nb_connect

This issue is caused by limitations of the select(2) system call. From the
(linux) manpage:

> POSIX allows an implementation to define an upper limit, advertised via the
> constant FD_SETSIZE, on the range of file descriptors that can be specified
> in a file descriptor set.  The Linux kernel imposes no fixed limit, but the
> glibc implementation makes fd_set a fixed-size type, with FD_SETSIZE defined
> as 1024, and the FD_*() macros operating according to that limit.  To
> monitor file descriptors greater than 1023, use poll(2) instead.

As Michiel already noted, poll(2) is already imported in jk_connect.c, so using
poll(2) doesn't add any new dependencies.

I've attached a patch that uses poll(2) if it is available at compile time;
otherwise it falls back to the current select(2) implementation.

On the long run, it would probably be preferable to use some kind of event
library like libuv or libevent that abstracts over the kernel interface, and
automatically uses the optimal one available (e.g. epoll on linux and kqueue on
FreeBSD). This would both improve portability and performance, and possibly
code simplicity.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.5.7

2016-11-03 Thread Felix Schumacher
Hi all,

change r1767357 broke ajp connector with an executor.

Tomcat fails to set the thread priority, since the ajp connector reports a 
default priority of -1 and Thread#setPriority will throw an IAE in line 583 of 
AbstractProtocol#start.

To reproduce this enable the commented executor in server.xml and add that 
executor to the ajp connector.

A second rather minor point is a white space policy violation in 
webapps/docs/config/http2.xml:160.

Regards,
 Felix

Am 2. November 2016 15:15:03 MEZ, schrieb Mark Thomas :
>The proposed Apache Tomcat 8.5.7 release is now available for voting.
>
>The major changes compared to the 8.5.6 release are:
>
>
>- Implement header limits for HTTP/2
>
>- Improve handling of I/O errors with async processing
>
>- Fail earlier on invalid HTTP requests
>
>It can be obtained from:
>https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.7/
>The Maven staging repo is:
>https://repository.apache.org/content/repositories/orgapachetomcat-1102/
>The svn tag is:
>http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_7/
>
>The proposed 8.5.7 release is:
>[ ] Broken - do not release
>[ ] Alpha  - go ahead and release as 8.5.7
>[ ] Beta   - go ahead and release as 8.5.7
>[ ] Stable - go ahead and release as 8.5.7
>
>-
>To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>For additional commands, e-mail: dev-h...@tomcat.apache.org


Re: [VOTE] Release Apache Tomcat 8.5.7

2016-11-03 Thread Mark Thomas
On 03/11/2016 14:43, Felix Schumacher wrote:
> Hi all,
> 
> change r1767357 broke ajp connector with an executor.
> 
> Tomcat fails to set the thread priority, since the ajp connector reports a 
> default priority of -1 and Thread#setPriority will throw an IAE in line 583 
> of AbstractProtocol#start.
> 
> To reproduce this enable the commented executor in server.xml and add that 
> executor to the ajp connector.
> 
> A second rather minor point is a white space policy violation in 
> webapps/docs/config/http2.xml:160.

That almost certainly means 9.0.x is broken as well.

I can re-roll once this is fixed.

I'll be able to get to this in a few hours. If someone beats me to the
fix, that would be great :)

Mark

> 
> Regards,
>  Felix
> 
> Am 2. November 2016 15:15:03 MEZ, schrieb Mark Thomas :
>> The proposed Apache Tomcat 8.5.7 release is now available for voting.
>>
>> The major changes compared to the 8.5.6 release are:
>>
>>
>> - Implement header limits for HTTP/2
>>
>> - Improve handling of I/O errors with async processing
>>
>> - Fail earlier on invalid HTTP requests
>>
>> It can be obtained from:
>> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.7/
>> The Maven staging repo is:
>> https://repository.apache.org/content/repositories/orgapachetomcat-1102/
>> The svn tag is:
>> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_7/
>>
>> The proposed 8.5.7 release is:
>> [ ] Broken - do not release
>> [ ] Alpha  - go ahead and release as 8.5.7
>> [ ] Beta   - go ahead and release as 8.5.7
>> [ ] Stable - go ahead and release as 8.5.7
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.5.7

2016-11-03 Thread Coty Sutherland
Just a quick question for clarity regarding APR tests...we're testing
against the openssl-1.0.2-stable branch, correct? That passes fine,
but testing against trunk fails a couple of tests:

org.apache.tomcat.util.net.openssl.ciphers.TestCipher.testAllOpenSSLCiphersMapped

junit.framework.AssertionFailedError: No mapping found in IBM's JSSE
implementation for TLS13-AES-128-GCM-SHA256+TLSv1.3 when one was
expected
No mapping found in Oracle's JSSE implementation for
TLS13-AES-128-GCM-SHA256+TLSv1.3 when one was expected

org.apache.tomcat.util.net.openssl.ciphers.TestCipher.testOpenSSLCipherAvailability

junit.framework.AssertionFailedError: TLS13-AES-128-GCM-SHA256+TLSv1.3
 expected:<0> but was:<1>
at 
org.apache.tomcat.util.net.openssl.ciphers.TestCipher.testOpenSSLCipherAvailability(TestCipher.java:107)

On Thu, Nov 3, 2016 at 10:49 AM, Mark Thomas  wrote:
> On 03/11/2016 14:43, Felix Schumacher wrote:
>> Hi all,
>>
>> change r1767357 broke ajp connector with an executor.
>>
>> Tomcat fails to set the thread priority, since the ajp connector reports a 
>> default priority of -1 and Thread#setPriority will throw an IAE in line 583 
>> of AbstractProtocol#start.
>>
>> To reproduce this enable the commented executor in server.xml and add that 
>> executor to the ajp connector.
>>
>> A second rather minor point is a white space policy violation in 
>> webapps/docs/config/http2.xml:160.
>
> That almost certainly means 9.0.x is broken as well.
>
> I can re-roll once this is fixed.
>
> I'll be able to get to this in a few hours. If someone beats me to the
> fix, that would be great :)
>
> Mark
>
>>
>> Regards,
>>  Felix
>>
>> Am 2. November 2016 15:15:03 MEZ, schrieb Mark Thomas :
>>> The proposed Apache Tomcat 8.5.7 release is now available for voting.
>>>
>>> The major changes compared to the 8.5.6 release are:
>>>
>>>
>>> - Implement header limits for HTTP/2
>>>
>>> - Improve handling of I/O errors with async processing
>>>
>>> - Fail earlier on invalid HTTP requests
>>>
>>> It can be obtained from:
>>> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.7/
>>> The Maven staging repo is:
>>> https://repository.apache.org/content/repositories/orgapachetomcat-1102/
>>> The svn tag is:
>>> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_7/
>>>
>>> The proposed 8.5.7 release is:
>>> [ ] Broken - do not release
>>> [ ] Alpha  - go ahead and release as 8.5.7
>>> [ ] Beta   - go ahead and release as 8.5.7
>>> [ ] Stable - go ahead and release as 8.5.7
>>>
>>> -
>>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>>> For additional commands, e-mail: dev-h...@tomcat.apache.org
>>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.5.7

2016-11-03 Thread Rémy Maucherat
2016-11-03 15:49 GMT+01:00 Mark Thomas :

> On 03/11/2016 14:43, Felix Schumacher wrote:
> > Hi all,
> >
> > change r1767357 broke ajp connector with an executor.
> >
> > Tomcat fails to set the thread priority, since the ajp connector reports
> a default priority of -1 and Thread#setPriority will throw an IAE in line
> 583 of AbstractProtocol#start.
> >
> > To reproduce this enable the commented executor in server.xml and add
> that executor to the ajp connector.
> >
> > A second rather minor point is a white space policy violation in
> webapps/docs/config/http2.xml:160.
>
> That almost certainly means 9.0.x is broken as well.
>
> I can re-roll once this is fixed.
>
> I'll be able to get to this in a few hours. If someone beats me to the
> fix, that would be great :)
>
> Bad luck ... AbstractProtocol.start should use Thread.NORM_PRIORITY if
getThreadPriority() is -1. I won't commit it since you'll have a lot of
tagging to do, so it won't make any difference :(

Rémy


svn commit: r1767903 - /tomcat/trunk/java/org/apache/catalina/connector/OutputBuffer.java

2016-11-03 Thread violetagg
Author: violetagg
Date: Thu Nov  3 15:11:18 2016
New Revision: 1767903

URL: http://svn.apache.org/viewvc?rev=1767903&view=rev
Log:
Set the buffer size if it is above the one specified when OutputBuffer object 
was created.
This change resets the behavior to the one before r1758421.

Modified:
tomcat/trunk/java/org/apache/catalina/connector/OutputBuffer.java

Modified: tomcat/trunk/java/org/apache/catalina/connector/OutputBuffer.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/OutputBuffer.java?rev=1767903&r1=1767902&r2=1767903&view=diff
==
--- tomcat/trunk/java/org/apache/catalina/connector/OutputBuffer.java (original)
+++ tomcat/trunk/java/org/apache/catalina/connector/OutputBuffer.java Thu Nov  
3 15:11:18 2016
@@ -639,7 +639,7 @@ public class OutputBuffer extends Writer
 
 
 public void setBufferSize(int size) {
-if (size != bb.capacity()) {
+if (size > bb.capacity()) {
 bb = ByteBuffer.allocate(size);
 clear(bb);
 }



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1767904 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/catalina/connector/OutputBuffer.java

2016-11-03 Thread violetagg
Author: violetagg
Date: Thu Nov  3 15:19:48 2016
New Revision: 1767904

URL: http://svn.apache.org/viewvc?rev=1767904&view=rev
Log:
Set the buffer size if it is above the one specified when OutputBuffer object 
was created.
This change resets the behavior to the one before r1758421.

Modified:
tomcat/tc8.5.x/trunk/   (props changed)
tomcat/tc8.5.x/trunk/java/org/apache/catalina/connector/OutputBuffer.java

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Thu Nov  3 15:19:48 2016
@@ -1 +1 @@
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501
 
,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747404,1747506,1747536,1747
 
924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1756289,1756408-1756410,1
 
756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757790,1757799,1757813,1757853,1757883,1757903,1757976,1757997,1758000,1758058,1758072-1758075,1758078-1758079,1758223,1758257,1758261,1758276,1758292,1758369,1758378-1758383,1758421,1758423,1758425-1758427,1758430,1758443,1758448,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758580,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1759757,1759785-1759790,1760005,1760022,1760109-1760110,1760135,1760200-1760201,1760227,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,1761740,1761752,1762051-1762053,1762123,1762168,176217
 
2,1762182,1762201-1762202,1762204,1762208,1762288,1762296,1762324,1762348,1762353,1762362,1762374,1762492,1762503,1762505,1762541,1762608,1762710,1762753,1762766,1762769,1762944,1762947,1762953,1763167,1763179,1763232,1763259,1763271-1763272,1763276-1763277,1763319-1763320,1763370,1763372,1763375,1763377,1763393,1763412,1763430,1763450,1763462,1763505,1763511-1763512,1763516,17635

Re: [VOTE] Release Apache Tomcat 8.5.7

2016-11-03 Thread Christopher Schultz
Mark,

On 11/2/16 10:15 AM, Mark Thomas wrote:
> The proposed Apache Tomcat 8.5.7 release is now available for voting.
> 
> The major changes compared to the 8.5.6 release are:
> 
> 
> - Implement header limits for HTTP/2
> 
> - Improve handling of I/O errors with async processing
> 
> - Fail earlier on invalid HTTP requests
> 
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.7/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1102/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_7/
> 
> The proposed 8.5.7 release is:
> [ ] Broken - do not release
> [ ] Alpha  - go ahead and release as 8.5.7
> [ ] Beta   - go ahead and release as 8.5.7

Do we still need Alpha and Beta choices for 8.5.x? At this point, it
should either be Broken or Stable, no?

> [X] Stable - go ahead and release as 8.5.7

Works fine for a non-fancy web application (no websocket, h2, etc.). See
below for some potentially bad test failures... I'm not sure I know what
reasonable things could have caused them.

Details:

* Environment
*  Java (build): java version "1.8.0_101" Java(TM) SE Runtime
Environment (build 1.8.0_101-b13) Java HotSpot(TM) 64-Bit Server VM
(build 25.101-b13, mixed mode)
*  Java (test): java version "1.8.0_101" Java(TM) SE Runtime
Environment (build 1.8.0_101-b13) Java HotSpot(TM) 64-Bit Server VM
(build 25.101-b13, mixed mode)
*  OS:   Linux 2.6.32-312-ec2 x86_64
*  cc:   cc (Debian 4.7.2-5) 4.7.2
*  make: GNU Make 3.81
*  OpenSSL:  OpenSSL 1.0.2f 28 Jan 2016 (Library: OpenSSL 1.0.1t 3 May 2016)
*  APR:  1.4.6
*
* Valid MD5 signature for apache-tomcat-8.5.7.zip
* Valid GPG signature for apache-tomcat-8.5.7.zip
* Valid MD5 signature for apache-tomcat-8.5.7.tar.gz
* Valid GPG signature for apache-tomcat-8.5.7.tar.gz
* Valid MD5 signature for apache-tomcat-8.5.7.exe
* Valid GPG signature for apache-tomcat-8.5.7.exe
* Valid MD5 signature for apache-tomcat-8.5.7-src.zip
* Valid GPG signature for apache-tomcat-8.5.7-src.zip
* Valid MD5 signature for apache-tomcat-8.5.7-src.tar.gz
* Valid GPG signature for apache-tomcat-8.5.7-src.tar.gz
*
* Binary Zip and tarball: Same
* Source Zip and tarball: Same
*
* Building dependencies returned: 0
* tcnative builds cleanly
* Tomcat builds cleanly
* Junit Tests: FAILED
*
* Tests that failed:
* org.apache.catalina.session.TestStandardSessionIntegration.APR.txt
* org.apache.catalina.session.TestStandardSessionIntegration.NIO.txt
* org.apache.catalina.session.TestStandardSessionIntegration.NIO2.txt
* org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.APR.txt
* org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.NIO.txt
* org.apache.catalina.tribes.group.TestGroupChannelMemberArrival.NIO2.txt
* org.apache.catalina.tribes.group.TestGroupChannelSenderConnections.APR.txt
* org.apache.catalina.tribes.group.TestGroupChannelSenderConnections.NIO.txt
*
org.apache.catalina.tribes.group.TestGroupChannelSenderConnections.NIO2.txt
* org.apache.catalina.tribes.group.TestGroupChannelStartStop.APR.txt
* org.apache.catalina.tribes.group.TestGroupChannelStartStop.NIO.txt
* org.apache.catalina.tribes.group.TestGroupChannelStartStop.NIO2.txt


The above tests are expected to fail in my environment.

I'm not so sure about those below:

*
org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator.APR.txt
*
org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator.NIO.txt
*
org.apache.catalina.tribes.group.interceptors.TestNonBlockingCoordinator.NIO2.txt
* org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.APR.txt
* org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.NIO.txt
*
org.apache.catalina.tribes.group.interceptors.TestOrderInterceptor.NIO2.txt
*
org.apache.catalina.tribes.group.interceptors.TestTcpFailureDetector.APR.txt
*
org.apache.catalina.tribes.group.interceptors.TestTcpFailureDetector.NIO.txt
*
org.apache.catalina.tribes.group.interceptors.TestTcpFailureDetector.NIO2.txt


These failures are likely due to imperfect OpenSSL version matching
(note the mismatched build vs "library" versions of OpenSSL).

* org.apache.tomcat.util.net.openssl.ciphers.TestCipher.APR.txt
* org.apache.tomcat.util.net.openssl.ciphers.TestCipher.NIO.txt
* org.apache.tomcat.util.net.openssl.ciphers.TestCipher.NIO2.txt
*
org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfigurationParser.APR.txt
*
org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfigurationParser.NIO.txt
*
org.apache.tomcat.util.net.openssl.ciphers.TestOpenSSLCipherConfigurationParser.NIO2.txt



signature.asc
Description: OpenPGP digital signature


Re: svn commit: r1767903 - /tomcat/trunk/java/org/apache/catalina/connector/OutputBuffer.java

2016-11-03 Thread Christopher Schultz
Violetta,

On 11/3/16 11:11 AM, violet...@apache.org wrote:
> Author: violetagg
> Date: Thu Nov  3 15:11:18 2016
> New Revision: 1767903
> 
> URL: http://svn.apache.org/viewvc?rev=1767903&view=rev
> Log:
> Set the buffer size if it is above the one specified when OutputBuffer object 
> was created.
> This change resets the behavior to the one before r1758421.
> 
> Modified:
> tomcat/trunk/java/org/apache/catalina/connector/OutputBuffer.java
> 
> Modified: tomcat/trunk/java/org/apache/catalina/connector/OutputBuffer.java
> URL: 
> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/OutputBuffer.java?rev=1767903&r1=1767902&r2=1767903&view=diff
> ==
> --- tomcat/trunk/java/org/apache/catalina/connector/OutputBuffer.java 
> (original)
> +++ tomcat/trunk/java/org/apache/catalina/connector/OutputBuffer.java Thu Nov 
>  3 15:11:18 2016
> @@ -639,7 +639,7 @@ public class OutputBuffer extends Writer
>  
>  
>  public void setBufferSize(int size) {
> -if (size != bb.capacity()) {
> +if (size > bb.capacity()) {
>  bb = ByteBuffer.allocate(size);
>  clear(bb);
>  }

Might this cause a problem with output buffers growing without bound?

-chris



signature.asc
Description: OpenPGP digital signature


Re: svn commit: r1767903 - /tomcat/trunk/java/org/apache/catalina/connector/OutputBuffer.java

2016-11-03 Thread Violeta Georgieva
2016-11-03 18:37 GMT+02:00 Christopher Schultz :
>
> Violetta,
>
> On 11/3/16 11:11 AM, violet...@apache.org wrote:
> > Author: violetagg
> > Date: Thu Nov  3 15:11:18 2016
> > New Revision: 1767903
> >
> > URL: http://svn.apache.org/viewvc?rev=1767903&view=rev
> > Log:
> > Set the buffer size if it is above the one specified when OutputBuffer
object was created.
> > This change resets the behavior to the one before r1758421.
> >
> > Modified:
> > tomcat/trunk/java/org/apache/catalina/connector/OutputBuffer.java
> >
> > Modified:
tomcat/trunk/java/org/apache/catalina/connector/OutputBuffer.java
> > URL:
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/OutputBuffer.java?rev=1767903&r1=1767902&r2=1767903&view=diff
> >
==
> > --- tomcat/trunk/java/org/apache/catalina/connector/OutputBuffer.java
(original)
> > +++ tomcat/trunk/java/org/apache/catalina/connector/OutputBuffer.java
Thu Nov  3 15:11:18 2016
> > @@ -639,7 +639,7 @@ public class OutputBuffer extends Writer
> >
> >
> >  public void setBufferSize(int size) {
> > -if (size != bb.capacity()) {
> > +if (size > bb.capacity()) {
> >  bb = ByteBuffer.allocate(size);
> >  clear(bb);
> >  }
>
> Might this cause a problem with output buffers growing without bound?

This is an API that the application can call.
Servlet javadoc specifies:

"Sets the preferred buffer size for the body of the response. The servlet
container will use a buffer at least as large as the size requested. The
actual buffer size used can be found using getBufferSize."
https://docs.oracle.com/javaee/7/api/javax/servlet/ServletResponse.html#setBufferSize-int-

Regards,
Violeta

>
> -chris
>


svn commit: r1767935 - in /tomcat/tc8.5.x/trunk: ./ webapps/docs/config/http2.xml

2016-11-03 Thread fschumacher
Author: fschumacher
Date: Thu Nov  3 17:26:53 2016
New Revision: 1767935

URL: http://svn.apache.org/viewvc?rev=1767935&view=rev
Log:
ws police

Modified:
tomcat/tc8.5.x/trunk/   (props changed)
tomcat/tc8.5.x/trunk/webapps/docs/config/http2.xml

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Thu Nov  3 17:26:53 2016
@@ -1 +1 @@
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501
 
,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747404,1747506,1747536,1747
 
924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1756289,1756408-1756410,1
 
756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757790,1757799,1757813,1757853,1757883,1757903,1757976,1757997,1758000,1758058,1758072-1758075,1758078-1758079,1758223,1758257,1758261,1758276,1758292,1758369,1758378-1758383,1758421,1758423,1758425-1758427,1758430,1758443,1758448,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758580,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1759757,1759785-1759790,1760005,1760022,1760109-1760110,1760135,1760200-1760201,1760227,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,1761740,1761752,1762051-1762053,1762123,1762168,176217
 
2,1762182,1762201-1762202,1762204,1762208,1762288,1762296,1762324,1762348,1762353,1762362,1762374,1762492,1762503,1762505,1762541,1762608,1762710,1762753,1762766,1762769,1762944,1762947,1762953,1763167,1763179,1763232,1763259,1763271-1763272,1763276-1763277,1763319-1763320,1763370,1763372,1763375,1763377,1763393,1763412,1763430,1763450,1763462,1763505,1763511-1763512,1763516,1763518,1763520,1763529,1763559,1763565,1763568,1763574,1763619,1763634-1763635,1763718,1763786,1763798-1763799,1763813,1763815,1763819,1763831,1764083,1764425,1764646,

Re: svn commit: r1767903 - /tomcat/trunk/java/org/apache/catalina/connector/OutputBuffer.java

2016-11-03 Thread Christopher Schultz
Violeta,

On 11/3/16 12:43 PM, Violeta Georgieva wrote:
> 2016-11-03 18:37 GMT+02:00 Christopher Schultz > :
>>
>> Violetta,
>>
>> On 11/3/16 11:11 AM, violet...@apache.org wrote:
>>> Author: violetagg
>>> Date: Thu Nov  3 15:11:18 2016
>>> New Revision: 1767903
>>>
>>> URL: http://svn.apache.org/viewvc?rev=1767903&view=rev
>>> Log:
>>> Set the buffer size if it is above the one specified when OutputBuffer
> object was created.
>>> This change resets the behavior to the one before r1758421.
>>>
>>> Modified:
>>> tomcat/trunk/java/org/apache/catalina/connector/OutputBuffer.java
>>>
>>> Modified:
> tomcat/trunk/java/org/apache/catalina/connector/OutputBuffer.java
>>> URL:
> http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/catalina/connector/OutputBuffer.java?rev=1767903&r1=1767902&r2=1767903&view=diff
>>>
> ==
>>> --- tomcat/trunk/java/org/apache/catalina/connector/OutputBuffer.java
> (original)
>>> +++ tomcat/trunk/java/org/apache/catalina/connector/OutputBuffer.java
> Thu Nov  3 15:11:18 2016
>>> @@ -639,7 +639,7 @@ public class OutputBuffer extends Writer
>>>
>>>
>>>  public void setBufferSize(int size) {
>>> -if (size != bb.capacity()) {
>>> +if (size > bb.capacity()) {
>>>  bb = ByteBuffer.allocate(size);
>>>  clear(bb);
>>>  }
>>
>> Might this cause a problem with output buffers growing without bound?
> 
> This is an API that the application can call.
> Servlet javadoc specifies:
> 
> "Sets the preferred buffer size for the body of the response. The servlet
> container will use a buffer at least as large as the size requested. The
> actual buffer size used can be found using getBufferSize."
> https://docs.oracle.com/javaee/7/api/javax/servlet/ServletResponse.html#setBufferSize-int-

Okay. It might be nice to have a way for client code to shrink the
buffer size at some point, maybe by checking the current buffer size
relative to the requested buffer size, and shrink the buffer if there is
some factor of difference.

I can imagine a use case of setting the buffer size to be large for a
huge response and then attempting to reduce the buffer size again to
"save memory".

-chris



signature.asc
Description: OpenPGP digital signature


Re: [VOTE] Release Apache Tomcat 8.5.7

2016-11-03 Thread Christopher Schultz
Felix,

On 11/3/16 10:43 AM, Felix Schumacher wrote:
> Hi all,
> 
> change r1767357 broke ajp connector with an executor.
> 
> Tomcat fails to set the thread priority, since the ajp connector
> reports a default priority of -1 and Thread#setPriority will throw an
> IAE in line 583 of AbstractProtocol#start.
> 
> To reproduce this enable the commented executor in server.xml and add
> that executor to the ajp connector.

I'm using this configuration with 8.5 with no ill effects:







Which exact connector are you using? How do I need to change my
configuration to confirm the problem?

> A second rather minor point is a white space policy violation in
> webapps/docs/config/http2.xml:160.

Oh noes! :)

-chris

> Am 2. November 2016 15:15:03 MEZ, schrieb Mark Thomas :
>> The proposed Apache Tomcat 8.5.7 release is now available for voting.
>>
>> The major changes compared to the 8.5.6 release are:
>>
>>
>> - Implement header limits for HTTP/2
>>
>> - Improve handling of I/O errors with async processing
>>
>> - Fail earlier on invalid HTTP requests
>>
>> It can be obtained from:
>> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.7/
>> The Maven staging repo is:
>> https://repository.apache.org/content/repositories/orgapachetomcat-1102/
>> The svn tag is:
>> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_7/
>>
>> The proposed 8.5.7 release is:
>> [ ] Broken - do not release
>> [ ] Alpha  - go ahead and release as 8.5.7
>> [ ] Beta   - go ahead and release as 8.5.7
>> [ ] Stable - go ahead and release as 8.5.7
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 



signature.asc
Description: OpenPGP digital signature


Re: [VOTE] Release Apache Tomcat 8.5.7

2016-11-03 Thread Felix Schumacher

Am 03.11.2016 um 18:32 schrieb Christopher Schultz:

Felix,

On 11/3/16 10:43 AM, Felix Schumacher wrote:

Hi all,

change r1767357 broke ajp connector with an executor.

Tomcat fails to set the thread priority, since the ajp connector
reports a default priority of -1 and Thread#setPriority will throw an
IAE in line 583 of AbstractProtocol#start.

To reproduce this enable the commented executor in server.xml and add
that executor to the ajp connector.

I'm using this configuration with 8.5 with no ill effects:

 

 

 

Which exact connector are you using? How do I need to change my
configuration to confirm the problem?
I used the conf/server.xml from output/build. In fact I changed into 
output/build and edited conf/server.xml with


--- conf/server.xml.orig2016-11-03 18:43:48.737312712 +0100
+++ conf/server.xml2016-11-03 18:44:29.069284390 +0100
@@ -53,10 +53,8 @@
   

 

-


 

 
-
+executor="tomcatThreadPool" />



 

svn commit: r1767945 - /tomcat/trunk/java/org/apache/coyote/http11/filters/ChunkedOutputFilter.java

2016-11-03 Thread violetagg
Author: violetagg
Date: Thu Nov  3 18:20:42 2016
New Revision: 1767945

URL: http://svn.apache.org/viewvc?rev=1767945&view=rev
Log:
Ensure that in all cases the correct position and limit are set to the endChunk 
buffer.

Modified:
tomcat/trunk/java/org/apache/coyote/http11/filters/ChunkedOutputFilter.java

Modified: 
tomcat/trunk/java/org/apache/coyote/http11/filters/ChunkedOutputFilter.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/http11/filters/ChunkedOutputFilter.java?rev=1767945&r1=1767944&r2=1767945&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/http11/filters/ChunkedOutputFilter.java 
(original)
+++ tomcat/trunk/java/org/apache/coyote/http11/filters/ChunkedOutputFilter.java 
Thu Nov  3 18:20:42 2016
@@ -152,7 +152,7 @@ public class ChunkedOutputFilter impleme
 
 // Write end chunk
 buffer.doWrite(endChunk);
-endChunk.flip();
+endChunk.position(0).limit(endChunk.capacity());
 
 return 0;
 



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1767946 - in /tomcat/trunk: java/org/apache/coyote/AbstractProtocol.java webapps/docs/changelog.xml

2016-11-03 Thread fschumacher
Author: fschumacher
Date: Thu Nov  3 18:22:56 2016
New Revision: 1767946

URL: http://svn.apache.org/viewvc?rev=1767946&view=rev
Log:
Check that threadPriority values used in AbstractProtocol are valid.
Followup to r1767328

Modified:
tomcat/trunk/java/org/apache/coyote/AbstractProtocol.java
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/java/org/apache/coyote/AbstractProtocol.java
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/coyote/AbstractProtocol.java?rev=1767946&r1=1767945&r2=1767946&view=diff
==
--- tomcat/trunk/java/org/apache/coyote/AbstractProtocol.java (original)
+++ tomcat/trunk/java/org/apache/coyote/AbstractProtocol.java Thu Nov  3 
18:22:56 2016
@@ -554,7 +554,11 @@ public abstract class AbstractProtocol Thread.MAX_PRIORITY) {
+priority = Thread.NORM_PRIORITY;
+}
+timeoutThread.setPriority(priority);
 timeoutThread.setDaemon(true);
 timeoutThread.start();
 }

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1767946&r1=1767945&r2=1767946&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Thu Nov  3 18:22:56 2016
@@ -45,6 +45,14 @@
   issues do not "pop up" wrt. others).
 -->
 
+  
+
+  
+Check that threadPriority values used in AbstractProtocol are valid.
+(fschumacher)
+  
+
+  
 
 
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.5.7

2016-11-03 Thread Felix Schumacher

Am 03.11.2016 um 15:49 schrieb Mark Thomas:

On 03/11/2016 14:43, Felix Schumacher wrote:

Hi all,

change r1767357 broke ajp connector with an executor.

Tomcat fails to set the thread priority, since the ajp connector reports a 
default priority of -1 and Thread#setPriority will throw an IAE in line 583 of 
AbstractProtocol#start.

To reproduce this enable the commented executor in server.xml and add that 
executor to the ajp connector.

A second rather minor point is a white space policy violation in 
webapps/docs/config/http2.xml:160.

That almost certainly means 9.0.x is broken as well.

I can re-roll once this is fixed.

I'll be able to get to this in a few hours. If someone beats me to the
fix, that would be great :)
I have committed a fix for 9.0.0.M12 (which is affected as well - as you 
suspected).


Felix


Mark


Regards,
  Felix

Am 2. November 2016 15:15:03 MEZ, schrieb Mark Thomas :

The proposed Apache Tomcat 8.5.7 release is now available for voting.

The major changes compared to the 8.5.6 release are:


- Implement header limits for HTTP/2

- Improve handling of I/O errors with async processing

- Fail earlier on invalid HTTP requests

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.7/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1102/
The svn tag is:
http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_7/

The proposed 8.5.7 release is:
[ ] Broken - do not release
[ ] Alpha  - go ahead and release as 8.5.7
[ ] Beta   - go ahead and release as 8.5.7
[ ] Stable - go ahead and release as 8.5.7

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org




-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1767947 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/coyote/http11/filters/ChunkedOutputFilter.java

2016-11-03 Thread violetagg
Author: violetagg
Date: Thu Nov  3 18:34:30 2016
New Revision: 1767947

URL: http://svn.apache.org/viewvc?rev=1767947&view=rev
Log:
Merged revision 1767945 from tomcat/trunk:
Ensure that in all cases the correct position and limit are set to the endChunk 
buffer.

Modified:
tomcat/tc8.5.x/trunk/   (props changed)

tomcat/tc8.5.x/trunk/java/org/apache/coyote/http11/filters/ChunkedOutputFilter.java

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Thu Nov  3 18:34:30 2016
@@ -1 +1 @@
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501
 
,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747404,1747506,1747536,1747
 
924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1756289,1756408-1756410,1
 
756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757790,1757799,1757813,1757853,1757883,1757903,1757976,1757997,1758000,1758058,1758072-1758075,1758078-1758079,1758223,1758257,1758261,1758276,1758292,1758369,1758378-1758383,1758421,1758423,1758425-1758427,1758430,1758443,1758448,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758580,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1759757,1759785-1759790,1760005,1760022,1760109-1760110,1760135,1760200-1760201,1760227,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,1761740,1761752,1762051-1762053,1762123,1762168,176217
 
2,1762182,1762201-1762202,1762204,1762208,1762288,1762296,1762324,1762348,1762353,1762362,1762374,1762492,1762503,1762505,1762541,1762608,1762710,1762753,1762766,1762769,1762944,1762947,1762953,1763167,1763179,1763232,1763259,1763271-1763272,1763276-1763277,1763319-1763320,1763370,1763372,1763375,1763377,1763393,1763412,1763430,1763450,1763462,1763505,1763511-1763512,1763516,1763518,176352

svn commit: r1767948 - in /tomcat/tc8.5.x/trunk: ./ java/org/apache/coyote/AbstractProtocol.java webapps/docs/changelog.xml

2016-11-03 Thread fschumacher
Author: fschumacher
Date: Thu Nov  3 18:37:37 2016
New Revision: 1767948

URL: http://svn.apache.org/viewvc?rev=1767948&view=rev
Log:
heck that threadPriority values used in AbstractProtocol are valid.
Followup to r1767357

Modified:
tomcat/tc8.5.x/trunk/   (props changed)
tomcat/tc8.5.x/trunk/java/org/apache/coyote/AbstractProtocol.java
tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml

Propchange: tomcat/tc8.5.x/trunk/
--
--- svn:mergeinfo (original)
+++ svn:mergeinfo Thu Nov  3 18:37:37 2016
@@ -1 +1 @@
-/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501
 
,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747404,1747506,1747536,1747
 
924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1756289,1756408-1756410,1
 
756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,1757167-1757168,1757175,1757180,1757182,1757195,1757271,1757278,1757347,1757353-1757354,1757363,1757374,1757399,1757406,1757408,1757485,1757495,1757499,1757527,1757578,1757684,1757722,1757727,1757790,1757799,1757813,1757853,1757883,1757903,1757976,1757997,1758000,1758058,1758072-1758075,1758078-1758079,1758223,1758257,1758261,1758276,1758292,1758369,1758378-1758383,1758421,1758423,1758425-1758427,1758430,1758443,1758448,1758459,1758483,1758486-1758487,1758499,1758525,1758556,1758580,1758582,1758584,1758588,1758842,1759019,1759212,1759224,1759227,1759252,1759274,1759513-1759516,1759611,1759757,1759785-1759790,1760005,1760022,1760109-1760110,1760135,1760200-1760201,1760227,1760300,1760397,1760446,1760454,1760640,1760648,1761057,1761422,1761491,1761498,1761500-1761501,1761550,1761553,1761572,1761574,1761625-1761626,1761628,1761682,1761740,1761752,1762051-1762053,1762123,1762168,176217
 
2,1762182,1762201-1762202,1762204,1762208,1762288,1762296,1762324,1762348,1762353,1762362,1762374,1762492,1762503,1762505,1762541,1762608,1762710,1762753,1762766,1762769,1762944,1762947,1762953,1763167,1763179,1763232,1763259,1763271-1763272,1763276-1763277,1763319-1763320,1763370,1763372,1763375,1763377,1763393,1763412,1763430,1763450,1763462,1763505,1763511-1763512,1763516,1763518,1763520,176352

Re: [VOTE] Release Apache Tomcat 8.5.7

2016-11-03 Thread Violeta Georgieva
Hi Felix,

2016-11-03 20:24 GMT+02:00 Felix Schumacher <
felix.schumac...@internetallee.de>:
>
> Am 03.11.2016 um 15:49 schrieb Mark Thomas:
>>
>> On 03/11/2016 14:43, Felix Schumacher wrote:
>>>
>>> Hi all,
>>>
>>> change r1767357 broke ajp connector with an executor.
>>>
>>> Tomcat fails to set the thread priority, since the ajp connector
reports a default priority of -1 and Thread#setPriority will throw an IAE
in line 583 of AbstractProtocol#start.
>>>
>>> To reproduce this enable the commented executor in server.xml and add
that executor to the ajp connector.
>>>
>>> A second rather minor point is a white space policy violation in
webapps/docs/config/http2.xml:160.
>>
>> That almost certainly means 9.0.x is broken as well.
>>
>> I can re-roll once this is fixed.
>>
>> I'll be able to get to this in a few hours. If someone beats me to the
>> fix, that would be great :)
>
> I have committed a fix for 9.0.0.M12 (which is affected as well - as you
suspected).

Do we need this fix in Tomcat 6/7/8.0?

Thanks,
Violeta

> Felix
>
>>
>> Mark
>>
>>> Regards,
>>>   Felix
>>>
>>> Am 2. November 2016 15:15:03 MEZ, schrieb Mark Thomas :

 The proposed Apache Tomcat 8.5.7 release is now available for voting.

 The major changes compared to the 8.5.6 release are:


 - Implement header limits for HTTP/2

 - Improve handling of I/O errors with async processing

 - Fail earlier on invalid HTTP requests

 It can be obtained from:
 https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.7/
 The Maven staging repo is:

https://repository.apache.org/content/repositories/orgapachetomcat-1102/
 The svn tag is:
 http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_7/

 The proposed 8.5.7 release is:
 [ ] Broken - do not release
 [ ] Alpha  - go ahead and release as 8.5.7
 [ ] Beta   - go ahead and release as 8.5.7
 [ ] Stable - go ahead and release as 8.5.7

 -
 To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
 For additional commands, e-mail: dev-h...@tomcat.apache.org
>>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>> For additional commands, e-mail: dev-h...@tomcat.apache.org
>>
>
>
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>


[Bug 60333] inconsistency in folder name from webapps to work folder

2016-11-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60333

Mark Thomas  changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |INVALID
 OS||All

--- Comment #1 from Mark Thomas  ---
No sample WAR has been provided.

An application should not be making any assumptions about the name, location or
accessibility of the work directory.

I have performed a quick test and web applications that contain a '#' are
handled correctly.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.5.7

2016-11-03 Thread Felix Schumacher


Am 3. November 2016 21:01:51 MEZ, schrieb Violeta Georgieva 
:
>Hi Felix,
>
>2016-11-03 20:24 GMT+02:00 Felix Schumacher <
>felix.schumac...@internetallee.de>:
>>
>> Am 03.11.2016 um 15:49 schrieb Mark Thomas:
>>>
>>> On 03/11/2016 14:43, Felix Schumacher wrote:

 Hi all,

 change r1767357 broke ajp connector with an executor.

 Tomcat fails to set the thread priority, since the ajp connector
>reports a default priority of -1 and Thread#setPriority will throw an
>IAE
>in line 583 of AbstractProtocol#start.

 To reproduce this enable the commented executor in server.xml and
>add
>that executor to the ajp connector.

 A second rather minor point is a white space policy violation in
>webapps/docs/config/http2.xml:160.
>>>
>>> That almost certainly means 9.0.x is broken as well.
>>>
>>> I can re-roll once this is fixed.
>>>
>>> I'll be able to get to this in a few hours. If someone beats me to
>the
>>> fix, that would be great :)
>>
>> I have committed a fix for 9.0.0.M12 (which is affected as well - as
>you
>suspected).
>
>Do we need this fix in Tomcat 6/7/8.0?

I have had a short look at AbstractProtocol in tomcat 8.0 and couldn't find any 
reference to Thread#setPriority. So I think anything below 8.5 is safe.

A test with modified server.xml worked correctly.

Regards,
 Felix

>
>Thanks,
>Violeta
>
>> Felix
>>
>>>
>>> Mark
>>>
 Regards,
   Felix

 Am 2. November 2016 15:15:03 MEZ, schrieb Mark Thomas
>>:
>
> The proposed Apache Tomcat 8.5.7 release is now available for
>voting.
>
> The major changes compared to the 8.5.6 release are:
>
>
> - Implement header limits for HTTP/2
>
> - Improve handling of I/O errors with async processing
>
> - Fail earlier on invalid HTTP requests
>
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.7/
> The Maven staging repo is:
>
>https://repository.apache.org/content/repositories/orgapachetomcat-1102/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_7/
>
> The proposed 8.5.7 release is:
> [ ] Broken - do not release
> [ ] Alpha  - go ahead and release as 8.5.7
> [ ] Beta   - go ahead and release as 8.5.7
> [ ] Stable - go ahead and release as 8.5.7
>
>
>-
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
>>>
>>>
>>>
>-
>>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>>> For additional commands, e-mail: dev-h...@tomcat.apache.org
>>>
>>
>>
>> -
>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
>> For additional commands, e-mail: dev-h...@tomcat.apache.org
>>


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 8.5.7

2016-11-03 Thread Mark Thomas
This vote is cancelled due to a regression in the fix for BZ 60319.

8.5.8 will follow shortly.

Mark


On 02/11/2016 14:15, Mark Thomas wrote:
> The proposed Apache Tomcat 8.5.7 release is now available for voting.
> 
> The major changes compared to the 8.5.6 release are:
> 
> 
> - Implement header limits for HTTP/2
> 
> - Improve handling of I/O errors with async processing
> 
> - Fail earlier on invalid HTTP requests
> 
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.7/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1102/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_7/
> 
> The proposed 8.5.7 release is:
> [ ] Broken - do not release
> [ ] Alpha  - go ahead and release as 8.5.7
> [ ] Beta   - go ahead and release as 8.5.7
> [ ] Stable - go ahead and release as 8.5.7
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



Re: [VOTE] Release Apache Tomcat 9.0.0.M12

2016-11-03 Thread Mark Thomas
This vote is cancelled due to a regression in the fix for BZ 60319.

M13 will follow shortly.

Mark


On 02/11/2016 13:06, Mark Thomas wrote:
> The proposed Apache Tomcat 9.0.0.M12 release is now available for voting.
> 
> This is a milestone release for the 9.0.x branch. It should be
> noted that, as a milestone release:
> - Servlet 4.0 is not finalised
> - The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket 1.2/2.0
> 
> The major changes compared to the 9.0.0.M11 release are:
> 
> - Implement header limits for HTTP/2
> 
> - Improve handling of I/O errors with async processing
> 
> - Fail earlier on invalid HTTP requests
> 
> Along with lots of other bug fixes and improvements
> 
> For full details, see the changelog:
> http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml
> 
> It can be obtained from:
> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M12/
> The Maven staging repo is:
> https://repository.apache.org/content/repositories/orgapachetomcat-1101/
> The svn tag is:
> http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_0_M12/
> 
> The proposed 9.0.0.M12 release is:
> [ ] Broken - do not release
> [ ] Alpha - go ahead and release as 9.0.0.M12
> 
> -
> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
> For additional commands, e-mail: dev-h...@tomcat.apache.org
> 


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r16826 - in /dev/tomcat: tomcat-8/v8.5.7/ tomcat-9/v9.0.0.M12/

2016-11-03 Thread markt
Author: markt
Date: Thu Nov  3 20:30:13 2016
New Revision: 16826

Log:
Drop after cancelled votes

Removed:
dev/tomcat/tomcat-8/v8.5.7/
dev/tomcat/tomcat-9/v9.0.0.M12/


-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1767967 - /tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml

2016-11-03 Thread markt
Author: markt
Date: Thu Nov  3 20:33:18 2016
New Revision: 1767967

URL: http://svn.apache.org/viewvc?rev=1767967&view=rev
Log:
8.5.7 won't be released

Modified:
tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml

Modified: tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml?rev=1767967&r1=1767966&r2=1767967&view=diff
==
--- tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/tc8.5.x/trunk/webapps/docs/changelog.xml Thu Nov  3 20:33:18 2016
@@ -54,7 +54,7 @@
 
   
 
-
+
   
 
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1767966 - /tomcat/trunk/webapps/docs/changelog.xml

2016-11-03 Thread markt
Author: markt
Date: Thu Nov  3 20:32:57 2016
New Revision: 1767966

URL: http://svn.apache.org/viewvc?rev=1767966&view=rev
Log:
M12 won't be released

Modified:
tomcat/trunk/webapps/docs/changelog.xml

Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1767966&r1=1767965&r2=1767966&view=diff
==
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Thu Nov  3 20:32:57 2016
@@ -54,7 +54,7 @@
 
   
 
-
+
   
 
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 60333] inconsistency in folder name from webapps to work folder

2016-11-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60333

Prahalad Prabhakar  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|INVALID |---

--- Comment #2 from Prahalad Prabhakar  ---
Hi,

Due to larger file size the war didn't upload properly.
Kindly use the following URL for the sample war file - 

https://drive.google.com/file/d/0B98HdOP1i77Fd3NSNjVOd0RnbXM/view?usp=sharing


Upon placing the war file namely GTC#bridge.war in webapps , it first unpacks
the war with its contents with the exact same name.

Next in work folder it created a folder with same name ( GTC#bridge ).

However the same is not observed in tomcat 7.0.67.

Only from versions 8.0.1 onwards this is seen.

While placing the same war in tomcat 7.0.67 it unpacks the war with the same
name in webapps.

But in work folder , it renames the folder from GTC#bridge to GTC_bridge with
the exact same contents.

Herein lies what i preceive is the bug.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 60333] inconsistency in folder name from webapps to work folder

2016-11-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60333

Mark Thomas  changed:

   What|Removed |Added

 Resolution|--- |INVALID
 Status|REOPENED|RESOLVED

--- Comment #3 from Mark Thomas  ---
Tomcat is free to structure the work directory any way it pleases. The 8.0.x
behaviour is by design.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1767969 - in /tomcat/tags/TOMCAT_9_0_0_M13: ./ build.properties.default webapps/docs/changelog.xml

2016-11-03 Thread markt
Author: markt
Date: Thu Nov  3 20:52:15 2016
New Revision: 1767969

URL: http://svn.apache.org/viewvc?rev=1767969&view=rev
Log:
Tag 9.0.0.M13

Added:
tomcat/tags/TOMCAT_9_0_0_M13/
  - copied from r1767968, tomcat/trunk/
Modified:
tomcat/tags/TOMCAT_9_0_0_M13/build.properties.default
tomcat/tags/TOMCAT_9_0_0_M13/webapps/docs/changelog.xml

Modified: tomcat/tags/TOMCAT_9_0_0_M13/build.properties.default
URL: 
http://svn.apache.org/viewvc/tomcat/tags/TOMCAT_9_0_0_M13/build.properties.default?rev=1767969&r1=1767968&r2=1767969&view=diff
==
--- tomcat/tags/TOMCAT_9_0_0_M13/build.properties.default (original)
+++ tomcat/tags/TOMCAT_9_0_0_M13/build.properties.default Thu Nov  3 20:52:15 
2016
@@ -27,7 +27,7 @@ version.major=9
 version.minor=0
 version.build=0
 version.patch=0
-version.suffix=.M13-dev
+version.suffix=.M13
 
 # - Build control flags -
 # Note enabling validation uses Checkstyle which is LGPL licensed

Modified: tomcat/tags/TOMCAT_9_0_0_M13/webapps/docs/changelog.xml
URL: 
http://svn.apache.org/viewvc/tomcat/tags/TOMCAT_9_0_0_M13/webapps/docs/changelog.xml?rev=1767969&r1=1767968&r2=1767969&view=diff
==
--- tomcat/tags/TOMCAT_9_0_0_M13/webapps/docs/changelog.xml (original)
+++ tomcat/tags/TOMCAT_9_0_0_M13/webapps/docs/changelog.xml Thu Nov  3 20:52:15 
2016
@@ -44,7 +44,7 @@
   They eventually become mixed with the numbered issues. (I.e., numbered
   issues do not "pop up" wrt. others).
 -->
-
+
   
 
   



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1767970 - in /tomcat/tc8.5.x/trunk: build.properties.default res/maven/mvn.properties.default

2016-11-03 Thread markt
Author: markt
Date: Thu Nov  3 20:54:52 2016
New Revision: 1767970

URL: http://svn.apache.org/viewvc?rev=1767970&view=rev
Log:
Increment version for next release

Modified:
tomcat/tc8.5.x/trunk/build.properties.default
tomcat/tc8.5.x/trunk/res/maven/mvn.properties.default

Modified: tomcat/tc8.5.x/trunk/build.properties.default
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/build.properties.default?rev=1767970&r1=1767969&r2=1767970&view=diff
==
--- tomcat/tc8.5.x/trunk/build.properties.default (original)
+++ tomcat/tc8.5.x/trunk/build.properties.default Thu Nov  3 20:54:52 2016
@@ -25,7 +25,7 @@
 # - Version Control Flags -
 version.major=8
 version.minor=5
-version.build=7
+version.build=8
 version.patch=0
 version.suffix=-dev
 

Modified: tomcat/tc8.5.x/trunk/res/maven/mvn.properties.default
URL: 
http://svn.apache.org/viewvc/tomcat/tc8.5.x/trunk/res/maven/mvn.properties.default?rev=1767970&r1=1767969&r2=1767970&view=diff
==
--- tomcat/tc8.5.x/trunk/res/maven/mvn.properties.default (original)
+++ tomcat/tc8.5.x/trunk/res/maven/mvn.properties.default Thu Nov  3 20:54:52 
2016
@@ -35,7 +35,7 @@ maven.asf.release.repo.url=https://repos
 maven.asf.release.repo.repositoryId=apache.releases
 
 # Release version info
-maven.asf.release.deploy.version=8.5.7
+maven.asf.release.deploy.version=8.5.8
 
 #Where do we load the libraries from
 tomcat.lib.path=../../output/build/lib



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r1767971 - in /tomcat/tc8.5.x/tags/TOMCAT_8_5_8: ./ build.properties.default webapps/docs/changelog.xml

2016-11-03 Thread markt
Author: markt
Date: Thu Nov  3 20:56:24 2016
New Revision: 1767971

URL: http://svn.apache.org/viewvc?rev=1767971&view=rev
Log:
Tag 8.5.8

Added:
tomcat/tc8.5.x/tags/TOMCAT_8_5_8/   (props changed)
  - copied from r1767970, tomcat/tc8.5.x/trunk/
Modified:
tomcat/tc8.5.x/tags/TOMCAT_8_5_8/build.properties.default
tomcat/tc8.5.x/tags/TOMCAT_8_5_8/webapps/docs/changelog.xml

Propchange: tomcat/tc8.5.x/tags/TOMCAT_8_5_8/
--
bugtraq:append = false

Propchange: tomcat/tc8.5.x/tags/TOMCAT_8_5_8/
--
bugtraq:label = Bugzilla ID (optional)

Propchange: tomcat/tc8.5.x/tags/TOMCAT_8_5_8/
--
--- bugtraq:logregex (added)
+++ bugtraq:logregex Thu Nov  3 20:56:24 2016
@@ -0,0 +1,2 @@
+(https?\://(bz|issues)\.apache\.org/bugzilla/show_bug.cgi\?id=\d+|BZ\s?\d+)
+(\d+)

Propchange: tomcat/tc8.5.x/tags/TOMCAT_8_5_8/
--
bugtraq:message = Fix https://bz.apache.org/bugzilla/show_bug.cgi?id=%BUGID%

Propchange: tomcat/tc8.5.x/tags/TOMCAT_8_5_8/
--
bugtraq:url = https://bz.apache.org/bugzilla/show_bug.cgi?id=%BUGID%

Propchange: tomcat/tc8.5.x/tags/TOMCAT_8_5_8/
--
--- svn:ignore (added)
+++ svn:ignore Thu Nov  3 20:56:24 2016
@@ -0,0 +1,7 @@
+.*
+build.properties
+logs
+nbproject
+output
+work
+*.iml

Propchange: tomcat/tc8.5.x/tags/TOMCAT_8_5_8/
--
--- svn:mergeinfo (added)
+++ svn:mergeinfo Thu Nov  3 20:56:24 2016
@@ -0,0 +1 @@
+/tomcat/trunk:1734785,1734799,1734845,1734928,1735041,1735044,1735480,1735577,1735597,1735599-1735600,1735615,1736145,1736162,1736209,1736280,1736297,1736299,1736489,1736646,1736703,1736836,1736849,1737104-1737105,1737112,1737117,1737119-1737120,1737155,1737157,1737192,1737280,1737339,1737632,1737664,1737715,1737748,1737785,1737834,1737860,1737903,1737959,1738005,1738007,1738014-1738015,1738018,1738022,1738039,1738043,1738059-1738060,1738147,1738149,1738174-1738175,1738261,1738589,1738623-1738625,1738643,1738816,1738850,1738855,1738946-1738948,1738953-1738954,1738979,1738982,1739079-1739081,1739087,1739113,1739153,1739172,1739176,1739191,1739474,1739726,1739762,1739775,1739814,1739817-1739818,1739975,1740131,1740324,1740465,1740495,1740508-1740509,1740520,1740535,1740707,1740803,1740810,1740969,1740980,1740991,1740997,1741015,1741033,1741036,1741058,1741060,1741080,1741147,1741159,1741164,1741173,1741181,1741190,1741197,1741202,1741208,1741213,1741221,1741225,1741232,1741409,1741501
 
,1741677,1741892,1741896,1741984,1742023,1742042,1742071,1742090,1742093,1742101,1742105,1742111,1742139,1742146,1742148,1742166,1742181,1742184,1742187,1742246,1742248-1742251,1742263-1742264,1742268,1742276,1742369,1742387,1742448,1742509-1742512,1742917,1742919,1742933,1742975-1742976,1742984,1742986,1743019,1743115,1743117,1743124-1743125,1743134,1743425,1743554,1743679,1743696-1743698,1743700-1743701,1744058,1744064-1744065,1744125,1744194,1744229,1744270,1744323,1744432,1744684,1744697,1744705,1744713,1744760,1744786,1745083,1745142-1745143,1745145,1745177,1745179-1745180,1745227,1745248,1745254,1745337,1745467,1745473,1745576,1745735,1745744,1746304,1746306-1746307,1746319,1746327,1746338,1746340-1746341,1746344,1746427,1746441,1746473,1746490,1746492,1746495-1746496,1746499-1746501,1746503-1746507,1746509,1746549,1746551,1746554,1746556,1746558,1746584,1746620,1746649,1746724,1746939,1746989,1747014,1747028,1747035,1747210,1747225,1747234,1747253,1747404,1747506,1747536,1747
 
924,1747980,1747993,1748001,1748253,1748452,1748547,1748629,1748676,1748715,1749287,1749296,1749328,1749373,1749465,1749506,1749508,1749665-1749666,1749763,1749865-1749866,1749898,1749978,1749980,1750011,1750015,1750056,1750480,1750617,1750634,1750692,1750697,1750700,1750703,1750707,1750714,1750718,1750723,1750774,1750899,1750975,1750995,1751061,1751097,1751173,1751438,1751447,1751463,1751702,1752212,1752737,1752745,1753078,1753080,1753358,1753363,1754111,1754140-1754141,1754281,1754310,1754445,1754467,1754494,1754496,1754528,1754532-1754533,1754613,1754714,1754874,1754941,1754944,1754950-1754951,1755005,1755007,1755009,1755132,1755180-1755181,1755185,1755190,1755204-1755206,1755208,1755214,1755224,1755227,1755230,1755629,1755646-1755647,1755650,1755653,1755675,1755680,1755683,1755693,1755717,1755731-1755737,1755812,1755828,1755884,1755890,1755918-1755919,1755942,1755958,1755960,1755970,1755993,1756013,1756019,1756039,1756056,1756083-1756114,1756175,1756288-1756289,1756408-1756410,1
 
756778,1756798,1756878,1756898,1756939,1757123-1757124,1757126,1757128,1757132-1757133,1757136,1757145,17

[Bug 60333] inconsistency in folder name from webapps to work folder

2016-11-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60333

Prahalad Prabhakar  changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|INVALID |---

--- Comment #4 from Prahalad Prabhakar  ---
Hi

That's is a fair point you have made . 

Let me lay a little context here, as to how this design change is impacting us.

We use Equinox OSGI packages within our war for creating self sustained
components.

Equinox OSGI however has a restriction on the folder name with the special
charecter ( the likes of % and # ) and each time it encounters these charecters
it would not begin and hence cause none of our components to load leading a
failure of deployment.

However since until tomcat 7.0.67 the application folder name in work directory
automatically replaced the '#' with an "_" it did not cause any problems.

However with the new design in tomcat 8.0.1 onwards this behavior is not
observed causing our application to fail.

Kindly provide us an official release notes in this regard.

Thanks,
Prahalad.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 60333] inconsistency in folder name from webapps to work folder

2016-11-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60333

Mark Thomas  changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution|--- |INVALID

--- Comment #5 from Mark Thomas  ---
It is in the 8.0.x changelog. Bug 54708.

Please stop re-opening this issue. The implementation isn't going to change.
The primary reason is that using '_' has the potential for conflicts since
foo_bar.war is a valid WAR name and that would conflict with foo#bar.war if '#'
was replaced with '_'

If Equinox can't handle file paths with '#' (I suspect because those characters
need to be encoded in URLs) then that is a bug that needs to be fixed in
Equinox.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 60333] inconsistency in folder name from webapps to work folder

2016-11-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60333

--- Comment #6 from Christopher Schultz  ---
One weird consequence of using # in path names is just that: if they are used
in URLs (e.g. ClassLoader.getResource()), they can fail because the # does
funny things. I haven't done extensive testing, but I would hope at least that
ServletContext.getResource() would return a URL that does not throw an error or
fail to load the file due to a # present in the path.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[Bug 60333] inconsistency in folder name from webapps to work folder

2016-11-03 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=60333

--- Comment #7 from Prahalad Prabhakar  ---
Thanks for the speedy updates.

-- 
You are receiving this mail because:
You are the assignee for the bug.
-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r16827 [2/2] - in /dev/tomcat/tomcat-9/v9.0.0.M13: ./ bin/ bin/embed/ bin/extras/ src/

2016-11-03 Thread markt
Added: dev/tomcat/tomcat-9/v9.0.0.M13/src/apache-tomcat-9.0.0.M13-src.tar.gz.asc
==
--- dev/tomcat/tomcat-9/v9.0.0.M13/src/apache-tomcat-9.0.0.M13-src.tar.gz.asc 
(added)
+++ dev/tomcat/tomcat-9/v9.0.0.M13/src/apache-tomcat-9.0.0.M13-src.tar.gz.asc 
Thu Nov  3 21:27:18 2016
@@ -0,0 +1,17 @@
+-BEGIN PGP SIGNATURE-
+Version: GnuPG v2
+
+iQIcBAABCAAGBQJYG6ZqAAoJEBDAHFovYFnnfRgP/1QK5Aehfz5D5AXyagTGeF6j
+hBx76FD9hkngvpIqAdLWbe/Lz02DkLh2jw/dJtD0tZwwBDoQ9uXaTcoDtb9CfjLf
+jaeRptpEVFIPOS6VWwXRIjXpo10uQ+63a9cr4blJsGpy1c8yb2G4dYsb5Eap0h+r
+6Czst157PdBWHT+AjTxB58zjb+af7vXQGBXTizZB5bncsXa2snS7sP3eSbKARJ/5
+ZGzOhWzqg66c0wCHFU1UJ6LumGSqlQ5qnA1dh28JDQwnIKzjVtbMLEC8vBwyA+6r
+VEC0zKlTdVHfljxkWZuwUBOaOUa9EyHy3OcVQL6xLOv31/YoZPR03LkrqI/0IZKo
+pZGedvIu3Bgs2gSd4Ded0ziPwtK0O3Tx9Cf+JYwZLmhtEoNxNguinSww0PwFTWcg
+FoXrOjqZFoSHtSRcX+aOcjp0bt0vBTbNOCNc9kV7nZ+hk2JUlQg8Qg7RV5/ReULl
+vt1Qmr4hhGBpQrkbiCGU2T22BqhIJi5n2VN9TxL1Z6KEzfSNiGszXTiGRhVfX7JY
+lnR0RIhdIeqT9q+W7KOK2eR53PQOKDF99uuXl+fNKMXnucNQ25BI27WBjC/Ajq2w
+dGBKZtw7ul01x+c6Lj6q5hBlHAfll83NSLQ/rgMhmmjzEi9yAS+iGcHojWjFFTGv
+0TaIpupUhH3dKI0Mq4Hw
+=jisX
+-END PGP SIGNATURE-

Added: dev/tomcat/tomcat-9/v9.0.0.M13/src/apache-tomcat-9.0.0.M13-src.tar.gz.md5
==
--- dev/tomcat/tomcat-9/v9.0.0.M13/src/apache-tomcat-9.0.0.M13-src.tar.gz.md5 
(added)
+++ dev/tomcat/tomcat-9/v9.0.0.M13/src/apache-tomcat-9.0.0.M13-src.tar.gz.md5 
Thu Nov  3 21:27:18 2016
@@ -0,0 +1 @@
+f9775f0131efa30ef37ea274c6dd1964 *apache-tomcat-9.0.0.M13-src.tar.gz
\ No newline at end of file

Added: 
dev/tomcat/tomcat-9/v9.0.0.M13/src/apache-tomcat-9.0.0.M13-src.tar.gz.sha1
==
--- dev/tomcat/tomcat-9/v9.0.0.M13/src/apache-tomcat-9.0.0.M13-src.tar.gz.sha1 
(added)
+++ dev/tomcat/tomcat-9/v9.0.0.M13/src/apache-tomcat-9.0.0.M13-src.tar.gz.sha1 
Thu Nov  3 21:27:18 2016
@@ -0,0 +1 @@
+e3d1a45517728d46649bb821f032a344a605 *apache-tomcat-9.0.0.M13-src.tar.gz
\ No newline at end of file

Added: dev/tomcat/tomcat-9/v9.0.0.M13/src/apache-tomcat-9.0.0.M13-src.zip
==
Binary file - no diff available.

Propchange: dev/tomcat/tomcat-9/v9.0.0.M13/src/apache-tomcat-9.0.0.M13-src.zip
--
svn:mime-type = application/octet-stream

Added: dev/tomcat/tomcat-9/v9.0.0.M13/src/apache-tomcat-9.0.0.M13-src.zip.asc
==
--- dev/tomcat/tomcat-9/v9.0.0.M13/src/apache-tomcat-9.0.0.M13-src.zip.asc 
(added)
+++ dev/tomcat/tomcat-9/v9.0.0.M13/src/apache-tomcat-9.0.0.M13-src.zip.asc Thu 
Nov  3 21:27:18 2016
@@ -0,0 +1,17 @@
+-BEGIN PGP SIGNATURE-
+Version: GnuPG v2
+
+iQIcBAABCAAGBQJYG6ZVAAoJEBDAHFovYFnnpB8P/2O3k9Mb6YJ09XQZloVSpeLh
+QQ9QV6I91/gTBK+zg88nBpy7/hn3oQ7p/NoViE7pCULUcMsjM5IuKoN7bS9p5zTO
+skTkeR/Sve+bcX1lMbBNudk4wBhF5KHe598oa9Y5r63A8o3AHefBAhmaftlXPaMd
+/nr0HgyYRw/EZNCcd8JUkK76mzZxmApeI0Tkcn9f0h8RARagwLkomvomkwQaZsuW
+f/l+F+M0MYSKKPqKv/e6CsHMcAYgDT94rS+DxFx8V4MWnmXAcsDVgU6UF6SkqFyo
+q93kZi0485yxACrj/HgbNF9JxHMmVAZLLYym0ts+dp1MuNvcIyp6JqRQchenWP7t
+c8X607X896vNCuYK5WWC5peid5sIduxNLt2Nybmnv3RW0C1JkXLJaE5C32lVEmlm
+uGDTZ04ZzJz8yTsAPB2h8uvA9TCgAS524Y23dZagZe5kkIIwcL6hp4B5fsqmixxX
+FUj3m9CdjY7SFXZs9FCpnDNv3uliuP3yfx0uViXzfc51JNILjqY5ZBiHquPU8T9j
+LWzeUMaVk+fvttm/2+IBRyPpC7qNDOTHyo8XE+iMuIo71zGOiX9xHmebzDwoDlEy
+GGp++cpGeo9G3efjLDFQQMavr+tTPd5hdGQjthCAxnHHAqqMJkBGP4uzht9eVkGX
+BjpPrLByDiBWr+w/qP7r
+=l27T
+-END PGP SIGNATURE-

Added: dev/tomcat/tomcat-9/v9.0.0.M13/src/apache-tomcat-9.0.0.M13-src.zip.md5
==
--- dev/tomcat/tomcat-9/v9.0.0.M13/src/apache-tomcat-9.0.0.M13-src.zip.md5 
(added)
+++ dev/tomcat/tomcat-9/v9.0.0.M13/src/apache-tomcat-9.0.0.M13-src.zip.md5 Thu 
Nov  3 21:27:18 2016
@@ -0,0 +1 @@
+3d4b960d06e96cab74bd1df6c113903c *apache-tomcat-9.0.0.M13-src.zip
\ No newline at end of file

Added: dev/tomcat/tomcat-9/v9.0.0.M13/src/apache-tomcat-9.0.0.M13-src.zip.sha1
==
--- dev/tomcat/tomcat-9/v9.0.0.M13/src/apache-tomcat-9.0.0.M13-src.zip.sha1 
(added)
+++ dev/tomcat/tomcat-9/v9.0.0.M13/src/apache-tomcat-9.0.0.M13-src.zip.sha1 Thu 
Nov  3 21:27:18 2016
@@ -0,0 +1 @@
+022a733fe6765158581cd36bf1a643bb93d687dd *apache-tomcat-9.0.0.M13-src.zip
\ No newline at end of file



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r16827 [1/2] - in /dev/tomcat/tomcat-9/v9.0.0.M13: ./ bin/ bin/embed/ bin/extras/ src/

2016-11-03 Thread markt
Author: markt
Date: Thu Nov  3 21:27:18 2016
New Revision: 16827

Log:
Upload 9.0.0.M13 for voting

Added:
dev/tomcat/tomcat-9/v9.0.0.M13/
dev/tomcat/tomcat-9/v9.0.0.M13/KEYS   (with props)
dev/tomcat/tomcat-9/v9.0.0.M13/README.html   (with props)
dev/tomcat/tomcat-9/v9.0.0.M13/RELEASE-NOTES
dev/tomcat/tomcat-9/v9.0.0.M13/bin/
dev/tomcat/tomcat-9/v9.0.0.M13/bin/README.html   (with props)
dev/tomcat/tomcat-9/v9.0.0.M13/bin/apache-tomcat-9.0.0.M13-deployer.tar.gz  
 (with props)

dev/tomcat/tomcat-9/v9.0.0.M13/bin/apache-tomcat-9.0.0.M13-deployer.tar.gz.asc

dev/tomcat/tomcat-9/v9.0.0.M13/bin/apache-tomcat-9.0.0.M13-deployer.tar.gz.md5

dev/tomcat/tomcat-9/v9.0.0.M13/bin/apache-tomcat-9.0.0.M13-deployer.tar.gz.sha1
dev/tomcat/tomcat-9/v9.0.0.M13/bin/apache-tomcat-9.0.0.M13-deployer.zip   
(with props)
dev/tomcat/tomcat-9/v9.0.0.M13/bin/apache-tomcat-9.0.0.M13-deployer.zip.asc
dev/tomcat/tomcat-9/v9.0.0.M13/bin/apache-tomcat-9.0.0.M13-deployer.zip.md5
dev/tomcat/tomcat-9/v9.0.0.M13/bin/apache-tomcat-9.0.0.M13-deployer.zip.sha1
dev/tomcat/tomcat-9/v9.0.0.M13/bin/apache-tomcat-9.0.0.M13-fulldocs.tar.gz  
 (with props)

dev/tomcat/tomcat-9/v9.0.0.M13/bin/apache-tomcat-9.0.0.M13-fulldocs.tar.gz.asc

dev/tomcat/tomcat-9/v9.0.0.M13/bin/apache-tomcat-9.0.0.M13-fulldocs.tar.gz.md5

dev/tomcat/tomcat-9/v9.0.0.M13/bin/apache-tomcat-9.0.0.M13-fulldocs.tar.gz.sha1
dev/tomcat/tomcat-9/v9.0.0.M13/bin/apache-tomcat-9.0.0.M13-windows-x64.zip  
 (with props)

dev/tomcat/tomcat-9/v9.0.0.M13/bin/apache-tomcat-9.0.0.M13-windows-x64.zip.asc

dev/tomcat/tomcat-9/v9.0.0.M13/bin/apache-tomcat-9.0.0.M13-windows-x64.zip.md5

dev/tomcat/tomcat-9/v9.0.0.M13/bin/apache-tomcat-9.0.0.M13-windows-x64.zip.sha1
dev/tomcat/tomcat-9/v9.0.0.M13/bin/apache-tomcat-9.0.0.M13-windows-x86.zip  
 (with props)

dev/tomcat/tomcat-9/v9.0.0.M13/bin/apache-tomcat-9.0.0.M13-windows-x86.zip.asc

dev/tomcat/tomcat-9/v9.0.0.M13/bin/apache-tomcat-9.0.0.M13-windows-x86.zip.md5

dev/tomcat/tomcat-9/v9.0.0.M13/bin/apache-tomcat-9.0.0.M13-windows-x86.zip.sha1
dev/tomcat/tomcat-9/v9.0.0.M13/bin/apache-tomcat-9.0.0.M13.exe   (with 
props)
dev/tomcat/tomcat-9/v9.0.0.M13/bin/apache-tomcat-9.0.0.M13.exe.asc
dev/tomcat/tomcat-9/v9.0.0.M13/bin/apache-tomcat-9.0.0.M13.exe.md5
dev/tomcat/tomcat-9/v9.0.0.M13/bin/apache-tomcat-9.0.0.M13.exe.sha1
dev/tomcat/tomcat-9/v9.0.0.M13/bin/apache-tomcat-9.0.0.M13.tar.gz   (with 
props)
dev/tomcat/tomcat-9/v9.0.0.M13/bin/apache-tomcat-9.0.0.M13.tar.gz.asc
dev/tomcat/tomcat-9/v9.0.0.M13/bin/apache-tomcat-9.0.0.M13.tar.gz.md5
dev/tomcat/tomcat-9/v9.0.0.M13/bin/apache-tomcat-9.0.0.M13.tar.gz.sha1
dev/tomcat/tomcat-9/v9.0.0.M13/bin/apache-tomcat-9.0.0.M13.zip   (with 
props)
dev/tomcat/tomcat-9/v9.0.0.M13/bin/apache-tomcat-9.0.0.M13.zip.asc
dev/tomcat/tomcat-9/v9.0.0.M13/bin/apache-tomcat-9.0.0.M13.zip.md5
dev/tomcat/tomcat-9/v9.0.0.M13/bin/apache-tomcat-9.0.0.M13.zip.sha1
dev/tomcat/tomcat-9/v9.0.0.M13/bin/embed/

dev/tomcat/tomcat-9/v9.0.0.M13/bin/embed/apache-tomcat-9.0.0.M13-embed.tar.gz   
(with props)

dev/tomcat/tomcat-9/v9.0.0.M13/bin/embed/apache-tomcat-9.0.0.M13-embed.tar.gz.asc

dev/tomcat/tomcat-9/v9.0.0.M13/bin/embed/apache-tomcat-9.0.0.M13-embed.tar.gz.md5

dev/tomcat/tomcat-9/v9.0.0.M13/bin/embed/apache-tomcat-9.0.0.M13-embed.tar.gz.sha1
dev/tomcat/tomcat-9/v9.0.0.M13/bin/embed/apache-tomcat-9.0.0.M13-embed.zip  
 (with props)

dev/tomcat/tomcat-9/v9.0.0.M13/bin/embed/apache-tomcat-9.0.0.M13-embed.zip.asc

dev/tomcat/tomcat-9/v9.0.0.M13/bin/embed/apache-tomcat-9.0.0.M13-embed.zip.md5

dev/tomcat/tomcat-9/v9.0.0.M13/bin/embed/apache-tomcat-9.0.0.M13-embed.zip.sha1
dev/tomcat/tomcat-9/v9.0.0.M13/bin/extras/
dev/tomcat/tomcat-9/v9.0.0.M13/bin/extras/catalina-jmx-remote.jar   (with 
props)
dev/tomcat/tomcat-9/v9.0.0.M13/bin/extras/catalina-jmx-remote.jar.asc
dev/tomcat/tomcat-9/v9.0.0.M13/bin/extras/catalina-jmx-remote.jar.md5
dev/tomcat/tomcat-9/v9.0.0.M13/bin/extras/catalina-jmx-remote.jar.sha1
dev/tomcat/tomcat-9/v9.0.0.M13/bin/extras/catalina-ws.jar   (with props)
dev/tomcat/tomcat-9/v9.0.0.M13/bin/extras/catalina-ws.jar.asc
dev/tomcat/tomcat-9/v9.0.0.M13/bin/extras/catalina-ws.jar.md5
dev/tomcat/tomcat-9/v9.0.0.M13/bin/extras/catalina-ws.jar.sha1
dev/tomcat/tomcat-9/v9.0.0.M13/src/
dev/tomcat/tomcat-9/v9.0.0.M13/src/apache-tomcat-9.0.0.M13-src.tar.gz   
(with props)
dev/tomcat/tomcat-9/v9.0.0.M13/src/apache-tomcat-9.0.0.M13-src.tar.gz.asc
dev/tomcat/tomcat-9/v9.0.0.M13/src/apache-tomcat-9.0.0.M13-src.tar.gz.md5
dev/tomcat/tomcat-9/v9.0.0.M13/src/apache-tomcat-9.0.0.M13-src.tar.gz.sha1
dev/tomcat/tomcat-9/v9.0.0.M13/src/apache-tomcat-9.0.0.M13-src.zip   (with 
props)
dev/tomcat/tomcat-9/v9.0.0.M13/src/apache-tomcat-9.0.0.M13-src.zip.asc
dev/tomcat/tomcat-9/v9.0.0.M13/src/apa

[VOTE] Release Apache Tomcat 9.0.0.M13

2016-11-03 Thread Mark Thomas
The proposed Apache Tomcat 9.0.0.M13 release is now available for voting.

This is a milestone release for the 9.0.x branch. It should be
noted that, as a milestone release:
- Servlet 4.0 is not finalised
- The EGs have not started work on JSP 2.4, EL 3.1 or WebSocket 1.2/2.0

9.0.0.M13 corrects a regression reported in 9.0.0.M12.

The major changes compared to the 9.0.0.M11 release are:

- Implement header limits for HTTP/2

- Improve handling of I/O errors with async processing

- Fail earlier on invalid HTTP requests

Along with lots of other bug fixes and improvements

For full details, see the changelog:
http://svn.apache.org/repos/asf/tomcat/trunk/webapps/docs/changelog.xml

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-9/v9.0.0.M13/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1103/
The svn tag is:
http://svn.apache.org/repos/asf/tomcat/tags/TOMCAT_9_0_0_M13/

The proposed 9.0.0.M13 release is:
[ ] Broken - do not release
[ ] Alpha - go ahead and release as 9.0.0.M13

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



[VOTE] Release Apache Tomcat 8.5.8

2016-11-03 Thread Mark Thomas
The proposed Apache Tomcat 8.5.8 release is now available for voting.

8.5.8 corrects a regression 8.5.7.

The major changes compared to the 8.5.6 release are:

- Implement header limits for HTTP/2

- Improve handling of I/O errors with async processing

- Fail earlier on invalid HTTP requests

It can be obtained from:
https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.8/
The Maven staging repo is:
https://repository.apache.org/content/repositories/orgapachetomcat-1104/
The svn tag is:
http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_8/

The proposed 8.5.8 release is:
[ ] Broken - do not release
[ ] Stable - go ahead and release as 8.5.8

-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org



svn commit: r16828 [1/2] - in /dev/tomcat/tomcat-8/v8.5.8: ./ bin/ bin/embed/ bin/extras/ src/

2016-11-03 Thread markt
Author: markt
Date: Thu Nov  3 21:49:51 2016
New Revision: 16828

Log:
Upload 8.5.8 for voting

Added:
dev/tomcat/tomcat-8/v8.5.8/
dev/tomcat/tomcat-8/v8.5.8/KEYS   (with props)
dev/tomcat/tomcat-8/v8.5.8/README.html   (with props)
dev/tomcat/tomcat-8/v8.5.8/RELEASE-NOTES
dev/tomcat/tomcat-8/v8.5.8/bin/
dev/tomcat/tomcat-8/v8.5.8/bin/README.html   (with props)
dev/tomcat/tomcat-8/v8.5.8/bin/apache-tomcat-8.5.8-deployer.tar.gz   (with 
props)
dev/tomcat/tomcat-8/v8.5.8/bin/apache-tomcat-8.5.8-deployer.tar.gz.asc
dev/tomcat/tomcat-8/v8.5.8/bin/apache-tomcat-8.5.8-deployer.tar.gz.md5
dev/tomcat/tomcat-8/v8.5.8/bin/apache-tomcat-8.5.8-deployer.tar.gz.sha1
dev/tomcat/tomcat-8/v8.5.8/bin/apache-tomcat-8.5.8-deployer.zip   (with 
props)
dev/tomcat/tomcat-8/v8.5.8/bin/apache-tomcat-8.5.8-deployer.zip.asc
dev/tomcat/tomcat-8/v8.5.8/bin/apache-tomcat-8.5.8-deployer.zip.md5
dev/tomcat/tomcat-8/v8.5.8/bin/apache-tomcat-8.5.8-deployer.zip.sha1
dev/tomcat/tomcat-8/v8.5.8/bin/apache-tomcat-8.5.8-fulldocs.tar.gz   (with 
props)
dev/tomcat/tomcat-8/v8.5.8/bin/apache-tomcat-8.5.8-fulldocs.tar.gz.asc
dev/tomcat/tomcat-8/v8.5.8/bin/apache-tomcat-8.5.8-fulldocs.tar.gz.md5
dev/tomcat/tomcat-8/v8.5.8/bin/apache-tomcat-8.5.8-fulldocs.tar.gz.sha1
dev/tomcat/tomcat-8/v8.5.8/bin/apache-tomcat-8.5.8-windows-x64.zip   (with 
props)
dev/tomcat/tomcat-8/v8.5.8/bin/apache-tomcat-8.5.8-windows-x64.zip.asc
dev/tomcat/tomcat-8/v8.5.8/bin/apache-tomcat-8.5.8-windows-x64.zip.md5
dev/tomcat/tomcat-8/v8.5.8/bin/apache-tomcat-8.5.8-windows-x64.zip.sha1
dev/tomcat/tomcat-8/v8.5.8/bin/apache-tomcat-8.5.8-windows-x86.zip   (with 
props)
dev/tomcat/tomcat-8/v8.5.8/bin/apache-tomcat-8.5.8-windows-x86.zip.asc
dev/tomcat/tomcat-8/v8.5.8/bin/apache-tomcat-8.5.8-windows-x86.zip.md5
dev/tomcat/tomcat-8/v8.5.8/bin/apache-tomcat-8.5.8-windows-x86.zip.sha1
dev/tomcat/tomcat-8/v8.5.8/bin/apache-tomcat-8.5.8.exe   (with props)
dev/tomcat/tomcat-8/v8.5.8/bin/apache-tomcat-8.5.8.exe.asc
dev/tomcat/tomcat-8/v8.5.8/bin/apache-tomcat-8.5.8.exe.md5
dev/tomcat/tomcat-8/v8.5.8/bin/apache-tomcat-8.5.8.exe.sha1
dev/tomcat/tomcat-8/v8.5.8/bin/apache-tomcat-8.5.8.tar.gz   (with props)
dev/tomcat/tomcat-8/v8.5.8/bin/apache-tomcat-8.5.8.tar.gz.asc
dev/tomcat/tomcat-8/v8.5.8/bin/apache-tomcat-8.5.8.tar.gz.md5
dev/tomcat/tomcat-8/v8.5.8/bin/apache-tomcat-8.5.8.tar.gz.sha1
dev/tomcat/tomcat-8/v8.5.8/bin/apache-tomcat-8.5.8.zip   (with props)
dev/tomcat/tomcat-8/v8.5.8/bin/apache-tomcat-8.5.8.zip.asc
dev/tomcat/tomcat-8/v8.5.8/bin/apache-tomcat-8.5.8.zip.md5
dev/tomcat/tomcat-8/v8.5.8/bin/apache-tomcat-8.5.8.zip.sha1
dev/tomcat/tomcat-8/v8.5.8/bin/embed/
dev/tomcat/tomcat-8/v8.5.8/bin/embed/apache-tomcat-8.5.8-embed.tar.gz   
(with props)
dev/tomcat/tomcat-8/v8.5.8/bin/embed/apache-tomcat-8.5.8-embed.tar.gz.asc
dev/tomcat/tomcat-8/v8.5.8/bin/embed/apache-tomcat-8.5.8-embed.tar.gz.md5
dev/tomcat/tomcat-8/v8.5.8/bin/embed/apache-tomcat-8.5.8-embed.tar.gz.sha1
dev/tomcat/tomcat-8/v8.5.8/bin/embed/apache-tomcat-8.5.8-embed.zip   (with 
props)
dev/tomcat/tomcat-8/v8.5.8/bin/embed/apache-tomcat-8.5.8-embed.zip.asc
dev/tomcat/tomcat-8/v8.5.8/bin/embed/apache-tomcat-8.5.8-embed.zip.md5
dev/tomcat/tomcat-8/v8.5.8/bin/embed/apache-tomcat-8.5.8-embed.zip.sha1
dev/tomcat/tomcat-8/v8.5.8/bin/extras/
dev/tomcat/tomcat-8/v8.5.8/bin/extras/catalina-jmx-remote.jar   (with props)
dev/tomcat/tomcat-8/v8.5.8/bin/extras/catalina-jmx-remote.jar.asc
dev/tomcat/tomcat-8/v8.5.8/bin/extras/catalina-jmx-remote.jar.md5
dev/tomcat/tomcat-8/v8.5.8/bin/extras/catalina-jmx-remote.jar.sha1
dev/tomcat/tomcat-8/v8.5.8/bin/extras/catalina-ws.jar   (with props)
dev/tomcat/tomcat-8/v8.5.8/bin/extras/catalina-ws.jar.asc
dev/tomcat/tomcat-8/v8.5.8/bin/extras/catalina-ws.jar.md5
dev/tomcat/tomcat-8/v8.5.8/bin/extras/catalina-ws.jar.sha1
dev/tomcat/tomcat-8/v8.5.8/src/
dev/tomcat/tomcat-8/v8.5.8/src/apache-tomcat-8.5.8-src.tar.gz   (with props)
dev/tomcat/tomcat-8/v8.5.8/src/apache-tomcat-8.5.8-src.tar.gz.asc
dev/tomcat/tomcat-8/v8.5.8/src/apache-tomcat-8.5.8-src.tar.gz.md5
dev/tomcat/tomcat-8/v8.5.8/src/apache-tomcat-8.5.8-src.tar.gz.sha1
dev/tomcat/tomcat-8/v8.5.8/src/apache-tomcat-8.5.8-src.zip   (with props)
dev/tomcat/tomcat-8/v8.5.8/src/apache-tomcat-8.5.8-src.zip.asc
dev/tomcat/tomcat-8/v8.5.8/src/apache-tomcat-8.5.8-src.zip.md5
dev/tomcat/tomcat-8/v8.5.8/src/apache-tomcat-8.5.8-src.zip.sha1

Added: dev/tomcat/tomcat-8/v8.5.8/KEYS
==
--- dev/tomcat/tomcat-8/v8.5.8/KEYS (added)
+++ dev/tomcat/tomcat-8/v8.5.8/KEYS Thu Nov  3 21:49:51 2016
@@ -0,0 +1,616 @@
+This file contains the PGP&GPG keys of various Apache developers.
+Please don't use them for email unless you have to. Their main

svn commit: r16828 [2/2] - in /dev/tomcat/tomcat-8/v8.5.8: ./ bin/ bin/embed/ bin/extras/ src/

2016-11-03 Thread markt
Propchange: dev/tomcat/tomcat-8/v8.5.8/src/apache-tomcat-8.5.8-src.zip
--
svn:mime-type = application/octet-stream

Added: dev/tomcat/tomcat-8/v8.5.8/src/apache-tomcat-8.5.8-src.zip.asc
==
--- dev/tomcat/tomcat-8/v8.5.8/src/apache-tomcat-8.5.8-src.zip.asc (added)
+++ dev/tomcat/tomcat-8/v8.5.8/src/apache-tomcat-8.5.8-src.zip.asc Thu Nov  3 
21:49:51 2016
@@ -0,0 +1,17 @@
+-BEGIN PGP SIGNATURE-
+Version: GnuPG v2
+
+iQIcBAABCAAGBQJYG6m6AAoJEBDAHFovYFnnHlkP/jvrX5dWG8Hu6Xg7fuzLobIV
+2GNe786SzZefHeqG84krd4ug3KRpOCzKDuy4ZzH7rVNULUfCkVF7osZAfHfuu9AD
+2K+q3dnjkvkWO/RfI50siAjN5M+FWBHHFO9tnR2jIh+wu4vDtZ5SidNvDwEczwB5
+z2IVWklr2KBgxL7phVoBm72c3Fayd5Ss4mCJMaewLPOZyL8vhBSrWRfcxt8Qpsd0
+cuSZtKeEs2MHBQl8/FF/5+lnRrjSR7T+XZfFa+mAxMAFD9doIGRIHsWrdoeKbnRU
+Q50TCDJrr9RJLzQPVy+t7X3wNbpMfxAYDflISaPR2z/b5hHRJds1hVb8RmGYPkLE
+IOWV9dzc435zwpT0Aj7VH1LcS6rmVugNZQceDn40yBPVF9pVsG5GkxtkDoxd8wbM
+KXqAwRI0HYG3t139rr/uMebEUpx+2TiDGG7Dm7Cgq1GvnZYjgNE9ZVSN1N9sK8oB
+d/OUhYMMhtB/lAd79yY7C3e3f0ksnXQILsMd9W/11ZKZ54HO4w+a/sbexZ+tJfAW
+eBvL6OhFTn1MV/KsaDLBZKh8w3VQ0YIWpbTsJhWLbac3yGff6zGSX0DTRA8GTDqG
+SLrMYvGwaO8Sr8ZFDTdbLwgXIVwjM4tYQc0OjpmtEbapOAT5zpcS2AHxi7sAqX5C
+iWwu3rCFDjGIR+qq+j61
+=MySA
+-END PGP SIGNATURE-

Added: dev/tomcat/tomcat-8/v8.5.8/src/apache-tomcat-8.5.8-src.zip.md5
==
--- dev/tomcat/tomcat-8/v8.5.8/src/apache-tomcat-8.5.8-src.zip.md5 (added)
+++ dev/tomcat/tomcat-8/v8.5.8/src/apache-tomcat-8.5.8-src.zip.md5 Thu Nov  3 
21:49:51 2016
@@ -0,0 +1 @@
+7d6f766607710ba89c25f9c4e07c63a1 *apache-tomcat-8.5.8-src.zip
\ No newline at end of file

Added: dev/tomcat/tomcat-8/v8.5.8/src/apache-tomcat-8.5.8-src.zip.sha1
==
--- dev/tomcat/tomcat-8/v8.5.8/src/apache-tomcat-8.5.8-src.zip.sha1 (added)
+++ dev/tomcat/tomcat-8/v8.5.8/src/apache-tomcat-8.5.8-src.zip.sha1 Thu Nov  3 
21:49:51 2016
@@ -0,0 +1 @@
+661ea1acf4a792ec594dfc0129eaffa0241c8165 *apache-tomcat-8.5.8-src.zip
\ No newline at end of file



-
To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org
For additional commands, e-mail: dev-h...@tomcat.apache.org