Am 3. November 2016 21:01:51 MEZ, schrieb Violeta Georgieva <miles...@gmail.com>: >Hi Felix, > >2016-11-03 20:24 GMT+02:00 Felix Schumacher < >felix.schumac...@internetallee.de>: >> >> Am 03.11.2016 um 15:49 schrieb Mark Thomas: >>> >>> On 03/11/2016 14:43, Felix Schumacher wrote: >>>> >>>> Hi all, >>>> >>>> change r1767357 broke ajp connector with an executor. >>>> >>>> Tomcat fails to set the thread priority, since the ajp connector >reports a default priority of -1 and Thread#setPriority will throw an >IAE >in line 583 of AbstractProtocol#start. >>>> >>>> To reproduce this enable the commented executor in server.xml and >add >that executor to the ajp connector. >>>> >>>> A second rather minor point is a white space policy violation in >webapps/docs/config/http2.xml:160. >>> >>> That almost certainly means 9.0.x is broken as well. >>> >>> I can re-roll once this is fixed. >>> >>> I'll be able to get to this in a few hours. If someone beats me to >the >>> fix, that would be great :) >> >> I have committed a fix for 9.0.0.M12 (which is affected as well - as >you >suspected). > >Do we need this fix in Tomcat 6/7/8.0?
I have had a short look at AbstractProtocol in tomcat 8.0 and couldn't find any reference to Thread#setPriority. So I think anything below 8.5 is safe. A test with modified server.xml worked correctly. Regards, Felix > >Thanks, >Violeta > >> Felix >> >>> >>> Mark >>> >>>> Regards, >>>> Felix >>>> >>>> Am 2. November 2016 15:15:03 MEZ, schrieb Mark Thomas ><ma...@apache.org >>: >>>>> >>>>> The proposed Apache Tomcat 8.5.7 release is now available for >voting. >>>>> >>>>> The major changes compared to the 8.5.6 release are: >>>>> >>>>> >>>>> - Implement header limits for HTTP/2 >>>>> >>>>> - Improve handling of I/O errors with async processing >>>>> >>>>> - Fail earlier on invalid HTTP requests >>>>> >>>>> It can be obtained from: >>>>> https://dist.apache.org/repos/dist/dev/tomcat/tomcat-8/v8.5.7/ >>>>> The Maven staging repo is: >>>>> >https://repository.apache.org/content/repositories/orgapachetomcat-1102/ >>>>> The svn tag is: >>>>> http://svn.apache.org/repos/asf/tomcat/tc8.5.x/tags/TOMCAT_8_5_7/ >>>>> >>>>> The proposed 8.5.7 release is: >>>>> [ ] Broken - do not release >>>>> [ ] Alpha - go ahead and release as 8.5.7 >>>>> [ ] Beta - go ahead and release as 8.5.7 >>>>> [ ] Stable - go ahead and release as 8.5.7 >>>>> >>>>> >--------------------------------------------------------------------- >>>>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >>>>> For additional commands, e-mail: dev-h...@tomcat.apache.org >>> >>> >>> >--------------------------------------------------------------------- >>> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >>> For additional commands, e-mail: dev-h...@tomcat.apache.org >>> >> >> >> --------------------------------------------------------------------- >> To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org >> For additional commands, e-mail: dev-h...@tomcat.apache.org >> --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@tomcat.apache.org For additional commands, e-mail: dev-h...@tomcat.apache.org